1 // SPDX-License-Identifier: MIT
3 * Copyright © 2018 Intel Corporation
9 #include "intel_display_types.h"
10 #include "intel_quirks.h"
12 static void intel_set_quirk(struct drm_i915_private *i915, enum intel_quirk_id quirk)
14 i915->display.quirks.mask |= BIT(quirk);
18 * Some machines (Lenovo U160) do not work with SSC on LVDS for some reason
20 static void quirk_ssc_force_disable(struct drm_i915_private *i915)
22 intel_set_quirk(i915, QUIRK_LVDS_SSC_DISABLE);
23 drm_info(&i915->drm, "applying lvds SSC disable quirk\n");
27 * A machine (e.g. Acer Aspire 5734Z) may need to invert the panel backlight
30 static void quirk_invert_brightness(struct drm_i915_private *i915)
32 intel_set_quirk(i915, QUIRK_INVERT_BRIGHTNESS);
33 drm_info(&i915->drm, "applying inverted panel brightness quirk\n");
36 /* Some VBT's incorrectly indicate no backlight is present */
37 static void quirk_backlight_present(struct drm_i915_private *i915)
39 intel_set_quirk(i915, QUIRK_BACKLIGHT_PRESENT);
40 drm_info(&i915->drm, "applying backlight present quirk\n");
43 /* Toshiba Satellite P50-C-18C requires T12 delay to be min 800ms
44 * which is 300 ms greater than eDP spec T12 min.
46 static void quirk_increase_t12_delay(struct drm_i915_private *i915)
48 intel_set_quirk(i915, QUIRK_INCREASE_T12_DELAY);
49 drm_info(&i915->drm, "Applying T12 delay quirk\n");
53 * GeminiLake NUC HDMI outputs require additional off time
54 * this allows the onboard retimer to correctly sync to signal
56 static void quirk_increase_ddi_disabled_time(struct drm_i915_private *i915)
58 intel_set_quirk(i915, QUIRK_INCREASE_DDI_DISABLED_TIME);
59 drm_info(&i915->drm, "Applying Increase DDI Disabled quirk\n");
62 static void quirk_no_pps_backlight_power_hook(struct drm_i915_private *i915)
64 intel_set_quirk(i915, QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK);
65 drm_info(&i915->drm, "Applying no pps backlight power quirk\n");
72 void (*hook)(struct drm_i915_private *i915);
75 /* For systems that don't have a meaningful PCI subdevice/subvendor ID */
76 struct intel_dmi_quirk {
77 void (*hook)(struct drm_i915_private *i915);
78 const struct dmi_system_id (*dmi_id_list)[];
81 static int intel_dmi_reverse_brightness(const struct dmi_system_id *id)
83 DRM_INFO("Backlight polarity reversed on %s\n", id->ident);
87 static int intel_dmi_no_pps_backlight(const struct dmi_system_id *id)
89 DRM_INFO("No pps backlight support on %s\n", id->ident);
93 static const struct intel_dmi_quirk intel_dmi_quirks[] = {
95 .dmi_id_list = &(const struct dmi_system_id[]) {
97 .callback = intel_dmi_reverse_brightness,
98 .ident = "NCR Corporation",
99 .matches = {DMI_MATCH(DMI_SYS_VENDOR, "NCR Corporation"),
100 DMI_MATCH(DMI_PRODUCT_NAME, ""),
104 .callback = intel_dmi_reverse_brightness,
105 .ident = "Thundersoft TST178 tablet",
106 /* DMI strings are too generic, also match on BIOS date */
107 .matches = {DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
108 DMI_EXACT_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
109 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
110 DMI_EXACT_MATCH(DMI_BIOS_DATE, "04/15/2014"),
113 { } /* terminating entry */
115 .hook = quirk_invert_brightness,
118 .dmi_id_list = &(const struct dmi_system_id[]) {
120 .callback = intel_dmi_no_pps_backlight,
121 .ident = "Google Lillipup sku524294",
122 .matches = {DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Google"),
123 DMI_EXACT_MATCH(DMI_BOARD_NAME, "Lindar"),
124 DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "sku524294"),
128 .callback = intel_dmi_no_pps_backlight,
129 .ident = "Google Lillipup sku524295",
130 .matches = {DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Google"),
131 DMI_EXACT_MATCH(DMI_BOARD_NAME, "Lindar"),
132 DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "sku524295"),
137 .hook = quirk_no_pps_backlight_power_hook,
141 static struct intel_quirk intel_quirks[] = {
142 /* Lenovo U160 cannot use SSC on LVDS */
143 { 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },
145 /* Sony Vaio Y cannot use SSC on LVDS */
146 { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
148 /* Acer Aspire 5734Z must invert backlight brightness */
149 { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
151 /* Acer/eMachines G725 */
152 { 0x2a42, 0x1025, 0x0210, quirk_invert_brightness },
154 /* Acer/eMachines e725 */
155 { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
157 /* Acer/Packard Bell NCL20 */
158 { 0x2a42, 0x1025, 0x034b, quirk_invert_brightness },
160 /* Acer Aspire 4736Z */
161 { 0x2a42, 0x1025, 0x0260, quirk_invert_brightness },
163 /* Acer Aspire 5336 */
164 { 0x2a42, 0x1025, 0x048a, quirk_invert_brightness },
166 /* Acer C720 and C720P Chromebooks (Celeron 2955U) have backlights */
167 { 0x0a06, 0x1025, 0x0a11, quirk_backlight_present },
169 /* Acer C720 Chromebook (Core i3 4005U) */
170 { 0x0a16, 0x1025, 0x0a11, quirk_backlight_present },
172 /* Apple Macbook 2,1 (Core 2 T7400) */
173 { 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
175 /* Apple Macbook 4,1 */
176 { 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
178 /* Toshiba CB35 Chromebook (Celeron 2955U) */
179 { 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
181 /* HP Chromebook 14 (Celeron 2955U) */
182 { 0x0a06, 0x103c, 0x21ed, quirk_backlight_present },
184 /* Dell Chromebook 11 */
185 { 0x0a06, 0x1028, 0x0a35, quirk_backlight_present },
187 /* Dell Chromebook 11 (2015 version) */
188 { 0x0a16, 0x1028, 0x0a35, quirk_backlight_present },
190 /* Toshiba Satellite P50-C-18C */
191 { 0x191B, 0x1179, 0xF840, quirk_increase_t12_delay },
194 { 0x3185, 0x8086, 0x2072, quirk_increase_ddi_disabled_time },
195 { 0x3184, 0x8086, 0x2072, quirk_increase_ddi_disabled_time },
197 { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time },
198 { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time },
200 { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
201 { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
202 /* HP Notebook - 14-r206nv */
203 { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness },
206 void intel_init_quirks(struct drm_i915_private *i915)
208 struct pci_dev *d = to_pci_dev(i915->drm.dev);
211 for (i = 0; i < ARRAY_SIZE(intel_quirks); i++) {
212 struct intel_quirk *q = &intel_quirks[i];
214 if (d->device == q->device &&
215 (d->subsystem_vendor == q->subsystem_vendor ||
216 q->subsystem_vendor == PCI_ANY_ID) &&
217 (d->subsystem_device == q->subsystem_device ||
218 q->subsystem_device == PCI_ANY_ID))
221 for (i = 0; i < ARRAY_SIZE(intel_dmi_quirks); i++) {
222 if (dmi_check_system(*intel_dmi_quirks[i].dmi_id_list) != 0)
223 intel_dmi_quirks[i].hook(i915);
227 bool intel_has_quirk(struct drm_i915_private *i915, enum intel_quirk_id quirk)
229 return i915->display.quirks.mask & BIT(quirk);