2 * Copyright (C) 2014 Red Hat
3 * Copyright (C) 2014 Intel Corp.
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
12 * The above copyright notice and this permission notice shall be included in
13 * all copies or substantial portions of the Software.
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21 * OTHER DEALINGS IN THE SOFTWARE.
28 #include <linux/dma-fence.h>
29 #include <linux/ktime.h>
31 #include <drm/drm_atomic.h>
32 #include <drm/drm_atomic_helper.h>
33 #include <drm/drm_atomic_uapi.h>
34 #include <drm/drm_blend.h>
35 #include <drm/drm_bridge.h>
36 #include <drm/drm_damage_helper.h>
37 #include <drm/drm_device.h>
38 #include <drm/drm_drv.h>
39 #include <drm/drm_framebuffer.h>
40 #include <drm/drm_gem_atomic_helper.h>
41 #include <drm/drm_print.h>
42 #include <drm/drm_self_refresh_helper.h>
43 #include <drm/drm_vblank.h>
44 #include <drm/drm_writeback.h>
46 #include "drm_crtc_helper_internal.h"
47 #include "drm_crtc_internal.h"
52 * This helper library provides implementations of check and commit functions on
53 * top of the CRTC modeset helper callbacks and the plane helper callbacks. It
54 * also provides convenience implementations for the atomic state handling
55 * callbacks for drivers which don't need to subclass the drm core structures to
56 * add their own additional internal state.
58 * This library also provides default implementations for the check callback in
59 * drm_atomic_helper_check() and for the commit callback with
60 * drm_atomic_helper_commit(). But the individual stages and callbacks are
61 * exposed to allow drivers to mix and match and e.g. use the plane helpers only
62 * together with a driver private modeset implementation.
64 * This library also provides implementations for all the legacy driver
65 * interfaces on top of the atomic interface. See drm_atomic_helper_set_config(),
66 * drm_atomic_helper_disable_plane(), and the various functions to implement
67 * set_property callbacks. New drivers must not implement these functions
68 * themselves but must use the provided helpers.
70 * The atomic helper uses the same function table structures as all other
71 * modesetting helpers. See the documentation for &struct drm_crtc_helper_funcs,
72 * struct &drm_encoder_helper_funcs and &struct drm_connector_helper_funcs. It
73 * also shares the &struct drm_plane_helper_funcs function table with the plane
77 drm_atomic_helper_plane_changed(struct drm_atomic_state *state,
78 struct drm_plane_state *old_plane_state,
79 struct drm_plane_state *plane_state,
80 struct drm_plane *plane)
82 struct drm_crtc_state *crtc_state;
84 if (old_plane_state->crtc) {
85 crtc_state = drm_atomic_get_new_crtc_state(state,
86 old_plane_state->crtc);
88 if (WARN_ON(!crtc_state))
91 crtc_state->planes_changed = true;
94 if (plane_state->crtc) {
95 crtc_state = drm_atomic_get_new_crtc_state(state, plane_state->crtc);
97 if (WARN_ON(!crtc_state))
100 crtc_state->planes_changed = true;
104 static int handle_conflicting_encoders(struct drm_atomic_state *state,
105 bool disable_conflicting_encoders)
107 struct drm_connector_state *new_conn_state;
108 struct drm_connector *connector;
109 struct drm_connector_list_iter conn_iter;
110 struct drm_encoder *encoder;
111 unsigned int encoder_mask = 0;
115 * First loop, find all newly assigned encoders from the connectors
116 * part of the state. If the same encoder is assigned to multiple
117 * connectors bail out.
119 for_each_new_connector_in_state(state, connector, new_conn_state, i) {
120 const struct drm_connector_helper_funcs *funcs = connector->helper_private;
121 struct drm_encoder *new_encoder;
123 if (!new_conn_state->crtc)
126 if (funcs->atomic_best_encoder)
127 new_encoder = funcs->atomic_best_encoder(connector,
129 else if (funcs->best_encoder)
130 new_encoder = funcs->best_encoder(connector);
132 new_encoder = drm_connector_get_single_encoder(connector);
135 if (encoder_mask & drm_encoder_mask(new_encoder)) {
136 drm_dbg_atomic(connector->dev,
137 "[ENCODER:%d:%s] on [CONNECTOR:%d:%s] already assigned\n",
138 new_encoder->base.id, new_encoder->name,
139 connector->base.id, connector->name);
144 encoder_mask |= drm_encoder_mask(new_encoder);
152 * Second loop, iterate over all connectors not part of the state.
154 * If a conflicting encoder is found and disable_conflicting_encoders
155 * is not set, an error is returned. Userspace can provide a solution
156 * through the atomic ioctl.
158 * If the flag is set conflicting connectors are removed from the CRTC
159 * and the CRTC is disabled if no encoder is left. This preserves
160 * compatibility with the legacy set_config behavior.
162 drm_connector_list_iter_begin(state->dev, &conn_iter);
163 drm_for_each_connector_iter(connector, &conn_iter) {
164 struct drm_crtc_state *crtc_state;
166 if (drm_atomic_get_new_connector_state(state, connector))
169 encoder = connector->state->best_encoder;
170 if (!encoder || !(encoder_mask & drm_encoder_mask(encoder)))
173 if (!disable_conflicting_encoders) {
174 drm_dbg_atomic(connector->dev,
175 "[ENCODER:%d:%s] in use on [CRTC:%d:%s] by [CONNECTOR:%d:%s]\n",
176 encoder->base.id, encoder->name,
177 connector->state->crtc->base.id,
178 connector->state->crtc->name,
179 connector->base.id, connector->name);
184 new_conn_state = drm_atomic_get_connector_state(state, connector);
185 if (IS_ERR(new_conn_state)) {
186 ret = PTR_ERR(new_conn_state);
190 drm_dbg_atomic(connector->dev,
191 "[ENCODER:%d:%s] in use on [CRTC:%d:%s], disabling [CONNECTOR:%d:%s]\n",
192 encoder->base.id, encoder->name,
193 new_conn_state->crtc->base.id, new_conn_state->crtc->name,
194 connector->base.id, connector->name);
196 crtc_state = drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
198 ret = drm_atomic_set_crtc_for_connector(new_conn_state, NULL);
202 if (!crtc_state->connector_mask) {
203 ret = drm_atomic_set_mode_prop_for_crtc(crtc_state,
208 crtc_state->active = false;
212 drm_connector_list_iter_end(&conn_iter);
218 set_best_encoder(struct drm_atomic_state *state,
219 struct drm_connector_state *conn_state,
220 struct drm_encoder *encoder)
222 struct drm_crtc_state *crtc_state;
223 struct drm_crtc *crtc;
225 if (conn_state->best_encoder) {
226 /* Unset the encoder_mask in the old crtc state. */
227 crtc = conn_state->connector->state->crtc;
229 /* A NULL crtc is an error here because we should have
230 * duplicated a NULL best_encoder when crtc was NULL.
231 * As an exception restoring duplicated atomic state
232 * during resume is allowed, so don't warn when
233 * best_encoder is equal to encoder we intend to set.
235 WARN_ON(!crtc && encoder != conn_state->best_encoder);
237 crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
239 crtc_state->encoder_mask &=
240 ~drm_encoder_mask(conn_state->best_encoder);
245 crtc = conn_state->crtc;
248 crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
250 crtc_state->encoder_mask |=
251 drm_encoder_mask(encoder);
255 conn_state->best_encoder = encoder;
259 steal_encoder(struct drm_atomic_state *state,
260 struct drm_encoder *encoder)
262 struct drm_crtc_state *crtc_state;
263 struct drm_connector *connector;
264 struct drm_connector_state *old_connector_state, *new_connector_state;
267 for_each_oldnew_connector_in_state(state, connector, old_connector_state, new_connector_state, i) {
268 struct drm_crtc *encoder_crtc;
270 if (new_connector_state->best_encoder != encoder)
273 encoder_crtc = old_connector_state->crtc;
275 drm_dbg_atomic(encoder->dev,
276 "[ENCODER:%d:%s] in use on [CRTC:%d:%s], stealing it\n",
277 encoder->base.id, encoder->name,
278 encoder_crtc->base.id, encoder_crtc->name);
280 set_best_encoder(state, new_connector_state, NULL);
282 crtc_state = drm_atomic_get_new_crtc_state(state, encoder_crtc);
283 crtc_state->connectors_changed = true;
290 update_connector_routing(struct drm_atomic_state *state,
291 struct drm_connector *connector,
292 struct drm_connector_state *old_connector_state,
293 struct drm_connector_state *new_connector_state)
295 const struct drm_connector_helper_funcs *funcs;
296 struct drm_encoder *new_encoder;
297 struct drm_crtc_state *crtc_state;
299 drm_dbg_atomic(connector->dev, "Updating routing for [CONNECTOR:%d:%s]\n",
300 connector->base.id, connector->name);
302 if (old_connector_state->crtc != new_connector_state->crtc) {
303 if (old_connector_state->crtc) {
304 crtc_state = drm_atomic_get_new_crtc_state(state, old_connector_state->crtc);
305 crtc_state->connectors_changed = true;
308 if (new_connector_state->crtc) {
309 crtc_state = drm_atomic_get_new_crtc_state(state, new_connector_state->crtc);
310 crtc_state->connectors_changed = true;
314 if (!new_connector_state->crtc) {
315 drm_dbg_atomic(connector->dev, "Disabling [CONNECTOR:%d:%s]\n",
316 connector->base.id, connector->name);
318 set_best_encoder(state, new_connector_state, NULL);
323 crtc_state = drm_atomic_get_new_crtc_state(state,
324 new_connector_state->crtc);
326 * For compatibility with legacy users, we want to make sure that
327 * we allow DPMS On->Off modesets on unregistered connectors. Modesets
328 * which would result in anything else must be considered invalid, to
329 * avoid turning on new displays on dead connectors.
331 * Since the connector can be unregistered at any point during an
332 * atomic check or commit, this is racy. But that's OK: all we care
333 * about is ensuring that userspace can't do anything but shut off the
334 * display on a connector that was destroyed after it's been notified,
337 * Additionally, we also want to ignore connector registration when
338 * we're trying to restore an atomic state during system resume since
339 * there's a chance the connector may have been destroyed during the
340 * process, but it's better to ignore that then cause
341 * drm_atomic_helper_resume() to fail.
343 if (!state->duplicated && drm_connector_is_unregistered(connector) &&
344 crtc_state->active) {
345 drm_dbg_atomic(connector->dev,
346 "[CONNECTOR:%d:%s] is not registered\n",
347 connector->base.id, connector->name);
351 funcs = connector->helper_private;
353 if (funcs->atomic_best_encoder)
354 new_encoder = funcs->atomic_best_encoder(connector, state);
355 else if (funcs->best_encoder)
356 new_encoder = funcs->best_encoder(connector);
358 new_encoder = drm_connector_get_single_encoder(connector);
361 drm_dbg_atomic(connector->dev,
362 "No suitable encoder found for [CONNECTOR:%d:%s]\n",
363 connector->base.id, connector->name);
367 if (!drm_encoder_crtc_ok(new_encoder, new_connector_state->crtc)) {
368 drm_dbg_atomic(connector->dev,
369 "[ENCODER:%d:%s] incompatible with [CRTC:%d:%s]\n",
370 new_encoder->base.id,
372 new_connector_state->crtc->base.id,
373 new_connector_state->crtc->name);
377 if (new_encoder == new_connector_state->best_encoder) {
378 set_best_encoder(state, new_connector_state, new_encoder);
380 drm_dbg_atomic(connector->dev,
381 "[CONNECTOR:%d:%s] keeps [ENCODER:%d:%s], now on [CRTC:%d:%s]\n",
384 new_encoder->base.id,
386 new_connector_state->crtc->base.id,
387 new_connector_state->crtc->name);
392 steal_encoder(state, new_encoder);
394 set_best_encoder(state, new_connector_state, new_encoder);
396 crtc_state->connectors_changed = true;
398 drm_dbg_atomic(connector->dev,
399 "[CONNECTOR:%d:%s] using [ENCODER:%d:%s] on [CRTC:%d:%s]\n",
402 new_encoder->base.id,
404 new_connector_state->crtc->base.id,
405 new_connector_state->crtc->name);
411 mode_fixup(struct drm_atomic_state *state)
413 struct drm_crtc *crtc;
414 struct drm_crtc_state *new_crtc_state;
415 struct drm_connector *connector;
416 struct drm_connector_state *new_conn_state;
420 for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
421 if (!new_crtc_state->mode_changed &&
422 !new_crtc_state->connectors_changed)
425 drm_mode_copy(&new_crtc_state->adjusted_mode, &new_crtc_state->mode);
428 for_each_new_connector_in_state(state, connector, new_conn_state, i) {
429 const struct drm_encoder_helper_funcs *funcs;
430 struct drm_encoder *encoder;
431 struct drm_bridge *bridge;
433 WARN_ON(!!new_conn_state->best_encoder != !!new_conn_state->crtc);
435 if (!new_conn_state->crtc || !new_conn_state->best_encoder)
439 drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
442 * Each encoder has at most one connector (since we always steal
443 * it away), so we won't call ->mode_fixup twice.
445 encoder = new_conn_state->best_encoder;
446 funcs = encoder->helper_private;
448 bridge = drm_bridge_chain_get_first_bridge(encoder);
449 ret = drm_atomic_bridge_chain_check(bridge,
453 drm_dbg_atomic(encoder->dev, "Bridge atomic check failed\n");
457 if (funcs && funcs->atomic_check) {
458 ret = funcs->atomic_check(encoder, new_crtc_state,
461 drm_dbg_atomic(encoder->dev,
462 "[ENCODER:%d:%s] check failed\n",
463 encoder->base.id, encoder->name);
466 } else if (funcs && funcs->mode_fixup) {
467 ret = funcs->mode_fixup(encoder, &new_crtc_state->mode,
468 &new_crtc_state->adjusted_mode);
470 drm_dbg_atomic(encoder->dev,
471 "[ENCODER:%d:%s] fixup failed\n",
472 encoder->base.id, encoder->name);
478 for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
479 const struct drm_crtc_helper_funcs *funcs;
481 if (!new_crtc_state->enable)
484 if (!new_crtc_state->mode_changed &&
485 !new_crtc_state->connectors_changed)
488 funcs = crtc->helper_private;
489 if (!funcs || !funcs->mode_fixup)
492 ret = funcs->mode_fixup(crtc, &new_crtc_state->mode,
493 &new_crtc_state->adjusted_mode);
495 drm_dbg_atomic(crtc->dev, "[CRTC:%d:%s] fixup failed\n",
496 crtc->base.id, crtc->name);
504 static enum drm_mode_status mode_valid_path(struct drm_connector *connector,
505 struct drm_encoder *encoder,
506 struct drm_crtc *crtc,
507 const struct drm_display_mode *mode)
509 struct drm_bridge *bridge;
510 enum drm_mode_status ret;
512 ret = drm_encoder_mode_valid(encoder, mode);
513 if (ret != MODE_OK) {
514 drm_dbg_atomic(encoder->dev,
515 "[ENCODER:%d:%s] mode_valid() failed\n",
516 encoder->base.id, encoder->name);
520 bridge = drm_bridge_chain_get_first_bridge(encoder);
521 ret = drm_bridge_chain_mode_valid(bridge, &connector->display_info,
523 if (ret != MODE_OK) {
524 drm_dbg_atomic(encoder->dev, "[BRIDGE] mode_valid() failed\n");
528 ret = drm_crtc_mode_valid(crtc, mode);
529 if (ret != MODE_OK) {
530 drm_dbg_atomic(encoder->dev, "[CRTC:%d:%s] mode_valid() failed\n",
531 crtc->base.id, crtc->name);
539 mode_valid(struct drm_atomic_state *state)
541 struct drm_connector_state *conn_state;
542 struct drm_connector *connector;
545 for_each_new_connector_in_state(state, connector, conn_state, i) {
546 struct drm_encoder *encoder = conn_state->best_encoder;
547 struct drm_crtc *crtc = conn_state->crtc;
548 struct drm_crtc_state *crtc_state;
549 enum drm_mode_status mode_status;
550 const struct drm_display_mode *mode;
552 if (!crtc || !encoder)
555 crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
558 if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
561 mode = &crtc_state->mode;
563 mode_status = mode_valid_path(connector, encoder, crtc, mode);
564 if (mode_status != MODE_OK)
572 * drm_atomic_helper_check_modeset - validate state object for modeset changes
574 * @state: the driver state object
576 * Check the state object to see if the requested state is physically possible.
577 * This does all the CRTC and connector related computations for an atomic
578 * update and adds any additional connectors needed for full modesets. It calls
579 * the various per-object callbacks in the follow order:
581 * 1. &drm_connector_helper_funcs.atomic_best_encoder for determining the new encoder.
582 * 2. &drm_connector_helper_funcs.atomic_check to validate the connector state.
583 * 3. If it's determined a modeset is needed then all connectors on the affected
584 * CRTC are added and &drm_connector_helper_funcs.atomic_check is run on them.
585 * 4. &drm_encoder_helper_funcs.mode_valid, &drm_bridge_funcs.mode_valid and
586 * &drm_crtc_helper_funcs.mode_valid are called on the affected components.
587 * 5. &drm_bridge_funcs.mode_fixup is called on all encoder bridges.
588 * 6. &drm_encoder_helper_funcs.atomic_check is called to validate any encoder state.
589 * This function is only called when the encoder will be part of a configured CRTC,
590 * it must not be used for implementing connector property validation.
591 * If this function is NULL, &drm_atomic_encoder_helper_funcs.mode_fixup is called
593 * 7. &drm_crtc_helper_funcs.mode_fixup is called last, to fix up the mode with CRTC constraints.
595 * &drm_crtc_state.mode_changed is set when the input mode is changed.
596 * &drm_crtc_state.connectors_changed is set when a connector is added or
597 * removed from the CRTC. &drm_crtc_state.active_changed is set when
598 * &drm_crtc_state.active changes, which is used for DPMS.
599 * &drm_crtc_state.no_vblank is set from the result of drm_dev_has_vblank().
600 * See also: drm_atomic_crtc_needs_modeset()
604 * Drivers which set &drm_crtc_state.mode_changed (e.g. in their
605 * &drm_plane_helper_funcs.atomic_check hooks if a plane update can't be done
606 * without a full modeset) _must_ call this function after that change. It is
607 * permitted to call this function multiple times for the same update, e.g.
608 * when the &drm_crtc_helper_funcs.atomic_check functions depend upon the
609 * adjusted dotclock for fifo space allocation and watermark computation.
612 * Zero for success or -errno
615 drm_atomic_helper_check_modeset(struct drm_device *dev,
616 struct drm_atomic_state *state)
618 struct drm_crtc *crtc;
619 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
620 struct drm_connector *connector;
621 struct drm_connector_state *old_connector_state, *new_connector_state;
623 unsigned int connectors_mask = 0;
625 for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
626 bool has_connectors =
627 !!new_crtc_state->connector_mask;
629 WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
631 if (!drm_mode_equal(&old_crtc_state->mode, &new_crtc_state->mode)) {
632 drm_dbg_atomic(dev, "[CRTC:%d:%s] mode changed\n",
633 crtc->base.id, crtc->name);
634 new_crtc_state->mode_changed = true;
637 if (old_crtc_state->enable != new_crtc_state->enable) {
638 drm_dbg_atomic(dev, "[CRTC:%d:%s] enable changed\n",
639 crtc->base.id, crtc->name);
642 * For clarity this assignment is done here, but
643 * enable == 0 is only true when there are no
644 * connectors and a NULL mode.
646 * The other way around is true as well. enable != 0
647 * implies that connectors are attached and a mode is set.
649 new_crtc_state->mode_changed = true;
650 new_crtc_state->connectors_changed = true;
653 if (old_crtc_state->active != new_crtc_state->active) {
654 drm_dbg_atomic(dev, "[CRTC:%d:%s] active changed\n",
655 crtc->base.id, crtc->name);
656 new_crtc_state->active_changed = true;
659 if (new_crtc_state->enable != has_connectors) {
660 drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch\n",
661 crtc->base.id, crtc->name);
666 if (drm_dev_has_vblank(dev))
667 new_crtc_state->no_vblank = false;
669 new_crtc_state->no_vblank = true;
672 ret = handle_conflicting_encoders(state, false);
676 for_each_oldnew_connector_in_state(state, connector, old_connector_state, new_connector_state, i) {
677 const struct drm_connector_helper_funcs *funcs = connector->helper_private;
679 WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
682 * This only sets crtc->connectors_changed for routing changes,
683 * drivers must set crtc->connectors_changed themselves when
684 * connector properties need to be updated.
686 ret = update_connector_routing(state, connector,
688 new_connector_state);
691 if (old_connector_state->crtc) {
692 new_crtc_state = drm_atomic_get_new_crtc_state(state,
693 old_connector_state->crtc);
694 if (old_connector_state->link_status !=
695 new_connector_state->link_status)
696 new_crtc_state->connectors_changed = true;
698 if (old_connector_state->max_requested_bpc !=
699 new_connector_state->max_requested_bpc)
700 new_crtc_state->connectors_changed = true;
703 if (funcs->atomic_check)
704 ret = funcs->atomic_check(connector, state);
707 "[CONNECTOR:%d:%s] driver check failed\n",
708 connector->base.id, connector->name);
712 connectors_mask |= BIT(i);
716 * After all the routing has been prepared we need to add in any
717 * connector which is itself unchanged, but whose CRTC changes its
718 * configuration. This must be done before calling mode_fixup in case a
719 * crtc only changed its mode but has the same set of connectors.
721 for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
722 if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
726 "[CRTC:%d:%s] needs all connectors, enable: %c, active: %c\n",
727 crtc->base.id, crtc->name,
728 new_crtc_state->enable ? 'y' : 'n',
729 new_crtc_state->active ? 'y' : 'n');
731 ret = drm_atomic_add_affected_connectors(state, crtc);
735 ret = drm_atomic_add_affected_planes(state, crtc);
741 * Iterate over all connectors again, to make sure atomic_check()
742 * has been called on them when a modeset is forced.
744 for_each_oldnew_connector_in_state(state, connector, old_connector_state, new_connector_state, i) {
745 const struct drm_connector_helper_funcs *funcs = connector->helper_private;
747 if (connectors_mask & BIT(i))
750 if (funcs->atomic_check)
751 ret = funcs->atomic_check(connector, state);
754 "[CONNECTOR:%d:%s] driver check failed\n",
755 connector->base.id, connector->name);
761 * Iterate over all connectors again, and add all affected bridges to
764 for_each_oldnew_connector_in_state(state, connector,
766 new_connector_state, i) {
767 struct drm_encoder *encoder;
769 encoder = old_connector_state->best_encoder;
770 ret = drm_atomic_add_encoder_bridges(state, encoder);
774 encoder = new_connector_state->best_encoder;
775 ret = drm_atomic_add_encoder_bridges(state, encoder);
780 ret = mode_valid(state);
784 return mode_fixup(state);
786 EXPORT_SYMBOL(drm_atomic_helper_check_modeset);
789 * drm_atomic_helper_check_wb_encoder_state() - Check writeback encoder state
790 * @encoder: encoder state to check
791 * @conn_state: connector state to check
793 * Checks if the writeback connector state is valid, and returns an error if it
797 * Zero for success or -errno
800 drm_atomic_helper_check_wb_encoder_state(struct drm_encoder *encoder,
801 struct drm_connector_state *conn_state)
803 struct drm_writeback_job *wb_job = conn_state->writeback_job;
804 struct drm_property_blob *pixel_format_blob;
805 struct drm_framebuffer *fb;
809 if (!wb_job || !wb_job->fb)
812 pixel_format_blob = wb_job->connector->pixel_formats_blob_ptr;
813 nformats = pixel_format_blob->length / sizeof(u32);
814 formats = pixel_format_blob->data;
817 for (i = 0; i < nformats; i++)
818 if (fb->format->format == formats[i])
821 drm_dbg_kms(encoder->dev, "Invalid pixel format %p4cc\n", &fb->format->format);
825 EXPORT_SYMBOL(drm_atomic_helper_check_wb_encoder_state);
828 * drm_atomic_helper_check_plane_state() - Check plane state for validity
829 * @plane_state: plane state to check
830 * @crtc_state: CRTC state to check
831 * @min_scale: minimum @src:@dest scaling factor in 16.16 fixed point
832 * @max_scale: maximum @src:@dest scaling factor in 16.16 fixed point
833 * @can_position: is it legal to position the plane such that it
834 * doesn't cover the entire CRTC? This will generally
835 * only be false for primary planes.
836 * @can_update_disabled: can the plane be updated while the CRTC
839 * Checks that a desired plane update is valid, and updates various
840 * bits of derived state (clipped coordinates etc.). Drivers that provide
841 * their own plane handling rather than helper-provided implementations may
842 * still wish to call this function to avoid duplication of error checking
846 * Zero if update appears valid, error code on failure
848 int drm_atomic_helper_check_plane_state(struct drm_plane_state *plane_state,
849 const struct drm_crtc_state *crtc_state,
853 bool can_update_disabled)
855 struct drm_framebuffer *fb = plane_state->fb;
856 struct drm_rect *src = &plane_state->src;
857 struct drm_rect *dst = &plane_state->dst;
858 unsigned int rotation = plane_state->rotation;
859 struct drm_rect clip = {};
862 WARN_ON(plane_state->crtc && plane_state->crtc != crtc_state->crtc);
864 *src = drm_plane_state_src(plane_state);
865 *dst = drm_plane_state_dest(plane_state);
868 plane_state->visible = false;
872 /* crtc should only be NULL when disabling (i.e., !fb) */
873 if (WARN_ON(!plane_state->crtc)) {
874 plane_state->visible = false;
878 if (!crtc_state->enable && !can_update_disabled) {
879 drm_dbg_kms(plane_state->plane->dev,
880 "Cannot update plane of a disabled CRTC.\n");
884 drm_rect_rotate(src, fb->width << 16, fb->height << 16, rotation);
887 hscale = drm_rect_calc_hscale(src, dst, min_scale, max_scale);
888 vscale = drm_rect_calc_vscale(src, dst, min_scale, max_scale);
889 if (hscale < 0 || vscale < 0) {
890 drm_dbg_kms(plane_state->plane->dev,
891 "Invalid scaling of plane\n");
892 drm_rect_debug_print("src: ", &plane_state->src, true);
893 drm_rect_debug_print("dst: ", &plane_state->dst, false);
897 if (crtc_state->enable)
898 drm_mode_get_hv_timing(&crtc_state->mode, &clip.x2, &clip.y2);
900 plane_state->visible = drm_rect_clip_scaled(src, dst, &clip);
902 drm_rect_rotate_inv(src, fb->width << 16, fb->height << 16, rotation);
904 if (!plane_state->visible)
906 * Plane isn't visible; some drivers can handle this
907 * so we just return success here. Drivers that can't
908 * (including those that use the primary plane helper's
909 * update function) will return an error from their
910 * update_plane handler.
914 if (!can_position && !drm_rect_equals(dst, &clip)) {
915 drm_dbg_kms(plane_state->plane->dev,
916 "Plane must cover entire CRTC\n");
917 drm_rect_debug_print("dst: ", dst, false);
918 drm_rect_debug_print("clip: ", &clip, false);
924 EXPORT_SYMBOL(drm_atomic_helper_check_plane_state);
927 * drm_atomic_helper_check_crtc_primary_plane() - Check CRTC state for primary plane
928 * @crtc_state: CRTC state to check
930 * Checks that a CRTC has at least one primary plane attached to it, which is
931 * a requirement on some hardware. Note that this only involves the CRTC side
932 * of the test. To test if the primary plane is visible or if it can be updated
933 * without the CRTC being enabled, use drm_atomic_helper_check_plane_state() in
934 * the plane's atomic check.
937 * 0 if a primary plane is attached to the CRTC, or an error code otherwise
939 int drm_atomic_helper_check_crtc_primary_plane(struct drm_crtc_state *crtc_state)
941 struct drm_crtc *crtc = crtc_state->crtc;
942 struct drm_device *dev = crtc->dev;
943 struct drm_plane *plane;
945 /* needs at least one primary plane to be enabled */
946 drm_for_each_plane_mask(plane, dev, crtc_state->plane_mask) {
947 if (plane->type == DRM_PLANE_TYPE_PRIMARY)
951 drm_dbg_atomic(dev, "[CRTC:%d:%s] primary plane missing\n", crtc->base.id, crtc->name);
955 EXPORT_SYMBOL(drm_atomic_helper_check_crtc_primary_plane);
958 * drm_atomic_helper_check_planes - validate state object for planes changes
960 * @state: the driver state object
962 * Check the state object to see if the requested state is physically possible.
963 * This does all the plane update related checks using by calling into the
964 * &drm_crtc_helper_funcs.atomic_check and &drm_plane_helper_funcs.atomic_check
965 * hooks provided by the driver.
967 * It also sets &drm_crtc_state.planes_changed to indicate that a CRTC has
971 * Zero for success or -errno
974 drm_atomic_helper_check_planes(struct drm_device *dev,
975 struct drm_atomic_state *state)
977 struct drm_crtc *crtc;
978 struct drm_crtc_state *new_crtc_state;
979 struct drm_plane *plane;
980 struct drm_plane_state *new_plane_state, *old_plane_state;
983 for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
984 const struct drm_plane_helper_funcs *funcs;
986 WARN_ON(!drm_modeset_is_locked(&plane->mutex));
988 funcs = plane->helper_private;
990 drm_atomic_helper_plane_changed(state, old_plane_state, new_plane_state, plane);
992 drm_atomic_helper_check_plane_damage(state, new_plane_state);
994 if (!funcs || !funcs->atomic_check)
997 ret = funcs->atomic_check(plane, state);
999 drm_dbg_atomic(plane->dev,
1000 "[PLANE:%d:%s] atomic driver check failed\n",
1001 plane->base.id, plane->name);
1006 for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
1007 const struct drm_crtc_helper_funcs *funcs;
1009 funcs = crtc->helper_private;
1011 if (!funcs || !funcs->atomic_check)
1014 ret = funcs->atomic_check(crtc, state);
1016 drm_dbg_atomic(crtc->dev,
1017 "[CRTC:%d:%s] atomic driver check failed\n",
1018 crtc->base.id, crtc->name);
1025 EXPORT_SYMBOL(drm_atomic_helper_check_planes);
1028 * drm_atomic_helper_check - validate state object
1030 * @state: the driver state object
1032 * Check the state object to see if the requested state is physically possible.
1033 * Only CRTCs and planes have check callbacks, so for any additional (global)
1034 * checking that a driver needs it can simply wrap that around this function.
1035 * Drivers without such needs can directly use this as their
1036 * &drm_mode_config_funcs.atomic_check callback.
1038 * This just wraps the two parts of the state checking for planes and modeset
1039 * state in the default order: First it calls drm_atomic_helper_check_modeset()
1040 * and then drm_atomic_helper_check_planes(). The assumption is that the
1041 * @drm_plane_helper_funcs.atomic_check and @drm_crtc_helper_funcs.atomic_check
1042 * functions depend upon an updated adjusted_mode.clock to e.g. properly compute
1045 * Note that zpos normalization will add all enable planes to the state which
1046 * might not desired for some drivers.
1047 * For example enable/disable of a cursor plane which have fixed zpos value
1048 * would trigger all other enabled planes to be forced to the state change.
1051 * Zero for success or -errno
1053 int drm_atomic_helper_check(struct drm_device *dev,
1054 struct drm_atomic_state *state)
1058 ret = drm_atomic_helper_check_modeset(dev, state);
1062 if (dev->mode_config.normalize_zpos) {
1063 ret = drm_atomic_normalize_zpos(dev, state);
1068 ret = drm_atomic_helper_check_planes(dev, state);
1072 if (state->legacy_cursor_update)
1073 state->async_update = !drm_atomic_helper_async_check(dev, state);
1075 drm_self_refresh_helper_alter_state(state);
1079 EXPORT_SYMBOL(drm_atomic_helper_check);
1082 crtc_needs_disable(struct drm_crtc_state *old_state,
1083 struct drm_crtc_state *new_state)
1086 * No new_state means the CRTC is off, so the only criteria is whether
1087 * it's currently active or in self refresh mode.
1090 return drm_atomic_crtc_effectively_active(old_state);
1093 * We need to disable bridge(s) and CRTC if we're transitioning out of
1094 * self-refresh and changing CRTCs at the same time, because the
1095 * bridge tracks self-refresh status via CRTC state.
1097 if (old_state->self_refresh_active &&
1098 old_state->crtc != new_state->crtc)
1102 * We also need to run through the crtc_funcs->disable() function if
1103 * the CRTC is currently on, if it's transitioning to self refresh
1104 * mode, or if it's in self refresh mode and needs to be fully
1107 return old_state->active ||
1108 (old_state->self_refresh_active && !new_state->active) ||
1109 new_state->self_refresh_active;
1113 disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
1115 struct drm_connector *connector;
1116 struct drm_connector_state *old_conn_state, *new_conn_state;
1117 struct drm_crtc *crtc;
1118 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
1121 for_each_oldnew_connector_in_state(old_state, connector, old_conn_state, new_conn_state, i) {
1122 const struct drm_encoder_helper_funcs *funcs;
1123 struct drm_encoder *encoder;
1124 struct drm_bridge *bridge;
1127 * Shut down everything that's in the changeset and currently
1128 * still on. So need to check the old, saved state.
1130 if (!old_conn_state->crtc)
1133 old_crtc_state = drm_atomic_get_old_crtc_state(old_state, old_conn_state->crtc);
1135 if (new_conn_state->crtc)
1136 new_crtc_state = drm_atomic_get_new_crtc_state(
1138 new_conn_state->crtc);
1140 new_crtc_state = NULL;
1142 if (!crtc_needs_disable(old_crtc_state, new_crtc_state) ||
1143 !drm_atomic_crtc_needs_modeset(old_conn_state->crtc->state))
1146 encoder = old_conn_state->best_encoder;
1148 /* We shouldn't get this far if we didn't previously have
1149 * an encoder.. but WARN_ON() rather than explode.
1151 if (WARN_ON(!encoder))
1154 funcs = encoder->helper_private;
1156 drm_dbg_atomic(dev, "disabling [ENCODER:%d:%s]\n",
1157 encoder->base.id, encoder->name);
1160 * Each encoder has at most one connector (since we always steal
1161 * it away), so we won't call disable hooks twice.
1163 bridge = drm_bridge_chain_get_first_bridge(encoder);
1164 drm_atomic_bridge_chain_disable(bridge, old_state);
1166 /* Right function depends upon target state. */
1168 if (funcs->atomic_disable)
1169 funcs->atomic_disable(encoder, old_state);
1170 else if (new_conn_state->crtc && funcs->prepare)
1171 funcs->prepare(encoder);
1172 else if (funcs->disable)
1173 funcs->disable(encoder);
1174 else if (funcs->dpms)
1175 funcs->dpms(encoder, DRM_MODE_DPMS_OFF);
1178 drm_atomic_bridge_chain_post_disable(bridge, old_state);
1181 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
1182 const struct drm_crtc_helper_funcs *funcs;
1185 /* Shut down everything that needs a full modeset. */
1186 if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
1189 if (!crtc_needs_disable(old_crtc_state, new_crtc_state))
1192 funcs = crtc->helper_private;
1194 drm_dbg_atomic(dev, "disabling [CRTC:%d:%s]\n",
1195 crtc->base.id, crtc->name);
1198 /* Right function depends upon target state. */
1199 if (new_crtc_state->enable && funcs->prepare)
1200 funcs->prepare(crtc);
1201 else if (funcs->atomic_disable)
1202 funcs->atomic_disable(crtc, old_state);
1203 else if (funcs->disable)
1204 funcs->disable(crtc);
1205 else if (funcs->dpms)
1206 funcs->dpms(crtc, DRM_MODE_DPMS_OFF);
1208 if (!drm_dev_has_vblank(dev))
1211 ret = drm_crtc_vblank_get(crtc);
1212 WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n");
1214 drm_crtc_vblank_put(crtc);
1219 * drm_atomic_helper_update_legacy_modeset_state - update legacy modeset state
1221 * @old_state: atomic state object with old state structures
1223 * This function updates all the various legacy modeset state pointers in
1224 * connectors, encoders and CRTCs.
1226 * Drivers can use this for building their own atomic commit if they don't have
1227 * a pure helper-based modeset implementation.
1229 * Since these updates are not synchronized with lockings, only code paths
1230 * called from &drm_mode_config_helper_funcs.atomic_commit_tail can look at the
1231 * legacy state filled out by this helper. Defacto this means this helper and
1232 * the legacy state pointers are only really useful for transitioning an
1233 * existing driver to the atomic world.
1236 drm_atomic_helper_update_legacy_modeset_state(struct drm_device *dev,
1237 struct drm_atomic_state *old_state)
1239 struct drm_connector *connector;
1240 struct drm_connector_state *old_conn_state, *new_conn_state;
1241 struct drm_crtc *crtc;
1242 struct drm_crtc_state *new_crtc_state;
1245 /* clear out existing links and update dpms */
1246 for_each_oldnew_connector_in_state(old_state, connector, old_conn_state, new_conn_state, i) {
1247 if (connector->encoder) {
1248 WARN_ON(!connector->encoder->crtc);
1250 connector->encoder->crtc = NULL;
1251 connector->encoder = NULL;
1254 crtc = new_conn_state->crtc;
1255 if ((!crtc && old_conn_state->crtc) ||
1256 (crtc && drm_atomic_crtc_needs_modeset(crtc->state))) {
1257 int mode = DRM_MODE_DPMS_OFF;
1259 if (crtc && crtc->state->active)
1260 mode = DRM_MODE_DPMS_ON;
1262 connector->dpms = mode;
1267 for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
1268 if (!new_conn_state->crtc)
1271 if (WARN_ON(!new_conn_state->best_encoder))
1274 connector->encoder = new_conn_state->best_encoder;
1275 connector->encoder->crtc = new_conn_state->crtc;
1278 /* set legacy state in the crtc structure */
1279 for_each_new_crtc_in_state(old_state, crtc, new_crtc_state, i) {
1280 struct drm_plane *primary = crtc->primary;
1281 struct drm_plane_state *new_plane_state;
1283 crtc->mode = new_crtc_state->mode;
1284 crtc->enabled = new_crtc_state->enable;
1287 drm_atomic_get_new_plane_state(old_state, primary);
1289 if (new_plane_state && new_plane_state->crtc == crtc) {
1290 crtc->x = new_plane_state->src_x >> 16;
1291 crtc->y = new_plane_state->src_y >> 16;
1295 EXPORT_SYMBOL(drm_atomic_helper_update_legacy_modeset_state);
1298 * drm_atomic_helper_calc_timestamping_constants - update vblank timestamping constants
1299 * @state: atomic state object
1301 * Updates the timestamping constants used for precise vblank timestamps
1302 * by calling drm_calc_timestamping_constants() for all enabled crtcs in @state.
1304 void drm_atomic_helper_calc_timestamping_constants(struct drm_atomic_state *state)
1306 struct drm_crtc_state *new_crtc_state;
1307 struct drm_crtc *crtc;
1310 for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
1311 if (new_crtc_state->enable)
1312 drm_calc_timestamping_constants(crtc,
1313 &new_crtc_state->adjusted_mode);
1316 EXPORT_SYMBOL(drm_atomic_helper_calc_timestamping_constants);
1319 crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
1321 struct drm_crtc *crtc;
1322 struct drm_crtc_state *new_crtc_state;
1323 struct drm_connector *connector;
1324 struct drm_connector_state *new_conn_state;
1327 for_each_new_crtc_in_state(old_state, crtc, new_crtc_state, i) {
1328 const struct drm_crtc_helper_funcs *funcs;
1330 if (!new_crtc_state->mode_changed)
1333 funcs = crtc->helper_private;
1335 if (new_crtc_state->enable && funcs->mode_set_nofb) {
1336 drm_dbg_atomic(dev, "modeset on [CRTC:%d:%s]\n",
1337 crtc->base.id, crtc->name);
1339 funcs->mode_set_nofb(crtc);
1343 for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
1344 const struct drm_encoder_helper_funcs *funcs;
1345 struct drm_encoder *encoder;
1346 struct drm_display_mode *mode, *adjusted_mode;
1347 struct drm_bridge *bridge;
1349 if (!new_conn_state->best_encoder)
1352 encoder = new_conn_state->best_encoder;
1353 funcs = encoder->helper_private;
1354 new_crtc_state = new_conn_state->crtc->state;
1355 mode = &new_crtc_state->mode;
1356 adjusted_mode = &new_crtc_state->adjusted_mode;
1358 if (!new_crtc_state->mode_changed)
1361 drm_dbg_atomic(dev, "modeset on [ENCODER:%d:%s]\n",
1362 encoder->base.id, encoder->name);
1365 * Each encoder has at most one connector (since we always steal
1366 * it away), so we won't call mode_set hooks twice.
1368 if (funcs && funcs->atomic_mode_set) {
1369 funcs->atomic_mode_set(encoder, new_crtc_state,
1371 } else if (funcs && funcs->mode_set) {
1372 funcs->mode_set(encoder, mode, adjusted_mode);
1375 bridge = drm_bridge_chain_get_first_bridge(encoder);
1376 drm_bridge_chain_mode_set(bridge, mode, adjusted_mode);
1381 * drm_atomic_helper_commit_modeset_disables - modeset commit to disable outputs
1383 * @old_state: atomic state object with old state structures
1385 * This function shuts down all the outputs that need to be shut down and
1386 * prepares them (if required) with the new mode.
1388 * For compatibility with legacy CRTC helpers this should be called before
1389 * drm_atomic_helper_commit_planes(), which is what the default commit function
1390 * does. But drivers with different needs can group the modeset commits together
1391 * and do the plane commits at the end. This is useful for drivers doing runtime
1392 * PM since planes updates then only happen when the CRTC is actually enabled.
1394 void drm_atomic_helper_commit_modeset_disables(struct drm_device *dev,
1395 struct drm_atomic_state *old_state)
1397 disable_outputs(dev, old_state);
1399 drm_atomic_helper_update_legacy_modeset_state(dev, old_state);
1400 drm_atomic_helper_calc_timestamping_constants(old_state);
1402 crtc_set_mode(dev, old_state);
1404 EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_disables);
1406 static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
1407 struct drm_atomic_state *old_state)
1409 struct drm_connector *connector;
1410 struct drm_connector_state *new_conn_state;
1413 for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
1414 const struct drm_connector_helper_funcs *funcs;
1416 funcs = connector->helper_private;
1417 if (!funcs->atomic_commit)
1420 if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
1421 WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);
1422 funcs->atomic_commit(connector, old_state);
1428 * drm_atomic_helper_commit_modeset_enables - modeset commit to enable outputs
1430 * @old_state: atomic state object with old state structures
1432 * This function enables all the outputs with the new configuration which had to
1433 * be turned off for the update.
1435 * For compatibility with legacy CRTC helpers this should be called after
1436 * drm_atomic_helper_commit_planes(), which is what the default commit function
1437 * does. But drivers with different needs can group the modeset commits together
1438 * and do the plane commits at the end. This is useful for drivers doing runtime
1439 * PM since planes updates then only happen when the CRTC is actually enabled.
1441 void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
1442 struct drm_atomic_state *old_state)
1444 struct drm_crtc *crtc;
1445 struct drm_crtc_state *old_crtc_state;
1446 struct drm_crtc_state *new_crtc_state;
1447 struct drm_connector *connector;
1448 struct drm_connector_state *new_conn_state;
1451 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
1452 const struct drm_crtc_helper_funcs *funcs;
1454 /* Need to filter out CRTCs where only planes change. */
1455 if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
1458 if (!new_crtc_state->active)
1461 funcs = crtc->helper_private;
1463 if (new_crtc_state->enable) {
1464 drm_dbg_atomic(dev, "enabling [CRTC:%d:%s]\n",
1465 crtc->base.id, crtc->name);
1466 if (funcs->atomic_enable)
1467 funcs->atomic_enable(crtc, old_state);
1468 else if (funcs->commit)
1469 funcs->commit(crtc);
1473 for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
1474 const struct drm_encoder_helper_funcs *funcs;
1475 struct drm_encoder *encoder;
1476 struct drm_bridge *bridge;
1478 if (!new_conn_state->best_encoder)
1481 if (!new_conn_state->crtc->state->active ||
1482 !drm_atomic_crtc_needs_modeset(new_conn_state->crtc->state))
1485 encoder = new_conn_state->best_encoder;
1486 funcs = encoder->helper_private;
1488 drm_dbg_atomic(dev, "enabling [ENCODER:%d:%s]\n",
1489 encoder->base.id, encoder->name);
1492 * Each encoder has at most one connector (since we always steal
1493 * it away), so we won't call enable hooks twice.
1495 bridge = drm_bridge_chain_get_first_bridge(encoder);
1496 drm_atomic_bridge_chain_pre_enable(bridge, old_state);
1499 if (funcs->atomic_enable)
1500 funcs->atomic_enable(encoder, old_state);
1501 else if (funcs->enable)
1502 funcs->enable(encoder);
1503 else if (funcs->commit)
1504 funcs->commit(encoder);
1507 drm_atomic_bridge_chain_enable(bridge, old_state);
1510 drm_atomic_helper_commit_writebacks(dev, old_state);
1512 EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_enables);
1515 * For atomic updates which touch just a single CRTC, calculate the time of the
1516 * next vblank, and inform all the fences of the deadline.
1518 static void set_fence_deadline(struct drm_device *dev,
1519 struct drm_atomic_state *state)
1521 struct drm_crtc *crtc;
1522 struct drm_crtc_state *new_crtc_state;
1523 struct drm_plane *plane;
1524 struct drm_plane_state *new_plane_state;
1525 ktime_t vbltime = 0;
1528 for_each_new_crtc_in_state (state, crtc, new_crtc_state, i) {
1531 if (drm_atomic_crtc_needs_modeset(new_crtc_state))
1534 if (!new_crtc_state->active)
1537 if (drm_crtc_next_vblank_start(crtc, &v))
1540 if (!vbltime || ktime_before(v, vbltime))
1544 /* If no CRTCs updated, then nothing to do: */
1548 for_each_new_plane_in_state (state, plane, new_plane_state, i) {
1549 if (!new_plane_state->fence)
1551 dma_fence_set_deadline(new_plane_state->fence, vbltime);
1556 * drm_atomic_helper_wait_for_fences - wait for fences stashed in plane state
1558 * @state: atomic state object with old state structures
1559 * @pre_swap: If true, do an interruptible wait, and @state is the new state.
1560 * Otherwise @state is the old state.
1562 * For implicit sync, driver should fish the exclusive fence out from the
1563 * incoming fb's and stash it in the drm_plane_state. This is called after
1564 * drm_atomic_helper_swap_state() so it uses the current plane state (and
1565 * just uses the atomic state to find the changed planes)
1567 * Note that @pre_swap is needed since the point where we block for fences moves
1568 * around depending upon whether an atomic commit is blocking or
1569 * non-blocking. For non-blocking commit all waiting needs to happen after
1570 * drm_atomic_helper_swap_state() is called, but for blocking commits we want
1571 * to wait **before** we do anything that can't be easily rolled back. That is
1572 * before we call drm_atomic_helper_swap_state().
1574 * Returns zero if success or < 0 if dma_fence_wait() fails.
1576 int drm_atomic_helper_wait_for_fences(struct drm_device *dev,
1577 struct drm_atomic_state *state,
1580 struct drm_plane *plane;
1581 struct drm_plane_state *new_plane_state;
1584 set_fence_deadline(dev, state);
1586 for_each_new_plane_in_state(state, plane, new_plane_state, i) {
1587 if (!new_plane_state->fence)
1590 WARN_ON(!new_plane_state->fb);
1593 * If waiting for fences pre-swap (ie: nonblock), userspace can
1594 * still interrupt the operation. Instead of blocking until the
1595 * timer expires, make the wait interruptible.
1597 ret = dma_fence_wait(new_plane_state->fence, pre_swap);
1601 dma_fence_put(new_plane_state->fence);
1602 new_plane_state->fence = NULL;
1607 EXPORT_SYMBOL(drm_atomic_helper_wait_for_fences);
1610 * drm_atomic_helper_wait_for_vblanks - wait for vblank on CRTCs
1612 * @old_state: atomic state object with old state structures
1614 * Helper to, after atomic commit, wait for vblanks on all affected
1615 * CRTCs (ie. before cleaning up old framebuffers using
1616 * drm_atomic_helper_cleanup_planes()). It will only wait on CRTCs where the
1617 * framebuffers have actually changed to optimize for the legacy cursor and
1618 * plane update use-case.
1620 * Drivers using the nonblocking commit tracking support initialized by calling
1621 * drm_atomic_helper_setup_commit() should look at
1622 * drm_atomic_helper_wait_for_flip_done() as an alternative.
1625 drm_atomic_helper_wait_for_vblanks(struct drm_device *dev,
1626 struct drm_atomic_state *old_state)
1628 struct drm_crtc *crtc;
1629 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
1631 unsigned int crtc_mask = 0;
1634 * Legacy cursor ioctls are completely unsynced, and userspace
1635 * relies on that (by doing tons of cursor updates).
1637 if (old_state->legacy_cursor_update)
1640 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
1641 if (!new_crtc_state->active)
1644 ret = drm_crtc_vblank_get(crtc);
1648 crtc_mask |= drm_crtc_mask(crtc);
1649 old_state->crtcs[i].last_vblank_count = drm_crtc_vblank_count(crtc);
1652 for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
1653 if (!(crtc_mask & drm_crtc_mask(crtc)))
1656 ret = wait_event_timeout(dev->vblank[i].queue,
1657 old_state->crtcs[i].last_vblank_count !=
1658 drm_crtc_vblank_count(crtc),
1659 msecs_to_jiffies(100));
1661 WARN(!ret, "[CRTC:%d:%s] vblank wait timed out\n",
1662 crtc->base.id, crtc->name);
1664 drm_crtc_vblank_put(crtc);
1667 EXPORT_SYMBOL(drm_atomic_helper_wait_for_vblanks);
1670 * drm_atomic_helper_wait_for_flip_done - wait for all page flips to be done
1672 * @old_state: atomic state object with old state structures
1674 * Helper to, after atomic commit, wait for page flips on all affected
1675 * crtcs (ie. before cleaning up old framebuffers using
1676 * drm_atomic_helper_cleanup_planes()). Compared to
1677 * drm_atomic_helper_wait_for_vblanks() this waits for the completion on all
1678 * CRTCs, assuming that cursors-only updates are signalling their completion
1679 * immediately (or using a different path).
1681 * This requires that drivers use the nonblocking commit tracking support
1682 * initialized using drm_atomic_helper_setup_commit().
1684 void drm_atomic_helper_wait_for_flip_done(struct drm_device *dev,
1685 struct drm_atomic_state *old_state)
1687 struct drm_crtc *crtc;
1690 for (i = 0; i < dev->mode_config.num_crtc; i++) {
1691 struct drm_crtc_commit *commit = old_state->crtcs[i].commit;
1694 crtc = old_state->crtcs[i].ptr;
1696 if (!crtc || !commit)
1699 ret = wait_for_completion_timeout(&commit->flip_done, 10 * HZ);
1701 drm_err(dev, "[CRTC:%d:%s] flip_done timed out\n",
1702 crtc->base.id, crtc->name);
1705 if (old_state->fake_commit)
1706 complete_all(&old_state->fake_commit->flip_done);
1708 EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);
1711 * drm_atomic_helper_commit_tail - commit atomic update to hardware
1712 * @old_state: atomic state object with old state structures
1714 * This is the default implementation for the
1715 * &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers
1716 * that do not support runtime_pm or do not need the CRTC to be
1717 * enabled to perform a commit. Otherwise, see
1718 * drm_atomic_helper_commit_tail_rpm().
1720 * Note that the default ordering of how the various stages are called is to
1721 * match the legacy modeset helper library closest.
1723 void drm_atomic_helper_commit_tail(struct drm_atomic_state *old_state)
1725 struct drm_device *dev = old_state->dev;
1727 drm_atomic_helper_commit_modeset_disables(dev, old_state);
1729 drm_atomic_helper_commit_planes(dev, old_state, 0);
1731 drm_atomic_helper_commit_modeset_enables(dev, old_state);
1733 drm_atomic_helper_fake_vblank(old_state);
1735 drm_atomic_helper_commit_hw_done(old_state);
1737 drm_atomic_helper_wait_for_vblanks(dev, old_state);
1739 drm_atomic_helper_cleanup_planes(dev, old_state);
1741 EXPORT_SYMBOL(drm_atomic_helper_commit_tail);
1744 * drm_atomic_helper_commit_tail_rpm - commit atomic update to hardware
1745 * @old_state: new modeset state to be committed
1747 * This is an alternative implementation for the
1748 * &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers
1749 * that support runtime_pm or need the CRTC to be enabled to perform a
1750 * commit. Otherwise, one should use the default implementation
1751 * drm_atomic_helper_commit_tail().
1753 void drm_atomic_helper_commit_tail_rpm(struct drm_atomic_state *old_state)
1755 struct drm_device *dev = old_state->dev;
1757 drm_atomic_helper_commit_modeset_disables(dev, old_state);
1759 drm_atomic_helper_commit_modeset_enables(dev, old_state);
1761 drm_atomic_helper_commit_planes(dev, old_state,
1762 DRM_PLANE_COMMIT_ACTIVE_ONLY);
1764 drm_atomic_helper_fake_vblank(old_state);
1766 drm_atomic_helper_commit_hw_done(old_state);
1768 drm_atomic_helper_wait_for_vblanks(dev, old_state);
1770 drm_atomic_helper_cleanup_planes(dev, old_state);
1772 EXPORT_SYMBOL(drm_atomic_helper_commit_tail_rpm);
1774 static void commit_tail(struct drm_atomic_state *old_state)
1776 struct drm_device *dev = old_state->dev;
1777 const struct drm_mode_config_helper_funcs *funcs;
1778 struct drm_crtc_state *new_crtc_state;
1779 struct drm_crtc *crtc;
1782 unsigned int i, new_self_refresh_mask = 0;
1784 funcs = dev->mode_config.helper_private;
1787 * We're measuring the _entire_ commit, so the time will vary depending
1788 * on how many fences and objects are involved. For the purposes of self
1789 * refresh, this is desirable since it'll give us an idea of how
1790 * congested things are. This will inform our decision on how often we
1791 * should enter self refresh after idle.
1793 * These times will be averaged out in the self refresh helpers to avoid
1794 * overreacting over one outlier frame
1796 start = ktime_get();
1798 drm_atomic_helper_wait_for_fences(dev, old_state, false);
1800 drm_atomic_helper_wait_for_dependencies(old_state);
1803 * We cannot safely access new_crtc_state after
1804 * drm_atomic_helper_commit_hw_done() so figure out which crtc's have
1805 * self-refresh active beforehand:
1807 for_each_new_crtc_in_state(old_state, crtc, new_crtc_state, i)
1808 if (new_crtc_state->self_refresh_active)
1809 new_self_refresh_mask |= BIT(i);
1811 if (funcs && funcs->atomic_commit_tail)
1812 funcs->atomic_commit_tail(old_state);
1814 drm_atomic_helper_commit_tail(old_state);
1816 commit_time_ms = ktime_ms_delta(ktime_get(), start);
1817 if (commit_time_ms > 0)
1818 drm_self_refresh_helper_update_avg_times(old_state,
1819 (unsigned long)commit_time_ms,
1820 new_self_refresh_mask);
1822 drm_atomic_helper_commit_cleanup_done(old_state);
1824 drm_atomic_state_put(old_state);
1827 static void commit_work(struct work_struct *work)
1829 struct drm_atomic_state *state = container_of(work,
1830 struct drm_atomic_state,
1836 * drm_atomic_helper_async_check - check if state can be committed asynchronously
1838 * @state: the driver state object
1840 * This helper will check if it is possible to commit the state asynchronously.
1841 * Async commits are not supposed to swap the states like normal sync commits
1842 * but just do in-place changes on the current state.
1844 * It will return 0 if the commit can happen in an asynchronous fashion or error
1845 * if not. Note that error just mean it can't be committed asynchronously, if it
1846 * fails the commit should be treated like a normal synchronous commit.
1848 int drm_atomic_helper_async_check(struct drm_device *dev,
1849 struct drm_atomic_state *state)
1851 struct drm_crtc *crtc;
1852 struct drm_crtc_state *crtc_state;
1853 struct drm_plane *plane = NULL;
1854 struct drm_plane_state *old_plane_state = NULL;
1855 struct drm_plane_state *new_plane_state = NULL;
1856 const struct drm_plane_helper_funcs *funcs;
1857 int i, ret, n_planes = 0;
1859 for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
1860 if (drm_atomic_crtc_needs_modeset(crtc_state))
1864 for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i)
1867 /* FIXME: we support only single plane updates for now */
1868 if (n_planes != 1) {
1870 "only single plane async updates are supported\n");
1874 if (!new_plane_state->crtc ||
1875 old_plane_state->crtc != new_plane_state->crtc) {
1877 "[PLANE:%d:%s] async update cannot change CRTC\n",
1878 plane->base.id, plane->name);
1882 funcs = plane->helper_private;
1883 if (!funcs->atomic_async_update) {
1885 "[PLANE:%d:%s] driver does not support async updates\n",
1886 plane->base.id, plane->name);
1890 if (new_plane_state->fence) {
1892 "[PLANE:%d:%s] missing fence for async update\n",
1893 plane->base.id, plane->name);
1898 * Don't do an async update if there is an outstanding commit modifying
1899 * the plane. This prevents our async update's changes from getting
1900 * overridden by a previous synchronous update's state.
1902 if (old_plane_state->commit &&
1903 !try_wait_for_completion(&old_plane_state->commit->hw_done)) {
1905 "[PLANE:%d:%s] inflight previous commit preventing async commit\n",
1906 plane->base.id, plane->name);
1910 ret = funcs->atomic_async_check(plane, state);
1913 "[PLANE:%d:%s] driver async check failed\n",
1914 plane->base.id, plane->name);
1917 EXPORT_SYMBOL(drm_atomic_helper_async_check);
1920 * drm_atomic_helper_async_commit - commit state asynchronously
1922 * @state: the driver state object
1924 * This function commits a state asynchronously, i.e., not vblank
1925 * synchronized. It should be used on a state only when
1926 * drm_atomic_async_check() succeeds. Async commits are not supposed to swap
1927 * the states like normal sync commits, but just do in-place changes on the
1930 * TODO: Implement full swap instead of doing in-place changes.
1932 void drm_atomic_helper_async_commit(struct drm_device *dev,
1933 struct drm_atomic_state *state)
1935 struct drm_plane *plane;
1936 struct drm_plane_state *plane_state;
1937 const struct drm_plane_helper_funcs *funcs;
1940 for_each_new_plane_in_state(state, plane, plane_state, i) {
1941 struct drm_framebuffer *new_fb = plane_state->fb;
1942 struct drm_framebuffer *old_fb = plane->state->fb;
1944 funcs = plane->helper_private;
1945 funcs->atomic_async_update(plane, state);
1948 * ->atomic_async_update() is supposed to update the
1949 * plane->state in-place, make sure at least common
1950 * properties have been properly updated.
1952 WARN_ON_ONCE(plane->state->fb != new_fb);
1953 WARN_ON_ONCE(plane->state->crtc_x != plane_state->crtc_x);
1954 WARN_ON_ONCE(plane->state->crtc_y != plane_state->crtc_y);
1955 WARN_ON_ONCE(plane->state->src_x != plane_state->src_x);
1956 WARN_ON_ONCE(plane->state->src_y != plane_state->src_y);
1959 * Make sure the FBs have been swapped so that cleanups in the
1960 * new_state performs a cleanup in the old FB.
1962 WARN_ON_ONCE(plane_state->fb != old_fb);
1965 EXPORT_SYMBOL(drm_atomic_helper_async_commit);
1968 * drm_atomic_helper_commit - commit validated state object
1970 * @state: the driver state object
1971 * @nonblock: whether nonblocking behavior is requested.
1973 * This function commits a with drm_atomic_helper_check() pre-validated state
1974 * object. This can still fail when e.g. the framebuffer reservation fails. This
1975 * function implements nonblocking commits, using
1976 * drm_atomic_helper_setup_commit() and related functions.
1978 * Committing the actual hardware state is done through the
1979 * &drm_mode_config_helper_funcs.atomic_commit_tail callback, or its default
1980 * implementation drm_atomic_helper_commit_tail().
1983 * Zero for success or -errno.
1985 int drm_atomic_helper_commit(struct drm_device *dev,
1986 struct drm_atomic_state *state,
1991 if (state->async_update) {
1992 ret = drm_atomic_helper_prepare_planes(dev, state);
1996 drm_atomic_helper_async_commit(dev, state);
1997 drm_atomic_helper_cleanup_planes(dev, state);
2002 ret = drm_atomic_helper_setup_commit(state, nonblock);
2006 INIT_WORK(&state->commit_work, commit_work);
2008 ret = drm_atomic_helper_prepare_planes(dev, state);
2013 ret = drm_atomic_helper_wait_for_fences(dev, state, true);
2019 * This is the point of no return - everything below never fails except
2020 * when the hw goes bonghits. Which means we can commit the new state on
2021 * the software side now.
2024 ret = drm_atomic_helper_swap_state(state, true);
2029 * Everything below can be run asynchronously without the need to grab
2030 * any modeset locks at all under one condition: It must be guaranteed
2031 * that the asynchronous work has either been cancelled (if the driver
2032 * supports it, which at least requires that the framebuffers get
2033 * cleaned up with drm_atomic_helper_cleanup_planes()) or completed
2034 * before the new state gets committed on the software side with
2035 * drm_atomic_helper_swap_state().
2037 * This scheme allows new atomic state updates to be prepared and
2038 * checked in parallel to the asynchronous completion of the previous
2039 * update. Which is important since compositors need to figure out the
2040 * composition of the next frame right after having submitted the
2043 * NOTE: Commit work has multiple phases, first hardware commit, then
2044 * cleanup. We want them to overlap, hence need system_unbound_wq to
2045 * make sure work items don't artificially stall on each another.
2048 drm_atomic_state_get(state);
2050 queue_work(system_unbound_wq, &state->commit_work);
2057 drm_atomic_helper_cleanup_planes(dev, state);
2060 EXPORT_SYMBOL(drm_atomic_helper_commit);
2063 * DOC: implementing nonblocking commit
2065 * Nonblocking atomic commits should use struct &drm_crtc_commit to sequence
2066 * different operations against each another. Locks, especially struct
2067 * &drm_modeset_lock, should not be held in worker threads or any other
2068 * asynchronous context used to commit the hardware state.
2070 * drm_atomic_helper_commit() implements the recommended sequence for
2071 * nonblocking commits, using drm_atomic_helper_setup_commit() internally:
2073 * 1. Run drm_atomic_helper_prepare_planes(). Since this can fail and we
2074 * need to propagate out of memory/VRAM errors to userspace, it must be called
2077 * 2. Synchronize with any outstanding nonblocking commit worker threads which
2078 * might be affected by the new state update. This is handled by
2079 * drm_atomic_helper_setup_commit().
2081 * Asynchronous workers need to have sufficient parallelism to be able to run
2082 * different atomic commits on different CRTCs in parallel. The simplest way to
2083 * achieve this is by running them on the &system_unbound_wq work queue. Note
2084 * that drivers are not required to split up atomic commits and run an
2085 * individual commit in parallel - userspace is supposed to do that if it cares.
2086 * But it might be beneficial to do that for modesets, since those necessarily
2087 * must be done as one global operation, and enabling or disabling a CRTC can
2088 * take a long time. But even that is not required.
2090 * IMPORTANT: A &drm_atomic_state update for multiple CRTCs is sequenced
2091 * against all CRTCs therein. Therefore for atomic state updates which only flip
2092 * planes the driver must not get the struct &drm_crtc_state of unrelated CRTCs
2093 * in its atomic check code: This would prevent committing of atomic updates to
2094 * multiple CRTCs in parallel. In general, adding additional state structures
2095 * should be avoided as much as possible, because this reduces parallelism in
2096 * (nonblocking) commits, both due to locking and due to commit sequencing
2099 * 3. The software state is updated synchronously with
2100 * drm_atomic_helper_swap_state(). Doing this under the protection of all modeset
2101 * locks means concurrent callers never see inconsistent state. Note that commit
2102 * workers do not hold any locks; their access is only coordinated through
2103 * ordering. If workers would access state only through the pointers in the
2104 * free-standing state objects (currently not the case for any driver) then even
2105 * multiple pending commits could be in-flight at the same time.
2107 * 4. Schedule a work item to do all subsequent steps, using the split-out
2108 * commit helpers: a) pre-plane commit b) plane commit c) post-plane commit and
2109 * then cleaning up the framebuffers after the old framebuffer is no longer
2110 * being displayed. The scheduled work should synchronize against other workers
2111 * using the &drm_crtc_commit infrastructure as needed. See
2112 * drm_atomic_helper_setup_commit() for more details.
2115 static int stall_checks(struct drm_crtc *crtc, bool nonblock)
2117 struct drm_crtc_commit *commit, *stall_commit = NULL;
2118 bool completed = true;
2122 spin_lock(&crtc->commit_lock);
2124 list_for_each_entry(commit, &crtc->commit_list, commit_entry) {
2126 completed = try_wait_for_completion(&commit->flip_done);
2128 * Userspace is not allowed to get ahead of the previous
2129 * commit with nonblocking ones.
2131 if (!completed && nonblock) {
2132 spin_unlock(&crtc->commit_lock);
2133 drm_dbg_atomic(crtc->dev,
2134 "[CRTC:%d:%s] busy with a previous commit\n",
2135 crtc->base.id, crtc->name);
2139 } else if (i == 1) {
2140 stall_commit = drm_crtc_commit_get(commit);
2146 spin_unlock(&crtc->commit_lock);
2151 /* We don't want to let commits get ahead of cleanup work too much,
2152 * stalling on 2nd previous commit means triple-buffer won't ever stall.
2154 ret = wait_for_completion_interruptible_timeout(&stall_commit->cleanup_done,
2157 drm_err(crtc->dev, "[CRTC:%d:%s] cleanup_done timed out\n",
2158 crtc->base.id, crtc->name);
2160 drm_crtc_commit_put(stall_commit);
2162 return ret < 0 ? ret : 0;
2165 static void release_crtc_commit(struct completion *completion)
2167 struct drm_crtc_commit *commit = container_of(completion,
2171 drm_crtc_commit_put(commit);
2174 static void init_commit(struct drm_crtc_commit *commit, struct drm_crtc *crtc)
2176 init_completion(&commit->flip_done);
2177 init_completion(&commit->hw_done);
2178 init_completion(&commit->cleanup_done);
2179 INIT_LIST_HEAD(&commit->commit_entry);
2180 kref_init(&commit->ref);
2181 commit->crtc = crtc;
2184 static struct drm_crtc_commit *
2185 crtc_or_fake_commit(struct drm_atomic_state *state, struct drm_crtc *crtc)
2188 struct drm_crtc_state *new_crtc_state;
2190 new_crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
2192 return new_crtc_state->commit;
2195 if (!state->fake_commit) {
2196 state->fake_commit = kzalloc(sizeof(*state->fake_commit), GFP_KERNEL);
2197 if (!state->fake_commit)
2200 init_commit(state->fake_commit, NULL);
2203 return state->fake_commit;
2207 * drm_atomic_helper_setup_commit - setup possibly nonblocking commit
2208 * @state: new modeset state to be committed
2209 * @nonblock: whether nonblocking behavior is requested.
2211 * This function prepares @state to be used by the atomic helper's support for
2212 * nonblocking commits. Drivers using the nonblocking commit infrastructure
2213 * should always call this function from their
2214 * &drm_mode_config_funcs.atomic_commit hook.
2216 * Drivers that need to extend the commit setup to private objects can use the
2217 * &drm_mode_config_helper_funcs.atomic_commit_setup hook.
2219 * To be able to use this support drivers need to use a few more helper
2220 * functions. drm_atomic_helper_wait_for_dependencies() must be called before
2221 * actually committing the hardware state, and for nonblocking commits this call
2222 * must be placed in the async worker. See also drm_atomic_helper_swap_state()
2223 * and its stall parameter, for when a driver's commit hooks look at the
2224 * &drm_crtc.state, &drm_plane.state or &drm_connector.state pointer directly.
2226 * Completion of the hardware commit step must be signalled using
2227 * drm_atomic_helper_commit_hw_done(). After this step the driver is not allowed
2228 * to read or change any permanent software or hardware modeset state. The only
2229 * exception is state protected by other means than &drm_modeset_lock locks.
2230 * Only the free standing @state with pointers to the old state structures can
2231 * be inspected, e.g. to clean up old buffers using
2232 * drm_atomic_helper_cleanup_planes().
2234 * At the very end, before cleaning up @state drivers must call
2235 * drm_atomic_helper_commit_cleanup_done().
2237 * This is all implemented by in drm_atomic_helper_commit(), giving drivers a
2238 * complete and easy-to-use default implementation of the atomic_commit() hook.
2240 * The tracking of asynchronously executed and still pending commits is done
2241 * using the core structure &drm_crtc_commit.
2243 * By default there's no need to clean up resources allocated by this function
2244 * explicitly: drm_atomic_state_default_clear() will take care of that
2249 * 0 on success. -EBUSY when userspace schedules nonblocking commits too fast,
2250 * -ENOMEM on allocation failures and -EINTR when a signal is pending.
2252 int drm_atomic_helper_setup_commit(struct drm_atomic_state *state,
2255 struct drm_crtc *crtc;
2256 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
2257 struct drm_connector *conn;
2258 struct drm_connector_state *old_conn_state, *new_conn_state;
2259 struct drm_plane *plane;
2260 struct drm_plane_state *old_plane_state, *new_plane_state;
2261 struct drm_crtc_commit *commit;
2262 const struct drm_mode_config_helper_funcs *funcs;
2265 funcs = state->dev->mode_config.helper_private;
2267 for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
2268 commit = kzalloc(sizeof(*commit), GFP_KERNEL);
2272 init_commit(commit, crtc);
2274 new_crtc_state->commit = commit;
2276 ret = stall_checks(crtc, nonblock);
2281 * Drivers only send out events when at least either current or
2282 * new CRTC state is active. Complete right away if everything
2285 if (!old_crtc_state->active && !new_crtc_state->active) {
2286 complete_all(&commit->flip_done);
2290 /* Legacy cursor updates are fully unsynced. */
2291 if (state->legacy_cursor_update) {
2292 complete_all(&commit->flip_done);
2296 if (!new_crtc_state->event) {
2297 commit->event = kzalloc(sizeof(*commit->event),
2302 new_crtc_state->event = commit->event;
2305 new_crtc_state->event->base.completion = &commit->flip_done;
2306 new_crtc_state->event->base.completion_release = release_crtc_commit;
2307 drm_crtc_commit_get(commit);
2309 commit->abort_completion = true;
2311 state->crtcs[i].commit = commit;
2312 drm_crtc_commit_get(commit);
2315 for_each_oldnew_connector_in_state(state, conn, old_conn_state, new_conn_state, i) {
2317 * Userspace is not allowed to get ahead of the previous
2318 * commit with nonblocking ones.
2320 if (nonblock && old_conn_state->commit &&
2321 !try_wait_for_completion(&old_conn_state->commit->flip_done)) {
2322 drm_dbg_atomic(conn->dev,
2323 "[CONNECTOR:%d:%s] busy with a previous commit\n",
2324 conn->base.id, conn->name);
2329 /* Always track connectors explicitly for e.g. link retraining. */
2330 commit = crtc_or_fake_commit(state, new_conn_state->crtc ?: old_conn_state->crtc);
2334 new_conn_state->commit = drm_crtc_commit_get(commit);
2337 for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
2339 * Userspace is not allowed to get ahead of the previous
2340 * commit with nonblocking ones.
2342 if (nonblock && old_plane_state->commit &&
2343 !try_wait_for_completion(&old_plane_state->commit->flip_done)) {
2344 drm_dbg_atomic(plane->dev,
2345 "[PLANE:%d:%s] busy with a previous commit\n",
2346 plane->base.id, plane->name);
2351 /* Always track planes explicitly for async pageflip support. */
2352 commit = crtc_or_fake_commit(state, new_plane_state->crtc ?: old_plane_state->crtc);
2356 new_plane_state->commit = drm_crtc_commit_get(commit);
2359 if (funcs && funcs->atomic_commit_setup)
2360 return funcs->atomic_commit_setup(state);
2364 EXPORT_SYMBOL(drm_atomic_helper_setup_commit);
2367 * drm_atomic_helper_wait_for_dependencies - wait for required preceeding commits
2368 * @old_state: atomic state object with old state structures
2370 * This function waits for all preceeding commits that touch the same CRTC as
2371 * @old_state to both be committed to the hardware (as signalled by
2372 * drm_atomic_helper_commit_hw_done()) and executed by the hardware (as signalled
2373 * by calling drm_crtc_send_vblank_event() on the &drm_crtc_state.event).
2375 * This is part of the atomic helper support for nonblocking commits, see
2376 * drm_atomic_helper_setup_commit() for an overview.
2378 void drm_atomic_helper_wait_for_dependencies(struct drm_atomic_state *old_state)
2380 struct drm_crtc *crtc;
2381 struct drm_crtc_state *old_crtc_state;
2382 struct drm_plane *plane;
2383 struct drm_plane_state *old_plane_state;
2384 struct drm_connector *conn;
2385 struct drm_connector_state *old_conn_state;
2389 for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
2390 ret = drm_crtc_commit_wait(old_crtc_state->commit);
2393 "[CRTC:%d:%s] commit wait timed out\n",
2394 crtc->base.id, crtc->name);
2397 for_each_old_connector_in_state(old_state, conn, old_conn_state, i) {
2398 ret = drm_crtc_commit_wait(old_conn_state->commit);
2401 "[CONNECTOR:%d:%s] commit wait timed out\n",
2402 conn->base.id, conn->name);
2405 for_each_old_plane_in_state(old_state, plane, old_plane_state, i) {
2406 ret = drm_crtc_commit_wait(old_plane_state->commit);
2409 "[PLANE:%d:%s] commit wait timed out\n",
2410 plane->base.id, plane->name);
2413 EXPORT_SYMBOL(drm_atomic_helper_wait_for_dependencies);
2416 * drm_atomic_helper_fake_vblank - fake VBLANK events if needed
2417 * @old_state: atomic state object with old state structures
2419 * This function walks all CRTCs and fakes VBLANK events on those with
2420 * &drm_crtc_state.no_vblank set to true and &drm_crtc_state.event != NULL.
2421 * The primary use of this function is writeback connectors working in oneshot
2422 * mode and faking VBLANK events. In this case they only fake the VBLANK event
2423 * when a job is queued, and any change to the pipeline that does not touch the
2424 * connector is leading to timeouts when calling
2425 * drm_atomic_helper_wait_for_vblanks() or
2426 * drm_atomic_helper_wait_for_flip_done(). In addition to writeback
2427 * connectors, this function can also fake VBLANK events for CRTCs without
2430 * This is part of the atomic helper support for nonblocking commits, see
2431 * drm_atomic_helper_setup_commit() for an overview.
2433 void drm_atomic_helper_fake_vblank(struct drm_atomic_state *old_state)
2435 struct drm_crtc_state *new_crtc_state;
2436 struct drm_crtc *crtc;
2439 for_each_new_crtc_in_state(old_state, crtc, new_crtc_state, i) {
2440 unsigned long flags;
2442 if (!new_crtc_state->no_vblank)
2445 spin_lock_irqsave(&old_state->dev->event_lock, flags);
2446 if (new_crtc_state->event) {
2447 drm_crtc_send_vblank_event(crtc,
2448 new_crtc_state->event);
2449 new_crtc_state->event = NULL;
2451 spin_unlock_irqrestore(&old_state->dev->event_lock, flags);
2454 EXPORT_SYMBOL(drm_atomic_helper_fake_vblank);
2457 * drm_atomic_helper_commit_hw_done - setup possible nonblocking commit
2458 * @old_state: atomic state object with old state structures
2460 * This function is used to signal completion of the hardware commit step. After
2461 * this step the driver is not allowed to read or change any permanent software
2462 * or hardware modeset state. The only exception is state protected by other
2463 * means than &drm_modeset_lock locks.
2465 * Drivers should try to postpone any expensive or delayed cleanup work after
2466 * this function is called.
2468 * This is part of the atomic helper support for nonblocking commits, see
2469 * drm_atomic_helper_setup_commit() for an overview.
2471 void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *old_state)
2473 struct drm_crtc *crtc;
2474 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
2475 struct drm_crtc_commit *commit;
2478 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
2479 commit = new_crtc_state->commit;
2484 * copy new_crtc_state->commit to old_crtc_state->commit,
2485 * it's unsafe to touch new_crtc_state after hw_done,
2486 * but we still need to do so in cleanup_done().
2488 if (old_crtc_state->commit)
2489 drm_crtc_commit_put(old_crtc_state->commit);
2491 old_crtc_state->commit = drm_crtc_commit_get(commit);
2493 /* backend must have consumed any event by now */
2494 WARN_ON(new_crtc_state->event);
2495 complete_all(&commit->hw_done);
2498 if (old_state->fake_commit) {
2499 complete_all(&old_state->fake_commit->hw_done);
2500 complete_all(&old_state->fake_commit->flip_done);
2503 EXPORT_SYMBOL(drm_atomic_helper_commit_hw_done);
2506 * drm_atomic_helper_commit_cleanup_done - signal completion of commit
2507 * @old_state: atomic state object with old state structures
2509 * This signals completion of the atomic update @old_state, including any
2510 * cleanup work. If used, it must be called right before calling
2511 * drm_atomic_state_put().
2513 * This is part of the atomic helper support for nonblocking commits, see
2514 * drm_atomic_helper_setup_commit() for an overview.
2516 void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state)
2518 struct drm_crtc *crtc;
2519 struct drm_crtc_state *old_crtc_state;
2520 struct drm_crtc_commit *commit;
2523 for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
2524 commit = old_crtc_state->commit;
2525 if (WARN_ON(!commit))
2528 complete_all(&commit->cleanup_done);
2529 WARN_ON(!try_wait_for_completion(&commit->hw_done));
2531 spin_lock(&crtc->commit_lock);
2532 list_del(&commit->commit_entry);
2533 spin_unlock(&crtc->commit_lock);
2536 if (old_state->fake_commit) {
2537 complete_all(&old_state->fake_commit->cleanup_done);
2538 WARN_ON(!try_wait_for_completion(&old_state->fake_commit->hw_done));
2541 EXPORT_SYMBOL(drm_atomic_helper_commit_cleanup_done);
2544 * drm_atomic_helper_prepare_planes - prepare plane resources before commit
2546 * @state: atomic state object with new state structures
2548 * This function prepares plane state, specifically framebuffers, for the new
2549 * configuration, by calling &drm_plane_helper_funcs.prepare_fb. If any failure
2550 * is encountered this function will call &drm_plane_helper_funcs.cleanup_fb on
2551 * any already successfully prepared framebuffer.
2554 * 0 on success, negative error code on failure.
2556 int drm_atomic_helper_prepare_planes(struct drm_device *dev,
2557 struct drm_atomic_state *state)
2559 struct drm_connector *connector;
2560 struct drm_connector_state *new_conn_state;
2561 struct drm_plane *plane;
2562 struct drm_plane_state *new_plane_state;
2565 for_each_new_connector_in_state(state, connector, new_conn_state, i) {
2566 if (!new_conn_state->writeback_job)
2569 ret = drm_writeback_prepare_job(new_conn_state->writeback_job);
2574 for_each_new_plane_in_state(state, plane, new_plane_state, i) {
2575 const struct drm_plane_helper_funcs *funcs;
2577 funcs = plane->helper_private;
2579 if (funcs->prepare_fb) {
2580 ret = funcs->prepare_fb(plane, new_plane_state);
2582 goto fail_prepare_fb;
2584 WARN_ON_ONCE(funcs->cleanup_fb);
2586 if (!drm_core_check_feature(dev, DRIVER_GEM))
2589 ret = drm_gem_plane_helper_prepare_fb(plane, new_plane_state);
2591 goto fail_prepare_fb;
2595 for_each_new_plane_in_state(state, plane, new_plane_state, i) {
2596 const struct drm_plane_helper_funcs *funcs = plane->helper_private;
2598 if (funcs->begin_fb_access) {
2599 ret = funcs->begin_fb_access(plane, new_plane_state);
2601 goto fail_begin_fb_access;
2607 fail_begin_fb_access:
2608 for_each_new_plane_in_state(state, plane, new_plane_state, j) {
2609 const struct drm_plane_helper_funcs *funcs = plane->helper_private;
2614 if (funcs->end_fb_access)
2615 funcs->end_fb_access(plane, new_plane_state);
2617 i = j; /* set i to upper limit to cleanup all planes */
2619 for_each_new_plane_in_state(state, plane, new_plane_state, j) {
2620 const struct drm_plane_helper_funcs *funcs;
2625 funcs = plane->helper_private;
2627 if (funcs->cleanup_fb)
2628 funcs->cleanup_fb(plane, new_plane_state);
2633 EXPORT_SYMBOL(drm_atomic_helper_prepare_planes);
2635 static bool plane_crtc_active(const struct drm_plane_state *state)
2637 return state->crtc && state->crtc->state->active;
2641 * drm_atomic_helper_commit_planes - commit plane state
2643 * @old_state: atomic state object with old state structures
2644 * @flags: flags for committing plane state
2646 * This function commits the new plane state using the plane and atomic helper
2647 * functions for planes and CRTCs. It assumes that the atomic state has already
2648 * been pushed into the relevant object state pointers, since this step can no
2651 * It still requires the global state object @old_state to know which planes and
2652 * crtcs need to be updated though.
2654 * Note that this function does all plane updates across all CRTCs in one step.
2655 * If the hardware can't support this approach look at
2656 * drm_atomic_helper_commit_planes_on_crtc() instead.
2658 * Plane parameters can be updated by applications while the associated CRTC is
2659 * disabled. The DRM/KMS core will store the parameters in the plane state,
2660 * which will be available to the driver when the CRTC is turned on. As a result
2661 * most drivers don't need to be immediately notified of plane updates for a
2664 * Unless otherwise needed, drivers are advised to set the ACTIVE_ONLY flag in
2665 * @flags in order not to receive plane update notifications related to a
2666 * disabled CRTC. This avoids the need to manually ignore plane updates in
2667 * driver code when the driver and/or hardware can't or just don't need to deal
2668 * with updates on disabled CRTCs, for example when supporting runtime PM.
2670 * Drivers may set the NO_DISABLE_AFTER_MODESET flag in @flags if the relevant
2671 * display controllers require to disable a CRTC's planes when the CRTC is
2672 * disabled. This function would skip the &drm_plane_helper_funcs.atomic_disable
2673 * call for a plane if the CRTC of the old plane state needs a modesetting
2674 * operation. Of course, the drivers need to disable the planes in their CRTC
2675 * disable callbacks since no one else would do that.
2677 * The drm_atomic_helper_commit() default implementation doesn't set the
2678 * ACTIVE_ONLY flag to most closely match the behaviour of the legacy helpers.
2679 * This should not be copied blindly by drivers.
2681 void drm_atomic_helper_commit_planes(struct drm_device *dev,
2682 struct drm_atomic_state *old_state,
2685 struct drm_crtc *crtc;
2686 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
2687 struct drm_plane *plane;
2688 struct drm_plane_state *old_plane_state, *new_plane_state;
2690 bool active_only = flags & DRM_PLANE_COMMIT_ACTIVE_ONLY;
2691 bool no_disable = flags & DRM_PLANE_COMMIT_NO_DISABLE_AFTER_MODESET;
2693 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
2694 const struct drm_crtc_helper_funcs *funcs;
2696 funcs = crtc->helper_private;
2698 if (!funcs || !funcs->atomic_begin)
2701 if (active_only && !new_crtc_state->active)
2704 funcs->atomic_begin(crtc, old_state);
2707 for_each_oldnew_plane_in_state(old_state, plane, old_plane_state, new_plane_state, i) {
2708 const struct drm_plane_helper_funcs *funcs;
2711 funcs = plane->helper_private;
2716 disabling = drm_atomic_plane_disabling(old_plane_state,
2721 * Skip planes related to inactive CRTCs. If the plane
2722 * is enabled use the state of the current CRTC. If the
2723 * plane is being disabled use the state of the old
2724 * CRTC to avoid skipping planes being disabled on an
2727 if (!disabling && !plane_crtc_active(new_plane_state))
2729 if (disabling && !plane_crtc_active(old_plane_state))
2734 * Special-case disabling the plane if drivers support it.
2736 if (disabling && funcs->atomic_disable) {
2737 struct drm_crtc_state *crtc_state;
2739 crtc_state = old_plane_state->crtc->state;
2741 if (drm_atomic_crtc_needs_modeset(crtc_state) &&
2745 funcs->atomic_disable(plane, old_state);
2746 } else if (new_plane_state->crtc || disabling) {
2747 funcs->atomic_update(plane, old_state);
2749 if (!disabling && funcs->atomic_enable) {
2750 if (drm_atomic_plane_enabling(old_plane_state, new_plane_state))
2751 funcs->atomic_enable(plane, old_state);
2756 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
2757 const struct drm_crtc_helper_funcs *funcs;
2759 funcs = crtc->helper_private;
2761 if (!funcs || !funcs->atomic_flush)
2764 if (active_only && !new_crtc_state->active)
2767 funcs->atomic_flush(crtc, old_state);
2770 EXPORT_SYMBOL(drm_atomic_helper_commit_planes);
2773 * drm_atomic_helper_commit_planes_on_crtc - commit plane state for a CRTC
2774 * @old_crtc_state: atomic state object with the old CRTC state
2776 * This function commits the new plane state using the plane and atomic helper
2777 * functions for planes on the specific CRTC. It assumes that the atomic state
2778 * has already been pushed into the relevant object state pointers, since this
2779 * step can no longer fail.
2781 * This function is useful when plane updates should be done CRTC-by-CRTC
2782 * instead of one global step like drm_atomic_helper_commit_planes() does.
2784 * This function can only be savely used when planes are not allowed to move
2785 * between different CRTCs because this function doesn't handle inter-CRTC
2786 * dependencies. Callers need to ensure that either no such dependencies exist,
2787 * resolve them through ordering of commit calls or through some other means.
2790 drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state)
2792 const struct drm_crtc_helper_funcs *crtc_funcs;
2793 struct drm_crtc *crtc = old_crtc_state->crtc;
2794 struct drm_atomic_state *old_state = old_crtc_state->state;
2795 struct drm_crtc_state *new_crtc_state =
2796 drm_atomic_get_new_crtc_state(old_state, crtc);
2797 struct drm_plane *plane;
2798 unsigned int plane_mask;
2800 plane_mask = old_crtc_state->plane_mask;
2801 plane_mask |= new_crtc_state->plane_mask;
2803 crtc_funcs = crtc->helper_private;
2804 if (crtc_funcs && crtc_funcs->atomic_begin)
2805 crtc_funcs->atomic_begin(crtc, old_state);
2807 drm_for_each_plane_mask(plane, crtc->dev, plane_mask) {
2808 struct drm_plane_state *old_plane_state =
2809 drm_atomic_get_old_plane_state(old_state, plane);
2810 struct drm_plane_state *new_plane_state =
2811 drm_atomic_get_new_plane_state(old_state, plane);
2812 const struct drm_plane_helper_funcs *plane_funcs;
2815 plane_funcs = plane->helper_private;
2817 if (!old_plane_state || !plane_funcs)
2820 WARN_ON(new_plane_state->crtc &&
2821 new_plane_state->crtc != crtc);
2823 disabling = drm_atomic_plane_disabling(old_plane_state, new_plane_state);
2825 if (disabling && plane_funcs->atomic_disable) {
2826 plane_funcs->atomic_disable(plane, old_state);
2827 } else if (new_plane_state->crtc || disabling) {
2828 plane_funcs->atomic_update(plane, old_state);
2830 if (!disabling && plane_funcs->atomic_enable) {
2831 if (drm_atomic_plane_enabling(old_plane_state, new_plane_state))
2832 plane_funcs->atomic_enable(plane, old_state);
2837 if (crtc_funcs && crtc_funcs->atomic_flush)
2838 crtc_funcs->atomic_flush(crtc, old_state);
2840 EXPORT_SYMBOL(drm_atomic_helper_commit_planes_on_crtc);
2843 * drm_atomic_helper_disable_planes_on_crtc - helper to disable CRTC's planes
2844 * @old_crtc_state: atomic state object with the old CRTC state
2845 * @atomic: if set, synchronize with CRTC's atomic_begin/flush hooks
2847 * Disables all planes associated with the given CRTC. This can be
2848 * used for instance in the CRTC helper atomic_disable callback to disable
2851 * If the atomic-parameter is set the function calls the CRTC's
2852 * atomic_begin hook before and atomic_flush hook after disabling the
2855 * It is a bug to call this function without having implemented the
2856 * &drm_plane_helper_funcs.atomic_disable plane hook.
2859 drm_atomic_helper_disable_planes_on_crtc(struct drm_crtc_state *old_crtc_state,
2862 struct drm_crtc *crtc = old_crtc_state->crtc;
2863 const struct drm_crtc_helper_funcs *crtc_funcs =
2864 crtc->helper_private;
2865 struct drm_plane *plane;
2867 if (atomic && crtc_funcs && crtc_funcs->atomic_begin)
2868 crtc_funcs->atomic_begin(crtc, NULL);
2870 drm_atomic_crtc_state_for_each_plane(plane, old_crtc_state) {
2871 const struct drm_plane_helper_funcs *plane_funcs =
2872 plane->helper_private;
2877 WARN_ON(!plane_funcs->atomic_disable);
2878 if (plane_funcs->atomic_disable)
2879 plane_funcs->atomic_disable(plane, NULL);
2882 if (atomic && crtc_funcs && crtc_funcs->atomic_flush)
2883 crtc_funcs->atomic_flush(crtc, NULL);
2885 EXPORT_SYMBOL(drm_atomic_helper_disable_planes_on_crtc);
2888 * drm_atomic_helper_cleanup_planes - cleanup plane resources after commit
2890 * @old_state: atomic state object with old state structures
2892 * This function cleans up plane state, specifically framebuffers, from the old
2893 * configuration. Hence the old configuration must be perserved in @old_state to
2894 * be able to call this function.
2896 * This function must also be called on the new state when the atomic update
2897 * fails at any point after calling drm_atomic_helper_prepare_planes().
2899 void drm_atomic_helper_cleanup_planes(struct drm_device *dev,
2900 struct drm_atomic_state *old_state)
2902 struct drm_plane *plane;
2903 struct drm_plane_state *old_plane_state, *new_plane_state;
2906 for_each_oldnew_plane_in_state(old_state, plane, old_plane_state, new_plane_state, i) {
2907 const struct drm_plane_helper_funcs *funcs = plane->helper_private;
2909 if (funcs->end_fb_access)
2910 funcs->end_fb_access(plane, new_plane_state);
2913 for_each_oldnew_plane_in_state(old_state, plane, old_plane_state, new_plane_state, i) {
2914 const struct drm_plane_helper_funcs *funcs;
2915 struct drm_plane_state *plane_state;
2918 * This might be called before swapping when commit is aborted,
2919 * in which case we have to cleanup the new state.
2921 if (old_plane_state == plane->state)
2922 plane_state = new_plane_state;
2924 plane_state = old_plane_state;
2926 funcs = plane->helper_private;
2928 if (funcs->cleanup_fb)
2929 funcs->cleanup_fb(plane, plane_state);
2932 EXPORT_SYMBOL(drm_atomic_helper_cleanup_planes);
2935 * drm_atomic_helper_swap_state - store atomic state into current sw state
2936 * @state: atomic state
2937 * @stall: stall for preceding commits
2939 * This function stores the atomic state into the current state pointers in all
2940 * driver objects. It should be called after all failing steps have been done
2941 * and succeeded, but before the actual hardware state is committed.
2943 * For cleanup and error recovery the current state for all changed objects will
2944 * be swapped into @state.
2946 * With that sequence it fits perfectly into the plane prepare/cleanup sequence:
2948 * 1. Call drm_atomic_helper_prepare_planes() with the staged atomic state.
2950 * 2. Do any other steps that might fail.
2952 * 3. Put the staged state into the current state pointers with this function.
2954 * 4. Actually commit the hardware state.
2956 * 5. Call drm_atomic_helper_cleanup_planes() with @state, which since step 3
2957 * contains the old state. Also do any other cleanup required with that state.
2959 * @stall must be set when nonblocking commits for this driver directly access
2960 * the &drm_plane.state, &drm_crtc.state or &drm_connector.state pointer. With
2961 * the current atomic helpers this is almost always the case, since the helpers
2962 * don't pass the right state structures to the callbacks.
2966 * Returns 0 on success. Can return -ERESTARTSYS when @stall is true and the
2967 * waiting for the previous commits has been interrupted.
2969 int drm_atomic_helper_swap_state(struct drm_atomic_state *state,
2973 struct drm_connector *connector;
2974 struct drm_connector_state *old_conn_state, *new_conn_state;
2975 struct drm_crtc *crtc;
2976 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
2977 struct drm_plane *plane;
2978 struct drm_plane_state *old_plane_state, *new_plane_state;
2979 struct drm_crtc_commit *commit;
2980 struct drm_private_obj *obj;
2981 struct drm_private_state *old_obj_state, *new_obj_state;
2985 * We have to stall for hw_done here before
2986 * drm_atomic_helper_wait_for_dependencies() because flip
2987 * depth > 1 is not yet supported by all drivers. As long as
2988 * obj->state is directly dereferenced anywhere in the drivers
2989 * atomic_commit_tail function, then it's unsafe to swap state
2990 * before drm_atomic_helper_commit_hw_done() is called.
2993 for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) {
2994 commit = old_crtc_state->commit;
2999 ret = wait_for_completion_interruptible(&commit->hw_done);
3004 for_each_old_connector_in_state(state, connector, old_conn_state, i) {
3005 commit = old_conn_state->commit;
3010 ret = wait_for_completion_interruptible(&commit->hw_done);
3015 for_each_old_plane_in_state(state, plane, old_plane_state, i) {
3016 commit = old_plane_state->commit;
3021 ret = wait_for_completion_interruptible(&commit->hw_done);
3027 for_each_oldnew_connector_in_state(state, connector, old_conn_state, new_conn_state, i) {
3028 WARN_ON(connector->state != old_conn_state);
3030 old_conn_state->state = state;
3031 new_conn_state->state = NULL;
3033 state->connectors[i].state = old_conn_state;
3034 connector->state = new_conn_state;
3037 for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
3038 WARN_ON(crtc->state != old_crtc_state);
3040 old_crtc_state->state = state;
3041 new_crtc_state->state = NULL;
3043 state->crtcs[i].state = old_crtc_state;
3044 crtc->state = new_crtc_state;
3046 if (new_crtc_state->commit) {
3047 spin_lock(&crtc->commit_lock);
3048 list_add(&new_crtc_state->commit->commit_entry,
3049 &crtc->commit_list);
3050 spin_unlock(&crtc->commit_lock);
3052 new_crtc_state->commit->event = NULL;
3056 for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
3057 WARN_ON(plane->state != old_plane_state);
3059 old_plane_state->state = state;
3060 new_plane_state->state = NULL;
3062 state->planes[i].state = old_plane_state;
3063 plane->state = new_plane_state;
3066 for_each_oldnew_private_obj_in_state(state, obj, old_obj_state, new_obj_state, i) {
3067 WARN_ON(obj->state != old_obj_state);
3069 old_obj_state->state = state;
3070 new_obj_state->state = NULL;
3072 state->private_objs[i].state = old_obj_state;
3073 obj->state = new_obj_state;
3078 EXPORT_SYMBOL(drm_atomic_helper_swap_state);
3081 * drm_atomic_helper_update_plane - Helper for primary plane update using atomic
3082 * @plane: plane object to update
3083 * @crtc: owning CRTC of owning plane
3084 * @fb: framebuffer to flip onto plane
3085 * @crtc_x: x offset of primary plane on @crtc
3086 * @crtc_y: y offset of primary plane on @crtc
3087 * @crtc_w: width of primary plane rectangle on @crtc
3088 * @crtc_h: height of primary plane rectangle on @crtc
3089 * @src_x: x offset of @fb for panning
3090 * @src_y: y offset of @fb for panning
3091 * @src_w: width of source rectangle in @fb
3092 * @src_h: height of source rectangle in @fb
3093 * @ctx: lock acquire context
3095 * Provides a default plane update handler using the atomic driver interface.
3098 * Zero on success, error code on failure
3100 int drm_atomic_helper_update_plane(struct drm_plane *plane,
3101 struct drm_crtc *crtc,
3102 struct drm_framebuffer *fb,
3103 int crtc_x, int crtc_y,
3104 unsigned int crtc_w, unsigned int crtc_h,
3105 uint32_t src_x, uint32_t src_y,
3106 uint32_t src_w, uint32_t src_h,
3107 struct drm_modeset_acquire_ctx *ctx)
3109 struct drm_atomic_state *state;
3110 struct drm_plane_state *plane_state;
3113 state = drm_atomic_state_alloc(plane->dev);
3117 state->acquire_ctx = ctx;
3118 plane_state = drm_atomic_get_plane_state(state, plane);
3119 if (IS_ERR(plane_state)) {
3120 ret = PTR_ERR(plane_state);
3124 ret = drm_atomic_set_crtc_for_plane(plane_state, crtc);
3127 drm_atomic_set_fb_for_plane(plane_state, fb);
3128 plane_state->crtc_x = crtc_x;
3129 plane_state->crtc_y = crtc_y;
3130 plane_state->crtc_w = crtc_w;
3131 plane_state->crtc_h = crtc_h;
3132 plane_state->src_x = src_x;
3133 plane_state->src_y = src_y;
3134 plane_state->src_w = src_w;
3135 plane_state->src_h = src_h;
3137 if (plane == crtc->cursor)
3138 state->legacy_cursor_update = true;
3140 ret = drm_atomic_commit(state);
3142 drm_atomic_state_put(state);
3145 EXPORT_SYMBOL(drm_atomic_helper_update_plane);
3148 * drm_atomic_helper_disable_plane - Helper for primary plane disable using * atomic
3149 * @plane: plane to disable
3150 * @ctx: lock acquire context
3152 * Provides a default plane disable handler using the atomic driver interface.
3155 * Zero on success, error code on failure
3157 int drm_atomic_helper_disable_plane(struct drm_plane *plane,
3158 struct drm_modeset_acquire_ctx *ctx)
3160 struct drm_atomic_state *state;
3161 struct drm_plane_state *plane_state;
3164 state = drm_atomic_state_alloc(plane->dev);
3168 state->acquire_ctx = ctx;
3169 plane_state = drm_atomic_get_plane_state(state, plane);
3170 if (IS_ERR(plane_state)) {
3171 ret = PTR_ERR(plane_state);
3175 if (plane_state->crtc && plane_state->crtc->cursor == plane)
3176 plane_state->state->legacy_cursor_update = true;
3178 ret = __drm_atomic_helper_disable_plane(plane, plane_state);
3182 ret = drm_atomic_commit(state);
3184 drm_atomic_state_put(state);
3187 EXPORT_SYMBOL(drm_atomic_helper_disable_plane);
3190 * drm_atomic_helper_set_config - set a new config from userspace
3191 * @set: mode set configuration
3192 * @ctx: lock acquisition context
3194 * Provides a default CRTC set_config handler using the atomic driver interface.
3196 * NOTE: For backwards compatibility with old userspace this automatically
3197 * resets the "link-status" property to GOOD, to force any link
3198 * re-training. The SETCRTC ioctl does not define whether an update does
3199 * need a full modeset or just a plane update, hence we're allowed to do
3200 * that. See also drm_connector_set_link_status_property().
3203 * Returns 0 on success, negative errno numbers on failure.
3205 int drm_atomic_helper_set_config(struct drm_mode_set *set,
3206 struct drm_modeset_acquire_ctx *ctx)
3208 struct drm_atomic_state *state;
3209 struct drm_crtc *crtc = set->crtc;
3212 state = drm_atomic_state_alloc(crtc->dev);
3216 state->acquire_ctx = ctx;
3217 ret = __drm_atomic_helper_set_config(set, state);
3221 ret = handle_conflicting_encoders(state, true);
3225 ret = drm_atomic_commit(state);
3228 drm_atomic_state_put(state);
3231 EXPORT_SYMBOL(drm_atomic_helper_set_config);
3234 * drm_atomic_helper_disable_all - disable all currently active outputs
3236 * @ctx: lock acquisition context
3238 * Loops through all connectors, finding those that aren't turned off and then
3239 * turns them off by setting their DPMS mode to OFF and deactivating the CRTC
3240 * that they are connected to.
3242 * This is used for example in suspend/resume to disable all currently active
3243 * functions when suspending. If you just want to shut down everything at e.g.
3244 * driver unload, look at drm_atomic_helper_shutdown().
3246 * Note that if callers haven't already acquired all modeset locks this might
3247 * return -EDEADLK, which must be handled by calling drm_modeset_backoff().
3250 * 0 on success or a negative error code on failure.
3253 * drm_atomic_helper_suspend(), drm_atomic_helper_resume() and
3254 * drm_atomic_helper_shutdown().
3256 int drm_atomic_helper_disable_all(struct drm_device *dev,
3257 struct drm_modeset_acquire_ctx *ctx)
3259 struct drm_atomic_state *state;
3260 struct drm_connector_state *conn_state;
3261 struct drm_connector *conn;
3262 struct drm_plane_state *plane_state;
3263 struct drm_plane *plane;
3264 struct drm_crtc_state *crtc_state;
3265 struct drm_crtc *crtc;
3268 state = drm_atomic_state_alloc(dev);
3272 state->acquire_ctx = ctx;
3274 drm_for_each_crtc(crtc, dev) {
3275 crtc_state = drm_atomic_get_crtc_state(state, crtc);
3276 if (IS_ERR(crtc_state)) {
3277 ret = PTR_ERR(crtc_state);
3281 crtc_state->active = false;
3283 ret = drm_atomic_set_mode_prop_for_crtc(crtc_state, NULL);
3287 ret = drm_atomic_add_affected_planes(state, crtc);
3291 ret = drm_atomic_add_affected_connectors(state, crtc);
3296 for_each_new_connector_in_state(state, conn, conn_state, i) {
3297 ret = drm_atomic_set_crtc_for_connector(conn_state, NULL);
3302 for_each_new_plane_in_state(state, plane, plane_state, i) {
3303 ret = drm_atomic_set_crtc_for_plane(plane_state, NULL);
3307 drm_atomic_set_fb_for_plane(plane_state, NULL);
3310 ret = drm_atomic_commit(state);
3312 drm_atomic_state_put(state);
3315 EXPORT_SYMBOL(drm_atomic_helper_disable_all);
3318 * drm_atomic_helper_shutdown - shutdown all CRTC
3321 * This shuts down all CRTC, which is useful for driver unloading. Shutdown on
3322 * suspend should instead be handled with drm_atomic_helper_suspend(), since
3323 * that also takes a snapshot of the modeset state to be restored on resume.
3325 * This is just a convenience wrapper around drm_atomic_helper_disable_all(),
3326 * and it is the atomic version of drm_crtc_force_disable_all().
3328 void drm_atomic_helper_shutdown(struct drm_device *dev)
3330 struct drm_modeset_acquire_ctx ctx;
3333 DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret);
3335 ret = drm_atomic_helper_disable_all(dev, &ctx);
3338 "Disabling all crtc's during unload failed with %i\n",
3341 DRM_MODESET_LOCK_ALL_END(dev, ctx, ret);
3343 EXPORT_SYMBOL(drm_atomic_helper_shutdown);
3346 * drm_atomic_helper_duplicate_state - duplicate an atomic state object
3348 * @ctx: lock acquisition context
3350 * Makes a copy of the current atomic state by looping over all objects and
3351 * duplicating their respective states. This is used for example by suspend/
3352 * resume support code to save the state prior to suspend such that it can
3353 * be restored upon resume.
3355 * Note that this treats atomic state as persistent between save and restore.
3356 * Drivers must make sure that this is possible and won't result in confusion
3357 * or erroneous behaviour.
3359 * Note that if callers haven't already acquired all modeset locks this might
3360 * return -EDEADLK, which must be handled by calling drm_modeset_backoff().
3363 * A pointer to the copy of the atomic state object on success or an
3364 * ERR_PTR()-encoded error code on failure.
3367 * drm_atomic_helper_suspend(), drm_atomic_helper_resume()
3369 struct drm_atomic_state *
3370 drm_atomic_helper_duplicate_state(struct drm_device *dev,
3371 struct drm_modeset_acquire_ctx *ctx)
3373 struct drm_atomic_state *state;
3374 struct drm_connector *conn;
3375 struct drm_connector_list_iter conn_iter;
3376 struct drm_plane *plane;
3377 struct drm_crtc *crtc;
3380 state = drm_atomic_state_alloc(dev);
3382 return ERR_PTR(-ENOMEM);
3384 state->acquire_ctx = ctx;
3385 state->duplicated = true;
3387 drm_for_each_crtc(crtc, dev) {
3388 struct drm_crtc_state *crtc_state;
3390 crtc_state = drm_atomic_get_crtc_state(state, crtc);
3391 if (IS_ERR(crtc_state)) {
3392 err = PTR_ERR(crtc_state);
3397 drm_for_each_plane(plane, dev) {
3398 struct drm_plane_state *plane_state;
3400 plane_state = drm_atomic_get_plane_state(state, plane);
3401 if (IS_ERR(plane_state)) {
3402 err = PTR_ERR(plane_state);
3407 drm_connector_list_iter_begin(dev, &conn_iter);
3408 drm_for_each_connector_iter(conn, &conn_iter) {
3409 struct drm_connector_state *conn_state;
3411 conn_state = drm_atomic_get_connector_state(state, conn);
3412 if (IS_ERR(conn_state)) {
3413 err = PTR_ERR(conn_state);
3414 drm_connector_list_iter_end(&conn_iter);
3418 drm_connector_list_iter_end(&conn_iter);
3420 /* clear the acquire context so that it isn't accidentally reused */
3421 state->acquire_ctx = NULL;
3425 drm_atomic_state_put(state);
3426 state = ERR_PTR(err);
3431 EXPORT_SYMBOL(drm_atomic_helper_duplicate_state);
3434 * drm_atomic_helper_suspend - subsystem-level suspend helper
3437 * Duplicates the current atomic state, disables all active outputs and then
3438 * returns a pointer to the original atomic state to the caller. Drivers can
3439 * pass this pointer to the drm_atomic_helper_resume() helper upon resume to
3440 * restore the output configuration that was active at the time the system
3443 * Note that it is potentially unsafe to use this. The atomic state object
3444 * returned by this function is assumed to be persistent. Drivers must ensure
3445 * that this holds true. Before calling this function, drivers must make sure
3446 * to suspend fbdev emulation so that nothing can be using the device.
3449 * A pointer to a copy of the state before suspend on success or an ERR_PTR()-
3450 * encoded error code on failure. Drivers should store the returned atomic
3451 * state object and pass it to the drm_atomic_helper_resume() helper upon
3455 * drm_atomic_helper_duplicate_state(), drm_atomic_helper_disable_all(),
3456 * drm_atomic_helper_resume(), drm_atomic_helper_commit_duplicated_state()
3458 struct drm_atomic_state *drm_atomic_helper_suspend(struct drm_device *dev)
3460 struct drm_modeset_acquire_ctx ctx;
3461 struct drm_atomic_state *state;
3464 /* This can never be returned, but it makes the compiler happy */
3465 state = ERR_PTR(-EINVAL);
3467 DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, err);
3469 state = drm_atomic_helper_duplicate_state(dev, &ctx);
3473 err = drm_atomic_helper_disable_all(dev, &ctx);
3475 drm_atomic_state_put(state);
3476 state = ERR_PTR(err);
3481 DRM_MODESET_LOCK_ALL_END(dev, ctx, err);
3483 return ERR_PTR(err);
3487 EXPORT_SYMBOL(drm_atomic_helper_suspend);
3490 * drm_atomic_helper_commit_duplicated_state - commit duplicated state
3491 * @state: duplicated atomic state to commit
3492 * @ctx: pointer to acquire_ctx to use for commit.
3494 * The state returned by drm_atomic_helper_duplicate_state() and
3495 * drm_atomic_helper_suspend() is partially invalid, and needs to
3496 * be fixed up before commit.
3499 * 0 on success or a negative error code on failure.
3502 * drm_atomic_helper_suspend()
3504 int drm_atomic_helper_commit_duplicated_state(struct drm_atomic_state *state,
3505 struct drm_modeset_acquire_ctx *ctx)
3508 struct drm_plane *plane;
3509 struct drm_plane_state *new_plane_state;
3510 struct drm_connector *connector;
3511 struct drm_connector_state *new_conn_state;
3512 struct drm_crtc *crtc;
3513 struct drm_crtc_state *new_crtc_state;
3515 state->acquire_ctx = ctx;
3517 for_each_new_plane_in_state(state, plane, new_plane_state, i)
3518 state->planes[i].old_state = plane->state;
3520 for_each_new_crtc_in_state(state, crtc, new_crtc_state, i)
3521 state->crtcs[i].old_state = crtc->state;
3523 for_each_new_connector_in_state(state, connector, new_conn_state, i)
3524 state->connectors[i].old_state = connector->state;
3526 ret = drm_atomic_commit(state);
3528 state->acquire_ctx = NULL;
3532 EXPORT_SYMBOL(drm_atomic_helper_commit_duplicated_state);
3535 * drm_atomic_helper_resume - subsystem-level resume helper
3537 * @state: atomic state to resume to
3539 * Calls drm_mode_config_reset() to synchronize hardware and software states,
3540 * grabs all modeset locks and commits the atomic state object. This can be
3541 * used in conjunction with the drm_atomic_helper_suspend() helper to
3542 * implement suspend/resume for drivers that support atomic mode-setting.
3545 * 0 on success or a negative error code on failure.
3548 * drm_atomic_helper_suspend()
3550 int drm_atomic_helper_resume(struct drm_device *dev,
3551 struct drm_atomic_state *state)
3553 struct drm_modeset_acquire_ctx ctx;
3556 drm_mode_config_reset(dev);
3558 DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, err);
3560 err = drm_atomic_helper_commit_duplicated_state(state, &ctx);
3562 DRM_MODESET_LOCK_ALL_END(dev, ctx, err);
3563 drm_atomic_state_put(state);
3567 EXPORT_SYMBOL(drm_atomic_helper_resume);
3569 static int page_flip_common(struct drm_atomic_state *state,
3570 struct drm_crtc *crtc,
3571 struct drm_framebuffer *fb,
3572 struct drm_pending_vblank_event *event,
3575 struct drm_plane *plane = crtc->primary;
3576 struct drm_plane_state *plane_state;
3577 struct drm_crtc_state *crtc_state;
3580 crtc_state = drm_atomic_get_crtc_state(state, crtc);
3581 if (IS_ERR(crtc_state))
3582 return PTR_ERR(crtc_state);
3584 crtc_state->event = event;
3585 crtc_state->async_flip = flags & DRM_MODE_PAGE_FLIP_ASYNC;
3587 plane_state = drm_atomic_get_plane_state(state, plane);
3588 if (IS_ERR(plane_state))
3589 return PTR_ERR(plane_state);
3591 ret = drm_atomic_set_crtc_for_plane(plane_state, crtc);
3594 drm_atomic_set_fb_for_plane(plane_state, fb);
3596 /* Make sure we don't accidentally do a full modeset. */
3597 state->allow_modeset = false;
3598 if (!crtc_state->active) {
3599 drm_dbg_atomic(crtc->dev,
3600 "[CRTC:%d:%s] disabled, rejecting legacy flip\n",
3601 crtc->base.id, crtc->name);
3609 * drm_atomic_helper_page_flip - execute a legacy page flip
3611 * @fb: DRM framebuffer
3612 * @event: optional DRM event to signal upon completion
3613 * @flags: flip flags for non-vblank sync'ed updates
3614 * @ctx: lock acquisition context
3616 * Provides a default &drm_crtc_funcs.page_flip implementation
3617 * using the atomic driver interface.
3620 * Returns 0 on success, negative errno numbers on failure.
3623 * drm_atomic_helper_page_flip_target()
3625 int drm_atomic_helper_page_flip(struct drm_crtc *crtc,
3626 struct drm_framebuffer *fb,
3627 struct drm_pending_vblank_event *event,
3629 struct drm_modeset_acquire_ctx *ctx)
3631 struct drm_plane *plane = crtc->primary;
3632 struct drm_atomic_state *state;
3635 state = drm_atomic_state_alloc(plane->dev);
3639 state->acquire_ctx = ctx;
3641 ret = page_flip_common(state, crtc, fb, event, flags);
3645 ret = drm_atomic_nonblocking_commit(state);
3647 drm_atomic_state_put(state);
3650 EXPORT_SYMBOL(drm_atomic_helper_page_flip);
3653 * drm_atomic_helper_page_flip_target - do page flip on target vblank period.
3655 * @fb: DRM framebuffer
3656 * @event: optional DRM event to signal upon completion
3657 * @flags: flip flags for non-vblank sync'ed updates
3658 * @target: specifying the target vblank period when the flip to take effect
3659 * @ctx: lock acquisition context
3661 * Provides a default &drm_crtc_funcs.page_flip_target implementation.
3662 * Similar to drm_atomic_helper_page_flip() with extra parameter to specify
3663 * target vblank period to flip.
3666 * Returns 0 on success, negative errno numbers on failure.
3668 int drm_atomic_helper_page_flip_target(struct drm_crtc *crtc,
3669 struct drm_framebuffer *fb,
3670 struct drm_pending_vblank_event *event,
3673 struct drm_modeset_acquire_ctx *ctx)
3675 struct drm_plane *plane = crtc->primary;
3676 struct drm_atomic_state *state;
3677 struct drm_crtc_state *crtc_state;
3680 state = drm_atomic_state_alloc(plane->dev);
3684 state->acquire_ctx = ctx;
3686 ret = page_flip_common(state, crtc, fb, event, flags);
3690 crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
3691 if (WARN_ON(!crtc_state)) {
3695 crtc_state->target_vblank = target;
3697 ret = drm_atomic_nonblocking_commit(state);
3699 drm_atomic_state_put(state);
3702 EXPORT_SYMBOL(drm_atomic_helper_page_flip_target);
3705 * drm_atomic_helper_bridge_propagate_bus_fmt() - Propagate output format to
3706 * the input end of a bridge
3707 * @bridge: bridge control structure
3708 * @bridge_state: new bridge state
3709 * @crtc_state: new CRTC state
3710 * @conn_state: new connector state
3711 * @output_fmt: tested output bus format
3712 * @num_input_fmts: will contain the size of the returned array
3714 * This helper is a pluggable implementation of the
3715 * &drm_bridge_funcs.atomic_get_input_bus_fmts operation for bridges that don't
3716 * modify the bus configuration between their input and their output. It
3717 * returns an array of input formats with a single element set to @output_fmt.
3720 * a valid format array of size @num_input_fmts, or NULL if the allocation
3724 drm_atomic_helper_bridge_propagate_bus_fmt(struct drm_bridge *bridge,
3725 struct drm_bridge_state *bridge_state,
3726 struct drm_crtc_state *crtc_state,
3727 struct drm_connector_state *conn_state,
3729 unsigned int *num_input_fmts)
3733 input_fmts = kzalloc(sizeof(*input_fmts), GFP_KERNEL);
3735 *num_input_fmts = 0;
3739 *num_input_fmts = 1;
3740 input_fmts[0] = output_fmt;
3743 EXPORT_SYMBOL(drm_atomic_helper_bridge_propagate_bus_fmt);