1 // SPDX-License-Identifier: GPL-2.0-only
3 * Copyright (C) 2013 Red Hat
7 #include <linux/file.h>
8 #include <linux/sync_file.h>
9 #include <linux/uaccess.h>
11 #include <drm/drm_drv.h>
12 #include <drm/drm_file.h>
13 #include <drm/drm_syncobj.h>
18 #include "msm_gpu_trace.h"
21 * Cmdstream submission:
24 static struct msm_gem_submit *submit_create(struct drm_device *dev,
26 struct msm_gpu_submitqueue *queue, uint32_t nr_bos,
29 static atomic_t ident = ATOMIC_INIT(0);
30 struct msm_gem_submit *submit;
34 sz = struct_size(submit, bos, nr_bos) +
35 ((u64)nr_cmds * sizeof(submit->cmd[0]));
38 return ERR_PTR(-ENOMEM);
40 submit = kzalloc(sz, GFP_KERNEL);
42 return ERR_PTR(-ENOMEM);
44 submit->hw_fence = msm_fence_alloc();
45 if (IS_ERR(submit->hw_fence)) {
46 ret = PTR_ERR(submit->hw_fence);
51 ret = drm_sched_job_init(&submit->base, queue->entity, queue);
53 kfree(submit->hw_fence);
58 kref_init(&submit->ref);
60 submit->aspace = queue->ctx->aspace;
62 submit->cmd = (void *)&submit->bos[nr_bos];
63 submit->queue = queue;
64 submit->pid = get_pid(task_pid(current));
65 submit->ring = gpu->rb[queue->ring_nr];
66 submit->fault_dumped = false;
68 /* Get a unique identifier for the submission for logging purposes */
69 submit->ident = atomic_inc_return(&ident) - 1;
71 INIT_LIST_HEAD(&submit->node);
76 void __msm_gem_submit_destroy(struct kref *kref)
78 struct msm_gem_submit *submit =
79 container_of(kref, struct msm_gem_submit, ref);
82 if (submit->fence_id) {
83 spin_lock(&submit->queue->idr_lock);
84 idr_remove(&submit->queue->fence_idr, submit->fence_id);
85 spin_unlock(&submit->queue->idr_lock);
88 dma_fence_put(submit->user_fence);
91 * If the submit is freed before msm_job_run(), then hw_fence is
92 * just some pre-allocated memory, not a reference counted fence.
93 * Once the job runs and the hw_fence is initialized, it will
94 * have a refcount of at least one, since the submit holds a ref
97 if (kref_read(&submit->hw_fence->refcount) == 0) {
98 kfree(submit->hw_fence);
100 dma_fence_put(submit->hw_fence);
103 put_pid(submit->pid);
104 msm_submitqueue_put(submit->queue);
106 for (i = 0; i < submit->nr_cmds; i++)
107 kfree(submit->cmd[i].relocs);
112 static int submit_lookup_objects(struct msm_gem_submit *submit,
113 struct drm_msm_gem_submit *args, struct drm_file *file)
118 for (i = 0; i < args->nr_bos; i++) {
119 struct drm_msm_gem_submit_bo submit_bo;
120 void __user *userptr =
121 u64_to_user_ptr(args->bos + (i * sizeof(submit_bo)));
123 /* make sure we don't have garbage flags, in case we hit
124 * error path before flags is initialized:
126 submit->bos[i].flags = 0;
128 if (copy_from_user(&submit_bo, userptr, sizeof(submit_bo))) {
134 /* at least one of READ and/or WRITE flags should be set: */
135 #define MANDATORY_FLAGS (MSM_SUBMIT_BO_READ | MSM_SUBMIT_BO_WRITE)
137 if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) ||
138 !(submit_bo.flags & MANDATORY_FLAGS)) {
139 DRM_ERROR("invalid flags: %x\n", submit_bo.flags);
145 submit->bos[i].handle = submit_bo.handle;
146 submit->bos[i].flags = submit_bo.flags;
147 /* in validate_objects() we figure out if this is true: */
148 submit->bos[i].iova = submit_bo.presumed;
151 spin_lock(&file->table_lock);
153 for (i = 0; i < args->nr_bos; i++) {
154 struct drm_gem_object *obj;
156 /* normally use drm_gem_object_lookup(), but for bulk lookup
157 * all under single table_lock just hit object_idr directly:
159 obj = idr_find(&file->object_idr, submit->bos[i].handle);
161 DRM_ERROR("invalid handle %u at index %u\n", submit->bos[i].handle, i);
166 drm_gem_object_get(obj);
168 submit->bos[i].obj = to_msm_bo(obj);
172 spin_unlock(&file->table_lock);
180 static int submit_lookup_cmds(struct msm_gem_submit *submit,
181 struct drm_msm_gem_submit *args, struct drm_file *file)
187 for (i = 0; i < args->nr_cmds; i++) {
188 struct drm_msm_gem_submit_cmd submit_cmd;
189 void __user *userptr =
190 u64_to_user_ptr(args->cmds + (i * sizeof(submit_cmd)));
192 ret = copy_from_user(&submit_cmd, userptr, sizeof(submit_cmd));
198 /* validate input from userspace: */
199 switch (submit_cmd.type) {
200 case MSM_SUBMIT_CMD_BUF:
201 case MSM_SUBMIT_CMD_IB_TARGET_BUF:
202 case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
205 DRM_ERROR("invalid type: %08x\n", submit_cmd.type);
209 if (submit_cmd.size % 4) {
210 DRM_ERROR("non-aligned cmdstream buffer size: %u\n",
216 submit->cmd[i].type = submit_cmd.type;
217 submit->cmd[i].size = submit_cmd.size / 4;
218 submit->cmd[i].offset = submit_cmd.submit_offset / 4;
219 submit->cmd[i].idx = submit_cmd.submit_idx;
220 submit->cmd[i].nr_relocs = submit_cmd.nr_relocs;
222 userptr = u64_to_user_ptr(submit_cmd.relocs);
224 sz = array_size(submit_cmd.nr_relocs,
225 sizeof(struct drm_msm_gem_submit_reloc));
226 /* check for overflow: */
227 if (sz == SIZE_MAX) {
231 submit->cmd[i].relocs = kmalloc(sz, GFP_KERNEL);
232 if (!submit->cmd[i].relocs) {
236 ret = copy_from_user(submit->cmd[i].relocs, userptr, sz);
247 /* Unwind bo state, according to cleanup_flags. In the success case, only
248 * the lock is dropped at the end of the submit (and active/pin ref is dropped
249 * later when the submit is retired).
251 static void submit_cleanup_bo(struct msm_gem_submit *submit, int i,
252 unsigned cleanup_flags)
254 struct drm_gem_object *obj = &submit->bos[i].obj->base;
255 unsigned flags = submit->bos[i].flags & cleanup_flags;
258 * Clear flags bit before dropping lock, so that the msm_job_run()
259 * path isn't racing with submit_cleanup() (ie. the read/modify/
260 * write is protected by the obj lock in all paths)
262 submit->bos[i].flags &= ~cleanup_flags;
264 if (flags & BO_VMA_PINNED)
265 msm_gem_vma_unpin(submit->bos[i].vma);
267 if (flags & BO_OBJ_PINNED)
268 msm_gem_unpin_locked(obj);
270 if (flags & BO_LOCKED)
271 dma_resv_unlock(obj->resv);
274 static void submit_unlock_unpin_bo(struct msm_gem_submit *submit, int i)
276 unsigned cleanup_flags = BO_VMA_PINNED | BO_OBJ_PINNED | BO_LOCKED;
277 submit_cleanup_bo(submit, i, cleanup_flags);
279 if (!(submit->bos[i].flags & BO_VALID))
280 submit->bos[i].iova = 0;
283 /* This is where we make sure all the bo's are reserved and pin'd: */
284 static int submit_lock_objects(struct msm_gem_submit *submit)
286 int contended, slow_locked = -1, i, ret = 0;
289 for (i = 0; i < submit->nr_bos; i++) {
290 struct msm_gem_object *msm_obj = submit->bos[i].obj;
292 if (slow_locked == i)
297 if (!(submit->bos[i].flags & BO_LOCKED)) {
298 ret = dma_resv_lock_interruptible(msm_obj->base.resv,
302 submit->bos[i].flags |= BO_LOCKED;
306 ww_acquire_done(&submit->ticket);
311 if (ret == -EALREADY) {
312 DRM_ERROR("handle %u at index %u already on submit list\n",
313 submit->bos[i].handle, i);
318 submit_unlock_unpin_bo(submit, i);
321 submit_unlock_unpin_bo(submit, slow_locked);
323 if (ret == -EDEADLK) {
324 struct msm_gem_object *msm_obj = submit->bos[contended].obj;
325 /* we lost out in a seqno race, lock and retry.. */
326 ret = dma_resv_lock_slow_interruptible(msm_obj->base.resv,
329 submit->bos[contended].flags |= BO_LOCKED;
330 slow_locked = contended;
334 /* Not expecting -EALREADY here, if the bo was already
335 * locked, we should have gotten -EALREADY already from
336 * the dma_resv_lock_interruptable() call.
338 WARN_ON_ONCE(ret == -EALREADY);
344 static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit)
348 for (i = 0; i < submit->nr_bos; i++) {
349 struct drm_gem_object *obj = &submit->bos[i].obj->base;
350 bool write = submit->bos[i].flags & MSM_SUBMIT_BO_WRITE;
352 /* NOTE: _reserve_shared() must happen before
353 * _add_shared_fence(), which makes this a slightly
354 * strange place to call it. OTOH this is a
355 * convenient can-fail point to hook it in.
357 ret = dma_resv_reserve_fences(obj->resv, 1);
361 /* If userspace has determined that explicit fencing is
362 * used, it can disable implicit sync on the entire
368 /* Otherwise userspace can ask for implicit sync to be
369 * disabled on specific buffers. This is useful for internal
370 * usermode driver managed buffers, suballocation, etc.
372 if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT)
375 ret = drm_sched_job_add_implicit_dependencies(&submit->base,
385 static int submit_pin_objects(struct msm_gem_submit *submit)
389 submit->valid = true;
391 for (i = 0; i < submit->nr_bos; i++) {
392 struct drm_gem_object *obj = &submit->bos[i].obj->base;
393 struct msm_gem_vma *vma;
395 /* if locking succeeded, pin bo: */
396 vma = msm_gem_get_vma_locked(obj, submit->aspace);
402 ret = msm_gem_pin_vma_locked(obj, vma);
406 submit->bos[i].flags |= BO_OBJ_PINNED | BO_VMA_PINNED;
407 submit->bos[i].vma = vma;
409 if (vma->iova == submit->bos[i].iova) {
410 submit->bos[i].flags |= BO_VALID;
412 submit->bos[i].iova = vma->iova;
413 /* iova changed, so address in cmdstream is not valid: */
414 submit->bos[i].flags &= ~BO_VALID;
415 submit->valid = false;
422 static void submit_attach_object_fences(struct msm_gem_submit *submit)
426 for (i = 0; i < submit->nr_bos; i++) {
427 struct drm_gem_object *obj = &submit->bos[i].obj->base;
429 if (submit->bos[i].flags & MSM_SUBMIT_BO_WRITE)
430 dma_resv_add_fence(obj->resv, submit->user_fence,
431 DMA_RESV_USAGE_WRITE);
432 else if (submit->bos[i].flags & MSM_SUBMIT_BO_READ)
433 dma_resv_add_fence(obj->resv, submit->user_fence,
434 DMA_RESV_USAGE_READ);
438 static int submit_bo(struct msm_gem_submit *submit, uint32_t idx,
439 struct msm_gem_object **obj, uint64_t *iova, bool *valid)
441 if (idx >= submit->nr_bos) {
442 DRM_ERROR("invalid buffer index: %u (out of %u)\n",
443 idx, submit->nr_bos);
448 *obj = submit->bos[idx].obj;
450 *iova = submit->bos[idx].iova;
452 *valid = !!(submit->bos[idx].flags & BO_VALID);
457 /* process the reloc's and patch up the cmdstream as needed: */
458 static int submit_reloc(struct msm_gem_submit *submit, struct msm_gem_object *obj,
459 uint32_t offset, uint32_t nr_relocs, struct drm_msm_gem_submit_reloc *relocs)
461 uint32_t i, last_offset = 0;
469 DRM_ERROR("non-aligned cmdstream buffer: %u\n", offset);
473 /* For now, just map the entire thing. Eventually we probably
474 * to do it page-by-page, w/ kmap() if not vmap()d..
476 ptr = msm_gem_get_vaddr_locked(&obj->base);
480 DBG("failed to map: %d", ret);
484 for (i = 0; i < nr_relocs; i++) {
485 struct drm_msm_gem_submit_reloc submit_reloc = relocs[i];
490 if (submit_reloc.submit_offset % 4) {
491 DRM_ERROR("non-aligned reloc offset: %u\n",
492 submit_reloc.submit_offset);
497 /* offset in dwords: */
498 off = submit_reloc.submit_offset / 4;
500 if ((off >= (obj->base.size / 4)) ||
501 (off < last_offset)) {
502 DRM_ERROR("invalid offset %u at reloc %u\n", off, i);
507 ret = submit_bo(submit, submit_reloc.reloc_idx, NULL, &iova, &valid);
514 iova += submit_reloc.reloc_offset;
516 if (submit_reloc.shift < 0)
517 iova >>= -submit_reloc.shift;
519 iova <<= submit_reloc.shift;
521 ptr[off] = iova | submit_reloc.or;
527 msm_gem_put_vaddr_locked(&obj->base);
532 /* Cleanup submit at end of ioctl. In the error case, this also drops
533 * references, unpins, and drops active refcnt. In the non-error case,
534 * this is done when the submit is retired.
536 static void submit_cleanup(struct msm_gem_submit *submit, bool error)
538 unsigned cleanup_flags = BO_LOCKED;
542 cleanup_flags |= BO_VMA_PINNED | BO_OBJ_PINNED;
544 for (i = 0; i < submit->nr_bos; i++) {
545 struct msm_gem_object *msm_obj = submit->bos[i].obj;
546 submit_cleanup_bo(submit, i, cleanup_flags);
548 drm_gem_object_put(&msm_obj->base);
552 void msm_submit_retire(struct msm_gem_submit *submit)
556 for (i = 0; i < submit->nr_bos; i++) {
557 struct drm_gem_object *obj = &submit->bos[i].obj->base;
559 drm_gem_object_put(obj);
563 struct msm_submit_post_dep {
564 struct drm_syncobj *syncobj;
566 struct dma_fence_chain *chain;
569 static struct drm_syncobj **msm_parse_deps(struct msm_gem_submit *submit,
570 struct drm_file *file,
571 uint64_t in_syncobjs_addr,
572 uint32_t nr_in_syncobjs,
573 size_t syncobj_stride)
575 struct drm_syncobj **syncobjs = NULL;
576 struct drm_msm_gem_submit_syncobj syncobj_desc = {0};
580 syncobjs = kcalloc(nr_in_syncobjs, sizeof(*syncobjs),
581 GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
583 return ERR_PTR(-ENOMEM);
585 for (i = 0; i < nr_in_syncobjs; ++i) {
586 uint64_t address = in_syncobjs_addr + i * syncobj_stride;
588 if (copy_from_user(&syncobj_desc,
589 u64_to_user_ptr(address),
590 min(syncobj_stride, sizeof(syncobj_desc)))) {
595 if (syncobj_desc.point &&
596 !drm_core_check_feature(submit->dev, DRIVER_SYNCOBJ_TIMELINE)) {
601 if (syncobj_desc.flags & ~MSM_SUBMIT_SYNCOBJ_FLAGS) {
606 ret = drm_sched_job_add_syncobj_dependency(&submit->base, file,
607 syncobj_desc.handle, syncobj_desc.point);
611 if (syncobj_desc.flags & MSM_SUBMIT_SYNCOBJ_RESET) {
613 drm_syncobj_find(file, syncobj_desc.handle);
622 for (j = 0; j <= i; ++j) {
624 drm_syncobj_put(syncobjs[j]);
632 static void msm_reset_syncobjs(struct drm_syncobj **syncobjs,
633 uint32_t nr_syncobjs)
637 for (i = 0; syncobjs && i < nr_syncobjs; ++i) {
639 drm_syncobj_replace_fence(syncobjs[i], NULL);
643 static struct msm_submit_post_dep *msm_parse_post_deps(struct drm_device *dev,
644 struct drm_file *file,
645 uint64_t syncobjs_addr,
646 uint32_t nr_syncobjs,
647 size_t syncobj_stride)
649 struct msm_submit_post_dep *post_deps;
650 struct drm_msm_gem_submit_syncobj syncobj_desc = {0};
654 post_deps = kcalloc(nr_syncobjs, sizeof(*post_deps),
655 GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
657 return ERR_PTR(-ENOMEM);
659 for (i = 0; i < nr_syncobjs; ++i) {
660 uint64_t address = syncobjs_addr + i * syncobj_stride;
662 if (copy_from_user(&syncobj_desc,
663 u64_to_user_ptr(address),
664 min(syncobj_stride, sizeof(syncobj_desc)))) {
669 post_deps[i].point = syncobj_desc.point;
671 if (syncobj_desc.flags) {
676 if (syncobj_desc.point) {
677 if (!drm_core_check_feature(dev,
678 DRIVER_SYNCOBJ_TIMELINE)) {
683 post_deps[i].chain = dma_fence_chain_alloc();
684 if (!post_deps[i].chain) {
690 post_deps[i].syncobj =
691 drm_syncobj_find(file, syncobj_desc.handle);
692 if (!post_deps[i].syncobj) {
699 for (j = 0; j <= i; ++j) {
700 dma_fence_chain_free(post_deps[j].chain);
701 if (post_deps[j].syncobj)
702 drm_syncobj_put(post_deps[j].syncobj);
712 static void msm_process_post_deps(struct msm_submit_post_dep *post_deps,
713 uint32_t count, struct dma_fence *fence)
717 for (i = 0; post_deps && i < count; ++i) {
718 if (post_deps[i].chain) {
719 drm_syncobj_add_point(post_deps[i].syncobj,
721 fence, post_deps[i].point);
722 post_deps[i].chain = NULL;
724 drm_syncobj_replace_fence(post_deps[i].syncobj,
730 int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
731 struct drm_file *file)
733 struct msm_drm_private *priv = dev->dev_private;
734 struct drm_msm_gem_submit *args = data;
735 struct msm_file_private *ctx = file->driver_priv;
736 struct msm_gem_submit *submit = NULL;
737 struct msm_gpu *gpu = priv->gpu;
738 struct msm_gpu_submitqueue *queue;
739 struct msm_ringbuffer *ring;
740 struct msm_submit_post_dep *post_deps = NULL;
741 struct drm_syncobj **syncobjs_to_reset = NULL;
742 int out_fence_fd = -1;
743 bool has_ww_ticket = false;
753 if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) {
754 DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n");
758 /* for now, we just have 3d pipe.. eventually this would need to
759 * be more clever to dispatch to appropriate gpu module:
761 if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0)
764 if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS)
767 if (args->flags & MSM_SUBMIT_SUDO) {
768 if (!IS_ENABLED(CONFIG_DRM_MSM_GPU_SUDO) ||
769 !capable(CAP_SYS_RAWIO))
773 queue = msm_submitqueue_get(ctx, args->queueid);
777 ring = gpu->rb[queue->ring_nr];
779 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
780 out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
781 if (out_fence_fd < 0) {
783 goto out_post_unlock;
787 submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds);
788 if (IS_ERR(submit)) {
789 ret = PTR_ERR(submit);
790 goto out_post_unlock;
793 trace_msm_gpu_submit(pid_nr(submit->pid), ring->id, submit->ident,
794 args->nr_bos, args->nr_cmds);
796 ret = mutex_lock_interruptible(&queue->lock);
798 goto out_post_unlock;
800 if (args->flags & MSM_SUBMIT_SUDO)
801 submit->in_rb = true;
803 if (args->flags & MSM_SUBMIT_FENCE_FD_IN) {
804 struct dma_fence *in_fence;
806 in_fence = sync_file_get_fence(args->fence_fd);
813 ret = drm_sched_job_add_dependency(&submit->base, in_fence);
818 if (args->flags & MSM_SUBMIT_SYNCOBJ_IN) {
819 syncobjs_to_reset = msm_parse_deps(submit, file,
821 args->nr_in_syncobjs,
822 args->syncobj_stride);
823 if (IS_ERR(syncobjs_to_reset)) {
824 ret = PTR_ERR(syncobjs_to_reset);
829 if (args->flags & MSM_SUBMIT_SYNCOBJ_OUT) {
830 post_deps = msm_parse_post_deps(dev, file,
832 args->nr_out_syncobjs,
833 args->syncobj_stride);
834 if (IS_ERR(post_deps)) {
835 ret = PTR_ERR(post_deps);
840 ret = submit_lookup_objects(submit, args, file);
844 ret = submit_lookup_cmds(submit, args, file);
848 /* copy_*_user while holding a ww ticket upsets lockdep */
849 ww_acquire_init(&submit->ticket, &reservation_ww_class);
850 has_ww_ticket = true;
851 ret = submit_lock_objects(submit);
855 ret = submit_fence_sync(submit, !!(args->flags & MSM_SUBMIT_NO_IMPLICIT));
859 ret = submit_pin_objects(submit);
863 for (i = 0; i < args->nr_cmds; i++) {
864 struct msm_gem_object *msm_obj;
867 ret = submit_bo(submit, submit->cmd[i].idx,
868 &msm_obj, &iova, NULL);
872 if (!submit->cmd[i].size ||
873 ((submit->cmd[i].size + submit->cmd[i].offset) >
874 msm_obj->base.size / 4)) {
875 DRM_ERROR("invalid cmdstream size: %u\n", submit->cmd[i].size * 4);
880 submit->cmd[i].iova = iova + (submit->cmd[i].offset * 4);
885 ret = submit_reloc(submit, msm_obj, submit->cmd[i].offset * 4,
886 submit->cmd[i].nr_relocs, submit->cmd[i].relocs);
893 idr_preload(GFP_KERNEL);
895 spin_lock(&queue->idr_lock);
898 * If using userspace provided seqno fence, validate that the id
899 * is available before arming sched job. Since access to fence_idr
900 * is serialized on the queue lock, the slot should be still avail
901 * after the job is armed
903 if ((args->flags & MSM_SUBMIT_FENCE_SN_IN) &&
904 (!args->fence || idr_find(&queue->fence_idr, args->fence))) {
905 spin_unlock(&queue->idr_lock);
911 drm_sched_job_arm(&submit->base);
913 submit->user_fence = dma_fence_get(&submit->base.s_fence->finished);
915 if (args->flags & MSM_SUBMIT_FENCE_SN_IN) {
917 * Userspace has assigned the seqno fence that it wants
918 * us to use. It is an error to pick a fence sequence
919 * number that is not available.
921 submit->fence_id = args->fence;
922 ret = idr_alloc_u32(&queue->fence_idr, submit->user_fence,
923 &submit->fence_id, submit->fence_id,
926 * We've already validated that the fence_id slot is valid,
927 * so if idr_alloc_u32 failed, it is a kernel bug
932 * Allocate an id which can be used by WAIT_FENCE ioctl to map
933 * back to the underlying fence.
935 submit->fence_id = idr_alloc_cyclic(&queue->fence_idr,
936 submit->user_fence, 1,
937 INT_MAX, GFP_NOWAIT);
940 spin_unlock(&queue->idr_lock);
943 if (submit->fence_id < 0) {
944 ret = submit->fence_id;
945 submit->fence_id = 0;
948 if (ret == 0 && args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
949 struct sync_file *sync_file = sync_file_create(submit->user_fence);
953 fd_install(out_fence_fd, sync_file->file);
954 args->fence_fd = out_fence_fd;
958 submit_attach_object_fences(submit);
960 /* The scheduler owns a ref now: */
961 msm_gem_submit_get(submit);
963 msm_rd_dump_submit(priv->rd, submit, NULL);
965 drm_sched_entity_push_job(&submit->base);
967 args->fence = submit->fence_id;
968 queue->last_fence = submit->fence_id;
970 msm_reset_syncobjs(syncobjs_to_reset, args->nr_in_syncobjs);
971 msm_process_post_deps(post_deps, args->nr_out_syncobjs,
976 submit_cleanup(submit, !!ret);
978 ww_acquire_fini(&submit->ticket);
980 mutex_unlock(&queue->lock);
982 if (ret && (out_fence_fd >= 0))
983 put_unused_fd(out_fence_fd);
985 if (!IS_ERR_OR_NULL(submit)) {
986 msm_gem_submit_put(submit);
989 * If the submit hasn't yet taken ownership of the queue
990 * then we need to drop the reference ourself:
992 msm_submitqueue_put(queue);
994 if (!IS_ERR_OR_NULL(post_deps)) {
995 for (i = 0; i < args->nr_out_syncobjs; ++i) {
996 kfree(post_deps[i].chain);
997 drm_syncobj_put(post_deps[i].syncobj);
1002 if (!IS_ERR_OR_NULL(syncobjs_to_reset)) {
1003 for (i = 0; i < args->nr_in_syncobjs; ++i) {
1004 if (syncobjs_to_reset[i])
1005 drm_syncobj_put(syncobjs_to_reset[i]);
1007 kfree(syncobjs_to_reset);