]> Git Repo - buildroot-mgba.git/commitdiff
package/libvncserver: correct WITH_THREADS=ON/OFF logic
authorPeter Korsgaard <[email protected]>
Wed, 15 May 2024 14:59:02 +0000 (16:59 +0200)
committerYann E. MORIN <[email protected]>
Fri, 17 May 2024 14:37:36 +0000 (16:37 +0200)
Commit ee59023794f5540e5 (package/libvncserver: bump to version 0.9.12)
changes the package from autotools to cmake and accidently inverted the
threads logic.

The reason this was not noticed is that the build system verifies if threads
support works and otherwise disables it even when -DWITH_THREADS=ON is
passed, E.G.  for a nothread configuration:

cmake ... -DWITH_THREADS=ON ...
..
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - not found

Signed-off-by: Peter Korsgaard <[email protected]>
Signed-off-by: Yann E. MORIN <[email protected]>
package/libvncserver/libvncserver.mk

index 3a15a82d0800640f39962d81f802068b85071be7..082f838f1229af14d9d4052a2bc693defdcff0ee 100644 (file)
@@ -22,7 +22,7 @@ LIBVNCSERVER_CONF_OPTS += \
        -DWITH_SDL=OFF \
        -DWITH_TESTS=OFF
 
-ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 LIBVNCSERVER_CONF_OPTS += -DWITH_THREADS=ON
 else
 LIBVNCSERVER_CONF_OPTS += -DWITH_THREADS=OFF
This page took 0.038191 seconds and 4 git commands to generate.