]> Git Repo - buildroot-mgba.git/commitdiff
Revert "support/dependencies: don't check for `which'"
authorYann E. MORIN <[email protected]>
Fri, 1 Oct 2021 18:04:25 +0000 (20:04 +0200)
committerYann E. MORIN <[email protected]>
Fri, 1 Oct 2021 18:09:55 +0000 (20:09 +0200)
This reverts commit a95c353a46247db036862ad839c095ca9ae4f690.

Switching to using 'command -v' instead of 'which', opened a can of
worms that is hard to fix in a timely manner:

  - recursive call to 'make' from a post-build, post-iamge script, fails
    because of a redefinition of HOSTCC_NOCCACHE (a bug on its own that
    needs a separate fix anyway) [0];

  - 'make' believeing it can call "simple" commands with execve() et al.
    instead of passing them through a shell via system(), and thus
    failing to find 'command' in the PATH [1].

[0] https://lore.kernel.org/buildroot/20211001175329[email protected]/T/#m95c17eb8374e4e3dd6eee700d397aa12cca0739e
[1] https://lore.kernel.org/buildroot/20211001180304.GV1504958@scaer/T/#m3a8f36bd76ec7d8e5038a6c8932bb6ffe23ea268

Signed-off-by: Yann E. MORIN <[email protected]>
support/dependencies/dependencies.sh

index a3e0b3ecc4319f29952b031c4f29f77d5f661101..c5dcb8623153c8689db49f8a3f9d65ca3c03ca6f 100755 (executable)
@@ -65,6 +65,8 @@ check_prog_host()
        fi
 }
 
+# Verify that which is installed
+check_prog_host "which"
 # Verify that sed is installed
 check_prog_host "sed"
 
This page took 0.03362 seconds and 4 git commands to generate.