Ensure bfd_close after bfd_openw so we don't get multiple bfd_openw

calls for same file.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 7ee94d4ae743673acf6500f59d20bdc53cff19c4..6365b7121f6a483e3903309af4aab657fd113ba4 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2000-05-24  Alan Modra  <[email protected]>
+
+       * objdump.c (display_target_list): Close the bfd.
+       (display_info_table): Likewise.
+
 2000-05-14  H.J. Lu  ([email protected])
 
        * objcopy.c (filter_symbols): Don't strip global symbols in

diff --git a/binutils/objdump.c b/binutils/objdump.c
index cd61ec0d8dceb008820e0f88bfd00803a1781178..522f6ec217472e44a34887b359be0fd74fcd407f 100644 (file)
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -2653,6 +2653,7 @@ display_target_list ()
        {
          if (bfd_get_error () != bfd_error_invalid_operation)
            nonfatal (p->name);
+         bfd_close (abfd);
          continue;
        }
 
@@ -2660,6 +2661,7 @@ display_target_list ()
        if (bfd_set_arch_mach (abfd, (enum bfd_architecture) a, 0))
          printf ("  %s\n",
                  bfd_printable_arch_mach ((enum bfd_architecture) a, 0));
+      bfd_close (abfd);
     }
   unlink (dummy_name);
   free (dummy_name);
@@ -2727,6 +2729,8 @@ display_info_table (first, last)
                  putchar ('-');
                putchar (' ');
              }
+           if (abfd != NULL)
+             bfd_close (abfd);
          }
        putchar ('\n');
       }