Adjust handling of Ada DIEs after dwarf2_physname patch.

        * dwarf2read.c (dwarf2_compute_name): Add handling of Ada DIEs.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d41f036cf02e4a5c46b7d2f6b2d210ba77f0a566..88187f1ff843bdc1d499133d663109e08078fb21 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-09  Joel Brobecker  <[email protected]>
+
+       Adjust handling of Ada DIEs after dwarf2_physname patch.
+       * dwarf2read.c (dwarf2_compute_name): Add handling of Ada DIEs.
+
 2010-03-09  Christopher Faylor  <[email protected]>
            Pierre Muller  <[email protected]>
 
@@ -127,8 +132,8 @@
 
        * python/python-internal.h: Include symtab.h.
 
-2010-03-09  Joel Brobecker <[email protected]>
-           Pierre Muller <[email protected]>
+2010-03-09  Joel Brobecker  <[email protected]>
+           Pierre Muller  <[email protected]>
 
        * p-lang.c (is_pascal_string_type): Remove unneeded parentheses.
        * p-valprint.c (pascal_val_print): Remove undeed block and fix

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 1f25a456cf0229d3182b7c31ba4435398b55a7b9..fd75c74d43e1be66e1521b8d78b1e62c6147e2c4 100644 (file)
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -3324,6 +3324,9 @@ die_needs_namespace (struct die_info *die, struct dwarf2_cu *cu)
    compute the physname for the object, which include a method's
    formal parameters (C++/Java) and return type (Java).
 
+   For Ada, return the DIE's linkage name rather than the fully qualified
+   name.  PHYSNAME is ignored..
+
    The result is allocated on the objfile_obstack and canonicalized.  */
 
 static const char *
@@ -3396,6 +3399,19 @@ dwarf2_compute_name (char *name, struct die_info *die, struct dwarf2_cu *cu,
            }
        }
     }
+  else if (cu->language == language_ada)
+    {
+      /* For Ada unit, we prefer the linkage name over the name, as
+        the former contains the exported name, which the user expects
+        to be able to reference.  Ideally, we want the user to be able
+        to reference this entity using either natural or linkage name,
+        but we haven't started looking at this enhancement yet.  */
+      struct attribute *attr;
+
+      attr = dwarf2_attr (die, DW_AT_MIPS_linkage_name, cu);
+      if (attr && DW_STRING (attr))
+       name = DW_STRING (attr);
+    }
 
   return name;
 }