]> Git Repo - binutils.git/blob - gdb/ChangeLog
Remove struct tui_point
[binutils.git] / gdb / ChangeLog
1 2019-12-11  Tom Tromey  <[email protected]>
2
3         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
4         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
5         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
6         * tui/tui-data.h (struct tui_point): Remove.
7         (struct tui_gen_win_info) <origin>: Remove.
8         <x, y>: New fields.
9         * tui/tui-command.c (tui_cmd_window::resize): Update.
10
11 2019-12-11  Tom Tromey  <[email protected]>
12
13         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
14         Implement.
15         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
16         Implement.
17         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
18         method.
19         (struct tui_win_info) <min_height>: Implement.
20
21 2019-12-11  Tom Tromey  <[email protected]>
22
23         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
24         (struct tui_win_info) <can_box>: Update.
25
26 2019-12-11  Tom Tromey  <[email protected]>
27
28         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
29         method.
30         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
31         method.
32         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
33         method.
34         (struct tui_win_info) <max_height>: Now override.
35
36 2019-12-11  Joel Brobecker  <[email protected]>
37
38         * NEWS: Create a new section for the next release branch.
39         Rename the section of the current branch, now that it has
40         been cut.
41
42 2019-12-11  Joel Brobecker  <[email protected]>
43
44         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
45         * version.in: Bump version to 10.0.50.DATE-git.
46
47 2019-12-11  Tom Tromey  <[email protected]>
48
49         PR build/25268:
50         * gdbsupport/thread-pool.c (set_thread_name): New function.
51         (thread_pool::set_thread_count): Don't call pthread_setname_np.
52         (thread_pool::thread_function): Call set_thread_name.
53
54 2019-12-11  Tom Tromey  <[email protected]>
55
56         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
57         bfd_get_signed_8.
58
59 2019-12-11  Philippe Waroquiers  <[email protected]>
60
61         * NEWS: Document -raw-values option and the related setting commands.
62         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
63         only set it on when /r is given.
64         * valprint.c (value_print_option_defs): New element raw-values.
65         * Makefile.in: Add the new file.
66
67 2019-12-10  Christian Biesinger  <[email protected]>
68
69         * gdbsupport/safe-strerror.c: Supress the unused function warning
70         for select_strerror_r.
71
72 2019-12-10  Christian Biesinger  <[email protected]>
73
74         * config.in: Regenerate.
75         * configure: Regenerate.
76         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
77         safe_strerror instead of strerror.
78         * gdbsupport/common.m4: Don't check for strerror.
79         * gdbsupport/safe-strerror.c: Support both the glibc version
80         of strerror_r and the XSI version.
81
82 2019-12-10  Tom Tromey  <[email protected]>
83
84         * ada-typeprint.c (print_choices): Use a single "?".
85         (print_variant_part): Print "?" if the discriminant name
86         is not known.
87
88 2019-12-10  George Barrett  <[email protected]>
89
90         Fix scripted probe breakpoints.
91         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
92         declaration forward.
93         (breakpoint_ops_for_event_location_type)
94         (breakpoint_ops_for_event_location): Add function definitions.
95         (break_command_1, trace_command): Use
96         breakpoint_ops_for_event_location.
97         * breakpoint.h (breakpoint_ops_for_event_location): Add function
98         declarations.
99         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
100         breakpoint_ops_for_event_location.
101         * python/py-breakpoint.c (bppy_init): Use
102         breakpoint_ops_for_event_location.
103
104 2019-12-09  Tankut Baris Aktemur  <[email protected]>
105
106         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
107         when ranking an lvalue argument for an rvalue parameter.
108
109 2019-12-08  Wataru Ashihara  <[email protected]>
110
111         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
112         template argument for scoped_restore_tmpl from bool to int.
113
114 2019-12-07  Keith Seitz  <[email protected]>
115
116         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
117         (build_id_to_debug_bfd): Make static, rewriting to use
118         build_id_to_bfd_suffix.
119         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
120         adding `suffix' parameter. Append SUFFIX to file names
121         when searching for matching files.
122         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
123         (build_id_to_exec_bfd): Likewise.
124         * build-id.h (build_id_to_debug_bfd): Clarify that function
125         searches for BFD of debug info file.
126         (build_id_to_exec_bfd): Declare.
127         * corelow.c: Include build-id.h.
128         (locate_exec_from_corefile_build_id): New function.
129         (core_target_open): If no executable BFD is found,
130         search for a core file BFD using build-id.
131
132 2019-12-06  Christian Biesinger  <[email protected]>
133
134         * bcache.c: Put in namespace gdb.
135         * bcache.h: Likewise.
136         * gdbtypes.c (check_types_worklist): Update.
137         (types_deeply_equal): Update.
138         * macrotab.c (struct macro_table) <bcache>: Update.
139         (new_macro_table): Update.
140         * macrotab.h (struct bcache): Put this forward declaration
141         inside namespace gdb.
142         (new_macro_table): Update.
143         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
144         Update.
145         <macro_cache>: Update.
146         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
147
148 2019-12-06  Tom de Vries  <[email protected]>
149
150         PR symtab/24971
151         * block.c (best_symbol, better_symbol): New function.
152         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
153         decl.
154
155 2019-12-06  Tankut Baris Aktemur  <[email protected]>
156
157         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
158         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
159         for ranking see-through reference cases.
160
161 2019-12-06  Philippe Waroquiers  <[email protected]>
162         * stack.c (faas_command): Check a command is provided.
163         * thread.c (taas_command, tfaas_command): Likewise.
164
165 2019-12-05  Philippe Waroquiers  <[email protected]>
166         * inferior.c (prune_inferiors):  Only call delete_inferior,
167         Do not modify the inferior list.
168
169 2019-12-05  Simon Marchi  <[email protected]>
170
171         * c-exp.y: Update calls to lookup_typename,
172         lookup_signed_typename and lookup_unsigned_typename.
173         * c-lang.c (evaluate_subexp_c): Likewise.
174         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
175         Likewise.
176         * eval.c (binop_promote): Likewise.
177         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
178         (lookup_unsigned_typename): Likewise.
179         (lookup_signed_typename): Likewise.
180         * gdbtypes.h (lookup_unsigned_typename): Likewise.
181         (lookup_signed_typename): Likewise.
182         (lookup_typename): Likewise.
183         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
184         lookup_typename, lookup_signed_typename,
185         lookup_unsigned_typename.
186         * m2-exp.y: Likewise.
187         * printcmd.c (printf_wide_c_string): Likewise.
188         (ui_printf): Likewise.
189         * python/py-type.c (typy_lookup_typename): Likewise.
190         * python/py-xmethods.c (python_xmethod_worker::invoke):
191         Likewise.
192         * rust-exp.y: Likewise.
193
194 2019-12-04  Christian Biesinger  <[email protected]>
195
196         * configure.nat (obsd64): Add missing files x86-nat.o and
197         nat/x86-dregs.o.
198
199 2019-12-04  Tom Tromey  <[email protected]>
200
201         * valprint.c (val_print_string): Use metadata_style.
202         * go-valprint.c (print_go_string): Use metadata style.
203         * p-valprint.c (pascal_object_print_static_field): Use metadata
204         style.
205         * cp-valprint.c (cp_print_static_field): Use metadata style.
206
207 2019-12-04  Andrew Burgess  <[email protected]>
208             Chris January  <[email protected]>
209
210         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
211         tokens.
212         (typebase): New patterns for complex, single/double precision, and
213         single/double complex.
214         (f77_keywords): Change token for complex keyword, and add single,
215         double, and precision keywords.
216
217 2019-12-04  Simon Marchi  <[email protected]>
218
219         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
220         "info io_registers".
221
222 2019-12-04  Simon Marchi  <[email protected]>
223
224         * regcache.c (cooked_read_test): Initialize thread list of
225         mock_inferior.
226
227 2019-12-04  Simon Marchi  <[email protected]>
228
229         * aarch64-linux-tdep.c: Remove includes.
230
231 2019-12-04  Simon Marchi  <[email protected]>
232
233         * aarch64-tdep.c: Remove includes.
234
235 2019-12-04  Simon Marchi  <[email protected]>
236
237         * filtered-iterator.h (filtered_iterator) <operator==,
238         operator!=>: Compare wrapped iterators, not wrapped pointers.
239         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
240         unittests/filtered_iterator-selftests.c.
241         * unittests/filtered_iterator-selftests.c: New file.
242
243 2019-12-04  Tom Tromey  <[email protected]>
244
245         * gdbtypes.c (create_range_type): Inherit endianity
246         from base type.
247
248 2019-12-04  Tom Tromey  <[email protected]>
249
250         * ada-lang.c (decode_constrained_packed_array)
251         (ada_value_assign, value_assign_to_component): Update.
252         * dwarf2loc.c (rw_pieced_value, access_memory)
253         (dwarf2_compile_expr_to_ax): Update.
254         * dwarf2read.c (dwarf2_add_field): Update.
255         * eval.c (evaluate_subexp_standard): Update.
256         * gdbarch.c, gdbarch.h: Rebuild.
257         * gdbarch.sh (bits_big_endian): Remove.
258         * gdbtypes.h (union field_location): Update comment.
259         * target-descriptions.c (make_gdb_type): Update.
260         * valarith.c (value_bit_index): Update.
261         * value.c (struct value) <bitpos>: Update comment.
262         (unpack_bits_as_long, modify_field): Update.
263         * value.h (value_bitpos): Update comment.
264
265 2019-12-04  Tom Tromey  <[email protected]>
266
267         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
268         endian-ness.
269
270 2019-12-04  Tom Tromey  <[email protected]>
271
272         * dwarf2read.c (dwarf2_init_float_type)
273         (dwarf2_init_complex_target_type): Add byte_order parameter.
274         (read_base_type): Compute byte order earlier.
275         * gdbtypes.c (init_float_type): Add byte_order parameter.
276         * gdbtypes.h (init_float_type): Add byte_order parameter.
277
278 2019-12-04  Tom Tromey  <[email protected]>
279
280         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
281
282 2019-12-04  Tom Tromey  <[email protected]>
283
284         * dwarf2read.c (process_structure_scope): Initialize
285         "discr_offset".
286
287 2019-12-04  Andrew Burgess  <[email protected]>
288
289         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
290         add it into the search spec.
291         (parse_max_results_option): New function.
292         (mi_info_functions_or_variables): Parse -max-results flag and pass
293         it to mi_symbol_info.
294         (mi_cmd_symbol_info_modules): Likewise.
295         (mi_cmd_symbol_info_types): Likewise.
296         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
297         return type to bool, change result container into a set, and don't
298         add new results if we have enough already.
299         (global_symbol_searcher::add_matching_msymbols): Change return
300         type to bool, and don't add new results if we have enough already.
301         (sort_search_symbols_remove_dups): Delete.
302         (global_symbol_searcher::search): Early exit from search loop when
303         we have enough results.  Use a std::set to collect the results
304         from calling add_matching_symbols.
305         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
306         member function.
307         (global_symbol_searcher) <m_max_search_results>: New member
308         variable.
309         (global_symbol_searcher) <add_matching_symbols>: Update header
310         comment and change return type to bool.
311         (global_symbol_searcher) <add_matching_msymbols>: Update header
312         comment and change return type to bool.
313
314 2019-12-04  Andrew Burgess  <[email protected]>
315
316         * symtab.c (symbol_search::compare_search_syms): Update header
317         comment.
318         (global_symbol_searcher::is_suitable_msymbol): New function.
319         (global_symbol_searcher::expand_symtabs): New function.
320         (global_symbol_searcher::add_matching_symbols): New function.
321         (global_symbol_searcher::add_matching_msymbols): New function.
322         (global_symbol_searcher::search): Move most of the content
323         into the new functions above, and call them as needed.
324         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
325         function.
326         (global_symbol_searcher) <add_matching_symbols>: New member
327         function.
328         (global_symbol_searcher) <add_matching_msymbols>: New member
329         function.
330         (global_symbol_searcher) <is_suitable_msymbol>: New member
331         function.
332
333 2019-12-04  Andrew Burgess  <[email protected]>
334
335         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
336         -symbol-info-module-variables entries.
337         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
338         (mi_cmd_symbol_info_module_variables): Declare.
339         * mi/mi-symbol-cmds.c
340         (module_symbol_search_iterator): New typedef.
341         (output_module_symbols_in_single_module_and_file): New function.
342         (output_module_symbols_in_single_module): New function.
343         (mi_info_module_functions_or_variables): New function.
344         (mi_cmd_symbol_info_module_functions): New function.
345         (mi_cmd_symbol_info_module_variables): New function.
346         * NEWS: Mention new MI command.
347
348 2019-12-03  Christian Biesinger  <[email protected]>
349
350         * bcache.c (hash): Remove.
351         (hash_continue): Remove.
352         * bcache.h (hash): Remove.
353         (hash_continue): Remove.
354         (struct bcache) <ctor>: Update.
355         * psymtab.c (psymbol_hash): Update.
356         * stabsread.c (hashname): Update.
357         * utils.h (fast_hash): Add an argument for a start value,
358         defaulting to zero.
359
360 2019-12-03  Philippe Waroquiers  <[email protected]>
361         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
362         (destroy_block_symbol_cache): New function.
363         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
364         (resize_symbol_cache): Likewise.
365
366 2019-12-02  Tom Tromey  <[email protected]>
367
368         * unittests/tui-selftests.c (run_tests): Make conditional.
369         (_initialize_tui_selftest): Make conditional.
370
371 2019-12-02  Christian Biesinger  <[email protected]>
372
373         * aix-thread.c (debug_aix_thread): Change type to bool.
374
375 2019-12-02  Luis Machado  <[email protected]>
376
377         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
378
379 2019-12-01  Andrew Burgess  <[email protected]>
380
381         * dwarf2read.c (read_tag_string_type): Read the fields required to
382         make a dynamic string, and possibly create a dynamic range for the
383         string.
384         (attr_to_dynamic_prop): Setup is_reference based on the type of
385         attribute being processed.
386         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
387         (resolve_dynamic_array): Rename to...
388         (resolve_dynamic_array_or_string): ...this, update header comment,
389         and accept TYPE_CODE_STRING.
390         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
391
392 2019-12-01  Andrew Burgess  <[email protected]>
393
394         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
395         of its implementation from...
396         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
397         the new function.
398
399 2019-12-01  Andrew Burgess  <[email protected]>
400
401         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
402         create a range with stride where appropriate.
403         * f-valprint.c: Include 'gdbarch.h'.
404         (f77_print_array_1): Take the stride into account when walking the
405         array.  Also convert the stride into addressable units.
406         * gdbtypes.c (create_range_type): Initialise the stride to
407         constant zero.
408         (create_range_type_with_stride): New function, initialise the
409         range as normal, and then setup the stride.
410         (has_static_range): Include the stride here.  Also change the
411         return type to bool.
412         (create_array_type_with_stride): Consider the range stride if the
413         array isn't given its own stride.
414         (resolve_dynamic_range): Resolve the stride if needed.
415         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
416         (struct range_bounds) <flag_is_byte_stride>: New member variable.
417         (TYPE_BIT_STRIDE): Define.
418         (TYPE_ARRAY_BIT_STRIDE): Define.
419         (create_range_type_with_stride): Declare.
420         * valarith.c (value_subscripted_rvalue): Take range stride into
421         account when walking the array.
422
423 2019-12-01  Tom Tromey  <[email protected]>
424
425         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
426         specially.
427
428 2019-12-01  Tom Tromey  <[email protected]>
429
430         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
431         \0.
432         * unittests/tui-selftests.c: New file.
433         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
434
435 2019-12-01  Tom Tromey  <[email protected]>
436
437         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
438
439 2019-12-01  Tom Tromey  <[email protected]>
440
441         * NEWS: Document new settings.
442         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
443         * tui/tui-win.c (_initialize_tui_win): Add border style
444         observers.
445         * tui/tui-io.h (tui_apply_style): Declare.
446         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
447         longer static.
448         (apply_ansi_escape, tui_set_reverse_mode): Update.
449         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
450         Add "skip_intensity" parameter.
451         <changed>: New member.
452         <do_set_value>: Declare.
453         (tui_border_style, tui_active_border_style): Declare.
454         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
455         globals.
456         (cli_style_option): Initialize "changed".
457         (cli_style_option::do_set_value): New function.
458         (cli_style_option::add_setshow_commands): Add "skip_intensity"
459         parameter.  Update.
460         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
461         (_initialize_cli_style): Update.  Create TUI border style
462         commands.
463
464 2019-12-01  Tom Tromey  <[email protected]>
465
466         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
467         parameter.
468         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
469         parameter.
470         * tui/tui-win.h (compact_source): Declare.
471         * tui/tui-win.c (compact_source): New global.
472         (tui_set_compact_source, tui_show_compact_source): New functions.
473         (_initialize_tui_win): Add "compact-source" setting.
474         * tui/tui-source.c (tui_source_window::set_contents): Handle
475         compact_source setting.
476         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
477         * NEWS: Document new setting.
478
479 2019-11-30  Tom Tromey  <[email protected]>
480
481         * dwarf2read.c (dwarf2_add_field): Include field offset when
482         computing variant part length.
483
484 2019-11-30  Philippe Waroquiers  <[email protected]>
485         * NEWS:  Mention define-prefix.  Tell that command names can now
486         contain a . character.
487
488 2019-11-30  Philippe Waroquiers  <[email protected]>
489
490         * command.h (valid_cmd_char_p): Declare.
491         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
492         the check of valid command char.
493         (find_command_name_length, valid_user_defined_cmd_name_p): Use
494         valid_cmd_char_p.
495         * cli/cli-script.c (validate_comname): Likewise.
496         * completer.c (gdb_completer_command_word_break_characters):
497         Do not remove . from the word break char, update comments.
498         (complete_line_internal_1): Use valid_cmd_char_p.
499         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
500         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
501
502 2019-11-30  Philippe Waroquiers  <[email protected]>
503
504         * cli/cli-script.c (do_define_command): Ensure a redefined
505         prefix command is kept as a prefix command.
506         (define_prefix_command): New function.
507         (show_user_1): Report user defined prefixes.
508         (_initialize_cli_script):  Create the new 'define-prefix' command.
509         Add completers for 'define' and 'document'.
510         * top.c (execute_command):  If command is a user-defined prefix only
511         command, report the list of commands for this prefix command.
512
513 2019-11-29  Tankut Baris Aktemur  <[email protected]>
514
515         * valops.c (find_oload_champ): Improve debug output.
516
517 2019-11-29  Tankut Baris Aktemur  <[email protected]>
518
519         * valops.c (find_oload_champ): Print part of debug messages
520         before the badness vector is std::move'd.
521
522 2019-11-28  Tom Tromey  <[email protected]>
523
524         * value.c (creal_internal_fn): Fix comment.
525
526 2019-11-28  Tom Tromey  <[email protected]>
527
528         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
529         flag_bound_evaluated>: Now unsigned.
530
531 2019-11-28  Tom Tromey  <[email protected]>
532
533         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
534         declare.
535
536 2019-11-28  Mihails Strasuns  <[email protected]>
537
538         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
539         debug output.
540         * jit.c (jit_unregister_code): Add debug print to match
541         `jit_register_code`.
542
543 2019-11-27  Christian Biesinger  <[email protected]>
544
545         * NEWS: Mention the new multithreaded symbol loading.
546
547 2019-11-27  Christian Biesinger  <[email protected]>
548
549         * maint.c (n_worker_threads): Default to 0.
550         (worker_threads_disabled): New function.
551         * maint.h (worker_threads_disabled): New function.
552         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
553         here if worker_threads_disabled () is true.
554         (minimal_symbol_reader::install): Skip all threading if
555         worker_threads_disabled () is true.
556
557 2019-11-27  Christian Biesinger  <[email protected]>
558
559         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
560         hash code if possible.
561         (add_minsym_to_demangled_hash_table): Likewise.
562         (minimal_symbol_reader::install): Compute the hash codes for msymbol
563         on the background thread.
564         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
565         Add these fields.
566
567 2019-11-27  Christian Biesinger  <[email protected]>
568
569         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
570         of the mangled name on the background thread.
571         * symtab.c (symbol_set_names): Allow passing in the hash of the
572         linkage_name.
573         * symtab.h (symbol_set_names): Likewise.
574
575 2019-11-27  Kevin Buettner  <[email protected]>
576
577         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
578         physnames are computed for inherited DIEs.
579
580 2019-11-27  Tom Tromey  <[email protected]>
581
582         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
583         backslashes.
584         * cp-support.c: Remove unnecessary backslashes.
585
586 2019-11-27  Christian Biesinger  <[email protected]>
587
588         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
589         with sym->set_linkage_name.
590         * coffread.c (coff_read_enum_type): Likewise.
591         * mdebugread.c (parse_symbol): Likewise.
592         * stabsread.c (patch_block_stabs): Likewise.
593         (define_symbol): Likewise.
594         (read_enum_type): Likewise.
595         (common_block_end): Likewise.
596         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
597         function.
598         (SYMBOL_SET_LINKAGE_NAME): Remove.
599         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
600         with sym->set_linkage_name.
601
602 2019-11-27  Andrew Burgess  <[email protected]>
603
604         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
605         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
606         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
607         * NEWS: Mention new MI command.
608
609 2019-11-27  Andrew Burgess  <[email protected]>
610
611         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
612         '-symbol-info-types', and '-symbol-info-variables'.
613         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
614         (mi_cmd_symbol_info_types): Declare.
615         (mi_cmd_symbol_info_variables): Declare.
616         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
617         (output_debug_symbol): New function.
618         (output_nondebug_symbol): New function.
619         (mi_symbol_info): New function.
620         (mi_info_functions_or_variables): New function.
621         (mi_cmd_symbol_info_functions): New function.
622         (mi_cmd_symbol_info_types): New function.
623         (mi_cmd_symbol_info_variables): New function.
624         * NEWS: Mention new commands.
625
626 2019-11-27  Andrew Burgess  <[email protected]>
627
628         * symtab.c (symbol_to_info_string): New function, most content
629         moved from print_symbol_info, but updated to return a std::string.
630         (print_symbol_info): Update to use symbol_to_info_string and print
631         returned string.
632         * symtab.h (symbol_to_info_string): Declare new function.
633
634 2019-11-27  Andrew Burgess  <[email protected]>
635
636         * python/python.c (gdbpy_rbreak): Convert to using
637         global_symbol_searcher.
638         * symtab.c (file_matches): Convert return type to bool, change
639         file list to std::vector, update header comment.
640         (search_symbols): Rename to...
641         (global_symbol_searcher::search): ...this and update now its
642         a member function of global_symbol_searcher.  Take account of the
643         changes to file_matches.
644         (symtab_symbol_info): Convert to using global_symbol_searcher.
645         (rbreak_command): Likewise.
646         (search_module_symbols): Likewise.
647         * symtab.h (enum symbol_search): Update comment.
648         (search_symbols): Remove declaration.
649         (class global_symbol_searcher): New class.
650
651 2019-11-26  Tom Tromey  <[email protected]>
652
653         * cp-support.c (_initialize_cp_support): Conditionally initialize
654         gdb_demangle_attempt_core_dump.
655
656 2019-11-26  Tom Tromey  <[email protected]>
657
658         * python/py-function.c (fnpy_init): Update.
659         * value.h (add_internal_function): Adjust declaration.
660         * value.c (function_destroyer): Remove.
661         (do_add_internal_function): Don't set destroyer or copy name.
662         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
663         Set name_allocated.
664         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
665         (cmdpy_init): Set name_allocated.
666         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
667         member.
668         (~cmd_list_element): Free "name" if needed.
669
670 2019-11-26  Tom Tromey  <[email protected]>
671
672         * value.h (add_internal_function): Add new overload.  Move
673         documentation from value.h.
674         * value.c (do_add_internal_function): New function.
675         (add_internal_function): Use it.  Add new overload.
676         (function_destroyer): Don't free doc.
677         * python/py-function.c (fnpy_init): Update.
678
679 2019-11-26  Tom Tromey  <[email protected]>
680
681         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
682         (cmdpy_init): Set "doc_allocated".
683
684 2019-11-26  Tom Tromey  <[email protected]>
685
686         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
687         name of worker thread.
688         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
689         pthread_setname_np.
690         * configure, config.in: Rebuild.
691
692 2019-11-26  Tom Tromey  <[email protected]>
693
694         * python/python.c (class gdbpy_gil): New.
695         (struct gdbpy_event): Add constructor, destructor, operator().
696         (gdbpy_post_event): Use run_on_main_thread.
697         (gdbpy_initialize_events): Remove.
698         (do_start_initialization): Update.
699
700 2019-11-26  Tom Tromey  <[email protected]>
701
702         * NEWS: Add entry.
703         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
704         commands.  Call update_thread_pool_size.
705         (update_thread_pool_size, maintenance_set_worker_threads): New
706         functions.
707         (n_worker_threads): New global.
708
709 2019-11-26  Christian Biesinger  <[email protected]>
710             Tom Tromey  <[email protected]>
711
712         * minsyms.c (minimal_symbol_reader::install): Use
713         parallel_for_each.
714         * gdbsupport/parallel-for.h: New file.
715         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
716
717 2019-11-26  Christian Biesinger  <[email protected]>
718             Tom Tromey  <[email protected]>
719
720         * gdbsupport/thread-pool.h: New file.
721         * gdbsupport/thread-pool.c: New file.
722         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
723         (HFILES_NO_SRCDIR): Add thread-pool.h.
724
725 2019-11-26  Tom Tromey  <[email protected]>
726
727         * event-top.h (thread_local_segv_handler): Declare.
728         * event-top.c (thread_local_segv_handler): New global.
729         (install_handle_sigsegv, handle_sigsegv): New functions.
730         (async_init_signals): Install SIGSEGV handler.
731         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
732         thread-local.
733         (report_failed_demangle): New function.
734         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
735         handler-setting code, instead use segv_handler.  Run warning code
736         on main thread.
737
738 2019-11-26  Tom Tromey  <[email protected]>
739
740         * run-on-main-thread.c: New file.
741         * run-on-main-thread.h: New file.
742         * unittests/main-thread-selftests.c: New file.
743         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
744         main-thread-selftests.c.
745         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
746         (COMMON_SFILES): Add run-on-main-thread.c.
747
748 2019-11-26  Tom Tromey  <[email protected]>
749
750         * main.c (setup_alternate_signal_stack): Remove.
751         (captured_main_1): Use gdb::alternate_signal_stack.
752         * gdbsupport/alt-stack.h: New file.
753
754 2019-11-26  Tom Tromey  <[email protected]>
755
756         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
757         Remove comment.
758         (save_original_signals_state, restore_original_signals_state): Use
759         gdb_sigmask.
760         * linux-nat.c (block_child_signals, restore_child_signals_mask)
761         (_initialize_linux_nat): Use gdb_sigmask.
762         * guile/guile.c (_initialize_guile): Use block_signals.
763         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
764         * gdbsupport/gdb-sigmask.h: New file.
765         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
766         * cp-support.c (gdb_demangle): Use gdb_sigmask.
767         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
768         pthread_sigmask.
769         * configure, config.in: Rebuild.
770         * gdbsupport/block-signals.h: New file.
771
772 2019-11-26  Tom Tromey  <[email protected]>
773
774         * acinclude.m4: Include ax_pthread.m4.
775         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
776         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
777         (CLIBS): Use PTHREAD_LIBS.
778         (aclocal_m4_deps): Add ax_pthread.m4.
779         * config.in, configure: Rebuild.
780         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
781
782 2019-11-26  Tom Tromey  <[email protected]>
783
784         * symtab.h (struct minimal_symbol) <name_set>: New member.
785         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
786         Don't call symbol_set_names.
787         (minimal_symbol_reader::install): Call symbol_set_names.
788
789 2019-11-26  Philippe Waroquiers  <[email protected]>
790
791         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
792         restore_active_ext_lang, as GIL is needed for (indirectly)
793         called PyOS_InterruptOccurred.
794
795 2019-11-26  Simon Marchi  <[email protected]>
796
797         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
798         definition.
799
800 2019-11-26  Simon Marchi  <[email protected]>
801
802         * remote-sim.c (simulator_command): Make static, remove
803         declaration.
804
805 2019-11-26  Simon Marchi  <[email protected]>
806
807         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
808         static.
809         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
810         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
811         (main): Likewise.
812         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
813         (main): Likewise.
814         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
815         (main): Likewise.
816         * unittests/basic_string_view/element_access/char/1.cc (test01):
817         Likewise.
818         (main): Likewise.
819         * unittests/basic_string_view/element_access/char/empty.cc (main):
820         Likewise.
821         * unittests/basic_string_view/element_access/char/front_back.cc
822         (test01): Likewise.
823         (main): Likewise.
824         * unittests/basic_string_view/inserters/char/2.cc (test05):
825         Likewise.
826         (main): Likewise.
827         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
828         (test01): Likewise.
829         (main): Likewise.
830         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
831         (test01): Likewise.
832         (main): Likewise.
833         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
834         Likewise.
835         * unittests/basic_string_view/operations/compare/char/1.cc
836         (test01): Likewise.
837         (main): Likewise.
838         * unittests/basic_string_view/operations/compare/char/13650.cc
839         (test01): Likewise.
840         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
841         Likewise.
842         (main): Likewise.
843         * unittests/basic_string_view/operations/data/char/1.cc (test01):
844         Likewise.
845         (main): Likewise.
846         * unittests/basic_string_view/operations/find/char/1.cc (test01):
847         Likewise.
848         (main): Likewise.
849         * unittests/basic_string_view/operations/find/char/2.cc (test02):
850         Likewise.
851         (main): Likewise.
852         * unittests/basic_string_view/operations/find/char/3.cc (test03):
853         Likewise.
854         (main): Likewise.
855         * unittests/basic_string_view/operations/find/char/4.cc (main):
856         Likewise.
857         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
858         Likewise.
859         (main): Likewise.
860         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
861         Likewise.
862         (main): Likewise.
863         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
864         Likewise.
865         (main): Likewise.
866         * unittests/basic_string_view/operations/substr/char/1.cc
867         (test01): Likewise.
868         (main): Likewise.
869         * unittests/basic_string_view/operators/char/2.cc (main):
870         Likewise.
871         * unittests/optional/assignment/1.cc (test): Likewise.
872         * unittests/optional/assignment/2.cc (test): Likewise.
873         * unittests/optional/assignment/3.cc (test): Likewise.
874         * unittests/optional/assignment/4.cc (test): Likewise.
875         * unittests/optional/assignment/5.cc (test): Likewise.
876         * unittests/optional/assignment/6.cc (test): Likewise.
877         * unittests/optional/assignment/7.cc (test): Likewise.
878         * unittests/optional/cons/copy.cc (test): Likewise.
879         * unittests/optional/cons/default.cc (test): Likewise.
880         * unittests/optional/cons/move.cc (test): Likewise.
881         * unittests/optional/cons/value.cc (test): Likewise.
882         * unittests/optional/in_place.cc (test): Likewise.
883         * unittests/optional/observers/1.cc (test): Likewise.
884         * unittests/optional/observers/2.cc (test): Likewise.
885
886 2019-11-26  Simon Marchi  <[email protected]>
887
888         * tui-win.h (tui_set_var_cmd): Remove.
889         * tui-win.c (tui_set_var_cmd): Make static.
890
891 2019-11-26  Simon Marchi  <[email protected]>
892
893         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
894         rbreak_command_wrapper): Remove.
895         * symtab.c (rbreak_command_wrapper): Remove.
896
897 2019-11-26  Simon Marchi  <[email protected]>
898
899         * inferior.h (info_terminal_command): Remove declaration.
900         * inflow.c (info_terminal_command): Make static.
901
902 2019-11-26  Simon Marchi  <[email protected]>
903
904         * inferior.c (exit_inferior_silent): Remove.
905
906 2019-11-26  Simon Marchi  <[email protected]>
907
908         * dictionary.c (dict_empty, mdict_empty): Remove.
909         * dictionary.c (mdict_empty): Remove.
910
911 2019-11-26  Simon Marchi  <[email protected]>
912
913          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
914          (arc_insn_get_memory_offset): Likewise.
915          (arc_insn_dump): Likewise.
916          * cp-support.c (test_cp_symbol_name_matches): Likewise.
917          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
918          * dictionary.c (dict_iterator_next): Likewise.
919          (dict_iter_match_first): Likewise.
920          (dict_iter_match_next): Likewise.
921          * f-lang.c (evaluate_subexp_f): Likewise.
922          * hppa-tdep.c (hppa_read_pc): Likewise.
923          * i386-tdep.c (i386_floatformat_for_type): Likewise.
924          * parse.c (write_exp_elt_msym): Likewise.
925          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
926          * remote.c (remote_packet_size): Likewise.
927          (remote_notif_stop_parse): Likewise.
928          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
929          * s12z-tdep.c (s12z_disassemble_info): Likewise.
930          * source.c (prepare_path_for_appending): Likewise.
931          * sparc64-linux-tdep.c
932          (sparc64_linux_handle_segmentation_fault); Likewise.
933          * stack.c (frame_selection_by_function_completer): Likewise.
934
935 2019-11-26  Simon Marchi  <[email protected]>
936
937         * completer.c (set_gdb_completion_word_break_characters):
938         Remove.
939
940 2019-11-26  Simon Marchi  <[email protected]>
941
942         * dwarf-index-write.c: Include dwarf-index-write.h.
943         * mi/mi-interp.c: Include mi/mi-interp.h.
944
945 2019-11-26  Simon Marchi  <[email protected]>
946
947         * aarch32-tdep.c: Include aarch32-tdep.h.
948         * aarch32-tdep.h: Forward-declare struct target_desc.
949
950 2019-11-26  Christian Biesinger  <[email protected]>
951
952         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
953         strerror.
954         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
955         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
956
957 2019-11-25  Tom de Vries  <[email protected]>
958
959         * contrib/words.sh: Add -c option.
960
961 2019-11-25  Christian Biesinger  <[email protected]>
962
963         * solib.c (solib_find_1): Change int to bool.
964         (exec_file_find): Change int to bool.
965         (solib_find): Change int to bool.
966         (solib_read_symbols): Change int to bool.
967         (solib_used): Change int to bool.
968         (solib_add): Change int to bool.
969         (info_sharedlibrary_command): Change int to bool.
970         (solib_contains_address_p): Change int to bool.
971         (solib_keep_data_in_core): Change int to bool.
972         (in_solib_dynsym_resolve_code): Change int to bool.
973         (reload_shared_libraries_1): Change int to bool.
974         (gdb_sysroot_changed): Change int to bool.
975         * solib.h (solib_read_symbols): Change int to bool.
976         (solib_contains_address_p): Change int to bool.
977         (solib_keep_data_in_core): Change int to bool.
978         (in_solib_dynsym_resolve_code): Change int to bool.
979         (libpthread_name_p): Change int to bool.
980
981 2019-11-25  Luis Machado  <[email protected]>
982
983         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
984         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
985         (remote_packet_max_chars): New static global.
986         (show_remote_packet_max_chars): New function.
987         (remote_target::putpkt_binary): Adjust to use new
988         remote_packet_max_chars option.
989         (remote_target::getpkt_or_notif_sane_1): Likewise.
990         (_initialize_remote): Register new remote-packet-max-chars option.
991
992 2019-11-24  Simon Marchi  <[email protected]>
993
994         * m68k-linux-nat.c: Include gdbarch.h.
995
996 2019-11-24  Tom Tromey  <[email protected]>
997
998         * symfile.c (read_symbols): Update.
999         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1000         bool.
1001         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1002         (psym_lookup_symbol, psym_find_last_source_symtab)
1003         (psym_forget_cached_source_info, psym_print_stats)
1004         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1005         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1006         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1007         (psym_find_compunit_symtab_by_address)
1008         (maintenance_print_psymbols, maintenance_info_psymtabs)
1009         (maintenance_check_psymtabs): Update.
1010         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1011         bool.
1012
1013 2019-11-22  Tom Tromey  <[email protected]>
1014
1015         * observable.h: Update comments.
1016
1017 2019-11-22  Tom Tromey  <[email protected]>
1018
1019         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1020         (print_ada_task_info): Don't try to fetch thread id if task is not
1021         alive.
1022
1023 2019-11-22  Christian Biesinger  <[email protected]>
1024
1025         * ada-exp.y: Update.
1026         * ada-lang.c (sort_choices): Update.
1027         (ada_print_symbol_signature): Update.
1028         (resolve_subexp): Update.
1029         (ada_parse_renaming): Update.
1030         (ada_read_renaming_var_value): Update.
1031         (lesseq_defined_than): Update.
1032         (remove_extra_symbols): Update.
1033         (remove_irrelevant_renamings): Update.
1034         (ada_add_block_symbols): Update.
1035         (ada_collect_symbol_completion_matches): Update.
1036         (ada_is_renaming_symbol): Update.
1037         (aggregate_assign_from_choices): Update.
1038         (ada_evaluate_subexp): Update.
1039         (ada_has_this_exception_support): Update.
1040         (ada_is_non_standard_exception_sym): Update.
1041         (ada_add_exceptions_from_frame): Update.
1042         (ada_add_global_exceptions): Update.
1043         (ada_print_subexp): Update.
1044         * ax-gdb.c (gen_var_ref): Update.
1045         (gen_maybe_namespace_elt): Update.
1046         (gen_expr_for_cast): Update.
1047         (gen_expr): Update.
1048         * block.h: Update.
1049         * blockframe.c (find_pc_partial_function): Update.
1050         * breakpoint.c (print_breakpoint_location): Update.
1051         (update_static_tracepoint): Update.
1052         * btrace.c (ftrace_print_function_name): Update.
1053         (ftrace_function_switched): Update.
1054         * buildsym.c (find_symbol_in_list): Update.
1055         * c-exp.y: Update.
1056         * c-typeprint.c (c_print_typedef): Update.
1057         (c_type_print_template_args): Update.
1058         * cli/cli-cmds.c (edit_command): Update.
1059         (list_command): Update.
1060         (print_sal_location): Update.
1061         * coffread.c (patch_opaque_types): Update.
1062         (process_coff_symbol): Update.
1063         (coff_read_enum_type): Update.
1064         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1065         (convert_one_symbol): Update.
1066         (hash_symname): Update.
1067         (eq_symname): Update.
1068         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1069         * compile/compile-cplus-types.c (debug_print_scope): Update.
1070         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1071         * compile/compile-object-load.c (get_out_value_type): Update.
1072         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1073         (search_symbol_list): Update.
1074         (cp_lookup_symbol_imports_or_template): Update.
1075         * cp-support.c (overload_list_add_symbol): Update.
1076         * ctfread.c (psymtab_to_symtab): Update.
1077         * dbxread.c (cp_set_block_scope): Update.
1078         * dictionary.c (iter_match_first_hashed): Update.
1079         (iter_match_next_hashed): Update.
1080         (insert_symbol_hashed): Update.
1081         (iter_match_next_linear): Update.
1082         * dictionary.h: Update.
1083         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1084         (locexpr_describe_location_piece): Update.
1085         (locexpr_describe_location_1): Update.
1086         (locexpr_generate_c_location): Update.
1087         (loclist_describe_location): Update.
1088         (loclist_generate_c_location): Update.
1089         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1090         (read_func_scope): Update.
1091         (process_enumeration_scope): Update.
1092         (new_symbol): Update.
1093         (dwarf2_const_value): Update.
1094         (dwarf2_symbol_mark_computed): Update.
1095         * eval.c (evaluate_funcall): Update.
1096         (evaluate_subexp_standard): Update.
1097         * expprint.c (print_subexp_standard): Update.
1098         (dump_subexp_body_standard): Update.
1099         * f-valprint.c (info_common_command_for_block): Update.
1100         * findvar.c (get_hosting_frame): Update.
1101         (default_read_var_value): Update.
1102         * go-lang.c (go_symbol_package_name): Update.
1103         * guile/scm-block.c (bkscm_print_block_smob): Update.
1104         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1105         (gdbscm_symbol_name): Update.
1106         (gdbscm_symbol_linkage_name): Update.
1107         (gdbscm_symbol_print_name): Update.
1108         * infcall.c (get_function_name): Update.
1109         * infcmd.c (jump_command): Update.
1110         (finish_command): Update.
1111         * infrun.c (insert_exception_resume_breakpoint): Update.
1112         * linespec.c (canonicalize_linespec): Update.
1113         (create_sals_line_offset): Update.
1114         (convert_linespec_to_sals): Update.
1115         (complete_label): Update.
1116         (find_label_symbols_in_block): Update.
1117         * m2-typeprint.c (m2_print_typedef): Update.
1118         * mdebugread.c (mdebug_reg_to_regnum): Update.
1119         (parse_symbol): Update.
1120         (mylookup_symbol): Update.
1121         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1122         (list_args_or_locals): Update.
1123         * objc-lang.c (compare_selectors): Update.
1124         (info_selectors_command): Update.
1125         (compare_classes): Update.
1126         (info_classes_command): Update.
1127         (find_imps): Update.
1128         * p-typeprint.c (pascal_print_typedef): Update.
1129         * printcmd.c (build_address_symbolic): Update.
1130         (info_address_command): Update.
1131         (print_variable_and_value): Update.
1132         * python/py-framefilter.c (extract_sym): Update.
1133         (py_print_single_arg): Update.
1134         * python/py-symbol.c (sympy_str): Update.
1135         (sympy_get_name): Update.
1136         (sympy_get_linkage_name): Update.
1137         * python/python.c (gdbpy_rbreak): Update.
1138         * record-btrace.c (btrace_get_bfun_name): Update.
1139         (btrace_call_history): Update.
1140         * rust-lang.c (rust_print_typedef): Update.
1141         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1142         * stabsread.c (stab_reg_to_regnum): Update.
1143         (define_symbol): Update.
1144         (read_enum_type): Update.
1145         (common_block_end): Update.
1146         (cleanup_undefined_types_1): Update.
1147         (scan_file_globals): Update.
1148         * stack.c (print_frame_arg): Update.
1149         (print_frame_args): Update.
1150         (find_frame_funname): Update.
1151         (info_frame_command_core): Update.
1152         (iterate_over_block_locals): Update.
1153         (print_block_frame_labels): Update.
1154         (do_print_variable_and_value): Update.
1155         (iterate_over_block_arg_vars): Update.
1156         (return_command): Update.
1157         * symmisc.c (dump_symtab_1): Update.
1158         (print_symbol): Update.
1159         * symtab.c (eq_symbol_entry): Update.
1160         (symbol_cache_dump): Update.
1161         (lookup_language_this): Update.
1162         (find_pc_sect_line): Update.
1163         (skip_prologue_sal): Update.
1164         (symbol_search::compare_search_syms): Update.
1165         (treg_matches_sym_type_name): Update.
1166         (search_symbols): Update.
1167         (print_symbol_info): Update.
1168         (rbreak_command): Update.
1169         (completion_list_add_symbol): Update.
1170         (find_gnu_ifunc): Update.
1171         (get_symbol_address): Update.
1172         (search_module_symbols): Update.
1173         (info_module_subcommand): Update.
1174         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1175         (SYMBOL_LINKAGE_NAME): Remove.
1176         (SYMBOL_DEMANGLED_NAME): Remove.
1177         (SYMBOL_PRINT_NAME): Remove.
1178         (SYMBOL_SEARCH_NAME): Remove.
1179         * tracepoint.c (set_traceframe_context): Update.
1180         (validate_actionline): Update.
1181         (collection_list::collect_symbol): Update.
1182         (encode_actions_1): Update.
1183         (info_scope_command): Update.
1184         (print_one_static_tracepoint_marker): Update.
1185         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1186         * valops.c (address_of_variable): Update.
1187         (find_overload_match): Update.
1188         (find_oload_champ): Update.
1189
1190 2019-11-22  Christian Biesinger  <[email protected]>
1191
1192         * ada-lang.c (ada_lookup_simple_minsym): Update.
1193         (ada_collect_symbol_completion_matches): Update.
1194         * ada-tasks.c (read_atcb): Update.
1195         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1196         (amd64_windows_skip_trampoline_code): Update.
1197         * arm-tdep.c (skip_prologue_function): Update.
1198         (arm_skip_stack_protector): Update.
1199         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1200         (arm_wince_skip_main_prologue): Update.
1201         * ax-gdb.c (gen_expr): Update.
1202         * block.c (call_site_for_pc): Update.
1203         * blockframe.c (find_pc_partial_function): Update.
1204         * breakpoint.c (set_breakpoint_location_function): Update.
1205         * btrace.c (ftrace_print_function_name): Update.
1206         (ftrace_function_switched): Update.
1207         * c-valprint.c (print_unpacked_pointer): Update.
1208         * coffread.c (coff_symfile_read): Update.
1209         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1210         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1211         * dwarf-index-write.c (write_psymbols): Update.
1212         * dwarf2loc.c (call_site_to_target_addr): Update.
1213         (func_verify_no_selftailcall): Update.
1214         (tailcall_dump): Update.
1215         (call_site_find_chain_1): Update.
1216         (dwarf_expr_reg_to_entry_parameter): Update.
1217         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1218         * eval.c (evaluate_funcall): Update.
1219         (evaluate_subexp_standard): Update.
1220         (evaluate_subexp_for_sizeof): Update.
1221         * expprint.c (print_subexp_standard): Update.
1222         (dump_subexp_body_standard): Update.
1223         * frame.c (get_prev_frame_always_1): Update.
1224         * frv-tdep.c (frv_skip_main_prologue): Update.
1225         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1226         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1227         (gnuv3_get_typename_from_type_info): Update.
1228         (gnuv3_skip_trampoline): Update.
1229         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1230         * i386-tdep.c (i386_skip_main_prologue): Update.
1231         (i386_pe_skip_trampoline_code): Update.
1232         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1233         * infcall.c (get_function_name): Update.
1234         * linespec.c (minsym_found): Update.
1235         * linux-fork.c (info_checkpoints_command): Update.
1236         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1237         (m32c_m16c_pointer_to_address): Update.
1238         * maint.c (maintenance_translate_address): Update.
1239         * minsyms.c (add_minsym_to_hash_table): Update.
1240         (add_minsym_to_demangled_hash_table): Update.
1241         (lookup_minimal_symbol_mangled): Update.
1242         (lookup_minimal_symbol_demangled): Update.
1243         (lookup_minimal_symbol_linkage): Update.
1244         (lookup_minimal_symbol_text): Update.
1245         (lookup_minimal_symbol_by_pc_name): Update.
1246         (minimal_symbol_is_less_than): Update.
1247         (compact_minimal_symbols): Update.
1248         (build_minimal_symbol_hash_tables): Update.
1249         (find_solib_trampoline_target): Update.
1250         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1251         (mips_skip_pic_trampoline_code): Update.
1252         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1253         * objc-lang.c (info_selectors_command): Update.
1254         (info_classes_command): Update.
1255         (find_methods): Update.
1256         (find_imps): Update.
1257         * p-valprint.c (pascal_val_print): Update.
1258         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1259         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1260         * printcmd.c (build_address_symbolic): Update.
1261         (info_symbol_command): Update.
1262         * psymtab.c (psymbol_name_matches): Update.
1263         (match_partial_symbol): Update.
1264         (lookup_partial_symbol): Update.
1265         (print_partial_symbols): Update.
1266         (sort_pst_symbols): Update.
1267         (maintenance_check_psymtabs): Update.
1268         * python/py-framefilter.c (py_print_frame): Update.
1269         * python/python.c (gdbpy_rbreak): Update.
1270         * record-btrace.c (btrace_get_bfun_name): Update.
1271         (btrace_call_history): Update.
1272         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1273         (rs6000_skip_trampoline_code): Update.
1274         * sol-thread.c (info_cb): Update.
1275         * stabsread.c (scan_file_globals): Update.
1276         * stack.c (find_frame_funname): Update.
1277         (info_frame_command_core): Update.
1278         * symmisc.c (dump_msymbols): Update.
1279         * symtab.c (symbol_natural_name): Rename to..,
1280         (general_symbol_info::natural_name): ...this.
1281         (symbol_demangled_name): Rename to...
1282         (general_symbol_info::demangled_name): ...this.
1283         (symbol_search_name): Rename to...
1284         (general_symbol_info::search_name): ...this.
1285         (symbol_matches_search_name): Update.
1286         (find_pc_sect_line): Update.
1287         (skip_prologue_sal): Update.
1288         (search_symbols): Update.
1289         (print_msymbol_info): Update.
1290         (rbreak_command): Update.
1291         (completion_list_add_msymbol): Update.
1292         (completion_list_objc_symbol): Update.
1293         (get_msymbol_address): Update.
1294         * symtab.h (struct general_symbol_info): Add member functions
1295         natural_name (), linkage_name (), print_name (), demangled_name (),
1296         and search_name ().
1297         (SYMBOL_NATURAL_NAME): Update.
1298         (symbol_natural_name): Move to a member function on general_symbol_info.
1299         (SYMBOL_DEMANGLED_NAME): Update.
1300         (symbol_demangled_name): Move to a member function on
1301         general_symbol_info.
1302         (SYMBOL_SEARCH_NAME): Update.
1303         (symbol_search_name): Move to a member function on general_symbol_info.
1304         (MSYMBOL_NATURAL_NAME): Remove.
1305         (MSYMBOL_LINKAGE_NAME): Remove.
1306         (MSYMBOL_PRINT_NAME): Remove.
1307         (MSYMBOL_DEMANGLED_NAME): Remove.
1308         (MSYMBOL_SEARCH_NAME): Remove.
1309         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1310
1311 2019-11-22  Christian Biesinger  <[email protected]>
1312
1313         * symtab.c (create_demangled_names_hash): Use per_bfd->
1314         minimal_symbol_count for computing the initial size, if greater
1315         than our default size.
1316
1317 2019-11-22  Tom de Vries  <[email protected]>
1318
1319         * contrib/words.sh: Improve words extraction.
1320
1321 2019-11-22  Tom de Vries  <[email protected]>
1322
1323         * contrib/words.sh: Combine sed invocations.
1324
1325 2019-11-21  Christian Biesinger  <[email protected]>
1326
1327         * Makefile.in: Update.
1328         * demangle.c: Rename to...
1329         * gdb-demangle.c: ..this.
1330         (is_cplus_marker): Change return type to bool.
1331         (_initialize_demangler): Rename to...
1332         (_initialize_gdb_demangle): ...this.
1333         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1334         * symtab.h (demangle): Remove declaration; instead include
1335         gdb-demangle.h.
1336
1337 2019-11-21  Tom Tromey  <[email protected]>
1338
1339         * gdbsupport/format.c (format_pieces): Parse %I64d.
1340         * unittests/format_pieces-selftests.c (test_windows_formats): New
1341         function.
1342         (run_tests): Call it.
1343
1344 2019-11-21  Peeter Joot  <[email protected]>
1345
1346         Byte reverse display of variables with DW_END_big, DW_END_little
1347         (DW_AT_endianity) dwarf attributes if different than the native
1348         byte order.
1349         * ada-lang.c (ada_value_binop):
1350         Use type_byte_order instead of gdbarch_byte_order.
1351         * ada-valprint.c (printstr):
1352         (ada_val_print_string):
1353         * ada-lang.c (value_pointer):
1354         (ada_value_binop):
1355         Use type_byte_order instead of gdbarch_byte_order.
1356         * c-lang.c (c_get_string):
1357         Use type_byte_order instead of gdbarch_byte_order.
1358         * c-valprint.c (c_val_print_array):
1359         Use type_byte_order instead of gdbarch_byte_order.
1360         * cp-valprint.c (cp_print_class_member):
1361         Use type_byte_order instead of gdbarch_byte_order.
1362         * dwarf2loc.c (rw_pieced_value):
1363         Use type_byte_order instead of gdbarch_byte_order.
1364         * dwarf2read.c (read_base_type): Handle DW_END_big,
1365         DW_END_little
1366         * f-lang.c (f_get_encoding):
1367         Use type_byte_order instead of gdbarch_byte_order.
1368         * findvar.c (default_read_var_value):
1369         Use type_byte_order instead of gdbarch_byte_order.
1370         * gdbtypes.c (check_types_equal):
1371         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1372         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1373         and TYPE_ENDIANITY_LITTLE if set.
1374         (type_byte_order): new function.
1375         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1376         (struct main_type) <flag_endianity_not_default>:
1377         New field.
1378         (type_byte_order): New function.
1379         * infcmd.c (default_print_one_register_info):
1380         Use type_byte_order instead of gdbarch_byte_order.
1381         * p-lang.c (pascal_printstr):
1382         Use type_byte_order instead of gdbarch_byte_order.
1383         * p-valprint.c (pascal_val_print):
1384         Use type_byte_order instead of gdbarch_byte_order.
1385         * printcmd.c (print_scalar_formatted):
1386         Use type_byte_order instead of gdbarch_byte_order.
1387         * solib-darwin.c (darwin_current_sos):
1388         Use type_byte_order instead of gdbarch_byte_order.
1389         * solib-svr4.c (solib_svr4_r_ldsomap):
1390         Use type_byte_order instead of gdbarch_byte_order.
1391         * stap-probe.c (stap_modify_semaphore):
1392         Use type_byte_order instead of gdbarch_byte_order.
1393         * target-float.c (target_float_same_format_p):
1394         Use type_byte_order instead of gdbarch_byte_order.
1395         * valarith.c (scalar_binop):
1396         (value_bit_index):
1397         Use type_byte_order instead of gdbarch_byte_order.
1398         * valops.c (value_cast):
1399         Use type_byte_order instead of gdbarch_byte_order.
1400         * valprint.c (generic_emit_char):
1401         (generic_printstr):
1402         (val_print_string):
1403         Use type_byte_order instead of gdbarch_byte_order.
1404         * value.c (unpack_long):
1405         (unpack_bits_as_long):
1406         (unpack_value_bitfield):
1407         (modify_field):
1408         (pack_long):
1409         (pack_unsigned_long):
1410         Use type_byte_order instead of gdbarch_byte_order.
1411         * findvar.c (unsigned_pointer_to_address):
1412         (signed_pointer_to_address):
1413         (unsigned_address_to_pointer):
1414         (address_to_signed_pointer):
1415         (default_read_var_value):
1416         (default_value_from_register):
1417         Use type_byte_order instead of gdbarch_byte_order.
1418         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1419         Use type_byte_order instead of gdbarch_byte_order.
1420         * riscv-tdep.c (riscv_print_one_register_info):
1421         Use type_byte_order instead of gdbarch_byte_order.
1422
1423 2019-11-21  Simon Marchi  <[email protected]>
1424
1425         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1426         (current_ui_gdb_stdin_ptr): Likewise.
1427         (current_ui_gdb_stderr_ptr): Likewise.
1428         (current_ui_gdb_stdlog_ptr): Likewise.
1429         (current_ui_current_uiout_ptr): Likewise.
1430         (gen_ret_current_ui_field_ptr): Remove.
1431
1432 2019-11-21  Tom de Vries  <[email protected]>
1433
1434         PR gdb/24956
1435         * cli/cli-script.c (execute_control_command): Only switch to
1436         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1437
1438 2019-11-19  Tom Tromey  <[email protected]>
1439
1440         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1441         Now static.  Change type of "name".
1442         (tui_set_win_height_command): Don't copy "arg".
1443         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1444         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1445
1446 2019-11-19  Ali Tamur <[email protected]>
1447
1448         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1449         "if (attr != nullptr)".
1450         (dwarf2_find_base_address): Likewise.
1451         (dwarf2_build_include_psymtabs): Likewise.
1452         (read_cutu_die_from_dwo): Likewise.
1453         (read_func_scope): Likewise.
1454         (read_call_site_scope): Likewise.
1455         (dwarf2_get_pc_bounds): Likewise.
1456         (dwarf2_record_block_ranges): Likewise.
1457         (dwarf2_add_field): Likewise.
1458         (dwarf2_add_member_fn): Likewise.
1459         (read_structure_type): Likewise.
1460         (read_enumeration_type): Likewise.
1461         (read_array_type): Likewise.
1462         (read_array_order): Likewise.
1463         (read_set_type): Likewise.
1464         (read_common_block): Likewise.
1465         (read_tag_reference_type): Likewise.
1466         (read_tag_string_type): Likewise.
1467         (read_subroutine_type): Likewise.
1468         (read_base_type): Likewise.
1469         (read_subrange_type): Likewise.
1470         (new_symbol): Likewise.
1471         (prepare_one_comp_unit): Likewise.
1472
1473 2019-11-19  Tom Tromey  <[email protected]>
1474
1475         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1476         result in error when DebugActiveProcess fails.
1477
1478 2019-11-18  Sergio Durigan Junior  <[email protected]>
1479             Pedro Alves  <[email protected]>
1480
1481         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1482         * target.c (target_stack::push): Call 'unpush' if there's a
1483         target on top of the stack.
1484
1485 2019-11-18  Philippe Waroquiers  <[email protected]>
1486
1487         * python/py-block.c (blpy_dealloc): Call tp_free.
1488         (blpy_block_syms_dealloc): Likewise.
1489         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1490         * python/py-inferior.c (infpy_dealloc): Likewise.
1491         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1492         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1493         * python/py-symbol.c (sympy_dealloc): Likewise.
1494         * python/py-symtab.c (stpy_dealloc): Likewise.
1495         * python/py-type.c (typy_iterator_dealloc): Likewise.
1496
1497 2019-11-18  Christian Biesinger  <[email protected]>
1498
1499         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1500         constructor instead of using a class initializer.
1501
1502 2019-11-15  Christian Biesinger  <[email protected]>
1503
1504         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1505         * configure: Regenerate.
1506         * configure.ac: Don't source common.host.
1507         * gdbsupport/common.host: Remove.
1508         * gdbsupport/mingw-strerror.c: Remove.
1509         * gdbsupport/posix-strerror.c: Rename to...
1510         * gdbsupport/safe-strerror.c: ...this.
1511
1512 2019-11-15  Christian Biesinger  <[email protected]>
1513
1514         * maint.c (scoped_command_stats::print_time): Use localtime_r
1515         instead of localtime (provided through gnulib if necessary).
1516         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1517         of ctime.
1518
1519 2019-11-15  Christian Biesinger  <[email protected]>
1520
1521         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1522         avoid compile errors.
1523
1524 2019-11-15  Christian Biesinger  <[email protected]>
1525
1526         * config.in: Regenerate.
1527         * configure: Regenerate.
1528         * gdbsupport/common.m4: No longer check for strerror_r.
1529         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1530         POSIX version of strerror_r, now that gnulib provides it if
1531         necessary.
1532
1533 2019-11-14  Christian Biesinger  <[email protected]>
1534
1535         * README (`configure' options): Update.
1536
1537 2019-11-14  Tom Tromey  <[email protected]>
1538
1539         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1540         expected type for the RHS if the LHS is a convenience variable.
1541
1542 2019-11-14  Simon Marchi  <[email protected]>
1543
1544         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1545         Provide explicit default and copy constructor.
1546
1547 2019-11-14  Philippe Waroquiers  <[email protected]>
1548
1549         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1550         only call Py_INCREF (newbp) in the bppy_pending_object case.
1551
1552 2019-11-13  Tom Tromey  <[email protected]>
1553
1554         PR build/25182:
1555         * psympriv.h (partial_symbol): Remove static assert.
1556         * symtab.h (general_symbol_info, symbol): Remove static assert.
1557
1558 2019-11-12  Andrew Burgess  <[email protected]>
1559
1560         * gdbsupport/format.c (format_pieces::format_pieces): Support
1561         printf 'z' size modifier.
1562         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1563         * printcmd.c (ui_printf):  Handle size_t_arg.
1564         * ui-out.c (ui_out::vmessage): Likewise.
1565         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1566         function.
1567         (run_tests): Call test_format_int_sizes.
1568
1569 2019-11-12  Christian Biesinger  <[email protected]>
1570
1571         * ada-exp.y (write_ambiguous_var): Update.
1572         * buildsym.c (add_symbol_to_list): Update.
1573         * dwarf2read.c (read_variable): Update.
1574         (new_symbol): Update.
1575         * jit.c (finalize_symtab): Update.
1576         * language.c (language_alloc_type_symbol): Update.
1577         * symtab.c (fixup_symbol_section): Update.
1578         (initialize_objfile_symbol_1): Move code to...
1579         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1580         (allocate_symbol): Update.
1581         (allocate_template_symbol): Update.
1582         (get_symbol_address): Update.
1583         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1584         of having as a field, and add a constructor.
1585         (SYMBOL_VALUE): Update.
1586         (SYMBOL_VALUE_ADDRESS): Update.
1587         (SET_SYMBOL_VALUE_ADDRESS): Update.
1588         (SYMBOL_VALUE_BYTES): Update.
1589         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1590         (SYMBOL_BLOCK_VALUE): Update.
1591         (SYMBOL_VALUE_CHAIN): Update.
1592         (SYMBOL_LANGUAGE): Update.
1593         (SYMBOL_SECTION): Update.
1594         (SYMBOL_OBJ_SECTION): Update.
1595         (SYMBOL_SET_LANGUAGE): Update.
1596         (SYMBOL_SET_LINKAGE_NAME): Update.
1597         (SYMBOL_SET_NAMES): Update.
1598         (SYMBOL_NATURAL_NAME): Update.
1599         (SYMBOL_LINKAGE_NAME): Update.
1600         (SYMBOL_DEMANGLED_NAME): Update.
1601         (SYMBOL_SEARCH_NAME): Update.
1602         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1603         (struct symbol): Update.
1604         (struct template_symbol): Update.
1605         (struct rust_vtable_symbol): Update.
1606         * xcoffread.c (SYMBOL_DUP): Update.
1607
1608 2019-11-12  Tom Tromey  <[email protected]>
1609
1610         * tui/tui-layout.c (show_layout): Set current_layout.
1611         (show_source_disasm_command, show_data)
1612         (show_source_or_disasm_and_command): Don't set current_layout.
1613
1614 2019-11-12  Tom Tromey  <[email protected]>
1615
1616         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1617
1618 2019-11-12  Tom Tromey  <[email protected]>
1619
1620         * tui/tui-win.c (resize_message): New global.
1621         (show_tui_resize_message): New function.
1622         (tui_async_resize_screen): Print message if requested.
1623         (_initialize_tui_win): Add tui-resize-message setting.
1624         * NEWS: Add entry for new commands.
1625
1626 2019-11-11  Tom Tromey  <[email protected]>
1627
1628         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1629         functions.
1630
1631 2019-11-11  Christian Biesinger  <[email protected]>
1632
1633         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1634
1635 2019-11-10  Andrew Burgess  <[email protected]>
1636
1637         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1638         function.
1639         * python/python-internal.h (gdbpy_lookup_static_symbols):
1640         Declare new function.
1641         * python/python.c (python_GdbMethods): Add
1642         gdb.lookup_static_symbols method.
1643         * NEWS: Mention gdb.lookup_static_symbols.
1644
1645 2019-11-10  Andrew Burgess  <[email protected]>
1646
1647         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1648         static block of current object file first.  Also fix typo in
1649         header comment.
1650
1651 2019-11-10  Andrew Burgess  <[email protected]>
1652
1653         * stack.c (set_last_displayed_sal): Delete.
1654         (last_displayed_sal_valid): Delete.
1655         (last_displayed_pspace): Delete.
1656         (last_displayed_addr): Delete.
1657         (last_displayed_symtab): Delete.
1658         (last_displayed_line): Delete.
1659         (class last_displayed_symtab_info_type): New.
1660         (last_displayed_symtab_info): New static global variable.
1661         (print_frame_info): Call methods on last_displayed_symtab_info.
1662         (clear_last_displayed_sal): Update header comment, and make use of
1663         last_displayed_symtab_info.
1664         (last_displayed_sal_is_valid): Likewise.
1665         (get_last_displayed_pspace): Likewise.
1666         (get_last_displayed_addr): Likewise.
1667         (get_last_displayed_symtab): Likewise.
1668         (get_last_displayed_line): Likewise.
1669         (get_last_displayed_sal): Likewise.
1670         * stack.h (clear_last_displayed_sal): Update header comment.
1671         (last_displayed_sal_is_valid): Likewise.
1672         (get_last_displayed_pspace): Likewise.
1673         (get_last_displayed_addr): Likewise.
1674         (get_last_displayed_symtab): Likewise.
1675         (get_last_displayed_line): Likewise.
1676         (get_last_displayed_sal): Likewise.
1677
1678 2019-11-10  Andrew Burgess  <[email protected]>
1679
1680         * stack.c (frame_show_address): Convert return type to bool.
1681         * stack.h (frame_show_address): Likewise, and update header
1682         comment.
1683
1684 2019-11-10  Andrew Burgess  <[email protected]>
1685
1686         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1687         * unittests/vec-utils-selftests.c: New file.
1688         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1689
1690 2019-11-10  Tom Tromey  <[email protected]>
1691
1692         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1693         (tui_highlight_win): Likewise.
1694         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1695         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1696         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1697         Don't set can_highlight.
1698
1699 2019-11-10  Tom Tromey  <[email protected]>
1700
1701         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1702         Remove unused declaration.
1703
1704 2019-11-08  Tom Tromey  <[email protected]>
1705
1706         * top.c (read_command_file): Update.
1707         (command_line_input): Make return type const.
1708         * python/py-gdb-readline.c: Update.
1709         * linespec.c (decode_line_2): Update.
1710         * defs.h (command_line_input): Make return type const.
1711         * cli/cli-script.c (read_next_line): Make return type const.
1712         * ada-lang.c (get_selections): Update.
1713
1714 2019-11-06  Christian Biesinger  <[email protected]>
1715
1716         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1717         * mi/mi-main.c (output_cores): Likewise.
1718         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1719         (linux_xfer_osdata_modules): Likewise.
1720         * remote.c (register_remote_support_xml): Likewise.
1721         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1722         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1723
1724 2019-11-06  Tom Tromey  <[email protected]>
1725
1726         * tui/tui-interp.c: Don't include readline.h.
1727         * tui/tui-hooks.c: Don't include readline.h.
1728         * symmisc.c: Include tilde.h, not readline.h.
1729         * symfile.c: Include tilde.h, not readline.h.
1730         * source.c: Include tilde.h, not readline.h.
1731         * solib.c: Include tilde.h, not readline.h.
1732         * psymtab.c: Include tilde.h, not readline.h.
1733         * exec.c: Include tilde.h, not readline.h.
1734         * corelow.c: Include tilde.h, not readline.h.
1735         * cli/cli-dump.c: Include tilde.h, not readline.h.
1736         * cli/cli-cmds.c: Don't include readline.h.
1737
1738 2019-11-05  Tom Tromey  <[email protected]>
1739
1740         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1741         (tui_disassemble): Set addr_size.
1742         (tui_disasm_window::set_contents): Use addr_size.
1743
1744 2019-11-05  Tom Tromey  <[email protected]>
1745
1746         * rust-lang.c (rust_language_defn): Update.
1747         * python/py-value.c (valpy_string): Call c_get_string.
1748         * p-lang.c (pascal_language_defn): Update.
1749         * opencl-lang.c (opencl_language_defn): Update.
1750         * objc-lang.c (objc_language_defn): Update.
1751         * m2-lang.c (m2_language_defn): Update.
1752         * language.c (unknown_language_defn, auto_language_defn): Update.
1753         (default_get_string): Remove.
1754         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1755         * go-lang.c (go_language_defn): Update.
1756         * f-lang.c (f_language_defn): Update.
1757         * d-lang.c (d_language_defn): Update.
1758         * c-lang.c (c_language_defn, cplus_language_defn)
1759         (asm_language_defn, minimal_language_defn): Update.
1760         * ada-lang.c (ada_language_defn): Update.
1761         * language.h (struct language_defn) <la_get_string>: Remove.
1762         (LA_GET_STRING): Remove.
1763         (default_get_string): Don't declare.
1764
1765 2019-11-05  Tom Tromey  <[email protected]>
1766
1767         * tui/tui-source.h (struct tui_source_window): Inline
1768         constructor.  Remove destructor.
1769         <style_changed, m_observable>: Move to superclass.
1770         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1771         (struct tui_source_window_base): Move private members to end.
1772         <style_changed, m_observable>: Move from tui_source_window.
1773         * tui/tui-winsource.c (tui_copy_source_line): Move from
1774         tui-source.c.  Rename from copy_source_line.  Add special handling
1775         for negative line number.
1776         (tui_source_window_base::style_changed): Move from
1777         tui_source_window.
1778         (tui_source_window_base): Register observer.
1779         (~tui_source_window_base): New.
1780         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1781         rename.
1782         (tui_source_window::set_contents): Use tui_copy_source_line.
1783         (tui_source_window::tui_source_window): Move to tui-source.h.
1784         (tui_source_window::~tui_source_window): Remove.
1785         (tui_source_window::style_changed): Move to superclass.
1786         * tui/tui-disasm.c (tui_disassemble): Create string file with
1787         styling, when possible.  Add "addr_size" parameter.
1788         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1789         Don't compute maximum size.
1790         (len_without_escapes): New function
1791
1792 2019-11-05  Tom Tromey  <[email protected]>
1793
1794         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1795         std::string.
1796         * tui/tui-winsource.c (tui_show_source_line): Update.
1797         * tui/tui-source.c (tui_source_window::set_contents): Update.
1798         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1799
1800 2019-11-05  Christian Biesinger  <[email protected]>
1801
1802         * symtab.h (gdb_static_assert): Put && operator at the beginning
1803         of the line instead of the end.
1804
1805 2019-11-04  Christian Biesinger  <[email protected]>
1806
1807         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1808         and sizeof (symbol).
1809         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1810
1811 2019-11-04  Rainer Orth  <[email protected]>
1812
1813         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1814         * configure.host: Mark *-*-solaris2.10* obsolete.
1815         * configure.tgt: Mark Solaris < 11 obsolete.
1816         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1817         Update target triplet.
1818
1819 2019-11-01  Tom Tromey  <[email protected]>
1820
1821         * utils.c (print_sys_errmsg): Simplify.
1822
1823 2019-11-01  Tom Tromey  <[email protected]>
1824
1825         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1826
1827 2019-11-01  Christian Biesinger  <[email protected]>
1828
1829         * configure: Regenerate.
1830         * configure.ac: Remove check for strerror_r.
1831         * gdbsupport/common.m4: Check for strerror_r.
1832
1833 2019-11-01  Luis Machado  <[email protected]>
1834
1835         PR gdb/25124
1836
1837         * arm-tdep.c (arm_per_objfile): Rename to ...
1838         (arm_per_bfd): ... this.
1839         (arm_objfile_data_key): Rename to ...
1840         (arm_bfd_data_key): ... this.
1841         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1842         data.
1843         (arm_record_special_symbol): Likewise.
1844
1845 2019-10-31  Andrew Burgess  <[email protected]>
1846
1847         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1848         end.
1849         * c-typeprint.c (c_print_typedef): Likewise.
1850         * f-typeprint.c (f_print_typedef): Likewise.
1851         * m2-typeprint.c (m2_print_typedef): Likewise.
1852         * p-typeprint.c (pascal_print_typedef): Likewise.
1853         * rust-lang.c (rust_print_typedef): Likewise.
1854         * symtab.c (print_symbol_info): Print a newline after calling
1855         typedef_print.
1856
1857 2019-10-31  Andrew Burgess  <[email protected]>
1858
1859         * symtab.c (info_module_cmdlist): New variable.
1860         (info_module_command): New function.
1861         (search_module_symbols): New function.
1862         (info_module_subcommand): New function.
1863         (struct info_modules_var_func_options): New struct.
1864         (info_modules_var_func_options_defs): New variable.
1865         (make_info_modules_var_func_options_def_group): New function.
1866         (info_module_functions_command): New function.
1867         (info_module_variables_command): New function.
1868         (info_module_var_func_command_completer): New function.
1869         (_initialize_symtab): Register new 'info module functions' and
1870         'info module variables' commands.
1871         * symtab.h (typedef symbol_search_in_module): New typedef.
1872         (search_module_symbols): Declare new function.
1873         * NEWS: Mention new commands.
1874
1875 2019-10-31  Andrew Burgess  <[email protected]>
1876
1877         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1878         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1879         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1880         MODULES_DOMAIN.
1881         (scan_partial_symbols): Only create partial module symbols for non
1882         declarations.
1883         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1884         and MODULES_DOMAIN.
1885         * symtab.c (search_domain_name): Likewise.
1886         (search_symbols): Likewise.
1887         (print_symbol_info): Likewise.
1888         (symtab_symbol_info): Likewise.
1889         (info_modules_command): New function.
1890         (_initialize_symtab): Register 'info modules' command.
1891         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1892         * NEWS: Mention new 'info modules' command.
1893
1894 2019-10-31  Philippe Waroquiers  <[email protected]>
1895
1896         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1897         and $_gdb_maint_setting_str.
1898
1899 2019-10-31  Philippe Waroquiers  <[email protected]>
1900
1901         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1902         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1903         (str_value_from_setting, gdb_setting_str_internal_fn)
1904         (gdb_maint_setting_str_internal_fn): New functions.
1905         (_initialize_cli_cmds): Define the new convenience functions.
1906         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1907         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1908
1909 2019-10-31  Christian Biesinger  <[email protected]>
1910
1911         * agent.c (set_can_use_agent): When the setting is turned on,
1912         look up agent symbols if we don't have them yet.
1913         (agent_new_objfile): Don't look up agent symbols when the agent
1914         setting is off.
1915
1916 2019-10-31  Christian Biesinger  <[email protected]>
1917
1918         * config.in: Regenerate.
1919
1920 2019-10-31  Christian Biesinger  <[email protected]>
1921
1922         * configure: Regenerate.
1923         * configure.ac: Check for strerror_r.
1924         * gdbsupport/common-utils.h (safe_strerror): Change return value
1925         to const char * and document that this function is now threadsafe.
1926         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1927         thread_local and call strerror_r, if available.
1928         * utils.c (perror_string): Update.
1929         (print_sys_errmsg): Update.
1930
1931 2019-10-31  Luis Machado  <[email protected]>
1932
1933         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1934         objfile_key.
1935         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1936         objfile to fetch per-bfd data.
1937         (arm_find_exidx_entry): Likewise.
1938
1939 2019-10-31  Christian Biesinger  <[email protected]>
1940
1941         * gdbsupport/agent.c (debug_agent): Change type to bool.
1942         (use_agent): Likewise.
1943         (all_agent_symbols_look_up): Likewise.
1944         (agent_loaded_p): Change return value to bool.
1945         (agent_look_up_symbols): Update.
1946         (agent_capability_check): Change return value to bool.
1947         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1948         (debug_agent): Change type to bool.
1949         (use_agent): Likewise.
1950         (agent_capability_check): Change return value to bool.
1951
1952 2019-10-30  Christian Biesinger  <[email protected]>
1953
1954         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1955         (build_minimal_symbol_hash_tables): Code to clear the table moved
1956         to clear_minimal_symbol_hash_tables.
1957         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1958         when needed.
1959
1960 2019-10-29  Simon Marchi  <[email protected]>
1961
1962         * infcmd.c: Remove includes.
1963         * infrun.c: Remove includes.
1964
1965 2019-10-29  Simon Marchi  <[email protected]>
1966
1967         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1968         (grow_vect): Remove declaration.
1969         (ada_type_of_array): Remove declaration.
1970         (ada_update_initial_language): Remove declaration.
1971         (ada_fold_name): Remove declaration.
1972         (ada_fill_in_ada_prototype): Remove declaration.
1973         (user_select_syms): Remove declaration.
1974         (get_selections): Remove declaration.
1975         (ada_tag_type): Remove declaration.
1976         (ada_value_tag): Remove declaration.
1977         (ada_is_others_clause): Remove declaration.
1978         (ada_in_variant): Remove declaration.
1979         (ada_value_struct_elt): Remove declaration.
1980         (ada_attribute_name): Remove declaration.
1981         (ada_system_address_type): Remove declaration.
1982         * ada-lang.c (ada_watch_location_expression): Make static.
1983         (GROW_VECT): Move here from ada-lang.h.
1984         (grow_vect): Make static.
1985         (ada_update_initial_language): Make static.
1986         (ada_fold_name): Make static.
1987         (ada_type_of_array): Make static.
1988         (encoded_ordered_before): Move up.
1989         (sort_choices): Move up.
1990         (print_signatures): Move up.
1991         (ada_print_symbol_signature): Move up.
1992         (get_selections): Move up and make static.
1993         (user_select_syms): Move up and make static.
1994         (ada_value_struct_elt): Move up and make static.
1995         (ada_tag_type): Make static.
1996         (ada_value_tag): Make static.
1997         (ada_is_others_clause): Make static.
1998         (ada_in_variant): Make static.
1999         (ada_attribute_name): Make static.
2000
2001 2019-10-29  Simon Marchi  <[email protected]>
2002
2003         * ada-lang.c: Remove includes.
2004         * ada-typeprint.c: Remove includes.
2005         * ada-valprint.c: Remove includes.
2006
2007 2019-10-29  Simon Marchi  <[email protected]>
2008
2009         * addrmap.c: Add static assertions of type size, moved from
2010         _initialize_addrmap.
2011         (_initialize_addrmap): Remove.
2012
2013 2019-10-29  Christian Biesinger  <[email protected]>
2014
2015         * coffread.c (record_minimal_symbol): Update.
2016         (process_coff_symbol): Update.
2017         * dbxread.c (read_dbx_symtab): Update.
2018         * dwarf2read.c (add_partial_symbol): Update.
2019         (fixup_go_packaging): Update.
2020         (load_partial_dies): Update.
2021         (new_symbol): Update.
2022         * elfread.c (record_minimal_symbol): Change signature to use
2023         gdb::string_view instead of name+len.
2024         (elf_symtab_read): Update.
2025         (elf_rel_plt_read): Update.
2026         * mdebugread.c (parse_partial_symbols): Update.
2027         (handle_psymbol_enumerators): Update.
2028         (new_symbol): Update.
2029         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2030         to use gdb::string_view instead of name+len.
2031         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2032         * psympriv.h (add_psymbol_to_list): Likewise.
2033         * psymtab.c (add_psymbol_to_bcache): Likewise.
2034         (add_psymbol_to_list): Likewise.
2035         * stabsread.c (define_symbol): Update.
2036         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2037         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2038         (symbol_set_names): Likewise.
2039         * xcoffread.c (scan_xcoff_symtab): Update.
2040
2041 2019-10-29  Christian Biesinger  <[email protected]>
2042
2043         * symtab.h (symbol_set_names): Document that copy_name must be
2044         set to true for non-nullterminated strings.
2045         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2046         linkage_name if the entry was not found and we need to demangle.
2047
2048 2019-10-29  Christian Biesinger  <[email protected]>
2049
2050         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2051         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2052         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2053         * gdbsupport/gdb_binary_search.h: New file.
2054
2055 2019-10-29  Christian Biesinger  <[email protected]>
2056
2057         * NEWS: Mention new --with-system-gdbinit-dir option.
2058         * config.in: Regenerate.
2059         * configure: Regenerate.
2060         * configure.ac: Add new option --with-system-gdbinit-dir.
2061         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2062         for a ".gdb" suffix.
2063         * main.c (get_init_files): Change system_gdbinit argument to
2064         a vector and return the files in SYSTEM_GDBINIT_DIR in
2065         addition to SYSTEM_GDBINIT.
2066         (captured_main_1): Update.
2067         (print_gdb_help): Update.
2068         * top.c (print_gdb_configuration): Also print the value of
2069         SYSTEM_GDBINIT_DIR.
2070
2071 2019-10-28  Christian Biesinger  <[email protected]>
2072
2073         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2074         that takes gdb::string_view arguments.
2075
2076 2019-10-26  Tom de Vries  <[email protected]>
2077
2078         * aarch64-linux-tdep.c: Fix typos in comments.
2079         * aarch64-tdep.c: Same.
2080         * ada-lang.c: Same.
2081         * amd64-nat.c: Same.
2082         * arc-tdep.c: Same.
2083         * arch/aarch64-insn.c: Same.
2084         * block.c: Same.
2085         * breakpoint.h: Same.
2086         * btrace.h: Same.
2087         * c-varobj.c: Same.
2088         * cli/cli-decode.c: Same.
2089         * cli/cli-script.c: Same.
2090         * cli/cli-utils.h: Same.
2091         * coff-pe-read.c: Same.
2092         * coffread.c: Same.
2093         * compile/compile-cplus-symbols.c: Same.
2094         * compile/compile-object-run.c: Same.
2095         * completer.c: Same.
2096         * corelow.c: Same.
2097         * cp-support.c: Same.
2098         * demangle.c: Same.
2099         * dwarf-index-write.c: Same.
2100         * dwarf2-frame.c: Same.
2101         * dwarf2-frame.h: Same.
2102         * eval.c: Same.
2103         * frame-base.h: Same.
2104         * frame.h: Same.
2105         * gdbcmd.h: Same.
2106         * gdbtypes.h: Same.
2107         * gnu-nat.c: Same.
2108         * guile/scm-objfile.c: Same.
2109         * i386-tdep.c: Same.
2110         * i386-tdep.h: Same.
2111         * infcall.c: Same.
2112         * infcall.h: Same.
2113         * linux-nat.c: Same.
2114         * m68k-tdep.c: Same.
2115         * macroexp.c: Same.
2116         * memattr.c: Same.
2117         * mi/mi-cmd-disas.c: Same.
2118         * mi/mi-getopt.h: Same.
2119         * mi/mi-main.c: Same.
2120         * minsyms.c: Same.
2121         * nat/aarch64-sve-linux-sigcontext.h: Same.
2122         * objfiles.h: Same.
2123         * ppc-linux-nat.c: Same.
2124         * ppc-linux-tdep.c: Same.
2125         * ppc-tdep.h: Same.
2126         * progspace.h: Same.
2127         * prologue-value.h: Same.
2128         * python/py-evtregistry.c: Same.
2129         * python/py-instruction.h: Same.
2130         * record-btrace.c: Same.
2131         * record-full.c: Same.
2132         * remote.c: Same.
2133         * rs6000-tdep.c: Same.
2134         * ser-tcp.c: Same.
2135         * sol-thread.c: Same.
2136         * sparc-sol2-tdep.c: Same.
2137         * sparc64-tdep.c: Same.
2138         * stabsread.c: Same.
2139         * symfile.c: Same.
2140         * symtab.h: Same.
2141         * target.c: Same.
2142         * tracepoint.c: Same.
2143         * tui/tui-data.h: Same.
2144         * tui/tui-io.c: Same.
2145         * tui/tui-win.c: Same.
2146         * tui/tui.c: Same.
2147         * unittests/rsp-low-selftests.c: Same.
2148         * user-regs.h: Same.
2149         * utils.c: Same.
2150         * utils.h: Same.
2151         * valarith.c: Same.
2152         * valops.c: Same.
2153         * valprint.c: Same.
2154         * valprint.h: Same.
2155         * value.c: Same.
2156         * value.h: Same.
2157         * varobj.c: Same.
2158         * x86-nat.h: Same.
2159         * xtensa-tdep.c: Same.
2160
2161 2019-10-25  Ali Tamur <[email protected]>
2162
2163         * charset.c (find_charset_names): Reflect API change.
2164
2165 2019-10-25  Christian Biesinger  <[email protected]>
2166
2167         * symtab.c (struct demangled_name_entry): Change demangled name
2168         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2169         part of the struct anymore.
2170         (symbol_set_names): No longer obstack allocate + copy the demangled
2171         name, just store the allocated name from bfd.
2172
2173 2019-10-25  Tom Tromey  <[email protected]>
2174
2175         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2176         (bsearch_cie_cmp, add_cie): Remove.
2177         (find_cie): Reimplement.
2178         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2179         (dwarf2_build_frame_info): Update.
2180
2181 2019-10-24  H.J. Lu  <[email protected]>
2182
2183         PR gdb/25126
2184         * symfile.c (reread_symbols): Call forget_cached_source_info to
2185         clear the stale source cache.
2186
2187 2019-10-24  Christian Biesinger  <[email protected]>
2188
2189         * configure: Regenerate.
2190         * configure.ac: Remove code that sets python_has_threads.
2191
2192 2019-10-24  Christian Biesinger  <[email protected]>
2193
2194         * config.in: Regenerate.
2195         * configure: Regenerate.
2196         * configure.ac: Remove the code that uses sed to get the python
2197         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2198
2199 2019-10-24  Andrew Burgess  <[email protected]>
2200
2201         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2202         error paths.
2203
2204 2019-10-23  Tom Tromey  <[email protected]>
2205
2206         * arc-tdep.c: Remove ".." from include.
2207         * frv-tdep.c: Remove ".." from include.
2208         * lm32-tdep.c: Remove ".." from include.
2209         * microblaze-tdep.c: Remove ".." from include.
2210         * or1k-tdep.h: Remove ".." from include.
2211         * s12z-tdep.c: Remove ".." from include.
2212         * Makefile.in (OPCODES_CFLAGS): Add comment.
2213         (TOP_CFLAGS): New variable.
2214         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2215
2216 2019-10-23  Tom Tromey  <[email protected]>
2217
2218         * Makefile.in (READLINE_DIR): Update.
2219
2220 2019-10-23  Tankut Baris Aktemur  <[email protected]>
2221
2222         * infcall.c (call_function_by_hand_dummy): Fix the function
2223         comment.  And extract out a code section into...
2224         (reserve_stack_space): ...this new function.
2225
2226 2019-10-23  Tankut Baris Aktemur  <[email protected]>
2227
2228         * infcall.c (value_arg_coerce): Remove an unused parameter.
2229         (call_function_by_hand_dummy): Update the call to
2230         'value_arg_coerce'.
2231
2232 2019-10-23  Tankut Baris Aktemur  <[email protected]>
2233
2234         * infcall.c (call_function_by_hand_dummy): Refactor.
2235
2236 2019-10-23  Tankut Baris Aktemur  <[email protected]>
2237
2238         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2239
2240 2019-10-23  Tom Tromey  <[email protected]>
2241
2242         * configure: Rebuild.
2243         * configure.ac: Don't check for sigprocmask.
2244         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2245
2246 2019-10-23  Tom Tromey  <[email protected]>
2247
2248         * configure: Rebuild.
2249         * acinclude.m4: Use m4_include, not sinclude.
2250
2251 2019-10-23  Tom de Vries  <[email protected]>
2252
2253         PR breakpoints/24687
2254         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2255
2256 2019-10-22  Christian Biesinger  <[email protected]>
2257
2258         * symtab.c (struct demangled_name_entry) <language>: Change from
2259         bitfield to regular variable.
2260
2261 2019-10-22  Christian Biesinger  <[email protected]>
2262
2263         * symtab.c (struct demangled_name_entry): Add a constructor.
2264         (free_demangled_name_entry): New function to call the destructor
2265         for demangled_name_entry.
2266         (create_demangled_names_hash): Pass free_demangled_name_entry to
2267         htab_create_alloc.
2268         (symbol_set_names): Call placement new for demangled_name_entry.
2269         * utils.c: No longer include xxhash.h here, now that fast_hash
2270         is inlined in the header.
2271         * utils.h: Instead, include it here.
2272
2273 2019-10-22  Christian Biesinger  <[email protected]>
2274
2275         * Makefile.in: Link with libxxhash.
2276         * config.in: Regenerate.
2277         * configure: Regenerate.
2278         * configure.ac: Search for libxxhash.
2279         * utils.c (fast_hash): Use xxhash if present.
2280
2281 2019-10-22  Christian Biesinger  <[email protected]>
2282
2283         * utils.h (fast_hash): New function.
2284         * symtab.c (hash_demangled_name_entry): Call new function
2285         fast_hash.
2286
2287 2019-10-22  Christian Biesinger  <[email protected]>
2288
2289         * symtab.c (struct demangled_name_entry): Change type of mangled
2290         to gdb::string_view. Also adds a constructor that takes the
2291         mangled name.
2292         (hash_demangled_name_entry): Update.
2293         (eq_demangled_name_entry): Update.
2294         (free_demangled_name_entry): New function to call the destructor
2295         now that this is not a POD anymore.
2296         (create_demangled_names_hash): Pass free_demangled_name_entry to
2297         htab_create_alloc.
2298         (symbol_set_names): Update.
2299
2300 2019-10-21  Ali Tamur  <[email protected]>
2301
2302         * dwarf2read.c (dir_index): Change type.
2303         (file_name_index): Likewise.
2304         (line_header::include_dir_at): Change comment and implementation on
2305         whether it is DWARF 5.
2306         (line_header::is_valid_file_index): New function.
2307         (line_header::file_name_at): Change comment and implementation on
2308         whether it is DWARF 5.
2309         (line_header::file_names): Change to private field renamed as
2310         m_file_names and introduce a new accessor method.
2311         (line_header::file_names_size): New method.
2312         (line_header::include_dirs): Change to private field and rename as
2313         m_include_dirs.
2314         (dw2_get_file_names_reader): Define local var at a smaller scope and
2315         reflect API change.
2316         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2317         (process_structure_scope): Likewise.
2318         (line_header::add_include_dir): Change message and reflect renaming.
2319         (line_header::add_file_name): Likewise.
2320         (read_formatted_entries): Handle DW_FORM_data16.
2321         (dwarf_decode_line_header): Fix line header length calculation.
2322         (psymtab_include_file_name): Change comment and API.
2323         (lnp_state_machine::m_file): Update comment and reflect type change.
2324         (lnp_state_machine::record_line): Reflect type change.
2325         (dwarf_decode_lines): Reflect API change.
2326         (file_file_name): Likewise.
2327         (file_full_name): Likewise.
2328
2329 2019-10-21  Andrew Burgess  <[email protected]>
2330
2331         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2332
2333 2019-10-21  Tom Tromey  <[email protected]>
2334
2335         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2336
2337 2019-10-21  Tom Tromey  <[email protected]>
2338
2339         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2340         NM_H.   Use AC_CONFIG_LINKS.
2341         * configure: Rebuild.
2342         * Makefile.in (NM_H): New variable.
2343         (generated_files): Add NM_H.  Remove gcore.
2344         (nm.h, stamp-nmh): New targets.
2345
2346 2019-10-20  Tom Tromey  <[email protected]>
2347
2348         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2349         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2350         obsolete comment.
2351         (put_objfile_before): Now static.
2352
2353 2019-10-19  Simon Marchi  <[email protected]>
2354
2355         * gdbsupport/common-utils.h (startswith): Change return type to
2356         bool.
2357
2358 2019-10-19  Christian Biesinger  <[email protected]>
2359
2360         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2361         * breakpoint.c (bp_locations_compare): Rename to...
2362         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2363         (update_global_location_list): Use std::sort instead of qsort.
2364         * buildsym.c (compare_line_numbers): Rename to...
2365         (lte_is_less_than): ...this, and change to std::sort semantics.
2366         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2367         instead of qsort.
2368         * disasm.c (compare_lines): Rename to...
2369         (line_is_less_than): ...this, and change to std::sort semantics.
2370         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2371         of qsort.
2372         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2373         (fde_is_less_than): ...this, and change to std::sort semantics.
2374         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2375         * mdebugread.c (compare_blocks):
2376         (block_is_less_than): ...this, and change to std::sort semantics.
2377         (sort_blocks): Call std::sort instead of qsort.
2378         * objfiles.c (qsort_cmp): Rename to...
2379         (sort_cmp): ...this, and change to std::sort semantics.
2380         (update_section_map): Call std::sort instead of qsort.
2381         * remote.c (compare_pnums): Remove.
2382         (map_regcache_remote_table): Call std::sort instead of qsort.
2383         * utils.c (compare_positive_ints): Remove.
2384         * utils.h (compare_positive_ints): Remove.
2385         * xcoffread.c (compare_lte): Remove.
2386         (arrange_linetable): Call std::sort instead of qsort.
2387
2388 2019-10-19  Sergio Durigan Junior  <[email protected]>
2389
2390         * symfile.c (init_entry_point_info): Fix typo.
2391         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2392
2393 2019-10-18  Tom de Vries  <[email protected]>
2394
2395         * aarch64-tdep.c: Fix typos in comments.
2396         * ada-lang.c: Same.
2397         * ada-tasks.c: Same.
2398         * alpha-tdep.c: Same.
2399         * alpha-tdep.h: Same.
2400         * amd64-nat.c: Same.
2401         * amd64-windows-tdep.c: Same.
2402         * arc-tdep.c: Same.
2403         * arc-tdep.h: Same.
2404         * arch-utils.c: Same.
2405         * arm-nbsd-tdep.c: Same.
2406         * arm-tdep.c: Same.
2407         * ax-gdb.c: Same.
2408         * blockframe.c: Same.
2409         * btrace.c: Same.
2410         * c-varobj.c: Same.
2411         * coff-pe-read.c: Same.
2412         * coffread.c: Same.
2413         * cris-tdep.c: Same.
2414         * darwin-nat.c: Same.
2415         * dbxread.c: Same.
2416         * dcache.c: Same.
2417         * disasm.c: Same.
2418         * dtrace-probe.c: Same.
2419         * dwarf-index-write.c: Same.
2420         * dwarf2-frame-tailcall.c: Same.
2421         * dwarf2-frame.c: Same.
2422         * dwarf2read.c: Same.
2423         * eval.c: Same.
2424         * exceptions.c: Same.
2425         * fbsd-tdep.c: Same.
2426         * findvar.c: Same.
2427         * frame.c: Same.
2428         * frv-tdep.c: Same.
2429         * gnu-v3-abi.c: Same.
2430         * go32-nat.c: Same.
2431         * h8300-tdep.c: Same.
2432         * hppa-tdep.c: Same.
2433         * i386-linux-tdep.c: Same.
2434         * i386-tdep.c: Same.
2435         * ia64-libunwind-tdep.c: Same.
2436         * ia64-tdep.c: Same.
2437         * infcmd.c: Same.
2438         * infrun.c: Same.
2439         * linespec.c: Same.
2440         * linux-nat.c: Same.
2441         * linux-thread-db.c: Same.
2442         * machoread.c: Same.
2443         * mdebugread.c: Same.
2444         * mep-tdep.c: Same.
2445         * mn10300-tdep.c: Same.
2446         * namespace.c: Same.
2447         * objfiles.c: Same.
2448         * opencl-lang.c: Same.
2449         * or1k-tdep.c: Same.
2450         * osabi.c: Same.
2451         * ppc-linux-nat.c: Same.
2452         * ppc-linux-tdep.c: Same.
2453         * ppc-sysv-tdep.c: Same.
2454         * printcmd.c: Same.
2455         * procfs.c: Same.
2456         * record-btrace.c: Same.
2457         * record-full.c: Same.
2458         * remote-fileio.c: Same.
2459         * remote.c: Same.
2460         * rs6000-tdep.c: Same.
2461         * s12z-tdep.c: Same.
2462         * score-tdep.c: Same.
2463         * ser-base.c: Same.
2464         * ser-go32.c: Same.
2465         * skip.c: Same.
2466         * sol-thread.c: Same.
2467         * solib-svr4.c: Same.
2468         * solib.c: Same.
2469         * source.c: Same.
2470         * sparc-nat.c: Same.
2471         * sparc-sol2-tdep.c: Same.
2472         * sparc-tdep.c: Same.
2473         * sparc64-tdep.c: Same.
2474         * stabsread.c: Same.
2475         * stack.c: Same.
2476         * symfile.c: Same.
2477         * symtab.c: Same.
2478         * target-descriptions.c: Same.
2479         * target-float.c: Same.
2480         * thread.c: Same.
2481         * utils.c: Same.
2482         * valops.c: Same.
2483         * valprint.c: Same.
2484         * value.c: Same.
2485         * varobj.c: Same.
2486         * windows-nat.c: Same.
2487         * xcoffread.c: Same.
2488         * xstormy16-tdep.c: Same.
2489         * xtensa-tdep.c: Same.
2490
2491 2019-10-17  Tom Tromey  <[email protected]>
2492
2493         * configure: Rebuild.
2494         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2495         in AC_CONFIG_FILES invocation.
2496         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2497         new-style config.status invocation.
2498
2499 2019-10-17  Tom de Vries  <[email protected]>
2500
2501         * arm-nbsd-nat.c: Fix typos in comments.
2502         * arm-tdep.c: Same.
2503         * darwin-nat-info.c: Same.
2504         * dwarf2read.c: Same.
2505         * elfread.c: Same.
2506         * event-top.c: Same.
2507         * findvar.c: Same.
2508         * gdbtypes.c: Same.
2509         * hppa-tdep.c: Same.
2510         * i386-tdep.c: Same.
2511         * jit.c: Same.
2512         * main.c: Same.
2513         * mdebugread.c: Same.
2514         * moxie-tdep.c: Same.
2515         * nto-procfs.c: Same.
2516         * osabi.c: Same.
2517         * ppc-linux-tdep.c: Same.
2518         * remote.c: Same.
2519         * riscv-tdep.c: Same.
2520         * s390-tdep.c: Same.
2521         * sh-tdep.c: Same.
2522         * sparc-linux-tdep.c: Same.
2523         * sparc-nat.c: Same.
2524         * stack.c: Same.
2525         * target-descriptions.c: Same.
2526         * top.c: Same.
2527         * varobj.c: Same.
2528
2529 2019-10-16  Tom Tromey  <[email protected]>
2530
2531         * objfiles.h (struct objfile) <original_name>: Now const.
2532
2533 2019-10-16  Christian Biesinger  <[email protected]>
2534
2535         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2536         pass on to sigsetjmp's second argument.
2537         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2538
2539 2019-10-16  Keith Seitz  <[email protected]>
2540
2541         PR gdb/23567
2542         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2543         sections whose size is greater than the file size.
2544
2545 2019-10-16  Jim Wilson  <[email protected]>
2546
2547         * riscv-tdep.c (riscv_gcc_target_options): New.
2548         (riscv_gnu_triplet_regexp): New.
2549         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2550         set_gdbarch_gnu_triplet_regexp.
2551
2552 2019-10-16  Christian Biesinger  <[email protected]>
2553
2554         * Makefile.in: Add xml-builtin.h.
2555         * features/feature_to_c.sh: Add an include for xml-builtin.h
2556         to ensure that the compiler checks that the types match.
2557         * xml-builtin.h: New file.
2558         * xml-support.c (fetch_xml_builtin): Add missing const.
2559         * xml-support.h: Remove declaration of xml_builtins.
2560
2561 2019-10-16  Tom de Vries  <[email protected]>
2562
2563         PR tdep/25096
2564         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2565         (amd64_classify_aggregate): ... here.
2566         (amd64_classify_aggregate_field): Handled fiels of nested structs
2567         recursively.
2568
2569 2019-10-16  Tom de Vries  <[email protected]>
2570
2571         PR tdep/24104
2572         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2573         that handles 'theclass'.
2574
2575 2019-10-15  Andrew Burgess  <[email protected]>
2576
2577         * linespec.c (decode_digits_ordinary): Update comment.
2578         * make-target-delegates: No longer need to handle VEC case.
2579         * memrange.c (normalize_mem_ranges): Update comment.
2580         * namespace.c (add_using_directive): Update comment.
2581         * objc-lang.c (uniquify_strings): Update comment.
2582         * ppc-linux-nat.c (struct thread_points): Update comment.
2583         * probe.h (find_probes_in_objfile): Update comment.
2584         * target.h (enum flash_preserve_mode): Update comment.
2585         * varobj.c (varobj_restrict_range): Update comment.
2586         * varobj.h (varobj_list_children): Update comment.
2587
2588 2019-10-15  Andrew Burgess  <[email protected]>
2589
2590         * Makefile.in: Remove references to vec.h and vec.c.
2591         * aarch64-tdep.c: No longer include vec.h.
2592         * ada-lang.c: Likewise.
2593         * ada-lang.h: Likewise.
2594         * arm-tdep.c: Likewise.
2595         * ax.h: Likewise.
2596         * breakpoint.h: Likewise.
2597         * charset.c: Likewise.
2598         * cp-support.h: Likewise.
2599         * dtrace-probe.c: Likewise.
2600         * dwarf2read.c: Likewise.
2601         * extension.h: Likewise.
2602         * gdb_bfd.c: Likewise.
2603         * gdbsupport/gdb_vecs.h: Likewise.
2604         * gdbsupport/vec.c: Remove.
2605         * gdbsupport/vec.h: Remove.
2606         * gdbthread.h: Likewise.
2607         * guile/scm-type.c: Likewise.
2608         * inline-frame.c: Likewise.
2609         * machoread.c: Likewise.
2610         * memattr.c: Likewise.
2611         * memrange.h: Likewise.
2612         * namespace.h: Likewise.
2613         * nat/linux-btrace.h: Likewise.
2614         * osdata.c: Likewise.
2615         * parser-defs.h: Likewise.
2616         * progspace.h: Likewise.
2617         * python/py-type.c: Likewise.
2618         * record-btrace.c: Likewise.
2619         * rust-exp.y: Likewise.
2620         * solib-target.c: Likewise.
2621         * stap-probe.c: Likewise.
2622         * target-descriptions.c: Likewise.
2623         * target-memory.c: Likewise.
2624         * target.h: Likewise.
2625         * varobj.c: Likewise.
2626         * varobj.h: Likewise.
2627         * xml-support.h: Likewise.
2628
2629 2019-10-15  Andrew Burgess  <[email protected]>
2630
2631         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2632         Update for new std::vector based implementation.
2633         (process_psymtab_comp_unit_reader): Likewise.
2634         (scan_partial_symbols): Likewise.
2635         (recursively_compute_inclusions): Likewise.
2636         (compute_compunit_symtab_includes): Likewise.
2637         (process_imported_unit_die): Likewise.
2638         (queue_and_load_dwo_tu): Likewise.
2639         (follow_die_sig_1): Likewise.
2640         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2641         (typedef dwarf2_per_cu_ptr): Remove.
2642         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2643         function.
2644         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2645         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2646         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2647         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2648         std::vector.
2649
2650 2019-10-15  Tom Tromey  <[email protected]>
2651
2652         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2653         TID.
2654
2655 2019-10-15  Tom Tromey  <[email protected]>
2656
2657         * windows-nat.c (windows_nat_target::fetch_registers)
2658         (windows_nat_target::store_registers): Rename "pid" to "tid".
2659
2660 2019-10-15  Tom Tromey  <[email protected]>
2661
2662         * gdbarch.h, gdbarch.c: Rebuild.
2663         * gdbarch.sh (gcc_target_options): Change return type to
2664         std::string.
2665         * compile/compile.c (get_args): Update.
2666         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2667         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2668         std::string.
2669         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2670         std::string.
2671         * arch-utils.c (default_gcc_target_options): Return std::string.
2672         * arch-utils.h (default_gcc_target_options): Return std::string.
2673         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2674
2675 2019-10-15  Christian Biesinger  <[email protected]>
2676
2677         * breakpoint.c (breakpoint_chain): Make static.
2678         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2679         of accessing breakpoint_chain.
2680
2681 2019-10-15  Christian Biesinger  <[email protected]>
2682
2683         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2684         to a gdb::function_view and return value to bool.
2685         * breakpoint.h (iterate_over_breakpoints): Likewise.
2686         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2687         (pop_dummy_frame): Update.
2688         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2689         (gdbscm_breakpoints): Update.
2690         * python/py-breakpoint.c (build_bp_list): Update.
2691         (gdbpy_breakpoints): Update.
2692         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2693         Update.
2694         (bpfinishpy_handle_stop): Update.
2695         (bpfinishpy_handle_exit): Update.
2696         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2697         (svr4_update_solib_event_breakpoints): Update.
2698
2699 2019-10-15  Andreas Arnez  <[email protected]>
2700
2701         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2702         when unwrapping single-field structs.
2703
2704 2019-10-14  Simon Marchi  <[email protected]>
2705
2706         * dwarf2read.c: Remove includes.
2707
2708 2019-10-13  Simon Marchi  <[email protected]>
2709
2710         * ui-out.c (ui_out::call_do_message): Silence
2711         -Wformat-nonliteral warning.
2712
2713 2019-10-12  Simon Marchi  <[email protected]>
2714
2715         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2716         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2717         include: readline/tilde.h.
2718
2719 2019-10-12  Christian Biesinger  <[email protected]>
2720
2721         * remote.c (remote_target::get_trace_status): Remove declaration of
2722         trace_regblock_size.
2723
2724 2019-10-12  Christian Biesinger  <[email protected]>
2725
2726         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2727         (show_user): Remove declaration of cmdlist.
2728         * cli/cli-cmds.h (max_user_call_depth): Declare.
2729         * cli/cli-script.c (execute_user_command): Remove declaration
2730         of max_user_call_depth.
2731
2732 2019-10-11  Jim Wilson  <[email protected]>
2733
2734         * gdbsupport/print-utils.h (pulongest): Fix comment.
2735         (plongest): Likewise.
2736         (phex): Add missing comment, mention leading zeros.
2737         (phex_nz): Add mention of no leading zeros to comment.
2738
2739         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2740         plongest instead of unsigned long long cast.
2741
2742 2019-10-10  Christian Biesinger  <[email protected]>
2743
2744         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2745         for external_editor_command and gdbtk_test.
2746
2747 2019-10-10  Christian Biesinger  <[email protected]>
2748
2749         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2750         * varobj.c (varobjdebug): Move comment to...
2751         * varobj.h (varobjdebug): ...here, and declare.
2752
2753 2019-10-09  Tom Tromey  <[email protected]>
2754
2755         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2756         erase_data_content.
2757
2758 2019-10-09  Tom Tromey  <[email protected]>
2759
2760         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2761         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2762         * tui/tui-command.c (tui_cmd_window::resize)
2763         (tui_refresh_cmd_win): Update.
2764         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2765         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2766         * tui/tui-data.c (~tui_gen_win_info): Remove.
2767         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2768         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2769         (tui_redisplay_readline, tui_mld_flush)
2770         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2771         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2772         (tui_data_window::erase_data_content)
2773         (tui_data_item_window::rerender)
2774         (tui_data_item_window::refresh_window): Update.
2775         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2776         (box_win, tui_gen_win_info::make_window)
2777         (tui_gen_win_info::make_visible): Update.
2778         (tui_delete_win): Remove.
2779         * tui/tui-winsource.c
2780         (tui_source_window_base::do_erase_source_content): Update.
2781         (tui_show_source_line, tui_source_window_base::update_tab_width)
2782         (tui_source_window_base::update_exec_info): Update.
2783         * tui/tui-data.h (struct curses_deleter): New.
2784         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2785         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2786
2787 2019-10-09  Tom Tromey  <[email protected]>
2788
2789         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2790
2791 2019-10-09  Tom Tromey  <[email protected]>
2792
2793         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2794         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2795
2796 2019-10-09  Tom Tromey  <[email protected]>
2797
2798         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2799         window height directly.
2800         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2801         declare.
2802         * tui/tui-layout.c (tui_default_win_height): Remove.
2803         (tui_default_win_viewport_height): Remove.
2804
2805 2019-10-09  Tom Tromey  <[email protected]>
2806
2807         * tui/tui.h: Remove comments.
2808
2809 2019-10-09  Tom de Vries  <[email protected]>
2810
2811         * python/lib/gdb/printer/bound_registers.py: Use
2812         '^builtin_type_bound128' as regexp argument for
2813         add_builtin_pretty_printer.
2814
2815 2019-10-09  Christian Biesinger  <[email protected]>
2816
2817         * guile/guile.c (guile_extension_script_ops): Remove forward
2818         declaration and mark as static.
2819         (guile_script_ops): Likewise.
2820         (extension_language_guile): Move further down in the file so
2821         it can reference the definitions for guile_{extension_,}script_ops.
2822
2823 2019-10-09  Andreas Arnez  <[email protected]>
2824
2825         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2826         except SORTL, DFLTCC, and KDSA.
2827
2828 2019-10-08  Tom Tromey  <[email protected]>
2829
2830         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2831         (struct safe_symbol_file_add_args): Remove.
2832
2833 2019-10-08  Tom Tromey  <[email protected]>
2834
2835         * windows-nat.c: Don't include buildsym-legacy.h.
2836
2837 2019-10-08  Tom Tromey  <[email protected]>
2838
2839         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2840
2841 2019-10-08  Christian Biesinger  <[email protected]>
2842
2843         * gdbtypes.c (overload_debug): Move comment to header.
2844         * gdbtypes.h (overload_debug): Declare.
2845         * valops.c: Remove declaration of overload_debug, instead
2846         include gdbtypes.h.
2847
2848 2019-10-08  Christian Biesinger  <[email protected]>
2849
2850         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2851         through _().
2852         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2853         move comment...
2854         * language.h (lang_frame_mismatch_warn): ... here. Also add
2855         declaration.
2856         * top.c (lang_frame_mismatch_warn): Remove declaration.
2857         (check_frame_language_change): Pass lang_frame_mismatch_warn
2858         through _().
2859
2860 2019-10-07  Christian Biesinger  <[email protected]>
2861
2862         * c-lang.h (vtbl_ptr_name): Declare.
2863         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2864         it from the header.
2865         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2866
2867 2019-10-07  Christian Biesinger  <[email protected]>
2868
2869         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2870         gdb_static_assert.
2871
2872 2019-10-07  Weimin Pan  <[email protected]>
2873
2874         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2875         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2876         * ctfread.c: New file.
2877         * ctfread.h: New file.
2878         * elfread.c: Include ctfread.h.
2879         (struct elfinfo text_p): New member ctfsect.
2880         (elf_locate_sections): Mark CTF section.
2881         (elf_symfile_read): Call elfctf_build_psymtabs.
2882         * Makefile.in (LIBCTF): Add.
2883         (CLIBS): Use it.
2884         (CDEPS): Likewise.
2885         (DIST): Add ctfread.c.
2886
2887 2019-10-07  Andrew Burgess  <[email protected]>
2888
2889         * ctfread.c (struct nextfield): Renamed to ...
2890         (struct ctf_nextfield): ... this.
2891         (struct field_info): Renamed to ...
2892         (strut ctf_field_info): ... this.
2893         (attach_fields_to_type): Update for renamed structures.
2894         (ctf_add_member_cb): Likewise.
2895         (ctf_add_enum_member_cb): Likewise.
2896         (process_struct_members): Likewise.
2897         (process_enum_type): Likewise.
2898
2899 2019-10-07  Weimin Pan  <[email protected]>
2900
2901         * tracectf.h: Rename, was ctf.h.
2902         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2903         * tracefile.c: Likewise.
2904         * tracepoint.c: Remove unused include ctf.h.
2905         * mi/mi-main.c: Likewise.
2906         * Makefile.in Replace ctf.c with tracectf.c.
2907
2908 2019-10-06  Joel Brobecker  <[email protected]>
2909
2910         * version.in: Change version number to "9.0.50.DATE-git".
2911
2912 2019-10-03  Tom Tromey  <[email protected]>
2913
2914         PR rust/24976:
2915         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2916
2917 2019-10-03  Andrew Burgess  <[email protected]>
2918
2919         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2920         cp_search_name_hash.
2921         * NEWS: Add entry about nested function support.
2922
2923 2019-10-03  Bernhard Heckel  <[email protected]>
2924             Andrew Burgess  <[email protected]>
2925
2926         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2927         for nested static variables when searchin VAR_DOMAIN.
2928         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2929         global scope, update comment.
2930         (add_partial_subprogram): Call add_partial_subprogram recursively
2931         for nested subroutines when processinng Fortran.
2932         (load_partial_dies): Process the child entities of a subprogram
2933         when processing Fortran.
2934         (partial_die_parent_scope): Handle building scope
2935         for Fortran nested functions.
2936         (process_die): Record that nested functions have a scope.
2937         (new_symbol): Always record Fortran subprograms on the global
2938         symbol list.
2939         (determine_prefix): How to build the prefix for Fortran
2940         subprograms.
2941
2942 2019-10-03  Andrew Burgess  <[email protected]>
2943
2944         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2945         have just sent the thread a SIGSTOP and are waiting for it to
2946         arrive.
2947
2948 2019-10-03  Andrew Burgess  <[email protected]>
2949
2950         * btrace.c (btrace_add_pc): Remove whitespace before the template
2951         parameter in 'std::vector <...>'.
2952         (parse_xml_btrace_block): Likewise.
2953         (btrace_maint_decode_pt): Likewise.
2954         (btrace_maint_update_packets): Likewise.
2955         (btrace_maint_print_packets): Likewise.
2956         * btrace.h (struct btrace_maint_info): Likewise.
2957         * dwarf2read.c (struct type_unit_group): Likewise.
2958         (build_type_psymtabs_reader): Likewise.
2959         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2960         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2961         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2962
2963 2019-10-03  Tom de Vries  <[email protected]>
2964
2965         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2966         the first line of the help text for set/show style metadata.
2967
2968 2019-10-02  Tom Tromey  <[email protected]>
2969
2970         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2971         * gdbsupport/common-inferior.c: New file.
2972         * infcmd.c (startup_with_shell): Don't define.
2973         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2974         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2975         * inferior.h (startup_with_shell): Don't declare.
2976
2977 2019-10-02  Christian Biesinger  <[email protected]>
2978
2979         * gdbsupport/gdb_assert.h: Include errors.h.
2980         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2981
2982 2019-10-02  Tom Tromey  <[email protected]>
2983
2984         * NEWS: Add $_ada_exception entry.
2985         * ada-lang.c (struct ada_catchpoint): Add constructor.
2986         <m_kind>: New member.
2987         (allocate_location_exception, re_set_exception): Remove
2988         "ex" parameter.
2989         (should_stop_exception): Compute $_ada_exception.
2990         (check_status_exception, print_it_exception)
2991         (print_one_exception, print_mention_exception): Remove
2992         "ex" parameter.
2993         (allocate_location_catch_exception, re_set_catch_exception)
2994         (check_status_exception, print_it_catch_exception)
2995         (print_one_catch_exception, print_mention_catch_exception)
2996         (print_recreate_catch_exception)
2997         (allocate_location_catch_exception_unhandled)
2998         (re_set_catch_exception_unhandled)
2999         (check_status_exception, print_it_catch_exception_unhandled)
3000         (print_one_catch_exception_unhandled)
3001         (print_mention_catch_exception_unhandled)
3002         (print_recreate_catch_exception_unhandled)
3003         (allocate_location_catch_assert, re_set_catch_assert)
3004         (check_status_assert, print_it_catch_assert)
3005         (print_one_catch_assert, print_mention_catch_assert)
3006         (print_recreate_catch_assert)
3007         (allocate_location_catch_handlers, re_set_catch_handlers)
3008         (check_status_handlers, print_it_catch_handlers)
3009         (print_one_catch_handlers, print_mention_catch_handlers)
3010         (print_recreate_catch_handlers): Remove.
3011         (create_ada_exception_catchpoint): Update.
3012         (initialize_ada_catchpoint_ops): Update.
3013
3014 2019-10-02  Tom Tromey  <[email protected]>
3015
3016         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3017         (create_excep_cond_exprs): Simplify exception string computation.
3018         (ada_exception_catchpoint_cond_string): Likewise.
3019
3020 2019-10-02  Tom Tromey  <[email protected]>
3021
3022         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3023         * ada-lang.c (lesseq_defined_than): Handle
3024         LOC_STATIC.
3025         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3026         parameter.
3027         (dwarf2_has_info): Likewise.
3028         (new_symbol): Set maybe_copied on symbol when
3029         appropriate.
3030         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3031         parameter.
3032         <can_copy>: New member.
3033         * elfread.c (record_minimal_symbol): Set maybe_copied
3034         on symbol when appropriate.
3035         (elf_symfile_read): Update call to dwarf2_has_info.
3036         * minsyms.c (lookup_minimal_symbol_linkage): New
3037         function.
3038         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3039         * symtab.c (get_symbol_address, get_msymbol_address):
3040         New functions.
3041         * symtab.h (get_symbol_address, get_msymbol_address):
3042         Declare.
3043         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3044         maybe_copied.
3045         (struct symbol, struct minimal_symbol) <maybe_copied>:
3046         New member.
3047
3048 2019-10-02  Tom Tromey  <[email protected]>
3049
3050         * source.c (struct current_source_location): New.
3051         (current_source_key): New global.
3052         (current_source_symtab, current_source_line)
3053         (current_source_pspace): Remove.
3054         (get_source_location): New function.
3055         (get_current_source_symtab_and_line)
3056         (set_default_source_symtab_and_line)
3057         (set_current_source_symtab_and_line)
3058         (clear_current_source_symtab_and_line, select_source_symtab)
3059         (info_source_command, print_source_lines_base)
3060         (info_line_command, search_command_helper, _initialize_source):
3061         Update.
3062
3063 2019-10-02  Tom Tromey  <[email protected]>
3064
3065         * source.c (select_source_symtab): Don't call
3066         decode_line_with_current_source.
3067
3068 2019-10-02  Andrew Burgess  <[email protected]>
3069
3070         * symtab.c (lookup_global_symbol): Search global block.
3071
3072 2019-10-02  Tom Tromey  <[email protected]>
3073
3074         * coffread.c (process_coff_symbol): Update.
3075         * dwarf2read.c (var_decode_location, new_symbol): Update.
3076         * mdebugread.c (parse_symbol): Update.
3077         * objfiles.c (relocate_one_symbol): Update.
3078         * stabsread.c (define_symbol, fix_common_block)
3079         (scan_file_globals): Update.
3080         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3081         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3082         * xcoffread.c (process_xcoff_symbol): Update.
3083
3084 2019-10-02  Andreas Arnez  <[email protected]>
3085
3086         * MAINTAINERS: Update my email address.
3087
3088 2019-10-02  Andrew Burgess  <[email protected]>
3089
3090         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3091         std::vector.
3092         (build_type_psymtabs_reader): Update for std::vector.
3093         (build_type_psymtab_dependencies): Likewise.
3094         * dwarf2read.h: Remove use of DEF_VEC_P.
3095         (typedef sig_type_ptr): Delete.
3096
3097 2019-10-02  Andrew Burgess  <[email protected]>
3098
3099         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3100         to std::vector.
3101         (btrace_maint_decode_pt): Likewise, and move allocation of the
3102         vector outside of the loop.
3103         (btrace_maint_update_packets): Update to handle change from VEC to
3104         std::vector.
3105         (btrace_maint_print_packets): Likewise.
3106         (maint_info_btrace_cmd): Likewise.
3107         * btrace.h: Remove use of DEF_VEC_O.
3108         (typedef btrace_pt_packet_s): Delete.
3109         (struct btrace_maint_info) <packets>: Change fromm VEC to
3110         std::vector.
3111         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3112
3113 2019-10-02  Andrew Burgess  <[email protected]>
3114
3115         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3116         make accesses into the vector constant references.
3117         (btrace_add_pc): Update for std::vector.
3118         (btrace_stitch_bts): Likewise.
3119         (parse_xml_btrace_block): Likewise.
3120         (btrace_maint_update_packets): Likewise.
3121         (btrace_maint_print_packets): Likewise.
3122         (maint_info_btrace_cmd): Likewise.
3123         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3124         std::vector.
3125         (btrace_data::empty): Likewise.
3126         (btrace_data_append): Likewise.
3127         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3128         (typedef btrace_block_s): Delete.
3129         (struct btrace_block): Add constructor.
3130         (struct btrace_data_bts) <blocks>: Change to std::vector.
3131         * nat/linux-btrace.c (perf_event_read_bts): Update for
3132         std::vector.
3133         (linux_read_bts): Likewise.
3134
3135 2019-10-01  Tom Tromey  <[email protected]>
3136
3137         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3138
3139 2019-10-01  Tom Tromey  <[email protected]>
3140
3141         * stack.c (print_frame, info_frame_command_core): Use
3142         styled_string.
3143         * linux-thread-db.c (try_thread_db_load_1)
3144         (try_thread_db_load_from_pdir_1): Use styled_string.
3145         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3146         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3147         (maybe_print_unsupported_script_warning)
3148         (maybe_print_script_not_found_warning): Use styled_string.
3149         * ada-lang.c (user_select_syms): Use styled_string.
3150
3151 2019-10-01  Tom Tromey  <[email protected]>
3152
3153         * p-lang.c (pascal_printstr): Use metadata style.
3154         * value.c (show_convenience): Use metadata style.
3155         * valprint.c (valprint_check_validity, val_print_optimized_out)
3156         (val_print_not_saved, val_print_unavailable)
3157         (val_print_invalid_address, generic_val_print, val_print)
3158         (value_check_printable, val_print_array_elements): Use metadata
3159         style.
3160         * ui-out.h (class ui_out) <field_fmt>: New overload.
3161         <do_field_fmt>: Add style parameter.
3162         * ui-out.c (ui_out::field_fmt): New overload.
3163         * typeprint.c (type_print_unknown_return_type)
3164         (val_print_not_allocated, val_print_not_associated): Use metadata
3165         style.
3166         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3167         parameter.
3168         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3169         * tracepoint.c (tvariables_info_1): Use metadata style.
3170         * stack.c (print_frame_arg, print_frame_info, print_frame)
3171         (info_frame_command_core): Use metadata style.
3172         * skip.c (info_skip_command): Use metadata style.
3173         * rust-lang.c (rust_print_enum): Use metadata style.
3174         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3175         metadata style.
3176         * python/py-framefilter.c (py_print_single_arg): Use metadata
3177         style.
3178         * printcmd.c (do_one_display, print_variable_and_value): Use
3179         metadata style.
3180         * p-valprint.c (pascal_val_print)
3181         (pascal_object_print_value_fields): Use metadata style.
3182         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3183         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3184         parameter.
3185         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3186         * m2-valprint.c (m2_print_long_set): Use metadata style.
3187         * m2-typeprint.c (m2_print_type): Use metadata style.
3188         * infcmd.c (print_return_value_1): Use metadata style.
3189         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3190         * f-valprint.c (info_common_command_for_block): Use metadata
3191         style.
3192         * f-typeprint.c (f_type_print_base): Use metadata style.
3193         * expprint.c (print_subexp_standard): Use metadata style.
3194         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3195         * cli/cli-style.h (class cli_style_option): Add constructor.
3196         (metadata_style): Declare.
3197         * cli/cli-style.c (metadata_style): New global.
3198         (_initialize_cli_style): Register metadata style.
3199         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3200         parameter.
3201         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3202         * c-typeprint.c (c_type_print_base_struct_union)
3203         (c_type_print_base_1): Use metadata style.
3204         * breakpoint.c (watchpoint_value_print)
3205         (print_one_breakpoint_location): Use metadata style.
3206         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3207         style.
3208         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3209         style.
3210         * ada-valprint.c (val_print_packed_array_elements, printstr)
3211         (print_field_values, ada_val_print_ref, ada_val_print): Use
3212         metadata style.
3213         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3214         style.
3215         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3216         style.
3217         * ada-lang.c (user_select_syms): Use metadata style.
3218
3219 2019-10-01  Tom Tromey  <[email protected]>
3220
3221         * cli/cli-cmds.c (pwd_command): Style output.
3222
3223 2019-10-01  Pedro Alves  <[email protected]>
3224             Tom Tromey  <[email protected]>
3225
3226         * symtab.c (print_symbol_info): Use %ps.
3227         (print_msymbol_info): Use %ps.
3228         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3229         * printcmd.c (print_variable_and_value): Use %ps.
3230         * macrocmd.c (show_pp_source_pos): Use %ps.
3231         * infrun.c (print_exited_reason): Use ui_out::message.
3232         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3233         (describe_other_breakpoints): Use ui_out::message and new
3234         formats.
3235         (say_where): Use new formats.
3236         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3237         and new formats.
3238
3239 2019-10-01  Pedro Alves  <[email protected]>
3240             Tom Tromey  <[email protected]>
3241
3242         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3243         (test_gdb_formats): New function.
3244         (run_tests): Call it.
3245         (test_format_specifier): Update.
3246         * utils.h (fputs_filtered): Update comment.
3247         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3248         (fputs_styled_unfiltered): Declare.
3249         * utils.c (fputs_styled_unfiltered): New function.
3250         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3251         (vfprintf_filtered): Update.
3252         (vfprintf_unfiltered, vprintf_filtered): Update.
3253         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3254         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3255         disallow_ui_out_field>: New constants.
3256         (enum class field_kind): New.
3257         (struct base_field_s, struct signed_field_s): New.
3258         (signed_field): New function.
3259         (struct string_field_s): New.
3260         (string_field): New function.
3261         (struct styled_string_s): New.
3262         (styled_string): New function.
3263         (class ui_out) <message>: Add comment.
3264         <vmessage, call_do_message>: New methods.
3265         <do_message>: Add style parameter.
3266         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3267         methods.
3268         (ui_out::message): Rewrite.
3269         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3270         parameter.
3271         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3272         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3273         gdb_extensions parameter.
3274         (class format_piece): Add parameter to constructor.
3275         (n_int_args): New field.
3276         * gdbsupport/format.c (format_pieces::format_pieces): Add
3277         gdb_extensions parameter.  Handle '*'.
3278         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3279         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3280         vfprintf_styled_no_gdbfmt.
3281         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3282         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3283         unfiltered output.
3284         * ui-style.h (struct ui_file_style) <ptr>: New method.
3285
3286 2019-10-01  Tom Tromey  <[email protected]>
3287
3288         * unittests/format_pieces-selftests.c: Update.  Add final format.
3289         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3290         empty literal pieces.
3291
3292 2019-10-01  Tom Tromey  <[email protected]>
3293
3294         * ui-out.h (enum class ui_out_style_kind): Remove.
3295         (class ui_out) <field_string, field_stsream, do_field_string>:
3296         Change type of "style".
3297         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3298         (ui_out::field_string): Update.
3299         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3300         of "style".
3301         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3302         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3303         * stack.c (print_frame_arg, print_frame_info, print_frame):
3304         Update.
3305         * source.c (print_source_lines_base): Update.
3306         * solib.c (info_sharedlibrary_command): Update.
3307         * skip.c (info_skip_command): Update.
3308         * record-btrace.c (btrace_call_history_src_line)
3309         (btrace_call_history): Update.
3310         * python/py-framefilter.c (py_print_frame): Update.
3311         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3312         "style".
3313         * mi/mi-out.c (mi_ui_out::do_table_header)
3314         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3315         (mi_ui_out::do_field_string): Update.
3316         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3317         Update.
3318         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3319         "style".
3320         * cli-out.c (cli_ui_out::do_table_header)
3321         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3322         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3323         (cli_ui_out::do_field_fmt): Update.
3324         * breakpoint.c (print_breakpoint_location): Update.
3325         (update_static_tracepoint): Update.
3326
3327 2019-10-01  Philippe Waroquiers  <[email protected]>
3328
3329         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3330         conversion of gdb_datadir.
3331         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3332         remove not needed c_str ().
3333
3334 2019-09-30  Ali Tamur <[email protected]>
3335
3336         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3337         (dwarf2_string_attr): Likewise.
3338
3339 2019-09-30  Ali Tamur <[email protected]>
3340
3341         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3342         (process_full_type_unit): Likewise.
3343         (dump_die_shallow): Likewise.
3344         (cu_debug_loc_section): Likewise.
3345
3346 2019-09-28  Christian Biesinger  <[email protected]>
3347
3348         * minsyms.c (compare_minimal_symbols): Rename to...
3349         (minimal_symbol_is_less_than): ...this, and adjust to STL
3350         conventions (return bool, take arguments as references)
3351         (minimal_symbol_reader::install): Call std::sort instead
3352         of qsort.
3353
3354 2019-09-29  Christian Biesinger  <[email protected]>
3355
3356         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3357         hash and why.
3358         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3359         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3360
3361 2019-09-30  Simon Marchi  <[email protected]>
3362
3363         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3364         * psympriv.h (add_psymbol_to_list): Move comment here and update
3365         it.
3366
3367 2019-09-29  Tom de Vries  <[email protected]>
3368
3369         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3370         Use $tmpdir/$(basename "$output_file").dwz instead of
3371         "${output_file}.dwz".
3372
3373 2019-09-28  Simon Marchi  <[email protected]>
3374
3375         PR gdb/25045
3376         * hppa-linux-nat.c: Include gdbarch.h.
3377
3378 2019-09-26  Christian Biesinger  <[email protected]>
3379
3380         * blockframe.c (find_pc_partial_function): Change return type to bool.
3381         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3382         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3383         (stub_gnu_ifunc_resolve_name): Likewise.
3384         * symtab.c (compare_filenames_for_search): Likewise.
3385         (compare_glob_filenames_for_search): Likewise.
3386         (matching_obj_sections): Likewise.
3387         (symbol_matches_domain): Likewise.
3388         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3389         (find_line_pc): Change return type to bool.
3390         (find_line_pc_range): Likewise.
3391         (producer_is_realview): Likewise.
3392         * symtab.h (symbol_matches_domain): Likewise.
3393         (find_pc_partial_function): Likewise.
3394         (find_pc_line_pc_range): Likewise.
3395         (in_gnu_ifunc_stub): Likewise.
3396         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3397         (find_line_pc): Likewise.
3398         (find_line_pc_range): Likewise.
3399         (matching_obj_sections): Likewise.
3400         (find_line_symtab): Change out parameter to bool.
3401         (producer_is_realview): Change return type to bool.
3402         (compare_filenames_for_search): Likewise.
3403         (compare_glob_filenames_for_search): Likewise.
3404
3405 2019-09-26  Tom Tromey  <[email protected]>
3406
3407         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3408         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3409         * gdb_usleep.h: Remove.
3410         * gdb_usleep.c: Remove.
3411         * utils.c: Don't include gdb_usleep.h.
3412
3413 2019-09-26  Tom Tromey  <[email protected]>
3414
3415         * python/py-type.c (type_to_type_object): Call check_typedef
3416         for stub types.
3417
3418 2019-09-26  Tom Tromey  <[email protected]>
3419
3420         * utils.h (initialize_utils): Don't declare.
3421         * top.c (gdb_init): Don't call initialize_utils.
3422         * utils.c (initialize_utils): Remove.  Move contents...
3423         (_initialize_utils): ... here.
3424
3425 2019-09-25  Tom Tromey  <[email protected]>
3426
3427         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3428         * utils.h (make_hex_string): Don't declare.
3429         * utils.c (make_hex_string): Remove.
3430
3431 2019-09-24  Tom de Vries  <[email protected]>
3432
3433         PR gdb/23815
3434         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3435         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3436
3437 2019-09-23  Dimitar Dimitrov  <[email protected]>
3438
3439         * NEWS: Mention new simulator port for PRU.
3440
3441 2019-09-23  Christian Biesinger  <[email protected]>
3442
3443         * ada-exp.y (write_object_remaining): Update.
3444         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3445         and eliminate the static buffer.
3446         (ada_decode_symbol): Update.
3447         (ada_la_decode): Update.
3448         (ada_sniff_from_mangled_name): Update.
3449         (is_valid_name_for_wild_match): Update.
3450         (ada_lookup_name_info::matches): Update and simplify.
3451         (name_matches_regex): Update.
3452         (ada_add_global_exceptions): Update.
3453         * ada-lang.h (ada_decode): Update signature.
3454         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3455         * dwarf-index-write.c (debug_names::insert): Update.
3456
3457 2019-09-21  Simon Marchi  <[email protected]>
3458
3459         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3460         formatting.
3461
3462 2019-09-21  Simon Marchi  <[email protected]>
3463
3464         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3465         Change "nonzero" to "true" in documentation.
3466
3467 2019-09-20  Christian Biesinger  <[email protected]>
3468
3469         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3470         (_initialize_darwin_solib): Don't set
3471         darwin_so_ops.lookup_lib_global_symbol.
3472         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3473         set_gdbarch_iterate_over_objfiles_in_search_order.
3474         (elf_lookup_lib_symbol): Rename to...
3475         (svr4_iterate_over_objfiles_in_search_order): this, and update
3476         to iterate semantics.
3477         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3478         * solib.c (solib_global_lookup): Remove.
3479         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3480         (solib_global_lookup): Remove.
3481         * symtab.c (lookup_global_or_static_symbol): Remove call to
3482         solib_global_lookup.
3483
3484 2019-09-20  Joel Brobecker  <[email protected]>
3485
3486         * NEWS: Move entries about default MI version now being
3487         version 3, and about the GDB/MI fix for multi-location
3488         breakpoints to the "since GDB 8.3" section.
3489
3490 2019-09-20  Joel Brobecker  <[email protected]>
3491
3492         GDB 8.3.1 released.
3493
3494 2019-09-20  Ulrich Weigand  <[email protected]>
3495
3496         * NEWS: Mention that Cell/B.E. debugging support was removed.
3497         * MAINTAINERS: Remove spu target.
3498
3499         * config/djgpp/fnchange.lst: Remove entries for removed files.
3500
3501         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3502         spu-multiarch.o, and spu-tdep.o.
3503         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3504         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3505         spu-multiarch.c, and spu-tdep.c.
3506         * spu-linux-nat.c: Remove file.
3507         * spu-multiarch.c: Remove file.
3508         * spu-tdep.c: Remove file.
3509         * spu-tdep.h: Remove file.
3510         * solib-spu.c: Remove file.
3511         * solib-spu.h: Remove file.
3512
3513         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3514         * configure.nat (spu-linux): Remove.
3515         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3516         solib-multiarch.o from gdb_target_obs.
3517         (spu*-*-*): Remove.
3518
3519         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3520         feature flag.
3521         (ppc_linux_no_features): Update.
3522         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3523         Cell/B.E. support.
3524         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3525         (tdesc_powerpc_cell64l): Likewise.
3526         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3527         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3528         Cell/B.E. support.
3529         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3530         Do not include "features/rs6000/powerpc-cell32l.c" or
3531         "features/rs6000/powerpc-cell64l.c".
3532         (ppc_linux_spu_section): Remove.
3533         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3534         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3535         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3536         (ppc_linux_spe_context_lookup): Remove.
3537         (ppc_linux_spe_context_inferior_created): Remove.
3538         (ppc_linux_spe_context_solib_loaded): Remove.
3539         (ppc_linux_spe_context_solib_unloaded): Remove.
3540         (ppc_linux_spe_context): Remove.
3541         (struct ppu2spu_cache): Remove.
3542         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3543         (struct ppu2spu_data): Remove.
3544         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3545         ppu2spu_unwind): Remove.
3546         (ppc_linux_init_abi): Remove Cell/B.E. support.
3547         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3548
3549         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3550         (rs6000/powerpc-cell64l-expedite): Likewise
3551         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3552         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3553         rs6000/powerpc-cell64l.xml.
3554         * features/rs6000/powerpc-cell32l.xml: Remove.
3555         * features/rs6000/powerpc-cell64l.xml: Likewise.
3556         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3557         * features/rs6000/powerpc-cell64l.c: Likewise.
3558         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3559         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3560         * regformats/reg-spu.dat: Remove.
3561
3562         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3563         * corelow.c (struct spuid_list): Remove.
3564         (add_to_spuid_list): Remove.
3565         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3566         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3567         (remote_protocol_features): Remove associated entries.
3568         (_initialize_remote): No longer initialize them.
3569         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3570         * linux-nat.c (SPUFS_MAGIC): Remove.
3571         (linux_proc_xfer_spu): Remove.
3572         (spu_enumerate_spu_ids): Remove.
3573         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3574         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3575         (linux_make_corefile_notes): No longer call it.
3576
3577         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3578         (cooked_write_test): Likewise.
3579
3580 2019-09-20  Tom Tromey  <[email protected]>
3581
3582         * NEWS: Mention case-sensitivity of TUI commands.
3583         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3584         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3585         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3586
3587 2019-09-20  Tom Tromey  <[email protected]>
3588
3589         * tui/tui-source.c (tui_source_window::set_contents): Use
3590         make_unique_xstrdup.
3591         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3592         make_unique_xstrdup.
3593
3594 2019-09-20  Tom Tromey  <[email protected]>
3595
3596         * tui/tui-data.c: Remove separator comments.
3597         * tui/tui-layout.c: Remove separator comments.
3598         * tui/tui-win.c: Remove separator comments.
3599         * tui/tui-wingeneral.c: Remove separator comments.
3600
3601 2019-09-20  Tom Tromey  <[email protected]>
3602
3603         * tui/tui.h (strcat_to_buf): Don't declare.
3604         * tui/tui.c (strcat_to_buf): Remove.
3605
3606 2019-09-20  Tom Tromey  <[email protected]>
3607
3608         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3609         from "fullname".
3610         * tui/tui-source.c (tui_source_window::set_contents)
3611         (tui_source_window::location_matches_p)
3612         (tui_source_window::maybe_update): Update.
3613
3614 2019-09-20  Tom Tromey  <[email protected]>
3615
3616         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3617         Update.
3618         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3619         prefix.
3620         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3621         (tui_data_window::line_from_reg_element_no)
3622         (tui_data_window::first_reg_element_no_inline)
3623         (tui_data_window::show_registers)
3624         (tui_data_window::show_register_group)
3625         (tui_data_window::display_registers_from)
3626         (tui_data_window::display_registers_from_line)
3627         (tui_data_window::first_data_item_displayed)
3628         (tui_data_window::delete_data_content_windows)
3629         (tui_data_window::erase_data_content)
3630         (tui_data_window::do_scroll_vertical)
3631         (tui_data_window::refresh_window)
3632         (tui_data_window::check_register_values): Update.
3633
3634 2019-09-20  Tom Tromey  <[email protected]>
3635
3636         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3637         (struct tui_locator_window) <full_name, proc_name>: Now
3638         std::string.
3639         * tui/tui-stack.c (tui_locator_window::make_status_line)
3640         (tui_locator_window::set_locator_fullname)
3641         (tui_locator_window::set_locator_info): Update.
3642         * tui/tui-source.c (tui_source_window::set_contents)
3643         (tui_source_window::showing_source_p): Update.
3644
3645 2019-09-20  Tom Tromey  <[email protected]>
3646
3647         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3648         Don't call tui_locator_win_info_ptr.
3649
3650 2019-09-20  Tom Tromey  <[email protected]>
3651
3652         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3653
3654 2019-09-20  Tom Tromey  <[email protected]>
3655
3656         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3657         height for locator.
3658         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3659         * tui/tui-layout.c (show_source_disasm_command, show_data)
3660         (show_source_or_disasm_and_command): Use 1 as height for locator.
3661
3662 2019-09-20  Tom Tromey  <[email protected]>
3663
3664         * tui/tui.c (tui_enable): Update.
3665         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3666         Update.
3667         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3668         Update.
3669         * tui/tui-data.c (win_resized): Now bool.
3670         (tui_win_resized): Return bool.
3671         (tui_set_win_resized_to): Accept a bool.
3672
3673 2019-09-20  Tom Tromey  <[email protected]>
3674
3675         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3676         Change type of "refresh_values_only".
3677         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3678         type of "refresh_values_only".
3679
3680 2019-09-20  Tom Tromey  <[email protected]>
3681
3682         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3683         std::string.
3684         (tui_disassemble): Add "pos" parameter.
3685         (tui_disasm_window::set_contents): Simplify.
3686
3687 2019-09-20  Tom Tromey  <[email protected]>
3688
3689         * tui/tui-winsource.h (struct tui_source_window_base)
3690         <show_source_content>: Now private.
3691         * tui/tui-winsource.c
3692         (tui_source_window_base::show_source_content): Don't handle empty
3693         content case.
3694
3695 2019-09-20  Tom Tromey  <[email protected]>
3696
3697         * tui/tui-layout.c (show_source_disasm_command)
3698         (show_source_or_disasm_and_command): Don't call
3699         show_source_content.
3700
3701 2019-09-20  Tom Tromey  <[email protected]>
3702
3703         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3704         Declare.
3705         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3706         from tui_make_status_line.
3707         (tui_locator_window::rerender): Update.
3708
3709 2019-09-20  Tom Tromey  <[email protected]>
3710
3711         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3712         (tui_locator_window::rerender): Update.
3713
3714 2019-09-20  Tom Tromey  <[email protected]>
3715
3716         * tui/tui-winsource.h (struct tui_source_window_base)
3717         <~tui_source_window_base>: Don't declare.
3718         <fullname>: Remove.
3719         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3720         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3721         member.
3722         * tui/tui-source.c (tui_source_window::set_contents): Update.
3723         (tui_source_window::location_matches_p)
3724         (tui_source_window::maybe_update): Update.
3725
3726 2019-09-20  Tom Tromey  <[email protected]>
3727
3728         * tui/tui-winsource.h (~tui_source_element): Remove.
3729         (tui_source_element): Update.
3730         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3731         * tui/tui-winsource.c (tui_show_source_line): Update.
3732         * tui/tui-source.c (tui_source_window::set_contents): Update.
3733         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3734
3735 2019-09-20  Tom Tromey  <[email protected]>
3736
3737         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3738         declare.
3739         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3740         tui_clear_source_windows_detail.
3741         * tui/tui-winsource.h (struct tui_source_window_base)
3742         <clear_detail>: Don't declare.
3743         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3744         Remove.
3745         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3746
3747 2019-09-20  Tom Tromey  <[email protected]>
3748
3749         PR ada/24919:
3750         * block.c (contained_in): Fix final return value.
3751
3752 2019-09-20  Alan Modra  <[email protected]>
3753
3754         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3755         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3756         (read_indirect_string_from_dwz): Use bfd accessor.
3757         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3758         * machoread.c (macho_symfile_read_all_oso): Likewise.
3759         * solib.c (solib_bfd_open): Likewise.
3760
3761 2019-09-19  Christian Biesinger  <[email protected]>
3762
3763         * eval.c: Move declaration of overload_resolution to...
3764         * value.h: ...here.
3765
3766 2019-09-19  Christian Biesinger  <[email protected]>
3767
3768         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3769         * arm-linux-tdep.c: Likewise.
3770         * arm-nbsd-nat.c: Likewise.
3771         * arm-tdep.h: Declare arm_apcs_32.
3772         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3773
3774 2019-09-19  Christian Biesinger  <[email protected]>
3775
3776         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3777         * dwarf2read.h: Declare dwarf_always_disassemble.
3778
3779 2019-09-19  Tom de Vries  <[email protected]>
3780
3781         PR gdb/25009
3782         * source-cache.c (source_cache::ensure): Catch exception thrown during
3783         construction of the highlighter.
3784
3785 2019-09-18  Alan Modra  <[email protected]>
3786
3787         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3788         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3789         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3790         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3791         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3792         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3793         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3794         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3795         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3796         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3797         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3798         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3799         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3800         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3801         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3802         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3803         * mi/mi-interp.c: Update throughout for bfd section macro and
3804         function changes.
3805         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3806         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3807
3808 2019-09-18  Tom Tromey  <[email protected]>
3809
3810         * NEWS: Add entry.
3811         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3812         call rl_initialize.
3813         (tui_enable): Do not call rl_initialize.
3814
3815 2019-09-18  Christian Groessler  <[email protected]>
3816
3817         * alpha-linux-nat.c: Include gdbarch.h.
3818
3819 2019-09-18  Simon Marchi  <[email protected]>
3820
3821         * ui-file.c: Include cli/cli-style.h.
3822         (term_cli_styling): Remove cli_styling declaration.
3823
3824 2019-09-18  Alan Modra  <[email protected]>
3825
3826         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3827         to bfd_asymbol_section.
3828
3829 2019-09-18  Alan Modra  <[email protected]>
3830
3831         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3832         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3833         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3834
3835 2019-09-18  Alan Modra  <[email protected]>
3836
3837         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3838         * spu-linux-nat.c (spu_bfd_open): Likewise.
3839
3840 2019-09-18  Christian Biesinger  <[email protected]>
3841
3842         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3843         to bool to match definition in dwarf2read.c.
3844
3845 2019-09-17  Christian Biesinger  <[email protected]>
3846
3847         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3848         (print_signatures): Likewise.
3849         (trust_pad_over_xvs): Likewise.
3850         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3851         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3852         * arm-linux-nat.c (arm_apcs_32): Likewise.
3853         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3854         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3855         * arm-tdep.c (arm_debug): Likewise.
3856         (arm_apcs_32): Likewise.
3857         * auto-load.c (debug_auto_load): Likewise.
3858         (auto_load_gdb_scripts): Likewise.
3859         (global_auto_load): Likewise.
3860         (auto_load_local_gdbinit): Likewise.
3861         (auto_load_local_gdbinit_loaded): Likewise.
3862         * auto-load.h (global_auto_load): Likewise.
3863         (auto_load_local_gdbinit): Likewise.
3864         (auto_load_local_gdbinit_loaded): Likewise.
3865         * breakpoint.c (disconnected_dprintf): Likewise.
3866         (breakpoint_proceeded): Likewise.
3867         (automatic_hardware_breakpoints): Likewise.
3868         (always_inserted_mode): Likewise.
3869         (target_exact_watchpoints): Likewise.
3870         (_initialize_breakpoint): Update.
3871         * breakpoint.h (target_exact_watchpoints): Change to bool.
3872         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3873         * cli/cli-cmds.c (trace_commands): Likewise.
3874         * cli/cli-cmds.h (trace_commands): Likewise.
3875         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3876         to bool*.
3877         * cli/cli-logging.c (logging_overwrite): Change to bool.
3878         (logging_redirect): Likewise.
3879         (debug_redirect): Likewise.
3880         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3881         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3882         to bool.
3883         <boolean_option_def>: Update.
3884         (struct flag_option_def): Change default type of Context to bool
3885         from int.
3886         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3887         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3888         (get_setshow_command_value_string): Likewise.
3889         * cli/cli-style.c (cli_styling): Change to bool.
3890         (source_styling): Likewise.
3891         * cli/cli-style.h (source_styling): Likewise.
3892         (cli_styling): Likewise.
3893         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3894         to bool.
3895         * command.h (var_types): Update comment.
3896         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3897         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3898         bool.
3899         (debug_compile_cplus_scopes): Likewise.
3900         * compile/compile-internal.h (compile_debug): Likewise.
3901         * compile/compile.c (compile_debug): Likewise.
3902         (struct compile_options) <raw>: Likewise.
3903         * cp-support.c (catch_demangler_crashes): Likewise.
3904         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3905         (usr_cmd_cris_dwarf2_cfi): Likewise.
3906         * csky-tdep.c (csky_debug): Likewise.
3907         * darwin-nat.c (enable_mach_exceptions): Likewise.
3908         * dcache.c (dcache_enabled_p): Likewise.
3909         * defs.h (info_verbose): Likewise.
3910         * demangle.c (demangle): Likewise.
3911         (asm_demangle): Likewise.
3912         * dwarf-index-cache.c (debug_index_cache): Likewise.
3913         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3914         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3915         * dwarf2read.c (check_physname): Likewise.
3916         (use_deprecated_index_sections): Likewise.
3917         (dwarf_always_disassemble): Likewise.
3918         * eval.c (overload_resolution): Likewise.
3919         * event-top.c (set_editing_cmd_var): Likewise.
3920         (exec_done_display_p): Likewise.
3921         * event-top.h (set_editing_cmd_var): Likewise.
3922         (exec_done_display_p): Likewise.
3923         * exec.c (write_files): Likewise.
3924         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3925         (debug_fbsd_nat): Likewise.
3926         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3927         Likewise.
3928         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3929         <backtrace_past_entry> Likewise.
3930         * gdb-demangle.h (demangle): Likewise.
3931         (asm_demangle): Likewise.
3932         * gdb_bfd.c (bfd_sharing): Likewise.
3933         * gdbcore.h (write_files): Likewise.
3934         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3935         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3936         * gdbthread.h (print_thread_events): Likewise.
3937         * gdbtypes.c (opaque_type_resolution): Likewise.
3938         (strict_type_checking): Likewise.
3939         * gnu-nat.c (gnu_debug_flag): Likewise.
3940         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3941         * guile/scm-param.c (pascm_variable): Add boolval.
3942         (add_setshow_generic): Update.
3943         (pascm_param_value): Update.
3944         (pascm_set_param_value_x): Update.
3945         * hppa-tdep.c (hppa_debug): Change to bool..
3946         * infcall.c (may_call_functions_p): Likewise.
3947         (coerce_float_to_double_p): Likewise.
3948         (unwind_on_signal_p): Likewise.
3949         (unwind_on_terminating_exception_p): Likewise.
3950         * infcmd.c (startup_with_shell): Likewise.
3951         * inferior.c (print_inferior_events): Likewise.
3952         * inferior.h (startup_with_shell): Likewise.
3953         (print_inferior_events): Likewise.
3954         * infrun.c (step_stop_if_no_debug): Likewise.
3955         (detach_fork): Likewise.
3956         (debug_displaced): Likewise.
3957         (disable_randomization): Likewise.
3958         (non_stop): Likewise.
3959         (non_stop_1): Likewise.
3960         (observer_mode): Likewise.
3961         (observer_mode_1): Likewise.
3962         (set_observer_mode): Update.
3963         (sched_multi): Change to bool.
3964         * infrun.h (debug_displaced): Likewise.
3965         (sched_multi): Likewise.
3966         (step_stop_if_no_debug): Likewise.
3967         (non_stop): Likewise.
3968         (disable_randomization): Likewise.
3969         * linux-tdep.c (use_coredump_filter): Likewise.
3970         (dump_excluded_mappings): Likewise.
3971         * linux-thread-db.c (auto_load_thread_db): Likewise.
3972         (check_thread_db_on_load): Likewise.
3973         * main.c (captured_main_1): Update.
3974         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3975         xx2_opt, boolean_opt>: Change to bool.
3976         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3977         * maint.c (maintenance_profile_p): Likewise.
3978         (per_command_time): Likewise.
3979         (per_command_space): Likewise.
3980         (per_command_symtab): Likewise.
3981         * memattr.c (inaccessible_by_default): Likewise.
3982         * mi/mi-main.c (mi_async): Likewise.
3983         (mi_async_1): Likewise.
3984         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3985         * nat/fork-inferior.h (startup_with_shell): Likewise.
3986         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3987         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3988         * nios2-tdep.c (nios2_debug): Likewise.
3989         * or1k-tdep.c (or1k_debug): Likewise.
3990         * parse.c (parser_debug): Likewise.
3991         * parser-defs.h (parser_debug): Likewise.
3992         * printcmd.c (print_symbol_filename): Likewise.
3993         * proc-api.c (procfs_trace): Likewise.
3994         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3995         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3996         (set_parameter_value): Update.
3997         (add_setshow_generic): Update.
3998         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3999         to bool*.
4000         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4001         int*.
4002         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4003         * record-btrace.c (record_btrace_target::store_registers): Update.
4004         * record-full.c (record_full_memory_query): Change to bool.
4005         (record_full_stop_at_limit): Likewise.
4006         * record-full.h (record_full_memory_query): Likewise.
4007         * remote-notif.c (notif_debug): Likewise.
4008         * remote-notif.h (notif_debug): Likewise.
4009         * remote.c (use_range_stepping): Likewise.
4010         (interrupt_on_connect): Likewise.
4011         (remote_break): Likewise.
4012         * ser-tcp.c (tcp_auto_retry): Likewise.
4013         * ser-unix.c (serial_hwflow): Likewise.
4014         * skip.c (debug_skip): Likewise.
4015         * solib-aix.c (solib_aix_debug): Likewise.
4016         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4017         (spu_auto_flush_cache_p): Likewise.
4018         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4019         Likewise.
4020         (struct info_print_options) <quiet>: Likewise.
4021         * symfile-debug.c (debug_symfile): Likewise.
4022         * symfile.c (auto_solib_add): Likewise.
4023         (separate_debug_file_debug): Likewise.
4024         * symfile.h (auto_solib_add): Likewise.
4025         (separate_debug_file_debug): Likewise.
4026         * symtab.c (basenames_may_differ): Likewise.
4027         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4028         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4029         (struct info_types_options) <quiet>: Likewise.
4030         * symtab.h (demangle): Likewise.
4031         (basenames_may_differ): Likewise.
4032         * target-dcache.c (stack_cache_enabled_1): Likewise.
4033         (code_cache_enabled_1): Likewise.
4034         * target.c (trust_readonly): Likewise.
4035         (may_write_registers): Likewise.
4036         (may_write_memory): Likewise.
4037         (may_insert_breakpoints): Likewise.
4038         (may_insert_tracepoints): Likewise.
4039         (may_insert_fast_tracepoints): Likewise.
4040         (may_stop): Likewise.
4041         (auto_connect_native_target): Likewise.
4042         (target_stop_and_wait): Update.
4043         (target_async_permitted): Change to bool.
4044         (target_async_permitted_1): Likewise.
4045         (may_write_registers_1): Likewise.
4046         (may_write_memory_1): Likewise.
4047         (may_insert_breakpoints_1): Likewise.
4048         (may_insert_tracepoints_1): Likewise.
4049         (may_insert_fast_tracepoints_1): Likewise.
4050         (may_stop_1): Likewise.
4051         * target.h (target_async_permitted): Likewise.
4052         (may_write_registers): Likewise.
4053         (may_write_memory): Likewise.
4054         (may_insert_breakpoints): Likewise.
4055         (may_insert_tracepoints): Likewise.
4056         (may_insert_fast_tracepoints): Likewise.
4057         (may_stop): Likewise.
4058         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4059         (make_thread_apply_all_options_def_group): Change argument from int*
4060         to bool*.
4061         (thread_apply_all_command): Update.
4062         (print_thread_events): Change to bool.
4063         * top.c (confirm): Likewise.
4064         (command_editing_p): Likewise.
4065         (history_expansion_p): Likewise.
4066         (write_history_p): Likewise.
4067         (info_verbose): Likewise.
4068         * top.h (confirm): Likewise.
4069         (history_expansion_p): Likewise.
4070         * tracepoint.c (disconnected_tracing): Likewise.
4071         (circular_trace_buffer): Likewise.
4072         * typeprint.c (print_methods): Likewise.
4073         (print_typedefs): Likewise.
4074         * utils.c (debug_timestamp): Likewise.
4075         (sevenbit_strings): Likewise.
4076         (pagination_enabled): Likewise.
4077         * utils.h (sevenbit_strings): Likewise.
4078         (pagination_enabled): Likewise.
4079         * valops.c (overload_resolution): Likewise.
4080         * valprint.h (struct value_print_options) <prettyformat_arrays,
4081         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4082         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4083         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4084         Likewise.
4085         * windows-nat.c (new_console): Likewise.
4086         (cygwin_exceptions): Likewise.
4087         (new_group): Likewise.
4088         (debug_exec): Likewise.
4089         (debug_events): Likewise.
4090         (debug_memory): Likewise.
4091         (debug_exceptions): Likewise.
4092         (useshell): Likewise.
4093         * windows-tdep.c (maint_display_all_tib): Likewise.
4094         * xml-support.c (debug_xml): Likewise.
4095
4096 2019-09-17  Mike Gulick  <[email protected]>
4097
4098         * source.c (prepare_path_for_appending): New function.
4099         (openp): Make use of new function.
4100         (find_and_open_source): Search for the compilation directory and
4101         source file as a relative path beneath the directory search path.
4102
4103 2019-09-17  Andrew Burgess  <[email protected]>
4104
4105         * source-cache.c (source_cache::get_line_charpos): Catch
4106         exceptions and return false, this matches the behaviour documented
4107         in the header file.
4108
4109 2019-09-17  Joel Brobecker  <[email protected]>
4110
4111         * ada-tasks.c (info_task): Remove quoting of the task's name.
4112
4113 2019-09-16  Christian Biesinger  <[email protected]>
4114
4115         * symfile.c (auto_solib_add): Replace comment with a reference
4116         to the header file.
4117
4118 2019-09-14  Christian Biesinger  <[email protected]>
4119
4120         * NEWS: Mention that gdb can now be compiled with Python 3
4121         on Windows.
4122
4123 2019-09-12  Andrew Burgess  <[email protected]>
4124
4125         * maint.c (maint_print_section_data::maint_print_section_data):
4126         Force use of 'float log10 (float)' by casting the argument to
4127         float.
4128
4129 2019-09-12  Andrew Burgess  <[email protected]>
4130
4131         * maint.c: Add 'cmath' include.
4132         (struct maint_print_section_data): New structure.
4133         (print_section_index): New function.
4134         (print_bfd_section_info): Add header comment, small whitespace
4135         cleanup, and update to call new print_section_index function.
4136         (print_objfile_section_info): Likewise.
4137         (maint_obj_section_from_bfd_section): New function.
4138         (print_bfd_section_info_maybe_relocated): New function.
4139         (maintenance_info_sections): Add header comment, always use
4140         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4141
4142 2019-09-12  Andrew Burgess  <[email protected]>
4143
4144         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4145         inner scope, add check that the objfile has psymtabs before
4146         checking psymtabs_addrmap.
4147         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4148
4149 2019-09-12  Philippe Waroquiers  <[email protected]>
4150
4151         * NEWS: Announce that Ada task names are now shown at more places,
4152         and between quotes (except in info task output).
4153         * gdb/ada-tasks.c (task_to_str): New function.
4154         (display_current_task_id): Call task_to_str.
4155         (task_command_1): Likewise.
4156         (print_ada_task_info): In non-mi mode, Properly align headers and data
4157         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4158
4159 2019-09-12  Rainer Orth  <[email protected]>
4160
4161         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4162         prstatus.pr_lwp.pr_info instead of making it up.
4163
4164 2019-09-11  Christian Biesinger  <[email protected]>
4165
4166         * auto-load.c (auto_load_expand_dir_vars): Update.
4167         * defs.h (gdb_datadir): Change to std::string.
4168         (python_libdir): Likewise.
4169         (relocate_gdb_directory): Change return type to std::string.
4170         * guile/guile.c (gdbscm_data_directory): Update.
4171         (initialize_scheme_side): Update.
4172         * jit.c (jit_reader_dir): Change to std::string.
4173         (jit_reader_load_command): Update.
4174         * main.c (gdb_datadir): Change to std::string.
4175         (python_libdir): Likewise.
4176         (set_gdb_data_directory): Update.
4177         (relocate_path): Change to return std::string.
4178         (relocate_gdb_directory): Change to return std::string.
4179         (relocate_gdbinit_path_maybe_in_datadir): Update.
4180         (captured_main_1): Update.
4181         * python/python.c (do_start_initialization): Update.
4182         * top.c (show_gdb_datadir): Update.
4183         * xml-syscall.c (xml_init_syscalls_info): Update.
4184         (init_syscalls_info): Update.
4185
4186 2019-09-11  Christian Biesinger  <[email protected]>
4187
4188         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4189         out of get_init_files.
4190         (get_init_files): Update.
4191
4192 2019-09-11  Christian Biesinger  <[email protected]>
4193
4194         * main.c (get_init_files): Change to use std::string.
4195         (captured_main_1): Update.
4196         (print_gdb_help): Update.
4197
4198 2019-09-11  Ali Tamur  <[email protected]>
4199
4200         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4201         implementation.
4202
4203 2019-09-11  Christian Biesinger  <[email protected]>
4204
4205         * dbxread.c (read_dbx_symtab): Update.
4206         * dwarf2read.c (load_partial_dies): Update.
4207         * mdebugread.c (parse_partial_symbols): Update.
4208         (handle_psymbol_enumerators): Update.
4209         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4210         * psymtab.c (add_psymbol_to_bcache): Likewise.
4211         (add_psymbol_to_list): Likewise.
4212         * symtab.c (symbol_set_names): Likewise.
4213         * symtab.h (symbol_set_names): Likewise.
4214         * xcoffread.c (scan_xcoff_symtab): Update.
4215
4216 2019-09-11  Tom Tromey  <[email protected]>
4217
4218         * symfile-mem.c (symbol_file_add_from_memory): Use
4219         bfd_set_filename.
4220         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4221         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4222
4223 2019-09-10  Tom Tromey  <[email protected]>
4224
4225         * dwarf-index-write.c (write_psymbols): Extend error message.
4226         (debug_names::insert): Add Ada code.
4227         (debug_names::write_psymbols): Remove Ada check.
4228         (debug_names) <m_string_obstack>: New member.
4229         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4230         (gdb_index_symbol_name_matcher::matches): Remove.
4231         (mapped_index_base::find_name_components_bounds): Add "lang"
4232         parameter.
4233         (mapped_index_base::build_name_components): Also split names
4234         according to Ada syntax.
4235         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4236         type of "match_callback".
4237         (check_match, check_find_bounds_finds)
4238         (dw2_expand_symtabs_matching): Update.
4239         (dw2_debug_names_iterator): Add new constructor.
4240         (dw2_debug_names_map_matching_symbols): New function.
4241         (dw2_debug_names_expand_symtabs_matching): Update.
4242         (dwarf2_debug_names_functions): Use
4243         dw2_debug_names_map_matching_symbols.
4244
4245 2019-09-10  Tom Tromey  <[email protected]>
4246
4247         * dwarf2read.c (dw2_get_file_names_reader): Add the
4248         CU's file name to the results.
4249
4250 2019-09-10  Tom Tromey  <[email protected]>
4251
4252         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4253         map_matching_symbols.  Update.
4254         * dwarf2read.c (dw2_map_matching_symbols): Update.
4255         * psymtab.c (match_partial_symbol): Change type; update.
4256         (psym_map_matching_symbols): Likewise.
4257         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4258         type; update.
4259         * symfile.h (struct quick_symbol_functions)
4260         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4261         Remove "match".
4262
4263 2019-09-10  Tom Tromey  <[email protected]>
4264
4265         * psymtab.c (map_block): Remove.
4266         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4267         * symtab.c (iterate_over_symbols_terminated): New function.
4268         * symtab.c (iterate_over_symbols_terminated): Declare.
4269
4270 2019-09-10  Tom Tromey  <[email protected]>
4271
4272         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4273         * language.h (struct language_defn) <la_iterate_over_symbols>:
4274         Return bool.
4275         * symtab.c (iterate_over_symbols): Return bool.
4276         * symtab.h (iterate_over_symbols): Return bool.
4277
4278 2019-09-10  Tom Tromey  <[email protected]>
4279
4280         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4281         (add_nonlocal_symbols): Update.
4282         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4283         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4284         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4285         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4286         Change type of "callback".  Remove "data".
4287
4288
4289 2019-09-09  Ali Tamur  <[email protected]>
4290
4291         * dwarf2read.c (comp_unit_head): Update comment.                     
4292         (dwarf2_dwo_name): New function declaration.                             
4293         (dwarf_unit_type_name): New function declaration.                        
4294         (read_comp_unit_head): Add support for new compilation units,            
4295         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.    
4296         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id         
4297         (currently named as "signature") in their header. Also clarify error     
4298         messages.                                                                
4299         (lookup_dwo_id): New function. Returns the dwo id of the given           
4300         compile unit.                                                            
4301         (lookup_dwo_unit): Use the new lookup_dwo_id function.                   
4302         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id 
4303         functions.                                                               
4304         (create_dwo_cu_reader): Use the added lookup_dwo_id function.            
4305         (dwarf2_dwo_name): Get the dwo name if present.                          
4306         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic   
4307         purposes.
4308
4309 2019-09-09  Tom Tromey  <[email protected]>
4310
4311         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4312
4313 2019-09-09  Philippe Waroquiers  <[email protected]>
4314
4315         * python/python.c (do_start_initialization): Make progname_copy static,
4316         to avoid a leak report.
4317
4318 2019-09-08  Tom Tromey  <[email protected]>
4319
4320         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4321
4322 2019-09-07  Simon Marchi  <[email protected]>
4323
4324         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4325         Change type to gdb::optional<block_enum>.
4326         (dw2_symtab_iter_init): Change block_index parameter type
4327         to gdb::optional<block_enum>.
4328         (dw2_lookup_symbol): Change block_index parameter
4329         type to block_enum.c
4330         (dw2_debug_names_lookup_symbol): Likewise.
4331         * psymtab.c (psym_lookup_symbol): Likewise.
4332         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4333         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4334         Likewise.
4335
4336 2019-09-06  Christian Biesinger  <[email protected]>
4337
4338         * defs.h (relocate_gdb_directory): Change int to bool in
4339         signature and rename flag to relocatable.
4340         * main.c (relocate_path): Likewise.
4341         (relocate_gdb_directory): Likewise.
4342
4343 2019-09-06  Alan Modra  <[email protected]>
4344
4345         * coffread.c (coff_symfile_read): Constify filename variable.
4346         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4347         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4348         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4349         * solib.c (reload_shared_libraries_1): Likewise.
4350         * symfile.c (reread_symbols): Likewise.
4351         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4352         * solib-darwin.c (darwin_bfd_open): Likewise.
4353         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4354
4355 2019-09-03  Andrew Burgess  <[email protected]>
4356
4357         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4358         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4359
4360 2019-09-03  Tom Tromey  <[email protected]>
4361
4362         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4363         types.
4364         (has_negatives): Unbias a range type bound.
4365         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4366         * gdbtypes.c (operator==): Handle new field.
4367         (create_range_type): Add "bias" parameter.
4368         (create_static_range_type, resolve_dynamic_range): Update.
4369         * gdbtypes.h (struct range_bounds) <bias>: New member.
4370         (create_range_type): Add bias parameter.
4371         * printcmd.c (print_scalar_formatted): Unbias range types.
4372         * value.c (unpack_long): Unbias range types.
4373         (pack_long): Bias range types.
4374
4375 2019-09-02  Alan Hayward  <[email protected]>
4376
4377         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4378         probe arguments.
4379
4380 2019-09-02  Alan Hayward  <[email protected]>
4381
4382         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4383         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4384         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4385         (compile_probe_arg): Likewise.
4386         * probe.h (get_argument_count): Likewise.
4387         * solib-svr4.c (solib_event_probe_action): Likewise.
4388         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4389
4390 2019-09-02  Alan Hayward  <[email protected]>
4391
4392         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4393         code to here...
4394         (svr4_create_solib_event_breakpoints): ...from here.
4395
4396 2019-08-30  Sergio Durigan Junior  <[email protected]>
4397
4398         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4399         suffix from warning message.
4400
4401 2019-08-30  Tom Tromey  <[email protected]>
4402
4403         * tui/tui-winsource.h (struct tui_source_window_base)
4404         <refresh_all>: Don't declare.
4405         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4406         Remove.
4407         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4408         tui_show_locator_content.
4409         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4410         declare.
4411         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4412         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4413         declare.
4414
4415 2019-08-30  Tom Tromey  <[email protected]>
4416
4417         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4418
4419 2019-08-30  Tom Tromey  <[email protected]>
4420
4421         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4422         Remove unnecessary forward declarations.
4423
4424 2019-08-30  Tom Tromey  <[email protected]>
4425
4426         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4427         rerender.
4428         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4429         tui_show_locator_content.
4430
4431 2019-08-30  Tom Tromey  <[email protected]>
4432
4433         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4434         (tui_locator_window::rerender): Rewrite using body of previous
4435         tui_show_locator_content.
4436
4437 2019-08-30  Tom Tromey  <[email protected]>
4438
4439         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4440         set_locator_fullname>: New methods.
4441         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4442         Rename from tui_set_locator_fullname.
4443         (tui_locator_window::set_locator_info): Rename from
4444         tui_set_locator_info.  Return bool.
4445         (tui_update_locator_fullname, tui_show_frame_info): Update.
4446
4447 2019-08-30  Tom Tromey  <[email protected]>
4448
4449         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4450
4451 2019-08-30  Tom Tromey  <[email protected]>
4452
4453         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4454         call touchwin.
4455
4456 2019-08-30  Tom Tromey  <[email protected]>
4457
4458         * tui/tui-wingeneral.c (box_win): Assume win_info and
4459         win_info->handle cannot be NULL.
4460
4461 2019-08-30  Tom Tromey  <[email protected]>
4462
4463         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4464         refresh_window>: Declare.
4465         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4466         resize.
4467         (tui_data_item_window::rerender): Rename from
4468         tui_display_register.
4469         (tui_data_item_window::refresh_window): New method.
4470         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4471         no-op.
4472
4473 2019-08-30  Tom Tromey  <[email protected]>
4474
4475         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4476         regs_column_count, current_group>: Move later.  Now private.
4477         <get_current_group>: New method.
4478         * tui/tui-regs.c (tui_reg_command): Update.
4479         * tui/tui-layout.c (tui_set_layout): Update.
4480
4481 2019-08-30  Tom Tromey  <[email protected]>
4482
4483         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4484         (tui_data_window::rerender): Don't call
4485         check_and_display_highlight_if_needed.
4486         (tui_data_window::refresh_all): Remove call to
4487         erase_data_content.
4488
4489 2019-08-30  Tom Tromey  <[email protected]>
4490
4491         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4492         (tui_data_window::display_registers_from)
4493         (tui_data_window::display_reg_element_at_line)
4494         (tui_data_window::display_registers_from_line): Remove checks of
4495         "empty".
4496
4497 2019-08-30  Tom Tromey  <[email protected]>
4498
4499         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4500         Don't declare.
4501         * tui/tui-regs.c (tui_data_window::show_registers): Call
4502         rerender.
4503         (tui_data_window::rerender): Rename from display_all_data.
4504         (tui_data_window::rerender): Remove old implementation.
4505
4506 2019-08-30  Tom Tromey  <[email protected]>
4507
4508         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4509         text.
4510         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4511
4512 2019-08-29  Bernhard Wodok  <[email protected]>
4513             Sergio Durigan Junior  <[email protected]>
4514
4515         PR win32/24284
4516         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4517
4518 2019-08-28  Andrew Burgess  <[email protected]>
4519
4520         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4521         when searching for types.
4522
4523 2019-08-28  Andrew Burgess  <[email protected]>
4524
4525         * f-lang.c (f_language_defn): Use f_print_typedef.
4526         * f-lang.h (f_print_typedef): Declare.
4527         * f-typeprint.c (f_print_typedef): Define.
4528
4529 2019-08-27  Christian Biesinger  <[email protected]>
4530
4531         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4532
4533 2019-08-27  Andrew Burgess  <[email protected]>
4534
4535         * cli/cli-utils.c (info_print_options_defs): Delete.
4536         (make_info_print_options_def_group): Delete.
4537         (extract_info_print_options): Delete.
4538         (info_print_command_completer): Delete.
4539         (info_print_args_help): Add extra parameter, and optionally
4540         include text about -n flag.
4541         * cli/cli-utils.h (struct info_print_options): Delete.
4542         (extract_info_print_options): Delete declaration.
4543         (info_print_command_completer): Delete declaration.
4544         (info_print_args_help): Add extra parameter, extend header
4545         comment.
4546         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4547         search_symbols.
4548         * stack.c (struct info_print_options): New type.
4549         (info_print_options_defs): New file scoped variable.
4550         (make_info_print_options_def_group): New static function.
4551         (info_print_command_completer): New static function.
4552         (info_locals_command): Update to use new local functions.
4553         (info_args_command): Likewise.
4554         (_initialize_stack): Add extra parameter to calls to
4555         info_print_args_help.
4556         * symtab.c (search_symbols): Add extra parameter, use this to
4557         possibly excluse non-debug symbols.
4558         (symtab_symbol_info): Add extra parameter, which is passed on to
4559         search_symbols.
4560         (struct info_print_options): New type.
4561         (info_print_options_defs): New file scoped variable.
4562         (make_info_print_options_def_group): New static function.
4563         (info_print_command_completer): New static function.
4564         (info_variables_command): Update to use local functions, and pass
4565         extra parameter through to symtab_symbol_info.
4566         (info_functions_command): Likewise.
4567         (info_types_command): Pass additional argument through to
4568         symtab_symbol_info.
4569         (rbreak_command): Pass extra argument to search_symbols.
4570         (_initialize_symtab): Add extra arguments for calls to
4571         info_print_args_help, and update help text for 'info variables',
4572         'whereis', and 'info functions' commands.
4573         * symtab.h (search_symbols): Add extra argument to declaration.
4574         * NEWS: Mention new flags.
4575
4576 2019-08-26  Christian Biesinger  <[email protected]>
4577
4578         * symtab.c (lookup_static_symbol): Call the new function (and move
4579         it down to be next to lookup_global_symbol).
4580         (struct global_sym_lookup_data): Add block_enum member and rename to...
4581         (struct global_or_static_sym_lookup_data): ...this.
4582         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4583         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4584         (lookup_symbol_global_or_static_iterator_cb): ...this.
4585         (lookup_global_or_static_symbol): New function.
4586         (lookup_global_symbol): Call new function.
4587
4588 2019-08-26  Tom de Vries  <[email protected]>
4589
4590         PR c++/24852
4591         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4592         when pc_probe.prob == NULL.
4593
4594 2019-08-25  Simon Marchi  <[email protected]>
4595
4596         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4597         variable symbol_linkage to symbol_linkage_.
4598
4599 2019-08-25  Simon Marchi  <[email protected]>
4600
4601         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4602         represent whether the symbol is static, dynamic, or we don't
4603         know.
4604
4605 2019-08-25  Yoshinori Sato <[email protected]>
4606
4607         * gdb/rx-tdep.c (rx_register_names): New.
4608         (rx_register_name): Delete.
4609         (rx_psw_type): Delete.
4610         (rx_fpsw_type): Delete.
4611         (rx_register_type): Delete.
4612         (rx_gdbarch_init): Convert target-descriptions.
4613         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4614         * gdb/features/Makefile: Add rx.xml.
4615         * gdb/features/rx.xml: New.
4616         * gdb/features/rx.c: Generated.
4617         * gdb/NEWS: Mention target description support.
4618
4619 2019-08-22  Christian Biesinger  <[email protected]>
4620
4621         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4622         *slot_ptr.
4623
4624 2019-08-23  Sergio Durigan Junior  <[email protected]>
4625
4626         * configure.ac: Don't check for 'dlfcn.h' (moved to
4627         gdbsupport/common.m4).
4628         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4629         'gdbsupport/'.
4630         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4631         * compile/compile-c-support.c: Include
4632         'gdbsupport/gdb-dlfcn.h'.
4633         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4634         * gdb-dlfcn.c: Move to...
4635         * gdbsupport/gdb-dlfcn.c: ... here.
4636         * gdb-dlfcn.h: Move to...
4637         * gdbsupport/gdb-dlfcn.h: ... here.
4638
4639 2019-08-23  Sandra Loosemore  <[email protected]>
4640
4641         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4642         the offset field signed.
4643
4644 2019-08-22  Christian Biesinger  <[email protected]>
4645
4646         * python/lib/gdb/__init__.py (_execute_file): New function.
4647         * python/python.c (python_run_simple_file): Call gdb._execute_file
4648         on Windows.
4649
4650 2019-08-22  Andrew Burgess  <[email protected]>
4651
4652         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4653         all uses as this was never set to anything but a zero value.
4654
4655 2019-08-21  Bogdan Harjoc  <[email protected]>
4656
4657         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4658
4659 2019-08-21  Christian Biesinger  <[email protected]>
4660
4661         * tui/tui-data.h (tui_gen_win_info): Add an =default
4662         move constructor, required by some GCC versions.
4663
4664 2019-08-21  Jinke Fan  <[email protected]>
4665
4666         * go32-nat.c (go32_sysinfo): Add hygon_p.
4667
4668 2019-08-20  Tom Tromey  <[email protected]>
4669
4670         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4671         line_from_reg_element_no, first_reg_element_no_inline,
4672         display_all_data, delete_data_content_windows,
4673         erase_data_content>: Now private.
4674
4675 2019-08-20  Tom Tromey  <[email protected]>
4676
4677         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4678         (tui_unhighlight_win, tui_highlight_win)
4679         (tui_win_info::make_window): Update.
4680         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4681
4682 2019-08-20  Tom Tromey  <[email protected]>
4683
4684         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4685         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4686         (MAX_PID_WIDTH): Move to tui-stack.c.
4687         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4688         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4689         (MAX_PID_WIDTH): Move from tui-data.h.
4690
4691 2019-08-20  Tom Tromey  <[email protected]>
4692
4693         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4694         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4695         (box_win): Update.
4696         (tui_gen_win_info::make_window): Rename from tui_make_window.
4697         (tui_win_info::make_window): New method.
4698         (tui_gen_win_info::make_visible): Update.
4699         * tui/tui-source.c (tui_source_window::set_contents): Update.
4700         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4701         (tui_data_window::display_registers_from): Update.
4702         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4703         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4704         Declare.
4705         <can_box>: Remove.
4706         <title>: Remove.
4707         (struct tui_win_info) <make_window>: Declare.
4708         <can_box>: Now virtual.
4709         <title>: New member.
4710         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4711         * tui/tui-command.c (tui_cmd_window::resize): Update.
4712
4713 2019-08-20  Tom Tromey  <[email protected]>
4714
4715         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4716         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4717         (tui_data_window::check_register_values): Update.
4718
4719 2019-08-20  Tom Tromey  <[email protected]>
4720
4721         * tui/tui-regs.h (struct tui_data_window): Use
4722         DISABLE_COPY_AND_ASSIGN.
4723         <regs_content>: Change type, removing unique_ptr.
4724         <tui_data_window>: Add move constructor.
4725         * tui/tui-regs.c (tui_data_window::show_registers)
4726         (tui_data_window::show_register_group)
4727         (tui_data_window::display_registers_from)
4728         (tui_data_window::display_registers_from)
4729         (tui_data_window::first_data_item_displayed)
4730         (tui_data_window::delete_data_content_windows)
4731         (tui_data_window::rerender, tui_data_window::refresh_window)
4732         (tui_data_window::check_register_values): Update.
4733
4734 2019-08-20  Tom Tromey  <[email protected]>
4735
4736         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4737         show_register_group>: Declare.
4738         (tui_show_register_group): Don't declare.
4739         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4740         tui_show_registers.
4741         (tui_data_window::show_register_group): Rename from
4742         tui_show_register_group.
4743         (tui_data_window::check_register_values, tui_reg_command):
4744         Update.
4745         * tui/tui-layout.c (tui_set_layout): Update.
4746
4747 2019-08-20  Tom Tromey  <[email protected]>
4748
4749         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4750         Declare.
4751         (tui_check_register_values): Don't declare.
4752         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4753         from tui_check_register_values.
4754         * tui/tui-hooks.c (tui_register_changed): Update.
4755
4756 2019-08-20  Tom Tromey  <[email protected]>
4757
4758         * tui/tui-regs.c (tui_reg_layout): Move later.
4759         (tui_show_registers): Don't enable TUI mode or change layout.
4760
4761 2019-08-20  Tom Tromey  <[email protected]>
4762
4763         * tui/tui-regs.h (struct tui_data_item_window)
4764         <~tui_data_item_window>: Remove.
4765         <content>: Now a unique_xmalloc_ptr.
4766         * tui/tui-regs.c (tui_register_format): Return a
4767         unique_xmalloc_ptr.
4768         (tui_get_register): Update.
4769         (~tui_data_item_window): Remove.
4770         (tui_data_window::display_registers_from, tui_display_register):
4771         Update.
4772         * tui/tui-io.h (tui_expand_tabs): Update.
4773         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4774         Remove "col" parameter.
4775
4776 2019-08-20  Tom Tromey  <[email protected]>
4777
4778         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4779         field.
4780         * tui/tui-regs.c (~tui_data_item_window): Update.
4781
4782 2019-08-20  Tom Tromey  <[email protected]>
4783
4784         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4785         earlier.
4786
4787 2019-08-20  Tom Tromey  <[email protected]>
4788
4789         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4790
4791 2019-08-20  Tom Tromey  <[email protected]>
4792
4793         * tui/tui-source.h (struct tui_source_window): Update.
4794         * tui/tui-regs.c (tui_show_registers): Update.
4795         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4796         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4797         (NO_REGS_STRING): Remove defines.
4798
4799 2019-08-20  Conrad Meyer  <[email protected]>
4800
4801         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4802         unnecessary thread walk if remote doesn't support the packet.
4803
4804 2019-08-19  Tom Tromey  <[email protected]>
4805
4806         * python/py-value.c (value_has_field): Fix indentation.
4807
4808 2019-08-19  Tom Tromey  <[email protected]>
4809
4810         * printcmd.c (do_one_display, info_display_command): Update.
4811         * block.h (contained_in): Return bool.  Add allow_nested
4812         parameter.
4813         * block.c (contained_in): Return bool.  Add allow_nested
4814         parameter.
4815
4816 2019-08-19  Tom Tromey  <[email protected]>
4817
4818         * configure: Rebuild.
4819         * configure.ac: Disallow the combination of -static-libstdc++ and
4820         source highlight.
4821         * source-cache.c (get_language_name): Handle rust.
4822         (source_cache::get_source_lines): Ignore highlighting exceptions.
4823
4824 2019-08-16  Tom Tromey  <[email protected]>
4825
4826         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4827         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4828         (struct tui_source_window_base) <make_visible, refresh_window,
4829         resize>: Remove methods.
4830         <execution_info>: Remove field.
4831         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4832         (tui_show_source_line, tui_source_window_base)
4833         (~tui_source_window_base): Update.
4834         (tui_source_window_base::resize)
4835         (tui_source_window_base::make_visible)
4836         (tui_source_window_base::refresh_window): Remove.
4837         (tui_source_window_base::update_exec_info): Update.
4838         * tui/tui-source.c (tui_source_window::set_contents): Update.
4839         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4840
4841 2019-08-16  Tom Tromey  <[email protected]>
4842
4843         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4844         deprecated_query_hook.
4845
4846 2019-08-16  Tom Tromey  <[email protected]>
4847
4848         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4849         (tui_update_source_windows_with_line): Update.
4850         * tui/tui-source.h (struct tui_source_window)
4851         <show_symtab_source>: Declare.
4852         (tui_show_symtab_source): Don't declare.
4853         * tui/tui-source.c (tui_show_symtab_source): Rename from
4854         tui_show_symtab_source.
4855
4856 2019-08-16  Tom Tromey  <[email protected]>
4857
4858         * tui/tui-winsource.h (struct tui_source_window_base)
4859         <set_contents>: Declare.
4860         * tui/tui-winsource.c
4861         (tui_source_window_base::update_source_window_as_is): Update.
4862         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4863         Declare.
4864         (tui_set_source_content): Don't declare.
4865         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4866         tui_set_source_content.
4867         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4868         Declare.
4869         (tui_set_disassem_content): Don't declare.
4870         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4871         tui_set_disassem_content.
4872
4873 2019-08-16  Tom Tromey  <[email protected]>
4874
4875         * tui/tui-winsource.h (struct tui_source_window_base)
4876         <update_breakpoint_info>: Declare.
4877         (tui_update_breakpoint_info): Don't declare.
4878         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4879         (tui_update_all_breakpoint_info): Update.
4880         (tui_source_window_base::update_breakpoint_info): Rename from
4881         tui_update_breakpoint_info.
4882         (tui_source_window_base::update_exec_info): Update.
4883
4884 2019-08-16  Tom Tromey  <[email protected]>
4885
4886         * tui/tui-winsource.h (struct tui_source_window_base)
4887         <update_source_window>: Declare.
4888         (tui_update_source_window): Don't declare.
4889         * tui/tui-winsource.c
4890         (tui_source_window_base::update_source_window): Rename from
4891         tui_update_source_window.
4892         (tui_source_window_base::rerender): Update.
4893         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4894         * tui/tui-disasm.c (tui_show_disassem)
4895         (tui_show_disassem_and_update_source)
4896         (tui_disasm_window::maybe_update): Update.
4897
4898 2019-08-16  Tom Tromey  <[email protected]>
4899
4900         * tui/tui-winsource.h (struct tui_source_window_base)
4901         <update_source_window_as_is>: Declare.
4902         (tui_update_source_window_as_is): Don't declare.
4903         * tui/tui-winsource.c (tui_update_source_window): Update
4904         (tui_source_window_base::update_source_window_as_is): Rename from
4905         tui_update_source_window_as_is.
4906         (tui_source_window_base::refill): Update.
4907         * tui/tui-source.c (tui_show_symtab_source): Update.
4908         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4909         Update.
4910
4911 2019-08-16  Tom Tromey  <[email protected]>
4912
4913         * tui/tui-winsource.h (tui_update_source_window)
4914         (tui_update_source_window_as_is): Remove "noerror" parameter.
4915         * tui/tui-winsource.c (tui_update_source_window)
4916         (tui_update_source_window_as_is): Remove "noerror" parameter.
4917         (tui_update_source_windows_with_addr)
4918         (tui_update_source_windows_with_line)
4919         (tui_source_window_base::rerender)
4920         (tui_source_window_base::refill): Update.
4921         * tui/tui-source.h (tui_set_source_content)
4922         (tui_show_symtab_source): Remove "noerror" parameter.
4923         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4924         parameter.
4925         (tui_show_symtab_source): Likewise.
4926         (tui_source_window::maybe_update): Update.
4927         * tui/tui-disasm.c (tui_show_disassem)
4928         (tui_show_disassem_and_update_source)
4929         (tui_disasm_window::do_scroll_vertical)
4930         (tui_disasm_window::maybe_update): Update.
4931
4932 2019-08-16  Tom Tromey  <[email protected]>
4933
4934         * tui/tui.c (tui_is_window_visible): Update.
4935         * tui/tui-wingeneral.c (tui_make_window)
4936         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4937         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4938         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4939         (tui_set_win_height_command, parse_scrolling_args): Update.
4940         * tui/tui-source.c (tui_source_window::style_changed): Update.
4941         * tui/tui-regs.c (tui_show_registers)
4942         (tui_data_window::first_data_item_displayed)
4943         (tui_data_window::delete_data_content_windows)
4944         (tui_check_register_values, tui_reg_command): Update.
4945         * tui/tui-disasm.c (tui_show_disassem): Update.
4946         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4947         method.
4948         <is_visible>: Remove field.
4949         * tui/tui-data.c (tui_next_win, tui_prev_win)
4950         (tui_delete_invisible_windows): Update.
4951
4952 2019-08-16  Tom Tromey  <[email protected]>
4953
4954         * tui/tui-winsource.h (struct tui_source_window_base)
4955         <m_has_locator>: Remove.
4956         * tui/tui-layout.c (show_source_disasm_command, show_data)
4957         (show_source_or_disasm_and_command): Update.
4958
4959 2019-08-16  Alan Hayward  <[email protected]>
4960
4961         * NEWS (Other MI changes): New subsection.
4962         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4963         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4964         * arch-utils.c (default_get_pc_address_flags): New function.
4965         * arch-utils.h (default_get_pc_address_flags): New declaration.
4966         * gdbarch.sh: Add get_pc_address_flags.
4967         * gdbarch.c: Regenerate.
4968         * gdbarch.h: Likewise.
4969         * stack.c (print_pc): New function.
4970         (print_frame_info) (print_frame): Call print_pc.
4971
4972 2019-08-16  Tom de Vries  <[email protected]>
4973
4974         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4975         print_objfile_section_info.
4976
4977 2019-08-15  Tom Tromey  <[email protected]>
4978
4979         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4980         calling update_cmdwin_start_line.
4981         * tui/tui-winsource.h (struct tui_source_window_base)
4982         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4983         <rerender>: Declare.
4984         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4985         Call rerender.
4986         (tui_source_window_base::set_new_height): Remove.
4987         (tui_source_window_base::rerender): Rename from
4988         do_make_visible_with_new_height.
4989         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4990         resize method.
4991         (tui_win_info::make_invisible_and_set_new_height)
4992         (tui_win_info::make_visible_with_new_height): Remove.
4993         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4994         Declare.
4995         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4996         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4997         do_make_visible_with_new_height>: Don't declare.
4998         <rerender>: Declare.
4999         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5000         set_new_height.
5001         (tui_data_window::do_make_visible_with_new_height): Remove.
5002         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5003         call tui_show_locator_content.
5004         (tui_gen_win_info::resize): Call rerender.
5005         (show_source_or_disasm_and_command): Don't call
5006         tui_show_locator_content.
5007         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5008         method.
5009         (struct tui_win_info) <rerender>: Declare.
5010         <set_new_height, make_invisible_and_set_new_height,
5011         make_visible_with_new_height>: Don't declare.
5012         * tui/tui-data.c (tui_win_list::rerender): New method.
5013         * tui/tui-command.h (struct tui_cmd_window)
5014         <do_make_visible_with_new_height>: Don't declare.
5015         * tui/tui-command.c
5016         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5017
5018 2019-08-15  Tom Tromey  <[email protected]>
5019
5020         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5021         * ada-lang.c (ada_enum_name): Likewise.
5022
5023 2019-08-15  Christian Biesinger  <[email protected]>
5024
5025         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5026         leading underscore.
5027         (GdbOutputErrorFile): Likewise.
5028         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5029         accordingly.
5030         (execute_unwinders): Rename to have a leading underscore.
5031         (auto_load_packages): Likewise.
5032         (global scope): Adjust call to auto_load_packages accordingly.
5033         (GdbSetPythonDirectory): Likewise.
5034         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5035         instead of execute_unwinders.
5036
5037 2019-08-15  Tom Tromey  <[email protected]>
5038
5039         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5040         (show_data): Don't change window visibility.
5041         (tui_gen_win_info::resize): Remove special case for command
5042         window.  Use wresize, when available.
5043         (show_source_or_disasm_and_command): Don't change window
5044         visibility.
5045         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5046         <make_visible>: New method.
5047         * tui/tui-command.c (tui_cmd_window::resize): New method.
5048
5049 2019-08-15  Tom Tromey  <[email protected]>
5050
5051         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5052         (struct tui_source_windows): New.
5053         * tui/tui-winsource.c (tui_display_main): Update.
5054         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5055         (new_height_ok, parse_scrolling_args): Update.
5056         * tui/tui-layout.c (show_layout, show_data): Update.
5057         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5058         (tui_add_to_source_windows): Don't declare.
5059         * tui/tui-data.c (source_windows, tui_source_windows)
5060         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5061
5062 2019-08-15  Tom Tromey  <[email protected]>
5063
5064         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5065         Rename from reset.
5066         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5067         * tui/tui-layout.c (show_source_disasm_command, show_data):
5068         Update.
5069         (tui_gen_win_info::resize): Rename.
5070         (show_source_or_disasm_and_command): Update.
5071         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5072         reset.
5073
5074 2019-08-15  Tom Tromey  <[email protected]>
5075
5076         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5077         * tui/tui-interp.c (tui_interp::init): Don't call
5078         tui_initialize_static_data.
5079         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5080
5081 2019-08-15  Tom Tromey  <[email protected]>
5082
5083         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5084         examine tui_win_list.
5085
5086 2019-08-15  Tom Tromey  <[email protected]>
5087
5088         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5089         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5090         tui_clear_source_content.
5091         (tui_clear_source_content): Remove.
5092         (tui_source_window_base::do_erase_source_content): Hoist call to
5093         content.clear().
5094         * tui/tui-stack.c (tui_show_frame_info): Don't call
5095         tui_clear_source_content.
5096
5097 2019-08-15  Tom Tromey  <[email protected]>
5098
5099         * tui/tui-winsource.h (struct tui_source_window_base)
5100         <do_erase_source_content>: New method.
5101         <erase_source_content>: New method.
5102         (tui_erase_source_content): Don't declare.
5103         * tui/tui-winsource.c (tui_clear_source_content): Update.
5104         (tui_source_window_base::do_erase_source_content): Rename from
5105         tui_erase_source_content.
5106         (tui_source_window_base::show_source_content): Update.
5107         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5108         * tui/tui-source.h (struct tui_source_window)
5109         <erase_source_content>: New method.
5110         * tui/tui-disasm.h (struct tui_disasm_window)
5111         <erase_source_content>: New method.
5112
5113 2019-08-15  Tom Tromey  <[email protected]>
5114
5115         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5116         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5117         constructor.
5118         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5119         * tui/tui-source.c (tui_set_source_content): Update.
5120         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5121
5122 2019-08-15  Tom Tromey  <[email protected]>
5123
5124         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5125         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5126         tui-source.c.
5127         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5128         Declare.
5129         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5130         method.
5131         (tui_source_window::maybe_update): Update.
5132
5133 2019-08-15  Tom Tromey  <[email protected]>
5134
5135         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5136         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5137         tui-disasm.c.
5138         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5139         Declare.
5140         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5141         method.
5142         (tui_disasm_window::maybe_update): Update.
5143
5144 2019-08-15  Tom Tromey  <[email protected]>
5145
5146         * tui/tui-winsource.h (struct tui_source_window_base)
5147         <maybe_update>: Declare.
5148         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5149         method.
5150         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5151         Declare.
5152         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5153         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5154         Declare.
5155         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5156
5157 2019-08-15  Tom Tromey  <[email protected]>
5158
5159         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5160
5161 2019-08-15  Tom Tromey  <[email protected]>
5162
5163         * tui/tui-wingeneral.c: Include tui-stack.h.
5164         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5165         (struct tui_locator_window): Move from tui-data.h.
5166         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5167         (tui_initialize_static_data): Move from tui-data.c.
5168         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5169         (struct tui_locator_window): Move to tui-stack.c.
5170         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5171         (tui_initialize_static_data): Move to tui-stack.c.
5172
5173 2019-08-15  Tom Tromey  <[email protected]>
5174
5175         * tui/tui-layout.c (show_source_disasm_command)
5176         (show_source_or_disasm_and_command): Use make_visible method, not
5177         tui_make_window.
5178         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5179         Remove.
5180
5181 2019-08-15  Tom Tromey  <[email protected]>
5182
5183         * tui/tui-wingeneral.h (tui_make_window): Update.
5184         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5185         parameter.
5186         (tui_gen_win_info::make_visible): Update.
5187         * tui/tui-regs.c (tui_data_window::display_registers_from):
5188         Update.
5189         * tui/tui-layout.c (show_source_disasm_command)
5190         (show_source_or_disasm_and_command): Update.
5191         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5192         (enum tui_box): Remove.
5193         (struct tui_win_info) <can_box>: New method.
5194         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5195         method.
5196
5197 2019-08-15  Tom de Vries  <[email protected]>
5198
5199         * linux-nat-trad.c: Include gdbarch.h.
5200
5201 2019-08-14  Alan Hayward  <[email protected]>
5202
5203         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5204         register sizes.
5205
5206 2019-08-14  Tom Tromey  <[email protected]>
5207
5208         * darwin-nat.c: Include gdbarch.h.
5209         * darwin-nat-info.c: Include gdbarch.h.
5210
5211 2019-08-13  Tom Tromey  <[email protected]>
5212
5213         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5214         Remove.
5215         * tui/tui-data.c (tui_initialize_static_data): Update.
5216
5217 2019-08-13  Tom Tromey  <[email protected]>
5218
5219         * tui/tui-winsource.h (struct tui_exec_info_window)
5220         <~tui_exec_info_window, maybe_allocate_content, get_content,
5221         m_content>: Remove.
5222         (struct tui_source_window_base) <set_exec_info_content,
5223         show_exec_info_content>: Don't declare.
5224         * tui/tui-winsource.c
5225         (tui_exec_info_window::maybe_allocate_content): Remove.
5226         (tui_source_window_base::update_exec_info): Rename from
5227         set_exec_info_content.
5228         (tui_source_window_base::show_exec_info_content)
5229         (tui_source_window_base::update_exec_info): Remove.
5230
5231 2019-08-13  Tom Tromey  <[email protected]>
5232
5233         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5234         declare.
5235         * tui/tui-winsource.c (tui_update_source_window_as_is)
5236         (tui_update_source_windows_with_addr, tui_erase_source_content):
5237         Update.
5238         (tui_clear_exec_info_content): Remove.
5239
5240 2019-08-13  Tom Tromey  <[email protected]>
5241
5242         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5243         declare.
5244         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5245         call tui_erase_exec_info_content.
5246         (tui_clear_exec_info_content): Rename from
5247         tui_erase_exec_info_content.
5248         (tui_clear_exec_info_content): Delete.
5249
5250 2019-08-13  Tom Tromey  <[email protected]>
5251
5252         * tui/tui-winsource.h (struct tui_source_window_base)
5253         <show_exec_info_content>: Declare.
5254         (tui_show_exec_info_content): Don't declare.
5255         * tui/tui-winsource.c
5256         (tui_source_window_base::show_exec_info_content): Rename from
5257         tui_show_exec_info_content.
5258         (tui_source_window_base::update_exec_info): Update.
5259
5260 2019-08-13  Tom Tromey  <[email protected]>
5261
5262         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5263         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5264         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5265         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5266         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5267         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5268         ... here.
5269
5270 2019-08-13  Tom Tromey  <[email protected]>
5271
5272         * tui/tui-winsource.h (struct tui_source_window_base)
5273         <update_exec_info>: Declare.
5274         (tui_update_exec_info): Don't declare.
5275         * tui/tui-winsource.c (tui_update_source_window_as_is)
5276         (tui_source_window_base::refresh_all)
5277         (tui_update_all_breakpoint_info): Update.
5278         (tui_source_window_base::update_exec_info): Rename from
5279         tui_update_exec_info.
5280         * tui/tui-stack.c (tui_show_frame_info): Update.
5281
5282 2019-08-13  Tom Tromey  <[email protected]>
5283
5284         * tui/tui-winsource.h (struct tui_source_window_base)
5285         <set_exec_info_content>: Declare.
5286         (tui_set_exec_info_content): Don't declare.
5287         * tui/tui-winsource.c
5288         (tui_source_window_base::set_exec_info_content): Rename from
5289         tui_set_exec_info_content.
5290         (tui_update_exec_info): Update.
5291
5292 2019-08-13  Tom Tromey  <[email protected]>
5293
5294         * tui/tui-winsource.h (struct tui_source_window_base)
5295         <show_source_content>: Declare.
5296         (tui_show_source_content): Don't declare.
5297         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5298         (tui_source_window_base::show_source_content): Rename from
5299         tui_show_source_content.
5300         (tui_source_window_base::refresh_all): Update.
5301         * tui/tui-layout.c (show_source_disasm_command)
5302         (show_source_or_disasm_and_command): Update.
5303
5304 2019-08-13  Tom Tromey  <[email protected]>
5305
5306         * tui/tui-winsource.c (tui_erase_source_content)
5307         (tui_show_source_content, tui_source_window_base::refresh_all):
5308         Update.
5309         * tui/tui-wingeneral.h
5310         (tui_check_and_display_highlight_if_needed): Don't declare.
5311         * tui/tui-wingeneral.c
5312         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5313         check_and_display_highlight_if_needed.
5314         * tui/tui-win.c (tui_rehighlight_all)
5315         (tui_win_info::make_visible_with_new_height): Update.
5316         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5317         (tui_data_window::erase_data_content)
5318         (tui_data_window::display_all_data): Update.
5319         * tui/tui-data.h (struct tui_win_info)
5320         <check_and_display_highlight_if_needed>: Declare.
5321
5322 2019-08-13  Tom Tromey  <[email protected]>
5323
5324         * tui/tui-win.c (tui_resize_all): Call
5325         tui_delete_invisible_windows.
5326         * tui/tui-layout.c (show_layout): Call
5327         tui_delete_invisible_windows.
5328         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5329         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5330
5331 2019-08-13  Tom Tromey  <[email protected]>
5332
5333         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5334         tui_add_win_to_layout.
5335
5336 2019-08-13  Tom Tromey  <[email protected]>
5337
5338         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5339         * tui/tui-layout.c (tui_default_win_height): Now static.
5340
5341 2019-08-13  Tom Tromey  <[email protected]>
5342
5343         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5344         single switch.
5345         (show_source_disasm_command, show_source_or_disasm_and_command):
5346         Don't check current layout.
5347
5348 2019-08-13  Tom Tromey  <[email protected]>
5349
5350         * tui/tui-wingeneral.c (make_all_visible): Remove.
5351         (tui_make_all_invisible): Simplify.
5352         * tui/tui-layout.c (tui_make_all_invisible): Move from
5353         tui-wingeneral.c; simplify.
5354         (show_layout): Hoist call to tui_make_all_invisible.
5355         (show_data): Don't call tui_make_all_invisible.
5356
5357 2019-08-13  Tom Tromey  <[email protected]>
5358
5359         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5360         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5361
5362 2019-08-13  Tom Tromey  <[email protected]>
5363
5364         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5365         tui-data.c.
5366         (show_source_disasm_command, show_data)
5367         (show_source_or_disasm_and_command): Don't use
5368         tui_set_current_layout_to.
5369         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5370         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5371         tui-layout.c.
5372         (tui_set_current_layout_to): Remove.
5373
5374 2019-08-13  Tom Tromey  <[email protected]>
5375
5376         * tui/tui-layout.c (tui_set_layout): Update.
5377         * tui/tui-data.h (struct tui_layout_def): Remove.
5378         (tui_layout_def): Don't declare.
5379         * tui/tui-data.c (layout_def): Remove.
5380         (tui_layout_def): Remove.
5381
5382 2019-08-13  Tom Tromey  <[email protected]>
5383
5384         * tui/tui-winsource.h (struct tui_source_window_base)
5385         <clear_detail>: No longer "override".
5386         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5387         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5388         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5389         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5390         Remove.
5391         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5392
5393 2019-08-13  Tom Tromey  <[email protected]>
5394
5395         * tracepoint.c: Don't include readline.h or history.h.
5396
5397 2019-08-12  Tom Tromey  <[email protected]>
5398
5399         * configure: Rebuild.
5400         * configure.ac: Check for readline 7.
5401         * NEWS: Mention readline 7 requirement.
5402         * README: Update.
5403
5404 2019-08-12  Tom Tromey  <[email protected]>
5405
5406         * mingw-hdep.c (gdb_select): Remove readline hack.
5407
5408 2019-08-09  Pedro Franco de Carvalho  <[email protected]>
5409
5410         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5411         when the function fails.
5412
5413 2019-08-09  Andreas Arnez  <[email protected]>
5414
5415         * s390-tdep.c (s390_type_align): New function.
5416         (s390_gdbarch_init): Set it as type_align gdbarch method.
5417
5418 2019-08-09  Tom de Vries  <[email protected]>
5419
5420         PR gdb/24591
5421         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5422         pc_low with relocation offset.
5423
5424 2019-08-07  Tom Tromey  <[email protected]>
5425
5426         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5427         (print_frame_args): Update.
5428         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5429         Update.
5430         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5431         * frame.h (struct frame_arg): Add initializers.
5432         <error>: Now a unique_xmalloc_ptr.
5433
5434 2019-08-07  Alan Hayward  <[email protected]>
5435
5436         * NEWS: Expand the Pointer Authentication entry.
5437         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5438         (aarch64_frame_unmask_lr): ... to this.
5439         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5440         Call aarch64_frame_unmask_lr.
5441         * frame.c (struct frame_info): Add "masked" variable.
5442         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5443         (fprint_frame): Check for masked pc.
5444         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5445         declarations.
5446         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5447         * stack.c (print_frame): Check for masked pc.
5448
5449 2019-08-06  Tom Tromey  <[email protected]>
5450
5451         * stabsread.c (patch_block_stabs, read_one_struct_field)
5452         (read_enum_type): Use obstack_strndup.
5453         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5454         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5455         * dwarf2read.c (guess_full_die_structure_name)
5456         (anonymous_struct_prefix): Use obstack_strndup.
5457         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5458         * c-exp.y (yylex): Use obstack_strndup.
5459         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5460         (write_var_or_type): Use obstack_strndup.
5461
5462 2019-08-06  Tom Tromey  <[email protected]>
5463
5464         * symfile.c (reread_symbols): Use obstack_strdup.
5465         * stabsread.c (read_type): Use obstack_strdup.
5466         * gdb_obstack.h (obstack_strdup): New overload.
5467         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5468         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5469         (dwarf2_canonicalize_name): Use obstack_strdup.
5470         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5471         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5472         Use obstack_strdup.
5473
5474 2019-08-06  Tom Tromey  <[email protected]>
5475
5476         * gdb_obstack.h (obstack_strdup): Define.
5477         * gdb_obstack.c (obstack_strdup): Don't define.
5478
5479 2019-08-06  Tom Tromey  <[email protected]>
5480
5481         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5482         obstack_strdup.
5483         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5484         obstack_strdup.
5485         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5486         * stabsread.c (common_block_start): Use obstack_strdup.
5487         * objfiles.c (set_objfile_main_name, objfile): Use
5488         obstack_strdup.
5489         * namespace.c (add_using_directive): Use obstack_strdup.
5490         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5491         * jit.c (finalize_symtab): Use obstack_strdup.
5492         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5493         (guess_partial_die_structure_name, partial_die_info::fixup)
5494         (dwarf2_name): Use obstack_strdup.
5495         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5496         obstack_strdup.
5497         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5498         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5499         obstack_strdup.
5500         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5501
5502 2019-08-07  Philippe Waroquiers  <[email protected]>
5503
5504         * unittests/help-doc-selftests.c: New file.
5505         * Makefile.in: Add the new file.
5506
5507 2019-08-07  Philippe Waroquiers  <[email protected]>
5508
5509         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5510         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5511         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5512         the trailing '.' is not output, and the first character is uppercased.
5513         (print_help_for_command): Update call to print_doc_line.
5514         (print_doc_of_command): Likewise.
5515         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5516         * cli/cli-option.c (append_indented_doc): Do not append newline.
5517         (build_help_option): Append newline after first appended_indented_doc
5518         only if a second call is done.
5519         (build_help): Append 2 new lines before each option, except the first
5520         one.
5521         * compile/compile.c (_initialize_compile): Add new lines after
5522         %OPTIONS%, when not at the end of the help.
5523         Change help doc or code
5524         producing the help doc to respect the invariants.
5525         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5526         Also removed the new line after 'Options:', as all other commands
5527         do not put an empty line between 'Options:' and the first option.
5528         * printcmd.c (_initialize_printcmd): Likewise.
5529         * stack.c (_initialize_stack): Likewise.
5530         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5531         incorrectly telling COMMAND is optional.
5532         * ada-lang.c (_initialize_ada_language): Change help doc or code
5533         producing the help doc to respect the invariants.
5534         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5535         * breakpoint.c (_initialize_breakpoint): Likewise.
5536         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5537         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5538         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5539         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5540         _initialize_cli_style): Likewise.
5541         * corelow.c (core_target_info): Likewise.
5542         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5543         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5544         * filesystem.c (_initialize_filesystem): Likewise.
5545         * frame.c (_initialize_frame): Likewise.
5546         * gnu-nat.c (add_task_commands): Likewise.
5547         * infcall.c (_initialize_infcall): Likewise.
5548         * infcmd.c (_initialize_infcmd): Likewise.
5549         * interps.c (_initialize_interpreter): Likewise.
5550         * language.c (_initialize_language): Likewise.
5551         * linux-fork.c (_initialize_linux_fork): Likewise.
5552         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5553         * maint.c (_initialize_maint_cmds): Likewise.
5554         * memattr.c (_initialize_mem): Likewise.
5555         * printcmd.c (_initialize_printcmd): Likewise.
5556         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5557         _RegEx): Likewise.
5558         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5559         * record-btrace.c (_initialize_record_btrace): Likewise.
5560         * record-full.c (_initialize_record_full): Likewise.
5561         * record.c (_initialize_record): Likewise.
5562         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5563         * regcache.c (_initialize_regcache): Likewise.
5564         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5565         _initialize_remote): Likewise.
5566         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5567         * serial.c (_initialize_serial): Likewise.
5568         * skip.c (_initialize_step_skip): Likewise.
5569         * source.c (_initialize_source): Likewise.
5570         * stack.c (_initialize_stack): Likewise.
5571         * symfile.c (_initialize_symfile): Likewise.
5572         * symtab.c (_initialize_symtab): Likewise.
5573         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5574         * top.c (init_main): Likewise.
5575         * tracefile-tfile.c (tfile_target_info): Likewise.
5576         * tracepoint.c (_initialize_tracepoint): Likewise.
5577         * tui/tui-win.c (_initialize_tui_win): Likewise.
5578         * utils.c (add_internal_problem_command): Likewise.
5579         * valprint.c (value_print_option_defs): Likewise.
5580
5581 2019-08-06  Frank Ch. Eigler  <[email protected]>
5582
5583         PR build/24886
5584         * configure.ac: Drop enable-libmcheck support.
5585         * configure, config.in: Rebuild.
5586         * libmcheck.m4: Remove.
5587         * acinclude.m4: Don't include it.
5588         * Makefile.in: Don't distribute it.
5589         * top.c (print_gdb_configuration): Don't mention it.
5590
5591 2019-08-06  Tom Tromey  <[email protected]>
5592
5593         * utils.c (set_output_style): Sometimes pass stream to
5594         emit_style_escape.
5595         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5596         * record-btrace.c (btrace_insn_history): Update.
5597         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5598         method.
5599         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5600         Update initializers.
5601         <m_uiout>: New field.
5602         <m_di>: Move lower.
5603         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5604         Remove "uiout" parameter.
5605         (dump_insns): Update.
5606         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5607         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5608
5609 2019-08-06  Christian Biesinger  <[email protected]>
5610
5611         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5612         (error_in_psymtab_expansion): Likewise.
5613         (lookup_symbol_via_quick_fns): Likewise.
5614         (basic_lookup_transparent_type_quick): Likewise.
5615         (basic_lookup_transparent_type_1): Likewise.
5616
5617 2019-08-06  Tom Tromey  <[email protected]>
5618
5619         * source.c (last_source_error): Now bool.
5620         (print_source_lines_base): Make "noprint" bool.  Only open
5621         source file when last_source_visited changes.
5622
5623 2019-08-06  Tom Tromey  <[email protected]>
5624
5625         * annotate.c (annotate_source_line): Use g_source_cache.
5626         * source-cache.c (source_cache::get_plain_source_lines): Change
5627         parameters.  Populate m_offset_cache.
5628         (source_cache::ensure): New method.
5629         (source_cache::get_line_charpos): New method.
5630         (extract_lines): Move lower.  Change parameters.
5631         (source_cache::get_source_lines): Move lower.
5632         * source-cache.h (class source_cache): Update comment.
5633         <get_line_charpos>: New method.
5634         <get_source_lines>: Update comment.
5635         <clear>: Clear m_offset_cache.
5636         <get_plain_source_lines>: Change parameters.
5637         <ensure>: New method
5638         <m_offset_cache>: New member.
5639         * source.c (forget_cached_source_info_for_objfile): Update.
5640         (info_source_command): Use g_source_cache.
5641         (find_source_lines, open_source_file_with_line_charpos): Remove.
5642         (print_source_lines_base, search_command_helper): Use g_source_cache.
5643         * source.h (open_source_file_with_line_charpos): Don't declare.
5644         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5645         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5646         Use g_source_cache.
5647
5648 2019-08-06  Tom Tromey  <[email protected]>
5649
5650         * source-cache.c (source_cache::get_plain_source_lines):
5651         Remove "first_line" and "last_line" parameters.
5652         (source_cache::get_source_lines): Cache plain text.
5653         * source-cache.h (class source_cache)
5654         <get_plain_source_lines>: Update.
5655
5656 2019-08-06  Tom Tromey  <[email protected]>
5657
5658         * source-cache.c (extract_lines): No longer a method.
5659         Changed type of parameter.  Include final newline.
5660         (selftests::extract_lines_test): New function.
5661         (_initialize_source_cache): Likewise.
5662         * source-cache.h (class source_cache)
5663         <extract_lines>: Don't declare.
5664
5665 2019-08-06  Tom Tromey  <[email protected]>
5666
5667         * breakpoint.c (init_breakpoint_sal): Update.
5668         (breakpoint): Update.
5669         * breakpoint.h (struct breakpoint) <filter>: Now a
5670         unique_xmalloc_ptr.
5671
5672 2019-08-05  Christian Biesinger  <[email protected]>
5673
5674         * NEWS: Mention dictionary access on blocks.
5675         * python/py-block.c (blpy_getitem): New function.
5676         (block_object_as_mapping): New struct.
5677         (block_object_type): Use new struct for tp_as_mapping field.
5678
5679 2019-08-05  Christian Biesinger  <[email protected]>
5680
5681         * objfiles.h (objfile): Add a comment describing partial symbols.
5682
5683 2019-08-05  Tom Tromey  <[email protected]>
5684
5685         * compile/compile.c (_initialize_compile): Use _(), not N_().
5686         * thread.c (_initialize_thread): Use _(), not N_().
5687         * stack.c (_initialize_stack): Use _(), not N_().
5688         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5689
5690 2019-08-04  Simon Marchi  <[email protected]>
5691
5692         * dwarf2read.c (struct dw2_symtab_iterator):
5693         <want_specific_block>: Remove.
5694         <block_index>: Change type to gdb::optional.
5695         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5696         change type of BLOCK_INDEX parameter to gdb::optional.
5697         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5698         (dw2_lookup_symbol): Don't pass argument for
5699         WANT_SPECIFIC_BLOCK.
5700         (dw2_expand_symtabs_for_function): Don't pass argument for
5701         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5702         (class dw2_debug_names_iterator)
5703         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5704         parameter, change BLOCK_INDEX type to gdb::optional.
5705         <m_want_specific_block>: Remove.
5706         <m_block_index>: Change type to gdb::optional.
5707         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5708         gdb::optional.  Re-write in function of gdb::optional.
5709         (dw2_debug_names_lookup_symbol): Don't pass argument for
5710         WANT_SPECIFIC_BLOCK.
5711         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5712         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5713         BLOCK_INDEX.
5714
5715 2019-08-03  Philippe Waroquiers  <[email protected]>
5716
5717         * NEWS: Mention changes to "info sources" command.
5718
5719 2019-08-03  Philippe Waroquiers  <[email protected]>
5720
5721         * symtab.c (filename_partial_match_opts): New struct type.
5722         (struct output_source_filename_data): New members
5723         regexp, c_regexp, partial_match.
5724         (output_source_filename): Use new members to decide to print file.
5725         (info_sources_option_defs): New variable.
5726         (make_info_sources_options_def_group, print_info_sources_header,
5727         info_sources_command_completer):
5728         New functions.
5729         (info_sources_command): Read new optional arguments.
5730         (_initialize_symtab): Update info sources help.
5731
5732 2019-08-02  Alexandre Oliva <[email protected]>
5733
5734         * ada-lang.c (exception_support_info_v0): Renamed from...
5735         (default_exception_support_info): ... this.  Create new
5736         definition for v1.
5737         (ada_has_this_exception_support): Look up catch_handlers_sym.
5738         (ada_exception_support_info_sniffer): Try v0 after default.
5739
5740 2019-08-01  Tom Tromey  <[email protected]>
5741
5742         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5743         gdbarch.h.
5744
5745 2019-08-01  Christian Biesinger  <[email protected]>
5746
5747         * s12z-tdep.c: Fix include path for s12z-opc.h.
5748
5749 2019-08-01  Alan Hayward  <[email protected]>
5750
5751         * NEWS: Require GNU make 3.82.
5752
5753 2019-07-16  Tom Tromey  <[email protected]>
5754
5755         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5756         declare.
5757
5758 2019-07-30  Tom Tromey  <[email protected]>
5759
5760         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5761
5762 2019-07-30  Kevin Buettner  <[email protected]>
5763
5764         * printcmd.c (print_address_symbolic): Print negative offsets.
5765         (build_address_symbolic): Force signed arithmetic when computing
5766         offset.
5767
5768 2019-07-30  Christian Biesinger  <[email protected]>
5769
5770         PR/24474: Add a function to lookup static variables.
5771         * NEWS: Mention this new function.
5772         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5773         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5774         * python/python.c (python_GdbMethods): Add new function.
5775
5776 2019-07-29  Christian Biesinger  <[email protected]>
5777
5778         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5779         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5780         (objfpy_lookup_static_symbol): New function.
5781         (objfile_object_methods): Add new functions.
5782
5783 2019-07-29  Philippe Waroquiers  <[email protected]>
5784
5785         * NEWS: Mention 'set|show print frame-info'.  Mention new
5786         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5787         backtrace argument.  Mention that python frame filtering code
5788         is now consistent with what 'backtrace' command prints.
5789
5790 2019-07-29  Philippe Waroquiers  <[email protected]>
5791
5792         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5793         comments.
5794         (print_frame_info_auto, print_frame_info_source_line,
5795         print_frame_info_location, print_frame_info_source_and_location,
5796         print_frame_info_location_and_address, print_frame_info_short_location):
5797         New declarations.
5798         (struct frame_print_options): New member print_frame_info.
5799         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5800         * stack.h (get_user_print_what_frame_info): New declaration.
5801         (frame_show_address): New declaration.
5802         * stack.c (print_frame_arguments_choices): New value 'presence'.
5803         (print_frame_info_auto, print_frame_info_source_line,
5804         print_frame_info_location, print_frame_info_source_and_location,
5805         print_frame_info_location_and_address, print_frame_info_short_location,
5806         print_frame_info_choices, print_frame_info_print_what): New definitions.
5807         (print_frame_args): Only print dots for args if print frame-arguments
5808         is 'presence'.
5809         (frame_print_option_defs): New element for "frame-info".
5810         (get_user_print_what_frame_info): New function.
5811         (frame_show_address): Make non static.  Move comment to stack.h.
5812         (print_frame_info_to_print_what): New function.
5813         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5814         to decide what to print.
5815         (backtrace_command_1): Handle the new print_frame_arguments_presence
5816         value.
5817         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5818         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5819         (py_print_frame): In non-mi mode, use LOCATION as default for
5820         print_what, similarly to frame information printed directly by
5821         backtrace command. Handle frame-info user option in non MI mode.
5822
5823 2019-07-27  Kevin Buettner  <[email protected]>
5824
5825         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5826         Add case for debugging 32-bit target on 64-bit host.  Revise
5827         comment.
5828
5829 2019-07-27  Kevin Buettner  <[email protected]>
5830
5831         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5832         instead of find_function_entry_range_from_pc.
5833
5834 2019-07-27  Kevin Buettner  <[email protected]>
5835
5836         * stack.c (find_frame_funname): Remove code which preferred
5837         minsym over symtab sym in "certain pathological cases".
5838
5839         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5840         parameter.  Change type of "do_demangle" to bool.
5841         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5842         Pass suitable "prefer_sym_over_minsym" flag to
5843         build_address_symbolic().  Don't output "+" for negative offsets.
5844         * printcmd.c (print_address_symbolic): Update invocation of
5845         build_address_symbolic to include a "prefer_sym_over_minsym"
5846         flag.
5847         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5848         Restrict cases in which use of minimal symbol is preferred to that
5849         of a found symbol.  Update comments.
5850
5851         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5852         for entry pc when entry pc is out of range for that FDE.
5853
5854 2019-07-26  Brian Callahan  <[email protected]>
5855
5856         PR gdb/24839:
5857         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5858         type.
5859
5860 2019-07-25  Christian Biesinger  <[email protected]>
5861
5862         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5863         this function's Python signature.
5864
5865
5866 2019-07-24  Christian Biesinger  <[email protected]>
5867
5868         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5869         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5870         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5871         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5872         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5873
5874
5875 2019-07-24  Yoshinori Sato  <[email protected]>
5876
5877         * h8300-tdep.c (h8300_register_name_common): New.
5878         h8300_register_name): Use h8300_register_name_common.
5879         (h8300s_register_name): Likewise.
5880         (h8300sx_register_name): Likewise.
5881         (h8300h_register_nam): New.
5882         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5883
5884
5885 2019-07-23  Srinath Parvathaneni  <[email protected]>
5886
5887         * arm-tdep.c (arm_skip_cmse_entry): New function.
5888         (arm_is_sgstubs_section): New function.
5889         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5890
5891 2019-07-22  Tom Tromey  <[email protected]>
5892
5893         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5894         Don't self-assign.
5895
5896 2019-07-22  Andrew Burgess  <[email protected]>
5897
5898         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5899         type_print.
5900
5901 2019-07-22  Andrew Burgess  <[email protected]>
5902
5903         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5904         so that GDB doesn't match any msymbols when searching in the
5905         TYPES_DOMAIN.
5906         (print_symbol_info): Print using typedef_print or type_print based
5907         on the type of the symbol.  Add updated FIXME comment moved from...
5908         (_initialize_symtab): ... move and update FIXME comment to above.
5909
5910 2019-07-22  Andrew Burgess  <[email protected]>
5911
5912         * NEWS: Mention adding -q option to "info types".
5913         * symtab.c (struct info_types_options): New struct.
5914         (info_types_options_defs): New variable.
5915         (make_info_types_options_def_group): New function.
5916         (info_types_command): Use gdb::option framework to parse options.
5917         (info_types_command_completer): New function.
5918         (_initialize_symtab): Extend the help text on "info types" and
5919         register command completer.
5920
5921 2019-07-21  Christian Biesinger  <[email protected]>
5922
5923         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5924         (lookup_symbol_in_objfile): Change int to block_enum and add a
5925         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5926
5927 2019-07-20  Christian Biesinger  <[email protected]>
5928
5929         * MAINTAINERS (Write After Approval): Add self.
5930
5931 2019-07-19  Andrew Burgess  <[email protected]>
5932
5933         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5934         instruction to the dummy code region.
5935
5936 2019-07-19  Tom Tromey  <[email protected]>
5937
5938         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5939         (ARGSUSED, PARAMS, __func__): Remove rules.
5940
5941 2019-07-19  Alan Hayward  <[email protected]>
5942
5943         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5944         * features/arm/arm-with-iwmmxt.c: Remove.
5945         * features/arm/arm-with-iwmmxt.xml: Remove.
5946         * features/arm/arm-with-m-fpa-layout.c: Remove.
5947         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5948         * features/arm/arm-with-m-vfp-d16.c: Remove.
5949         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5950         * features/arm/arm-with-m.c: Remove.
5951         * features/arm/arm-with-m.xml: Remove.
5952         * features/arm/arm-with-neon.c: Remove.
5953         * features/arm/arm-with-neon.xml: Remove.
5954         * features/arm/arm-with-vfpv2.c: Remove.
5955         * features/arm/arm-with-vfpv2.xml: Remove.
5956         * features/arm/arm-with-vfpv3.c: Remove.
5957         * features/arm/arm-with-vfpv3.xml: Remove.
5958
5959 2019-07-19  Alan Hayward  <[email protected]>
5960
5961         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5962
5963 2019-07-19  Alan Hayward  <[email protected]>
5964
5965         * arch/aarch32.c (aarch32_create_target_description): Create
5966         target descriptions using features.
5967         * arch/arm.c (arm_create_target_description)
5968         (arm_create_mprofile_target_description): Likewise.
5969         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5970
5971 2019-07-19  Alan Hayward  <[email protected]>
5972
5973         * Makefile.in: Add new files.
5974         * aarch32-tdep.c: New file.
5975         * aarch32-tdep.h: New file.
5976         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5977         Call aarch32_read_description.
5978         * arch/aarch32.c: New file.
5979         * arch/aarch32.h: New file.
5980         * arch/arm.c (arm_create_target_description)
5981         (arm_create_mprofile_target_description): New function.
5982         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5983         (arm_create_target_description)
5984         (arm_create_mprofile_target_description): New declaration.
5985         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5986         read_description functions.
5987         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5988         Likewise.
5989         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5990         * arm-tdep.c (tdesc_arm_list): New variable.
5991         (arm_register_g_packet_guesses): Call create description functions.
5992         (arm_read_description) (arm_read_mprofile_description): New
5993         function.
5994         * arm-tdep.h (arm_read_description)
5995         (arm_read_mprofile_description): Add declaration.
5996         * configure.tgt: Add new files.
5997
5998 2019-07-18  Guillaume LABARTHE  <[email protected]>
5999
6000         * top.c (new_ui_command): Open specified terminal just once.
6001
6002 2019-07-18  Tom Tromey  <[email protected]>
6003
6004         * symtab.c (main_name): Constify return type.
6005         * symfile.c (set_initial_language): Update.
6006         * symtab.h (main_name): Constify return type.
6007
6008 2019-07-17  Tom Tromey  <[email protected]>
6009
6010         * tui/tui-winsource.c (tui_update_source_window)
6011         (tui_update_source_window_as_is)
6012         (tui_update_source_windows_with_line): Remove return.
6013         * tui/tui-disasm.c (tui_show_disassem)
6014         (tui_show_disassem_and_update_source): Remove return.
6015         * tui/tui.c (tui_reset): Remove return.
6016         * tui/tui-wingeneral.c
6017         (tui_check_and_display_highlight_if_needed): Remove return.
6018
6019 2019-07-17  Tom Tromey  <[email protected]>
6020
6021         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6022
6023 2019-07-17  Tom Tromey  <[email protected]>
6024
6025         * tui/tui-winsource.h (struct tui_exec_info_window)
6026         (struct tui_source_window_base): Move from tui-data.h.
6027         * tui/tui-winsource.c: Move many method definitions from
6028         elsewhere.  Remove "structuring" comments.
6029         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6030         (tui_source_window_base::refresh_window): Move to
6031         tui-winsource.c.
6032         * tui/tui-win.c (tui_source_window_base::refresh_all)
6033         (tui_source_window_base::update_tab_width)
6034         (tui_source_window_base::set_new_height)
6035         (tui_source_window_base::do_make_visible_with_new_height): Move to
6036         tui-winsource.c.
6037         * tui/tui-source.h: Update.
6038         * tui/tui-source.c (tui_source_window_base::reset): Move to
6039         tui-winsource.c.
6040         * tui/tui-disasm.h: Update.
6041         * tui/tui-data.h (struct tui_exec_info_window): Move to
6042         tui-winsource.h.
6043         (struct tui_source_window_base): Likewise.
6044         * tui/tui-data.c (tui_source_window_base::clear_detail)
6045         (tui_source_window_base, ~tui_source_window_base): Move to
6046         tui-winsource.c.
6047
6048 2019-07-17  Tom Tromey  <[email protected]>
6049
6050         * tui/tui-win.c (tui_resize_all)
6051         (tui_source_window_base::update_tab_width)
6052         (tui_adjust_win_heights): Update.
6053         (tui_win_info::make_invisible_and_set_new_height): Rename from
6054         make_invisible_and_set_new_height.
6055         * tui/tui-data.h (struct tui_win_info)
6056         <make_invisible_and_set_new_height>: New method.
6057
6058 2019-07-17  Tom Tromey  <[email protected]>
6059
6060         * tui/tui.c: Update.
6061         * tui/tui-source.h (struct tui_source_window): Move from
6062         tui-data.h.
6063         * tui/tui-layout.c: Update.
6064         * tui/tui-disasm.c: Update.
6065         * tui/tui-data.h (struct tui_source_window): Move to
6066         tui-source.h.
6067
6068 2019-07-17  Tom Tromey  <[email protected]>
6069
6070         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6071         tui-data.h.
6072         * tui/tui-data.h (struct tui_disasm_window): Move to
6073         tui-disasm.h.
6074
6075 2019-07-17  Tom Tromey  <[email protected]>
6076
6077         * tui/tui-regs.h (struct tui_data_item_window): Move from
6078         tui-data.h.
6079         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6080         * tui/tui-data.h (struct tui_data_item_window): Move to
6081         tui-regs.h.
6082         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6083
6084 2019-07-17  Tom Tromey  <[email protected]>
6085
6086         * tui/tui.c: Update.
6087         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6088         (tui_cmd_window::max_height): Move to tui-command.c.
6089         * tui/tui-layout.c: Update.
6090         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6091         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6092         tui-command.c.
6093         * tui/tui-command.h (struct tui_cmd_window): Move from
6094         tui-data.h.
6095         * tui/tui-command.c: Remove "structuring" comments.
6096         (tui_cmd_window::clear_detail)
6097         (tui_cmd_window::do_make_visible_with_new_height)
6098         (tui_cmd_window::max_height): Move from elsewhere.
6099
6100 2019-07-17  Tom Tromey  <[email protected]>
6101
6102         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6103         Now static.
6104         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6105         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6106
6107 2019-07-17  Tom Tromey  <[email protected]>
6108
6109         * tui/tui.c: Update.
6110         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6111         tui-regs.c.
6112         * tui/tui-windata.h: Remove file.
6113         * tui/tui-windata.c: Remove file.
6114         * tui/tui-win.c (tui_data_window::set_new_height)
6115         (tui_data_window::do_make_visible_with_new_height): Move to
6116         tui-regs.c.
6117         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6118         * tui/tui-regs.c: Remove "structuring" comments.
6119         (tui_data_window::first_data_item_displayed)
6120         (tui_data_window::delete_data_content_windows)
6121         (tui_data_window::erase_data_content)
6122         (tui_data_window::display_all_data)
6123         (tui_data_window::refresh_all)
6124         (tui_data_window::do_scroll_vertical)
6125         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6126         (tui_data_window::do_make_visible_with_new_height)
6127         (tui_data_window::refresh_window): Move from elsewhere.
6128         (_initialize_tui_regs): Move to end of file.
6129         * tui/tui-layout.c: Update.
6130         * tui/tui-hooks.c: Update.
6131         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6132         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6133         tui-regs.c.
6134         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6135
6136 2019-07-17  Tom Tromey  <[email protected]>
6137
6138         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6139         seen.
6140
6141 2019-07-17  Tom Tromey  <[email protected]>
6142
6143         * tui/tui-win.c (tui_source_window_base::set_new_height)
6144         (tui_source_window_base::do_make_visible_with_new_height): Use
6145         m_has_locator field directly.
6146         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6147         method.
6148         (struct tui_source_window_base) <has_locator>: Likewise.
6149
6150 2019-07-17  Tom Tromey  <[email protected]>
6151
6152         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6153         Don't declare.
6154         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6155         Remove.
6156         * tui/tui-win.c (tui_source_window_base::set_new_height)
6157         (tui_source_window_base::set_new_height)
6158         (make_invisible_and_set_new_height)
6159         (tui_source_window_base::do_make_visible_with_new_height)
6160         (tui_source_window_base::do_make_visible_with_new_height):
6161         Update.
6162         * tui/tui-layout.c (show_source_disasm_command, show_data)
6163         (show_source_or_disasm_and_command): Update.
6164         * tui/tui-layout.c (show_layout): Update.
6165
6166 2019-07-17  Tom Tromey  <[email protected]>
6167
6168         * tui/tui-layout.c (make_data_window): Remove.
6169         (show_data): Unify creation and re-initialization cases.
6170
6171 2019-07-17  Tom Tromey  <[email protected]>
6172
6173         * tui/tui-layout.c (make_source_window, make_disasm_window):
6174         Remove.
6175         (show_data): Unify creation and re-initialization cases.
6176
6177 2019-07-17  Tom Tromey  <[email protected]>
6178
6179         * tui/tui-layout.c (make_command_window): Remove.
6180         (show_source_disasm_command, show_source_or_disasm_and_command):
6181         Unify creation and re-initialization cases.
6182
6183 2019-07-17  Tom Tromey  <[email protected]>
6184
6185         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6186         creation and re-initialization cases.
6187
6188 2019-07-17  Tom Tromey  <[email protected]>
6189
6190         * tui/tui-regs.c (tui_get_register): Return void.
6191
6192 2019-07-17  Tom Tromey  <[email protected]>
6193
6194         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6195         Simplify.
6196
6197 2019-07-17  Tom Tromey  <[email protected]>
6198
6199         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6200         resetting.
6201
6202 2019-07-17  Tom Tromey  <[email protected]>
6203
6204         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6205         * tui/tui-regs.c (tui_reg_layout): New function.
6206         (tui_show_registers, tui_reg_command): Use it.
6207         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6208         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6209         parameters.
6210         (tui_layout_command): Remove.
6211
6212 2019-07-17  Tom Tromey  <[email protected]>
6213
6214         * tui/tui-layout.h (tui/tui-layout): Return void.
6215         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6216
6217 2019-07-17  Tom Tromey  <[email protected]>
6218
6219         * tui/tui-layout.c (show_source_disasm_command, show_data):
6220         Update.
6221         (reset_locator): Remove.
6222         (show_source_or_disasm_and_command): Update.
6223
6224 2019-07-17  Tom Tromey  <[email protected]>
6225
6226         * tui/tui-source.c (tui_source_window_base::reset): Remove
6227         win_type parameter.
6228         * tui/tui-layout.c (make_command_window, make_source_window)
6229         (make_disasm_window, make_data_window)
6230         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6231         (reset_locator, show_source_or_disasm_and_command): Update.
6232         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6233         win_type parameter.
6234         (struct tui_source_window_base) <reset>: Likewise.
6235
6236 2019-07-17  Tom Tromey  <[email protected]>
6237
6238         * tui/tui-layout.c (show_source_disasm_command): Use
6239         reset_locator.
6240         (reset_locator): New function.
6241         (init_and_make_win): Remove.
6242         (show_source_or_disasm_and_command): Use reset_locator.
6243
6244 2019-07-17  Tom Tromey  <[email protected]>
6245
6246         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6247         condition.
6248         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6249         Remove condition.
6250         * tui/tui-source.c (tui_source_window_base::reset): New method.
6251         * tui/tui-layout.c (make_command_window): Don't call
6252         init_and_make_win.
6253         (make_source_window, make_disasm_window): Don't call
6254         make_source_or_disasm_window.
6255         (make_data_window): Don't call init_and_make_win.  Change calling
6256         convention.
6257         (show_source_disasm_command, show_data): Simplify.
6258         (make_source_or_disasm_window): Remove.
6259         (show_source_or_disasm_and_command): Simplify.
6260         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6261         (struct tui_source_window_base) <reset>: Likewise.
6262         <execution_info>: Remove initializer.
6263         * tui/tui-data.c (tui_source_window_base): Initialize
6264         execution_info.
6265
6266 2019-07-17  Tom Tromey  <[email protected]>
6267
6268         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6269         variable.
6270
6271 2019-07-17  Tom Tromey  <[email protected]>
6272
6273         * tui/tui.c (tui_rl_other_window): Update.
6274         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6275         superclass method first.  Always iterate over regs_content.
6276         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6277         method.
6278         * tui/tui-win.c (tui_set_focus_command): Update.
6279
6280 2019-07-17  Tom Tromey  <[email protected]>
6281
6282         * tui/tui-win.c (tui_set_focus_command): Rename from
6283         tui_set_focus.  Call tui_enable.
6284         (tui_set_focus_command): Remove.
6285
6286 2019-07-17  Tom Tromey  <[email protected]>
6287
6288         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6289         refresh_window.
6290         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6291         touchwin.
6292         (tui_data_window::refresh_window): Call refresh_window on data
6293         items.  Always call superclass refresh_window.
6294         (tui_win_info::refresh): Remove.
6295         (tui_source_window_base::refresh_window): Update.
6296         (tui_refresh_all): Update.
6297         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6298         refresh_window.
6299         (show_source_or_disasm_and_command): Likewise.
6300         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6301         (struct tui_source_window_base) <refresh>: Likewise.
6302
6303 2019-07-17  Tom Tromey  <[email protected]>
6304
6305         * tui/tui-winsource.c (tui_clear_source_content)
6306         (tui_show_source_content): Update.
6307         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6308         whether content is empty.
6309         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6310         Remove.
6311
6312 2019-07-17  Tom Tromey  <[email protected]>
6313
6314         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6315         window's contents.
6316         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6317         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6318
6319 2019-07-17  Tom Tromey  <[email protected]>
6320
6321         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6322         (struct tui_data_item_window): Update.
6323
6324 2019-07-17  Tom Tromey  <[email protected]>
6325
6326         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6327         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6328         defines.
6329
6330 2019-07-17  Tom Tromey  <[email protected]>
6331
6332         * tui/tui-winsource.h (tui_erase_source_content)
6333         (tui_clear_source_content): Remove "display_prompt" parameter.
6334         * tui/tui-winsource.c (tui_update_source_window_as_is)
6335         (tui_update_source_windows_with_addr): Update.
6336         (tui_clear_source_content): Remove "display_prompt" parameter.
6337         (tui_erase_source_content): Likewise.  Simplify.
6338         (tui_show_source_content): Update.
6339         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6340         * tui/tui-stack.c (tui_show_frame_info): Update.
6341         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6342         Remove defines.
6343
6344 2019-07-17  Tom Tromey  <[email protected]>
6345
6346         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6347         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6348         parameter.
6349         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6350         parameter.
6351
6352 2019-07-17  Tom Tromey  <[email protected]>
6353
6354         * tui/tui-winsource.c (tui_clear_source_content)
6355         (tui_show_source_content, tui_show_exec_info_content)
6356         (tui_clear_exec_info_content): Update.
6357         * tui/tui-stack.c (tui_show_locator_content): Update.
6358         (tui_show_frame_info): Update.
6359         * tui/tui-source.h (tui_source_window): Don't declare.
6360         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6361         from tui_source_is_displayed.
6362         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6363         Remove field.
6364         (struct tui_source_window_base) <content_in_use>: New field.  Now
6365         bool.
6366         (struct tui_source_window) <showing_source_p>: New method.
6367         (TUI_SRC_WIN): Change cast.
6368         * tui/tui-data.c (tui_initialize_static_data): Update.
6369
6370 2019-07-17  Tom Tromey  <[email protected]>
6371
6372         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6373         location_matches_p.
6374         * tui/tui-source.c (tui_source_window::location_matches_p): New
6375         method.
6376         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6377         method.
6378         * tui/tui-data.h (struct tui_source_window_base)
6379         <location_matches_p>: New method.
6380         (struct tui_source_window, struct tui_disasm_window)
6381         <location_matches_p>: Likewise.
6382
6383 2019-07-17  Tom Tromey  <[email protected]>
6384
6385         * tui/tui-win.c (tui_set_win_height_command): Rename from
6386         tui_set_win_height.
6387         (tui_set_win_height_command): Remove.
6388
6389 2019-07-17  Tom Tromey  <[email protected]>
6390
6391         * tui/tui-source.c (tui_source_window): New constructor.  Add
6392         observer.
6393         (~tui_source_window): New destructor.
6394         (tui_source_window::style_changed): New method.
6395         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6396         (tui_attach_detach_observers): Update.
6397         * tui/tui-data.h (struct tui_source_window): Make constructor not
6398         inline.  Add destructor.
6399         (struct tui_source_window) <style_changed>: New method.
6400         <m_observable>: New member.
6401
6402 2019-07-17  Tom Tromey  <[email protected]>
6403
6404         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6405         * tui/tui-win.c (tui_resize_all): Fix typo.
6406
6407 2019-07-17  Tom Tromey  <[email protected]>
6408
6409         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6410         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6411         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6412         * tui/tui-win.c (window_name_completer): Use foreach.
6413         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6414         (update_tab_width): Likewise.
6415         * tui/tui-layout.c (show_layout): Update.
6416         * tui/tui-data.h (class tui_window_iterator): New.
6417         (struct all_tui_windows): New.
6418         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6419
6420 2019-07-17  Tom Tromey  <[email protected]>
6421
6422         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6423         parameter.  Don't reference globals.
6424         (tui_reg_command): Update.
6425
6426 2019-07-17  Tom Tromey  <[email protected]>
6427
6428         * tui/tui-regs.c (tui_show_registers): Simplify.
6429
6430 2019-07-17  Tom Tromey  <[email protected]>
6431
6432         * tui/tui-regs.c (tui_show_registers): Update.
6433         (tui_show_register_group): Add win_info parameter.
6434
6435 2019-07-17  Tom Tromey  <[email protected]>
6436
6437         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6438         Rename from tui_display_reg_element_at_line.
6439         (tui_data_window::display_registers_from_line): Update.
6440         * tui/tui-data.h (struct tui_data_window)
6441         <display_reg_element_at_line>: New method.
6442
6443 2019-07-17  Tom Tromey  <[email protected]>
6444
6445         * tui/tui-regs.h (tui_display_registers_from)
6446         (tui_display_registers_from_line): Don't declare.
6447         * tui/tui-windata.c (tui_data_window::display_all_data)
6448         (tui_data_window::refresh_all)
6449         (tui_data_window::do_scroll_vertical): Update.
6450         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6451         from tui_display_registers_from.
6452         (tui_display_reg_element_at_line): Update.
6453         (tui_data_window::display_registers_from_line): Rename from
6454         tui_display_registers_from_line.
6455         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6456         display_registers_from_line>: New methods.
6457
6458 2019-07-17  Tom Tromey  <[email protected]>
6459
6460         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6461         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6462         from tui_erase_data_content.
6463         (tui_data_window::display_all_data)
6464         (tui_data_window::refresh_all)
6465         (tui_data_window::do_scroll_vertical): Update.
6466         * tui/tui-regs.c (tui_show_registers): Update.
6467         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6468         New method.
6469
6470 2019-07-17  Tom Tromey  <[email protected]>
6471
6472         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6473         declare.
6474         * tui/tui-windata.c
6475         (tui_data_window::delete_data_content_windows): Rename from
6476         tui_delete_data_content_windows.
6477         (tui_data_window::display_all_data)
6478         (tui_data_window::do_scroll_vertical): Update.
6479         * tui/tui-data.h (struct tui_data_window)
6480         <delete_data_content_windows>: New method.
6481
6482 2019-07-17  Tom Tromey  <[email protected]>
6483
6484         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6485         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6486
6487 2019-07-17  Tom Tromey  <[email protected]>
6488
6489         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6490         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6491         from tui_display_all_data.
6492         * tui/tui-win.c
6493         (tui_data_window::do_make_visible_with_new_height): Update.
6494         * tui/tui-regs.c (tui_show_registers): Update.
6495         * tui/tui-layout.c (tui_set_layout): Update.
6496         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6497         method.
6498
6499 2019-07-17  Tom Tromey  <[email protected]>
6500
6501         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6502         * tui/tui-windata.c (tui_display_data_from): Remove.
6503         (tui_data_window::refresh_all): Update.
6504
6505 2019-07-17  Tom Tromey  <[email protected]>
6506
6507         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6508         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6509         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6510         tui_display_registers_from_line.
6511         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6512         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6513         "force_display" parameter.
6514
6515 2019-07-17  Tom Tromey  <[email protected]>
6516
6517         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6518         declare.
6519         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6520         Rename from tui_first_reg_element_no_inline.
6521         (tui_display_reg_element_at_line)
6522         (tui_display_registers_from_line): Update.
6523         * tui/tui-data.h (struct tui_data_window)
6524         <first_reg_element_no_inline>: New method.
6525
6526 2019-07-17  Tom Tromey  <[email protected]>
6527
6528         * tui/tui-windata.c (tui_display_data_from)
6529         (tui_data_window::do_scroll_vertical): Update.
6530         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6531         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6532         Rename from tui_line_from_reg_element_no.
6533         (tui_display_registers_from_line): Update.
6534         * tui/tui-data.h (struct tui_data_window)
6535         <line_from_reg_element_no>: New method.
6536
6537 2019-07-17  Tom Tromey  <[email protected]>
6538
6539         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6540         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6541         tui_last_regs_line_no.
6542         (tui_display_reg_element_at_line)
6543         (tui_display_registers_from_line): Update.
6544         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6545         method.
6546
6547 2019-07-17  Tom Tromey  <[email protected]>
6548
6549         PR tui/24722:
6550         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6551         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6552         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6553         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6554         (tui_update_breakpoint_info): Likewise.
6555         * tui/tui-hooks.c (tui_event_create_breakpoint)
6556         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6557         Update.
6558
6559 2019-07-17  Tom Tromey  <[email protected]>
6560
6561         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6562
6563 2019-07-17  Tom Tromey  <[email protected]>
6564
6565         * tui/tui-winsource.c (tui_update_source_window_as_is)
6566         (tui_update_source_windows_with_addr): Update.
6567         * tui/tui-source.h (tui_set_source_content)
6568         (tui_show_symtab_source): Add "win_info" parameter.
6569         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6570         parameter.
6571         (tui_show_symtab_source): Likewise.
6572
6573 2019-07-17  Tom Tromey  <[email protected]>
6574
6575         * tui/tui-wingeneral.c
6576         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6577
6578 2019-07-17  Tom Tromey  <[email protected]>
6579
6580         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6581         (struct tui_cmd_window) <can_scroll>: New method.
6582         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6583         method.
6584
6585 2019-07-17  Tom Tromey  <[email protected]>
6586
6587         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6588         do_field_signed>: Rename.  Change type of "value".
6589         * ui-out.c (ui_out::field_signed): Rename from field_int.
6590         Change type of "value".
6591         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6592         type of "value".
6593         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6594         do_field_int.  Change type of "value".
6595         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6596         do_field_int.  Change type of "value".
6597         * tracepoint.c (trace_status_mi, tfind_1)
6598         (print_one_static_tracepoint_marker): Update.
6599         * thread.c (print_thread_info_1, print_selected_thread_frame):
6600         Update.
6601         * stack.c (print_frame, print_frame_info): Update.
6602         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6603         Update.
6604         * source.c (print_source_lines_base): Update.
6605         * skip.c (info_skip_command): Update.
6606         * record-btrace.c (btrace_ui_out_decode_error)
6607         (btrace_call_history_src_line): Update.
6608         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6609         Update.
6610         * progspace.c (print_program_space): Update.
6611         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6612         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6613         do_field_int.  Change type of "value".
6614         * mi/mi-out.c (mi_ui_out::do_table_begin)
6615         (mi_ui_out::do_table_header): Update.
6616         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6617         type of "value".
6618         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6619         (mi_cmd_data_list_changed_registers, output_register)
6620         (mi_cmd_data_read_memory, mi_load_progress)
6621         (mi_cmd_trace_frame_collected): Update.
6622         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6623         Update.
6624         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6625         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6626         (mi_cmd_var_list_children, varobj_update_one): Update.
6627         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6628         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6629         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6630         * inferior.c (print_inferior): Update.
6631         * gdb_bfd.c (print_one_bfd): Update.
6632         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6633         Update.
6634         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6635         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6636         do_field_int.  Change type of "value".
6637         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6638         do_field_int.  Change type of "value".
6639         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6640         (print_one_breakpoint_location, print_it_catch_fork)
6641         (print_one_catch_fork, print_it_catch_vfork)
6642         (print_one_catch_vfork, print_it_catch_solib)
6643         (print_it_catch_exec, print_it_ranged_breakpoint)
6644         (print_mention_watchpoint, print_mention_masked_watchpoint)
6645         (bkpt_print_it, update_static_tracepoint): Update.
6646         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6647         * break-catch-syscall.c (print_it_catch_syscall): Update.
6648         * ada-tasks.c (print_ada_task_info): Update.
6649         * ada-lang.c (print_it_exception, print_mention_exception):
6650         Update.
6651
6652 2019-07-17  Andrew Burgess  <[email protected]>
6653
6654         PR breakpoints/24541
6655         * gdbarch.c: Regenerate.
6656         * gdbarch.h: Regenerate.
6657         * gdbarch.sh: Adjust return type and parameter types for
6658         'stap_adjust_register'.
6659         (i386_stap_adjust_register): Adjust signature and return new
6660         register name.
6661         * stap-probe.c (stap_parse_register_operand): Adjust use of
6662         'gdbarch_stap_adjust_register'.
6663
6664 2019-07-17  Tom Tromey  <[email protected]>
6665
6666         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6667         declare VEC.
6668         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6669         std::vector.
6670         (struct s390_process_info): Add initializers.
6671         (s390_add_process): Use new.
6672         (s390_linux_nat_target::low_forget_process): Use delete.
6673         (s390_linux_nat_target::low_new_fork)
6674         (s390_linux_nat_target::stopped_by_watchpoint)
6675         (s390_linux_nat_target::low_prepare_to_resume)
6676         (s390_linux_nat_target::insert_watchpoint)
6677         (s390_linux_nat_target::insert_hw_breakpoint)
6678         (s390_linux_nat_target::remove_watchpoint)
6679         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6680
6681 2019-07-16  John Baldwin  <[email protected]>
6682
6683         * aarch64-fbsd-nat.c: Include regcache.h.
6684         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6685         argument.
6686         (aarch64_fbsd_nat_target::fetch_registers)
6687         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6688         variable.
6689         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6690
6691 2019-07-16  John Baldwin  <[email protected]>
6692
6693         * fbsd-nat.c: Include gdbarch.h.
6694
6695 2019-07-15  Tom Tromey  <[email protected]>
6696
6697         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6698
6699 2019-07-15  Tom Tromey  <[email protected]>
6700
6701         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6702         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6703         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6704         * cli-out.c (cli_ui_out::do_field_int): New method.
6705         * ui-out.c (ui_out::field_unsigned): New method.
6706         * symfile.c (generic_load): Use field_unsigned.
6707         (print_transfer_performance): Likewise.
6708         * record-btrace.c (ui_out_field_uint): Remove.
6709         (btrace_call_history_insn_range, btrace_call_history): Use
6710         field_unsigned.
6711         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6712         field_unsigned.
6713         * ui-out.h (class ui_out) <field_unsigned>: New method.
6714         <do_field_unsigned>: Likewise.
6715
6716 2019-07-15  Tom Tromey  <[email protected]>
6717
6718         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6719         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6720         * target.c (flash_erase_command): Use field_string.
6721         * infrun.c (print_signal_received_reason): Use field_string.
6722         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6723         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6724         field_string.
6725         * ada-tasks.c (print_ada_task_info): Use field_string.
6726
6727 2019-07-15  Tom Tromey  <[email protected]>
6728
6729         * target.c (flash_erase_command): Use field_core_addr.
6730         * symfile.c (generic_load): Use field_core_addr.
6731         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6732         Use field_core_addr.
6733         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6734         field_core_addr.
6735
6736 2019-07-12  Andrew Burgess  <[email protected]>
6737
6738         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6739         value if its desired type is smaller than a CORE_ADDR and signed.
6740
6741 2019-07-12  Andrew Burgess  <[email protected]>
6742
6743         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6744         of changes to field names, and use new is_reference field to
6745         decide if a property is a reference or not.
6746         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6747         field.
6748         (struct dwarf2_property_baton): Update header comment, rename
6749         'referenced_type' to 'property_type' and update comments.
6750         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6751         default property type, store in property baton, update to take
6752         accound of renamed field.
6753         (read_func_scope): Update call to attr_to_dynamic_prop.
6754         (read_array_type): Likewise.
6755         (dwarf2_per_cu_addr_sized_int_type): New function.
6756         (read_subrange_index_type): Move type finding code to
6757         dwarf2_per_cu_addr_sized_int_type.
6758         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6759         (dwarf2_per_cu_addr_type): New function.
6760         (set_die_type): Update calls to attr_to_dynamic_prop.
6761
6762 2019-07-12  Andrew Burgess  <[email protected]>
6763
6764         * dwarf2read.c (read_subrange_index_type): New function.
6765         (read_subrange_type): Move code into new function and call it.
6766         * gdbtypes.c (create_range_type): Add some asserts.
6767
6768 2019-07-12  Andrew Burgess  <[email protected]>
6769
6770         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6771         update return statements.
6772         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6773         declaration, and update comment to match.
6774         * gdbtypes.c (resolve_dynamic_array): Update call to
6775         dwarf2_evaluate_property to match new return type.
6776
6777 2019-07-12  Andrew Burgess  <[email protected]>
6778
6779         * valarith.c (value_subscripted_rvalue): Change lowerbound
6780         parameter type from int to LONGEST.
6781         * value.h (value_subscripted_rvalue): Likewise in declaration.
6782
6783 2019-07-11  Andrew Burgess  <[email protected]>
6784
6785         * cli/cli-utils.c (info_print_command_completer): New function.
6786         * cli/cli-utils.h: Add 'completer.h' include, and forward
6787         declaration for 'struct cmd_list_element'.
6788         (info_print_command_completer): Declare.
6789         * stack.c (_initialize_stack): Add completer for 'info locals' and
6790         'info args'.
6791         * symtab.c (_initialize_symtab): Add completer for 'info
6792         variables' and 'info functions'.
6793         * NEWS: Mention completion for additional info commands.
6794
6795 2019-07-11  Andrew Burgess  <[email protected]>
6796
6797         * cli/cli-utils.c (extract_info_print_args): Delete.
6798         (extract_arg_maybe_quoted): Delete.
6799         (info_print_options_defs): New variable.
6800         (make_info_print_options_def_group): New function.
6801         (extract_info_print_options): Define new function.
6802         * cli/cli-utils.h (extract_info_print_args): Delete.
6803         (struct info_print_options): New structure.
6804         (extract_info_print_options): Declare new function.
6805         * stack.c (info_locals_command): Update to use new
6806         extract_info_print_options, also add a header comment.
6807         (info_args_command): Likewise.
6808         * symtab.c (info_variables_command): Likewise.
6809         (info_functions_command): Likewise.
6810
6811 2019-07-11  Andrew Burgess  <[email protected]>
6812
6813         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6814         to extract string arguments.
6815         * common/common-utils.c (extract_string_maybe_quoted): New function.
6816         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6817
6818 2019-07-11  Tom Tromey  <[email protected]>
6819
6820         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6821         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6822         * top.h (gdbinit): Don't declare.
6823         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6824         into...
6825         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6826         * top.c (gdb_init): Don't call init_cli_cmds.
6827         (gdbinit): Remove.
6828         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6829
6830 2019-07-11  Tom Tromey  <[email protected]>
6831
6832         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6833         after it has been moved.
6834
6835 2019-07-10  Simon Marchi  <[email protected]>
6836
6837         * valops.c (value_must_coerce_to_target): Change return type to
6838         bool.
6839         * value.h (value_must_coerce_to_target): Likewise.
6840
6841 2019-07-10  Simon Marchi  <[email protected]>
6842
6843         * breakpoint.c (is_hardware_watchpoint): Remove
6844         forward-declaration.
6845         (is_masked_watchpoint): Change return type to bool.
6846         (is_tracepoint): Likewise.
6847         (is_breakpoint): Likewise.
6848         (is_hardware_watchpoint): Likewise.
6849         (is_watchpoint): Likewise.
6850         (is_no_memory_software_watchpoint): Likewise.
6851         (is_catchpoint): Likewise.
6852         (breakpoint_1): Make FILTER parameter's return type bool.
6853         is_masked_watchpoint): Change return type to bool.
6854         (save_breakpoints): Make FILTER parameter's return type bool.
6855         * breakpoint.h (is_breakpoint): Change return type to bool.
6856         (is_watchpoint): Likewise.
6857         (is_catchpoint): Likewise.
6858         (is_tracepoint): Likewise.
6859
6860 2019-07-10  Tom Tromey  <[email protected]>
6861
6862         * defs.h: Don't include gdbarch.h.
6863         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6864         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6865         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6866         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6867         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6868         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6869         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6870         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6871         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6872         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6873         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6874         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6875         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6876         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6877         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6878         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6879         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6880         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6881         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6882         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6883         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6884         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6885         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6886         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6887         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6888         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6889         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6890
6891 2019-07-10  Tom Tromey  <[email protected]>
6892
6893         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6894         * breakpoint.c (init_ada_exception_breakpoint): Register as
6895         bp_catchpoint.
6896         (print_one_breakpoint_location, print_one_breakpoint): Use
6897         is_ada_exception_catchpoint.
6898         * ada-lang.c (class ada_catchpoint_location): Pass
6899         bp_loc_software_breakpoint to bp_location constructor.
6900         (is_ada_exception_catchpoint): New function.
6901
6902 2019-07-10  Tom Tromey  <[email protected]>
6903
6904         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6905         VEC.
6906         (struct arm_exidx_entry): New method operator<.
6907         (struct arm_exidx_data) <section_maps>: Change type.
6908         (arm_exidx_data_free): Remove.
6909         (arm_exidx_data_key): Change type.  Move lower.
6910         (arm_exidx_new_objfile): Update.
6911         (arm_compare_exidx_entries): Remove.
6912         (arm_find_exidx_entry, _initialize_arm_tdep)
6913
6914 2019-07-10  Tom Tromey  <[email protected]>
6915
6916         * solib-spu.c (ocl_program_data_key): Change type.
6917         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6918         Update.
6919
6920 2019-07-10  Tom Tromey  <[email protected]>
6921
6922         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6923         (struct solib_aix_inferior_data) <library_list>: Change type.
6924         (solib_aix_inferior_data_handle): Change type.
6925         (get_solib_aix_inferior_data): Update.
6926         (solib_aix_free_library_list): Remove.
6927         (library_list_start_library): Update.
6928         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6929         return type.
6930         (solib_aix_get_library_list)
6931         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6932         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6933
6934 2019-07-10  Tom Tromey  <[email protected]>
6935
6936         * solib-dsbt.c (struct dsbt_info): Add initializers.
6937         (solib_dsbt_pspace_data): Change type.
6938         (dsbt_pspace_data_cleanup): Remove.
6939         (get_dsbt_info, _initialize_dsbt_solib): Update.
6940
6941 2019-07-10  Tom Tromey  <[email protected]>
6942
6943         * spu-tdep.c (spu_overlay_data): Change type.
6944         (spu_get_overlay_table, spu_overlay_new_objfile)
6945         (_initialize_spu_tdep): Update.
6946
6947 2019-07-10  Tom Tromey  <[email protected]>
6948
6949         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6950         destructor.
6951         (dbx_objfile_data_key): Change type and declare later.
6952         (DBX_SYMFILE_INFO): Rewrite.
6953         * dbxread.c (dbx_objfile_data_key): Change type.
6954         (dbx_symfile_init): Update.
6955         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6956         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6957         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6958
6959 2019-07-10  Tom Tromey  <[email protected]>
6960
6961         * jit.c (jit_program_space_key): Change type.  Move lower.
6962         (get_jit_program_space_data): Update.
6963         (jit_program_space_data_cleanup): Remove.
6964         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6965         Update.
6966         (struct jit_program_space_data): Add initializers.
6967
6968 2019-07-10  Tom Tromey  <[email protected]>
6969
6970         * solib-darwin.c (struct darwin_info): Add initializers.
6971         (solib_darwin_pspace_data): Change type.
6972         (darwin_pspace_data_cleanup): Remove.
6973         (get_darwin_info, _initialize_darwin_solib): Update.
6974
6975 2019-07-10  Tom Tromey  <[email protected]>
6976
6977         * remote-sim.c (struct sim_inferior_data): Add initializers,
6978         constructor, and destructor.
6979         (sim_inferior_data_key): Change type.  Move lower.
6980         (check_for_duplicate_sim_descriptor): Update.
6981         (get_sim_inferior_data): Use new.  Update.
6982         (~sim_inferior_data_cleanup): Rename from
6983         sim_inferior_data_cleanup.  Simplify.
6984         (gdbsim_close_inferior, simulator_command)
6985         (sim_command_completer, _initialize_remote_sim): Update.
6986         (next_pid, INITIAL_PID): Move earlier.
6987
6988 2019-07-10  Tom Tromey  <[email protected]>
6989
6990         * python/python-internal.h (create_thread_object): Return
6991         gdbpy_ref.
6992         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6993         * python/py-inferior.c (struct threadlist_entry): Add
6994         constructor.
6995         <thread_obj>: Now a gdbpy_ref.
6996         (thread_to_thread_object): Update.
6997         (add_thread_object): Use new.
6998         (delete_thread_object): Use delete.
6999         (infpy_threads): Update.
7000         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7001         GIL.
7002
7003 2019-07-10  Tom Tromey  <[email protected]>
7004
7005         * valops.c (value_cast): Specialize error message for Ada.
7006
7007 2019-07-10  Simon Marchi  <[email protected]>
7008
7009         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7010
7011 2019-07-10  Simon Marchi  <[email protected]>
7012
7013         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7014         bpstat_should_step): Return bool, adjust comments.
7015         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7016         bpstat_should_step): Likewise.
7017
7018 2019-07-10  Alan Hayward  <[email protected]>
7019
7020         * features/Makefile: Use feature target descriptions for Arm.
7021         * features/arm/arm-core.c: Generate new file.
7022         * features/arm/arm-fpa.c: Likewise.
7023         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7024         * features/arm/arm-m-profile.c: Likewise.
7025         * features/arm/arm-vfpv2.c: Likewise.
7026         * features/arm/arm-vfpv3.c: Likewise.
7027         * features/arm/xscale-iwmmxt.c: Likewise.
7028         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7029
7030 2019-07-10  Alan Hayward  <[email protected]>
7031
7032         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7033         ptrace earlier.
7034
7035 2019-07-10  Alan Hayward  <[email protected]>
7036
7037         * features/aarch64-pauth.c: Regenerate.
7038
7039 2019-07-09  Simon Marchi  <[email protected]>
7040
7041         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7042         bool.
7043         (bpstat_what): Use false instead of 0.
7044
7045 2019-07-09  Pedro Alves  <[email protected]>
7046
7047         * break-catch-throw.c (is_exception_catchpoint): New.
7048         * breakpoint.c (print_one_breakpoint_location): New parameter
7049         'raw_loc'.  Handle it.  Use
7050         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7051         looking at the breakpoint's type.
7052         (print_one_breakpoint): If handling "maint info breakpoints", also
7053         print locations of exception catchpoints.
7054         * breakpoint.h (is_exception_catchpoint): Declare.
7055
7056 2019-07-09  Pedro Alves  <[email protected]>
7057
7058         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7059         "addr" field.
7060         (allocate_location_exception_catchpoint): New.
7061         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7062         (initialize_throw_catchpoint_ops): Install
7063         allocate_location_exception_catchpoint as allocate_location
7064         method.
7065         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7066         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7067         bp_loc_other.
7068         (breakpoint_address_is_meaningful): Delete.
7069         (bl_address_is_meaningful): New.
7070         (breakpoint_locations_match): Adjust comment.
7071         (bp_location_from_bp_type): New, factored out of...
7072         (bp_location::bp_location(breakpoint *)): ... this.
7073         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7074         factored out of...
7075         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7076         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7077         breakpoint_address_is_meaningful.
7078         (bp_locations_compare): Adjust comment.
7079         (update_global_location_list): Use bl_address_is_meaningful
7080         instead of breakpoint_address_is_meaningful.
7081         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7082         explicit.
7083         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7084         * python/py-breakpoint.c (bppy_get_location): No longer check
7085         whether location is null.
7086
7087 2019-07-09  Pedro Alves  <[email protected]>
7088
7089         PR c++/15468
7090         * breakpoint.c (print_one_breakpoint_location): Remove
7091         single-location assert.
7092
7093 2019-07-09  Tom Tromey  <[email protected]>
7094
7095         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7096         * configure: Rebuild.
7097         * configure.ac: Change common to gdbsupport.
7098         * gdbsupport: Rename from common.
7099         * acinclude.m4: Change common to gdbsupport.
7100         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7101         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7102         gdbsupport.
7103         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7104         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7105         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7106         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7107         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7108         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7109         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7110         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7111         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7112         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7113         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7114         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7115         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7116         coff-pe-read.c, command.h, compile/compile-c-support.c,
7117         compile/compile-c.h, compile/compile-cplus-symbols.c,
7118         compile/compile-cplus-types.c, compile/compile-cplus.h,
7119         compile/compile-loc2c.c, compile/compile.c, completer.c,
7120         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7121         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7122         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7123         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7124         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7125         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7126         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7127         features/aarch64-core.c, features/aarch64-fpu.c,
7128         features/aarch64-pauth.c, features/aarch64-sve.c,
7129         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7130         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7131         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7132         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7133         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7134         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7135         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7136         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7137         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7138         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7139         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7140         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7141         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7142         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7143         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7144         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7145         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7146         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7147         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7148         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7149         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7150         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7151         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7152         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7153         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7154         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7155         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7156         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7157         minsyms.c, mips-linux-tdep.c, namespace.h,
7158         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7159         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7160         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7161         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7162         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7163         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7164         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7165         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7166         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7167         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7168         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7169         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7170         procfs.c, producer.c, progspace.h, psymtab.h,
7171         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7172         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7173         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7174         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7175         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7176         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7177         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7178         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7179         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7180         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7181         target-memory.c, target.c, target.h, target/waitstatus.c,
7182         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7183         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7184         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7185         unittests/array-view-selftests.c,
7186         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7187         unittests/common-utils-selftests.c,
7188         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7189         unittests/format_pieces-selftests.c,
7190         unittests/function-view-selftests.c,
7191         unittests/lookup_name_info-selftests.c,
7192         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7193         unittests/mkdir-recursive-selftests.c,
7194         unittests/observable-selftests.c,
7195         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7196         unittests/parse-connection-spec-selftests.c,
7197         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7198         unittests/scoped_fd-selftests.c,
7199         unittests/scoped_mmap-selftests.c,
7200         unittests/scoped_restore-selftests.c,
7201         unittests/string_view-selftests.c, unittests/style-selftests.c,
7202         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7203         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7204         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7205         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7206         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7207         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7208
7209 2019-07-09  Andrew Burgess  <[email protected]>
7210
7211         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7212         bool value.
7213         (decode_digits_ordinary): Set explicit_line field in sal.
7214         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7215         symtab_and_line that was set on an explicit line number in
7216         assembler code.  Do always update the recorded symtab and line if
7217         we do skip the prologue.
7218
7219 2019-07-09  Andrew Burgess  <[email protected]>
7220
7221         * breakpoint.c (set_breakpoint_location_function): Remove
7222         explicit_loc parameter.
7223         (momentary_breakpoint_from_master): Update call to
7224         set_breakpoint_location_function.
7225         (add_location_to_breakpoint): Likewise.
7226
7227 2019-07-09  Andrew Burgess  <[email protected]>
7228
7229         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7230         required features based on default bfd type when no specific bfd
7231         is present.
7232
7233 2019-07-08  Philippe Waroquiers  <[email protected]>
7234
7235         * NEWS: Mention that GDB printf and eval commands can now print
7236         C-style and Ada-style convenience var strings without
7237         calling the inferior.
7238         * printcmd.c (printf_c_string): Locally print GDB internal var
7239         instead of transiting via the inferior.
7240         (printf_wide_c_string): Likewise.
7241
7242 2019-07-04  Alan Hayward  <[email protected]>
7243
7244         PR breakpoints/25011
7245         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7246
7247 2019-07-04  Tom Tromey  <[email protected]>
7248
7249         PR tui/24724:
7250         * tui/tui-winsource.c (tui_clear_source_content): Update.
7251         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7252         (tui_update_breakpoint_info): Update.
7253         (tui_set_exec_info_content): Update.
7254         * tui/tui-source.c (tui_set_source_content_nil): Update.
7255         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7256         has_break.
7257         * tui/tui-data.h (enum tui_bp_flag): New.
7258         (tui_bp_flags): New enum flags type.
7259         (struct tui_source_element) <break_mode>: Change type.  Rename
7260         from has_break.
7261         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7262         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7263         constants.
7264         * tui/tui-winsource.h: Fix comment.
7265
7266 2019-07-04  Alan Hayward  <[email protected]>
7267
7268         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7269         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7270         (store_fpregs_to_thread)
7271         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7272         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7273         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7274         (IWMMXT_REGS_SIZE): Add define.
7275         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7276         (fetch_vfp_regs, store_vfp_regs)
7277         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7278         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7279
7280 2019-07-04  Alan Hayward  <[email protected]>
7281
7282         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7283         defines.
7284         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7285         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7286         (ARM_INT_REGISTER_SIZE): ...to this.
7287         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7288         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7289         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7290         (arm_linux_collect_gregset, supply_nwfpe_register)
7291         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7292         defines.
7293         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7294         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7295         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7296         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7297         (arm_return_in_memory, arm_store_return_value)
7298         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7299         (arm_record_ld_st_multiple): Likewise.
7300         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7301         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7302
7303 2019-07-04  Alan Hayward  <[email protected]>
7304
7305         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7306         AARCH64_DISPLACED_MODIFIED_INSNS.
7307         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7308         (aarch64_displaced_step_copy_insn): Likewise.
7309         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7310         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7311         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7312         ARM_DISPLACED_MODIFIED_INSNS.
7313         * arm-tdep.c (arm_gdbarch_init): Likewise.
7314         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7315         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7316         (struct arm_displaced_step_closure): Use
7317         ARM_DISPLACED_MODIFIED_INSNS.
7318
7319 2019-07-04  Alan Hayward  <[email protected]>
7320
7321         * features/Makefile: Remove unused xml files.
7322         * features/aarch64.xml: Remove.
7323         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7324         * features/i386/amd64-avx-avx512.xml: Remove.
7325         * features/i386/amd64-avx-linux.xml: Remove.
7326         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7327         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7328         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7329         * features/i386/amd64-avx-mpx.xml: Remove.
7330         * features/i386/amd64-avx.xml: Remove.
7331         * features/i386/amd64-linux.xml: Remove.
7332         * features/i386/amd64-mpx-linux.xml: Remove.
7333         * features/i386/amd64-mpx.xml: Remove.
7334         * features/i386/amd64.xml: Remove.
7335         * features/i386/i386-avx-avx512-linux.xml: Remove.
7336         * features/i386/i386-avx-avx512.xml: Remove.
7337         * features/i386/i386-avx-linux.xml: Remove.
7338         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7339         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7340         * features/i386/i386-avx-mpx-linux.xml: Remove.
7341         * features/i386/i386-avx-mpx.xml: Remove.
7342         * features/i386/i386-avx.xml: Remove.
7343         * features/i386/i386-linux.xml: Remove.
7344         * features/i386/i386-mmx-linux.xml: Remove.
7345         * features/i386/i386-mmx.xml: Remove.
7346         * features/i386/i386-mpx-linux.xml: Remove.
7347         * features/i386/i386-mpx.xml: Remove.
7348         * features/i386/i386.xml: Remove.
7349         * features/i386/x32-avx-avx512-linux.xml: Remove.
7350         * features/i386/x32-avx-linux.xml: Remove.
7351         * features/i386/x32-linux.xml: Remove.
7352
7353 2019-07-04  Alan Hayward  <[email protected]>
7354
7355         * regformats/aarch64.dat: Remove.
7356         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7357         * regformats/i386/amd64-avx-linux.dat: Remove.
7358         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7359         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7360         * regformats/i386/amd64-linux.dat: Remove.
7361         * regformats/i386/amd64-mpx-linux.dat: Remove.
7362         * regformats/i386/amd64.dat: Remove.
7363         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7364         * regformats/i386/i386-avx-linux.dat: Remove.
7365         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7366         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7367         * regformats/i386/i386-linux.dat: Remove.
7368         * regformats/i386/i386-mmx-linux.dat: Remove.
7369         * regformats/i386/i386-mpx-linux.dat: Remove.
7370         * regformats/i386/i386.dat: Remove.
7371         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7372         * regformats/i386/x32-avx-linux.dat: Remove.
7373         * regformats/i386/x32-linux.dat: Remove.
7374
7375 2019-07-04  Alan Hayward  <[email protected]>
7376
7377         * aarch64-tdep.c: Remove xml self tests.
7378         * amd64-linux-tdep.c: Likewise.
7379         * amd64-tdep.c: Likewise.
7380         * i386-linux-tdep.c: Likewise.
7381         * i386-tdep.c: Likewise.
7382
7383 2019-07-03  Pedro Alves  <[email protected]>
7384
7385         PR cli/24732
7386         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7387         (pipe_cmd_option_defs): New.
7388         (make_pipe_cmd_options_def_group): New.
7389         (pipe_command): Use gdb::option::process_options.
7390         (pipe_command_completer): New function.
7391         (_initialize_cli_cmds): Install completer for "pipe" command.
7392
7393 2019-07-03  Pedro Alves  <[email protected]>
7394
7395         * cli/cli-option.c (union option_value) <string>: New field.
7396         (struct option_def_and_value): Add ctor, move ctor, dtor and
7397         use DISABLE_COPY_AND_ASSIGN.
7398         (option_def_and_value::clear_value): New.
7399         (parse_option, save_option_value_in_ctx, get_val_type_str)
7400         (add_setshow_cmds_for_options): Handle var_string.
7401         * cli-option.h (union option_def::var_address) <string>: New
7402         field.
7403         (struct string_option_def): New.
7404         * maint-test-options.c (struct test_options_opts): Add default
7405         ctor and use DISABLE_COPY_AND_ASSIGN.
7406         <string_opt>: New field.
7407         (test_options_opts::~test_options_opts): New.
7408         (test_options_opts::dump): Also dump "-string".
7409         (test_options_option_defs): Install "string.
7410
7411 2019-07-03  Pedro Alves  <[email protected]>
7412
7413         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7414         option_value with a null enumeration.
7415         (complete_options): Save the option values in the context.
7416         (save_option_value_in_ctx): New, factored out from ...
7417         (process_options): ... here.
7418         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7419         of the function.
7420         * maint-test-options.c (test_options_opts::dump): New, factored
7421         out from ...
7422         (maintenance_test_options_command_mode): ... here.
7423         (maintenance_test_options_command_completion_result): Delete.
7424         (maintenance_test_options_command_completion_text): Update
7425         comment.
7426         (maintenance_show_test_options_completion_result): Change
7427         prototype.  Just print
7428         maintenance_test_options_command_completion_text.
7429         (save_completion_result): New.
7430         (maintenance_test_options_completer_mode): Pass options context to
7431         complete_options, and then save a dump.
7432         (_initialize_maint_test_options): Use add_cmd to install "maint
7433         show test-options-completion-result".
7434
7435 2019-07-03  Pedro Alves  <[email protected]>
7436
7437         * NEWS (New commands): Mention "with" and "maint with".
7438         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7439         (with_command, with_command_completer): New.
7440         (pipe_command): Adjust to new repeat_previous
7441         interface.
7442         (_initialize_cli_cmds): Install the "with" command and its "w"
7443         alias.
7444         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7445         declarations.
7446         * cli/cli-setshow.c (parse_cli_var_uinteger)
7447         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7448         argument strings for all var_types.
7449         (get_setshow_command_value_string): New, factored out from ...
7450         (do_show_command): ... this.
7451         * cli/cli-setshow.h: Include <string>.
7452         (get_setshow_command_value_string): Declare.
7453         * command.h (repeat_previous): Now returns const char *.  Adjust
7454         comment.
7455         * maint.c: Include "cli/cli-cmds.h".
7456         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7457         (_initialize_maint_cmds): Register the "maintenance with" command.
7458         * top.c (repeat_previous): Move bits from pipe_command here:
7459         Return the saved command line, if any; error out if there's no
7460         command to relaunch.
7461
7462 2019-07-03  Pedro Alves  <[email protected]>
7463
7464         * NEWS (New commands): Mention "maint set/show test-settings"
7465         instead of "maint test-settings".
7466         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7467         (maintenance_test_settings_set_list): Rename to ...
7468         (maintenance_set_test_settings_list): ... this.
7469         (maintenance_test_settings_show_list): Rename to  ...
7470         (maintenance_show_test_settings_list): ... this.
7471         (maintenance_test_settings_cmd): Delete.
7472         (maintenance_test_settings_set_cmd): ...
7473         (maintenance_set_test_settings_cmd): ... this.
7474         (maintenance_test_settings_show_cmd): ...
7475         (maintenance_show_test_settings_cmd): ... this.
7476         (maintenance_test_settings_show_value_cmd):
7477         (maintenance_show_test_settings_value_cmd): ... this.
7478         (_initialize_maint_test_settings): No longer install the "maint
7479         test-settings" prefix command.  Rename "maint test-settings set"
7480         to "maint set test-settings", and "maint test-settings show" to
7481         "maint show test-settings".  Adjust all subcommands.
7482
7483 2019-07-03  Pedro Alves  <[email protected]>
7484
7485         * maint-test-settings.c: Fix file's intro comment.  Replace all
7486         references to "test-options" with references to "test-settings",
7487         in comments.
7488
7489 2019-07-03  Pedro Alves  <[email protected]>
7490
7491         * maint-test-settings.c (maintenance_test_settings_xxx)
7492         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7493         New.
7494         (maintenance_test_settings_enums): Use them.
7495         (maintenance_test_settings_enum): Default to
7496         maintenance_test_settings_xxx.
7497         (_initialize_maint_test_settings): Initialize
7498         MAINTENANCE_TEST_SETTINGS_FILENAME.
7499
7500 2019-07-02  Simon Marchi  <[email protected]>
7501
7502         * breakpoint.h (remove_breakpoints_inf): Change return type to
7503         void, move function documentation here.
7504         * breakpoint.c (remove_breakpoints_inf): Change return type to
7505         void, move function documentation to header.
7506
7507 2019-07-02  Pedro Alves  <[email protected]>
7508
7509         * NEWS (Completion improvements): Mention "info threads".
7510         * thread.c (struct info_threads_opts, info_threads_option_defs)
7511         (make_info_threads_options_def_group): New.
7512         (info_threads_command): Use gdb::option::process_options.
7513         (info_threads_command_completer): New.
7514         (_initialize_thread): Use gdb::option::build_help to build the
7515         help text for "info threads".
7516
7517 2019-07-02  Simon Marchi  <[email protected]>
7518
7519         * defs.h (generic_load): Move from here...
7520         * symfile.h (generic_load): ... to here.  Rename name parameter
7521         to args.
7522         * symfile.c (generic_load): Add comment.
7523
7524 2019-07-01  Tom Tromey  <[email protected]>
7525
7526         * dwarf2read.c
7527         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7528         declaration of without_params.  Fix formatting.
7529
7530 2019-07-01  Tom Tromey  <[email protected]>
7531
7532         * ada-exp.y (find_primitive_type): Update.
7533         * ada-lang.h (ada_lookup_symbol): Update.
7534         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7535         parameter.
7536         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7537
7538 2019-06-28  Sergio Durigan Junior  <[email protected]>
7539
7540         PR breakpoints/24541
7541         * gdbarch.c: Regenerate.
7542         * gdbarch.h: Regenerate.
7543         * gdbarch.sh: Add 'stap_adjust_register'.
7544         * i386-tdep.c: Include '<unordered_set>'.
7545         (i386_stap_adjust_register): New function.
7546         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7547         * stap-probe.c (stap_parse_register_operand): Call
7548         'gdbarch_stap_adjust_register'.
7549
7550 2019-06-28  Sergio Durigan Junior  <[email protected]>
7551
7552         PR python/24742
7553         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7554         * python/python.c (do_start_initialization): Use 'xmalloc'
7555         instead of 'PyMem_Malloc'.
7556
7557 2019-06-28  Tom Tromey  <[email protected]>
7558
7559         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7560         for Ada.
7561
7562 2019-06-27  Tom Tromey  <[email protected]>
7563
7564         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7565         objfile_key.
7566         (arm_find_mapping_symbol, arm_record_special_symbol)
7567         (_initialize_arm_tdep): Update.
7568         (arm_objfile_data_free): Remove.
7569
7570 2019-06-27  Tom Tromey  <[email protected]>
7571
7572         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7573         to cp_print_static_field.
7574
7575 2019-06-26  Tom Tromey  <[email protected]>
7576
7577         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7578         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7579         declare.
7580
7581 2019-06-26  Alan Hayward  <[email protected]>
7582
7583         * features/aarch64-core.c (create_feature_aarch64_core):
7584         Regenerate.
7585         * features/aarch64-core.xml: Add cpsr flags.
7586
7587 2019-06-26  Alan Hayward  <[email protected]>
7588
7589         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7590         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7591
7592 2019-06-25  Simon Marchi  <[email protected]>
7593
7594         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7595         field.
7596         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7597         use.
7598         (arm_record_special_symbol): Don't insert new symbol in sorted
7599         position, push it at the end.
7600
7601 2019-06-25  Simon Marchi  <[email protected]>
7602
7603         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7604         (arm_mapping_symbol_s): Remove.
7605         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7606         (arm_mapping_symbol_vec): New typedef.
7607         (struct arm_per_objfile): Add constructor.
7608         <section_maps>: Change type to
7609         std::unique_ptr<arm_mapping_symbol_vec[]>.
7610         (arm_compare_mapping_symbols): Remove.
7611         (arm_find_mapping_symbol): Adjust to section_maps type change.
7612         (arm_objfile_data_free): Call delete on arm_per_objfile.
7613         (arm_record_special_symbol): Adjust to section_maps type change.
7614         Allocate arm_per_objfile with new.
7615
7616 2019-06-25  Philippe Waroquiers  <[email protected]>
7617
7618         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7619         with the command prefix.
7620
7621 2019-06-25  Tom Tromey  <[email protected]>
7622
7623         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7624         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7625
7626 2019-06-25  Tom Tromey  <[email protected]>
7627
7628         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7629         type.
7630         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7631         protected.
7632
7633 2019-06-25  Tom Tromey  <[email protected]>
7634
7635         * tui/tui-winsource.c
7636         (tui_source_window_base::set_is_exec_point_at): Add check against
7637         LOA_ADDRESS.
7638
7639 2019-06-25  Tom Tromey  <[email protected]>
7640
7641         * tui/tui-source.c (tui_set_source_content): Don't check before
7642         xfree.
7643         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7644
7645 2019-06-25  Tom Tromey  <[email protected]>
7646
7647         * tui/tui-winsource.h (tui_update_source_window_as_is)
7648         (tui_alloc_source_buffer, tui_line_is_displayed)
7649         (tui_addr_is_displayed): Change type of win_info.
7650         * tui/tui-winsource.c (tui_update_source_window_as_is)
7651         (tui_clear_source_content, tui_show_source_line)
7652         (tui_show_source_content, tui_source_window_base::refill)
7653         (tui_source_window_base::set_is_exec_point_at)
7654         (tui_source_window_base::set_is_exec_point_at)
7655         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7656         (tui_alloc_source_buffer, tui_line_is_displayed)
7657         (tui_addr_is_displayed): Change type of win_info.  Update.
7658         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7659         (tui_source_window_base::do_make_visible_with_new_height):
7660         Update.
7661         * tui/tui-source.c (tui_set_source_content)
7662         (tui_set_source_content_nil)
7663         (tui_source_window::do_scroll_vertical): Update.
7664         * tui/tui-layout.c (show_layout): Update.
7665         * tui/tui-disasm.c (tui_set_disassem_content)
7666         (tui_disasm_window::do_scroll_vertical): Update.
7667         * tui/tui-data.h (tui_win_content): Remove.
7668         (struct tui_gen_win_info) <content, content_size>: Remove.
7669         (struct tui_source_element): Add initializers and destructor.
7670         (union tui_which_element, struct tui_win_element): Remove.
7671         (struct tui_source_window_base) <content>: New field.
7672         (struct tui_data_window): Remove destructor.
7673         (tui_alloc_content, tui_free_win_content)
7674         (tui_free_all_source_wins_content): Don't declare.
7675         * tui/tui-data.c (tui_initialize_static_data): Update.
7676         (init_content_element, tui_alloc_content): Remove.
7677         (~tui_gen_win_info): Update.
7678         (~tui_data_window, tui_free_all_source_wins_content)
7679         (tui_free_win_content, free_content, free_content_elements):
7680         Remove.
7681
7682 2019-06-25  Tom Tromey  <[email protected]>
7683
7684         * tui/tui-winsource.h (tui_clear_source_content)
7685         (tui_erase_source_content, tui_show_source_content): Change type
7686         of win_info.
7687         * tui/tui-winsource.c (tui_clear_source_content)
7688         (tui_erase_source_content, tui_show_source_content): Change type
7689         of win_info.
7690         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7691         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7692         win_info.
7693         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7694         win_info.
7695         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7696
7697 2019-06-25  Tom Tromey  <[email protected]>
7698
7699         * tui/tui-winsource.c (tui_clear_source_content)
7700         (tui_source_window_base::set_is_exec_point_at): Update.
7701         * tui/tui-source.c (tui_set_source_content_nil): Update.
7702         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7703         a bool.
7704         * tui/tui-data.c (init_content_element): Update.
7705
7706 2019-06-25  Tom Tromey  <[email protected]>
7707
7708         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7709         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7710         * tui/tui-layout.c (init_and_make_win): Update.
7711         * tui/tui.h (enum tui_win_type): Update.
7712         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7713         tui_win_is_auxillary.
7714         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7715         tui_win_is_auxillary.
7716
7717 2019-06-25  Tom Tromey  <[email protected]>
7718
7719         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7720         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7721         (tui_delete_data_content_windows, tui_display_all_data)
7722         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7723         Update.
7724         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7725         * tui/tui-regs.c (tui_last_regs_line_no)
7726         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7727         (tui_show_registers): Update.
7728         (tui_show_register_group): Return void.  Update.
7729         (tui_display_registers_from, tui_display_reg_element_at_line)
7730         (tui_display_registers_from_line, tui_check_register_values):
7731         Update.
7732         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7733         member.
7734         (struct tui_data_window) <regs_content>: Now a std::vector.
7735         <regs_content_count>: Remove.
7736         (tui_add_content_elements, tui_free_data_content): Don't declare.
7737         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7738         (init_content_element): Remove DATA_WIN case.  Add assert.
7739         (tui_add_content_elements): Remove.
7740         (tui_data_window): Update.
7741         (tui_free_data_content): Remove.
7742         (free_content_elements): Remove DATA_WIN case.
7743
7744 2019-06-25  Tom Tromey  <[email protected]>
7745
7746         * tui/tui-data.c (tui_data_item_window): Update.
7747         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7748         * tui/tui-windata.c (tui_display_all_data)
7749         (tui_display_data_from_line): Update.
7750         (tui_check_data_values): Remove.
7751         * tui/tui-regs.c (tui_show_register_group)
7752         (tui_display_reg_element_at_line): Update.
7753         * tui/tui-hooks.c (tui_register_changed)
7754         (tui_refresh_frame_and_register_information): Call
7755         tui_check_register_values.
7756         * tui/tui-data.h (struct tui_data_window) <data_content,
7757         data_content_count, data_type>: Remove.
7758         (enum tui_data_type): Remove.
7759
7760         * tui/tui-data.c (tui_data_window::clear_detail)
7761         (~tui_data_window): Update.
7762
7763 2019-06-25  Tom Tromey  <[email protected]>
7764
7765         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7766         declare.
7767         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7768         Rename from tui_first_data_item_displayed.  Update.
7769         (tui_data_window::refresh_all)
7770         (tui_data_window::do_scroll_vertical): Update.
7771         * tui/tui-data.h (struct tui_data_window)
7772         <first_data_item_displayed>: Declare new method.
7773
7774 2019-06-25  Tom Tromey  <[email protected]>
7775
7776         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7777         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7778         contents...
7779         (tui_initialize_static_data): ...here.
7780
7781 2019-06-25  Tom Tromey  <[email protected]>
7782
7783         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7784         (tui_display_registers_from, tui_check_register_values): Update.
7785         (tui_display_register): Remove win_info parameter; update.
7786         (tui_get_register): Change type of parameters.
7787         * tui/tui-data.h (struct tui_data_element): Remove.
7788         (union tui_which_element) <data>: Remove.
7789         <data_window>: Change type.
7790         (struct tui_data_item_window): New.
7791         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7792         case.  Add assert.
7793         (~tui_data_item_window): New destructor.
7794         (free_content_elements): Remove DATA_ITEM_WIN case.
7795
7796 2019-06-25  Tom Tromey  <[email protected]>
7797
7798         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7799         Remove.
7800
7801 2019-06-25  Tom Tromey  <[email protected]>
7802
7803         * tui/tui-data.h (struct tui_command_element): Remove.
7804         (union tui_which_element) <command>: Remove.
7805         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7806         assert.
7807         (free_content_elements): Remove CMD_WIN case.
7808
7809 2019-06-25  Tom Tromey  <[email protected]>
7810
7811         * tui/tui-layout.c (tui_set_layout): Update.
7812         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7813         * tui/tui-data.c (layout_def): Update.
7814
7815 2019-06-25  Tom Tromey  <[email protected]>
7816
7817         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7818         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7819         (tui_source_window_base::set_new_height): Update.
7820         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7821         Update.
7822         (tui_set_locator_fullname, tui_set_locator_info)
7823         (tui_show_frame_info): Update.
7824         * tui/tui-source.c (tui_set_source_content)
7825         (tui_source_is_displayed): Update.
7826         * tui/tui-layout.c (show_source_disasm_command, show_data)
7827         (show_source_or_disasm_and_command): Update.
7828         * tui/tui-disasm.c (tui_set_disassem_content)
7829         (tui_get_begin_asm_address): Update.
7830         * tui/tui-data.h (struct tui_locator_element): Remove.
7831         (union tui_which_element) <locator>: Remove.
7832         (struct tui_locator_window): New.
7833         (tui_locator_win_info_ptr): Change return type.
7834         * tui/tui-data.c (_locator): Change type.
7835         (tui_locator_win_info_ptr): Change return type.
7836         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7837         (tui_alloc_content): Add assert.
7838
7839 2019-06-25  Tom Tromey  <[email protected]>
7840
7841         * tui/tui-winsource.c
7842         (tui_exec_info_window::maybe_allocate_content): New method.
7843         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7844         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7845         (make_source_or_disasm_window): Add cast.
7846         * tui/tui-data.h (union tui_which_element) <simple_string>:
7847         Remove.
7848         (struct tui_source_info): New.
7849         (struct tui_source_window_base) <execution_info>: Change type.
7850         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7851         case, and add assert.
7852         (tui_alloc_content): Add assert.
7853
7854 2019-06-25  Tom Tromey  <[email protected]>
7855
7856         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7857         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7858         * tui/tui-data.c (tui_alloc_win_info): Remove.
7859
7860 2019-06-25  Tom Tromey  <[email protected]>
7861
7862         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7863         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7864         can_highlight.
7865
7866 2019-06-25  Tom Tromey  <[email protected]>
7867
7868         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7869         make_visible_with_new_height method.
7870         (tui_win_info::make_visible_with_new_height): New method.
7871         (tui_source_window_base::do_make_visible_with_new_height)
7872         (tui_data_window::do_make_visible_with_new_height)
7873         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7874         (make_visible_with_new_height): Remove.
7875         (tui_resize_all, tui_adjust_win_heights): Use
7876         make_visible_with_new_height method.
7877         * tui/tui-data.h (struct tui_win_info)
7878         <do_make_visible_with_new_height, make_visible_with_new_height>:
7879         New methods.
7880         (struct tui_source_window_base, struct tui_data_window)
7881         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7882         methods.
7883
7884 2019-06-25  Tom Tromey  <[email protected]>
7885
7886         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7887         method.
7888         (update_tab_width): Call update_tab_width method.
7889         * tui/tui-data.h (struct tui_win_info)
7890         (struct tui_source_window_base) <update_tab_width>: New methods.
7891
7892 2019-06-25  Tom Tromey  <[email protected]>
7893
7894         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7895         parameter.
7896         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7897         parameter.
7898         (tui_gen_win_info::make_visible): Update.
7899         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7900         parameter.
7901         * tui/tui-data.h (enum tui_box): New enum.
7902         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7903
7904 2019-06-25  Tom Tromey  <[email protected]>
7905
7906         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7907         init_and_make_win for EXEC_INFO_WIN.
7908         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7909         longer inline.
7910         (struct tui_win_info) <~tui_win_info>: Inline.
7911         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7912         Don't declare.
7913         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7914         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7915         Remove.
7916         (tui_initialize_static_data): Update.
7917         (~tui_gen_win_info): Handle more cleanup here.
7918         (~tui_source_window_base): Delete "execution_info".
7919         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7920
7921 2019-06-25  Tom Tromey  <[email protected]>
7922
7923         * tui/tui-layout.c (make_command_window): Don't set
7924         can_highlight.
7925         (show_source_disasm_command): Call the reset method.
7926         (show_data): Don't set can_highlight.  Call the reset method.
7927         (tui_gen_win_info::reset): Rename from init_gen_win_info
7928         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7929         (show_source_or_disasm_and_command): Call the reset method.
7930         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7931         (struct tui_cmd_window): Set can_highlight.
7932
7933 2019-06-25  Tom Tromey  <[email protected]>
7934
7935         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7936         from make_visible.
7937         (tui_make_visible, tui_make_invisible): Rewrite.
7938         (tui_win_info::make_visible): Remove.
7939         (tui_source_window_base::make_visible): Update.
7940         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7941         method.  Moved from...
7942         (struct tui_win_info) <make_visible>: ...here.
7943
7944 2019-06-25  Tom Tromey  <[email protected]>
7945
7946         * tui/tui-winsource.c
7947         (tui_source_window_base::do_scroll_horizontal): Remove direction
7948         parameter.
7949         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7950         direction parameter.
7951         * tui/tui-win.c (tui_win_info::forward_scroll)
7952         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7953         (tui_win_info::right_scroll): Update.
7954         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7955         direction parameter.
7956         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7957         direction parameter.
7958         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7959         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7960         Remove direction parameter.
7961         (struct tui_source_window_base, struct tui_source_window)
7962         (struct tui_disasm_window, struct tui_data_window)
7963         (struct tui_cmd_window): Update.
7964
7965 2019-06-25  Tom Tromey  <[email protected]>
7966
7967         * tui/tui-winsource.h (tui_set_exec_info_content)
7968         (tui_show_exec_info_content, tui_erase_exec_info_content)
7969         (tui_clear_exec_info_content, tui_update_exec_info): Change
7970         argument to tui_source_window_base.
7971         * tui/tui-winsource.c (tui_set_exec_info_content)
7972         (tui_show_exec_info_content, tui_erase_exec_info_content)
7973         (tui_clear_exec_info_content, tui_update_exec_info): Change
7974         argument to tui_source_window_base.
7975
7976 2019-06-25  Tom Tromey  <[email protected]>
7977
7978         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7979         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7980
7981 2019-06-25  Tom Tromey  <[email protected]>
7982
7983         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7984         check.
7985
7986 2019-06-25  Tom Tromey  <[email protected]>
7987
7988         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7989         type to void.
7990         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7991         type to void.
7992         * tui/tui-source.c (tui_set_source_content): Update.
7993         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7994
7995 2019-06-25  Tom Tromey  <[email protected]>
7996
7997         * tui/tui-win.c (window_name_completer, tui_set_focus)
7998         (tui_all_windows_info): Use name method.
7999         * tui/tui-data.h (struct tui_gen_win_info)
8000         (struct tui_source_window, struct tui_disasm_window)
8001         (struct tui_data_window, struct tui_cmd_window) <name>: New
8002         method.
8003         (tui_win_name): Don't declare.
8004         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8005         (tui_win_name): Remove.
8006
8007 2019-06-25  Tom Tromey  <[email protected]>
8008
8009         * tui/tui-winsource.h (tui_update_source_window)
8010         (tui_update_source_window_as_is): Change parameter type.
8011         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8012         to be a tui_source_window_base.
8013         (tui_update_source_window_as_is): Likewise.
8014         * tui/tui-win.c (make_visible_with_new_height): Update.
8015
8016 2019-06-25  Tom Tromey  <[email protected]>
8017
8018         * tui/tui-winsource.c (tui_erase_source_content)
8019         (tui_show_source_content, tui_show_exec_info_content)
8020         (tui_erase_exec_info_content): Use refresh_window method.
8021         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8022         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8023         from tui_refresh_win.
8024         (tui_data_window::refresh_window): New method.
8025         (tui_win_info::refresh, tui_source_window_base::refresh)
8026         (tui_refresh_all): Use refresh_window method.
8027         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8028         method.
8029         * tui/tui-regs.c (tui_display_register): Call refresh_window
8030         method.
8031         * tui/tui-layout.c (show_source_disasm_command)
8032         (show_source_or_disasm_and_command): Call refresh_window method.
8033         * tui/tui-data.h (struct tui_gen_win_info)
8034         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8035         New method.
8036
8037 2019-06-25  Tom Tromey  <[email protected]>
8038
8039         * tui/tui.c (tui_rl_other_window, tui_enable)
8040         (tui_is_window_visible, tui_get_command_dimension): Update.
8041         * tui/tui-winsource.c (tui_update_source_window_as_is)
8042         (tui_clear_source_content, tui_erase_source_content)
8043         (tui_show_source_line, tui_source_window_base::refill)
8044         (tui_source_window_base::do_scroll_horizontal)
8045         (tui_source_window_base::set_is_exec_point_at)
8046         (tui_update_breakpoint_info, tui_set_exec_info_content)
8047         (tui_alloc_source_buffer, tui_line_is_displayed)
8048         (tui_addr_is_displayed): Update.
8049         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8050         (tui_check_and_display_highlight_if_needed)
8051         (tui_win_info::make_visible, tui_win_info::refresh)
8052         (tui_refresh_all): Update.
8053         * tui/tui-windata.c (tui_first_data_item_displayed)
8054         (tui_delete_data_content_windows, tui_erase_data_content)
8055         (tui_display_all_data, tui_data_window::refresh_all)
8056         (tui_check_data_values): Update.
8057         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8058         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8059         (tui_win_info::backward_scroll, tui_refresh_all_win)
8060         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8061         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8062         (tui_source_window_base::set_new_height)
8063         (tui_data_window::set_new_height)
8064         (make_invisible_and_set_new_height)
8065         (make_visible_with_new_height, new_height_ok)
8066         (parse_scrolling_args): Update.
8067         * tui/tui-stack.c (tui_show_frame_info): Update.
8068         * tui/tui-source.c (tui_set_source_content)
8069         (tui_set_source_content_nil, tui_source_is_displayed)
8070         (tui_source_window::do_scroll_vertical): Update.
8071         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8072         (tui_display_registers_from, tui_display_reg_element_at_line)
8073         (tui_check_register_values, tui_reg_command): Update.
8074         * tui/tui-layout.c (tui_default_win_height)
8075         (show_source_disasm_command, show_data, init_and_make_win)
8076         (show_source_or_disasm_and_command): Update.
8077         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8078         (tui_redisplay_readline, tui_mld_flush)
8079         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8080         (tui_getc): Update.
8081         * tui/tui-disasm.c (tui_set_disassem_content)
8082         (tui_disasm_window::do_scroll_vertical): Update.
8083         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8084         Now virtual.
8085         (struct tui_win_info): Derive from tui_gen_win_info.
8086         <~tui_win_info>: Mark as override.
8087         <generic>: Remove member.
8088         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8089         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8090         (~tui_data_window, ~tui_win_info)
8091         (tui_free_all_source_wins_content): Update.
8092         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8093
8094 2019-06-25  Tom Tromey  <[email protected]>
8095
8096         * tui/tui-layout.c (init_and_make_win): Use new.
8097         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8098         destructor, initializers.
8099         (tui_alloc_generic_win_info): Don't declare.
8100         * tui/tui-data.c (_locator): Add argument to constructor.
8101         (source_win, disasm_win): New globals.
8102         (exec_info): Remove.
8103         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8104         Update.
8105         (tui_alloc_generic_win_info): Remove.
8106         (init_content_element): Use new.
8107         (tui_win_info::tui_win_info): Update.
8108         (free_content_elements) <case DATA_WIN>: Use delete.
8109
8110 2019-06-25  Tom Tromey  <[email protected]>
8111
8112         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8113         * tui/tui-windata.c (tui_first_data_item_displayed)
8114         (tui_delete_data_content_windows): Update.
8115         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8116         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8117         (tui_display_registers_from, tui_check_register_values): Update.
8118         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8119         pointer.
8120         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8121         window.
8122         (tui_free_data_content): Update.
8123         (free_content_elements) <case DATA_WIN>: Free the window.
8124
8125 2019-06-25  Tom Tromey  <[email protected]>
8126
8127         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8128         Update.
8129         * tui/tui-layout.c (make_command_window)
8130         (show_source_disasm_command, show_data, init_and_make_win)
8131         (show_source_or_disasm_and_command): Update.
8132         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8133         method.
8134         <can_highight, is_highlighted>: Now bool.
8135         (tui_set_win_highlight): Don't declare.
8136         * tui/tui-data.c (tui_set_win_highlight): Remove.
8137
8138 2019-06-25  Tom Tromey  <[email protected]>
8139
8140         * tui/tui-wingeneral.c (make_visible): Remove check of window
8141         type.
8142
8143 2019-06-25  Tom Tromey  <[email protected]>
8144
8145         * tui/tui-win.c (tui_win_info::max_height)
8146         (tui_cmd_window::max_height): New methods.
8147         (new_height_ok): Call max_height.
8148         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8149         <max_height>: New method.
8150
8151 2019-06-25  Tom Tromey  <[email protected]>
8152
8153         * tui/tui-win.c (tui_source_window_base::set_new_height)
8154         (tui_data_window::set_new_height): New methods.
8155         (make_invisible_and_set_new_height): Call set_new_height method.
8156         * tui/tui-data.h (struct tui_win_info)
8157         (struct tui_source_window_base, struct tui_data_window)
8158         <set_new_height>: New method.
8159
8160 2019-06-25  Tom Tromey  <[email protected]>
8161
8162         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8163         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8164         tui_refresh_data_win.
8165         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8166         method.
8167         (tui_refresh_all_win): Call the refresh_all method.
8168         (tui_set_focus): Likewise.
8169         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8170         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8171         Likewise.
8172
8173 2019-06-25  Tom Tromey  <[email protected]>
8174
8175         * tui/tui-winsource.h (tui_refill_source_window)
8176         (tui_set_is_exec_point_at): Don't declare.
8177         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8178         (tui_source_window_base::refill): Rename from
8179         tui_refill_source_window.
8180         (tui_source_window_base::do_scroll_horizontal): Update.
8181         (tui_source_window_base::set_is_exec_point_at): Rename from
8182         tui_set_is_exec_point_at.
8183         (tui_update_all_breakpoint_info): Update.
8184         * tui/tui-stack.c (tui_show_frame_info): Update.
8185         * tui/tui-layout.c (show_data): Add cast.
8186         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8187         * tui/tui-data.h (struct tui_source_window_base) <refill,
8188         set_is_exec_point_at>: New methods.
8189         (tui_source_windows, tui_add_to_source_windows): Update types.
8190         (tui_add_to_source_windows): Remove redundant declaration.
8191         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8192         (tui_source_windows): Change return type.
8193         (tui_clear_source_windows_detail): Update.
8194         (tui_add_to_source_windows): Change type of parameter.
8195         (tui_free_all_source_wins_content): Update.
8196
8197 2019-06-25  Tom Tromey  <[email protected]>
8198
8199         * tui/tui-wingeneral.c (tui_win_info::refresh)
8200         (tui_source_window_base::refresh): New methods.
8201         (tui_refresh_all): Call the refresh method.
8202         * tui/tui-data.h (struct tui_win_info)
8203         (struct tui_source_window_base) <refresh>: New method.
8204
8205 2019-06-25  Tom Tromey  <[email protected]>
8206
8207         * tui/tui.h (tui_is_window_visible): Return bool.
8208         * tui/tui.c (tui_is_window_visible): Return bool.
8209         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8210         (tui_make_visible, tui_make_invisible)
8211         (tui_win_info::make_visible)
8212         (tui_source_window_base::make_visible, make_all_visible)
8213         (tui_make_all_visible, tui_make_all_invisible): Update.
8214         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8215         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8216         bool.
8217         (struct tui_win_info, struct tui_source_window_base)
8218         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8219         * tui/tui-data.c (tui_init_generic_part): Update.
8220
8221 2019-06-25  Tom Tromey  <[email protected]>
8222
8223         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8224         (tui_source_window_base::make_visible): New methods.
8225         (make_all_visible): Make method call.
8226         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8227         (struct tui_source_window_base, struct tui_cmd_window): Override
8228         make_visible.
8229         (tui_win_is_source_type): Don't declare.
8230         * tui/tui-data.c (tui_win_is_source_type): Remove.
8231
8232 2019-06-25  Tom Tromey  <[email protected]>
8233
8234         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8235         NULL check.
8236
8237 2019-06-25  Tom Tromey  <[email protected]>
8238
8239         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8240         Inline constructor.  Add initializers for members.
8241         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8242         constructors; now inline in class.
8243
8244 2019-06-25  Tom Tromey  <[email protected]>
8245
8246         * tui/tui-regs.c (tui_show_registers): Update.
8247         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8248         bool.
8249         * tui/tui-data.c (tui_data_window::clear_detail)
8250         (tui_data_window): Update.
8251
8252 2019-06-25  Tom Tromey  <[email protected]>
8253
8254         * tui/tui-windata.c (tui_display_all_data)
8255         (tui_display_data_from_line, tui_display_data_from)
8256         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8257         Update.
8258         * tui/tui-regs.c (tui_last_regs_line_no)
8259         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8260         (tui_show_registers, tui_show_register_group)
8261         (tui_display_registers_from, tui_display_reg_element_at_line)
8262         (tui_display_registers_from_line, tui_check_register_values)
8263         (tui_reg_next, tui_reg_prev): Update.
8264         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8265         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8266         tui_data_window.
8267         (struct tui_win_info) <detail>: Remove.  Add new fields from
8268         tui_data_info.
8269         (TUI_DATA_WIN): Add cast.
8270         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8271         (~tui_data_window): Simplify.
8272
8273 2019-06-25  Tom Tromey  <[email protected]>
8274
8275         * tui/tui-layout.c (show_source_disasm_command)
8276         (show_source_or_disasm_and_command): Update.
8277         * tui/tui-io.c (update_cmdwin_start_line)
8278         (tui_redisplay_readline): Update.
8279         * tui/tui-data.h (struct tui_command_info): Remove.
8280         (struct tui_win_info) <detail>: Remove command_info member.
8281         (struct tui_data_window) <start_line>: New member, from
8282         tui_command_info.
8283         (TUI_CMD_WIN): Add casts.
8284
8285 2019-06-25  Tom Tromey  <[email protected]>
8286
8287         * tui/tui-winsource.c (tui_update_source_window)
8288         (tui_refill_source_window)
8289         (tui_source_window_base::do_scroll_horizontal)
8290         (tui_update_breakpoint_info, tui_set_exec_info_content)
8291         (tui_show_exec_info_content, tui_erase_exec_info_content)
8292         (tui_clear_exec_info_content): Update.
8293         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8294         Update.
8295         * tui/tui-win.c (make_invisible_and_set_new_height)
8296         (make_visible_with_new_height): Update.
8297         * tui/tui-source.c (tui_set_source_content)
8298         (tui_show_symtab_source): Update.
8299         * tui/tui-layout.c (extract_display_start_addr)
8300         (show_source_disasm_command, show_data)
8301         (make_source_or_disasm_window)
8302         (show_source_or_disasm_and_command): Update.
8303         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8304         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8305         "gdbarch".
8306         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8307         to tui_source_window_base.
8308         (struct tui_win_info) <detail>: Remove source_info member.
8309         (struct tui_source_window_base) <has_locator>: Inline.
8310         Move contents from tui_source_info; rename has_locator member to
8311         m_has_locator.
8312         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8313         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8314         header file.
8315         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8316         Simplify.
8317         (tui_free_all_source_wins_content): Cast to
8318         tui_source_window_base.
8319
8320 2019-06-25  Tom Tromey  <[email protected]>
8321
8322         * tui/tui-win.c (make_invisible_and_set_new_height)
8323         (make_visible_with_new_height): Call has_locator method.
8324         * tui/tui-layout.c (show_source_disasm_command, show_data)
8325         (show_source_or_disasm_and_command): Update for bool change.
8326         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8327         (tui_win_info) <has_locator>: New method.
8328         (struct tui_source_window_base) <has_locator>: New method.
8329         (tui_win_has_locator): Don't declare.
8330         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8331         from tui_win_has_locator.
8332         (tui_source_window_base): Use false, not FALSE.
8333
8334 2019-06-25  Tom Tromey  <[email protected]>
8335
8336         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8337         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8338         clear_detail method directly.
8339         (tui_clear_win_detail): Remove.
8340
8341 2019-06-25  Tom Tromey  <[email protected]>
8342
8343         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8344         "this", not TUI_DISASM_WIN.
8345
8346 2019-06-25  Tom Tromey  <[email protected]>
8347
8348         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8349         declare.
8350         * tui/tui-winsource.c
8351         (tui_source_window_base::do_scroll_horizontal): Rename from
8352         tui_horizontal_source_scroll.
8353         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8354         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8355         from tui_vertical_data_scroll.
8356         * tui/tui-win.h (tui_scroll): Don't declare.
8357         * tui/tui-win.c (tui_win_info::forward_scroll)
8358         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8359         (tui_win_info::right_scroll): Rename and update.
8360         (tui_scroll_forward_command, tui_scroll_backward_command)
8361         (tui_scroll_left_command, tui_scroll_right_command): Update.
8362         (tui_scroll): Remove.
8363         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8364         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8365         from tui_vertical_source_scroll.
8366         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8367         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8368         from tui_vertical_disassem_scroll.
8369         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8370         do_scroll_horizontal>: New methods.
8371         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8372         Likewise.
8373         (struct tui_source_window_base): Add do_scroll_horizontal.
8374         (struct tui_source_window, struct tui_disasm_window): Add
8375         do_scroll_vertical.
8376         (struct tui_data_window, struct tui_cmd_window): Add
8377         do_scroll_horizontal and do_scroll_vertical.
8378         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8379
8380 2019-06-25  Tom Tromey  <[email protected]>
8381
8382         * tui/tui-data.h (struct tui_source_window_base): New struct.
8383         (struct tui_source_window): Derive from tui_source_window_base.
8384         (struct tui_disasm_window): New struct.
8385         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8386         from tui_source_window::clear_detail.
8387         (tui_source_window_base): Rename from tui_source_window.
8388         (~tui_source_window_base): Rename from ~tui_source_window.
8389         (tui_alloc_win_info): Create a tui_disasm_window.
8390
8391 2019-06-25  Tom Tromey  <[email protected]>
8392
8393         * tui/tui-data.h (struct tui_source_window)
8394         (struct tui_data_window): Declare destructors.
8395         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8396         destructors.
8397         (tui_win_info): Simplify.
8398
8399 2019-06-25  Tom Tromey  <[email protected]>
8400
8401         * tui/tui-winsource.c (tui_display_main)
8402         (tui_update_source_windows_with_addr)
8403         (tui_update_all_breakpoint_info): Update.
8404         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8405         (new_height_ok, parse_scrolling_args): Update.
8406         * tui/tui-stack.c (tui_show_frame_info): Update.
8407         * tui/tui-data.h (struct tui_list): Remove.
8408         (tui_source_windows): Return a reference to a std::vector.
8409         * tui/tui-data.c (source_windows): Now a std::vector.
8410         (tui_source_windows): Change return type.
8411         (tui_clear_source_windows): Rewrite.
8412         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8413         (tui_free_all_source_wins_content): Rewrite.
8414
8415 2019-06-25  Tom Tromey  <[email protected]>
8416
8417         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8418         (struct tui_data_window, struct tui_cmd_window): Declare
8419         clear_detail method.
8420         * tui/tui-data.c (tui_source_window::clear_detail)
8421         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8422         methods.
8423         (tui_clear_win_detail): Simplify.
8424
8425 2019-06-25  Tom Tromey  <[email protected]>
8426
8427         * tui/tui-layout.c (make_source_window, make_disasm_window)
8428         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8429         Return the new window.
8430         (show_source_disasm_command, show_data)
8431         (show_source_or_disasm_and_command): Update.
8432
8433 2019-06-25  Tom Tromey  <[email protected]>
8434
8435         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8436         parameter.  Return the new window.
8437         (show_source_disasm_command): Update and remove NULL check.
8438         (show_source_or_disasm_and_command): Update.
8439
8440 2019-06-25  Tom Tromey  <[email protected]>
8441
8442         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8443
8444 2019-06-25  Tom Tromey  <[email protected]>
8445
8446         * tui/tui-data.h (struct tui_win_info): Make constructor
8447         protected.  Make destructor virtual.  Add initializers.
8448         (tui_source_window, tui_data_window, tui_cmd_window): New
8449         classes.
8450         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8451         constructor.  Add "type" parameter.
8452         (tui_source_window, tui_data_window, tui_cmd_window): New
8453         constructors.
8454         (tui_alloc_win_info): Instantiate the appropriate subclass.
8455
8456 2019-06-25  Tom Tromey  <[email protected]>
8457
8458         * tui/tui-win.c (tui_resize_all): Use delete.
8459         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8460         destructor.
8461         (tui_free_window): Don't declare.
8462         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8463         Update.
8464
8465 2019-06-25  Tom Tromey  <[email protected]>
8466
8467         * tui/tui-data.h (struct tui_win_info): Add constructor.
8468         * tui/tui-data.c (tui_alloc_win_info): Use new.
8469         (tui_free_window): Use delete.
8470
8471 2019-06-22  Tom Tromey  <[email protected]>
8472
8473         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8474         declare.
8475         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8476
8477 2019-06-22  Tom Tromey  <[email protected]>
8478
8479         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8480         declare.
8481         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8482
8483 2019-06-22  Tom de Vries  <[email protected]>
8484
8485         * dwarf2read.c (create_addrmap_from_aranges)
8486         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8487         instead of '%zu'.
8488
8489 2019-06-21  Simon Marchi  <[email protected]>
8490
8491         * dwarf2read.h (dwarf2_section_info_def): Remove.
8492         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8493         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8494         std::vector<dwarf2_section_info>.
8495         (struct dwo_file) <~dwo_file>: Remove.
8496         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8497         types field.
8498         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8499         (dwarf2_read_debug_names): Likewise.
8500         (create_debug_types_hash_table): Change parameter type to
8501         array_view, adjust code accordingly.
8502         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8503         (partial_die_info::fixup): Likewise.
8504         (determine_prefix): Likewise.
8505         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8506
8507 2019-06-21  Simon Marchi  <[email protected]>
8508
8509         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8510         gdb_bfd_ref_ptr.
8511         <~dwo_file>: Remove call to gdb_bfd_unref.
8512         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8513         gdb_bfd_ref_ptr::get.
8514
8515 2019-06-21  Simon Marchi  <[email protected]>
8516
8517         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8518         type to htab_up.
8519         * dwarf2read.c (struct dwo_file): Initialize fields.
8520         <~dwo_file>: New.
8521         (free_dwo_file): Remove, move content to ~dwo_file.
8522         (struct dwo_file_deleter): Remove.
8523         (dwo_file_up>: Remove custom deleter.
8524         (free_dwo_files): Remove.
8525         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8526         dwo_files.
8527         (process_skeletonless_type_units): Call unique_ptr::get.
8528         (allocate_dwo_file_hash_table): Add deleter to created hash
8529         table.  Change return type to htab_up.
8530         (lookup_dwo_file_slot): Don't memset dwo_file, call
8531         unique_ptr::get.
8532         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8533         (create_dwo_unit_in_dwp_v2): Likewise.
8534         (open_and_init_dwo_file): Likewise.
8535         (free_dwo_file_from_slot): Remove.
8536
8537 2019-06-21  Simon Marchi  <[email protected]>
8538
8539         * dwarf2read.h (struct dwarf2_section_info) <readin,
8540         is_virtual>: Change type to bool.
8541         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8542         true instead of 1.
8543
8544 2019-06-19  Tom Tromey  <[email protected]>
8545
8546         * tui/tui-data.h (tui_init_content_element): Don't declare.
8547
8548 2019-06-19  Tom Tromey  <[email protected]>
8549
8550         * tui/tui-data.h (tui_init_win_info): Don't declare.
8551
8552 2019-06-19  Tom de Vries  <[email protected]>
8553
8554         * dwarf2read.h (abstract_to_concrete): Change type to
8555         std::unordered_map<sect_offset, std::vector<sect_offset>,
8556         gdb::hash_enum<sect_offset>>.
8557
8558 2019-06-19  Tom Tromey  <[email protected]>
8559
8560         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8561         EVAL_AVOID_SIDE_EFFECTS specially.
8562
8563 2019-06-19  Tom Tromey  <[email protected]>
8564
8565         * source-cache.c (highlighter): New global.
8566         (source_cache::get_source_lines): Create a highlighter on demand.
8567
8568 2019-06-18  Andrew Burgess  <[email protected]>
8569
8570         * defs.h (deprecated_interactive_hook): Delete declaration.
8571         * interps.c (clear_interpreter_hooks): Remove use of
8572         deprecated_interactive_hook.
8573         * top.c (deprecated_interactive_hook): Delete definition.
8574         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8575
8576 2019-06-18  Tom de Vries  <[email protected]>
8577
8578         PR gdb/24515
8579         * dwarf2read.h (abstract_to_concrete): Change type from
8580         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8581         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8582         * dwarf2read.c (read_variable): Update.
8583         (dwarf2_fetch_die_loc_sect_off): Update.
8584
8585 2019-06-17  Tom de Vries  <[email protected]>
8586
8587         PR gdb/24617
8588         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8589         accessing parent[parent_len - 1].
8590
8591 2019-06-17  Paul Pluzhnikov  <[email protected]>
8592
8593         PR gdb/24364
8594         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8595         call dtrace_process_dof with NULL dof.
8596
8597 2019-06-16  Tom de Vries  <[email protected]>
8598
8599         PR gdb/24445
8600         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8601
8602 2019-06-16  Tom Tromey  <[email protected]>
8603
8604         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8605         (make_all_visible): Use address of member.
8606
8607 2019-06-16  Tom Tromey  <[email protected]>
8608
8609         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8610         (tui_free_window, free_content, free_content_elements): Remove
8611         unnecessary cast.
8612         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8613         cast.
8614         * tui/tui-regs.c (tui_show_register_group)
8615         (tui_display_registers_from, tui_display_reg_element_at_line):
8616         Remove unnecessary cast.
8617
8618 2019-06-16  Andrew Burgess  <[email protected]>
8619
8620         * linux-nat.c (normal_mask): Delete.
8621         (_initialize_linux_nat): Don't initialise normal_mask.
8622
8623 2019-06-16  Simon Marchi  <[email protected]>
8624
8625         PR gdb/24445
8626         * dwarf-index-write.h (write_psymtabs_to_index): Add
8627         dwz_basename parameter.
8628         * dwarf-index-write.c (write_gdbindex): Move file writing to
8629         write_gdbindex_1.  Change return type void.
8630         (assert_file_size): Move up, remove filename parameter.
8631         (write_gdbindex_1): New function.
8632         (write_debug_names): Change return type to void, call
8633         assert_file_size.
8634         (struct index_wip_file): New struct.
8635         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8636         file logic to index_wip_file.  Write index for dwz file if
8637         needed.
8638         (save_gdb_index_command): Pass basename of dwz file, if present.
8639         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8640         build-id of dwz file, if present.
8641         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8642         (dwarf2_get_dwz_file): Likewise.
8643         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8644         (dwarf2_get_dwz_file): Likewise.
8645
8646 2019-06-16  Tom Tromey  <[email protected]>
8647
8648         * coffread.c (process_coff_symbol): Use xstrdup.
8649         * value.c (create_internalvar): Use xstrdup.
8650
8651 2019-06-16  Tom Tromey  <[email protected]>
8652
8653         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8654         * breakpoint.c (stopin_command, stopat_command)
8655         (until_break_command, decode_location_default): Remove unnecessary
8656         cast.
8657         * utils.c (subset_compare): Remove unnecessary cast.
8658         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8659         cast.
8660         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8661         cast.
8662         * infcmd.c (path_command): Remove unnecessary cast.
8663         * coffread.c (decode_type): Remove unnecessary cast.
8664         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8665         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8666         * tui/tui-stack.c (tui_show_locator_content)
8667         (tui_show_frame_info): Remove unnecessary cast.
8668         * tui/tui-win.c (tui_scroll_forward_command)
8669         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8670         (parse_scrolling_args): Remove unnecessary cast.
8671         * tui/tui-data.c (init_win_info, tui_del_window)
8672         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8673         (free_content_elements): Remove unnecessary cast.
8674         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8675         unnecessary cast.
8676         * tui/tui-source.c (tui_set_source_content)
8677         (tui_vertical_source_scroll): Remove unnecessary cast.
8678         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8679         cast.
8680         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8681         * tui/tui-regs.c (tui_display_registers_from)
8682         (tui_display_register): Remove unnecessary cast.
8683         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8684         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8685         (make_visible): Remove unnecessary cast.
8686         * tui/tui-winsource.c (tui_erase_source_content)
8687         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8688         unnecessary cast.
8689         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8690         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8691         * stabsread.c (read_type, read_array_type, read_range_type):
8692         Remove unnecessary cast.
8693         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8694         (parse_symbol, parse_type, upgrade_type, parse_external)
8695         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8696         unnecessary cast.
8697         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8698
8699 2019-06-16  Tom Tromey  <[email protected]>
8700
8701         * tui/tui-data.c (tui_alloc_generic_win_info)
8702         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8703         checks.
8704
8705 2019-06-16  Bernhard Heckel  <[email protected]>
8706             Andrew Burgess  <[email protected]>
8707
8708         * f-typeprint.c (f_print_type): Don't return early for not
8709         associated or not allocated types.
8710         (f_type_print_varspec_suffix): Add print_rank parameter and print
8711         ranks of array types in case they dangling.
8712         (f_type_print_base): Add print_rank parameter.
8713
8714 2019-06-15  Andrew Burgess  <[email protected]>
8715
8716         * NEWS: Mention new MI commands.
8717         * break-catch-throw.c (enum exception_event_kind): Move to
8718         breakpoint.h.
8719         (print_mention_exception_catchpoint): Output text as a single
8720         message.
8721         (catch_exception_command_1): Rename to...
8722         (catch_exception_event): ...this, make non-static, update header
8723         command, and change some parameter types.
8724         (catch_catch_command): Update for changes to
8725         catch_exception_command_1.
8726         (catch_throw_command): Likewise.
8727         (catch_rethrow_command): Likewise.
8728         * breakpoint.c (enum exception_event_kind): Delete.
8729         * breakpoint.h (enum exception_event_kind): Moved here from
8730         break-catch-throw.c.
8731         (catch_exception_event): Declare.
8732         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8733         (mi_cmd_catch_throw): New function.
8734         (mi_cmd_catch_rethrow): New function.
8735         (mi_cmd_catch_catch): New function.
8736         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8737         'catch-catch' entries.
8738         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8739         (mi_cmd_catch_rethrow): Declare.
8740         (mi_cmd_catch_catch): Declare.
8741
8742 2019-06-15  Andrew Burgess  <[email protected]>
8743
8744         * annotate.c (annotate_source_line): Change return type to void,
8745         update implementation to match.
8746         * annotate.h (annotate_source_line): Change return type to void,
8747         update header comment.
8748         * stack.c (print_frame_info): Don't change what frame information
8749         is printed based on whether annotations are on or not.
8750
8751 2019-06-15  Andrew Burgess  <[email protected]>
8752
8753         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8754         (annotate_source): Make static.
8755         (annotate_source_line): Moved from source.c and renamed from
8756         identify_source_line.  Update the return type.
8757         * annotate.h (annotate_source): Delete declaration.
8758         (annotate_source_line): Declaration moved from source.h, and
8759         renamed from identify_source_line.  Return type updated.
8760         * source.c (identify_source_line): Moved to annotate.c and renamed
8761         to annotate_source_line.
8762         (info_line_command): Remove check of annotation_level.
8763         * source.h (identify_source_line): Move declaration to annotate.h
8764         and rename to annotate_source_line.
8765         * stack.c: Add 'annotate.h' include.
8766         (print_frame_info): Remove check of annotation_level before
8767         calling annotate_source_line.
8768
8769 2019-06-15  Andrew Burgess  <[email protected]>
8770
8771         * source-cache.c (source_cache::get_plain_source_lines): Use
8772         open_source_file_with_line_charpos instead of just
8773         open_source_file, remove call to find_source_lines.
8774         (source_cache::get_source_lines): Likewise.
8775         * source.c (find_source_lines): Make static.
8776         (get_filename_and_charpos): Renamed into...
8777         (open_source_file_with_line_charpos): ..this along with changes to
8778         return a scoped_fd, and some other minor clean ups.
8779         (identify_source_line): Use open_source_file_with_line_charpos.
8780         (search_command_helper): Use open_source_file_with_line_charpos
8781         instead of just open_source_file, remove call to
8782         find_source_lines.
8783         * source.h (open_source_file_with_line_charpos): Declare new
8784         function.
8785         (find_source_lines): Delete declaration.
8786
8787 2019-06-15  Andrew Burgess  <[email protected]>
8788
8789         * source.c (get_filename_and_charpos): Remove fullname
8790         parameter.
8791         (identify_source_line): Update call to get_filename_and_charpos.
8792
8793 2019-06-14  Tom Tromey  <[email protected]>
8794
8795         PR gdb/24502:
8796         * ui-style.h (skip_ansi_escape): Update comment.
8797         * ui-file.h (class no_terminal_escape_file): New class.
8798         * ui-file.c (no_terminal_escape_file::write)
8799         (no_terminal_escape_file::puts): New methods.
8800         * cli/cli-logging.c (handle_redirections): Use
8801         no_terminal_escape_file.
8802
8803 2019-06-14  Tom Tromey  <[email protected]>
8804
8805         * NEWS: Move convenience variable news above Python news.
8806
8807 2019-06-14  Tom Tromey  <[email protected]>
8808
8809         * gnulib: Move directory to top-level.
8810         * configure.ac: Don't configure gnulib.
8811         * configure: Rebuild.
8812         * common/common-defs.h: Use new path to gnulib.
8813         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8814         (GNULIB_H): Remove.
8815         (INCGNU): Look in new gnulib location.
8816         (HFILES_NO_SRCDIR): Remove gnulib files.
8817         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8818         (generated_files): Remove GNULIB_H.
8819         ($(LIBGNU), all-lib): Remove targets.
8820         (distclean): Don't mention GNULIB_BUILDDIR.
8821         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8822
8823 2019-06-14  Tom Tromey  <[email protected]>
8824
8825         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8826         Warn if symbol file does not provide any symbols.
8827
8828 2019-06-14  Tom Tromey  <[email protected]>
8829
8830         * source.c (find_and_open_source): Respect basenames_may_differ.
8831
8832 2019-06-14  Andrew Burgess  <[email protected]>
8833
8834         * annotate.c (annotate_breakpoints_invalid): Make use of
8835         scoped_restore_terminal_state.
8836         (annotate_frames_invalid): Likewise.
8837
8838 2019-06-14  Tom Tromey  <[email protected]>
8839
8840         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8841         allow assignment to an internalvar.
8842
8843 2019-06-14  Tom Tromey  <[email protected]>
8844
8845         * ada-lex.l: Allow "_" in attribute names.
8846
8847 2019-06-14  Tom Tromey  <[email protected]>
8848
8849         PR gdb/24653:
8850         * regcache.c (registers_changed): Don't call alloca.
8851         * top.c (execute_command): Don't call alloca.
8852
8853 2019-06-13  Pedro Alves  <[email protected]>
8854
8855         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8856         'expression'.  When parsing an expression, error out if there's
8857         junk after "unlimited".
8858         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8859         (do_set_command): Adjust calls to is_unlimited_literal.
8860
8861 2019-06-13  Pedro Alves  <[email protected]>
8862
8863         * compile/compile.c (make_compile_options_def_group): Add braces
8864         around array_view initializer.
8865         * thread.c (make_thread_apply_all_options_def_group)
8866         (make_thread_apply_all_options_def_group): Likewise.
8867
8868 2019-06-13  Pedro Alves  <[email protected]>
8869
8870         * NEWS (New commands): Mention "maint test-options
8871         require-delimiter", "maint test-options unknown-is-error", "maint
8872         test-options unknown-is-operand" and "maint show
8873         test-options-completion-result".
8874         (New command options, command completion): New section.
8875         (Completion improvements): New section.
8876         Mention that you can abbreviate "unlimited".
8877
8878 2019-06-13  Pedro Alves  <[email protected]>
8879
8880         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8881         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8882         * unittests/cli-utils-selftests.c (test_parse_flags)
8883         (test_parse_flags_qcs): Delete.
8884         (test_cli_utils): Don't call deleted functions.
8885
8886 2019-06-13  Pedro Alves  <[email protected]>
8887
8888         * thread.c: Include "cli/cli-option.h".
8889         (tp_array_compar_ascending): Global.
8890         (tp_array_compar): Delete function.
8891         (tp_array_compar_ascending, tp_array_compar_descending): New
8892         functions.
8893         (ascending_option_def, qcs_flag_option_def)
8894         (thr_qcs_flags_option_defs)
8895         (make_thread_apply_all_options_def_group)
8896         (make_thread_apply_options_def_group): New.
8897         (thread_apply_all_command): Use gdb::option::process_options.
8898         (thread_apply_command_completer)
8899         (thread_apply_all_command_completer): New.
8900         (thread_apply_command): Use gdb::option::process_options.
8901         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8902         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8903         to generate help text of "thread apply".  Adjust "taas"'s help.
8904         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8905         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8906
8907 2019-06-13  Pedro Alves  <[email protected]>
8908
8909         * thread.c (thread_apply_command): Check for invalid TID with
8910         isdigit instead of !isalpha.
8911
8912 2019-06-13  Pedro Alves  <[email protected]>
8913
8914         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8915         (validate_flags_qcs): New.
8916         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8917         (validate_flags_qcs): Declare.
8918         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8919         (make_frame_apply_options_def_group): New.
8920         (frame_apply_command_count): Process options with
8921         gdb::option::process_options.
8922         (frame_apply_completer): New.
8923         (frame_apply_level_completer, frame_apply_all_completer)
8924         (frame_apply_completer): New.
8925         (_initialize_stack): Update help of "frame apply", "frame apply
8926         level", "frame apply all" and "faas" to mention supported options
8927         and install command completers.
8928         * stack.h (frame_apply_all_completer): Declare.
8929         * thread.c: Include "stack.h".
8930         (tfaas_command): Add "--".
8931         (_initialize_thread): Update help "tfaas" to mention supported
8932         options and install command completer.
8933
8934 2019-06-13  Pedro Alves  <[email protected]>
8935
8936         * completer.c (complete_nested_command_line): New.
8937         (gdb_completion_word_break_characters_throw): Add assertion.
8938         * completer.h (complete_nested_command_line): Declare.
8939
8940 2019-06-13  Pedro Alves  <[email protected]>
8941
8942         * stack.c (parse_backtrace_qualifiers): New.
8943         (backtrace_command): Use it.
8944         (backtrace_command_completer): Complete on qualifiers.
8945
8946 2019-06-13  Pedro Alves  <[email protected]>
8947
8948         * frame.c: Include "cli/cli-option.h.
8949         (user_set_backtrace_options): New.
8950         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8951         Delete.
8952         (get_prev_frame): Adjust.
8953         (boolean_option_def, uinteger_option_def)
8954         (set_backtrace_option_defs): New.
8955         (_initialize_frame): Adjust and use
8956         gdb::option::add_setshow_cmds_for_options to install "set
8957         backtrace past-main" and "set backtrace past-entry".
8958         * frame.h: Include "cli/cli-option.h".
8959         (struct frame_print_options): Forward declare.
8960         (print_frame_arguments_all, print_frame_arguments_scalars)
8961         (print_frame_arguments_none): Declare.
8962         (print_entry_values): Delete declaration.
8963         (struct frame_print_options, user_frame_print_options): New.
8964         (struct set_backtrace_options): New.
8965         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8966         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8967         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8968         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8969         (list_args_or_locals): Add frame_print_options parameter.
8970         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8971         * python/py-framefilter.c (enumerate_args): Pass down
8972         USER_FRAME_PRINT_OPTIONS.
8973         * stack.c: Include "cli/cli-option.h".
8974         (print_frame_arguments_all, print_frame_arguments_scalars)
8975         (print_frame_arguments_none): Declare.
8976         (print_raw_frame_arguments, print_entry_values): Delete.
8977         (user_frame_print_options): New.
8978         (boolean_option_def, enum_option_def, frame_print_option_defs):
8979         New.
8980         (struct backtrace_cmd_options): New.
8981         (bt_flag_option_def): New.
8982         (backtrace_command_option_defs): New.
8983         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8984         (print_frame_arg, read_frame_arg, print_frame_args)
8985         (print_frame_info, print_frame): Add frame_print_options parameter
8986         and use it.
8987         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8988         (backtrace_command_1): Add frame_print_options and
8989         backtrace_cmd_options parameters and use them.
8990         (make_backtrace_options_def_group): New.
8991         (backtrace_command): Process command options with
8992         gdb::option::process_options.
8993         (backtrace_command_completer): New.
8994         (_initialize_stack): Extend "backtrace"'s help to mention
8995         supported options.  Install completer for "backtrace".
8996         Install some settings commands with add_setshow_cmds_for_options.
8997
8998 2019-06-13  Pedro Alves  <[email protected]>
8999
9000         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9001         and that "set/show print raw frame-arguments" are now deprecated.
9002
9003         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9004         command.
9005         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9006         * stack.c (_initialize_stack): Install "set/show print
9007         raw-frame-arguments", and deprecate "set/show print raw
9008         frame-arguments".
9009         * valprint.c (_initialize_valprint): Deprecate "set/show print
9010         raw".
9011
9012 2019-06-13  Pedro Alves  <[email protected]>
9013
9014         * compile/compile.c (struct compile_options): New.
9015         (compile_flag_option_def, compile_command_option_defs)
9016         (make_compile_options_def_group): New.
9017         (compile_file_command): Handle options with
9018         gdb::option::process_options.
9019         (compile_file_command_completer): New function.
9020         (compile_code_command): Handle options with
9021         gdb::option::process_options.
9022         (compile_code_command_completer): New function.
9023         (_initialize_compiler): Install completers for "compile code" and
9024         "compile file".  Mention available options in "compile code" and
9025         "compile code"'s help.
9026         * completer.c (advance_to_completion_word): New, factored out from
9027         ...
9028         (advance_to_expression_complete_word_point): ... this.
9029         (advance_to_filename_complete_word_point): New.
9030         * completer.h (advance_to_filename_complete_word_point): New
9031         declaration.
9032
9033 2019-06-13  Pedro Alves  <[email protected]>
9034
9035         * compile/compile.c: Include "cli/cli-option.h".
9036         (compile_print_value): Scope data pointer is now a
9037         value_print_options pointer; adjust.
9038         (compile_print_command): Process options.  Scope data pointer is
9039         now a value_print_options pointer; adjust.
9040         (_initialize_compile): Update "compile print"'s help to include
9041         supported options.  Install a completer for "compile print".
9042         * cp-valprint.c (show_vtblprint, show_objectprint)
9043         (show_static_field_print): Delete.
9044         (_initialize_cp_valprint): Don't install "set print
9045         static-members", "set print vtbl", "set print object" here.
9046         * printcmd.c: Include "cli/cli-option.h" and
9047         "common/gdb_optional.h".
9048         (print_command_parse_format): Rework to fill in a
9049         value_print_options instead of a format_data.
9050         (print_value): Change parameter type from format_data pointer to
9051         value_print_options reference.  Adjust.
9052         (print_command_1): Process options.  Adjust to pass down a
9053         value_print_options.
9054         (print_command_completer): New.
9055         (_initialize_printcmd): Install print_command_completer as
9056         handle_brkchars completer for the "print" command.  Update
9057         "print"'s help to include supported options.
9058         * valprint.c: Include "cli/cli-option.h".
9059         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9060         here from cp-valprint.c.
9061         (boolean_option_def, uinteger_option_def)
9062         (value_print_option_defs, make_value_print_options_def_group):
9063         New.  Use gdb::option::add_setshow_cmds_for_options to install
9064         "set print elements", "set print null-stop", "set print repeats",
9065         "set print pretty", "set print union", "set print array", "set
9066         print address", "set print symbol", "set print array-indexes".
9067         * valprint.h: Include <string> and "cli/cli-option.h".
9068         (make_value_print_options_def_group): Declare.
9069         (print_value): Change parameter type from format_data pointer to
9070         value_print_options reference.
9071         (print_command_completer): Declare.
9072
9073 2019-06-13  Pedro Alves  <[email protected]>
9074
9075         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9076         (COMMON_SFILES): Add maint-test-settings.c.
9077         * cli/cli-decode.c (boolean_enums): New global, factored out from
9078         ...
9079         (add_setshow_boolean_cmd): ... here.
9080         * cli/cli-decode.h (boolean_enums): Declare.
9081         * cli/cli-option.c: New file.
9082         * cli/cli-option.h: New file.
9083         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9084         factored out from ...
9085         (parse_cli_boolean_value(const char *)): ... this.
9086         (is_unlimited_literal): Change parameter type to pointer to
9087         pointer.  Adjust and advance ARG pointer.
9088         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9089         (parse_cli_var_enum): New, factored out from ...
9090         (do_set_command): ... this.  Adjust.
9091         * cli/cli-setshow.h (parse_cli_boolean_value)
9092         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9093         (parse_cli_var_enum): Declare.
9094         * cli/cli-utils.c: Include "cli/cli-option.h".
9095         (get_ulongest): New.
9096         * cli/cli-utils.h (get_ulongest): Declare.
9097         (check_for_argument): New overloads.
9098         * maint-test-options.c: New file.
9099
9100 2019-06-13  Pedro Alves  <[email protected]>
9101
9102         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9103         parse a range if "-" is at the end of the string.
9104
9105 2019-06-13  Pedro Alves  <[email protected]>
9106
9107         * cli/cli-setshow.c (parse_auto_binary_operation)
9108         (parse_cli_boolean_value): Don't allow "o".
9109
9110 2019-06-13  Pedro Alves  <[email protected]>
9111
9112         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9113         * NEWS: Mention maint test-settings KIND.
9114         * maint-test-settings.c: New file.
9115
9116 2019-06-13  Pedro Alves  <[email protected]>
9117
9118         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9119         completer.
9120         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9121         "set" completers.
9122
9123 2019-06-13  Pedro Alves  <[email protected]>
9124
9125         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9126         after item.
9127
9128 2019-06-13  Pedro Alves  <[email protected]>
9129
9130         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9131
9132 2019-06-13  Pedro Alves <[email protected]>
9133
9134         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9135         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9136         call.
9137         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9138         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9139         calls.
9140         (check_for_argument): Skip spaces after argument.
9141
9142 2019-06-13  Pedro Alves  <[email protected]>
9143
9144         * thread.c (thread_apply_command): Adjust TID parsing.
9145         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9146         detected before end of string.
9147         (tid_is_in_list): Error out if LIST is invalid.
9148
9149 2019-06-13  Pedro Alves  <[email protected]>
9150
9151         * completer.c (complete_line_internal_1): Rewind completion word
9152         point.
9153         (completion_tracker::advance_custom_word_point_by): Change
9154         parameter type to int.
9155         * completer.h (completion_tracker::advance_custom_word_point_by):
9156         Likewise.
9157
9158 2019-06-13  Pedro Alves  <[email protected]>
9159
9160         * completer.c (advance_to_completion_word): Handle delimiters.
9161
9162 2019-06-11  Bernhard Heckel  <[email protected]>
9163
9164         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9165
9166 2019-06-11  Tom Tromey  <[email protected]>
9167
9168         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9169         (xmalloc_failed): Move to alloc.c.
9170         * alloc.c: New file.
9171         * Makefile.in (COMMON_SFILES): Add alloc.c.
9172
9173 2019-06-11  Tom Tromey  <[email protected]>
9174
9175         * nat/linux-waitpid.c: Don't include server.h.
9176         (linux_debug): Remove.
9177         (my_waitpid): Update.
9178
9179 2019-06-11  Tom Tromey  <[email protected]>
9180
9181         * infcall.c (_initialize_infcall): Remove trailing newline from
9182         help.
9183         * user-regs.c (_initialize_user_regs): Remove trailing newline
9184         from help.
9185         * typeprint.c (_initialize_typeprint): Remove trailing newline
9186         from help.
9187         * reverse.c (_initialize_reverse): Remove trailing newlines from
9188         help.
9189         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9190         from help.
9191         * language.c (add_set_language_command): Remove trailing newline
9192         from help.
9193         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9194         help.
9195         * disasm.c (_initialize_disasm): Remove trailing newline from
9196         help.
9197         * top.c (init_main): Remove trailing newline from help.
9198         * interps.c (_initialize_interpreter): Remove trailing newline
9199         from help.
9200         * btrace.c (_initialize_btrace): Remove trailing newlines from
9201         help.
9202         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9203         from help.
9204         * python/python.c (_initialize_python): Remove trailing newline
9205         from help.
9206         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9207         help.
9208         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9209         from help.  Reformat some text.
9210         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9211         from help.
9212         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9213         newline from help.
9214
9215 2019-06-11  Tom Tromey  <[email protected]>
9216
9217         * darwin-nat.c (darwin_decode_exception_message)
9218         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9219
9220 2019-06-10  Andrew Burgess  <[email protected]>
9221
9222         * valops.c (value_slice): Check for not allocated or not
9223         associated values.
9224
9225 2019-06-10  Tom de Vries  <[email protected]>
9226
9227         PR gdb/24618
9228         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9229         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9230         invalid.
9231
9232 2019-06-10  Tom de Vries  <[email protected]>
9233
9234         PR gdb/24611
9235         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9236         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9237
9238 2019-06-10  Tom de Vries  <[email protected]>
9239
9240         PR symtab/24545
9241         * symtab.c (struct demangled_name_entry): Add language field.
9242         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9243         static minimal symbol".  Set and use language field.
9244
9245 2019-06-10  Tom Tromey  <[email protected]>
9246
9247         * ada-lang.c (_initialize_ada_language): Update help text.
9248
9249 2019-06-10  Tom Tromey  <[email protected]>
9250
9251         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9252         with a newline.
9253         * guile/guile.c (handle_boot_error): Don't end warning with a
9254         newline.
9255         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9256         warning with a newline.
9257         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9258         newline.
9259         (s12z_frame_cache): Likewise.
9260         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9261         a newline.
9262         * solib-svr4.c (disable_probes_interface): Don't end warning with
9263         a newline.
9264         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9265         newline.
9266         * python/python.c (do_finish_initialization): Don't end warning
9267         with a newline.
9268
9269 2019-06-10  Tom Tromey  <[email protected]>
9270
9271         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9272         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9273         gdbpy_enter.
9274
9275 2019-06-10  Tom Tromey  <[email protected]>
9276
9277         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9278         data.
9279         (elf_new_init): Don't call stabsread_new_init.
9280         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9281         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9282         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9283
9284 2019-06-10  Tom de Vries  <[email protected]>
9285
9286         PR symtab/16264
9287         PR symtab/24517
9288         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9289
9290 2019-06-06  Руслан Ижбулатов <[email protected]>
9291
9292         * source.c (find_and_open_source): Also rewrite relative file
9293         names.
9294
9295 2019-04-26  Amos Bird  <[email protected]>
9296
9297         * annotate.c (annotate_thread_exited): Add "thread-exited"
9298         annotation.
9299
9300 2019-06-06  Tom Tromey  <[email protected]>
9301
9302         * maint.h (class scoped_command_stats): Use
9303         DISABLE_COPY_AND_ASSIGN.
9304         <print_time>: New method.
9305         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9306         print_time.
9307         (scoped_command_stats::print_time): New method.
9308
9309 2019-06-05  Andrew Burgess  <[email protected]>
9310
9311         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9312         instructions of lengths 6 or 8 bytes.
9313
9314 2019-06-04  Pedro Alves  <[email protected]>
9315
9316         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9317
9318         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9319         * breakpoint.c (condition_completer): Likewise.
9320         * cli/cli-dump.c (scan_expression): Likewise.
9321         * common/filestuff.c (mkdir_recursive): Likewise.
9322         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9323         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9324         (gdb_abspath): Likewise.
9325         * compile/compile-cplus-types.c
9326         (compile_cplus_instance::decl_name): Likewise.
9327         * completer.c (complete_explicit_location):
9328         (signal_completer, reg_or_group_completer_1): Likewise.
9329         * cp-support.c (cp_remove_params_if_any): Likewise.
9330         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9331         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9332         * infcmd.c (strip_bg_char): Likewise.
9333         * linespec.c (copy_token_string): Likewise.
9334         * mi/mi-main.c (output_cores): Likewise.
9335         * psymtab.c (psymtab_search_name):
9336         * symfile.c (test_set_ext_lang_command): Likewise.
9337         * target.c (target_fileio_read_stralloc): Likewise.
9338         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9339         * value.c (complete_internalvar): Likewise.
9340
9341 2019-06-04  Christian Biesinger  <[email protected]>
9342
9343         Add objfile property to gdb.Type.
9344         * NEWS: Mention Python API addition.
9345         * python/py-type.c (typy_get_objfile): New method.
9346
9347 2019-06-03  Philippe Waroquiers  <[email protected]>
9348
9349         * NEWS: Mention the new set|show style [title|highlight].
9350         Mention changes to "show style", "help" and "apropos".
9351
9352 2019-06-03  Philippe Waroquiers  <[email protected]>
9353
9354         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9355         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9356         instead of print_help_for_command.
9357         (print_doc_of_command): New function.
9358         (help_list): Add 'apropos -v word' suggestion.
9359         (print_help_for_command): Style the command name using title style.
9360         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9361         (_initialize_cli_cmds): Describe -v in apropos_command help.
9362
9363 2019-06-03  Philippe Waroquiers  <[email protected]>
9364
9365         * cli/cli-style.h (cli_style_option): Add name in constructor,
9366         add m_name class member, add constructor with intensity,
9367         add name class function.
9368         (cli_style_option::add_setshow_commands): Remove name argument.
9369         (highlight_style, title_style): New styles.
9370         * cli/cli-style.c (do_show): New function that shows a style
9371         characteristic styling the style name with itself.
9372         (set_style_name): New function.
9373         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9374         Update all callers according to the changes in cli/cli-style.h.
9375         * utils.h (fputs_highlighted): New function.
9376         * utils.c (fputs_highlighted): Likewise.
9377
9378 2019-05-31  Philippe Waroquiers  <[email protected]>
9379
9380         * NEWS: Mention new pipe command and new convenience variables.
9381
9382 2019-05-31  Philippe Waroquiers  <[email protected]>
9383
9384         * cli/cli-cmds.c (pipe_command): New function.
9385         (_initialize_cli_cmds): Call add_com for pipe_command.
9386         Define | as an alias for pipe.
9387         (exit_status_set_internal_vars): New function.
9388         (shell_escape): Call exit_status_set_internal_vars.
9389         cli/cli-decode.c (find_command_name_length): Recognize | as
9390         a single character command.
9391
9392 2019-05-31  Philippe Waroquiers  <[email protected]>
9393
9394         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9395         top.c (execute_command_to_ui_file): New function, mostly a copy
9396         of execute_command_to_string.
9397         (execute_command_to_string): Implement by calling
9398         execute_command_to_ui_file.
9399
9400 2019-05-31  Philippe Waroquiers  <[email protected]>
9401
9402         * top.h (saved_command_line): Remove declaration.
9403         * top.c (previous_saved_command_line, previous_repeat_arguments):
9404         New variables.
9405         (saved_command_line): Make static, define together with other
9406         'repeat variables'.
9407         (dont_repeat): Clear repeat_arguments.
9408         (repeat_previous, get_saved_command_line, save_command_line):
9409         New functions.
9410         (gdb_init): Initialize saved_command_line
9411         and previous_saved_command_line.
9412         * main.c (captured_main_1): Remove saved_command_line initialization.
9413         * event-top.c (handle_line_of_input): Update to use
9414         the new 'repeat' related functions instead of direct access to
9415         saved_command_line.
9416         * command.h (repeat_previous, get_saved_command_line,
9417         save_command_line): New declarations.
9418         (dont_repeat): Add comment.
9419
9420 2019-05-30  Tom Tromey  <[email protected]>
9421
9422         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9423         Fix comment.
9424         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9425
9426 2019-05-30  Jan Vrany  <[email protected]>
9427
9428         PR cli/24587
9429         * completer.c (complete): Initialize variable word.
9430
9431 2019-05-29  Sergio Durigan Junior  <[email protected]>
9432
9433         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9434         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9435         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9436         'body' is NULL to the outter 'if', protecting the '!is_define'
9437         situation as well.
9438
9439 2019-05-29  Tom Tromey  <[email protected]>
9440
9441         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9442         (dwarf_unknown): New function.
9443         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9444         (dwarf_type_encoding_name): Use dwarf_unknown.
9445
9446 2019-05-29  Tom Tromey  <[email protected]>
9447
9448         PR c++/20020:
9449         * cp-valprint.c (cp_print_value_fields): Call
9450         cp_print_static_field inside "try".
9451
9452 2019-05-29  Tom Tromey  <[email protected]>
9453
9454         * inflow.c (struct terminal_info): Add default operator=.
9455         * configure: Rebuild.
9456         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9457         -Wdeprecated-copy-dtor, -Wredundant-move.
9458
9459 2019-05-29  Tom Tromey  <[email protected]>
9460
9461         * NEWS: Add entry.
9462         * infcmd.c (print_return_value_1): Handle finish_print
9463         option.
9464         (show_print_finish): New function.
9465         (_initialize_infcmd): Add "set/show print finish" commands.
9466         * valprint.c (user_print_options): Initialize new member.
9467         * valprint.h (struct value_print_options) <finish_print>: New
9468         member.
9469
9470 2019-05-28  Tom Tromey  <[email protected]>
9471
9472         * ada-lang.c (ada_remove_Xbn_suffix)
9473         (find_old_style_renaming_symbol)
9474         (parse_old_style_renaming): Remove.
9475         (ada_find_renaming_symbol): Don't call
9476         find_old_style_renaming_symbol.
9477         (ada_is_renaming_symbol): Rename from
9478         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9479         bool.  Now static.
9480         (ada_read_var_value): Update and simplify.
9481         * ada-exp.y (write_var_or_type): Remove old code.
9482
9483 2019-05-28  Alan Hayward  <[email protected]>
9484
9485         PR gdb/25010
9486         * event-top.c: Remove include comment.
9487         * inflow.c (class scoped_ignore_sigttou): Move from here...
9488         * inflow.h (class scoped_ignore_sigttou): ...to here.
9489         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9490         * top.c:  Remove include comment.
9491
9492 2019-05-27  Tom Tromey  <[email protected]>
9493
9494         * NEWS: Fix typo.
9495
9496 2019-05-22  Tom Tromey  <[email protected]>
9497
9498         * target.c (target_follow_exec): Constify parameter.
9499         * target-delegates.c: Rebuild.
9500         * remote.c (remote_target::follow_exec): Constify parameter.
9501         * infrun.c (follow_exec): Constify parameter.
9502         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9503         (target_follow_exec): Likewise.
9504
9505 2019-05-22  Alan Hayward  <[email protected]>
9506
9507         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9508         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9509
9510 2019-05-22  Alan Hayward  <[email protected]>
9511
9512         * NEWS: Add debugredirect and testsuite sections.
9513
9514 2019-05-22  Simon Cook  <[email protected]>
9515
9516         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9517         target descriptions using exclusively floating point register name
9518         aliases.
9519
9520 2019-05-21  Andrew Burgess  <[email protected]>
9521
9522         PR gdb/18644:
9523         * f-lang.c (build_fortran_types): Handle the case where
9524         gdbarch_floatformat_for_type returns a nullptr.
9525
9526 2019-05-21  Tom de Vries  <[email protected]>
9527
9528         PR cli/24587
9529         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9530
9531 2019-05-18  Andrew Burgess  <[email protected]>
9532
9533         PR gdb/18644:
9534         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9535         16-byte floats.
9536         * i386-tdep.c (i386_floatformat_for_type): Use
9537         floatformats_ia64_quad for the 16-byte floating point component
9538         within a fortran 32-byte complex number.
9539
9540 2019-05-18  Andrew Burgess  <[email protected]>
9541
9542         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9543         delete default constructor.
9544         (find_partial_die): Update to return const struct.
9545         (partial_die_parent_scope): Move variable declaration into scope
9546         of its use and change its type to auto.
9547         (guess_partial_die_structure_name): Likewise.
9548         (partial_die_info::fixup): Likewise.
9549
9550 2019-05-17  Tom Tromey  <[email protected]>
9551
9552         * source.c (find_and_open_source): Remove cast.
9553
9554 2019-05-17  Tom Tromey  <[email protected]>
9555
9556         * annotate.c (annotate_source): Make "filename" const.
9557         * annotate.h (annotate_source): Use const.
9558
9559 2019-05-17  Alan Hayward  <[email protected]>
9560
9561         * disasm.c (set_disassembler_options): Send errors to stderr.
9562
9563 2019-05-17  Alan Hayward  <[email protected]>
9564
9565         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9566         (cli_interp_base::set_logging): Check debug_redirect.
9567         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9568         * cli/cli-logging.c (debug_redirect): Add static variable.
9569         (pop_output_files): Add default param.
9570         (handle_redirections): Print debug setting.
9571         (show_logging_command): Likewise.
9572         (_initialize_cli_logging): Add debugredirect command.
9573         * interps.c (current_interp_set_logging): Add debug_redirect
9574         parameter.
9575         * interps.h (set_logging): Add debug_redirect parameter.
9576         (current_interp_set_logging): Likewise.
9577         * mi/mi-common.h: Likewise.
9578         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9579
9580 2019-05-17  Alan Hayward  <[email protected]>
9581             Tom Tromey  <[email protected]>
9582
9583         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9584         directly.
9585         * cli/cli-interp.h (make_logging_output): Remove declaration.
9586         * cli/cli-logging.c (make_logging_output): Remove function.
9587         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9588         directly.
9589         * ui-file.c (tee_file::tee_file): Remove bools.
9590         (tee_file::~tee_file): Remove deletes.
9591         * ui-file.h (tee_file): Remove bools.
9592
9593 2019-01-28  Jan Vrany  <[email protected]>
9594
9595         * mi/mi-cmds.h (mi_cmd_complete): New function.
9596         * mi/mi-main.c (mi_cmd_complete): Likewise.
9597         * mi/mi-cmds.c: Define new MI command -complete.
9598         * NEWS: Mention new -complete command.
9599
9600 2019-01-24  Jan Vrany  <[email protected]>
9601
9602         * completer.h (complete): New function.
9603         * completer.c (complete): Likewise.
9604         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9605         function defined in completer.h.
9606
9607 2019-05-17  Jan Vrany  <[email protected]>
9608
9609         * MAINTAINERS (Write After Approval): Add myself.
9610
9611 2019-05-17  Tom de Vries  <[email protected]>
9612
9613         PR gdb/24094
9614         * dwarf2read.c (struct cu_partial_die_info): New struct.
9615         (find_partial_die): Return cu_partial_die_info.
9616         (partial_die_parent_scope, guess_partial_die_structure_name)
9617         (partial_die_info::fixup): Handle new return type of find_partial_die.
9618
9619 2019-05-16  Sergio Durigan Junior  <[email protected]>
9620
9621         PR breakpoints/24541
9622         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9623         "std::string", simplifying the algorithm.
9624
9625 2019-05-16  Sergio Durigan Junior  <[email protected]>
9626
9627         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9628         (stap_static_probe_ops::get_probes): Likewise.
9629
9630 2019-05-16  Sergio Durigan Junior  <[email protected]>
9631
9632         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9633         '-')" and "else if".
9634         (stap_parse_single_operand): Join checks for
9635         "gdbarch_stap_parse_special_token_p" and
9636         "gdbarch_stap_parse_special_token" in the same "if" statement.
9637         Invert check when verifying for operation on register
9638         displacement.
9639
9640 2019-05-16  Sergio Durigan Junior  <[email protected]>
9641
9642         * stap-probe.c (stap_get_opcode): Update comment.
9643         (stap_get_expected_argument_type): Likewise.
9644         (handle_stap_probe): Likewise.
9645
9646 2019-05-16  Sergio Durigan Junior  <[email protected]>
9647
9648         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9649         return type to 'bool'.  Adjust comment.  Use 'bool' when
9650         appropriate.
9651         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9652         * stap-probe.c (stap_parse_argument_1): Likewise.
9653         (stap_is_operator): Likewise.
9654         (stap_is_generic_prefix): Likewise.
9655         (stap_is_register_prefix): Likewise.
9656         (stap_is_register_indirection_prefix): Likewise.
9657         (stap_is_integer_prefix): Likewise.
9658         (stap_generic_check_suffix): Likewise.
9659         (stap_check_integer_suffix): Likewise.
9660         (stap_check_register_suffix): Likewise.
9661         (stap_check_register_indirection_suffix): Likewise.
9662         (stap_parse_register_operand): Likewise.
9663         (stap_parse_single_operand): Likewise.
9664         (stap_parse_argument_1): Likewise.
9665         (stap_probe::get_argument_count): Likewise.
9666         (stap_is_operator): Likewise.
9667
9668 2019-05-16  Tom Tromey  <[email protected]>
9669
9670         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9671         keyword to foreach.
9672
9673 2019-05-15  Simon Marchi  <[email protected]>
9674
9675         * linux-thread-db.c (try_thread_db_load_1): Change return type
9676         to bool.
9677         (try_thread_db_load): Likewise.
9678         (try_thread_db_load_from_pdir_1): Likewise.
9679         (try_thread_db_load_from_pdir): Likewise.
9680         (try_thread_db_load_from_sdir): Likewise.
9681         (try_thread_db_load_from_dir): Likewise.
9682         (thread_db_load_search): Likewise.
9683         (has_libpthread): Likewise.
9684         (thread_db_load): Likewise.
9685
9686 2019-05-15  Sergio Durigan Junior  <[email protected]>
9687
9688         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9689         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9690         NULL, and complain/return if that's the case.
9691
9692 2019-05-15  John Darrington <[email protected]>
9693
9694         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9695         (advance, posn, abstract_read_memory): New functions.
9696         [struct mem_read_abstraction]: New struct.
9697         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9698
9699 2019-05-14  Tom Tromey  <[email protected]>
9700
9701         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9702         value is not lval_memory.
9703
9704 2019-05-14  Tom Tromey  <[email protected]>
9705
9706         * solib.c (info_sharedlibrary_command): Style the file name.
9707
9708 2019-05-14  Alan Hayward  <[email protected]>
9709
9710         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9711         (aarch64_vnv_type): Likewise.
9712         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9713         * common/tdesc.c: Likewise.
9714         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9715         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9716         * features/aarch64-fpu.xml: Add ieee half view.
9717         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9718         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9719         * gdbtypes.h (struct builtin_type): Likewise.
9720         (struct objfile_type): Likewise.
9721
9722 2019-05-12  Paul Naert  <[email protected]>
9723
9724         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9725         typo.
9726         * location.h (string_to_event_location): Likewise.
9727
9728 2019-05-11  Joel Brobecker  <[email protected]>
9729
9730         GDB 8.3 released.
9731
9732 2019-05-10  Simon Marchi  <[email protected]>
9733
9734         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9735         New variable declaration.
9736         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9737         New variable.
9738         (print_one_breakpoint): Use ui_out::test_flags and new global
9739         variable to compute use_fixed_output.
9740         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9741         Remove.
9742         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9743         (mi_multi_location_breakpoint_output_fixed): Remove.
9744         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9745         new variable.
9746         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9747         fix_multi_location_breakpoint_output flag if version >= 3.
9748         * ui-out.h (enum ui_out_flag)
9749         <fix_multi_location_breakpoint_output>: New enumerator.
9750
9751 2019-05-10  Simon Marchi  <[email protected]>
9752
9753         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9754
9755 2019-05-10  Tom Tromey  <[email protected]>
9756
9757         * ada-lang.c (catch_ada_completer): New function.
9758         (_initialize_ada_language): Use it.
9759
9760 2019-05-10  Tom Tromey  <[email protected]>
9761
9762         * thread.c (print_thread_info): Make "requested_threads" const.
9763         * gdbthread.h (print_thread_info): Make "requested_threads"
9764         const.
9765         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9766         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9767
9768 2019-05-08  Tom Tromey  <[email protected]>
9769
9770         * gdbtypes.c (objfile_type_data): Change type.
9771         (objfile_type, _initialize_gdbtypes): Update.
9772
9773 2019-05-08  Tom Tromey  <[email protected]>
9774
9775         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9776         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9777         (_initialize_dwarf2_frame): Update.
9778
9779 2019-05-08  Tom Tromey  <[email protected]>
9780
9781         * objc-lang.c (objc_objfile_data): Change type.
9782         (find_methods): Update.
9783         (_initialize_objc_lang): Remove.
9784
9785 2019-05-08  Tom Tromey  <[email protected]>
9786
9787         * stabsread.c (rs6000_builtin_type_data): Change type.
9788         (rs6000_builtin_type, _initialize_stabsread): Update.
9789
9790 2019-05-08  Tom Tromey  <[email protected]>
9791
9792         * mips-tdep.c (mips_pdr_data): Remove.
9793         (_initialize_mips_tdep): Update.
9794
9795 2019-05-08  Tom Tromey  <[email protected]>
9796
9797         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9798         (hppa_init_objfile_priv_data, read_unwind_info)
9799         (find_unwind_entry, _initialize_hppa_tdep): Update.
9800
9801 2019-05-08  Tom Tromey  <[email protected]>
9802
9803         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9804         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9805         on obstack.
9806         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9807
9808 2019-05-08  Tom Tromey  <[email protected]>
9809
9810         * mdebugread.c (basic_type_data): Change type.
9811         (basic_type, _initialize_mdebugread): Update.
9812
9813 2019-05-08  Tom Tromey  <[email protected]>
9814
9815         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9816
9817 2019-05-08  Tom Tromey  <[email protected]>
9818
9819         * nto-tdep.c (nto_inferior_data_reg): Change type.
9820         (nto_inferior_data): Update.
9821         (nto_inferior_data_cleanup, nto_new_inferior_data)
9822         (_initialize_nto_tdep): Remove.
9823         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9824
9825 2019-05-08  Tom Tromey  <[email protected]>
9826
9827         * ada-lang.c (struct ada_inferior_data): Add initializers.
9828         (ada_inferior_data): Change type.
9829         (ada_inferior_data_cleanup): Remove.
9830         (get_ada_inferior_data, ada_inferior_exit)
9831         (struct ada_pspace_data): Add initializers, destructor.
9832         (ada_pspace_data_handle): Change type.
9833         (get_ada_pspace_data): Update.
9834         (ada_pspace_data_cleanup): Remove.
9835
9836 2019-05-08  Tom Tromey  <[email protected]>
9837
9838         * coffread.c (struct coff_symfile_info): Add initializers.
9839         (coff_objfile_data_key): Move lower.  Change type.
9840         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9841         Update.
9842         (coff_free_info): Remove.
9843
9844 2019-05-08  Tom Tromey  <[email protected]>
9845
9846         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9847         (fbsd_pspace_data_handle): Move lower.  Change type.
9848         (get_fbsd_pspace_data): Update.
9849         (fbsd_pspace_data_cleanup): Remove.
9850         (_initialize_fbsd_tdep): Update.
9851
9852 2019-05-08  Tom Tromey  <[email protected]>
9853
9854         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9855         (get_ada_tasks_pspace_data): Update.
9856         (ada_tasks_pspace_data_cleanup): Remove.
9857         (_initialize_tasks): Update.
9858         (ada_tasks_inferior_data_handle): Change type.
9859         (get_ada_tasks_inferior_data): Update.
9860         (ada_tasks_inferior_data_cleanup): Remove.
9861         (struct ada_tasks_pspace_data): Add initializers.
9862
9863 2019-05-08  Tom Tromey  <[email protected]>
9864
9865         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9866         * symfile-debug.c (debug_sym_get_probes): Change type.
9867         * stap-probe.c (handle_stap_probe):
9868         (stap_static_probe_ops::get_probes): Change type.
9869         * probe.h (class static_probe_ops) <get_probes>: Change type.
9870         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9871         (parse_probes_in_pspace): Update.
9872         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9873         Update.
9874         (any_static_probe_ops::get_probes): Change type.
9875         * elfread.c (elfread_data): New typedef.
9876         (probe_key): Change type.
9877         (elf_get_probes): Likewise.  Update.
9878         (probe_key_free): Remove.
9879         (_initialize_elfread): Update.
9880         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9881         Change type.
9882         (dtrace_process_dof_probe, dtrace_process_dof)
9883         (dtrace_static_probe_ops::get_probe): Change type.
9884
9885 2019-05-08  Tom Tromey  <[email protected]>
9886
9887         * xcoffread.c (struct xcoff_symfile_info): Rename from
9888         coff_symfile_info.  Add initializers.
9889         (xcoff_objfile_data_key): Move lower.  Change type.
9890         (XCOFF_DATA): Rewrite.
9891         (xcoff_free_info): Remove.
9892         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9893         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9894         (xcoff_initial_scan): Update.
9895
9896 2019-05-08  Tom Tromey  <[email protected]>
9897
9898         * solib-svr4.c (struct svr4_info): Add initializers and
9899         destructor.
9900         <probes_table>: Now an htab_up.
9901         (solib_svr4_pspace_data): Change type.
9902         (free_probes_table): Simplify.
9903         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9904         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9905         (probes_table_remove_objfile_probes, register_solib_event_probe)
9906         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9907         (_initialize_svr4_solib): Update.
9908
9909 2019-05-08  Tom Tromey  <[email protected]>
9910
9911         * remote.c (remote_pspace_data): Change type.
9912         (remote_pspace_data_cleanup): Remove.
9913         (get_remote_exec_file, set_pspace_remote_exec_file)
9914         (_initialize_remote): Update.
9915
9916 2019-05-08  Tom Tromey  <[email protected]>
9917
9918         * breakpoint.c (breakpoint_objfile_key): Change type.
9919         (get_breakpoint_objfile_data): Update.
9920         (free_breakpoint_objfile_data): Remove.
9921         (_initialize_breakpoint): Update.
9922
9923 2019-05-08  Tom Tromey  <[email protected]>
9924
9925         * linux-tdep.c (struct linux_info): Add initializers.
9926         (linux_inferior_data): Move.  Change type.
9927         (invalidate_linux_cache_inf): Update.
9928         (linux_inferior_data_cleanup): Remove.
9929         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9930
9931 2019-05-08  Tom Tromey  <[email protected]>
9932
9933         * auxv.c (auxv_inferior_data): Move.  Change type.
9934         (auxv_inferior_data_cleanup): Remove.
9935         (invalidate_auxv_cache_inf): Rewrite.
9936         (get_auxv_inferior_data, _initialize_auxv): Update.
9937
9938 2019-05-08  Tom Tromey  <[email protected]>
9939
9940         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9941         (symfile_debug_objfile_data_key): Change type.
9942         (symfile_debug_installed, debug_qf_has_symbols)
9943         (debug_qf_find_last_source_symtab)
9944         (debug_qf_forget_cached_source_info)
9945         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9946         (debug_qf_print_stats, debug_qf_dump)
9947         (debug_qf_expand_symtabs_for_function)
9948         (debug_qf_expand_all_symtabs)
9949         (debug_qf_expand_symtabs_with_fullname)
9950         (debug_qf_map_matching_symbols)
9951         (debug_qf_expand_symtabs_matching)
9952         (debug_qf_find_pc_sect_compunit_symtab)
9953         (debug_qf_map_symbol_filenames)
9954         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9955         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9956         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9957         (debug_sym_read_linetable, debug_sym_relocate): Update.
9958         (symfile_debug_free_objfile): Remove.
9959         (install_symfile_debug_logging, _initialize_symfile_debug):
9960         Update.
9961
9962 2019-05-08  Tom Tromey  <[email protected]>
9963
9964         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9965         allocate_on_obstack.
9966         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9967         (get_dwarf2_per_objfile): Update.
9968         (set_dwarf2_per_objfile): Remove.
9969         (dwarf2_has_info, dwarf2_get_section_info): Update.
9970         (dwarf2_free_objfile): Remove.
9971         (_initialize_dwarf2_read): Update.
9972
9973 2019-05-08  Tom Tromey  <[email protected]>
9974
9975         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9976         initializers.
9977         <unsupported_script_warning_printed,
9978         script_not_found_warning_printed>: Now bool.
9979         (auto_load_pspace_data): Change type.
9980         (~auto_load_pspace_info): Rename from
9981         auto_load_pspace_data_cleanup.
9982         (get_auto_load_pspace_data, init_loaded_scripts_info)
9983         (clear_section_scripts, maybe_print_unsupported_script_warning)
9984         (maybe_print_script_not_found_warning, _initialize_auto_load):
9985         Update.
9986
9987 2019-05-08  Tom Tromey  <[email protected]>
9988
9989         * objfiles.c (objfile_pspace_info): Add destructor and
9990         initializers.
9991         (objfiles_pspace_data): Change type.
9992         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9993         (get_objfile_pspace_data): Update.
9994         (objfiles_bfd_data): Change type.
9995         (get_objfile_bfd_data): Update.
9996         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9997
9998 2019-05-08  Tom Tromey  <[email protected]>
9999
10000         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10001         Change type.
10002         (get_catch_syscall_inferior_data): Update.
10003         (catch_syscall_inferior_data_cleanup): Remove.
10004         (_initialize_break_catch_syscall): Update.
10005
10006 2019-05-08  Tom Tromey  <[email protected]>
10007
10008         * inflow.c (struct terminal_info): Add destructor and
10009         initializers.
10010         (inflow_inferior_data): Change type.
10011         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10012         (get_inflow_inferior_data, inflow_inferior_exit)
10013         (swap_terminal_info, _initialize_inflow): Update.
10014
10015 2019-05-08  Tom Tromey  <[email protected]>
10016
10017         * target-dcache.c (target_dcache_cleanup): Remove.
10018         (target_dcache_aspace_key): Change type.
10019         (target_dcache_init_p, target_dcache_invalidate)
10020         (target_dcache_get, target_dcache_get_or_init)
10021         (_initialize_target_dcache): Update.
10022         * dcache.h (struct dcache_deleter): New.
10023
10024 2019-05-08  Tom Tromey  <[email protected]>
10025
10026         * symtab.c (struct symbol_cache): Add destructor and
10027         initializers.
10028         (symbol_cache_key): Move.  Change type.
10029         (make_symbol_cache, free_symbol_cache): Remove.
10030         (get_symbol_cache): Update.
10031         (symbol_cache_cleanup): Remove.
10032         (ALL_PSPACES, symbol_cache_flush)
10033         (maintenance_print_symbol_cache)
10034         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10035         Update.
10036
10037 2019-05-08  Tom Tromey  <[email protected]>
10038
10039         * symtab.c (struct main_info): Add destructor and initializers.
10040         (main_progspace_key): Move.  Change type.
10041         (get_main_info): Update.
10042         (main_info_cleanup): Remove.
10043         (_initialize_symtab): Update.
10044
10045 2019-05-08  Tom Tromey  <[email protected]>
10046
10047         * registry.h (DECLARE_REGISTRY): Define the _key class.
10048
10049 2019-05-08  Andrew Burgess  <[email protected]>
10050
10051         * NEWS: Merge two 'New commands' sections.
10052
10053 2019-05-08  Joel Brobecker  <[email protected]>
10054
10055         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10056         parameter and use Ada language definition instead.
10057         (ada_val_print_ptr): Remove unused language parameter.
10058         (ada_val_print_num): Remove language parameter and use Ada language
10059         definition instead.
10060         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10061         parameter.
10062         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10063         parameter and use Ada language definition instead.
10064         (ada_val_print_1): Update all ada_val_print_xxx calls.
10065         Remove language parameter.
10066         (ada_val_print): Update ada_val_print_1 call.
10067
10068 2019-05-08  Tom Tromey  <[email protected]>
10069
10070         * remote.c (remote_hw_watchpoint_limit)
10071         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10072         Now static.
10073
10074 2019-05-08  Tom Tromey  <[email protected]>
10075
10076         * maint.c (_initialize_maint_cmds): Move initialization code to
10077         remote.c.
10078         (watchdog, show_watchdog): Move to remote.c.
10079         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10080         "watchdog" static.
10081         (_initialize_remote): Move initialization code from maint.c.
10082         * defs.h (watchdog): Don't declare.
10083
10084 2019-05-08  Tom Tromey  <[email protected]>
10085
10086         * tui/tui-interp.c: Include main.h.
10087         * interps.c: Include main.h.
10088         * main.h (interpreter_p): Declare.
10089         * defs.h (interpreter_p): Don't declare.
10090
10091 2019-05-08  Tom Tromey  <[email protected]>
10092
10093         * dwarf2loc.c: Include dwarf2read.h.
10094         * defs.h (read_unsigned_leb128): Don't declare.
10095         * dwarf2read.h (read_unsigned_leb128): Declare.
10096
10097 2019-05-08  Tom Tromey  <[email protected]>
10098
10099         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10100         method.
10101
10102 2019-05-08  Tom Tromey  <[email protected]>
10103
10104         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10105         when no wrap column is set.
10106
10107 2019-05-08  Tom Tromey  <[email protected]>
10108
10109         * c-lang.c (c_get_string): Handle non-C-style arrays.
10110
10111 2019-05-08  Tom Tromey  <[email protected]>
10112
10113         * typeprint.c (print_offset_data::update): Print the bit offset,
10114         not the number of bits remaining.
10115
10116 2019-05-08  Tom Tromey  <[email protected]>
10117
10118         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10119         padding at end of comment.
10120
10121 2019-05-08  Tom Tromey  <[email protected]>
10122
10123         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10124         Compare main types.
10125
10126 2019-05-06  Tom Tromey  <[email protected]>
10127
10128         * common/scoped_mmap.c: Include common-defs.h.
10129         * common/scoped_mmap.h: Don't include config.h.
10130
10131 2019-05-04  Tom Tromey  <[email protected]>
10132
10133         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10134         (struct aarch64_call_info): Add initializers.
10135         <si>: Now a std::vector.
10136         (pass_on_stack, aarch64_push_dummy_call): Update.
10137
10138 2019-05-04  Simon Marchi  <[email protected]>
10139             Tom Tromey  <[email protected]>
10140
10141         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10142         (ppc_threads): Now a std::vector.  Now static.
10143         (hwdebug_find_thread_points_by_tid)
10144         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10145         Update.
10146
10147 2019-05-04  Tom Tromey  <[email protected]>
10148
10149         * arc-tdep.c (arc_tdesc_init): Return bool.
10150
10151 2019-05-04  Tom Tromey  <[email protected]>
10152
10153         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10154         Use gdb_assert_not_reached.
10155
10156 2019-05-04  Tom Tromey  <[email protected]>
10157
10158         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10159         "false".
10160
10161 2019-05-04  Tom Tromey  <[email protected]>
10162
10163         * arc-tdep.c (arc_tdesc_init): Use bool.
10164
10165 2019-05-04  Tom Tromey  <[email protected]>
10166
10167         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10168
10169 2019-05-04  Tom Tromey  <[email protected]>
10170
10171         * cli/cli-cmds.c (valid_command_p): Return bool.
10172
10173 2019-05-04  Tom Tromey  <[email protected]>
10174
10175         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10176         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10177
10178 2019-05-04  Raul Tambre  <[email protected]>
10179
10180         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10181         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10182         operator for comparison.
10183
10184 2019-05-04  Tom Tromey  <[email protected]>
10185
10186         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10187         (lookup_partial_symbol, print_partial_symbols)
10188         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10189         (psymbol_compare): Update.
10190         (add_psymbol_to_bcache): Clear the entire psymbol.
10191         (maintenance_check_psymtabs): Update.
10192         * psympriv.h (struct partial_symbol): Don't derive from
10193         general_symbol_info.
10194         <obj_section, unrelocated_address, address,
10195         set_unrelocated_address>: Update.
10196         <ginfo>: New member.
10197         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10198         (debug_names::write_psymbols): Update.
10199
10200 2019-05-04  Tom de Vries  <[email protected]>
10201
10202         * contrib/cc-with-tweaks.sh: Support -n arg.
10203
10204 2019-05-04  Philippe Waroquiers  <[email protected]>
10205
10206         * corelow.c (core_target::detach): Ensure frame cache and
10207         register caches are cleared.
10208         inferior.c (exit_inferior_1): Likewise.
10209
10210 2019-05-03  Sandra Loosemore  <[email protected]>
10211             Tom Tromey  <[email protected]>
10212
10213         * dictionary.c (collate_pending_symbols_by_language): Remove
10214         "struct" from foreach.
10215         * symtab.c (lookup_global_symbol_from_objfile)
10216         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10217         foreach.
10218         * ser-tcp.c (net_open): Remove "struct" from foreach.
10219         * objfiles.c (objfile_relocate, objfile_rebase)
10220         (objfile_has_symbols): Remove "struct" from foreach.
10221         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10222         from foreach.
10223         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10224         foreach.
10225         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10226         "struct" from foreach.
10227         * ada-lang.c (create_excep_cond_exprs)
10228         (ada_exception_catchpoint_cond_string): Remove "struct" from
10229         foreach.
10230
10231 2019-05-03  Tom Tromey  <[email protected]>
10232
10233         * ada-exp.y (convert_char_literal): Check suffix of each
10234         enumerator.
10235
10236 2019-05-03  Dilyan Palauzov  <[email protected]>
10237
10238         PR ada/21406:
10239         * ada-exp.y (yywrap): Don't define.
10240         * ada-lex.l (%option): Add noyywrap
10241         (yywrap): Remove.
10242
10243 2019-05-03  Eli Zaretskii  <[email protected]>
10244
10245         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10246         _WIN32_WINNT to the XP level, unless already defined to a higher
10247         level.
10248
10249         * unittests/parse-connection-spec-selftests.c:
10250         * ser-tcp.c:
10251         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10252         override.
10253
10254         * symfile.c (find_separate_debug_file): Remove colon from the
10255         drive spec of DOS/Windows file names of the target, so that the
10256         file name produced from DEBUGDIR and the target's directory will
10257         be valid on DOS/Windows systems.
10258
10259 2019-05-02  Andrew Burgess  <[email protected]>
10260
10261         * rust-lang.c (val_print_struct): Handle printing structures
10262         containing strings.
10263
10264 2019-05-02  Tom Tromey  <[email protected]>
10265
10266         * valarith.c (_initialize_valarith): Remove.
10267
10268 2019-05-01  Tom Tromey  <[email protected]>
10269
10270         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10271         bitfields.
10272
10273 2019-05-01  Tom Tromey  <[email protected]>
10274
10275         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10276         for big-endian copies.
10277
10278 2019-04-30  Ali Tamur  <[email protected]>
10279         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10280         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10281         (read_3_bytes): New function.
10282
10283 2019-04-30  Joel Brobecker  <[email protected]>
10284
10285         * windows-nat.c (main_thread_id): Delete.
10286         (handle_output_debug_string): Replace main_thread_id by
10287         current_event.dwThreadId.
10288         (fake_create_process): Likewise.
10289         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10290         Do not set main_thread_id.
10291         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10292         current_event.dwThreadId.
10293         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10294
10295 2019-04-30  Joel Brobecker  <[email protected]>
10296
10297         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10298         Use current_event.dwThreadId instead of main_thread_id.
10299
10300 2019-04-30  Tom Tromey  <[email protected]>
10301
10302         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10303         (create_excep_cond_exprs): Iterate over program spaces.
10304         (ada_exception_catchpoint_cond_string): Examine all minimal
10305         symbols for exception types.
10306
10307 2019-04-30  Tom Tromey  <[email protected]>
10308
10309         PR c++/24470:
10310         * dwarf2read.c (process_structure_scope): Handle case where type
10311         has template parameters but no symbol was created.
10312
10313 2019-04-30  Andrew Burgess  <[email protected]>
10314             Chris January  <[email protected]>
10315
10316         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10317         qualifier.
10318         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10319
10320 2019-04-30  Andrew Burgess  <[email protected]>
10321
10322         * f-typeprint.c (f_print_type): Update rules for printing
10323         whitespace.
10324         (f_type_print_varspec_suffix): Likewise.
10325
10326 2019-04-30  Andrew Burgess  <[email protected]>
10327             Chris January  <[email protected]>
10328
10329         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10330         function arguments.
10331
10332 2019-04-30  Andrew Burgess  <[email protected]>
10333
10334         * f-lang.c (build_fortran_types): Change name of void type to
10335         lower case.
10336         * f-typeprint.c (f_type_print_base): Print the name of the void
10337         type, rather than a fixed string.
10338         * f-valprint.c (f_decorations): Use lower case void string.
10339
10340 2019-04-30  Andrew Burgess  <[email protected]>
10341             Chris January  <[email protected]>
10342
10343         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10344         types for Fortran.
10345
10346 2019-04-30  Andrew Burgess  <[email protected]>
10347             Chris January  <[email protected]>
10348             David Lecomber  <[email protected]>
10349
10350         * f-exp.y (BINOP_INTRINSIC): New token.
10351         (exp): New parser rule handling BINOP_INTRINSIC.
10352         (f77_keywords): Add new builtin procedures.
10353         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10354         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10355         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10356         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10357         (print_unop_subexp_f): New function.
10358         (print_binop_subexp_f): New function.
10359         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10360         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10361         (dump_subexp_body_f): Likewise.
10362         (operator_check_f): Likewise.
10363         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10364         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10365
10366 2019-04-30  Andrew Burgess  <[email protected]>
10367
10368         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10369         UNOP_KIND.
10370         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10371         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10372         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10373         (operator_length_f): New fuction.
10374         (print_subexp_f): New function.
10375         (op_name_f): New function.
10376         (dump_subexp_body_f): New function.
10377         (operator_check_f): New function.
10378         (exp_descriptor_f): Replace standard expression handling functions
10379         with new functions.
10380         * gdb/fortran-operator.def: New file.
10381         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10382         * gdb/std-operator.def: Remove UNOP_KIND.
10383
10384 2019-04-30  Andrew Burgess  <[email protected]>
10385
10386         * std-operator.def: Remove unbalanced, stray double quote
10387         character.
10388
10389 2019-04-29  Andrew Burgess  <[email protected]>
10390             Chris January  <[email protected]>
10391             Daniel Everett  <[email protected]>
10392             Nick Forrington  <[email protected]>
10393             Richard Bunt  <[email protected]>
10394
10395         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10396         of depth when printing anonymous structs or unions.
10397         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10398         Don't print either the top-level value, or the children if the
10399         max-depth is exceeded.
10400         (ppscm_print_children): When printing the key of a map, allow one
10401         extra level of depth.
10402         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10403         print either the top-level value, or the children if the max-depth
10404         is exceeded.
10405         (print_children): When printing the key of a map, allow one extra
10406         level of depth.
10407         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10408         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10409         (user_print_options): Initialise max_depth field.
10410         (val_print_scalar_or_string_type_p): New function.
10411         (val_print): Check to see if the max depth has been reached.
10412         (val_print_check_max_depth): Define new function.
10413         (show_print_max_depth): New function.
10414         (_initialize_valprint): Add 'print max-depth' option.
10415         * valprint.h (struct value_print_options) <max_depth>: New field.
10416         (val_print_check_max_depth): Declare new function.
10417         * NEWS: Document new feature.
10418
10419 2019-04-29  Andrew Burgess  <[email protected]>
10420
10421         * ada-lang.c (ada_language_defn): Initialise new field.
10422         * c-lang.c (c_is_string_type_p): New function.
10423         (c_language_defn): Initialise new field.
10424         (cplus_language_defn): Initialise new field.
10425         (asm_language_defn): Initialise new field.
10426         (minimal_language_defn): Initialise new field.
10427         * c-lang.h (c_is_string_type_p): Declare new function.
10428         * d-lang.c (d_language_defn): Initialise new field.
10429         * f-lang.c (f_is_string_type_p): New function.
10430         (f_language_defn): Initialise new field.
10431         * go-lang.c (go_is_string_type_p): New function.
10432         (go_language_defn): Initialise new field.
10433         * language.c (default_is_string_type_p): New function.
10434         (unknown_language_defn): Initialise new field.
10435         (auto_language_defn): Initialise new field.
10436         * language.h (struct language_defn) <la_is_string_type_p>: New
10437         member variable.
10438         (default_is_string_type_p): Declare new function.
10439         * m2-lang.c (m2_language_defn): Initialise new field.
10440         * objc-lang.c (objc_language_defn): Initialise new field.
10441         * opencl-lang.c (opencl_language_defn): Initialise new field.
10442         * p-lang.c (pascal_is_string_type_p): New function.
10443         (pascal_language_defn): Initialise new field.
10444         * rust-lang.c (rust_is_string_type_p): New function.
10445         (rust_language_defn): Initialise new field.
10446
10447 2019-04-29  Andrew Burgess  <[email protected]>
10448
10449         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10450         New field.
10451         * ada-lang.c (ada_language_defn): Initialise new field.
10452         * c-lang.c (c_language_defn): Likewise.
10453         (cplus_language_defn): Likewise.
10454         (asm_language_defn): Likewise.
10455         (minimal_language_defn): Likewise.
10456         * d-lang.c (d_language_defn): Likewise.
10457         * f-lang.c (f_language_defn): Likewise.
10458         * go-lang.c (go_language_defn): Likewise.
10459         * language.c (unknown_language_defn): Likewise.
10460         (auto_language_defn): Likewise.
10461         * m2-lang.c (m2_language_defn): Likewise.
10462         * objc-lang.c (objc_language_defn): Likewise.
10463         * opencl-lang.c (opencl_language_defn): Likewise.
10464         * p-lang.c (pascal_language_defn): Likewise.
10465         * rust-lang.c (rust_language_defn): Likewise.
10466
10467 2019-04-29  Andrew Burgess  <[email protected]>
10468
10469         * ada-lang.c (ada_is_character_type): Change return type to bool.
10470         (ada_is_string_type): Likewise.
10471         * ada-lang.h (ada_is_character_type): Update declaration
10472         (ada_is_string_type): Likewise.
10473
10474 2019-04-27  Philippe Waroquiers  <[email protected]>
10475
10476         Support style in 'frame|thread apply'
10477
10478         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10479         * record.c (record_start, record_stop): Update callers of
10480         execute_command_to_string with false.
10481         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10482         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10483         methods.
10484         (class string_file): New constructor with term_out parameter.
10485         Override methods term_out and can_emit_style_escape.  New member
10486         term_out.
10487         (class stdio_file): Override can_emit_style_escape.
10488         (class tee_file): Override term_out and can_emit_style_escape.
10489         * utils.h (can_emit_style_escape): Remove.
10490         * utils.c (can_emit_style_escape): Likewise.
10491         Update all callers of can_emit_style_escape (SOMESTREAM) to
10492         SOMESTREAM->can_emit_style_escape.
10493         * source-cache.c (source_cache::get_source_lines): Likewise.
10494         * stack.c (frame_apply_command_count): Call execute_command_to_string
10495         passing the term_out characteristic of the current gdb_stdout.
10496         * thread.c (thr_try_catch_cmd): Likewise.
10497         * top.c (execute_command_to_string): pass term_out parameter
10498         to construct the string_file for the command output.
10499         * ui-file.c (term_cli_styling): New function (most code moved
10500         from utils.c can_emit_style_escape).
10501         (string_file::string_file, string_file::can_emit_style_escape,
10502         stdio_file::can_emit_style_escape, tee_file::term_out,
10503         tee_file::can_emit_style_escape): New functions.
10504
10505 2019-04-27  Philippe Waroquiers  <[email protected]>
10506
10507         * NEWS: Mention the new set|show may-call-functions.
10508         * infcall.c (may_call_functions_p): New variable.
10509         (show_may_call_functions_p): New function.
10510         (call_function_by_hand_dummy): Throws an error if not
10511         may-call-functions.
10512         (_initialize_infcall): Call add_setshow_boolean_cmd for
10513         may-call-functions.
10514
10515 2019-04-25  Keith Seitz  <[email protected]>
10516
10517         PR c++/24367
10518         * cp-support.c (inspect_type): Don't attempt substitutions
10519         of symbol with the same name.
10520
10521 2019-04-25  Tom Tromey  <[email protected]>
10522
10523         PR gdb/24475:
10524         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10525         static.
10526
10527 2019-04-25  Tom Tromey  <[email protected]>
10528
10529         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10530         rvalue reference.
10531         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10532         (gdb_xml_parser::parse): Use std::move.
10533         * python/python-internal.h (gdbpy_convert_exception): Take a const
10534         reference.
10535         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10536         std::move.
10537         * python/py-utils.c (gdbpy_convert_exception): Take a const
10538         reference.
10539         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10540         Use std::move.
10541         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10542         Use std::move.
10543         * mi/mi-main.c (mi_print_exception): Take a const reference.
10544         * main.c (handle_command_errors): Take a const reference.
10545         * linespec.c (parse_linespec): Use std::move.
10546         * infcall.c (run_inferior_call): Use std::move.
10547         (call_function_by_hand_dummy): Use std::move.
10548         * exec.c (try_open_exec_file): Use std::move.
10549         * exceptions.h (exception_print, exception_fprintf)
10550         (exception_print_same): Update.
10551         * exceptions.c (print_exception, exception_print)
10552         (exception_fprintf, exception_print_same): Change parameters to
10553         const reference.
10554         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10555         * common/new-op.c: Use std::move.
10556         * common/common-exceptions.h (struct gdb_exception): Add move
10557         constructor.
10558         (struct gdb_exception_error, struct gdb_exception_quit, struct
10559         gdb_quit_bad_alloc): Change constructor to move constructor.
10560         (throw_exception): Change parameter to rvalue reference.
10561         * common/common-exceptions.c (throw_exception): Take rvalue
10562         reference.
10563         * cli/cli-interp.c (safe_execute_command): Use std::move.
10564         * breakpoint.c (insert_bp_location, location_to_sals): Use
10565         std::move.
10566
10567 2019-04-25  Tom Tromey  <[email protected]>
10568
10569         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10570         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10571         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10572         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10573         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10574         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10575         guile/scm-value.c: Use unpack.
10576         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10577         gdbscm_gdb_exception.
10578         (gdbscm_throw_gdb_exception): Likewise.
10579         (struct gdbscm_gdb_exception): New.
10580         (unpack): New function.
10581         (gdbscm_wrap): Use unpack.
10582
10583 2019-04-25  Tom Tromey  <[email protected]>
10584
10585         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10586         (gdb_rl_callback_handler): Use std::move.
10587         * common/common-exceptions.h (struct gdb_exception): Add move
10588         assignment operator.
10589         (throw_exception_sjlj): Change "exception" to const reference.
10590         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10591         (throw_exception_sjlj): Change "exception" to const reference.
10592
10593 2019-04-25  Tom Tromey  <[email protected]>
10594
10595         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10596         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10597         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10598         Update.
10599         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10600         Update.
10601         * mi/mi-interp.c (mi_interp::exec): Update.
10602         * linespec.c (parse_linespec): Update.
10603         * infcall.c (run_inferior_call): Update.
10604         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10605         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10606         (gdbscm_lookup_global_symbol): Update.
10607         * guile/scm-param.c (gdbscm_parameter_value): Update.
10608         * guile/scm-frame.c (gdbscm_frame_read_register)
10609         (gdbscm_frame_read_var): Update.
10610         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10611         * exec.c (try_open_exec_file): Update.
10612         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10613         (gdb_rl_callback_handler): Update.
10614         * common/common-exceptions.h (exception_none): Don't declare.
10615         * common/common-exceptions.c (exception_none): Don't define.
10616         (struct catcher) <exception>: Update.
10617         * cli/cli-interp.c (safe_execute_command): Update.
10618         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10619
10620 2019-04-25  Ali Tamur  <[email protected]>
10621
10622         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10623         (read_attribute_value): Likewise.
10624         (dwarf2_read_addr_index): Update comment.
10625         (read_str_index): Add DW_FORM_strx.
10626         (dwarf2_string_attr): Likewise.
10627         (dwarf2_const_value_attr): Likewise.
10628         (dump_die_shallow): Likewise.
10629         (dwarf2_fetch_constant_bytes): Likewise.
10630         (skip_form_bytes): Likewise.
10631         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10632
10633 2019-04-25  Sergio Durigan Junior  <[email protected]>
10634
10635         PR corefiles/11608
10636         PR corefiles/18187
10637         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10638         OFFSET.  Verify if current mapping contains an ELF header.
10639         (linux_find_memory_regions_full): Adjust call to
10640         dump_mapping_p.
10641
10642 2019-04-25  Sandra Loosemore  <[email protected]>
10643             Kang Li <[email protected]>
10644
10645         PR gdb/21600
10646
10647         * dwarf2-frame.c (read_initial_length): Be consistent about using
10648         unsigned representation of length.
10649         (decode_frame_entry_1): Likewise.  Check for wraparound of
10650         end pointer as well as buffer overflow.
10651
10652 2019-04-24  Sergio Durigan Junior  <[email protected]>
10653
10654         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10655         "vq".
10656
10657 2019-04-24  Tom Tromey  <[email protected]>
10658
10659         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10660
10661 2019-04-23  Andrew Burgess  <[email protected]>
10662
10663         * s12z-tdep.c (s12z_unwind_pc): Delete.
10664         (s12z_unwind_sp): Delete.
10665         (s12z_gdbarch_init): Don't register deleted functions with
10666         gdbarch.
10667
10668 2019-04-23  Andrew Burgess  <[email protected]>
10669
10670         * rl78-tdep.c (rl78_unwind_sp): Delete.
10671         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10672
10673 2019-04-23  Andrew Burgess  <[email protected]>
10674
10675         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10676         (xstormy16_unwind_pc): Delete.
10677         (xstormy16_dummy_id): Delete.
10678         (xstormy16_gdbarch_init): Don't register deleted functions with
10679         gdbarch.
10680
10681 2019-04-23  Andrew Burgess  <[email protected]>
10682
10683         * vax-tdep.c (vax_unwind_pc): Delete.
10684         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10685
10686 2019-04-23  Andrew Burgess  <[email protected]>
10687
10688         * v850-tdep.c (v850_unwind_sp): Delete.
10689         (v850_unwind_pc): Delete.
10690         (v850_dummy_id): Delete.
10691         (v850_gdbarch_init): Don't register deleted functions with
10692         gdbarch.
10693
10694 2019-04-23  Andrew Burgess  <[email protected]>
10695
10696         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10697         (tilegx_unwind_pc): Delete.
10698         (tilegx_unwind_dummy_id): Delete.
10699         (tilegx_gdbarch_init): Don't register deleted functions with
10700         gdbarch.
10701
10702 2019-04-23  Andrew Burgess  <[email protected]>
10703
10704         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10705         (tic6x_dummy_id): Delete.
10706         (tic6x_gdbarch_init): Don't register deleted functions with
10707         gdbarch.
10708
10709 2019-04-23  Andrew Burgess  <[email protected]>
10710
10711         * sparc-tdep.c (sparc_unwind_pc): Delete.
10712         (sparc32_gdbarch_init): Don't register deleted function with
10713         gdbarch.
10714
10715 2019-04-23  Andrew Burgess  <[email protected]>
10716
10717         * sh-tdep.c (sh_unwind_sp): Delete.
10718         (sh_unwind_pc): Delete.
10719         (sh_dummy_id): Delete.
10720         (sh_gdbarch_init): Don't register deleted functions with
10721         gdbarch.
10722
10723 2019-04-23  Andrew Burgess  <[email protected]>
10724
10725         * score-tdep.c (score_unwind_sp): Delete.
10726         (score_unwind_pc): Delete.
10727         (score_dummy_id): Delete.
10728         (score_gdbarch_init): Don't register deleted functions with
10729         gdbarch.
10730
10731 2019-04-23  Andrew Burgess  <[email protected]>
10732
10733         * rx-tdep.c (rx_unwind_pc): Delete.
10734         (rx_unwind_sp): Delete.
10735         (rx_dummy_id): Delete.
10736         (rx_gdbarch_init): Don't register deleted functions with
10737         gdbarch.  Update comment.
10738
10739 2019-04-23  Andrew Burgess  <[email protected]>
10740
10741         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10742         (rs6000_dummy_id): Delete.
10743         (rs6000_gdbarch_init): Don't register deleted functions with
10744         gdbarch.
10745
10746 2019-04-23  Andrew Burgess  <[email protected]>
10747
10748         * or1k-tdep.c (or1k_dummy_id): Delete.
10749         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10750
10751 2019-04-23  Andrew Burgess  <[email protected]>
10752
10753         * nios2-tdep.c (nios2_dummy_id): Delete.
10754         (nios2_unwind_sp): Delete.
10755         (nios2_gdbarch_init): Don't register deleted functions with
10756         gdbarch.
10757
10758 2019-04-23  Andrew Burgess  <[email protected]>
10759
10760         * nds32-tdep.c (nds32_dummy_id): Delete.
10761         (nds32_unwind_pc): Delete.
10762         (nds32_unwind_sp): Delete.
10763         (nds32_gdbarch_init): Don't register deleted functions with
10764         gdbarch.
10765
10766 2019-04-23  Andrew Burgess  <[email protected]>
10767
10768         * msp430-tdep.c (msp430_unwind_pc): Delete.
10769         (msp430_unwind_sp): Delete.
10770         (msp430_dummy_id): Delete.
10771         (msp430_gdbarch_init): Don't register deleted functions with
10772         gdbarch.
10773
10774 2019-04-23  Andrew Burgess  <[email protected]>
10775
10776         * moxie-tdep.c (moxie_unwind_sp): Delete.
10777         (moxie_unwind_pc): Delete.
10778         (moxie_dummy_id): Delete.
10779         (moxie_gdbarch_init): Don't register deleted functions with
10780         gdbarch.
10781
10782 2019-04-23  Andrew Burgess  <[email protected]>
10783
10784         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10785         (mn10300_unwind_pc): Delete.
10786         (mn10300_unwind_sp): Delete.
10787         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10788         mn10300_unwind_sp.
10789         (mn10300_frame_unwind_init): Don't register deleted functions with
10790         gdbarch.
10791
10792 2019-04-23  Andrew Burgess  <[email protected]>
10793
10794         * mep-tdep.c (mep_unwind_pc): Delete.
10795         (mep_unwind_sp): Delete.
10796         (mep_dummy_id): Delete.
10797         (mep_gdbarch_init): Don't register deleted functions with
10798         gdbarch.
10799
10800 2019-04-23  Andrew Burgess  <[email protected]>
10801
10802         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10803         (m68hc11_unwind_sp): Delete.
10804         (m68hc11_gdbarch_init): Don't register deleted functions with
10805         gdbarch.
10806
10807 2019-04-23  Andrew Burgess  <[email protected]>
10808
10809         * m32r-tdep.c (m32r_unwind_sp): Delete.
10810         (m32r_unwind_pc): Delete.
10811         (m32r_dummy_id): Delete.
10812         (m32r_gdbarch_init): Don't register deleted functions with
10813         gdbarch.
10814
10815 2019-04-23  Andrew Burgess  <[email protected]>
10816
10817         * m32c-tdep.c (m32c_unwind_pc): Delete.
10818         (m32c_unwind_sp): Delete.
10819         (m32c_dummy_id): Delete.
10820         (m32c_gdbarch_init): Don't register deleted functions with
10821         gdbarch.
10822
10823 2019-04-23  Andrew Burgess  <[email protected]>
10824
10825         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10826         (lm32_unwind_pc): Delete.
10827         (lm32_dummy_id): Delete.
10828         (lm32_gdbarch_init): Don't register deleted functions with
10829         gdbarch.
10830
10831 2019-04-23  Andrew Burgess  <[email protected]>
10832
10833         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10834         (iq2000_unwind_pc): Delete.
10835         (iq2000_dummy_id): Delete.
10836         (iq2000_gdbarch_init): Don't register deleted functions with
10837         gdbarch.
10838
10839 2019-04-23  Andrew Burgess  <[email protected]>
10840
10841         * nds32-tdep.c (nds32_type_align): Delete.
10842         (nds32_push_dummy_call): Use type_align instead.
10843
10844 2019-04-23  Andrew Burgess  <[email protected]>
10845
10846         * arm-tdep.c (arm_type_align): Only handle vector override case.
10847         (arm_push_dummy_call): Use type_align.
10848         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10849
10850 2019-04-23  Andrew Burgess  <[email protected]>
10851
10852         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10853         case.
10854         (pass_on_stack): Use type_align.
10855         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10856         function.
10857
10858 2019-04-23  Tom Tromey  <[email protected]>
10859
10860         * dwarf2read.c (line_header::file_name_at): Remove unused
10861         overload.
10862
10863 2019-04-23  Tom de Vries  <[email protected]>
10864
10865         PR gdb/24438
10866         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10867         invocation.
10868
10869
10870 2019-03-27  Ali Tamur  <[email protected]>
10871
10872         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10873         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10874         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10875         (dwarf_expr_context::get_addr_index): Likewise
10876         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10877         (symbol_needs_eval_context::get_addr_index): Likewise
10878         (disassemble_dwarf_expression): Add DW_OP_addrx
10879         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10880         (read_cutu_die_from_dwo): Update comment
10881         (skip_one_die): Add DW_FORM_addrx
10882         (read_attribute_value): Likewise
10883         (var_decode_location): Add DW_OP_addrx
10884         (dwarf2_const_value_attr): Add DW_FORM_addrx
10885         (dump_die_shallow): Likewise
10886         (dwarf2_fetch_constant_bytes): Likewise
10887         (decode_locdesc): Add DW_OP_addrx
10888         (skip_form_bytes): Add DW_FORM_addrx
10889
10890 2019-04-22  Ali Tamur  <[email protected]>
10891
10892         * MAINTAINERS (Write After Approval): Add self.
10893
10894 2019-04-22  Simon Marchi  <[email protected]>
10895
10896         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10897         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10898         (open_symbol_file_object): Likewise.
10899         (svr4_default_sos): Add info parameter.
10900         (svr4_read_so_list): Likewise.
10901         (svr4_current_sos_direct): Adjust functions calls to pass down
10902         info.
10903         (svr4_current_sos_1): Add info parameter.
10904         (svr4_current_sos): Call get_svr4_info, pass info down to
10905         svr4_current_sos_1.
10906         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10907         get_svr4_info.
10908         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10909         get_svr4_info.
10910         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10911         to get_svr4_info.
10912         (probes_table_remove_objfile_probes): Likewise.
10913         (register_solib_event_probe): Add info parameter.
10914         (solist_update_incremental): Pass info parameter down to
10915         svr4_read_so_list.
10916         (disable_probes_interface): Add info parameter.
10917         (svr4_handle_solib_event): Pass current_program_space to
10918         get_svr4_info.  Adjust disable_probes_interface cleanup.
10919         (svr4_create_probe_breakpoints): Add info parameter, pass it
10920         down to register_solib_event_probe.
10921         (svr4_create_solib_event_breakpoints): Add info parameter,
10922         pass it down to svr4_create_probe_breakpoints.
10923         (enable_break): Pass info down to
10924         svr4_create_solib_event_breakpoints.
10925         (svr4_solib_create_inferior_hook): Pass current_program_space to
10926         get_svr4_info.
10927         (svr4_clear_solib): Likewise.
10928
10929 2019-04-22  Pedro Alves  <[email protected]>
10930
10931         * solib-svr4.c (svr4_free_objfile_observer): New.
10932         (probe_and_action::objfile): New field.
10933         (probes_table_htab_remove_objfile_probes)
10934         (probes_table_remove_objfile_probes): New functions.
10935         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10936         in the new probe_and_action.  Don't store the probe in 'lookup'.
10937         (svr4_create_probe_breakpoints): Pass objfile to
10938         register_solib_event_probe.
10939         (_initialize_svr4_solib): Register a free_objfile observer.
10940
10941 2019-04-19  Tom Tromey  <[email protected]>
10942
10943         * common/queue.h: Remove.
10944
10945 2019-04-19  Tom Tromey  <[email protected]>
10946
10947         * event-loop.c: Don't include "common/queue.h".
10948
10949 2019-04-19  Tom Tromey  <[email protected]>
10950
10951         * remote.c (remote_target): Use delete.
10952         * remote-notif.h: Include <list>, not "common/queue.h".
10953         (notif_client_p): Remove typedef.
10954         (remote_notif_state): Add constructor, destructor, initializer.
10955         <notif_queue>: Now a std::list.
10956         (remote_notif_state_xfree): Don't declare.
10957         * remote-notif.c (remote_notif_process, handle_notification)
10958         (remote_notif_state_allocate): Update.
10959         (~remote_notif_state): Rename from remote_notif_state_xfree.
10960
10961 2019-04-19  Tom Tromey  <[email protected]>
10962
10963         * symfile.c (reread_symbols): Update.
10964         * objfiles.c (objfile_register_static_link)
10965         (objfile_lookup_static_link): Update
10966         (~objfile) Don't delete static_links.
10967         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10968
10969 2019-04-19  Tom Tromey  <[email protected]>
10970
10971         * type-stack.h (struct type_stack) <insert>: Constify string.
10972         * type-stack.c (type_stack::insert): Constify string.
10973         * gdbtypes.h (lookup_template_type): Update.
10974         (address_space_name_to_int): Update.
10975         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10976         const.
10977         (lookup_template_type): Make name const.
10978         * c-exp.y: Update rules.
10979         (lex_one_token, classify_name, classify_inner_name)
10980         (c_print_token): Update.
10981         * p-exp.y: Update rules.
10982         (yylex): Update.
10983         * f-exp.y: Update rules.
10984         (yylex): Update.
10985         * d-exp.y: Update rules.
10986         (lex_one_token, classify_name, classify_inner_name): Update.
10987         * parse.c (write_dollar_variable, copy_name): Return std::string.
10988         * parser-defs.h (copy_name): Change return type.
10989         * m2-exp.y: Update rules.
10990         (yylex): Update.
10991         * go-exp.y (lex_one_token): Update.
10992         Update rules.
10993         (classify_unsafe_function, classify_packaged_name)
10994         (classify_name, yylex): Update.
10995
10996 2019-04-19  Sergei Trofimovich <[email protected]>
10997
10998         * configure.ac: add --enable-source-highlight switch.
10999         * configure: Regenerate.
11000         * top.c (print_gdb_version): plumb --enable-source-highlight
11001         status to "show configuration".
11002
11003 2019-04-19  Tom Tromey  <[email protected]>
11004
11005         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11006         Check ADA_TYPE_P.
11007         (empty_record, ada_template_to_fixed_record_type_1)
11008         (template_to_static_fixed_type)
11009         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11010         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11011         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11012         macros.
11013
11014 2019-04-19  Ilya Yu. Malakhov  <[email protected]>
11015
11016         PR symtab/24423:
11017         * source.c (print_source_lines_base): Advance "iter" when a
11018         control character is seen.
11019
11020 2019-04-19  Philippe Waroquiers  <[email protected]>
11021
11022         * inferior.h (struct infcall_suspend_state_deleter):
11023         Catch exception in destructor to avoid crash.
11024
11025 2019-04-19  Philippe Waroquiers  <[email protected]>
11026
11027         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11028         close to the add_com "shell".
11029
11030 2019-04-18  Tom Tromey  <[email protected]>
11031
11032         * process-stratum-target.h (class process_stratum_target)
11033         <stratum>: Add "final".
11034
11035 2019-04-17  Tom Tromey  <[email protected]>
11036
11037         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11038         against nullptr before use.
11039
11040 2019-04-17  Alan Hayward  <[email protected]>
11041
11042         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11043
11044 2019-04-17  Jim Wilson  <[email protected]>
11045             Andrew Burgess  <[email protected]>
11046
11047         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11048         code read might fail, assume 4-byte breakpoint in that case.
11049
11050 2019-04-15  Leszek Swirski  <[email protected]>
11051
11052         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11053         rather than a hand-rolled POD check when checking for forced MEMORY
11054         classification.
11055
11056 2019-04-15  Alan Hayward  <[email protected]>
11057
11058         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11059         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11060         function.
11061         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11062         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11063         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11064         declaration.
11065
11066 2019-04-15  Alan Hayward  <[email protected]>
11067
11068         * aarch64-linux-nat.c
11069         (aarch64_linux_nat_target::thread_architecture): Add override.
11070         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11071         each VQ.
11072
11073 2019-04-15  Alan Hayward  <[email protected]>
11074
11075         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11076
11077 2019-04-13  Andrew Burgess  <[email protected]>
11078
11079         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11080         target types of size 96-bits, add some additional comments, and
11081         check that the builtin type we found was the correct size.
11082
11083 2019-04-12  Eli Zaretskii  <[email protected]>
11084
11085         * utils.c (prompt_for_continue): Don't restore the styling at the
11086         end, as applied_style has the wrong value.  This fixes styling in
11087         long lists of file names that are interrupted by the "Continue?"
11088         prompt.
11089
11090 2019-04-12  Andrew Burgess  <[email protected]>
11091
11092         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11093         * c-lang.c (c_language_defn): Likewise.
11094         (cplus_language_defn): Likewise.
11095         (asm_language_defn): Likewise.
11096         (minimal_language_defn): Likewise.
11097         * d-lang.c (d_language_defn): Likewise.
11098         * f-lang.c (f_language_defn): Likewise.
11099         * go-lang.c (go_language_defn): Likewise.
11100         * language.c (unknown_language_defn): Likewise.
11101         (auto_language_defn): Likewise.
11102         * language.h (struct language_defn): Remove la_magic field.
11103         (LANG_MAGIC): Delete.
11104         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11105         * objc-lang.c (objc_language_defn): Likewise.
11106         * opencl-lang.c (opencl_language_defn): Likewise.
11107         * p-lang.c (pascal_language_defn): Likewise.
11108         * rust-lang.c (rust_language_defn): Likewise.
11109
11110 2019-04-11  Andrew Burgess  <[email protected]>
11111
11112         * riscv-tdep.c (riscv_type_align): New function.
11113         (riscv_type_alignment): Delete.
11114         (riscv_arg_location): Use 'type_align'.
11115         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11116
11117 2019-04-11  Andrew Burgess  <[email protected]>
11118
11119         * gdbtypes.c (type_align): A struct with no non-static fields also
11120         has alignment of 1.
11121
11122 2019-04-11  Andrew Burgess  <[email protected]>
11123
11124         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11125         component to 0.
11126         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11127         member.
11128         (riscv_struct_info::analyse): New implementation using new
11129         analyse_inner member function.
11130         (riscv_struct_info::field_offset): New member function.
11131         (riscv_struct_info::m_offsets): New member variable.
11132         (riscv_struct_info::analyse_inner): New private member function,
11133         takes the old implementation of riscv_struct_info::analyse but
11134         extended to track field offsets.
11135         (riscv_call_arg_struct): Update the struct folding special cases
11136         to handle cases where empty C++ structs, which are non-zero
11137         length, are found.
11138         (riscv_arg_location): Initialise the length of each location, a
11139         non-zero length now indicates the location is in use.
11140         (riscv_push_dummy_call): Allow for the first location having a
11141         non-zero offset when setting up arguments.
11142         (riscv_return_value): Likewise, but for return values.
11143
11144 2019-04-11  Tom Tromey  <[email protected]>
11145
11146         * utils.c (internal_vproblem): Make "msg" const.
11147
11148 2019-04-11  Alan Hayward  <[email protected]>
11149
11150         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11151         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11152         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11153         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11154
11155 2019-04-10  Kevin Buettner  <[email protected]>
11156
11157         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11158         function.
11159         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11160         of amd64_collect_native_gregset.
11161         (amd64_linux_nat_target::store_registers): Likewise.
11162
11163 2019-04-10  Tom Tromey  <[email protected]>
11164
11165         * symtab.c (lookup_global_symbol_from_objfile)
11166         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11167         * objfiles.h (class separate_debug_iterator): New.
11168         (class separate_debug_range): New.
11169         (struct objfile) <separate_debug_objfiles>: New method.
11170         (objfile_separate_debug_iterate): Don't declare.
11171         * objfiles.c (separate_debug_iterator::operator++): Rename from
11172         objfile_separate_debug_iterate.
11173         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11174         iterator.
11175         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11176         iterator.
11177
11178 2019-04-10  Tom Tromey  <[email protected]>
11179
11180         * symfile.c (reread_symbols): Remove old comment.
11181         * objfiles.c (free_all_objfiles): Fix a typo.
11182
11183 2019-04-10  Tom Tromey  <[email protected]>
11184
11185         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11186         * minsyms.c (lookup_minimal_symbol): Use foreach.
11187         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11188         (lookup_minimal_symbol_solib_trampoline): Likewise.
11189         * symfile.c (reread_symbols): Use foreach.
11190
11191 2019-04-09  Ivan Begert  <[email protected]>
11192             Tom Tromey  <[email protected]>
11193
11194         PR rust/24414:
11195         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11196         (rust_lex_int_test): Change "value" to be LONGEST.
11197         (rust_lex_tests): Add test for long integer literal.
11198
11199 2019-04-09  Tom Tromey  <[email protected]>
11200
11201         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11202         to bool.
11203         (extended_remote_target::attach): Update.
11204         (remote_target::remote_notice_new_inferior): Update.
11205         (remote_target::add_current_inferior_and_thread): Update.
11206         * inferior.c (exit_inferior_1): Use "false".
11207         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11208
11209 2019-04-09  Simon Marchi  <[email protected]>
11210
11211         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11212         the "start" command.
11213
11214 2019-04-08  Kevin Buettner  <[email protected]>
11215
11216         * python/py-inferior.c (infpy_thread_from_thread_handle):
11217         Adjust comments to reflect renaming of thread_from_thread_handle
11218         to thread_from_handle.  Adjust keywords.  Fix type error message.
11219         (inferior_object_methods): Add thread_from_handle.  Retain
11220         thread_from_thread_handle, but mark it as deprecated.
11221
11222 2019-04-08  Kevin Buettner  <[email protected]>
11223
11224         * gdbthread.h (find_thread_by_handle): Revise declaration.
11225         * thread.c (find_thread_by_handle): Likewise.  Adjust
11226         implementation too.
11227         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11228         support for buffer objects as handles.
11229
11230 2019-04-08  Kevin Buettner  <[email protected]>
11231
11232         * python/py-infthread.c (thpy_thread_handle): New function.
11233         (thread_object_methods): Register thpy_thread_handle.
11234
11235 2019-04-08  Kevin Buettner  <[email protected]>
11236
11237         * gdbthread.h (thread_to_thread_handle): Declare.
11238         * thread.c (gdbtypes.h): Include.
11239         (thread_to_thread_handle): New function.
11240
11241         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11242         (target_thread_info_to_thread_handle): Declare.
11243         * target.c (target_thread_info_to_thread_handle): New function.
11244         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11245         * target-delegates.c: Regenerate.
11246
11247         * linux-thread-db.c (class thread_db_target): Add method
11248         thread_info_to_thread_handle.
11249         (thread_db_target::thread_info_to_thread_handle): Define.
11250         * remote.c (class remote_target): Add new method
11251         thread_info_to_thread_handle.
11252         (remote_target::thread_info_to_thread_handle): Define.
11253
11254 2019-04-08  Pedro Alves  <[email protected]>
11255
11256         * common/common-exceptions.c (throw_exception): Don't create
11257         named object to throw; throw directly.
11258         (throw_it): Likewise.  Don't initialize gdb_exception::message
11259         here, with new; pass FMT and AP to the ctor instead.
11260         * common/common-exceptions.h: Include <string>.
11261         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11262         const char *, va_list)): New ctor.  Use std::make_shared.
11263         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11264         errors)): Delete.
11265         (gdb_exception_error::gdb_exception_error(enum errors, const char
11266         *, va_list)): New.
11267         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11268         Add assertion.
11269         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11270         errors)): Delete.
11271         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11272         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11273         Add assertion.
11274
11275 2019-04-08  Tom Tromey  <[email protected]>
11276
11277         * valops.c (value_rtti_indirect_type): Replace throw_exception
11278         with throw.
11279         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11280         with throw.
11281         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11282         throw.
11283         * target.c (target_translate_tls_address): Replace throw_exception
11284         with throw.
11285         * stack.c (frame_apply_command_count): Replace throw_exception
11286         with throw.
11287         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11288         throw.
11289         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11290         with throw.
11291         * rs6000-tdep.c (rs6000_frame_cache)
11292         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11293         * remote.c: Replace throw_exception with throw.
11294         * record-full.c (record_full_message, record_full_wait_1)
11295         (record_full_restore): Replace throw_exception with throw.
11296         * record-btrace.c:
11297         (get_thread_current_frame_id, record_btrace_start_replaying)
11298         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11299         (cmd_record_btrace_start): Replace throw_exception with throw.
11300         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11301         throw.
11302         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11303         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11304         * linespec.c:
11305         (find_linespec_symbols): Replace throw_exception with throw.
11306         * infrun.c (displaced_step_prepare, resume): Replace
11307         throw_exception with throw.
11308         * infcmd.c (post_create_inferior): Replace throw_exception with
11309         throw.
11310         * inf-loop.c (inferior_event_handler): Replace throw_exception
11311         with throw.
11312         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11313         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11314         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11315         (get_prev_frame_always, get_frame_pc_if_available)
11316         (get_frame_address_in_block_if_available, get_frame_language):
11317         Replace throw_exception with throw.
11318         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11319         throw_exception with throw.
11320         * eval.c (fetch_subexp_value, evaluate_var_value)
11321         (evaluate_funcall, evaluate_subexp_standard): Replace
11322         throw_exception with throw.
11323         * dwarf2loc.c (call_site_find_chain)
11324         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11325         Replace throw_exception with throw.
11326         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11327         with throw.
11328         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11329         throw.
11330         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11331         * completer.c (complete_line_internal): Replace throw_exception
11332         with throw.
11333         * compile/compile-object-run.c (compile_object_run): Replace
11334         throw_exception with throw.
11335         * cli/cli-script.c (process_next_line): Replace throw_exception
11336         with throw.
11337         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11338         (btrace_enable, btrace_maint_update_pt_packets): Replace
11339         throw_exception with throw.
11340         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11341         throw_exception with throw.
11342         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11343         throw_exception with throw.
11344         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11345         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11346         * aarch64-tdep.c (aarch64_make_prologue_cache)
11347         (aarch64_make_stub_cache): Replace throw_exception with throw.
11348
11349 2019-04-08  Tom Tromey  <[email protected]>
11350
11351         * common/common-exceptions.c (throw_exception): Rename from
11352         throw_exception_cxx.  Remove old copy.  Make argument const.
11353         (throw_it): Create and throw exception objects directly.
11354         * common/common-exceptions.h (throw_exception): Make argument
11355         const.
11356         (struct gdb_exception_error): Add constructor.
11357         (struct gdb_exception_quit): Add constructor.
11358
11359 2019-04-08  Tom Tromey  <[email protected]>
11360
11361         * common/common-exceptions.h (exception_rethrow): Don't declare.
11362         (TRY_SJLJ): Update comment.
11363         (TRY, CATCH, END_CATCH): Remove.
11364         * common/common-exceptions.c (exception_rethrow): Remove.
11365
11366 2019-04-08  Tom Tromey  <[email protected]>
11367
11368         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11369         Remove.
11370         (gdb_exception_error): Rename from
11371         gdb_exception_RETURN_MASK_ERROR.
11372         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11373         (gdb_quit_bad_alloc): Update.
11374         * aarch64-tdep.c: Update.
11375         * ada-lang.c: Update.
11376         * ada-typeprint.c: Update.
11377         * ada-valprint.c: Update.
11378         * amd64-tdep.c: Update.
11379         * arch-utils.c: Update.
11380         * break-catch-throw.c: Update.
11381         * breakpoint.c: Update.
11382         * btrace.c: Update.
11383         * c-varobj.c: Update.
11384         * cli/cli-cmds.c: Update.
11385         * cli/cli-interp.c: Update.
11386         * cli/cli-script.c: Update.
11387         * common/common-exceptions.c: Update.
11388         * common/new-op.c: Update.
11389         * common/selftest.c: Update.
11390         * compile/compile-c-symbols.c: Update.
11391         * compile/compile-cplus-symbols.c: Update.
11392         * compile/compile-object-load.c: Update.
11393         * compile/compile-object-run.c: Update.
11394         * completer.c: Update.
11395         * corelow.c: Update.
11396         * cp-abi.c: Update.
11397         * cp-support.c: Update.
11398         * cp-valprint.c: Update.
11399         * darwin-nat.c: Update.
11400         * disasm-selftests.c: Update.
11401         * dtrace-probe.c: Update.
11402         * dwarf-index-cache.c: Update.
11403         * dwarf-index-write.c: Update.
11404         * dwarf2-frame-tailcall.c: Update.
11405         * dwarf2-frame.c: Update.
11406         * dwarf2loc.c: Update.
11407         * dwarf2read.c: Update.
11408         * eval.c: Update.
11409         * event-loop.c: Update.
11410         * event-top.c: Update.
11411         * exec.c: Update.
11412         * f-valprint.c: Update.
11413         * fbsd-tdep.c: Update.
11414         * frame-unwind.c: Update.
11415         * frame.c: Update.
11416         * gdbtypes.c: Update.
11417         * gnu-v3-abi.c: Update.
11418         * guile/guile-internal.h: Update.
11419         * guile/scm-block.c: Update.
11420         * guile/scm-breakpoint.c: Update.
11421         * guile/scm-cmd.c: Update.
11422         * guile/scm-disasm.c: Update.
11423         * guile/scm-frame.c: Update.
11424         * guile/scm-lazy-string.c: Update.
11425         * guile/scm-math.c: Update.
11426         * guile/scm-param.c: Update.
11427         * guile/scm-ports.c: Update.
11428         * guile/scm-pretty-print.c: Update.
11429         * guile/scm-symbol.c: Update.
11430         * guile/scm-symtab.c: Update.
11431         * guile/scm-type.c: Update.
11432         * guile/scm-value.c: Update.
11433         * i386-linux-tdep.c: Update.
11434         * i386-tdep.c: Update.
11435         * inf-loop.c: Update.
11436         * infcall.c: Update.
11437         * infcmd.c: Update.
11438         * infrun.c: Update.
11439         * jit.c: Update.
11440         * language.c: Update.
11441         * linespec.c: Update.
11442         * linux-fork.c: Update.
11443         * linux-nat.c: Update.
11444         * linux-tdep.c: Update.
11445         * linux-thread-db.c: Update.
11446         * main.c: Update.
11447         * mi/mi-cmd-break.c: Update.
11448         * mi/mi-cmd-stack.c: Update.
11449         * mi/mi-interp.c: Update.
11450         * mi/mi-main.c: Update.
11451         * objc-lang.c: Update.
11452         * p-valprint.c: Update.
11453         * parse.c: Update.
11454         * ppc-linux-tdep.c: Update.
11455         * printcmd.c: Update.
11456         * python/py-arch.c: Update.
11457         * python/py-breakpoint.c: Update.
11458         * python/py-cmd.c: Update.
11459         * python/py-finishbreakpoint.c: Update.
11460         * python/py-frame.c: Update.
11461         * python/py-framefilter.c: Update.
11462         * python/py-gdb-readline.c: Update.
11463         * python/py-inferior.c: Update.
11464         * python/py-infthread.c: Update.
11465         * python/py-lazy-string.c: Update.
11466         * python/py-linetable.c: Update.
11467         * python/py-objfile.c: Update.
11468         * python/py-param.c: Update.
11469         * python/py-prettyprint.c: Update.
11470         * python/py-progspace.c: Update.
11471         * python/py-record-btrace.c: Update.
11472         * python/py-record.c: Update.
11473         * python/py-symbol.c: Update.
11474         * python/py-type.c: Update.
11475         * python/py-unwind.c: Update.
11476         * python/py-utils.c: Update.
11477         * python/py-value.c: Update.
11478         * python/python.c: Update.
11479         * record-btrace.c: Update.
11480         * record-full.c: Update.
11481         * remote-fileio.c: Update.
11482         * remote.c: Update.
11483         * riscv-tdep.c: Update.
11484         * rs6000-aix-tdep.c: Update.
11485         * rs6000-tdep.c: Update.
11486         * rust-exp.y: Update.
11487         * rust-lang.c: Update.
11488         * s390-tdep.c: Update.
11489         * selftest-arch.c: Update.
11490         * solib-dsbt.c: Update.
11491         * solib-frv.c: Update.
11492         * solib-spu.c: Update.
11493         * solib-svr4.c: Update.
11494         * solib.c: Update.
11495         * sparc64-linux-tdep.c: Update.
11496         * stack.c: Update.
11497         * symfile-mem.c: Update.
11498         * symmisc.c: Update.
11499         * target.c: Update.
11500         * thread.c: Update.
11501         * top.c: Update.
11502         * tracefile-tfile.c: Update.
11503         * tui/tui.c: Update.
11504         * typeprint.c: Update.
11505         * unittests/cli-utils-selftests.c: Update.
11506         * unittests/parse-connection-spec-selftests.c: Update.
11507         * valops.c: Update.
11508         * valprint.c: Update.
11509         * value.c: Update.
11510         * varobj.c: Update.
11511         * windows-nat.c: Update.
11512         * x86-linux-nat.c: Update.
11513         * xml-support.c: Update.
11514
11515 2019-04-08  Tom Tromey  <[email protected]>
11516
11517         * xml-support.c: Use C++ exception handling.
11518         * x86-linux-nat.c: Use C++ exception handling.
11519         * windows-nat.c: Use C++ exception handling.
11520         * varobj.c: Use C++ exception handling.
11521         * value.c: Use C++ exception handling.
11522         * valprint.c: Use C++ exception handling.
11523         * valops.c: Use C++ exception handling.
11524         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11525         handling.
11526         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11527         * typeprint.c: Use C++ exception handling.
11528         * tui/tui.c: Use C++ exception handling.
11529         * tracefile-tfile.c: Use C++ exception handling.
11530         * top.c: Use C++ exception handling.
11531         * thread.c: Use C++ exception handling.
11532         * target.c: Use C++ exception handling.
11533         * symmisc.c: Use C++ exception handling.
11534         * symfile-mem.c: Use C++ exception handling.
11535         * stack.c: Use C++ exception handling.
11536         * sparc64-linux-tdep.c: Use C++ exception handling.
11537         * solib.c: Use C++ exception handling.
11538         * solib-svr4.c: Use C++ exception handling.
11539         * solib-spu.c: Use C++ exception handling.
11540         * solib-frv.c: Use C++ exception handling.
11541         * solib-dsbt.c: Use C++ exception handling.
11542         * selftest-arch.c: Use C++ exception handling.
11543         * s390-tdep.c: Use C++ exception handling.
11544         * rust-lang.c: Use C++ exception handling.
11545         * rust-exp.y: Use C++ exception handling.
11546         * rs6000-tdep.c: Use C++ exception handling.
11547         * rs6000-aix-tdep.c: Use C++ exception handling.
11548         * riscv-tdep.c: Use C++ exception handling.
11549         * remote.c: Use C++ exception handling.
11550         * remote-fileio.c: Use C++ exception handling.
11551         * record-full.c: Use C++ exception handling.
11552         * record-btrace.c: Use C++ exception handling.
11553         * python/python.c: Use C++ exception handling.
11554         * python/py-value.c: Use C++ exception handling.
11555         * python/py-utils.c: Use C++ exception handling.
11556         * python/py-unwind.c: Use C++ exception handling.
11557         * python/py-type.c: Use C++ exception handling.
11558         * python/py-symbol.c: Use C++ exception handling.
11559         * python/py-record.c: Use C++ exception handling.
11560         * python/py-record-btrace.c: Use C++ exception handling.
11561         * python/py-progspace.c: Use C++ exception handling.
11562         * python/py-prettyprint.c: Use C++ exception handling.
11563         * python/py-param.c: Use C++ exception handling.
11564         * python/py-objfile.c: Use C++ exception handling.
11565         * python/py-linetable.c: Use C++ exception handling.
11566         * python/py-lazy-string.c: Use C++ exception handling.
11567         * python/py-infthread.c: Use C++ exception handling.
11568         * python/py-inferior.c: Use C++ exception handling.
11569         * python/py-gdb-readline.c: Use C++ exception handling.
11570         * python/py-framefilter.c: Use C++ exception handling.
11571         * python/py-frame.c: Use C++ exception handling.
11572         * python/py-finishbreakpoint.c: Use C++ exception handling.
11573         * python/py-cmd.c: Use C++ exception handling.
11574         * python/py-breakpoint.c: Use C++ exception handling.
11575         * python/py-arch.c: Use C++ exception handling.
11576         * printcmd.c: Use C++ exception handling.
11577         * ppc-linux-tdep.c: Use C++ exception handling.
11578         * parse.c: Use C++ exception handling.
11579         * p-valprint.c: Use C++ exception handling.
11580         * objc-lang.c: Use C++ exception handling.
11581         * mi/mi-main.c: Use C++ exception handling.
11582         * mi/mi-interp.c: Use C++ exception handling.
11583         * mi/mi-cmd-stack.c: Use C++ exception handling.
11584         * mi/mi-cmd-break.c: Use C++ exception handling.
11585         * main.c: Use C++ exception handling.
11586         * linux-thread-db.c: Use C++ exception handling.
11587         * linux-tdep.c: Use C++ exception handling.
11588         * linux-nat.c: Use C++ exception handling.
11589         * linux-fork.c: Use C++ exception handling.
11590         * linespec.c: Use C++ exception handling.
11591         * language.c: Use C++ exception handling.
11592         * jit.c: Use C++ exception handling.
11593         * infrun.c: Use C++ exception handling.
11594         * infcmd.c: Use C++ exception handling.
11595         * infcall.c: Use C++ exception handling.
11596         * inf-loop.c: Use C++ exception handling.
11597         * i386-tdep.c: Use C++ exception handling.
11598         * i386-linux-tdep.c: Use C++ exception handling.
11599         * guile/scm-value.c: Use C++ exception handling.
11600         * guile/scm-type.c: Use C++ exception handling.
11601         * guile/scm-symtab.c: Use C++ exception handling.
11602         * guile/scm-symbol.c: Use C++ exception handling.
11603         * guile/scm-pretty-print.c: Use C++ exception handling.
11604         * guile/scm-ports.c: Use C++ exception handling.
11605         * guile/scm-param.c: Use C++ exception handling.
11606         * guile/scm-math.c: Use C++ exception handling.
11607         * guile/scm-lazy-string.c: Use C++ exception handling.
11608         * guile/scm-frame.c: Use C++ exception handling.
11609         * guile/scm-disasm.c: Use C++ exception handling.
11610         * guile/scm-cmd.c: Use C++ exception handling.
11611         * guile/scm-breakpoint.c: Use C++ exception handling.
11612         * guile/scm-block.c: Use C++ exception handling.
11613         * guile/guile-internal.h: Use C++ exception handling.
11614         * gnu-v3-abi.c: Use C++ exception handling.
11615         * gdbtypes.c: Use C++ exception handling.
11616         * frame.c: Use C++ exception handling.
11617         * frame-unwind.c: Use C++ exception handling.
11618         * fbsd-tdep.c: Use C++ exception handling.
11619         * f-valprint.c: Use C++ exception handling.
11620         * exec.c: Use C++ exception handling.
11621         * event-top.c: Use C++ exception handling.
11622         * event-loop.c: Use C++ exception handling.
11623         * eval.c: Use C++ exception handling.
11624         * dwarf2read.c: Use C++ exception handling.
11625         * dwarf2loc.c: Use C++ exception handling.
11626         * dwarf2-frame.c: Use C++ exception handling.
11627         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11628         * dwarf-index-write.c: Use C++ exception handling.
11629         * dwarf-index-cache.c: Use C++ exception handling.
11630         * dtrace-probe.c: Use C++ exception handling.
11631         * disasm-selftests.c: Use C++ exception handling.
11632         * darwin-nat.c: Use C++ exception handling.
11633         * cp-valprint.c: Use C++ exception handling.
11634         * cp-support.c: Use C++ exception handling.
11635         * cp-abi.c: Use C++ exception handling.
11636         * corelow.c: Use C++ exception handling.
11637         * completer.c: Use C++ exception handling.
11638         * compile/compile-object-run.c: Use C++ exception handling.
11639         * compile/compile-object-load.c: Use C++ exception handling.
11640         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11641         * compile/compile-c-symbols.c: Use C++ exception handling.
11642         * common/selftest.c: Use C++ exception handling.
11643         * common/new-op.c: Use C++ exception handling.
11644         * cli/cli-script.c: Use C++ exception handling.
11645         * cli/cli-interp.c: Use C++ exception handling.
11646         * cli/cli-cmds.c: Use C++ exception handling.
11647         * c-varobj.c: Use C++ exception handling.
11648         * btrace.c: Use C++ exception handling.
11649         * breakpoint.c: Use C++ exception handling.
11650         * break-catch-throw.c: Use C++ exception handling.
11651         * arch-utils.c: Use C++ exception handling.
11652         * amd64-tdep.c: Use C++ exception handling.
11653         * ada-valprint.c: Use C++ exception handling.
11654         * ada-typeprint.c: Use C++ exception handling.
11655         * ada-lang.c: Use C++ exception handling.
11656         * aarch64-tdep.c: Use C++ exception handling.
11657
11658 2019-04-08  Tom Tromey  <[email protected]>
11659
11660         * xml-support.c (gdb_xml_parser::parse): Update.
11661         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11662         * value.c (show_convenience): Update.
11663         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11664         (test_parse_flags_qcs): Update.
11665         * thread.c (thr_try_catch_cmd): Update.
11666         * target.c (target_translate_tls_address): Update.
11667         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11668         (info_frame_command_core, frame_apply_command_count): Update.
11669         * rust-exp.y (rust_lex_exception_test): Update.
11670         * riscv-tdep.c (riscv_print_one_register_info): Update.
11671         * remote.c (remote_target::enable_btrace): Update.
11672         * record-btrace.c (record_btrace_enable_warn): Update.
11673         * python/py-utils.c (gdbpy_convert_exception): Update.
11674         * printcmd.c (do_one_display, print_variable_and_value): Update.
11675         * mi/mi-main.c (mi_print_exception): Update.
11676         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11677         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11678         * linux-nat.c (linux_nat_target::attach): Update.
11679         * linux-fork.c (class scoped_switch_fork_info): Update.
11680         * infrun.c (displaced_step_prepare): Update.
11681         * infcall.c (call_function_by_hand_dummy): Update.
11682         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11683         * gnu-v3-abi.c (print_one_vtable): Update.
11684         * frame.c (get_prev_frame_always): Update.
11685         * f-valprint.c (info_common_command_for_block): Update.
11686         * exec.c (try_open_exec_file): Update.
11687         * exceptions.c (print_exception, exception_print)
11688         (exception_fprintf, exception_print_same): Update.
11689         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11690         * dwarf-index-cache.c (index_cache::store)
11691         (index_cache::lookup_gdb_index): Update.
11692         * darwin-nat.c (maybe_cache_shell): Update.
11693         * cp-valprint.c (cp_print_value_fields): Update.
11694         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11695         (gcc_cplus_symbol_address): Update.
11696         * compile/compile-c-symbols.c (gcc_convert_symbol)
11697         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11698         * common/selftest.c: Update.
11699         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11700         a std::string.
11701         (exception_try_scope_entry, exception_try_scope_exit): Don't
11702         declare.
11703         (struct exception_try_scope): Remove.
11704         (TRY): Don't use exception_try_scope.
11705         (struct gdb_exception): Add constructor, operator=.
11706         <what>: New method.
11707         (struct gdb_exception_RETURN_MASK_ALL)
11708         (struct gdb_exception_RETURN_MASK_ERROR)
11709         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11710         (struct gdb_quit_bad_alloc): Update.
11711         * common/common-exceptions.c (exception_none): Change
11712         initializer.
11713         (struct catcher) <state, exception>: Initialize inline.
11714         <prev>: Remove member.
11715         (current_catcher): Remove.
11716         (catchers): New global.
11717         (exceptions_state_mc_init): Simplify.
11718         (catcher_pop): Remove.
11719         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11720         (try_scope_depth, exception_try_scope_entry)
11721         (exception_try_scope_exit): Remove.
11722         (throw_exception_sjlj): Update.
11723         (exception_messages, exception_messages_size): Remove.
11724         (throw_it): Simplify.
11725         (gdb_exception_sliced_copy): Remove.
11726         (throw_exception_cxx): Update.
11727         * cli/cli-script.c (script_from_file): Update.
11728         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11729         Update.
11730         * ada-valprint.c (ada_val_print): Update.
11731         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11732         (create_excep_cond_exprs): Update.
11733
11734 2019-04-08  Tom Tromey  <[email protected]>
11735
11736         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11737         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11738         (TRY, CATCH, END_CATCH): Remove some definitions.
11739         * common/common-exceptions.c: Don't use GDB_XCPT.
11740         (catcher_list_size): Remove.
11741         (throw_exception, throw_it): Simplify.
11742
11743 2019-04-05  Tom Tromey  <[email protected]>
11744
11745         Revert the header-sorting patch.
11746         * ft32-tdep.c: Revert.
11747         * frv-tdep.c: Revert.
11748         * frv-linux-tdep.c: Revert.
11749         * frame.c: Revert.
11750         * frame-unwind.c: Revert.
11751         * frame-base.c: Revert.
11752         * fork-child.c: Revert.
11753         * findvar.c: Revert.
11754         * findcmd.c: Revert.
11755         * filesystem.c: Revert.
11756         * filename-seen-cache.h: Revert.
11757         * filename-seen-cache.c: Revert.
11758         * fbsd-tdep.c: Revert.
11759         * fbsd-nat.h: Revert.
11760         * fbsd-nat.c: Revert.
11761         * f-valprint.c: Revert.
11762         * f-typeprint.c: Revert.
11763         * f-lang.c: Revert.
11764         * extension.h: Revert.
11765         * extension.c: Revert.
11766         * extension-priv.h: Revert.
11767         * expprint.c: Revert.
11768         * exec.h: Revert.
11769         * exec.c: Revert.
11770         * exceptions.c: Revert.
11771         * event-top.c: Revert.
11772         * event-loop.c: Revert.
11773         * eval.c: Revert.
11774         * elfread.c: Revert.
11775         * dwarf2read.h: Revert.
11776         * dwarf2read.c: Revert.
11777         * dwarf2loc.c: Revert.
11778         * dwarf2expr.h: Revert.
11779         * dwarf2expr.c: Revert.
11780         * dwarf2-frame.c: Revert.
11781         * dwarf2-frame-tailcall.c: Revert.
11782         * dwarf-index-write.h: Revert.
11783         * dwarf-index-write.c: Revert.
11784         * dwarf-index-common.c: Revert.
11785         * dwarf-index-cache.h: Revert.
11786         * dwarf-index-cache.c: Revert.
11787         * dummy-frame.c: Revert.
11788         * dtrace-probe.c: Revert.
11789         * disasm.h: Revert.
11790         * disasm.c: Revert.
11791         * disasm-selftests.c: Revert.
11792         * dictionary.c: Revert.
11793         * dicos-tdep.c: Revert.
11794         * demangle.c: Revert.
11795         * dcache.h: Revert.
11796         * dcache.c: Revert.
11797         * darwin-nat.h: Revert.
11798         * darwin-nat.c: Revert.
11799         * darwin-nat-info.c: Revert.
11800         * d-valprint.c: Revert.
11801         * d-namespace.c: Revert.
11802         * d-lang.c: Revert.
11803         * ctf.c: Revert.
11804         * csky-tdep.c: Revert.
11805         * csky-linux-tdep.c: Revert.
11806         * cris-tdep.c: Revert.
11807         * cris-linux-tdep.c: Revert.
11808         * cp-valprint.c: Revert.
11809         * cp-support.c: Revert.
11810         * cp-namespace.c: Revert.
11811         * cp-abi.c: Revert.
11812         * corelow.c: Revert.
11813         * corefile.c: Revert.
11814         * continuations.c: Revert.
11815         * completer.h: Revert.
11816         * completer.c: Revert.
11817         * complaints.c: Revert.
11818         * coffread.c: Revert.
11819         * coff-pe-read.c: Revert.
11820         * cli-out.h: Revert.
11821         * cli-out.c: Revert.
11822         * charset.c: Revert.
11823         * c-varobj.c: Revert.
11824         * c-valprint.c: Revert.
11825         * c-typeprint.c: Revert.
11826         * c-lang.c: Revert.
11827         * buildsym.c: Revert.
11828         * buildsym-legacy.c: Revert.
11829         * build-id.h: Revert.
11830         * build-id.c: Revert.
11831         * btrace.c: Revert.
11832         * bsd-uthread.c: Revert.
11833         * breakpoint.h: Revert.
11834         * breakpoint.c: Revert.
11835         * break-catch-throw.c: Revert.
11836         * break-catch-syscall.c: Revert.
11837         * break-catch-sig.c: Revert.
11838         * blockframe.c: Revert.
11839         * block.c: Revert.
11840         * bfin-tdep.c: Revert.
11841         * bfin-linux-tdep.c: Revert.
11842         * bfd-target.c: Revert.
11843         * bcache.c: Revert.
11844         * ax-general.c: Revert.
11845         * ax-gdb.h: Revert.
11846         * ax-gdb.c: Revert.
11847         * avr-tdep.c: Revert.
11848         * auxv.c: Revert.
11849         * auto-load.c: Revert.
11850         * arm-wince-tdep.c: Revert.
11851         * arm-tdep.c: Revert.
11852         * arm-symbian-tdep.c: Revert.
11853         * arm-pikeos-tdep.c: Revert.
11854         * arm-obsd-tdep.c: Revert.
11855         * arm-nbsd-tdep.c: Revert.
11856         * arm-nbsd-nat.c: Revert.
11857         * arm-linux-tdep.c: Revert.
11858         * arm-linux-nat.c: Revert.
11859         * arm-fbsd-tdep.c: Revert.
11860         * arm-fbsd-nat.c: Revert.
11861         * arm-bsd-tdep.c: Revert.
11862         * arch-utils.c: Revert.
11863         * arc-tdep.c: Revert.
11864         * arc-newlib-tdep.c: Revert.
11865         * annotate.h: Revert.
11866         * annotate.c: Revert.
11867         * amd64-windows-tdep.c: Revert.
11868         * amd64-windows-nat.c: Revert.
11869         * amd64-tdep.c: Revert.
11870         * amd64-sol2-tdep.c: Revert.
11871         * amd64-obsd-tdep.c: Revert.
11872         * amd64-obsd-nat.c: Revert.
11873         * amd64-nbsd-tdep.c: Revert.
11874         * amd64-nbsd-nat.c: Revert.
11875         * amd64-nat.c: Revert.
11876         * amd64-linux-tdep.c: Revert.
11877         * amd64-linux-nat.c: Revert.
11878         * amd64-fbsd-tdep.c: Revert.
11879         * amd64-fbsd-nat.c: Revert.
11880         * amd64-dicos-tdep.c: Revert.
11881         * amd64-darwin-tdep.c: Revert.
11882         * amd64-bsd-nat.c: Revert.
11883         * alpha-tdep.c: Revert.
11884         * alpha-obsd-tdep.c: Revert.
11885         * alpha-nbsd-tdep.c: Revert.
11886         * alpha-mdebug-tdep.c: Revert.
11887         * alpha-linux-tdep.c: Revert.
11888         * alpha-linux-nat.c: Revert.
11889         * alpha-bsd-tdep.c: Revert.
11890         * alpha-bsd-nat.c: Revert.
11891         * aix-thread.c: Revert.
11892         * agent.c: Revert.
11893         * addrmap.c: Revert.
11894         * ada-varobj.c: Revert.
11895         * ada-valprint.c: Revert.
11896         * ada-typeprint.c: Revert.
11897         * ada-tasks.c: Revert.
11898         * ada-lang.c: Revert.
11899         * aarch64-tdep.c: Revert.
11900         * aarch64-ravenscar-thread.c: Revert.
11901         * aarch64-newlib-tdep.c: Revert.
11902         * aarch64-linux-tdep.c: Revert.
11903         * aarch64-linux-nat.c: Revert.
11904         * aarch64-fbsd-tdep.c: Revert.
11905         * aarch64-fbsd-nat.c: Revert.
11906         * aarch32-linux-nat.c: Revert.
11907
11908 2019-04-05  Tom Tromey  <[email protected]>
11909
11910         * ft32-tdep.c: Sort headers.
11911         * frv-tdep.c: Sort headers.
11912         * frv-linux-tdep.c: Sort headers.
11913         * frame.c: Sort headers.
11914         * frame-unwind.c: Sort headers.
11915         * frame-base.c: Sort headers.
11916         * fork-child.c: Sort headers.
11917         * findvar.c: Sort headers.
11918         * findcmd.c: Sort headers.
11919         * filesystem.c: Sort headers.
11920         * filename-seen-cache.h: Sort headers.
11921         * filename-seen-cache.c: Sort headers.
11922         * fbsd-tdep.c: Sort headers.
11923         * fbsd-nat.h: Sort headers.
11924         * fbsd-nat.c: Sort headers.
11925         * f-valprint.c: Sort headers.
11926         * f-typeprint.c: Sort headers.
11927         * f-lang.c: Sort headers.
11928         * extension.h: Sort headers.
11929         * extension.c: Sort headers.
11930         * extension-priv.h: Sort headers.
11931         * expprint.c: Sort headers.
11932         * exec.h: Sort headers.
11933         * exec.c: Sort headers.
11934         * exceptions.c: Sort headers.
11935         * event-top.c: Sort headers.
11936         * event-loop.c: Sort headers.
11937         * eval.c: Sort headers.
11938         * elfread.c: Sort headers.
11939         * dwarf2read.h: Sort headers.
11940         * dwarf2read.c: Sort headers.
11941         * dwarf2loc.c: Sort headers.
11942         * dwarf2expr.h: Sort headers.
11943         * dwarf2expr.c: Sort headers.
11944         * dwarf2-frame.c: Sort headers.
11945         * dwarf2-frame-tailcall.c: Sort headers.
11946         * dwarf-index-write.h: Sort headers.
11947         * dwarf-index-write.c: Sort headers.
11948         * dwarf-index-common.c: Sort headers.
11949         * dwarf-index-cache.h: Sort headers.
11950         * dwarf-index-cache.c: Sort headers.
11951         * dummy-frame.c: Sort headers.
11952         * dtrace-probe.c: Sort headers.
11953         * disasm.h: Sort headers.
11954         * disasm.c: Sort headers.
11955         * disasm-selftests.c: Sort headers.
11956         * dictionary.c: Sort headers.
11957         * dicos-tdep.c: Sort headers.
11958         * demangle.c: Sort headers.
11959         * dcache.h: Sort headers.
11960         * dcache.c: Sort headers.
11961         * darwin-nat.h: Sort headers.
11962         * darwin-nat.c: Sort headers.
11963         * darwin-nat-info.c: Sort headers.
11964         * d-valprint.c: Sort headers.
11965         * d-namespace.c: Sort headers.
11966         * d-lang.c: Sort headers.
11967         * ctf.c: Sort headers.
11968         * csky-tdep.c: Sort headers.
11969         * csky-linux-tdep.c: Sort headers.
11970         * cris-tdep.c: Sort headers.
11971         * cris-linux-tdep.c: Sort headers.
11972         * cp-valprint.c: Sort headers.
11973         * cp-support.c: Sort headers.
11974         * cp-namespace.c: Sort headers.
11975         * cp-abi.c: Sort headers.
11976         * corelow.c: Sort headers.
11977         * corefile.c: Sort headers.
11978         * continuations.c: Sort headers.
11979         * completer.h: Sort headers.
11980         * completer.c: Sort headers.
11981         * complaints.c: Sort headers.
11982         * coffread.c: Sort headers.
11983         * coff-pe-read.c: Sort headers.
11984         * cli-out.h: Sort headers.
11985         * cli-out.c: Sort headers.
11986         * charset.c: Sort headers.
11987         * c-varobj.c: Sort headers.
11988         * c-valprint.c: Sort headers.
11989         * c-typeprint.c: Sort headers.
11990         * c-lang.c: Sort headers.
11991         * buildsym.c: Sort headers.
11992         * buildsym-legacy.c: Sort headers.
11993         * build-id.h: Sort headers.
11994         * build-id.c: Sort headers.
11995         * btrace.c: Sort headers.
11996         * bsd-uthread.c: Sort headers.
11997         * breakpoint.h: Sort headers.
11998         * breakpoint.c: Sort headers.
11999         * break-catch-throw.c: Sort headers.
12000         * break-catch-syscall.c: Sort headers.
12001         * break-catch-sig.c: Sort headers.
12002         * blockframe.c: Sort headers.
12003         * block.c: Sort headers.
12004         * bfin-tdep.c: Sort headers.
12005         * bfin-linux-tdep.c: Sort headers.
12006         * bfd-target.c: Sort headers.
12007         * bcache.c: Sort headers.
12008         * ax-general.c: Sort headers.
12009         * ax-gdb.h: Sort headers.
12010         * ax-gdb.c: Sort headers.
12011         * avr-tdep.c: Sort headers.
12012         * auxv.c: Sort headers.
12013         * auto-load.c: Sort headers.
12014         * arm-wince-tdep.c: Sort headers.
12015         * arm-tdep.c: Sort headers.
12016         * arm-symbian-tdep.c: Sort headers.
12017         * arm-pikeos-tdep.c: Sort headers.
12018         * arm-obsd-tdep.c: Sort headers.
12019         * arm-nbsd-tdep.c: Sort headers.
12020         * arm-nbsd-nat.c: Sort headers.
12021         * arm-linux-tdep.c: Sort headers.
12022         * arm-linux-nat.c: Sort headers.
12023         * arm-fbsd-tdep.c: Sort headers.
12024         * arm-fbsd-nat.c: Sort headers.
12025         * arm-bsd-tdep.c: Sort headers.
12026         * arch-utils.c: Sort headers.
12027         * arc-tdep.c: Sort headers.
12028         * arc-newlib-tdep.c: Sort headers.
12029         * annotate.h: Sort headers.
12030         * annotate.c: Sort headers.
12031         * amd64-windows-tdep.c: Sort headers.
12032         * amd64-windows-nat.c: Sort headers.
12033         * amd64-tdep.c: Sort headers.
12034         * amd64-sol2-tdep.c: Sort headers.
12035         * amd64-obsd-tdep.c: Sort headers.
12036         * amd64-obsd-nat.c: Sort headers.
12037         * amd64-nbsd-tdep.c: Sort headers.
12038         * amd64-nbsd-nat.c: Sort headers.
12039         * amd64-nat.c: Sort headers.
12040         * amd64-linux-tdep.c: Sort headers.
12041         * amd64-linux-nat.c: Sort headers.
12042         * amd64-fbsd-tdep.c: Sort headers.
12043         * amd64-fbsd-nat.c: Sort headers.
12044         * amd64-dicos-tdep.c: Sort headers.
12045         * amd64-darwin-tdep.c: Sort headers.
12046         * amd64-bsd-nat.c: Sort headers.
12047         * alpha-tdep.c: Sort headers.
12048         * alpha-obsd-tdep.c: Sort headers.
12049         * alpha-nbsd-tdep.c: Sort headers.
12050         * alpha-mdebug-tdep.c: Sort headers.
12051         * alpha-linux-tdep.c: Sort headers.
12052         * alpha-linux-nat.c: Sort headers.
12053         * alpha-bsd-tdep.c: Sort headers.
12054         * alpha-bsd-nat.c: Sort headers.
12055         * aix-thread.c: Sort headers.
12056         * agent.c: Sort headers.
12057         * addrmap.c: Sort headers.
12058         * ada-varobj.c: Sort headers.
12059         * ada-valprint.c: Sort headers.
12060         * ada-typeprint.c: Sort headers.
12061         * ada-tasks.c: Sort headers.
12062         * ada-lang.c: Sort headers.
12063         * aarch64-tdep.c: Sort headers.
12064         * aarch64-ravenscar-thread.c: Sort headers.
12065         * aarch64-newlib-tdep.c: Sort headers.
12066         * aarch64-linux-tdep.c: Sort headers.
12067         * aarch64-linux-nat.c: Sort headers.
12068         * aarch64-fbsd-tdep.c: Sort headers.
12069         * aarch64-fbsd-nat.c: Sort headers.
12070         * aarch32-linux-nat.c: Sort headers.
12071
12072 2019-04-04  Tom Tromey  <[email protected]>
12073
12074         * varobj.c (varobj_create): Update.
12075         * rust-exp.y (struct rust_parser) <update_innermost_block,
12076         lookup_symbol>: New methods.
12077         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12078         Rename.
12079         (rust_parser::rust_lookup_type)
12080         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12081         * printcmd.c (display_command, do_one_display): Update.
12082         * parser-defs.h (struct parser_state) <parser_state>: Add
12083         "tracker" parameter.
12084         (block_tracker): New member.
12085         (class innermost_block_tracker) <innermost_block_tracker>: Add
12086         "types" parameter.
12087         <reset>: Remove method.
12088         (innermost_block): Don't declare.
12089         (null_post_parser): Update.
12090         * parse.c (innermost_block): Remove global.
12091         (write_dollar_variable): Update.
12092         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12093         Remove "tracker_types" parameter.
12094         (parse_expression): Add "tracker" parameter.
12095         (parse_expression_for_completion): Update.
12096         (null_post_parser): Add "tracker" parameter.
12097         * p-exp.y: Update rules.
12098         * m2-exp.y: Update rules.
12099         * language.h (struct language_defn) <la_post_parser>: Add
12100         "tracker" parameter.
12101         * go-exp.y: Update rules.
12102         * f-exp.y: Update rules.
12103         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12104         parameter.
12105         * d-exp.y: Update rules.
12106         * c-exp.y: Update rules.
12107         * breakpoint.c (set_breakpoint_condition): Create an
12108         innermost_block_tracker.
12109         (watch_command_1): Likewise.
12110         * ada-lang.c (resolve): Add "tracker" parameter.
12111         (resolve_subexp): Likewise.
12112         * ada-exp.y (write_var_from_sym): Update.
12113
12114 2019-04-04  Tom Tromey  <[email protected]>
12115
12116         * type-stack.h: New file.
12117         * type-stack.c: New file.
12118         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12119         type-stack.h.
12120         (insert_into_type_stack, insert_type, push_type, push_type_int)
12121         (insert_type_address_space, pop_type, pop_type_int)
12122         (pop_typelist, pop_type_stack, append_type_stack)
12123         (push_type_stack, get_type_stack, push_typelist)
12124         (follow_type_instance_flags, follow_types): Don't declare.
12125         * parse.c (type_stack): Remove global.
12126         (parse_exp_in_context): Update.
12127         (insert_into_type_stack, insert_type, push_type, push_type_int)
12128         (insert_type_address_space, pop_type, pop_type_int)
12129         (pop_typelist, pop_type_stack, append_type_stack)
12130         (push_type_stack, get_type_stack, push_typelist)
12131         (follow_type_instance_flags, follow_types): Remove (moved to
12132         type-stack.c).
12133         * f-exp.y (type_stack): New global.
12134         Update rules.
12135         (push_kind_type, f_parse): Update.
12136         * d-exp.y (type_stack): New global.
12137         Update rules.
12138         (d_parse): Update.
12139         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12140         Update rules.
12141         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12142         (HFILES_NO_SRCDIR): Add type-stack.h.
12143
12144 2019-04-04  Tom Tromey  <[email protected]>
12145
12146         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12147         (rust_parser::convert_ast_to_expression, rust_parse)
12148         (rust_lex_test_completion, rust_lex_tests): Update.
12149         * parser-defs.h (struct expr_completion_state): New.
12150         (struct parser_state) <parser_state>: Add completion parameter.
12151         <mark_struct_expression, mark_completion_tag>: New methods.
12152         <parse_completion, m_completion_state>: New members.
12153         (prefixify_expression, null_post_parser): Update.
12154         (mark_struct_expression, mark_completion_tag): Don't declare.
12155         * parse.c (parse_completion, expout_last_struct)
12156         (expout_tag_completion_type, expout_completion_name): Remove
12157         globals.
12158         (parser_state::mark_struct_expression)
12159         (parser_state::mark_completion_tag): Now methods.
12160         (prefixify_expression): Add last_struct parameter.
12161         (prefixify_subexp): Likewise.
12162         (parse_exp_1): Update.
12163         (parse_exp_in_context): Add cstate parameter.  Update.
12164         (parse_expression_for_completion): Create an
12165         expr_completion_state.
12166         (null_post_parser): Add "completion" parameter.
12167         * p-exp.y: Update rules.
12168         (yylex): Update.
12169         * language.h (struct language_defn) <la_post_parser>: Add
12170         "completing" parameter.
12171         * go-exp.y: Update rules.
12172         (lex_one_token): Update.
12173         * expression.h (parse_completion): Don't declare.
12174         * d-exp.y: Update rules.
12175         (lex_one_token): Update rules.
12176         * c-exp.y: Update rules.
12177         (lex_one_token): Update.
12178         * ada-lang.c (resolve): Add "parse_completion" parameter.
12179         (resolve_subexp): Likewise.
12180         (ada_resolve_function): Likewise.
12181
12182 2019-04-04  Tom Tromey  <[email protected]>
12183
12184         * parser-defs.h (struct parser_state) <start_arglist,
12185         end_arglist>: New methods.
12186         <arglist_len, m_funcall_chain>: New members.
12187         (arglist_len, start_arglist, end_arglist): Don't declare.
12188         * parse.c (arglist_len, funcall_chain): Remove global.
12189         (start_arglist, end_arglist): Remove functions.
12190         (parse_exp_in_context): Update.
12191         * p-exp.y: Update rules.
12192         * m2-exp.y: Update rules.
12193         * go-exp.y: Update rules.
12194         * f-exp.y: Update rules.
12195         * d-exp.y: Update rules.
12196         * c-exp.y: Update rules.
12197
12198 2019-04-04  Tom Tromey  <[email protected]>
12199
12200         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12201         lex_operator, push_back>: New methods.
12202         Update all rules.
12203         (rust_parser::lex_hex, lex_escape): Rename and update.
12204         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12205         (rust_parser::lex_operator): Rename and update.
12206         (rust_parser::lex_number, rustyylex, rustyyerror)
12207         (rust_lex_test_init, rust_lex_test_sequence)
12208         (rust_lex_test_push_back, rust_lex_tests): Update.
12209         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12210         parameter.
12211         <lexptr, prev_lexptr>: New members.
12212         (lexptr, prev_lexptr): Don't declare.
12213         * parse.c (lexptr, prev_lexptr): Remove globals.
12214         (parse_exp_in_context): Update.
12215         * p-exp.y (yylex, yyerror): Update.
12216         * m2-exp.y (parse_number, yylex, yyerror): Update.
12217         * go-exp.y (lex_one_token, yyerror): Update.
12218         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12219         * d-exp.y (lex_one_token, yyerror): Update.
12220         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12221         (lex_one_token, yyerror): Update.
12222         * ada-lex.l (YY_INPUT): Update.
12223         (rewind_to_char): Update.
12224         * ada-exp.y (yyerror): Update.
12225
12226 2019-04-04  Tom Tromey  <[email protected]>
12227
12228         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12229         * parser-defs.h (struct parser_state) <parser_state>: Add new
12230         parameter.
12231         <comma_terminates>: New member.
12232         (comma_terminates): Don't declare global.
12233         * parse.c (comma_terminates): Remove global.
12234         (parse_exp_in_context): Update.
12235         * p-exp.y (yylex): Update.
12236         * m2-exp.y (yylex): Update.
12237         * go-exp.y (lex_one_token): Update.
12238         * f-exp.y (yylex): Update.
12239         * d-exp.y (lex_one_token): Update.
12240         * c-exp.y (lex_one_token): Update.
12241         * ada-lex.l: Update.
12242
12243 2019-04-04  Tom Tromey  <[email protected]>
12244
12245         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12246         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12247         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12248         * parser-defs.h (paren_depth): Don't declare.
12249         * parse.c (paren_depth): Remove global.
12250         (parse_exp_in_context): Update.
12251         * p-exp.y (paren_depth): New global.
12252         (pascal_parse): Initialize it.
12253         * m2-exp.y (paren_depth): New global.
12254         (m2_parse): Initialize it.
12255         * go-exp.y (paren_depth): New global.
12256         (go_parse): Initialize it.
12257         * f-exp.y (paren_depth): New global.
12258         (f_parse): Initialize it.
12259         * d-exp.y (paren_depth): New global.
12260         (d_parse): Initialize it.
12261         * c-exp.y (paren_depth): New global.
12262         (c_parse): Initialize it.
12263         * ada-lex.l (paren_depth): New global.
12264         (lexer_init): Initialize it.
12265
12266 2019-04-04  Tom Tromey  <[email protected]>
12267
12268         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12269         (rust_parser::convert_ast_to_type)
12270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12271         * parser-defs.h (struct parser_state) <parser_state>: Add
12272         parameters.  Initialize new members.
12273         <expression_context_block, expression_context_pc>: New members.
12274         * parse.c (expression_context_block, expression_context_pc):
12275         Remove globals.
12276         (parse_exp_in_context): Update.
12277         * p-exp.y: Update all rules.
12278         (yylex): Update.
12279         * m2-exp.y: Update all rules.
12280         (yylex): Update.
12281         * go-exp.y (yylex): Update.
12282         * f-exp.y (yylex): Update.
12283         * d-exp.y: Update all rules.
12284         (yylex): Update.
12285         * c-exp.y: Update all rules.
12286         (lex_one_token, classify_name, yylex, c_parse): Update.
12287         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12288
12289 2019-04-04  Tom Tromey  <[email protected]>
12290
12291         * gdbarch.h, gdbarch.c: Rebuild.
12292         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12293         * stap-probe.h: 
12294         (struct stap_parse_info): Replace "parser_state" with
12295         "expr_builder".
12296         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12297         (parser_state): New class.
12298         * parse.c (expr_builder): Rename.
12299         (expr_builder::release): Rename.
12300         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12301         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12302         (write_exp_elt_longcst, write_exp_elt_floatcst)
12303         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12304         (write_exp_string_vector, write_exp_bitstring)
12305         (write_exp_msymbol, mark_struct_expression)
12306         (write_dollar_variable)
12307         (insert_type_address_space, increase_expout_size): Replace
12308         "parser_state" with "expr_builder".
12309         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12310         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12311         "parser_state" with "expr_builder".
12312
12313 2019-04-04  Tom Tromey  <[email protected]>
12314
12315         * rust-exp.y: Replace "parse_language" with method call.
12316         * p-exp.y: 
12317         (yylex): Replace "parse_language" with method call.
12318         * m2-exp.y: 
12319         (yylex): Replace "parse_language" with method call.
12320         * go-exp.y (classify_name): Replace "parse_language" with method
12321         call.
12322         * f-exp.y (yylex): Replace "parse_language" with method call.
12323         * d-exp.y (lex_one_token): Replace "parse_language" with method
12324         call.
12325         * c-exp.y: 
12326         (lex_one_token, classify_name, yylex): Replace "parse_language"
12327         with method call.
12328         * ada-exp.y (find_primitive_type, type_char)
12329         (type_system_address): Replace "parse_language" with method call.
12330
12331 2019-04-04  Tom Tromey  <[email protected]>
12332
12333         * rust-exp.y: Replace "parse_gdbarch" with method call.
12334         * parse.c (write_dollar_variable, insert_type_address_space):
12335         Replace "parse_gdbarch" with method call.
12336         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12337         call.
12338         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12339         call.
12340         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12341         "parse_gdbarch" with method call.
12342         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12343         with method call.
12344         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12345         "parse_gdbarch" with method call.
12346         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12347         "parse_gdbarch" with method call.
12348         * c-exp.y (parse_type, parse_number, classify_name): Replace
12349         "parse_gdbarch" with method call.
12350         * ada-lex.l: Replace "parse_gdbarch" with method call.
12351         * ada-exp.y (parse_type, find_primitive_type, type_char)
12352         (type_system_address): Replace "parse_gdbarch" with method call.
12353
12354 2019-04-04  Tom Tromey  <[email protected]>
12355
12356         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12357         * stap-probe.c (stap_parse_argument): Update.
12358         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12359         initial_size parameter.
12360         * rust-exp.y (rust_lex_tests): Update.
12361         * parse.c (parser_state): Update.
12362         (parse_exp_in_context): Update.
12363         * parser-defs.h (struct parser_state) <parser_state>: Remove
12364         "initial_size" parameter.
12365
12366 2019-04-04  Tom Tromey  <[email protected]>
12367
12368         * parser-defs.h (increase_expout_size): Don't declare.
12369         * parse.c (increase_expout_size): Now static.
12370
12371 2019-04-04  Thomas Schwinge  <[email protected]>
12372
12373         * gnu-nat.c (gnu_nat_target::wait): Fix
12374         target_waitstatus_to_string call.
12375
12376 2019-04-01  Andrew Burgess  <[email protected]>
12377
12378         * eval.c (evaluate_subexp_standard): Handle internal functions
12379         during Fortran function call handling.
12380
12381 2019-04-01  Andrew Burgess  <[email protected]>
12382
12383         * NEWS: Mention new internal functions.
12384         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12385         (read_base_type): Use dwarf2_init_complex_target_type.
12386         * value.c (creal_internal_fn): New function.
12387         (cimag_internal_fn): New function.
12388         (_initialize_values): Register new internal functions.
12389
12390 2019-04-01  Philippe Waroquiers  <[email protected]>
12391
12392         * infrun.c (stop_all_threads): If debug_infrun, always
12393         trace the wait status after wait_one, using
12394         target_waitstatus_to_string and target_pid_to_str.
12395         (handle_inferior_event): Replace various trace of
12396         wait status kind by a single trace.
12397         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12398         wait status kind image by target_waitstatus_to_string.
12399         * target/waitstatus.c (target_waitstatus_to_string): Fix
12400         obsolete comment.
12401
12402 2019-04-01  Tom Tromey  <[email protected]>
12403
12404         PR symtab/23331:
12405         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12406
12407 2019-04-01  Sergio Durigan Junior  <[email protected]>
12408             Pedro Alves  <[email protected]>
12409
12410         * top.c (quit_force): Call 'finalize_values'.
12411         * value.c (finalize_values): New function.
12412         * value.h (finalize_values): Declare.
12413
12414 2019-03-30  Eli Zaretskii  <[email protected]>
12415
12416         * NEWS: Announce $_gdb_major and $_gdb_minor.
12417
12418         * top.c (init_gdb_version_vars): New function.
12419         (gdb_init): Call init_gdb_version_vars.
12420
12421 2019-03-29  Tom Tromey  <[email protected]>
12422
12423         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12424         help text.  Remove dead code.
12425
12426 2019-03-29  Keith Seitz  <[email protected]>
12427
12428         From Siddhesh Poyarekar:
12429         * f-lang.h (f77_get_upperbound): Return LONGEST.
12430         (f77_get_lowerbound): Likewise.
12431         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12432         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12433         print them.
12434         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12435         plongest to format print it.
12436         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12437         (f77_get_upperbound): Likewise.
12438         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12439         LOWER_BOUND to LONGEST.
12440         (f77_create_arrayprint_offset_tbl): Likewise.
12441
12442 2019-03-29  Keith Seitz  <[email protected]>
12443
12444         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12445         %s/pulongest for TYPE_LENGTH instead of %d in format
12446         strings.
12447         * ada-typerint.c (ada_print_type): Likewise.
12448         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12449         * compile/compile-c-support.c (generate_register_struct): Likewise.
12450         * gdbtypes.c (recursive_dump_type): Likewise.
12451         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12452         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12453         instead of %d in format strings.
12454         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12455         to std::min to ULONGEST.
12456         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12457         instead of %d in format strings.
12458         * tracepoint.c (info_scope_command): Likewise.
12459         * typeprint.c (print_offset_data::update)
12460         (print_offset_data::finish): Likewise.
12461         * xtensa-tdep.c (xtensa_store_return_value)
12462         (xtensa_push_dummy_call): Likewise.
12463
12464 2019-03-28  Jon Turney  <[email protected]>
12465
12466         * windows-nat.c (display_selector): Fixed format specifications
12467         for 64-bit Cygwin.
12468
12469 2019-03-28  Philippe Waroquiers  <[email protected]>
12470
12471         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12472
12473 2019-03-28  Sandra Loosemore  <[email protected]>
12474
12475         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12476         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12477         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12478         (nios2_linux_init_abi): Install it.
12479
12480 2019-03-28  Alan Hayward  <[email protected]>
12481
12482         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12483
12484 2019-03-28  Alan Hayward  <[email protected]>
12485
12486         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12487
12488 2019-03-24  Philippe Waroquiers  <[email protected]>
12489             Tom Tromey  <[email protected]>
12490
12491         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12492
12493 2019-03-26  Joel Brobecker  <[email protected]>
12494
12495         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12496         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12497         method to compute the bounds of range types. Also print "[evaluated]"
12498         if the bounds' values come from a dynamic evaluation.
12499
12500 2019-03-26  Andrew Burgess  <[email protected]>
12501
12502         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12503         whitespace when pretty printing is on.
12504
12505 2019-03-26  Alan Hayward  <[email protected]>
12506
12507         * ppc-linux-nat.c: Add include.
12508
12509 2019-03-26  Alan Hayward  <[email protected]>
12510
12511         * NEWS: Mention AArch64 Pointer Authentication.
12512
12513 2019-03-26  Alan Hayward  <[email protected]>
12514
12515         * arm-linux-nat.c: Add include.
12516
12517 2019-03-25  Simon Marchi  <[email protected]>
12518
12519         * source-cache.c (source_cache::get_source_lines): Re-read
12520         fullname after calling open_source_file.
12521
12522 2019-03-25  John Baldwin  <[email protected]>
12523
12524         * NEWS: Mention TLS support for FreeBSD.
12525
12526 2019-03-25  Tom Tromey  <[email protected]>
12527
12528         * minsyms.c (BUNCH_SIZE): Update comment.
12529         (~minimal_symbol_reader): Remove old comment.
12530         (compact_minimal_symbols): Update comment.
12531         (minimal_symbol_reader::install): Remove old comment.  Update
12532         other comments.
12533
12534 2019-03-25  Alan Hayward  <[email protected]>
12535
12536         * s390-linux-nat.c: Add include.
12537
12538 2019-03-25  Alan Hayward  <[email protected]>
12539
12540         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12541         Call linux_get_hwcap.
12542         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12543         Likewise.
12544         (aarch64_linux_get_hwcap): Remove function.
12545         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12546         declaration.
12547         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12548         linux_get_hwcap.
12549         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12550         * linux-tdep.c (linux_get_hwcap): Add function.
12551         (linux_get_hwcap2): Likewise.
12552         * linux-tdep.h (linux_get_hwcap): Add declaration.
12553         (linux_get_hwcap2): Likewise.
12554         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12555         (ppc_linux_get_hwcap2): Likewise.
12556         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12557         linux_get_hwcap.
12558         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12559         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12560         (ppc_linux_nat_target::read_description): Likewise.
12561         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12562         * s390-linux-nat.c: Likewise.
12563         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12564
12565 2019-03-24  Tom Tromey  <[email protected]>
12566
12567         * ada-lang.c (standard_lookup): Simplify initialization.
12568         (ada_lookup_symbol_nonlocal): Simplify return.
12569         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12570         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12571         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12572         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12573         initialization.
12574         * solib.c (solib_global_lookup): Simplify.
12575         * symtab.c (null_block_symbol): Remove.
12576         (symbol_cache_lookup): Simplify returns.
12577         (lookup_language_this): Simplify returns.
12578         (lookup_symbol_aux): Simplify return.
12579         (lookup_local_symbol): Simplify returns.
12580         (lookup_global_symbol_from_objfile): Simplify return.
12581         (lookup_symbol_in_objfile_symtabs)
12582         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12583         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12584         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12585         * cp-namespace.c (cp_lookup_bare_symbol)
12586         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12587         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12588         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12589         (cp_lookup_symbol_via_imports): Simplify initialization.
12590         (find_symbol_in_baseclass): Likewise.
12591         * symtab.h (null_block_symbol): Remove.
12592         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12593         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12594         (d_lookup_symbol_module): Likewise.
12595         (find_symbol_in_baseclass): Simplify initialization.
12596
12597 2019-03-24  Tom Tromey  <[email protected]>
12598
12599         * expression.h: Don't include symtab.h.
12600         (struct block): Forward declare.
12601
12602 2019-03-24  Tom Tromey  <[email protected]>
12603
12604         * c-exp.y (typebase): Remove casts.
12605         * gdbtypes.c (lookup_unsigned_typename, )
12606         (lookup_signed_typename): Remove cast.
12607         * eval.c (parse_to_comma_and_eval): Remove cast.
12608         * parse.c (write_dollar_variable): Remove cast.
12609         * block.h (struct block) <superblock>: Now const.
12610         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12611         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12612         (map_block): Make "block" const.
12613         * symfile.h (struct quick_symbol_functions)
12614         <map_matching_symbols>: Constify block argument to "callback".
12615         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12616         const.
12617         (find_pc_sect_compunit_symtab): Make "b" const.
12618         (find_symbol_at_address): Likewise.
12619         (search_symbols): Likewise.
12620         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12621         (dw2_debug_names_lookup_symbol): Likewise.
12622         (dw2_map_matching_symbols): Update.
12623         * p-valprint.c (pascal_val_print): Remove "block".
12624         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12625         (aux_add_nonlocal_symbols): Make "block" const.
12626         (resolve_subexp): Remove cast.
12627         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12628         const.
12629         (iterate_over_file_blocks): Likewise.
12630         * f-exp.y (%union) <bval>: Remove.
12631         * coffread.c (patch_opaque_types): Make "b" const.
12632         * spu-tdep.c (spu_catch_start): Make "block" const.
12633         * c-valprint.c (print_unpacked_pointer): Remove "block".
12634         * symmisc.c (dump_symtab_1): Make "b" const.
12635         (block_depth): Make "block" const.
12636         * d-exp.y (%union) <bval>: Remove.
12637         * cp-support.h (cp_lookup_rtti_type): Update.
12638         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12639         * psymtab.c (psym_lookup_symbol): Make "block" const.
12640         (maintenance_check_psymtabs): Make "b" const.
12641         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12642         (enumerate_locals, enumerate_args): Update.
12643         * python/py-symtab.c (stpy_global_block): Make "block" const.
12644         (stpy_static_block): Likewise.
12645         * inline-frame.c (block_starting_point_at): Make "new_block"
12646         const.
12647         * block.c (find_block_in_blockvector): Make return type const.
12648         (blockvector_for_pc_sect): Make "b" const.
12649         (find_block_in_blockvector): Make "b" const.
12650
12651 2019-03-23  Tom Tromey  <[email protected]>
12652
12653         * varobj.c (varobj_create): Update.
12654         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12655         * printcmd.c (display_command, do_one_display): Don't reset
12656         innermost_block.
12657         * parser-defs.h (enum innermost_block_tracker_type): Move to
12658         expression.h.
12659         (innermost_block): Update comment.
12660         * parse.c (parse_exp_1): Add tracker_types parameter.
12661         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12662         tracker_types parameter.  Reset innermost_block.
12663         (parse_exp_in_context): Remove.
12664         (parse_expression_for_completion): Update.
12665         * objfiles.c (~objfile): Don't reset expression_context_block or
12666         innermost_block.
12667         * expression.h (enum innermost_block_tracker_type): Move from
12668         parser-defs.h.
12669         (parse_exp_1): Add tracker_types parameter.
12670         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12671         reset innermost_block.
12672
12673 2019-03-23  Tom Tromey  <[email protected]>
12674
12675         * objfiles.h: Include bcache.h.
12676
12677 2019-03-23  Tom Tromey  <[email protected]>
12678
12679         * linespec.c (get_current_search_block): Use
12680         scoped_restore_current_language.
12681         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12682
12683 2019-03-22  Alan Hayward  <[email protected]>
12684             Jiong Wang  <[email protected]>
12685
12686         * aarch64-linux-tdep.c
12687         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12688         section.
12689         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12690
12691 2019-03-22  Alan Hayward  <[email protected]>
12692             Jiong Wang  <[email protected]>
12693
12694         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12695         instructions.
12696         (aarch64_analyze_prologue_test): Add PACIASP test.
12697         (aarch64_prologue_prev_register): Unmask PC value.
12698
12699 2019-03-22  Alan Hayward  <[email protected]>
12700             Jiong Wang  <[email protected]>
12701
12702         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12703         (aarch64_dwarf2_prev_register): Unmask PC value.
12704         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12705         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12706         DW_CFA_AARCH64_negate_ra_state.
12707         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12708
12709 2019-03-22  Alan Hayward  <[email protected]>
12710             Jiong Wang  <[email protected]>
12711
12712         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12713         registers.
12714         (aarch64_pseudo_register_name): Likewise.
12715         (aarch64_pseudo_register_type): Likewise.
12716         (aarch64_pseudo_register_reggroup_p): Likewise.
12717         (aarch64_gdbarch_init): Add pauth registers.
12718         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12719         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12720         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12721         (struct gdbarch_tdep): Add regnum for ra_state.
12722
12723 2019-03-22  Alan Hayward  <[email protected]>
12724             Jiong Wang  <[email protected]>
12725
12726         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12727
12728 2019-03-22  Alan Hayward  <[email protected]>
12729             Jiong Wang  <[email protected]>
12730
12731         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12732         function.
12733         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12734         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12735         (aarch64_gdbarch_init): Add puth registers.
12736         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12737         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12738         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12739
12740 2019-03-22  Alan Hayward  <[email protected]>
12741             Jiong Wang  <[email protected]>
12742
12743         * aarch64-linux-nat.c
12744         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12745         * aarch64-linux-tdep.c
12746         (aarch64_linux_core_read_description): Likewise.
12747         (aarch64_linux_get_hwcap): New function.
12748         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12749         (aarch64_linux_get_hwcap): New declaration.
12750
12751 2019-03-22  Alan Hayward  <[email protected]>
12752             Jiong Wang  <[email protected]>
12753
12754         * aarch64-linux-nat.c
12755         (aarch64_linux_nat_target::read_description): Add pauth param.
12756         * aarch64-linux-tdep.c
12757         (aarch64_linux_core_read_description): Likewise.
12758         * aarch64-tdep.c (struct target_desc): Add in pauth.
12759         (aarch64_read_description): Add pauth param.
12760         (aarch64_gdbarch_init): Likewise.
12761         * aarch64-tdep.h (aarch64_read_description): Likewise.
12762         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12763         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12764         * features/Makefile: Add new files.
12765         * features/aarch64-pauth.c: New file.
12766         * features/aarch64-pauth.xml: New file.
12767
12768 2019-03-20  Tom Tromey  <[email protected]>
12769
12770         * infrun.c (handle_inferior_event): Rename from
12771         handle_inferior_event_1.  Create a scoped_value_mark.
12772         (handle_inferior_event): Remove.
12773
12774 2019-03-19  Tom Tromey  <[email protected]>
12775
12776         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12777         * infrun.h (print_stop_event): Add "displays" parameter.
12778         * infrun.c (print_stop_event): Add "displays" parameter.
12779
12780 2019-03-19  Pedro Alves  <[email protected]>
12781
12782         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12783         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12784         to -1.  Fix TABs vs spaces.
12785         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12786         * tui/tui-out.h (tui_ui_out) Add intro comments.
12787         <m_line, m_start_of_line>: In-class initialize, and add describing
12788         comment.
12789
12790 2019-03-18  Alan Hayward  <[email protected]>
12791
12792         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12793         variable names.
12794         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12795
12796 2019-03-18  Pedro Alves  <[email protected]>
12797             Eli Zaretskii <[email protected]>
12798
12799         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12800         m_line and m_start_of_line.
12801
12802 2019-03-18  Eli Zaretskii  <[email protected]>
12803
12804         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12805         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12806         it returns a newline.  This fixes a regression in TU mode, whereby
12807         the next line is output on the same screen line as the user input.
12808
12809 2019-03-18  Tom Tromey  <[email protected]>
12810
12811         * minsyms.c (minimal_symbol_reader::install): Remove call to
12812         obstack_blank.
12813
12814 2019-03-18  Pedro Alves  <[email protected]>
12815
12816         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12817         New globals.
12818         (apply_style): New, factored out from ...
12819         (apply_ansi_escape): ... this.  Handle reverse video mode.
12820         (tui_set_reverse_mode): New function.
12821         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12822         * tui/tui-winsource.c (tui_show_source_line): Use
12823         tui_set_reverse_mode instead of setting A_STANDOUT.
12824         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12825         New setter methods.
12826
12827 2019-03-18  Hannes Domani  <[email protected]>
12828
12829         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12830         Handle tabs.
12831
12832 2019-03-18  Tom Tromey  <[email protected]>
12833
12834         * ada-lang.c (empty_array): Add "high" parameter.
12835         (ada_evaluate_subexp): Update.
12836
12837 2019-03-17  Sergei Trofimovich <[email protected]>
12838
12839         * unittests/string_view-selftests.c: Define
12840         _initialize_string_view_selftests unconditionally.
12841
12842 2019-03-17  Vladimir Martyanov  <[email protected]>
12843
12844         PR gdb/24350
12845         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12846
12847 2019-03-17  Vladimir Martyanov  <[email protected]>
12848
12849         PR gdb/24351
12850         * windows-nat.c (display_selector): Fix format specifiers.
12851
12852 2019-03-17  Eli Zaretskii  <[email protected]>
12853
12854         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12855         tui_refill_source_window instead of tui_refresh_win, to update the
12856         current execution line.  This fixes redisplay of the current line
12857         when stepping through the code with "next" or "step".
12858
12859 2019-03-16  Eli Zaretskii  <[email protected]>
12860
12861         * source-cache.c (source_cache::get_source_lines): Call
12862         find_source_lines to initialize s->nlines.  This fixes vertical
12863         scrolling of TUI source window when the DOWN arrow is pressed.
12864
12865 2019-03-16  Philippe Waroquiers  <[email protected]>
12866
12867         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12868         linux-thread-db.c (_initialize_thread_db): Likewise.
12869
12870 2019-03-16  Eli Zaretskii  <[email protected]>
12871
12872         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12873         wclrtoeol in tui_show_source_line".  This reverts changes made in
12874         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12875
12876 2019-03-15  Tom Tromey  <[email protected]>
12877
12878         * symtab.h (struct minimal_symbol): Derive from
12879         general_symbol_info.
12880         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12881         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12882         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12883         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12884         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12885         (MSYMBOL_SEARCH_NAME): Update.
12886         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12887         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12888         * minsyms.c (minimal_symbol_reader::record_full): Update.
12889
12890 2019-03-15  Tom Tromey  <[email protected]>
12891
12892         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12893
12894 2019-03-15  Tom Tromey  <[email protected]>
12895
12896         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12897         unique_xmalloc_ptr.
12898         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12899         Update.
12900         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12901         (build_minimal_symbol_hash_tables)
12902         (minimal_symbol_reader::install): Update.
12903
12904 2019-03-15  Tom Tromey  <[email protected]>
12905
12906         * symtab.c (create_demangled_names_hash): Update.
12907         (symbol_set_names): Update.
12908         * objfiles.h (struct objfile_per_bfd_storage)
12909         <demangled_names_hash>: Now an htab_up.
12910         * objfiles.c (objfile_per_bfd_storage): Simplify.
12911
12912 2019-03-15  Tom Tromey  <[email protected]>
12913
12914         * objfiles.h (struct objfile_per_bfd_storage): Declare
12915         destructor.
12916         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12917         New.
12918         (get_objfile_bfd_data): Use new.  Don't initialize
12919         language_of_main.
12920         (free_objfile_per_bfd_storage): Remove.
12921         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12922
12923 2019-03-15  Tom Tromey  <[email protected]>
12924
12925         * symfile.c (reread_symbols): Update.
12926         * objfiles.c (objfile::objfile): Update.
12927         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12928         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12929         comment.
12930         (minimal_symbol_reader::install): Update.
12931         (terminate_minimal_symbol_table): Remove.
12932         * jit.c (jit_object_close_impl): Update.
12933
12934 2019-03-15  Tom Tromey  <[email protected]>
12935
12936         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12937         initializations.
12938
12939 2019-03-15  Tom Tromey  <[email protected]>
12940
12941         * objfiles.h (struct objfile_per_bfd_storage)
12942         <demangled_hash_languages>: Now a bitset.
12943         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12944         (lookup_minimal_symbol): Update.
12945
12946 2019-03-15  Tom Tromey  <[email protected]>
12947
12948         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12949         Don't return the symbol.
12950         * coffread.c (record_minimal_symbol): Use record_full.
12951
12952 2019-03-14  Eli Zaretskii  <[email protected]>
12953
12954         The MS-Windows port of ncurses fails to switch to a color pair if
12955         one or both of the colors are the implicit default colors.  This
12956         change records the default colors when TUI is initialized, and
12957         then specifies them explicitly when a color pair uses the default
12958         colors.  This allows color styling in TUI mode on MS-Windows.
12959
12960         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12961         ncurses_norm_attr.
12962         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12963         colors in ncurses_norm_attr.
12964         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12965         "none", replace it with the default color recorded in
12966         ncurses_norm_attr.
12967
12968 2019-03-14  Tom Tromey  <[email protected]>
12969
12970         * source-cache.h (class source_cache) <get_source_lines>: Return
12971         std::string.
12972         * source-cache.c (source_cache::extract_lines): Handle case where
12973         first_pos==npos.  Return std::string.
12974         (source_cache::get_source_lines): Update.
12975
12976 2019-03-14  Tom Tromey  <[email protected]>
12977
12978         * NEWS: Add item for "style sources" commands.
12979         * source-cache.c (source_cache::get_source_lines): Check
12980         source_styling.
12981         * cli/cli-style.c (source_styling): New global.
12982         (_initialize_cli_style): Add "style sources" commands.
12983         (show_style_sources): New function.
12984         * cli/cli-style.h (source_styling): Declare.
12985
12986 2019-03-14  Pedro Alves  <[email protected]>
12987             Tom Tromey  <[email protected]>
12988
12989         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12990         * tui/tui-winsource.c (tui_refill_source_window): New function,
12991         from...
12992         (tui_horizontal_source_scroll): ... here.  Move some logic.
12993         * cli/cli-style.c (set_style_enabled): Notify new observable.
12994         * tui/tui-hooks.c (tui_redisplay_source): New function.
12995         (tui_attach_detach_observers): Attach or detach
12996         tui_redisplay_source.
12997         * observable.h (source_styling_changed): New observable.
12998         * observable.c: Define source_styling_changed observable.
12999
13000 2019-03-13  Tom Tromey  <[email protected]>
13001
13002         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13003         (i386_gnu_nat_target::store_registers): Update.
13004         * target-debug.h (target_debug_print_std_string): New macro.
13005         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13006         * windows-tdep.c (display_one_tib): Update.
13007         * tui/tui-stack.c (tui_make_status_line): Update.
13008         * top.c (print_inferior_quit_action): Update.
13009         * thread.c (thr_try_catch_cmd): Update.
13010         (add_thread_with_info): Update.
13011         (thread_target_id_str): Update.
13012         (thr_try_catch_cmd): Update.
13013         (thread_command): Update.
13014         (thread_find_command): Update.
13015         * record-btrace.c (record_btrace_target::info_record)
13016         (record_btrace_resume_thread, record_btrace_target::resume)
13017         (record_btrace_cancel_resume, record_btrace_step_thread)
13018         (record_btrace_target::wait, record_btrace_target::wait)
13019         (record_btrace_target::wait, record_btrace_target::stop): Update.
13020         * progspace.c (print_program_space): Update.
13021         * process-stratum-target.c
13022         (process_stratum_target::thread_address_space): Update.
13023         * linux-fork.c (linux_fork_mourn_inferior)
13024         (detach_checkpoint_command, info_checkpoints_command)
13025         (linux_fork_context): Update.
13026         (linux_fork_detach): Update.
13027         (class scoped_switch_fork_info): Update.
13028         (delete_checkpoint_command): Update.
13029         * infrun.c (follow_fork_inferior): Update.
13030         (follow_fork_inferior): Update.
13031         (proceed_after_vfork_done): Update.
13032         (handle_vfork_child_exec_or_exit): Update.
13033         (follow_exec): Update.
13034         (displaced_step_prepare_throw): Update.
13035         (displaced_step_restore): Update.
13036         (start_step_over): Update.
13037         (resume_1): Update.
13038         (clear_proceed_status_thread): Update.
13039         (proceed): Update.
13040         (print_target_wait_results): Update.
13041         (do_target_wait): Update.
13042         (context_switch): Update.
13043         (stop_all_threads): Update.
13044         (restart_threads): Update.
13045         (finish_step_over): Update.
13046         (handle_signal_stop): Update.
13047         (switch_back_to_stepped_thread): Update.
13048         (keep_going_pass_signal): Update.
13049         (print_exited_reason): Update.
13050         (normal_stop): Update.
13051         * inferior.c (inferior_pid_to_str): Change return type.
13052         (print_selected_inferior): Update.
13053         (add_inferior): Update.
13054         (detach_inferior): Update.
13055         * dummy-frame.c (fprint_dummy_frames): Update.
13056         * dcache.c (dcache_info_1): Update.
13057         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13058         (btrace_fetch, btrace_clear): Update.
13059         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13060         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13061         type.
13062         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13063         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13064         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13065         * gdbarch.c, gdbarch.h: Rebuild.
13066         * gdbarch.sh (core_pid_to_str): Change return type.
13067         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13068         return type.
13069         (windows_nat_target::pid_to_str): Change return type.
13070         (windows_delete_thread): Update.
13071         (windows_nat_target::attach): Update.
13072         (windows_nat_target::files_info): Update.
13073         * target-delegates.c: Rebuild.
13074         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13075         return type.
13076         (sol_thread_target::pid_to_str): Change return type.
13077         * remote.c (class remote_target) <pid_to_str>: Change return
13078         type.
13079         (remote_target::pid_to_str): Change return type.
13080         (extended_remote_target::attach, remote_target::remote_stop_ns)
13081         (remote_target::remote_notif_remove_queued_reply)
13082         (remote_target::push_stop_reply, remote_target::disable_btrace):
13083         Update.
13084         (extended_remote_target::attach): Update.
13085         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13086         type.
13087         (gdbsim_target::pid_to_str): Change return type.
13088         * ravenscar-thread.c (struct ravenscar_thread_target)
13089         <pid_to_str>: Change return type.
13090         (ravenscar_thread_target::pid_to_str): Change return type.
13091         * procfs.c (class procfs_target) <pid_to_str>: Change return
13092         type.
13093         (procfs_target::pid_to_str): Change return type.
13094         (procfs_target::attach): Update.
13095         (procfs_target::detach): Update.
13096         (procfs_target::fetch_registers): Update.
13097         (procfs_target::store_registers): Update.
13098         (procfs_target::wait): Update.
13099         (procfs_target::files_info): Update.
13100         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13101         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13102         return type.
13103         (nto_procfs_target::pid_to_str): Change return type.
13104         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13105         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13106         return type.
13107         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13108         (exit_lwp): Update.
13109         (attach_proc_task_lwp_callback, get_detach_signal)
13110         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13111         (linux_nat_target::resume, wait_lwp, stop_callback)
13112         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13113         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13114         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13115         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13116         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13117         type.
13118         (inf_ptrace_target::attach): Update.
13119         (inf_ptrace_target::files_info): Update.
13120         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13121         type.
13122         (go32_nat_target::pid_to_str): Change return type.
13123         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13124         (gnu_nat_target::wait): Update.
13125         (gnu_nat_target::wait): Update.
13126         (gnu_nat_target::resume): Update.
13127         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13128         (fbsd_nat_target::wait): Update.
13129         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13130         type.
13131         (darwin_nat_target::attach): Update.
13132         * corelow.c (class core_target) <pid_to_str>: Change return type.
13133         (core_target::pid_to_str): Change return type.
13134         * target.c (normal_pid_to_str): Change return type.
13135         (default_pid_to_str): Likewise.
13136         (target_pid_to_str): Change return type.
13137         (target_translate_tls_address): Update.
13138         (target_announce_detach): Update.
13139         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13140         return type.
13141         (bsd_uthread_target::pid_to_str): Change return type.
13142         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13143         type.
13144         (bsd_kvm_target::pid_to_str): Change return type.
13145         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13146         return type.
13147         (aix_thread_target::pid_to_str): Change return type.
13148         * target.h (struct target_ops) <pid_to_str>: Change return type.
13149         (target_pid_to_str, normal_pid_to_str): Likewise.
13150         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13151         type.
13152         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13153         type.
13154         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13155         return type.
13156         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13157         type.
13158         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13159         type.
13160         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13161         return type.
13162
13163 2019-03-13  Simon Marchi  <[email protected]>
13164
13165         * NEWS: Mention that the new default MI version is 3.  Mention
13166         changes to the output of commands and events that deal with
13167         multi-location breakpoints.
13168         * breakpoint.c: Include "mi/mi-out.h".
13169         (print_one_breakpoint): Change output syntax if using MI version
13170         >= 3.
13171         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13172         New.
13173         (mi_multi_location_breakpoint_output_fixed): New.
13174         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13175         (mi_cmd_fix_multi_location_breakpoint_output): New.
13176         (mi_multi_location_breakpoint_output_fixed): New.
13177         * mi/mi-cmds.c (mi_cmds): Register command
13178         -fix-multi-location-breakpoint-output.
13179         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13180         interpreter "mi".
13181
13182 2019-03-13  Simon Marchi  <[email protected]>
13183
13184         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13185         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13186         instantiate mi_ui_out based on interpreter name.
13187         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13188         * mi/mi-main.c (mi_load_progress): Likewise.
13189
13190 2019-03-12  John Baldwin  <[email protected]>
13191
13192         * NEWS: Combine separate "New targets" sections for 8.3.
13193
13194 2019-03-12  John Baldwin  <[email protected]>
13195
13196         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13197         (ppcfbsd_init_abi): Install gdbarch
13198         "fetch_tls_load_module_address" and "get_thread_local_address"
13199         methods.
13200
13201 2019-03-12  John Baldwin  <[email protected]>
13202
13203         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13204         (riscv_fbsd_init_abi): Install gdbarch
13205         "fetch_tls_load_module_address" and "get_thread_local_address"
13206         methods.
13207
13208 2019-03-12  John Baldwin  <[email protected]>
13209
13210         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13211         (i386fbsd_init_abi): Install gdbarch
13212         "fetch_tls_load_module_address" and "get_thread_local_address"
13213         methods.
13214
13215 2019-03-12  John Baldwin  <[email protected]>
13216
13217         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13218         (amd64fbsd_init_abi): Install gdbarch
13219         "fetch_tls_load_module_address" and "get_thread_local_address"
13220         methods.
13221
13222 2019-03-12  John Baldwin  <[email protected]>
13223
13224         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13225         (struct fbsd_pspace_data): New type.
13226         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13227         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13228         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13229         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13230         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13231
13232 2019-03-12  John Baldwin  <[email protected]>
13233
13234         * gdbtypes.c (lookup_struct_elt): New function.
13235         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13236         * gdbtypes.h (struct struct_elt): New type.
13237         (lookup_struct_elt): New prototype.
13238
13239 2019-03-12  John Baldwin  <[email protected]>
13240
13241         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13242         remove disabled code block.
13243
13244 2019-03-12  John Baldwin  <[email protected]>
13245
13246         * gdbarch.sh (get_thread_local_address): New method.
13247         * gdbarch.h, gdbarch.c: Regenerate.
13248         * target.c (target_translate_tls_address): Use
13249         gdbarch_get_thread_local_address if present instead of
13250         target::get_thread_local_address.
13251
13252 2019-03-12  John Baldwin  <[email protected]>
13253
13254         * target.h (target::get_thread_local_address): Update comment.
13255
13256 2019-03-12  John Baldwin  <[email protected]>
13257
13258         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13259         objfile->separate_debug_objfile_backlink if not NULL.
13260
13261 2019-03-12  John Baldwin  <[email protected]>
13262
13263         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13264         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13265         (amd64bsd_store_inferior_registers): Likewise.
13266         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13267         Enable segment base registers.
13268         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13269         PT_GETFSBASE and PT_GETGSBASE.
13270         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13271         PT_SETGSBASE.
13272         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13273         segment base registers.
13274         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13275
13276 2019-03-12  John Baldwin  <[email protected]>
13277
13278         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13279         Update calls to i386_target_description to add 'segments'
13280         parameter.
13281         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13282         add segment base registers.
13283         * arch/i386.c (i386_create_target_description): Add 'segments'
13284         parameter to enable segment base registers.
13285         * arch/i386.h (i386_create_target_description): Likewise.
13286         * features/i386/32bit-segments.xml: New file.
13287         * features/i386/32bit-segments.c: Generate.
13288         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13289         call to i386_target_description to add 'segments' parameter.
13290         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13291         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13292         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13293         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13294         if feature is present.
13295         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13296         Add 'segments' parameter to call to i386_target_description.
13297         (i386_target_description): Add 'segments' parameter to enable
13298         segment base registers.
13299         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13300         to call to i386_target_description.
13301         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13302         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13303         Define I386_NUM_REGS.
13304         (i386_target_description): Add 'segments' parameter to enable
13305         segment base registers.
13306
13307 2019-03-12  Eli Zaretskii  <[email protected]>
13308
13309         PR/24325
13310         * source-cache.c: #undef open and close, to avoid unresolved
13311         externals during linking.
13312
13313 2019-03-12  Tom Tromey  <[email protected]>
13314
13315         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13316         const.  Add initializers.
13317         (_initialize_remote): Don't initialize ptid globals.
13318
13319 2019-03-12  Pedro Alves  <[email protected]>
13320
13321         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13322
13323 2019-03-12  Pedro Alves  <[email protected]>
13324
13325         * cp-name-parser.y (main): Remove unused 'len' variable.
13326
13327 2019-03-12  Tom Tromey  <[email protected]>
13328
13329         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13330         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13331
13332 2019-03-12  Tom Tromey  <[email protected]>
13333
13334         * linux-nat.c (iterate_over_lwps): Update.
13335         (stop_callback): Remove parameter.
13336         (stop_wait_callback, detach_callback, resume_set_callback)
13337         (select_singlestep_lwp_callback, set_ignore_sigint)
13338         (status_callback, resumed_callback, resume_clear_callback)
13339         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13340         data parameter.
13341         (linux_nat_target::detach, linux_nat_target::resume)
13342         (linux_stop_and_wait_all_lwps, select_event_lwp)
13343         (linux_nat_filter_event, linux_nat_wait_1)
13344         (linux_nat_target::kill, linux_nat_target::stop)
13345         (linux_nat_target::stop): Update.
13346         (linux_nat_resume_callback): Change type.
13347         (resume_stopped_resumed_lwps, count_events_callback)
13348         (select_event_lwp_callback): Likewise.
13349         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13350         * arm-linux-nat.c (struct update_registers_data): Remove.
13351         (update_registers_callback): Change type.
13352         (arm_linux_insert_hw_breakpoint1): Update.
13353         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13354         parameter.
13355         (x86_linux_dr_set_addr): Update.
13356         (x86_linux_dr_set_control): Update.
13357         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13358         (iterate_over_lwps): Use gdb::function_view.
13359         * nat/aarch64-linux-hw-point.c (struct
13360         aarch64_dr_update_callback_param): Remove.
13361         (debug_reg_change_callback): Change type.
13362         (aarch64_notify_debug_reg_change): Update.
13363         * s390-linux-nat.c (s390_refresh_per_info): Update.
13364
13365 2019-03-11  Tom Tromey  <[email protected]>
13366
13367         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13368         redundant assignment to "this_cu".
13369
13370 2019-03-08  Simon Marchi  <[email protected]>
13371
13372         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13373
13374 2019-03-08  Simon Marchi  <[email protected]>
13375
13376         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13377         from...
13378         (rank_one_type): ... this.
13379
13380 2019-03-08  Simon Marchi  <[email protected]>
13381
13382         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13383         from...
13384         (rank_one_type): ... this.
13385
13386 2019-03-08  Simon Marchi  <[email protected]>
13387
13388         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13389         from...
13390         (rank_one_type): ... this.
13391
13392 2019-03-08  Simon Marchi  <[email protected]>
13393
13394         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13395         from...
13396         (rank_one_type): ... this.
13397
13398 2019-03-08  Simon Marchi  <[email protected]>
13399
13400         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13401         from...
13402         (rank_one_type): ... this.
13403
13404 2019-03-08  Simon Marchi  <[email protected]>
13405
13406         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13407         from...
13408         (rank_one_type): ... this.
13409
13410 2019-03-08  Simon Marchi  <[email protected]>
13411
13412         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13413         from...
13414         (rank_one_type): ... this.
13415
13416 2019-03-08  Simon Marchi  <[email protected]>
13417
13418         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13419         from...
13420         (rank_one_type): ... this.
13421
13422 2019-03-08  Simon Marchi  <[email protected]>
13423
13424         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13425         from...
13426         (rank_one_type): ... this.
13427
13428 2019-03-08  Simon Marchi  <[email protected]>
13429
13430         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13431         from...
13432         (rank_one_type): ... this.
13433
13434 2019-03-08  Simon Marchi  <[email protected]>
13435
13436         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13437         from...
13438         (rank_one_type): ... this.
13439
13440 2019-03-08  Simon Marchi  <[email protected]>
13441
13442         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13443         from...
13444         (rank_one_type): ... this.
13445
13446 2019-02-27  Philippe Waroquiers  <[email protected]>
13447
13448         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13449         inferior-events' shows the example events.
13450
13451 2019-03-08  Eli Zaretskii  <[email protected]>
13452
13453         Support styling on native MS-Windows console
13454
13455         PR/24315
13456         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13457         on MS-Windows if $TERM is not defined.
13458
13459         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13460
13461         * posix-hdep.c (gdb_console_fputs):
13462         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13463         functions.
13464         * ui-file.h (gdb_console_fputs): Add prototype.
13465
13466         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13467         back to fputs only if the former returns zero.
13468
13469 2019-03-07  Tom Tromey  <[email protected]>
13470
13471         * symmisc.c (print_symbol_bcache_statistics): Update.
13472         (print_objfile_statistics): Update.
13473         * symfile.c (allocate_symtab): Update.
13474         * stabsread.c: Don't include bcache.h.
13475         * psymtab.h (struct psymbol_bcache): Don't declare.
13476         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13477         (psymbol_bcache_init, psymbol_bcache_free)
13478         (psymbol_bcache_get_bcache): Don't declare.
13479         * psymtab.c (struct psymbol_bcache): Remove.
13480         (psymtab_storage::psymtab_storage): Update.
13481         (psymtab_storage::~psymtab_storage): Update.
13482         (psymbol_bcache_init, psymbol_bcache_free)
13483         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13484         (add_psymbol_to_bcache): Update.
13485         (allocate_psymtab): Update.
13486         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13487         macro_cache>: No longer pointers.
13488         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13489         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13490         * macrotab.c (macro_bcache): Update.
13491         * macroexp.c: Don't include bcache.h.
13492         * gdbtypes.c (check_types_worklist): Update.
13493         (types_deeply_equal): Remove TRY/CATCH.  Update.
13494         * elfread.c (elf_symtab_read): Update.
13495         * dwarf2read.c: Don't include bcache.h.
13496         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13497         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13498         (print_bcache_statistics, bcache_memory_used): Don't declare.
13499         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13500         methods.  Rename all data members.
13501         * bcache.c (struct bcache): Move to bcache.h.
13502         (bcache::expand_hash_table): Rename from expand_hash_table.
13503         (bcache): Remove.
13504         (bcache::insert): Rename from bcache_full.
13505         (bcache::compare): Rename from bcache_compare.
13506         (bcache_xmalloc): Remove.
13507         (bcache::~bcache): Rename from bcache_xfree.
13508         (bcache::print_statistics): Rename from print_bcache_statistics.
13509         (bcache::memory_used): Rename from bcache_memory_used.
13510
13511 2019-03-07  Pedro Alves  <[email protected]>
13512
13513         * infrun.c (normal_stop): Also check for
13514         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13515
13516 2019-03-07  Andrew Burgess  <[email protected]>
13517
13518         * f-lang.c (value_from_host_double): Moved to...
13519         * value.c (value_from_host_double): ...here.
13520         * value.h (value_from_host_double): Declare.
13521         * guile/scm-math.c (vlscm_convert_typed_number): Use
13522         value_from_host_double.
13523         (vlscm_convert_number): Likewise.
13524         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13525         * python/py-value.c (convert_value_from_python): Likewise.
13526
13527 2019-03-06  Tom Tromey  <[email protected]>
13528
13529         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13530
13531 2019-03-06  Tom Tromey  <[email protected]>
13532
13533         * utils.h (free_current_contents): Don't declare.
13534         * utils.c (free_current_contents): Remove.
13535
13536 2019-03-06  Tom Tromey  <[email protected]>
13537
13538         * top.c (quit_force): Update.
13539         * main.c (captured_command_loop): Update.
13540         * common/new-op.c (operator new): Update.
13541         * common/common-exceptions.c (struct catcher)
13542         <save_cleanup_chain>: Remove member.
13543         (exceptions_state_mc_init): Update.
13544         (exception_try_scope_entry): Return nullptr.
13545         (exception_try_scope_exit, exception_rethrow)
13546         (throw_exception_sjlj, throw_exception_cxx): Update.
13547         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13548         (all_cleanups, do_cleanups, discard_cleanups)
13549         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13550         (restore_cleanups, restore_final_cleanups): Don't declare.
13551         (do_final_cleanups): Remove parameter.
13552         * common/cleanups.c (cleanup_chain, make_cleanup)
13553         (make_cleanup_dtor, all_cleanups, do_cleanups)
13554         (discard_my_cleanups, discard_cleanups)
13555         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13556         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13557         (null_cleanup): Remove.
13558         (do_final_cleanups): Remove parameter.
13559
13560 2019-03-06  Tom Tromey  <[email protected]>
13561
13562         * remote.c (remote_target::remote_parse_stop_reply): Use
13563         unique_xmalloc_ptr.
13564
13565 2019-03-06  Tom Tromey  <[email protected]>
13566
13567         * stabsread.c (struct stabs_field_info): Rename from field_info.
13568         <list, fnlist>: Add initializers.
13569         <obstack>: New member.
13570         (read_member_functions, read_struct_fields, read_baseclasses):
13571         Allocate on obstack.  Don't use cleanups.
13572         (read_one_struct_field, read_member_functions, read_struct_fields)
13573         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13574         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13575         (read_struct_type): Update.
13576
13577 2019-03-06  Tom Tromey  <[email protected]>
13578
13579         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13580         * common/filestuff.h (make_cleanup_close): Don't declare.
13581         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13582         Remove.
13583
13584 2019-03-06  Tom Tromey  <[email protected]>
13585
13586         * solib-aix.c: Use make_scope_exit.
13587
13588 2019-03-06  Tom Tromey  <[email protected]>
13589
13590         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13591         Use make_scope_exit.
13592
13593 2019-03-06  Tom Tromey  <[email protected]>
13594
13595         * solib-svr4.c (disable_probes_interface): Remove parameter.
13596         (svr4_handle_solib_event): Use make_scope_exit.
13597
13598 2019-03-06  Tom Tromey  <[email protected]>
13599
13600         * remote.c (struct stop_reply_deleter): Remove.
13601         (stop_reply_up): Update.
13602         (struct stop_reply): Derive from notif_event.  Don't typedef.
13603         <regcache>: Now a std::vector.
13604         (stop_reply_xfree): Remove.
13605         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13606         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13607         (remote_target::discard_pending_stop_replies): Use delete.
13608         (remote_target::remote_parse_stop_reply): Update.
13609         (remote_target::process_stop_reply): Update.
13610         * remote-notif.h (struct notif_event): Add virtual destructor.
13611         Remove "dtr" member.
13612         (struct notif_client) <alloc_event>: Return a unique_ptr.
13613         (notif_event_xfree): Don't declare.
13614         (notif_event_up): New typedef.
13615         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13616         (notif_event_xfree, do_notif_event_xfree): Remove.
13617         (remote_notif_state_xfree): Update.
13618
13619 2019-03-06  Tom Tromey  <[email protected]>
13620
13621         * infrun.c (displaced_step_clear_cleanup): Now a
13622         forward_scope_exit type.
13623         (displaced_step_prepare_throw): Update.
13624         (displaced_step_fixup): Update.
13625
13626 2019-03-06  Tom Tromey  <[email protected]>
13627
13628         * inferior.h (class inferior): Update comment.
13629         * gdbthread.h (class thread_info): Update comment.
13630
13631 2019-03-06  Joel Brobecker  <[email protected]>
13632             Tom Tromey  <[email protected]>
13633
13634         * stabsread.h (struct stab_section_list): Remove.
13635         (coffstab_build_psymtabs): Update.
13636         * dbxread.c (symbuf_sections): Now a std::vector.
13637         (sect_idx): New global.
13638         (fill_symbuf): Update.
13639         (coffstab_build_psymtabs): Change type of stabsects parameter.
13640         Update.
13641         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13642         std::vector.
13643         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13644         (coff_locate_sections): Update.
13645         (coff_symfile_read): Remove cleanups.  Update.
13646         (init_stringtab): Add storage parameter.
13647         (free_stringtab, free_stringtab_cleanup): Remove.
13648         (init_lineno): Add storage parameter.
13649         (free_linetab, free_linetab_cleanup): Remove.
13650
13651 2019-03-06  Pedro Alves  <[email protected]>
13652
13653         * linux-fork.c (fork_info::clobber_regs): Delete.
13654         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13655         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13656         comment.  Adjust.
13657         (scoped_switch_fork_info::scoped_switch_fork_info)
13658         (checkpoint_command, linux_fork_context): Adjust
13659         fork_save_infrun_state calls.
13660
13661 2019-03-06  Pedro Alves  <[email protected]>
13662
13663         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13664         (inf_has_multiple_threads): Return 'bool' and rewrite using
13665         inferior_info::threads().
13666
13667 2019-03-06  Pedro Alves  <[email protected]>
13668
13669         * linux-fork.c: Include <list>.
13670         (fork_list): Now a std::list instance.
13671         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13672         (forks_exist_p, find_last_fork): Adjust.
13673         (new_fork): Delete.
13674         (one_fork_p): New.
13675         (add_fork): Adjust.
13676         (free_fork): Delete, folded into fork_info::~fork_info().
13677         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13678         Adjust.
13679         (init_fork_list): Delete.
13680         (linux_fork_killall, linux_fork_mourn_inferior)
13681         (linux_fork_detach, info_checkpoints_command): Adjust.
13682         (_initialize_linux_fork): No longer call init_fork_list.
13683
13684 2019-03-06  Pedro Alves  <[email protected]>
13685
13686         * linux-fork.c (new_fork): New, split out of ...
13687         (add_fork): ... this.  Return void.  Move "first fork" special
13688         case from here, to ...
13689         (checkpoint_command): ... here.
13690         * linux-linux.h (add_fork): Return void.
13691
13692 2019-03-06  Andrew Burgess  <[email protected]>
13693
13694         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13695
13696 2019-03-06  Andrew Burgess  <[email protected]>
13697             Chris January  <[email protected]>
13698             David Lecomber  <[email protected]>
13699
13700         * f-exp.y: New token, UNOP_INTRINSIC.
13701         (exp): New pattern using UNOP_INTRINSIC token.
13702         (f77_keywords): Add 'abs' keyword.
13703         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13704         (value_from_host_double): New function.
13705         (evaluate_subexp_f): Support UNOP_ABS.
13706
13707 2019-03-06  Andrew Burgess  <[email protected]>
13708
13709         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13710         types.
13711
13712 2019-03-06  Andrew Burgess  <[email protected]>
13713
13714         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13715         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13716         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13717
13718 2019-03-06  Andrew Burgess  <[email protected]>
13719
13720         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13721
13722 2019-03-06  Andrew Burgess  <[email protected]>
13723             Chris January  <[email protected]>
13724
13725         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13726         * f-exp.y: Define 'KIND' token.
13727         (exp): New pattern for KIND expressions.
13728         (ptype): Handle types with a kind extension.
13729         (direct_abs_decl): Extend to spot kind extensions.
13730         (f77_keywords): Add 'kind' to the list.
13731         (push_kind_type): New function.
13732         (convert_to_kind_type): New function.
13733         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13734         * parse.c (operator_length_standard): Likewise.
13735         * parser-defs.h (enum type_pieces): Add tp_kind.
13736         * std-operator.def: Add UNOP_KIND.
13737
13738 2019-03-06  Andrew Burgess  <[email protected]>
13739
13740         * f-exp.y (f_parse): Set yydebug.
13741
13742 2019-03-06  Andrew Burgess  <[email protected]>
13743
13744         * f-lang.c (evaluate_subexp_f): New function.
13745         (exp_descriptor_f): New global.
13746         (f_language_defn): Use exp_descriptor_f instead of
13747         exp_descriptor_standard.
13748
13749 2019-03-06  Andrew Burgess  <[email protected]>
13750
13751         * f-exp.y (struct token): Add comments.
13752         (dot_ops): Remove uppercase versions and the end marker.
13753         (f77_keywords): Likewise.
13754         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13755         entries in the dot_ops array are case insensitive, and use
13756         strncasecmp to compare strings.  Also some whitespace cleanup in
13757         this area.  Similar for the f77_keywords array, except entries in
13758         this list might be case sensitive.
13759
13760 2019-03-06  Andrew Burgess  <[email protected]>
13761
13762         * f-exp.y (struct f77_boolean_val): Add comments.
13763         (boolean_values): Remove uppercase versions, and end marker.
13764         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13765         and use strncasecmp to achieve case insensitivity.  Additionally,
13766         perform whitespace cleanup around this code.
13767
13768 2019-03-06  Tom Tromey  <[email protected]>
13769
13770         * remote-sim.c (gdbsim_target_open): Use result of
13771         gdb_argv::release.
13772
13773 2019-03-06  Richard Bunt  <[email protected]>
13774         Dirk Schubert  <[email protected]>
13775         Chris January  <[email protected]>
13776
13777         * eval.c (evaluate_subexp_standard): Call Fortran argument
13778         wrapping logic.
13779         * f-lang.c (struct value): A value which can be passed into a
13780         Fortran function call.
13781         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13782         where appropriate.
13783         (struct type): Value ready for a Fortran function call.
13784         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13785         is needed.
13786         * f-lang.h (fortran_argument_convert): Declaration.
13787         (fortran_preserve_arg_pointer): Declaration.
13788         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13789
13790 2019-03-05  Tom Tromey  <[email protected]>
13791
13792         * python/py-prettyprint.c (print_string_repr): Remove #if.
13793         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13794
13795 2019-03-05  Tom Tromey  <[email protected]>
13796
13797         * target.c (the_dummy_target): Move later.  Change type to
13798         "dummy_target".
13799         (initialize_targets): Don't initialize the_dummy_target.
13800
13801 2019-03-05  Tom Tromey  <[email protected]>
13802
13803         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13804         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13805
13806 2019-03-05  Tom Tromey  <[email protected]>
13807
13808         * windows-nat.c (windows_nat_target::attach)
13809         (windows_nat_target::detach): Don't call gdb_flush.
13810         * valprint.c (generic_val_print, val_print, val_print_string):
13811         Don't call gdb_flush.
13812         * utils.c (defaulted_query): Don't call gdb_flush.
13813         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13814         * target.c (target_announce_detach): Don't call gdb_flush.
13815         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13816         * remote.c (extended_remote_target::attach): Don't call
13817         gdb_flush.
13818         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13819         * printcmd.c (do_examine): Don't call gdb_flush.
13820         (info_display_command): Don't call gdb_flush.
13821         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13822         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13823         * memattr.c (info_mem_command): Don't call gdb_flush.
13824         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13825         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13826         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13827         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13828         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13829         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13830         (gnu_nat_target::detach): Don't call gdb_flush.
13831         * f-valprint.c (f_val_print): Don't call gdb_flush.
13832         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13833         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13834         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13835         gdb_flush.
13836         * c-valprint.c (c_val_print): Don't call gdb_flush.
13837         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13838
13839 2019-03-05  Tom Tromey  <[email protected]>
13840
13841         * varobj.c (update_dynamic_varobj_children): Update.
13842         (install_default_visualizer): Use reset, not release.
13843         * value.c (set_internalvar): Update.
13844         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13845         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13846         ATTRIBUTE_UNUSED_RESULT.
13847
13848 2019-03-05  Tom Tromey  <[email protected]>
13849
13850         * remote.c (class scoped_remote_fd) <release>: Add
13851         ATTRIBUTE_UNUSED_RESULT.
13852
13853 2019-03-05  Tom Tromey  <[email protected]>
13854
13855         * macroexp.c (struct macro_buffer) <release>: Add
13856         ATTRIBUTE_UNUSED_RESULT.
13857
13858 2019-03-05  Tom Tromey  <[email protected]>
13859
13860         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13861         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13862         ATTRIBUTE_UNUSED_RESULT.
13863
13864 2019-03-05  Tom Tromey  <[email protected]>
13865
13866         * common/scoped_fd.h (class scoped_fd) <release>: Add
13867         ATTRIBUTE_UNUSED_RESULT.
13868
13869 2019-03-05  Tom Tromey  <[email protected]>
13870
13871         * parser-defs.h (struct parser_state) <release>: Add
13872         ATTRIBUTE_UNUSED_RESULT.
13873
13874 2019-03-05  Tom Tromey  <[email protected]>
13875
13876         * utils.h (class gdb_argv) <release>: Add
13877         ATTRIBUTE_UNUSED_RESULT.
13878         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13879
13880 2019-03-02  Eli Zaretskii  <[email protected]>
13881
13882         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13883         for-loop range, to avoid compiler warnings.
13884
13885         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13886         avoid compiler warnings about unused variables.
13887
13888         * NEWS: Mention end of support for native debugging on MS-Windows
13889         before XP.
13890
13891         PR gdb/24292
13892         * common/netstuff.c:
13893         * gdbserver/gdbreplay.c
13894         * gdbserver/remote-utils.c:
13895         * ser-tcp.c:
13896         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13897         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13898         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13899         'getaddrinfo' and 'freeaddrinfo' were not available before
13900         Windows XP, and mingw.org's MinGW headers by default define
13901         _WIN32_WINNT to 0x500.
13902
13903 2019-03-01  Gary Benson <[email protected]>
13904
13905         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13906
13907 2019-02-28  Brian Vandenberg  <[email protected]>
13908             Rainer Orth  <[email protected]>
13909
13910         PR gdb/8527
13911         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13912         set_sigint_trap, clear_sigint_trap.
13913
13914 2019-02-27  Philippe Waroquiers  <[email protected]>
13915
13916         * target.c (target_detach): Clear the regcache and the
13917         frame cache.
13918
13919 2019-02-27  Pedro Alves  <[email protected]>
13920
13921         * utils.c (set_screen_size): When we cap the height/width sizes,
13922         tweak the corresponding command variable to show "unlimited":
13923
13924 2019-02-27  Saagar Jha  <[email protected]>
13925             Pedro Alves  <[email protected]>
13926
13927         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13928         before calling rl_set_screen_size.
13929
13930 2019-02-27  Tom Tromey  <[email protected]>
13931
13932         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13933         define.
13934         * python/py-value.c: Remove Python 2.4 workaround.
13935         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13936         workaround.
13937         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13938         Python 2.4 workaround.
13939         * python/python-internal.h: Remove Python 2.4 comment.
13940         (Py_ssize_t): Don't define.
13941         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13942         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13943         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13944         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13945         * python/python.c (do_start_initialization): Remove Python 2.4
13946         workaround.
13947         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13948         (print_children): Remove Python 2.4 workaround.
13949         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13950         workaround.
13951         (CHARBUFFERPROC_NAME): Remove.
13952         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13953         Python 2.4 workaround.
13954
13955 2019-02-27  Kevin Buettner  <[email protected]>
13956
13957         * NEWS: Note minimum Python version.
13958
13959 2019-02-27  Kevin Buettner  <[email protected]>
13960
13961         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13962         code from these functions.  Remove corresponding ifdefs.  Use
13963         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13964         Remove gotos and target of gotos.
13965         (infpy_search_memory): Likewise.
13966
13967 2019-02-27  Andrew Burgess  <[email protected]>
13968
13969         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13970         (hppa_gdbarch_init): Don't register deleted functions with
13971         gdbarch.
13972
13973 2019-02-27  Andrew Burgess  <[email protected]>
13974
13975         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13976         (h8300_unwind_sp): Delete.
13977         (h8300_dummy_id): Delete.
13978         (h8300_gdbarch_init): Don't register deleted functions with
13979         gdbarch.
13980
13981 2019-02-27  Andrew Burgess  <[email protected]>
13982
13983         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13984         (ft32_unwind_pc): Delete.
13985         (ft32_unwind_sp): Delete.
13986         (ft32_gdbarch_init): Don't register deleted functions with
13987         gdbarch.
13988
13989 2019-02-27  Andrew Burgess  <[email protected]>
13990
13991         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13992         (frv_unwind_pc): Delete.
13993         (frv_unwind_sp): Delete.
13994         (frv_gdbarch_init): Don't register deleted functions with
13995         gdbarch.
13996
13997 2019-02-27  Andrew Burgess  <[email protected]>
13998
13999         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14000         (riscv_unwind_pc): Delete.
14001         (riscv_unwind_sp): Delete.
14002         (riscv_gdbarch_init): Don't register deleted functions with
14003         gdbarch.
14004
14005 2019-02-27  Andrew Burgess  <[email protected]>
14006
14007         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14008         (csky_unwind_pc): Delete.
14009         (csky_unwind_sp): Delete.
14010         (csky_gdbarch_init): Don't register deleted functions with
14011         gdbarch.
14012
14013 2019-02-27  Andrew Burgess  <[email protected]>
14014
14015         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14016         (cris_unwind_pc): Delete.
14017         (cris_unwind_sp): Delete.
14018         (cris_gdbarch_init): Don't register deleted functions with
14019         gdbarch.
14020
14021 2019-02-27  Andrew Burgess  <[email protected]>
14022
14023         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14024         (bfin_unwind_pc): Delete.
14025         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14026
14027 2019-02-27  Andrew Burgess  <[email protected]>
14028
14029         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14030         (arm_unwind_pc): Delete.
14031         (arm_unwind_sp): Delete.
14032         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14033
14034 2019-02-27  Andrew Burgess  <[email protected]>
14035
14036         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14037         (arc_unwind_pc): Delete.
14038         (arc_unwind_sp): Delete.
14039         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14040
14041 2019-02-27  Andrew Burgess  <[email protected]>
14042
14043         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14044         (alpha_unwind_pc): Delete.
14045         (alpha_gdbarch_init): Don't register deleted functions with
14046         gdbarch.
14047
14048 2019-02-27  Andrew Burgess  <[email protected]>
14049
14050         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14051         (aarch64_unwind_pc): Delete.
14052         (aarch64_unwind_sp): Delete.
14053         (aarch64_gdbarch_init): Don't register deleted functions with
14054         gdbarch.
14055
14056 2019-02-27  Andrew Burgess  <[email protected]>
14057
14058         * gdbtypes.c (type_align): Don't consider static members when
14059         computing structure alignment.
14060
14061 2019-02-27  Andrew Burgess  <[email protected]>
14062
14063         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14064         return 0 for other types.
14065         * arch-utils.c (default_type_align): Always return 0.
14066         * gdbarch.h: Regenerate.
14067         * gdbarch.sh (type_align): Extend comment.
14068         * gdbtypes.c (type_align): Add additional comments, always call
14069         gdbarch_type_align before applying the default rules.
14070         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14071         generic code will then apply a suitable default.
14072         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14073         types, return 0 for other types.
14074
14075 2019-02-27  Joel Brobecker  <[email protected]>
14076
14077         * NEWS: Create a new section for the next release branch.
14078         Rename the section of the current branch, now that it has
14079         been cut.
14080
14081 2019-02-27  Joel Brobecker  <[email protected]>
14082
14083         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14084         * version.in: Bump version to 8.3.50.DATE-git.
14085
14086 2019-02-26  Simon Marchi  <[email protected]>
14087
14088         * aix-thread.c (ptid_cmp): Remove unused variable.
14089         (get_signaled_thread): Likewise.
14090         (store_regs_user_thread): Likewise.
14091         (store_regs_kernel_thread): Likewise.
14092         (fetch_regs_kernel_thread): Remove shadowed variable.
14093
14094 2019-02-26  Andrew Burgess  <[email protected]>
14095
14096         * features/riscv/32bit-cpu.xml: Add register numbers.
14097         * features/riscv/32bit-fpu.c: Regenerate.
14098         * features/riscv/32bit-fpu.xml: Add register numbers.
14099         * features/riscv/64bit-cpu.xml: Add register numbers.
14100         * features/riscv/64bit-fpu.c: Regenerate.
14101         * features/riscv/64bit-fpu.xml: Add register numbers.
14102
14103 2019-02-26  Kevin Buettner  <[email protected]>
14104
14105         * NEWS: Mention two argument form of gdb.Value constructor.
14106         * python/py-value.c (convert_buffer_and_type_to_value): New
14107         function.
14108         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14109         Add support for handling an optional second argument.  Call
14110         convert_buffer_and_type_to_value as appropriate.
14111         * python/python-internal.h (Py_buffer_deleter): New struct.
14112         (Py_buffer_up): New typedef.
14113
14114 2019-02-25  John Baldwin  <[email protected]>
14115
14116         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14117         instead of releasing ownership.
14118
14119 2019-02-25  Jordan Rupprecht  <[email protected]>
14120
14121         * dwarf2read.c (open_and_init_dwp_file): Call
14122         elf_numsections instead of bfd_count_sections to initialize
14123         dwp_file->num_sections.
14124
14125 2019-02-25  Tom Tromey  <[email protected]>
14126
14127         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14128
14129 2019-02-23  Sergio Durigan Junior  <[email protected]>
14130
14131         * gcore.in: Add '--readnever' option when invoking GDB.
14132
14133 2019-02-22  Simon Marchi  <[email protected]>
14134
14135         * MAINTAINERS: Update my email address.
14136
14137 2019-02-22  Simon Marchi  <[email protected]>
14138
14139         * build-id.c (build_id_to_debug_bfd_1): New function.
14140         (build_id_to_debug_bfd): Look for separate debug file in
14141         sysroot.
14142
14143 2019-02-22  Andrew Burgess  <[email protected]>
14144
14145         * gdbarch.sh: Update the copyright year range that is placed into
14146         generated files.
14147
14148 2019-02-22  Keith Seitz  <[email protected]>
14149
14150         PR symtab/23853
14151         * linespec.c (create_sals_line_offset): Search for the default
14152         symtab's filename instead of its fullname.
14153
14154 2019-02-21  Alan Hayward  <[email protected]>
14155
14156         * NEWS: Update style defaults.
14157
14158 2019-02-21  Alan Hayward  <[email protected]>
14159
14160         * main.c (captured_main_1): Disable styling in batch mode.
14161
14162 2019-02-20  Tom Tromey  <[email protected]>
14163
14164         * symtab.c (symtab_symbol_info): Fix typos.
14165
14166 2019-02-20  Tom Tromey  <[email protected]>
14167
14168         * findcmd.c (_initialize_mem_search): Use upper case for
14169         metasyntactic variables.
14170
14171 2019-02-20  Alan Hayward  <[email protected]>
14172
14173         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14174         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14175
14176 2019-02-19  Simon Marchi  <[email protected]>
14177
14178         * top.h (source_file_name): Change to std::string.
14179         * top.c (source_file_name): Likewise.
14180         (command_line_input): Adjust.
14181         * cli/cli-script.c (script_from_file): Adjust.
14182
14183 2019-02-19  Tom Tromey  <[email protected]>
14184
14185         * ravenscar-thread.c
14186         (ravenscar_thread_target::update_thread_list): Don't call
14187         ada_build_task_list.
14188         * ada-lang.h (ada_build_task_list): Don't declare.
14189         * ada-tasks.c (struct ada_tasks_inferior_data)
14190         <task_list_valid_p>: Now bool.
14191         (read_known_tasks, ada_task_list_changed)
14192         (ada_tasks_invalidate_inferior_data): Update.
14193         (read_known_tasks_array): Return bool.
14194         (read_known_tasks_list): Likewise.
14195         (read_known_tasks): Return void.
14196         (ada_build_task_list): Now static.
14197
14198 2019-02-18  Andrew Burgess  <[email protected]>
14199
14200         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14201         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14202
14203 2019-02-18  Philippe Waroquiers  <[email protected]>
14204
14205         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14206         variant for ada_tasks_pspace_data_handle and
14207         ada_tasks_inferior_data_handle.
14208         (ada_tasks_pspace_data_cleanup): New function.
14209         (ada_tasks_inferior_data_cleanup): New function.
14210
14211 2019-02-17  Tom Tromey  <[email protected]>
14212
14213         * macrotab.h (macro_source_fullname): Return a std::string.
14214         * macrotab.c (macro_include, check_for_redefinition)
14215         (macro_undef, macro_lookup_definition, foreach_macro)
14216         (foreach_macro_in_scope): Update.
14217         (macro_source_fullname): Return a std::string.
14218         * macrocmd.c (show_pp_source_pos): Update.
14219
14220 2019-02-17  Tom Tromey  <[email protected]>
14221
14222         * macrocmd.c (show_pp_source_pos): Style the file names.
14223
14224 2019-02-17  Tom Tromey  <[email protected]>
14225
14226         PR tui/24197:
14227         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14228
14229 2019-02-17  Tom Tromey  <[email protected]>
14230
14231         * ada-lang.c (user_select_syms): Use filtered printing.
14232         * utils.c (wrap_style): New global.
14233         (desired_style): Remove.
14234         (emit_style_escape): Add stream parameter.
14235         (set_output_style, reset_terminal_style, prompt_for_continue):
14236         Update.
14237         (flush_wrap_buffer): Only flush gdb_stdout.
14238         (wrap_here): Set wrap_style.
14239         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14240         treat escape sequences as a character.  Change when wrap buffer is
14241         flushed.
14242         (fputs_styled): Do not set the output style when the default is
14243         requested.
14244         * ui-style.h (struct ui_file_style) <is_default>: New method.
14245         * source.c (print_source_lines_base): Emit escape sequences in one
14246         piece.
14247
14248 2019-02-17  Joel Brobecker  <[email protected]>
14249
14250         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14251         integers and enumeration types.
14252
14253 2019-02-17  Joel Brobecker  <[email protected]>
14254
14255         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14256         instead of lookup_symbol_in_language
14257         (do_exact_match): New function.
14258         (ada_get_symbol_name_matcher): Return do_exact_match when
14259         doing a verbatim match.
14260
14261 2019-02-15  Tom Tromey  <[email protected]>
14262
14263         * ravenscar-thread.c (ravenscar_thread_target::resume)
14264         (ravenscar_thread_target::wait): Special case wildcard requests.
14265
14266 2019-02-15  Tom Tromey  <[email protected]>
14267
14268         * ravenscar-thread.c (base_ptid): Remove.
14269         (struct ravenscar_thread_target) <close>: New method.
14270         <m_base_ptid>: New member.
14271         <update_inferior_ptid, active_task, task_is_currently_active,
14272         runtime_initialized>: Declare methods.
14273         <ravenscar_thread_target>: Add constructor.
14274         (ravenscar_thread_target::task_is_currently_active)
14275         (ravenscar_thread_target::update_inferior_ptid)
14276         (ravenscar_runtime_initialized): Rename.  Now methods.
14277         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14278         (ravenscar_thread_target::update_thread_list): Update.
14279         (ravenscar_thread_target::active_task): Now method.
14280         (ravenscar_thread_target::store_registers)
14281         (ravenscar_thread_target::prepare_to_store)
14282         (ravenscar_thread_target::prepare_to_store)
14283         (ravenscar_thread_target::mourn_inferior): Update.
14284         (ravenscar_inferior_created): Use "new" to create target.
14285         (ravenscar_thread_target::get_ada_task_ptid): Update.
14286         (_initialize_ravenscar): Don't initialize base_ptid.
14287         (ravenscar_ops): Remove global.
14288
14289 2019-02-15  Tom Tromey  <[email protected]>
14290
14291         * target.h (push_target): Declare new overload.
14292         * target.c (push_target): New overload, taking an rvalue reference.
14293         * remote.c (remote_target::open_1): Use push_target overload.
14294         * corelow.c (core_target_open): Use push_target overload.
14295
14296 2019-02-15  Tom Tromey  <[email protected]>
14297
14298         * ravenscar-thread.c (is_ravenscar_task)
14299         (ravenscar_task_is_currently_active): Return bool.
14300         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14301         (_initialize_ravenscar): Remove "(void)".
14302         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14303         Return bool.
14304
14305 2019-02-15  Tom Tromey  <[email protected]>
14306
14307         * ravenscar-thread.c (ravenscar_runtime_initializer)
14308         (has_ravenscar_runtime, get_running_thread_id)
14309         (ravenscar_thread_target::resume): Fix indentation.
14310
14311 2019-02-15  Tom Tromey  <[email protected]>
14312
14313         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14314         from ravenscar_arch_ops.
14315         (sparc_ravenscar_ops::fetch_registers)
14316         (sparc_ravenscar_ops::store_registers): Now methods.
14317         (sparc_ravenscar_prepare_to_store): Remove.
14318         (sparc_ravenscar_ops): Redefine.
14319         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14320         methods and destructor.  Remove members.
14321         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14322         (ravenscar_thread_target::store_registers)
14323         (ravenscar_thread_target::prepare_to_store): Update.
14324         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14325         Remove.
14326         (struct ppc_ravenscar_powerpc_ops): Derive from
14327         ravenscar_arch_ops.
14328         (ppc_ravenscar_powerpc_ops::fetch_registers)
14329         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14330         (ppc_ravenscar_powerpc_ops): Redefine.
14331         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14332         (ppc_ravenscar_e500_ops::fetch_registers)
14333         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14334         (ppc_ravenscar_e500_ops): Redefine.
14335         * aarch64-ravenscar-thread.c
14336         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14337         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14338         (aarch64_ravenscar_fetch_registers)
14339         (aarch64_ravenscar_store_registers): Now methods.
14340         (aarch64_ravenscar_ops): Redefine.
14341
14342 2019-02-15  Tom Tromey  <[email protected]>
14343
14344         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14345         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14346         (ravenscar_thread_target::stopped_by_watchpoint)
14347         (ravenscar_thread_target::stopped_data_address)
14348         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14349
14350 2019-02-15  Tom Tromey  <[email protected]>
14351
14352         * ravenscar-thread.c: Fix some typos.
14353
14354 2019-02-15  Philippe Waroquiers  <[email protected]>
14355             Tom Tromey  <[email protected]>
14356
14357         * ada-lang.c (ada_exception_sal): Change addr_string to a
14358         std::string.
14359         (create_ada_exception_catchpoint): Update.
14360
14361 2019-02-15  Philippe Waroquiers  <[email protected]>
14362             Tom Tromey  <[email protected]>
14363
14364         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14365         (bp_location_ops): Remove.
14366         (base_breakpoint_allocate_location): Update.
14367         (free_bp_location): Update.
14368         * ada-lang.c (class ada_catchpoint_location)
14369         <ada_catchpoint_location>: Remove ops parameter.
14370         (ada_catchpoint_location_dtor): Remove.
14371         (ada_catchpoint_location_ops): Remove.
14372         (allocate_location_exception): Update.
14373         * breakpoint.h (struct bp_location_ops): Remove.
14374         (class bp_location) <bp_location>: Remove bp_location_ops
14375         parameter.
14376         <~bp_location>: Add destructor.
14377         <ops>: Remove.
14378
14379 2019-02-14  Thomas Schwinge  <[email protected]>
14380             Pedro Alves  <[email protected]>
14381
14382         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14383         'PATH_MAX'.
14384
14385 2019-02-14  David Michael  <[email protected]>
14386             Samuel Thibault  <[email protected]>
14387             Thomas Schwinge  <[email protected]>
14388
14389         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14390         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14391
14392 2019-02-14  Thomas Schwinge  <[email protected]>
14393
14394         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14395         (check_empty): Use "const char *".
14396
14397         * gnu-nat.c (gnu_nat_target::detach): Instead of
14398         'detach_inferior (pid)' call
14399         'detach_inferior (find_inferior_pid (pid))'.
14400
14401         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14402         'nat/fork-inferior.o'.
14403         * gnu-nat.c: #include "nat/fork-inferior.h".
14404
14405         * gnu-nat.c (gnu_nat_target::detach): Instead of
14406         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14407         * gnu-nat.h: #include "inf-child.h".
14408         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14409         'i386_gnu_nat_target::fetch_registers'.
14410         (gnu_store_registers): Rename/move to
14411         'i386_gnu_nat_target::store_registers'.
14412
14413         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14414         * gnu-nat.h (mach_thread_info): New function.
14415         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14416
14417         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14418
14419 2019-02-14  Frederic Konrad  <[email protected]>
14420
14421         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14422
14423 2019-02-14  Joel Brobecker  <[email protected]>
14424
14425         * windows-nat.c (windows_add_thread): Add new parameter
14426         "main_thread_p" with default value set to false.  Update
14427         function documentation as well as all callers.
14428         (windows_delete_thread): Likewise.
14429         (fake_create_process): Update call to windows_add_thread.
14430         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14431         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14432         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14433         call to windows_delete_thread.
14434
14435 2019-02-13  Simon Marchi  <[email protected]>
14436
14437         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14438
14439 2019-02-12  John Baldwin  <[email protected]>
14440
14441         * symfile.c (find_separate_debug_file): Use canonical path of
14442         sysroot with child_path instead of gdb_sysroot if it is valid.
14443
14444 2019-02-12  John Baldwin  <[email protected]>
14445
14446         * symfile.c (find_separate_debug_file): Use child_path to
14447         determine if an object file is under a sysroot.
14448
14449 2019-02-12  John Baldwin  <[email protected]>
14450
14451         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14452         unittests/child-path-selftests.c.
14453         * common/pathstuff.c (child_path): New function.
14454         * common/pathstuff.h (child_path): New prototype.
14455         * unittests/child-path-selftests.c: New file.
14456
14457 2019-02-12  John Baldwin  <[email protected]>
14458
14459         * symfile.c (find_separate_debug_file): Look for separate debug
14460         files in debug directories under the sysroot.
14461
14462 2019-02-12  Philippe Waroquiers  <[email protected]>
14463
14464         * symtab.h (struct minimal_symbol data_p): New const method.
14465         (struct minimal_symbol text_p): Likewise.
14466         * symtab.c (output_source_filename): Use file name style
14467         to print file name.
14468         (print_symbol_info): Likewise.
14469         (print_msymbol_info): Use address style to print addresses.
14470         Use function name style to print executable text symbols.
14471         (expand_symtab_containing_pc): Use data_p.
14472         (find_pc_sect_compunit_symtab): Likewise.
14473
14474 2019-02-12  Philippe Waroquiers  <[email protected]>
14475
14476         * breakpoint.c (describe_other_breakpoints): Use address style
14477         to print addresses.
14478         (say_where): Likewise.
14479
14480 2019-02-12  Philippe Waroquiers  <[email protected]>
14481
14482         * ada-typeprint.c (print_func_type): Print function name
14483         style to print function name.
14484         * c-typeprint.c (c_print_type_1): Likewise.
14485
14486 2019-02-11  Alan Hayward  <[email protected]>
14487
14488         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14489         for execve.
14490
14491 2019-02-10  Philippe Waroquiers  <[email protected]>
14492
14493         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14494         type_stack.
14495
14496 2019-02-10  Joel Brobecker  <[email protected]>
14497
14498         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14499         TYPE_CODE_REF types.
14500
14501 2019-02-08  Jim Wilson  <[email protected]>
14502
14503         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14504         (riscv_linux_fregset): New.
14505         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14506
14507 2019-02-07  Tom Tromey  <[email protected]>
14508
14509         * thread.c (thread_cancel_execution_command): Update.
14510         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14511         methods.
14512         (struct thread_fsm_ops): Remove.
14513         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14514         (thread_fsm_should_stop, thread_fsm_return_value)
14515         (thread_fsm_set_finished, thread_fsm_finished_p)
14516         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14517         Don't declare.
14518         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14519         * infrun.c (clear_proceed_status_thread)
14520         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14521         (print_stop_event): Update.
14522         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14523         Add constructor.
14524         (step_command_fsm_ops): Remove.
14525         (new_step_command_fsm): Remove.
14526         (step_1): Update.
14527         (step_command_fsm::should_stop): Rename from
14528         step_command_fsm_should_stop.
14529         (step_command_fsm::clean_up): Rename from
14530         step_command_fsm_clean_up.
14531         (step_command_fsm::do_async_reply_reason): Rename from
14532         step_command_fsm_async_reply_reason.
14533         (struct until_next_fsm): Inherit from thread_fsm.  Add
14534         constructor.
14535         (until_next_fsm_ops): Remove.
14536         (new_until_next_fsm): Remove.
14537         (until_next_fsm::should_stop): Rename from
14538         until_next_fsm_should_stop.
14539         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14540         (until_next_fsm::do_async_reply_reason): Rename from
14541         until_next_fsm_async_reply_reason.
14542         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14543         constructor.  Change type of breakpoint.
14544         (finish_command_fsm_ops): Remove.
14545         (new_finish_command_fsm): Remove.
14546         (finish_command_fsm::should_stop): Rename from
14547         finish_command_fsm_should_stop.
14548         (finish_command_fsm::clean_up): Rename from
14549         finish_command_fsm_clean_up.
14550         (finish_command_fsm::return_value): Rename from
14551         finish_command_fsm_return_value.
14552         (finish_command_fsm::do_async_reply_reason): Rename from
14553         finish_command_fsm_async_reply_reason.
14554         (finish_command): Update.
14555         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14556         Add constructor.
14557         (call_thread_fsm_ops): Remove.
14558         (call_thread_fsm::call_thread_fsm): Rename from
14559         new_call_thread_fsm.
14560         (call_thread_fsm::should_stop): Rename from
14561         call_thread_fsm_should_stop.
14562         (call_thread_fsm::should_notify_stop): Rename from
14563         call_thread_fsm_should_notify_stop.
14564         (run_inferior_call, call_function_by_hand_dummy): Update.
14565         * cli/cli-interp.c (should_print_stop_to_console): Update.
14566         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14567         Add constructor.  Change type of location_breakpoint,
14568         caller_breakpoint.
14569         (until_break_fsm_ops): Remove.
14570         (new_until_break_fsm): Remove.
14571         (until_break_fsm::should_stop): Rename from
14572         until_break_fsm_should_stop.
14573         (until_break_fsm::clean_up): Rename from
14574         until_break_fsm_clean_up.
14575         (until_break_fsm::do_async_reply_reason): Rename from
14576         until_break_fsm_async_reply_reason.
14577         (until_break_command): Update.
14578         * thread-fsm.c: Remove.
14579         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14580
14581 2019-02-07  Tom Tromey  <[email protected]>
14582
14583         * yy-remap.h: Add include guard.
14584         * xtensa-tdep.h: Add include guard.
14585         * xcoffread.h: Rename include guard.
14586         * varobj-iter.h: Add include guard.
14587         * tui/tui.h: Rename include guard.
14588         * tui/tui-winsource.h: Rename include guard.
14589         * tui/tui-wingeneral.h: Rename include guard.
14590         * tui/tui-windata.h: Rename include guard.
14591         * tui/tui-win.h: Rename include guard.
14592         * tui/tui-stack.h: Rename include guard.
14593         * tui/tui-source.h: Rename include guard.
14594         * tui/tui-regs.h: Rename include guard.
14595         * tui/tui-out.h: Rename include guard.
14596         * tui/tui-layout.h: Rename include guard.
14597         * tui/tui-io.h: Rename include guard.
14598         * tui/tui-hooks.h: Rename include guard.
14599         * tui/tui-file.h: Rename include guard.
14600         * tui/tui-disasm.h: Rename include guard.
14601         * tui/tui-data.h: Rename include guard.
14602         * tui/tui-command.h: Rename include guard.
14603         * tic6x-tdep.h: Add include guard.
14604         * target/waitstatus.h: Rename include guard.
14605         * target/wait.h: Rename include guard.
14606         * target/target.h: Rename include guard.
14607         * target/resume.h: Rename include guard.
14608         * target-float.h: Rename include guard.
14609         * stabsread.h: Add include guard.
14610         * rs6000-tdep.h: Add include guard.
14611         * riscv-fbsd-tdep.h: Add include guard.
14612         * regformats/regdef.h: Rename include guard.
14613         * record.h: Rename include guard.
14614         * python/python.h: Rename include guard.
14615         * python/python-internal.h: Rename include guard.
14616         * python/py-stopevent.h: Rename include guard.
14617         * python/py-ref.h: Rename include guard.
14618         * python/py-record.h: Rename include guard.
14619         * python/py-record-full.h: Rename include guard.
14620         * python/py-record-btrace.h: Rename include guard.
14621         * python/py-instruction.h: Rename include guard.
14622         * python/py-events.h: Rename include guard.
14623         * python/py-event.h: Rename include guard.
14624         * procfs.h: Add include guard.
14625         * proc-utils.h: Add include guard.
14626         * p-lang.h: Add include guard.
14627         * or1k-tdep.h: Rename include guard.
14628         * observable.h: Rename include guard.
14629         * nto-tdep.h: Rename include guard.
14630         * nat/x86-linux.h: Rename include guard.
14631         * nat/x86-linux-dregs.h: Rename include guard.
14632         * nat/x86-gcc-cpuid.h: Add include guard.
14633         * nat/x86-dregs.h: Rename include guard.
14634         * nat/x86-cpuid.h: Rename include guard.
14635         * nat/ppc-linux.h: Rename include guard.
14636         * nat/mips-linux-watch.h: Rename include guard.
14637         * nat/linux-waitpid.h: Rename include guard.
14638         * nat/linux-ptrace.h: Rename include guard.
14639         * nat/linux-procfs.h: Rename include guard.
14640         * nat/linux-osdata.h: Rename include guard.
14641         * nat/linux-nat.h: Rename include guard.
14642         * nat/linux-namespaces.h: Rename include guard.
14643         * nat/linux-btrace.h: Rename include guard.
14644         * nat/glibc_thread_db.h: Rename include guard.
14645         * nat/gdb_thread_db.h: Rename include guard.
14646         * nat/gdb_ptrace.h: Rename include guard.
14647         * nat/fork-inferior.h: Rename include guard.
14648         * nat/amd64-linux-siginfo.h: Rename include guard.
14649         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14650         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14651         * nat/aarch64-linux.h: Rename include guard.
14652         * nat/aarch64-linux-hw-point.h: Rename include guard.
14653         * mn10300-tdep.h: Add include guard.
14654         * mips-linux-tdep.h: Add include guard.
14655         * mi/mi-parse.h: Rename include guard.
14656         * mi/mi-out.h: Rename include guard.
14657         * mi/mi-main.h: Rename include guard.
14658         * mi/mi-interp.h: Rename include guard.
14659         * mi/mi-getopt.h: Rename include guard.
14660         * mi/mi-console.h: Rename include guard.
14661         * mi/mi-common.h: Rename include guard.
14662         * mi/mi-cmds.h: Rename include guard.
14663         * mi/mi-cmd-break.h: Rename include guard.
14664         * m2-lang.h: Add include guard.
14665         * location.h: Rename include guard.
14666         * linux-record.h: Rename include guard.
14667         * linux-nat.h: Add include guard.
14668         * linux-fork.h: Add include guard.
14669         * i386-darwin-tdep.h: Rename include guard.
14670         * hppa-linux-offsets.h: Add include guard.
14671         * guile/guile.h: Rename include guard.
14672         * guile/guile-internal.h: Rename include guard.
14673         * gnu-nat.h: Rename include guard.
14674         * gdb-stabs.h: Rename include guard.
14675         * frv-tdep.h: Add include guard.
14676         * f-lang.h: Add include guard.
14677         * event-loop.h: Add include guard.
14678         * darwin-nat.h: Rename include guard.
14679         * cp-abi.h: Rename include guard.
14680         * config/sparc/nm-sol2.h: Rename include guard.
14681         * config/nm-nto.h: Rename include guard.
14682         * config/nm-linux.h: Add include guard.
14683         * config/i386/nm-i386gnu.h: Rename include guard.
14684         * config/djgpp/nl_types.h: Rename include guard.
14685         * config/djgpp/langinfo.h: Rename include guard.
14686         * compile/gcc-cp-plugin.h: Add include guard.
14687         * compile/gcc-c-plugin.h: Add include guard.
14688         * compile/compile.h: Rename include guard.
14689         * compile/compile-object-run.h: Rename include guard.
14690         * compile/compile-object-load.h: Rename include guard.
14691         * compile/compile-internal.h: Rename include guard.
14692         * compile/compile-cplus.h: Rename include guard.
14693         * compile/compile-c.h: Rename include guard.
14694         * common/xml-utils.h: Rename include guard.
14695         * common/x86-xstate.h: Rename include guard.
14696         * common/version.h: Rename include guard.
14697         * common/vec.h: Rename include guard.
14698         * common/tdesc.h: Rename include guard.
14699         * common/selftest.h: Rename include guard.
14700         * common/scoped_restore.h: Rename include guard.
14701         * common/scoped_mmap.h: Rename include guard.
14702         * common/scoped_fd.h: Rename include guard.
14703         * common/safe-iterator.h: Rename include guard.
14704         * common/run-time-clock.h: Rename include guard.
14705         * common/refcounted-object.h: Rename include guard.
14706         * common/queue.h: Rename include guard.
14707         * common/ptid.h: Rename include guard.
14708         * common/print-utils.h: Rename include guard.
14709         * common/preprocessor.h: Rename include guard.
14710         * common/pathstuff.h: Rename include guard.
14711         * common/observable.h: Rename include guard.
14712         * common/netstuff.h: Rename include guard.
14713         * common/job-control.h: Rename include guard.
14714         * common/host-defs.h: Rename include guard.
14715         * common/gdb_wait.h: Rename include guard.
14716         * common/gdb_vecs.h: Rename include guard.
14717         * common/gdb_unlinker.h: Rename include guard.
14718         * common/gdb_unique_ptr.h: Rename include guard.
14719         * common/gdb_tilde_expand.h: Rename include guard.
14720         * common/gdb_sys_time.h: Rename include guard.
14721         * common/gdb_string_view.h: Rename include guard.
14722         * common/gdb_splay_tree.h: Rename include guard.
14723         * common/gdb_setjmp.h: Rename include guard.
14724         * common/gdb_ref_ptr.h: Rename include guard.
14725         * common/gdb_optional.h: Rename include guard.
14726         * common/gdb_locale.h: Rename include guard.
14727         * common/gdb_assert.h: Rename include guard.
14728         * common/filtered-iterator.h: Rename include guard.
14729         * common/filestuff.h: Rename include guard.
14730         * common/fileio.h: Rename include guard.
14731         * common/environ.h: Rename include guard.
14732         * common/common-utils.h: Rename include guard.
14733         * common/common-types.h: Rename include guard.
14734         * common/common-regcache.h: Rename include guard.
14735         * common/common-inferior.h: Rename include guard.
14736         * common/common-gdbthread.h: Rename include guard.
14737         * common/common-exceptions.h: Rename include guard.
14738         * common/common-defs.h: Rename include guard.
14739         * common/common-debug.h: Rename include guard.
14740         * common/cleanups.h: Rename include guard.
14741         * common/buffer.h: Rename include guard.
14742         * common/btrace-common.h: Rename include guard.
14743         * common/break-common.h: Rename include guard.
14744         * cli/cli-utils.h: Rename include guard.
14745         * cli/cli-style.h: Rename include guard.
14746         * cli/cli-setshow.h: Rename include guard.
14747         * cli/cli-script.h: Rename include guard.
14748         * cli/cli-interp.h: Rename include guard.
14749         * cli/cli-decode.h: Rename include guard.
14750         * cli/cli-cmds.h: Rename include guard.
14751         * charset-list.h: Add include guard.
14752         * buildsym-legacy.h: Rename include guard.
14753         * bfin-tdep.h: Add include guard.
14754         * ax.h: Rename include guard.
14755         * arm-linux-tdep.h: Add include guard.
14756         * arm-fbsd-tdep.h: Add include guard.
14757         * arch/xtensa.h: Rename include guard.
14758         * arch/tic6x.h: Add include guard.
14759         * arch/i386.h: Add include guard.
14760         * arch/arm.h: Rename include guard.
14761         * arch/arm-linux.h: Rename include guard.
14762         * arch/arm-get-next-pcs.h: Rename include guard.
14763         * arch/amd64.h: Add include guard.
14764         * arch/aarch64-insn.h: Rename include guard.
14765         * arch-utils.h: Rename include guard.
14766         * annotate.h: Add include guard.
14767         * amd64-darwin-tdep.h: Rename include guard.
14768         * aarch64-linux-tdep.h: Add include guard.
14769         * aarch64-fbsd-tdep.h: Add include guard.
14770         * aarch32-linux-nat.h: Add include guard.
14771
14772 2019-02-06  Philippe Waroquiers  <[email protected]>
14773
14774         * macrotab.c (macro_define_internal): New function that
14775         factorizes macro_define_object_internal and macro_define_function
14776         code.
14777         (macro_define_object_internal): Use macro_define_internal.
14778         (macro_define_function): Likewise.
14779
14780 2019-02-06  Philippe Waroquiers  <[email protected]>
14781
14782         * macrocmd.c (extract_identifier): Return
14783         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14784         callers.
14785
14786 2019-02-06  John Baldwin  <[email protected]>
14787
14788         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14789
14790 2019-02-05  Tom Tromey  <[email protected]>
14791
14792         * target.c (target_stack::unpush): Move assertion earlier.
14793
14794 2019-01-30  Tom Tromey  <[email protected]>
14795
14796         PR python/23615:
14797         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14798         (gdbpy_parse_and_eval): Likewise.
14799         * python/python-internal.h (gdbpy_allow_threads): New class.
14800
14801 2019-01-28  John Baldwin  <[email protected]>
14802
14803         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14804         (aarch64_fbsd_fpregmap): Move earlier.
14805         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14806         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14807         instead of individual calls to trad_frame_set_reg_addr.
14808         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14809         earlier.
14810         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14811         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14812         instead of individual calls to trad_frame_set_reg_addr.
14813
14814 2019-01-28  Alan Hayward  <[email protected]>
14815
14816         * CONTRIBUTE: Replace contribution list with wiki link.
14817
14818 2019-01-25  Tom Tromey  <[email protected]>
14819
14820         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14821
14822 2019-01-25  Tom Tromey  <[email protected]>
14823
14824         * xtensa-linux-nat.c: Fix common/ includes.
14825         * xml-support.h: Fix common/ includes.
14826         * xml-support.c: Fix common/ includes.
14827         * x86-linux-nat.c: Fix common/ includes.
14828         * windows-nat.c: Fix common/ includes.
14829         * varobj.h: Fix common/ includes.
14830         * varobj.c: Fix common/ includes.
14831         * value.c: Fix common/ includes.
14832         * valops.c: Fix common/ includes.
14833         * utils.c: Fix common/ includes.
14834         * unittests/xml-utils-selftests.c: Fix common/ includes.
14835         * unittests/utils-selftests.c: Fix common/ includes.
14836         * unittests/unpack-selftests.c: Fix common/ includes.
14837         * unittests/tracepoint-selftests.c: Fix common/ includes.
14838         * unittests/style-selftests.c: Fix common/ includes.
14839         * unittests/string_view-selftests.c: Fix common/ includes.
14840         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14841         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14842         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14843         * unittests/rsp-low-selftests.c: Fix common/ includes.
14844         * unittests/parse-connection-spec-selftests.c: Fix common/
14845         includes.
14846         * unittests/optional-selftests.c: Fix common/ includes.
14847         * unittests/offset-type-selftests.c: Fix common/ includes.
14848         * unittests/observable-selftests.c: Fix common/ includes.
14849         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14850         * unittests/memrange-selftests.c: Fix common/ includes.
14851         * unittests/memory-map-selftests.c: Fix common/ includes.
14852         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14853         * unittests/function-view-selftests.c: Fix common/ includes.
14854         * unittests/environ-selftests.c: Fix common/ includes.
14855         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14856         * unittests/common-utils-selftests.c: Fix common/ includes.
14857         * unittests/cli-utils-selftests.c: Fix common/ includes.
14858         * unittests/array-view-selftests.c: Fix common/ includes.
14859         * ui-file.c: Fix common/ includes.
14860         * tui/tui-io.c: Fix common/ includes.
14861         * tracepoint.h: Fix common/ includes.
14862         * tracepoint.c: Fix common/ includes.
14863         * tracefile-tfile.c: Fix common/ includes.
14864         * top.h: Fix common/ includes.
14865         * top.c: Fix common/ includes.
14866         * thread.c: Fix common/ includes.
14867         * target/waitstatus.h: Fix common/ includes.
14868         * target/waitstatus.c: Fix common/ includes.
14869         * target.h: Fix common/ includes.
14870         * target.c: Fix common/ includes.
14871         * target-memory.c: Fix common/ includes.
14872         * target-descriptions.c: Fix common/ includes.
14873         * symtab.h: Fix common/ includes.
14874         * symfile.c: Fix common/ includes.
14875         * stap-probe.c: Fix common/ includes.
14876         * spu-linux-nat.c: Fix common/ includes.
14877         * sparc-nat.c: Fix common/ includes.
14878         * source.c: Fix common/ includes.
14879         * solib.c: Fix common/ includes.
14880         * solib-target.c: Fix common/ includes.
14881         * ser-unix.c: Fix common/ includes.
14882         * ser-tcp.c: Fix common/ includes.
14883         * ser-pipe.c: Fix common/ includes.
14884         * ser-base.c: Fix common/ includes.
14885         * selftest-arch.c: Fix common/ includes.
14886         * s12z-tdep.c: Fix common/ includes.
14887         * rust-exp.y: Fix common/ includes.
14888         * rs6000-aix-tdep.c: Fix common/ includes.
14889         * riscv-tdep.c: Fix common/ includes.
14890         * remote.c: Fix common/ includes.
14891         * remote-notif.h: Fix common/ includes.
14892         * remote-fileio.h: Fix common/ includes.
14893         * remote-fileio.c: Fix common/ includes.
14894         * regcache.h: Fix common/ includes.
14895         * regcache.c: Fix common/ includes.
14896         * record-btrace.c: Fix common/ includes.
14897         * python/python.c: Fix common/ includes.
14898         * python/py-type.c: Fix common/ includes.
14899         * python/py-inferior.c: Fix common/ includes.
14900         * progspace.h: Fix common/ includes.
14901         * producer.c: Fix common/ includes.
14902         * procfs.c: Fix common/ includes.
14903         * proc-api.c: Fix common/ includes.
14904         * printcmd.c: Fix common/ includes.
14905         * ppc-linux-nat.c: Fix common/ includes.
14906         * parser-defs.h: Fix common/ includes.
14907         * osdata.c: Fix common/ includes.
14908         * obsd-nat.c: Fix common/ includes.
14909         * nat/x86-linux.c: Fix common/ includes.
14910         * nat/x86-linux-dregs.c: Fix common/ includes.
14911         * nat/x86-dregs.h: Fix common/ includes.
14912         * nat/x86-dregs.c: Fix common/ includes.
14913         * nat/ppc-linux.c: Fix common/ includes.
14914         * nat/mips-linux-watch.h: Fix common/ includes.
14915         * nat/mips-linux-watch.c: Fix common/ includes.
14916         * nat/linux-waitpid.c: Fix common/ includes.
14917         * nat/linux-ptrace.h: Fix common/ includes.
14918         * nat/linux-ptrace.c: Fix common/ includes.
14919         * nat/linux-procfs.c: Fix common/ includes.
14920         * nat/linux-personality.c: Fix common/ includes.
14921         * nat/linux-osdata.c: Fix common/ includes.
14922         * nat/linux-namespaces.c: Fix common/ includes.
14923         * nat/linux-btrace.h: Fix common/ includes.
14924         * nat/linux-btrace.c: Fix common/ includes.
14925         * nat/fork-inferior.c: Fix common/ includes.
14926         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14927         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14928         * nat/aarch64-linux.c: Fix common/ includes.
14929         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14930         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14931         * namespace.h: Fix common/ includes.
14932         * mips-linux-tdep.c: Fix common/ includes.
14933         * minsyms.c: Fix common/ includes.
14934         * mi/mi-parse.h: Fix common/ includes.
14935         * mi/mi-main.c: Fix common/ includes.
14936         * mi/mi-cmd-env.c: Fix common/ includes.
14937         * memrange.h: Fix common/ includes.
14938         * memattr.c: Fix common/ includes.
14939         * maint.h: Fix common/ includes.
14940         * maint.c: Fix common/ includes.
14941         * main.c: Fix common/ includes.
14942         * machoread.c: Fix common/ includes.
14943         * location.c: Fix common/ includes.
14944         * linux-thread-db.c: Fix common/ includes.
14945         * linux-nat.c: Fix common/ includes.
14946         * linux-fork.c: Fix common/ includes.
14947         * inline-frame.c: Fix common/ includes.
14948         * infrun.c: Fix common/ includes.
14949         * inflow.c: Fix common/ includes.
14950         * inferior.h: Fix common/ includes.
14951         * inferior.c: Fix common/ includes.
14952         * infcmd.c: Fix common/ includes.
14953         * inf-ptrace.c: Fix common/ includes.
14954         * inf-child.c: Fix common/ includes.
14955         * ia64-linux-nat.c: Fix common/ includes.
14956         * i387-tdep.c: Fix common/ includes.
14957         * i386-tdep.c: Fix common/ includes.
14958         * i386-linux-tdep.c: Fix common/ includes.
14959         * i386-linux-nat.c: Fix common/ includes.
14960         * i386-go32-tdep.c: Fix common/ includes.
14961         * i386-fbsd-tdep.c: Fix common/ includes.
14962         * i386-fbsd-nat.c: Fix common/ includes.
14963         * guile/scm-type.c: Fix common/ includes.
14964         * guile/guile.c: Fix common/ includes.
14965         * go32-nat.c: Fix common/ includes.
14966         * gnu-nat.c: Fix common/ includes.
14967         * gdbthread.h: Fix common/ includes.
14968         * gdbarch-selftests.c: Fix common/ includes.
14969         * gdb_usleep.c: Fix common/ includes.
14970         * gdb_select.h: Fix common/ includes.
14971         * gdb_bfd.c: Fix common/ includes.
14972         * gcore.c: Fix common/ includes.
14973         * fork-child.c: Fix common/ includes.
14974         * findvar.c: Fix common/ includes.
14975         * fbsd-nat.c: Fix common/ includes.
14976         * event-top.c: Fix common/ includes.
14977         * event-loop.c: Fix common/ includes.
14978         * dwarf2read.c: Fix common/ includes.
14979         * dwarf2loc.c: Fix common/ includes.
14980         * dwarf2-frame.c: Fix common/ includes.
14981         * dwarf-index-cache.c: Fix common/ includes.
14982         * dtrace-probe.c: Fix common/ includes.
14983         * disasm-selftests.c: Fix common/ includes.
14984         * defs.h: Fix common/ includes.
14985         * csky-tdep.c: Fix common/ includes.
14986         * cp-valprint.c: Fix common/ includes.
14987         * cp-support.h: Fix common/ includes.
14988         * cp-support.c: Fix common/ includes.
14989         * corelow.c: Fix common/ includes.
14990         * completer.h: Fix common/ includes.
14991         * completer.c: Fix common/ includes.
14992         * compile/compile.c: Fix common/ includes.
14993         * compile/compile-loc2c.c: Fix common/ includes.
14994         * compile/compile-cplus-types.c: Fix common/ includes.
14995         * compile/compile-cplus-symbols.c: Fix common/ includes.
14996         * command.h: Fix common/ includes.
14997         * cli/cli-dump.c: Fix common/ includes.
14998         * cli/cli-cmds.c: Fix common/ includes.
14999         * charset.c: Fix common/ includes.
15000         * build-id.c: Fix common/ includes.
15001         * btrace.h: Fix common/ includes.
15002         * btrace.c: Fix common/ includes.
15003         * breakpoint.h: Fix common/ includes.
15004         * breakpoint.c: Fix common/ includes.
15005         * ax.h: 
15006         (enum agent_op): Fix common/ includes.
15007         * ax-general.c (struct aop_map): Fix common/ includes.
15008         * ax-gdb.c: Fix common/ includes.
15009         * auxv.c: Fix common/ includes.
15010         * auto-load.c: Fix common/ includes.
15011         * arm-tdep.c: Fix common/ includes.
15012         * arch/riscv.c: Fix common/ includes.
15013         * arch/ppc-linux-common.c: Fix common/ includes.
15014         * arch/i386.c: Fix common/ includes.
15015         * arch/arm.c: Fix common/ includes.
15016         * arch/arm-linux.c: Fix common/ includes.
15017         * arch/arm-get-next-pcs.c: Fix common/ includes.
15018         * arch/amd64.c: Fix common/ includes.
15019         * arch/aarch64.c: Fix common/ includes.
15020         * arch/aarch64-insn.c: Fix common/ includes.
15021         * arch-utils.c: Fix common/ includes.
15022         * amd64-windows-tdep.c: Fix common/ includes.
15023         * amd64-tdep.c: Fix common/ includes.
15024         * amd64-sol2-tdep.c: Fix common/ includes.
15025         * amd64-obsd-tdep.c: Fix common/ includes.
15026         * amd64-nbsd-tdep.c: Fix common/ includes.
15027         * amd64-linux-tdep.c: Fix common/ includes.
15028         * amd64-linux-nat.c: Fix common/ includes.
15029         * amd64-fbsd-tdep.c: Fix common/ includes.
15030         * amd64-fbsd-nat.c: Fix common/ includes.
15031         * amd64-dicos-tdep.c: Fix common/ includes.
15032         * amd64-darwin-tdep.c: Fix common/ includes.
15033         * agent.c: Fix common/ includes.
15034         * ada-lang.h: Fix common/ includes.
15035         * ada-lang.c: Fix common/ includes.
15036         * aarch64-tdep.c: Fix common/ includes.
15037
15038 2019-01-25  Tom Tromey  <[email protected]>
15039
15040         * common/create-version.sh: Use common/version.h.
15041
15042 2019-01-24  Pedro Alves  <[email protected]>
15043
15044         * infrun.c (signal_stop, signal_print, signal_program)
15045         (signal_catch, signal_pass): Now arrays instead of pointers.
15046         (update_signals_program_target, do_target_resume)
15047         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15048         * linux-nat.c (linux_nat_target::pass_signals)
15049         (linux_nat_target::create_inferior, linux_nat_target::attach):
15050         Adjust.
15051         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15052         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15053         * procfs.c (procfs_target::pass_signals): Adjust.
15054         * record-full.c (record_full_target::resume): Adjust.
15055         * remote.c (remote_target::pass_signals)
15056         (remote_target::program_signals): Adjust.
15057         * target-debug.h (target_debug_print_signals): Now takes a
15058         gdb::array_view as parameter.  Adjust.
15059         * target.h (target_ops) <pass_signals, program_signals>: Replace
15060         pointer and length parameters with gdb::array_view.
15061         (target_pass_signals, target_program_signals): Likewise.
15062         * target-delegates.c: Regenerate.
15063
15064 2019-01-24  Pedro Alves  <[email protected]>
15065
15066         * common/forward-scope-exit.h
15067         (forward_scope_exit::forward_scope_exit): Pass arguments to
15068         m_bind_function directly, instead of creating a std::bind and
15069         copying that.
15070
15071 2019-01-24  Alan Hayward  <[email protected]>
15072
15073         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15074         for static members.
15075         (pass_in_v_vfp_candidate): Likewise.
15076
15077 2019-01-23  Tom Tromey  <[email protected]>
15078             Pedro Alves  <[email protected]>
15079
15080         * regcache.c (class regcache_invalidator): Remove.
15081         (regcache::raw_write): Use make_scope_exit.
15082
15083 2019-01-23  Tom Tromey  <[email protected]>
15084
15085         * ui-out.h (class ui_out_emit_type): Update comment.
15086
15087 2019-01-23  Tom Tromey  <[email protected]>
15088
15089         * infrun.c (fetch_inferior_event): Update comment.
15090
15091 2019-01-23  Tom Tromey  <[email protected]>
15092             Pedro Alves  <[email protected]>
15093
15094         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15095         parameter.
15096         (fetch_inferior_event): Use SCOPE_EXIT.
15097
15098
15099 2019-01-23  Tom Tromey  <[email protected]>
15100             Pedro Alves  <[email protected]>
15101
15102         * infrun.c (disable_thread_events): Delete.
15103         (stop_all_threads): Use SCOPE_EXIT.
15104
15105 2019-01-23  Tom Tromey  <[email protected]>
15106             Pedro Alves  <[email protected]>
15107
15108         * symfile.c: Include forward-scope-exit.h.
15109         (clear_symtab_users_cleanup): Replace forward declaration with
15110         a FORWARD_SCOPE_EXIT.
15111         (syms_from_objfile_1): Use the forward_scope_exit and
15112         gdb::optional instead of cleanup_function.
15113         (reread_symbols): Use the forward_scope_exit instead of
15114         cleanup_function.
15115         (clear_symtab_users_cleanup): Remove function.
15116
15117 2019-01-23  Tom Tromey  <[email protected]>
15118             Pedro Alves  <[email protected]>
15119
15120         * linux-nat.c: Include scope-exit.h.
15121         (cleanup_target_stop): Remove.
15122         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15123         SCOPE_EXIT.
15124
15125 2019-01-23  Tom Tromey  <[email protected]>
15126             Pedro Alves  <[email protected]>
15127
15128         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15129         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15130
15131 2019-01-23  Tom Tromey  <[email protected]>
15132             Andrew Burgess  <[email protected]>
15133             Pedro Alves  <[email protected]>
15134
15135         * infrun.c (fetch_inferior_event): Use scope_exit.
15136         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15137         * top.c (execute_command): Use scope_exit.
15138         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15139         * utils.c (do_bpstat_clear_actions_cleanup)
15140         (make_bpstat_clear_actions_cleanup): Remove.
15141
15142 2019-01-23  Tom Tromey  <[email protected]>
15143             Pedro Alves  <[email protected]>
15144
15145         * infrun.c: Include "common/scope-exit.h"
15146         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15147         (wait_for_inferior): Use SCOPE_EXIT.
15148         (fetch_inferior_event): Use scope_exit.
15149
15150 2019-01-23  Tom Tromey  <[email protected]>
15151             Pedro Alves  <[email protected]>
15152
15153         * breakpoint.c (create_breakpoint): Remove cleanup.
15154
15155 2019-01-23  Tom Tromey  <[email protected]>
15156             Andrew Burgess  <[email protected]>
15157             Pedro Alves  <[email protected]>
15158
15159 2019-01-23  Pedro Alves  <[email protected]>
15160
15161         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15162
15163 2019-01-23  Pedro Alves  <[email protected]>
15164             Andrew Burgess  <[email protected]>
15165
15166         * gdbthread.h: Include "common/forward-scope-exit.h".
15167         (scoped_finish_thread_state): Redefine custom class in terms of
15168         forward_scope_exit.
15169
15170 2019-01-23  Pedro Alves  <[email protected]>
15171             Andrew Burgess  <[email protected]>
15172
15173         * common/forward-scope-exit.h: New file.
15174
15175 2019-01-23  Pedro Alves  <[email protected]>
15176             Andrew Burgess  <[email protected]>
15177             Tom Tromey  <[email protected]>
15178
15179         * common/scope-exit.h: New file.
15180
15181 2019-01-23  Pedro Alves  <[email protected]>
15182
15183         * common/preprocessor.h (ESC): Rename to ...
15184         (ESC_PARENS): ... this.
15185         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15186         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15187
15188 2019-01-23  Tom Tromey  <[email protected]>
15189
15190         * language.h (class scoped_switch_to_sym_language_if_auto):
15191         Initialize m_lang in both cases.
15192
15193 2019-01-23  Alan Hayward  <[email protected]>
15194
15195         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15196         with XCNEW.
15197
15198 2019-01-22  Tom Tromey  <[email protected]>
15199
15200         * corelow.c: Do not include sys/file.h.
15201
15202 2019-01-22  Tom Tromey  <[email protected]>
15203
15204         * tui/tui-wingeneral.h: Include gdb_curses.h.
15205
15206 2019-01-22  Tom Tromey  <[email protected]>
15207
15208         * source-cache.h (class source_cache) <get_source_lines,
15209         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15210
15211 2019-01-22  Tom Tromey  <[email protected]>
15212
15213         * remote-fileio.h (struct remote_target): Declare.
15214
15215 2019-01-22  Tom Tromey  <[email protected]>
15216
15217         * python/py-arch.c: Do not include py-ref.h.
15218         * python/py-bpevent.c: Do not include py-ref.h.
15219         * python/py-cmd.c: Do not include py-ref.h.
15220         * python/py-continueevent.c: Do not include py-ref.h.
15221         * python/py-event.h: Do not include py-ref.h.
15222         * python/py-evtregistry.c: Do not include py-ref.h.
15223         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15224         * python/py-frame.c: Do not include py-ref.h.
15225         * python/py-framefilter.c: Do not include py-ref.h.
15226         * python/py-function.c: Do not include py-ref.h.
15227         * python/py-infevents.c: Do not include py-ref.h.
15228         * python/py-linetable.c: Do not include py-ref.h.
15229         * python/py-objfile.c: Do not include py-ref.h.
15230         * python/py-param.c: Do not include py-ref.h.
15231         * python/py-prettyprint.c: Do not include py-ref.h.
15232         * python/py-progspace.c: Do not include py-ref.h.
15233         * python/py-symbol.c: Do not include py-ref.h.
15234         * python/py-symtab.c: Do not include py-ref.h.
15235         * python/py-type.c: Do not include py-ref.h.
15236         * python/py-unwind.c: Do not include py-ref.h.
15237         * python/py-utils.c: Do not include py-ref.h.
15238         * python/py-value.c: Do not include py-ref.h.
15239         * python/py-varobj.c: Do not include py-ref.h.
15240         * python/py-xmethods.c: Do not include py-ref.h.
15241         * python/python.c: Do not include py-ref.h.
15242         * varobj.c: Do not include py-ref.h.
15243
15244 2019-01-22  Tom Tromey  <[email protected]>
15245
15246         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15247         keyword for bcache.
15248
15249 2019-01-22  Tom Tromey  <[email protected]>
15250
15251         * compile/compile-cplus-types.c: Remove a comment by #include.
15252
15253 2019-01-22  Tom Tromey  <[email protected]>
15254
15255         * compile/gcc-c-plugin.h: Include compile-internal.h.
15256
15257 2019-01-22  Tom Tromey  <[email protected]>
15258
15259         * stabsread.c (EXTERN): Do not define.
15260         (symnum, next_symbol_text_func, processing_gcc_compilation)
15261         (within_function, global_sym_chain, global_stabs)
15262         (previous_stab_code, this_object_header_files)
15263         (n_this_object_header_files)
15264         (n_allocated_this_object_header_files): Define.
15265         * stabsread.h (EXTERN): Never define.  Use "extern".
15266
15267 2019-01-22  Philippe Waroquiers  <[email protected]>
15268
15269         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15270         history_value.
15271
15272 2019-01-21  Tom Tromey  <[email protected]>
15273
15274         * ui-out.c: Fix includes.
15275         * tui/tui-source.c: Fix includes.
15276         * target.c: Fix includes.
15277         * remote.c: Fix includes.
15278         * regcache.c: Fix includes.
15279         * python/py-block.c: Fix includes.
15280         * printcmd.c: Fix includes.
15281         * or1k-tdep.c: Fix includes.
15282         * mi/mi-main.c: Fix includes.
15283         * m32r-tdep.c: Fix includes.
15284         * csky-tdep.c: Fix includes.
15285         * compile/compile-cplus-types.c: Fix includes.
15286         * cli/cli-interp.c: Fix includes.
15287
15288 2019-01-21  Alan Hayward  <[email protected]>
15289
15290         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15291         for padding.
15292
15293 2019-01-16  Tom Tromey  <[email protected]>
15294
15295         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15296         earlier.
15297         (struct objfile) <msymbols_range>: Move from top level.
15298         <msymbols>: New method.
15299         (class objfile_msymbols): Remove.
15300         * symtab.c (default_collect_symbol_completion_matches_break_on):
15301         Update.
15302         * symmisc.c (dump_msymbols): Update.
15303         * stabsread.c (scan_file_globals): Update.
15304         * objc-lang.c (info_selectors_command, info_classes_command)
15305         (find_methods): Update.
15306         * minsyms.c (find_solib_trampoline_target): Update.
15307         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15308         * coffread.c (coff_symfile_read): Update.
15309         * ada-lang.c (ada_lookup_simple_minsym)
15310         (ada_collect_symbol_completion_matches): Update.
15311
15312 2019-01-16  Tom Tromey  <[email protected]>
15313
15314         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15315         type.  Remove no-argument constructor.
15316         <iterator::operator++>: Simplify.
15317         <begin>: Update.
15318         <end>: Use minimal_symbol_count.
15319
15320 2019-01-16  Tom Tromey  <[email protected]>
15321
15322         * objfiles.h (struct objfile) <psymtabs>: New method.
15323         (class objfile_psymtabs): Remove.
15324         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15325         typedef.
15326         <range>: New method.
15327         (require_partial_symbols): Change return type.
15328         * psymtab.c (require_partial_symbols)
15329         (psym_expand_symtabs_matching): Update.
15330         * mdebugread.c (parse_partial_symbols): Update.
15331         * dbxread.c (dbx_end_psymtab): Update.
15332
15333 2019-01-15  Tom Tromey  <[email protected]>
15334
15335         * symtab.c (lookup_objfile_from_block)
15336         (lookup_symbol_in_objfile_symtabs)
15337         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15338         (find_line_symtab, info_sources_command)
15339         (default_collect_symbol_completion_matches_break_on)
15340         (make_source_files_completion_list): Update.
15341         * symmisc.c (print_objfile_statistics, dump_objfile)
15342         (maintenance_print_symbols, maintenance_info_symtabs)
15343         (maintenance_check_symtabs, maintenance_info_line_tables):
15344         Update.
15345         * source.c (select_source_symtab)
15346         (forget_cached_source_info_for_objfile): Update.
15347         * objfiles.h (class objfile_compunits): Remove.
15348         (struct objfile) <compunits_range>: New typedef.
15349         (compunits): New method.
15350         * objfiles.c (objfile_relocate1): Update.
15351         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15352         * maint.c (count_symtabs_and_blocks): Update.
15353         * linespec.c (iterate_over_all_matching_symtabs): Update.
15354         * cp-support.c (add_symbol_overload_list_qualified): Update.
15355         * coffread.c (coff_symtab_read): Update.
15356         * ada-lang.c (add_nonlocal_symbols)
15357         (ada_collect_symbol_completion_matches)
15358         (ada_add_global_exceptions): Update.
15359
15360 2019-01-15  Tom Tromey  <[email protected]>
15361
15362         * progspace.h (program_space) <objfiles_safe_range>: New
15363         typedef.
15364         <objfiles_safe>: New method.
15365         * objfiles.h (class all_objfiles_safe): Remove.
15366         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15367         * jit.c (jit_inferior_exit_hook): Update.
15368
15369 2019-01-17  Tom Tromey  <[email protected]>
15370
15371         * progspace.h (program_space) <objfiles_range>: New typedef.
15372         <objfiles>: New method.
15373         <objfiles_head>: Rename from objfiles.
15374         (object_files): Update.
15375         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15376         * guile/scm-pretty-print.c
15377         (ppscm_find_pretty_printer_from_objfiles): Update.
15378         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15379         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15380         Update.
15381         * python/py-progspace.c (pspy_get_objfiles): Update.
15382         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15383         Update.
15384         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15385         (objfpy_lookup_objfile_by_build_id): Update.
15386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15387         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15388         Update.
15389         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15390         (expand_symtab_containing_pc, lookup_objfile_from_block)
15391         (lookup_static_symbol, basic_lookup_transparent_type)
15392         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15393         (find_line_symtab, info_sources_command)
15394         (default_collect_symbol_completion_matches_break_on)
15395         (make_source_files_completion_list, find_main_name): Update.
15396         * symmisc.c (print_symbol_bcache_statistics)
15397         (print_objfile_statistics, maintenance_print_symbols)
15398         (maintenance_print_msymbols, maintenance_print_objfiles)
15399         (maintenance_info_symtabs, maintenance_check_symtabs)
15400         (maintenance_expand_symtabs, maintenance_info_line_tables):
15401         Update.
15402         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15403         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15404         (map_overlay_command, unmap_overlay_command)
15405         (simple_overlay_update, expand_symtabs_matching)
15406         (map_symbol_filenames): Update.
15407         * symfile-debug.c (set_debug_symfile): Update.
15408         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15409         Update.
15410         * source.c (select_source_symtab, forget_cached_source_info):
15411         Update.
15412         * solib.c (solib_read_symbols): Update.
15413         * solib-spu.c (append_ocl_sos): Update.
15414         * psymtab.c (maintenance_print_psymbols)
15415         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15416         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15417         * printcmd.c (info_symbol_command): Update.
15418         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15419         Update.
15420         * objfiles.h (class all_objfiles): Remove.
15421         * objfiles.c (have_partial_symbols, have_full_symbols)
15422         (have_minimal_symbols, qsort_cmp, update_section_map)
15423         (shared_objfile_contains_address_p)
15424         (default_iterate_over_objfiles_in_search_order): Update.
15425         * objc-lang.c (info_selectors_command, info_classes_command)
15426         (find_methods): Update.
15427         * minsyms.c (find_solib_trampoline_target): Update.
15428         * maint.c (maintenance_info_sections)
15429         (maintenance_translate_address, count_symtabs_and_blocks):
15430         Update.
15431         * main.c (captured_main_1): Update.
15432         * linux-thread-db.c (try_thread_db_load_from_pdir)
15433         (has_libpthread): Update.
15434         * linespec.c (iterate_over_all_matching_symtabs)
15435         (search_minsyms_for_name): Update.
15436         * jit.c (jit_find_objf_with_entry_addr): Update.
15437         * hppa-tdep.c (find_unwind_entry)
15438         (hppa_lookup_stub_minimal_symbol): Update.
15439         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15440         Update.
15441         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15442         (elf_gnu_ifunc_resolve_by_got): Update.
15443         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15444         * dwarf-index-write.c (save_gdb_index_command): Update.
15445         * cp-support.c (add_symbol_overload_list_qualified): Update.
15446         * breakpoint.c (create_overlay_event_breakpoint)
15447         (create_longjmp_master_breakpoint)
15448         (create_std_terminate_master_breakpoint)
15449         (create_exception_master_breakpoint): Update.
15450         * blockframe.c (find_pc_partial_function): Update.
15451         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15452         (ada_collect_symbol_completion_matches)
15453         (ada_add_global_exceptions): Update.
15454
15455 2019-01-17  Tom Tromey  <[email protected]>
15456
15457         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15458         declare VEC.
15459         (solib_target_parse_libraries): Change return type.
15460         (library_list_start_segment, library_list_start_section)
15461         (library_list_end_library, library_list_start_library); Update.
15462         (solib_target_free_library_list): Remove.
15463         (solib_target_parse_libraries): Remove cleanup.  Change return
15464         type.
15465         (solib_target_current_sos): Update.
15466
15467 2019-01-17  Tom Tromey  <tromey@bapiya>
15468
15469         * valprint.c: Replace "the the" with "the".
15470         * symtab.c: Replace "the the" with "the".
15471         * solib.c: Replace "the the" with "the".
15472         * solib-dsbt.c: Replace "the the" with "the".
15473         * linespec.c: Replace "the the" with "the".
15474         * dwarf2loc.h: Replace "the the" with "the".
15475         * amd64-windows-tdep.c: Replace "the the" with "the".
15476         * aarch64-tdep.c: Replace "the the" with "the".
15477
15478 2019-01-16  Keith Seitz  <[email protected]>
15479
15480         PR gdb/23773
15481         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15482         <builder>: Rename to ..
15483         <m_builder>: ... this and make private.
15484         (dwarf2_cu::get_builder): New method.  Change all users of
15485         `builder' to use this method.
15486         (dwarf2_start_symtab): Move to ...
15487         (dwarf2_cu::start_symtab): ... here.  Update all callers
15488         (setup_type_unit_groups): Move to ...
15489         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15490         callers.
15491         (dwarf2_cu::reset_builder): New method.
15492         (process_full_compunit, process_full_type_unit): Use
15493         dwarf2_cu::reset_builder.
15494         (follow_die_offset): Record the ancestor CU if it is different
15495         from the followed DIE's CU.
15496         (follow_die_sig_1): Likewise.
15497
15498 2019-01-15  Tom Tromey  <[email protected]>
15499
15500         * remote.c (class remote_state) <buf>: Now a char_vector.
15501         <buf_size>: Remove.
15502         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15503         parameter.
15504         (remote_target::getpkt_or_notif_sane_1)
15505         (remote_target::getpkt_sane)
15506         (remote_target::getpkt_or_notif_sane): Likewise.
15507         (class remote_target) <putpkt>: New overload.
15508         (remote_target::read_frame): Change type of "buf_p".  Remove
15509         sizeof_p parameter.
15510         (packet_ok): New overload.
15511         (packet_check_result): New overload.
15512         Update all uses.
15513
15514 2019-01-14  Tom Tromey  <[email protected]>
15515
15516         * remote-notif.c (handle_notification, remote_notif_ack)
15517         (remote_notif_parse): Make "buf" const.
15518         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15519         const.
15520         (remote_notif_parse, remote_notif_ack, handle_notification):
15521         Likewise.
15522         * remote.c (remote_notif_stop_parse): Make "buf" const.
15523         (remote_target::remote_parse_stop_reply): Make "buf" const.
15524         (remote_notif_stop_ack): Make "buf" const.
15525
15526 2019-01-14  Tom Tromey  <[email protected]>
15527
15528         * remote.c (remote_console_output): Make parameter const.
15529
15530 2019-01-14  Tom Tromey  <[email protected]>
15531
15532         * target-debug.h (target_debug_print_signals): Constify.
15533         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15534         * procfs.c (procfs_target::pass_signals): Update.
15535         * linux-nat.c (linux_nat_target::pass_signals): Update.
15536         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15537         * target-delegates.c: Rebuild.
15538         * remote.c (remote_target::program_signals): Update.
15539         (remote_target::pass_signals): Update.
15540         * target.c (target_pass_signals): Constify argument.
15541         (target_program_signals): Likewise.
15542         * target.h (struct target_ops) <pass_signals, program_signals>:
15543         Constify argument.
15544         (target_pass_signals, target_program_signals): Constify argument.
15545
15546 2019-01-14  Tom Tromey  <[email protected]>
15547
15548         PR tui/28819:
15549         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15550
15551 2019-01-14  Pedro Franco de Carvalho  <[email protected]>
15552
15553         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15554         field.
15555         * rs6000-tdep.c: Include reggroups.h.
15556         (IS_V_ALIAS_PSEUDOREG): Define.
15557         (rs6000_register_name): Return names for the "vX" aliases.
15558         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15559         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15560         aliases.  Call default_register_reggroup_p for all other
15561         pseudo-registers.
15562         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15563         New functions.
15564         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15565         Handle "vX" aliases.
15566         (v_alias_pseudo_register_collect): New function.
15567         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15568         (rs6000_gdbarch_init): Initialize "vX" aliases as
15569         pseudo-registers.  Restore registration of
15570         rs6000_pseudo_register_reggroup_p with
15571         set_tdesc_pseudo_register_reggroup_p.
15572
15573 2019-01-13  Max Filippov  <[email protected]>
15574
15575         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15576         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15577         set_gdbarch_num_pseudo_regs.
15578
15579 2019-01-12  Philippe Waroquiers  <[email protected]>
15580
15581         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15582         Remove arg prefixname, add do_set and do_show.
15583         Add member functions set_list and show_list.
15584         * cli/cli-style.c (class cli_style_option): Update accordingly.
15585         (style_set_list): Move to file scope.
15586         (style_show_list): Likewise.
15587         (set_style): Call help_list.
15588         (show_style): Call cmd_show_list.
15589         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15590         Update to use the new macro.
15591
15592 2019-10-12  Joel Brobecker  <[email protected]>
15593
15594         * ada-lang.c (_initialize_ada_language): Expand the help text
15595         for the "catch exception" command.
15596
15597 2019-01-12  Philippe Waroquiers  <[email protected]>
15598
15599         * symtab.c (matching_obj_sections): Initialize obj,
15600         declare it closer to its usage.
15601
15602 2019-01-10  Tom Tromey  <[email protected]>
15603
15604         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15605         (basic_inf_threads_range): Remove.
15606         (inf_threads_range, inf_non_exited_threads_range)
15607         (safe_inf_threads_range): Use next_adapter.
15608
15609 2019-01-10  Keith Seitz  <[email protected]>
15610
15611         PR gdb/23712
15612         PR symtab/23010
15613         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15614         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15615
15616 2019-01-10  Keith Seitz  <[email protected]>
15617
15618         PR gdb/23712
15619         PR symtab/23010
15620         * dictionary.c (pending_to_vector): Remove.
15621         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15622         Remove _1 suffix, replacing functions of the same name.  Update
15623         all callers.
15624         (dict_create_hashed, dict_create_hashed_expandable)
15625         (dict_create_linear, dict_create_linear_expandable, dict_free)
15626         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15627         Make functions static.
15628
15629 2019-01-10  Keith Seitz  <[email protected]>
15630
15631         PR gdb/23712
15632         PR symtab/23010
15633         * dictionary.h (struct dictionary): Replace declaration with
15634         multidictionary.
15635         (dict_create_hashed, dict_create_hashed_expandable)
15636         (dict_create_linear, dict_create_linear_expandable)
15637         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15638         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15639         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15640         taking multidictionary argument.
15641         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15642         * block.h (struct block) <dict>: Change to multidictionary
15643         and rename `multidict'.
15644         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15645         symmisc.c: Update all dictionary references to multidictionary.
15646
15647 2019-01-10  Keith Seitz  <[email protected]>
15648
15649         PR gdb/23712
15650         PR symtab/23010
15651         * dictionary.c: Include unordered_map.
15652         (pending_to_vector): New function.
15653         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15654         Rewrite the non-"_1" functions to take vector instead
15655         of linked list.
15656         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15657         "new" _1 versions of the same name.
15658         (multidictionary): Define.
15659         (std::hash<enum language): New definition.
15660         (collate_pending_symbols_by_language, mdict_create_hashed)
15661         (mdict_create_hashed_expandable, mdict_create_linear)
15662         (mdict_create_linear_expandable, mdict_free)
15663         (find_language_dictionary, create_new_language_dictionary)
15664         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15665         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15666         (mdict_size, mdict_empty): New functions.
15667         * dictionary.h (mdict_iterator): Define.
15668
15669 2019-01-10  Pedro Alves  <[email protected]>
15670
15671         * breakpoint.c (read_uploaded_action)
15672         (create_tracepoint_from_upload): Adjust to use
15673         gdb::unique_xmalloc_ptr.
15674         * ctf.c (ctf_write_uploaded_tp):
15675         (SET_ARRAY_FIELD): Use emplace_back.
15676         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15677         * tracefile-tfile.c (tfile_write_uploaded_tp):
15678         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15679         gdb::unique_xmalloc_ptr.
15680         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15681         at_string, cond_string, cmd_strings>: Replace char pointers
15682         with gdb::unique_xmalloc_ptr.
15683
15684 2019-01-10  Pedro Alves  <[email protected]>
15685
15686         * solib-target.c (library_list_start_library): Don't xstrdup name.
15687
15688 2019-01-10  Pedro Alves  <[email protected]>
15689
15690         * mdebugread.c (parse_partial_symbols): Use
15691         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15692
15693 2019-01-10  Andrew Burgess  <[email protected]>
15694
15695         * linux-fork.c (scoped_switch_fork_info)
15696         <~scoped_switch_fork_info>: Fix incorrect variable name.
15697
15698 2019-01-10  Andrew Burgess  <[email protected]>
15699
15700         * linux-fork.c (scoped_switch_fork_info)
15701         <scoped_switch_fork_info>: Make explicit.
15702         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15703
15704 2019-01-10  Tom Tromey  <[email protected]>
15705
15706         * objfiles.h (objfile::reset_psymtabs): Update.
15707         * objfiles.c (objfile::objfile): Update.
15708         * psymtab.h (psymtab_storage::obstack): Update.
15709         (psymtab_storage::m_obstack): Use gdb::optional.
15710         (class psymtab_storage): Update comment.  Remove objfile
15711         parameter.
15712         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15713
15714 2019-01-10  Tom Tromey  <[email protected]>
15715
15716         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15717         <free_psymtabs>: Now private.
15718         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15719         (allocate_psymtab): Use new method.
15720
15721 2019-01-10  Tom Tromey  <[email protected]>
15722
15723         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15724         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15725         * mdebugread.c (parse_partial_symbols): Use
15726         allocate_dependencies.
15727         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15728         allocate_dependencies.
15729         (process_psymtab_comp_unit_reader)
15730         (build_type_psymtab_dependencies): Likewise.
15731         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15732
15733 2019-01-10  Tom Tromey  <[email protected]>
15734
15735         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15736         PSYMBOL_SET_LANGUAGE.
15737         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15738
15739 2019-01-10  Tom Tromey  <[email protected]>
15740
15741         * psymtab.h (psymtab_storage::obstack): New method.
15742         <m_obstack>: Rename from obstack; now private.
15743         * psymtab.c (psymtab_storage): Update.
15744         * dwarf2read.c (create_addrmap_from_index)
15745         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15746         Update.
15747
15748 2019-01-10  Tom Tromey  <[email protected]>
15749
15750         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15751         * objfiles.h (objfile::reset_psymtabs): New method.
15752
15753 2019-01-10  Tom Tromey  <[email protected]>
15754
15755         * symmisc.c (print_symbol_bcache_statistics): Update.
15756         (print_objfile_statistics): Update.
15757         * symfile.c (reread_symbols): Update.
15758         * psymtab.h (class psymtab_storage): New.
15759         * psymtab.c (psymtab_storage): New constructor.
15760         (~psymtab_storage): New destructor.
15761         (require_partial_symbols): Update.
15762         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15763         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15764         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15765         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15766         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15767         (start_psymtab_common, end_psymtab_common)
15768         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15769         (allocate_psymtab): Update.
15770         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15771         Update.
15772         (dump_psymtab_addrmap, maintenance_print_psymbols)
15773         (maintenance_check_psymtabs): Update.
15774         (class objfile_psymtabs): Move to objfiles.h.
15775         * psympriv.h (discard_psymtab): Now inline.
15776         (psymtab_discarder::psymtab_discarder): Update.
15777         (psymtab_discarder::~psymtab_discarder): Update.
15778         (ALL_OBJFILE_PSYMTABS): Rewrite.
15779         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15780         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15781         Remove fields.
15782         <partial_symtabs>: New field.
15783         (class objfile_psymtabs): Move from psymtab.h.  Update.
15784         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15785         psymbol_cache.
15786         (objfile::~objfile): Don't destroy psymbol_cache.
15787         * mdebugread.c (parse_partial_symbols): Update.
15788         * dwarf2read.c (create_addrmap_from_index)
15789         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15790         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15791         (add_partial_subprogram, dwarf2_ranges_read): Update.
15792         * dwarf-index-write.c (write_address_map)
15793         (write_one_signatured_type, recursively_write_psymbols)
15794         (class debug_names, class debug_names, write_psymtabs_to_index):
15795         Update.
15796
15797 2019-01-10  Tom Tromey  <[email protected]>
15798
15799         * symtab.h (SYMBOL_SET_NAMES): Update.
15800         (symbol_set_names): Update.
15801         (MSYMBOL_SET_NAMES): Update.
15802         * symtab.c (symbol_set_names): Change argument to be an
15803         objfile_per_bfd_storage.
15804         * psymtab.c (add_psymbol_to_bcache): Update.
15805         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15806
15807 2019-01-10  Tom Tromey  <[email protected]>
15808
15809         * symtab.c (create_demangled_names_hash): Change argument to be an
15810         objfile_per_bfd_storage.
15811         (symbol_set_names): Update.
15812
15813 2019-01-10  Tom Tromey  <[email protected]>
15814
15815         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15816         init_psymbol_list.
15817         * psymtab.c (init_psymbol_list): Do nothing if already called.
15818         * psympriv.h (init_psymbol_list): Add comment.
15819         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15820         init_psymbol_list.
15821         * dbxread.c (dbx_symfile_read): Unconditionally call
15822         init_psymbol_list.
15823
15824 2019-01-10  Tom Tromey  <[email protected]>
15825
15826         * xcoffread.c (scan_xcoff_symtab): Update.
15827         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15828         "where".
15829         * mdebugread.c (parse_partial_symbols)
15830         (handle_psymbol_enumerators): Update.
15831         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15832         * dbxread.c (read_dbx_symtab): Update.
15833         * psympriv.h (psymbol_placement): New enum.
15834         (add_psymbol_to_list): Update.
15835
15836 2019-01-10  Tom Tromey  <[email protected]>
15837
15838         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15839         static_psymbols parameters.
15840         (scan_xcoff_symtab): Update.
15841         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15842         static_psymbols parameters.
15843         * psympriv.h (start_psymtab_common): Update.
15844         * mdebugread.c (parse_partial_symbols): Update.
15845         * dwarf2read.c (create_partial_symtab): Update.
15846         * dbxread.c (read_dbx_symtab): Update.
15847         (start_psymtab): Remove global_psymbols and static_psymbols
15848         parameters.
15849
15850 2019-01-10  Tom Tromey  <[email protected]>
15851
15852         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15853         * psymtab.c (allocate_psymtab): Add comment.
15854         * psympriv.h (allocate_psymtab): Add comment.
15855         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15856         initializations.
15857         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15858
15859 2019-01-10  Tom Tromey  <[email protected]>
15860
15861         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15862         Don't declare.
15863         * mipsread.c: Include mdebugread.h.
15864         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15865         Declare.
15866         * elfread.c: Include mdebugread.h.
15867
15868 2019-01-09  Tom Tromey  <[email protected]>
15869
15870         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15871         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15872         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15873         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15874         (psym_lookup_symbol, psym_find_last_source_symtab)
15875         (psym_forget_cached_source_info, psym_print_stats)
15876         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15877         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15878         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15879         (psym_find_compunit_symtab_by_address)
15880         (maintenance_print_psymbols, maintenance_info_psymtabs)
15881         (maintenance_check_psymtabs): Use ranged for.
15882         * psymtab.h (class objfile_psymtabs): New.
15883         (require_partial_symbols): Return objfile_psymtabs.
15884         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15885
15886 2019-01-09  Tom Tromey  <[email protected]>
15887
15888         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15889         (find_pc_mapped_section, list_overlays_command)
15890         (map_overlay_command, unmap_overlay_command)
15891         (simple_overlay_update): Use all_objfiles.
15892         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15893         * printcmd.c (info_symbol_command): Use all_objfiles.
15894         * objfiles.h (ALL_OBJSECTIONS): Remove.
15895         * maint.c (maintenance_translate_address): Use all_objfiles.
15896         * gcore.c (gcore_create_callback): Use all_objfiles.
15897         (objfile_find_memory_regions): Likewise.
15898
15899 2019-01-09  Tom Tromey  <[email protected]>
15900
15901         * symtab.c (find_line_symtab, info_sources_command)
15902         (make_source_files_completion_list): Use objfile_compunits.
15903         * source.c (select_source_symtab): Use objfile_compunits.
15904         * objfiles.h (struct objfile): Update comment.
15905         (ALL_OBJFILES): Remove.
15906         (ALL_FILETABS): Remove.
15907         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15908         objfile_compunits.
15909
15910 2019-01-09  Tom Tromey  <[email protected]>
15911
15912         * symmisc.c (print_objfile_statistics, dump_objfile)
15913         (maintenance_print_symbols): Use compunit_filetabs.
15914         * source.c (forget_cached_source_info_for_objfile): Use
15915         compunit_filetabs.
15916         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15917         (ALL_FILETABS): Use compunit_filetabs.
15918         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15919         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15920
15921 2019-01-09  Tom Tromey  <[email protected]>
15922
15923         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15924         (compunit_filetabs): New.
15925         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15926         compunit_filetabs.
15927         (info_sources_command, make_source_files_completion_list): Remove
15928         declaration.
15929         * symmisc.c (print_objfile_statistics, dump_objfile)
15930         (maintenance_print_symbols): Remove declaration.
15931         (maintenance_info_symtabs): Use compunit_filetabs.
15932         (maintenance_info_line_tables): Likewise.
15933         * source.c (select_source_symtab): Change local variable name.
15934         (forget_cached_source_info_for_objfile): Remove declaration.
15935         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15936         * objfiles.c (objfile_relocate1): Remove declaration.
15937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15938         declaration.
15939         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15940         * coffread.c (coff_symtab_read): Remove declaration.
15941         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15942         compunit_filetabs.
15943
15944 2019-01-09  Tom Tromey  <[email protected]>
15945
15946         * symtab.c (lookup_objfile_from_block)
15947         (find_pc_sect_compunit_symtab, search_symbols)
15948         (default_collect_symbol_completion_matches_break_on): Use
15949         objfile_compunits.
15950         * objfiles.h (ALL_COMPUNITS): Remove.
15951         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15952         * cp-support.c (add_symbol_overload_list_qualified): Use
15953         objfile_compunits.
15954         * ada-lang.c (ada_collect_symbol_completion_matches)
15955         (ada_add_global_exceptions): Use objfile_compunits.
15956
15957 2019-01-09  Tom Tromey  <[email protected]>
15958
15959         * source.c (select_source_symtab)
15960         (forget_cached_source_info_for_objfile): Remove declaration.
15961         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15962         declaration.
15963         * maint.c (count_symtabs_and_blocks): Remove declaration.
15964         * cp-support.c (add_symbol_overload_list_qualified): Remove
15965         declaration.
15966         * coffread.c (coff_symtab_read): Remove declaration.
15967         * symtab.c (lookup_symbol_in_objfile_symtabs)
15968         (basic_lookup_transparent_type_1): Use objfile_compunits.
15969         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15970         (info_sources_command, search_symbols)
15971         (default_collect_symbol_completion_matches_break_on)
15972         (make_source_files_completion_list): Remove declaration.
15973         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15974         (ada_collect_symbol_completion_matches)
15975         (ada_add_global_exceptions): Remove declaration.
15976         * linespec.c (iterate_over_all_matching_symtabs): Use
15977         objfile_compunits.
15978         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15979         (class objfile_compunits): New.
15980         (ALL_COMPUNITS): Use objfile_compunits.
15981         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15982         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15983         objfile_compunits.
15984         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15985
15986 2019-01-09  Tom Tromey  <[email protected]>
15987
15988         * symtab.c (search_symbols)
15989         (default_collect_symbol_completion_matches_break_on): Use
15990         objfile_msymbols.
15991         * ada-lang.c (ada_lookup_simple_minsym)
15992         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15993         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15994         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15995         objfile_msymbols.
15996         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15997         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15998         * objc-lang.c (find_methods): Use objfile_msymbols.
15999         (info_selectors_command, info_classes_command): Likewise.
16000         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16001         * objfiles.h (class objfile_msymbols): New.
16002         (ALL_OBJFILE_MSYMBOLS): Remove.
16003         (ALL_MSYMBOLS): Remove.
16004
16005 2019-01-09  Tom Tromey  <[email protected]>
16006
16007         * common/next-iterator.h (next_adapter): Add Iterator template
16008         parameter.
16009         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16010         (class all_objfiles_safe): New.
16011         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16012         * objfiles.c (put_objfile_before): Update comment.
16013         (add_separate_debug_objfile): Likewise.
16014         (free_all_objfiles): Use all_objfiles_safe.
16015         (objfile_purge_solibs): Likewise.
16016
16017 2019-01-09  Tom Tromey  <[email protected]>
16018
16019         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16020         (expand_symtab_containing_pc, lookup_static_symbol)
16021         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16022         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16023         all_objfiles.
16024         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16025         * breakpoint.c (create_overlay_event_breakpoint)
16026         (create_longjmp_master_breakpoint)
16027         (create_std_terminate_master_breakpoint)
16028         (create_exception_master_breakpoint): Use all_objfiles.
16029         * linux-thread-db.c (try_thread_db_load_from_pdir)
16030         (has_libpthread): Use all_objfiles.
16031         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16032         * linespec.c (iterate_over_all_matching_symtabs)
16033         (search_minsyms_for_name): Use all_objfiles.
16034         * maint.c (maintenance_info_sections): Use all_objfiles.
16035         * main.c (captured_main_1): Use all_objfiles.
16036         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16037         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16038         * guile/scm-pretty-print.c
16039         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16040         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16041         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16042         (maintenance_print_msymbols): Use all_objfiles.
16043         * source.c (select_source_symtab): Use all_objfiles.
16044         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16045         * symfile.c (remove_symbol_file_command)
16046         (expand_symtabs_matching, map_symbol_filenames): Use
16047         all_objfiles.
16048         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16049         all_objfiles.
16050         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16051         * objc-lang.c (find_methods): Use all_objfiles.
16052         * objfiles.c (have_partial_symbols, have_full_symbols)
16053         (have_minimal_symbols, qsort_cmp)
16054         (default_iterate_over_objfiles_in_search_order): Use
16055         all_objfiles.
16056         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16057         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16058         (maintenance_check_psymtabs): Use all_objfiles.
16059         (ALL_PSYMTABS): Remove.
16060         * compile/compile-object-run.c (do_module_cleanup): Use
16061         all_objfiles.
16062         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16063         * cp-support.c (add_symbol_overload_list_qualified): Use
16064         all_objfiles.
16065         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16066         Use all_objfiles.
16067         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16068         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16069         all_objfiles.
16070         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16071         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16072         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16073         Uses all_objfiles.
16074         * solib.c (solib_read_symbols): Use all_objfiles
16075
16076 2019-01-09  Tom Tromey  <[email protected]>
16077
16078         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16079         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16080         all_objfiles.
16081         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16082         * symmisc.c (print_symbol_bcache_statistics)
16083         (print_objfile_statistics, maintenance_print_objfiles)
16084         (maintenance_info_symtabs, maintenance_check_symtabs)
16085         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16086         all_objfiles.
16087         * source.c (forget_cached_source_info): Use all_objfiles.
16088         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16089         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16090         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16091         * objfiles.c (update_section_map): Use all_objfiles.
16092         (shared_objfile_contains_address_p): Likewise.
16093         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16094         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16095
16096 2019-01-09  Tom Tromey  <[email protected]>
16097
16098         * common/next-iterator.h: New file.
16099         * objfiles.h (class all_objfiles): New.
16100         (struct objfile_iterator): New.
16101
16102 2019-01-09  Philippe Waroquiers  <[email protected]>
16103
16104         * NEWS: Move the description of the changed "frame", "select-frame",
16105          and "info frame" commands to the Changed commands section.
16106
16107 2019-01-09  Simon Marchi  <[email protected]>
16108
16109         * gdbtypes.c (check_stub_method_group): Remove handling of old
16110         mangling schemes.
16111         * linespec.c (find_methods): Likewise.
16112         * stabsread.c (read_member_functions): Likewise.
16113         * valops.c (search_struct_method): Likewise.
16114         (value_struct_elt_for_reference): Likewise.
16115         * NEWS: Mention this change.
16116
16117 2019-01-09  Andrew Burgess  <[email protected]>
16118
16119         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16120         print_source_lines.
16121         * source.c (print_source_lines_base): Update line number check.
16122         (print_source_lines): New function.
16123         (source_lines_range::source_lines_range): New function.
16124         * source.h (class source_lines_range): New class.
16125         (print_source_lines): New declaration.
16126
16127 2019-01-09  Philippe Waroquiers  <[email protected]>
16128
16129         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16130
16131 2019-01-08  Tom Tromey  <[email protected]>
16132             Simon Marchi  <[email protected]>
16133
16134         PR gdb/24060
16135         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16136         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16137         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16138         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16139         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16140         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16141
16142 2019-01-08  Andrew Burgess  <[email protected]>
16143
16144         * source.c (select_source_symtab): Move header comment to
16145         declaration in source.h.
16146         (forget_cached_source_info_for_objfile): Likewise.
16147         (forget_cached_source_info): Likewise.
16148         (identify_source_line): Likewise.
16149         * source.h (identify_source_line): Move declaration from symtab.h
16150         and add comment from source.c
16151         (print_source_lines): Likewise.
16152         (forget_cached_source_info_for_objfile): Likewise.
16153         (forget_cached_source_info): Likewise.
16154         (select_source_symtab): Likewise.
16155         (enum print_source_lines_flag): Move definition from symtab.h.
16156         * symtab.h (identify_source_line): Move declaration to source.h.
16157         (print_source_lines): Likewise.
16158         (forget_cached_source_info_for_objfile): Likewise.
16159         (forget_cached_source_info): Likewise.
16160         (select_source_symtab): Likewise.
16161         (enum print_source_lines_flag): Move definition to source.h.
16162         * tui/tui-hooks.c: Add 'source.h' include.
16163
16164 2019-01-08  Andrew Burgess  <[email protected]>
16165
16166         * source.c (print_source_lines_base): Handle requests to print
16167         reverse line number sequences, and guard against empty lines
16168         string.
16169
16170 2019-01-08  Andrew Burgess  <[email protected]>
16171
16172         * source.c (print_source_lines_base): Fix skip of '\r' if next
16173         character is '\n'.
16174
16175 2019-01-06  Tom Tromey  <[email protected]>
16176
16177         * c-exp.y (struct c_parse_state) <macro_original_text,
16178         expansion_obstack>: New member.
16179         (macro_original_text, expansion_obstack): Remove globals.
16180         (scan_macro_expansion, scanning_macro_expansion)
16181         (finished_macro_expansion): Update.
16182         (scan_macro_cleanup): Remove.
16183         (yylex, c_parse): Update.
16184
16185 2019-01-06  Tom Tromey  <[email protected]>
16186
16187         * c-exp.y (struct c_parse_state) <strings>: New member.
16188         (operator_stoken): Update.
16189
16190 2019-01-06  Tom Tromey  <[email protected]>
16191
16192         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16193         (union type_stack_elt) <typelist_val>: Now a pointer to
16194         std::vector.
16195         (type_stack_cleanup): Don't declare.
16196         (push_typelist): Update.
16197         * parse.c (pop_typelist): Return a std::vector.
16198         (push_typelist): Take a std::vector.
16199         (follow_types): Update.  Do not free args.
16200         (type_stack_cleanup): Remove.
16201         * c-exp.y (struct c_parse_state): New.
16202         (cpstate): New global.
16203         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16204         (nonempty_typelist): Update.
16205         (func_mod): Create a new vector.
16206         (c_parse): Create a c_parse_state.
16207         (check_parameter_typelist): Do not delete params.
16208         (function_method): Update.  Do not delete type_list.
16209
16210 2019-01-06  Tom Tromey  <[email protected]>
16211
16212         PR gdb/28155:
16213         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16214         check_typedef.
16215         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16216         (print_return_value): Likewise.
16217
16218 2019-01-05  Tom Tromey  <[email protected]>
16219
16220         * contrib/cleanup_check.py: Remove.
16221         * contrib/gcc-with-excheck: Remove.
16222         * contrib/exsummary.py: Remove.
16223         * contrib/excheck.py: Remove.
16224
16225 2019-01-05  Joel Brobecker  <[email protected]>
16226
16227         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16228         NULL. Initialize tpprev to NULL instead of assigning it
16229         to NULL on the next statement.
16230         * windows-nat.c (windows_delete_thread): Remove check for
16231         main_thread_id before printing thread exit notifications.
16232         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16233         Remove thread ID check against main_thread_id.
16234         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16235         windows_delete_thread.
16236         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16237
16238 2019-01-04  Tom Tromey  <[email protected]>
16239
16240         * compile/compile.c (_initialize_compile): Use upper case for
16241         metasyntactic variables.
16242         * symmisc.c (_initialize_symmisc): Use upper case for
16243         metasyntactic variables.
16244         * psymtab.c (_initialize_psymtab): Use upper case for
16245         metasyntactic variables.
16246         * demangle.c (demangle_command): Use upper case for metasyntactic
16247         variables.
16248         (_initialize_demangler): Likewise.
16249         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16250         variables.
16251
16252 2019-01-03  Tom Tromey  <[email protected]>
16253
16254         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16255
16256 2019-01-03  Tom Tromey  <[email protected]>
16257
16258         * python/py-symtab.c (salpy_str): Update.
16259         (struct salpy_sal_object) <symtab>: Now a PyObject.
16260         (salpy_dealloc): Update.
16261         (del_objfile_sal): Use gdbpy_ref.
16262
16263 2019-01-03  Tom Tromey  <[email protected]>
16264
16265         * python/py-type.c (convert_field): Use new_reference.  Return
16266         gdbpy_ref.
16267         (make_fielditem): Return gdbpy_ref.
16268         (typy_fields): Update.
16269         (typy_getitem): Update.
16270         (field_name): Return gdbpy_ref.  Use new_reference.
16271         (typy_iterator_iternext): Update.
16272
16273 2019-01-03  Tom Tromey  <[email protected]>
16274
16275         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16276
16277 2019-01-03  Tom Tromey  <[email protected]>
16278
16279         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16280         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16281         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16282         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16283         (pspy_set_type_printers): Likewise.
16284         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16285         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16286         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16287         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16288         (objfpy_set_type_printers): Likewise.
16289
16290 2019-01-03  Tom Tromey  <[email protected]>
16291
16292         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16293         (gdbpy_print_stack): Use gdbpy_err_fetch.
16294         * python/python-internal.h (class gdbpy_err_fetch): New class.
16295         (class gdbpy_enter) <m_error_type, m_error_value,
16296         m_error_traceback>: Remove.
16297         <m_error>: New member.
16298         (gdbpy_exception_to_string): Don't declare.
16299         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16300         * python/py-value.c (convert_value_from_python): Use
16301         gdbpy_err_fetch.
16302         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16303         gdbpy_exception_to_string.
16304         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16305         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16306         gdbpy_err_fetch.
16307
16308 2019-01-03  Andrew Burgess  <[email protected]>
16309
16310         * linux-nat.c (delete_lwp_cleanup): Delete.
16311         (struct lwp_deleter): New struct.
16312         (lwp_info_up): New typedef.
16313         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16314         lwp_info_up.
16315
16316 2019-01-03  Andrew Burgess  <[email protected]>
16317
16318         * linux-fork.c (class scoped_switch_fork_info): New class.
16319         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16320
16321 2019-01-03  Andrew Burgess  <[email protected]>
16322
16323         * valops.c (find_overload_match): Remove use of null_cleanup, and
16324         calls to do_cleanups.
16325
16326 2019-01-03  Andrew Burgess  <[email protected]>
16327
16328         * compile/compile-cplus-types.c
16329         (compile_cplus_instance::decl_name): Handle changes to
16330         cp_func_name.
16331         * cp-support.c (cp_func_name): Update header comment, update
16332         return type.
16333         * cp-support.h (cp_func_name): Update return type in declaration.
16334         * valops.c (find_overload_match): Move temp_func local to top
16335         level of function and change its type.  Use temp_func to hold and
16336         delete temporary string obtained from cp_func_name.
16337
16338 2019-01-03  Andrew Burgess  <[email protected]>
16339
16340         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16341         gdb::char_vector, remove cleanup, and update uses of `msg`.
16342
16343 2019-01-03  Jim Wilson  <[email protected]>
16344
16345         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16346
16347 2019-01-02  Tom Tromey  <[email protected]>
16348
16349         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16350         (tdesc_parse_xml): Remove cleanups.
16351         * target-descriptions.h (make_cleanup_free_target_description):
16352         Don't declare.
16353         (target_desc_deleter): New struct.
16354         (target_desc_up): New typedef.
16355         * target-descriptions.c (target_desc_deleter::operator()): Rename
16356         from free_target_description.
16357         (make_cleanup_free_target_description): Remove.
16358
16359 2019-01-02  Tom Tromey  <[email protected]>
16360
16361         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16362         constructor, destructor.
16363         (linespec_parser): Remove typedef.
16364         (~linespec_parser): Rename from linespec_parser_delete.
16365         (linespec_lex_to_end, linespec_complete_label)
16366         (linespec_complete): Update.
16367         (decode_line_full): Remove cleanups.
16368         (decode_line_1): Update.
16369
16370 2019-01-02  Tom Tromey  <[email protected]>
16371
16372         * python/python-internal.h (inferior_to_inferior_object): Change
16373         return type.
16374         * python/py-exitedevent.c (create_exited_event_object): Update.
16375         * python/py-inferior.c (inferior_to_inferior_object): Return
16376         gdbpy_ref.
16377         (python_new_inferior, python_inferior_deleted)
16378         (thread_to_thread_object, delete_thread_object)
16379         (build_inferior_list, gdbpy_selected_inferior): Update.
16380         * python/py-infthread.c (create_thread_object): Update.  Also fail
16381         if inferior_to_inferior_object fails.
16382
16383 2019-01-02  Simon Marchi  <[email protected]>
16384
16385         * inferior.h (class inferior) <displaced_step_state>: New field.
16386         * infrun.h (struct displaced_step_state): Move here from
16387         infrun.c.  Initialize fields, add constructor.
16388         <inf>: Remove field.
16389         <reset>: New method.
16390         * infrun.c (struct displaced_step_inferior_state): Move to
16391         infrun.h.
16392         (displaced_step_inferior_states): Remove.
16393         (get_displaced_stepping_state): Adust.
16394         (displaced_step_in_progress_any_inferior): Adjust.
16395         (displaced_step_in_progress_thread): Adjust.
16396         (displaced_step_in_progress): Adjust.
16397         (add_displaced_stepping_state): Remove.
16398         (get_displaced_step_closure_by_addr): Adjust.
16399         (remove_displaced_stepping_state): Remove.
16400         (infrun_inferior_exit): Call displaced_step_state.reset.
16401         (use_displaced_stepping): Don't check for NULL.
16402         (displaced_step_prepare_throw): Call
16403         get_displaced_stepping_state.
16404         (displaced_step_fixup): Don't check for NULL.
16405         (prepare_for_detach): Don't check for NULL.
16406
16407 2019-01-02  Philippe Waroquiers  <[email protected]>
16408
16409         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16410          in case of call that did not complete.
16411
16412 2019-01-02  Andrey Utkin  <[email protected]>
16413
16414         * symfile.c (find_separate_debug_file): Fix search of debug files for
16415         remote debuggee.
16416
16417 2019-01-02  Tom Tromey  <[email protected]>
16418
16419         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16420         indentation.
16421         * python/py-frame.c (frapy_older): Remove cast.
16422         (frapy_newer): Likewise.
16423         * python/py-breakpoint.c (local_setattro): Remove cast.
16424         * python/py-arch.c (archpy_name): Remove local variable.
16425         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16426
16427 2019-01-02  Joel Brobecker  <[email protected]>
16428
16429         * unittests/basic_string_view/element_access/char/empty.cc:
16430         Fix year range in copyright header.
16431
16432 2019-01-01  Andrew Burgess  <[email protected]>
16433
16434         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16435         Delete.
16436         <operator==>: Update with for removed field.
16437         <hash>: Likewise.
16438         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16439         <isa_features>: ...this.
16440         <abi_features>: New field.
16441         (riscv_isa_flen): Update comment.
16442         (riscv_abi_xlen): New declaration.
16443         (riscv_abi_flen): New declaration.
16444         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16445         isa_features.
16446         (riscv_abi_xlen): New function.
16447         (riscv_isa_flen): Update to get answer from isa_features.
16448         (riscv_abi_flen): New function.
16449         (riscv_has_fp_abi): Update to get answer from abi_features.
16450         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16451         xlen and flen.
16452         (riscv_call_info) <xlen, flen>: Update comment.
16453         (riscv_call_arg_struct): Remove invalid assertions
16454         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16455         is removed.
16456         (riscv_gdbarch_init): Gather isa features and abi features
16457         separately, ensure both match on the gdbarch when reusing an old
16458         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16459         a target with 64-bit float hardware.
16460
16461 2019-01-01  Philippe Waroquiers  <[email protected]>
16462
16463         * source.c (search_command_helper): Stop reverse search
16464         when line 1 has been searched.
16465
16466 2019-01-01  Philippe Waroquiers  <[email protected]>
16467
16468         * record-full.c (record_full_base_target::close): Rewrite
16469         record_full_core_buf_list free logic.
16470
16471 2019-01-01  Philippe Waroquiers  <[email protected]>
16472
16473         * break-catch-syscall.c (print_one_catch_syscall): xfree
16474         the last text.
16475
16476 2019-01-01  Joel Brobecker  <[email protected]>
16477
16478         * top.c (print_gdb_version): Update Copyright year in version
16479         message.
16480
16481 2019-01-01  Joel Brobecker  <[email protected]>
16482
16483         Update copyright year range in all GDB files.
16484
16485 2019-01-01, 19  Joel Brobecker  <[email protected]>
16486
16487         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16488
16489 For older changes see ChangeLog-2018.
16490 \f
16491 Local Variables:
16492 mode: change-log
16493 left-margin: 8
16494 fill-column: 74
16495 version-control: never
16496 coding: utf-8
16497 End:
16498
This page took 0.970671 seconds and 4 git commands to generate.