1 If you find inaccuracies in this list, please send mail to
3 of these, you should consider sending mail to the same address, to
4 find out whether anyone else is working on it.
10 Below is a list of problems identified during the GDB 5.0 release
11 cycle. People hope to have these problems fixed in 5.1.
15 Update GDB's coding standard documentation. Known topics:
17 o alloca/malloc et.al.
33 Wow, three bug reports for the same problem in one day! We should
34 probably make fixing this a real priority :-).
36 Anyway, thanks for reporting.
38 The following patch will fix the problems with setting breakpoints in
39 dynamically loaded objects:
41 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00230.html
43 This patch isn't checked in yet (ping Michael/JimB), but I hope this
44 will be in the next GDB release.
46 There should really be a test in the testsuite for this problem, since
47 it keeps coming up :-(. Any volunteers?
53 x86 linux GDB and SIGALRM (???)
54 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00803.html
56 This problem has been fixed, but a regression test still needs to be
57 added to the testsuite:
58 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00309.html
62 [The test has been submitted for approval - cagney]
66 RFD: infrun.c: No bpstat_stop_status call after proceed over break?
67 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00665.html
69 GDB misses watchpoint triggers after proceeding over a breakpoint on
74 GDB 5.0 doesn't work on Linux/SPARC
76 There are two parts to this.
78 o GDB 5.0 doesn't work on GNU/Linux/SPARC32
80 o GDB 5.0 doesn't work on the new target
83 GDB does build on both these targets.
85 The first problem is the one that should be fixed.
89 GDB 5.1 - New features
90 ======================
92 The following new features should be included in 5.1.
96 Enable MI by default. Old code can be deleted after 5.1 is out.
100 o syntax change where a list would
102 [ foo=a, foo=b, foo=c ]
104 { foo=a, foo=b, foo=c }
106 o kill off the idea of a reverse
115 Pascal (Pierre Muller, David Taylor)
117 Pierre Muller has contributed patches for adding Pascal Language
120 2 pascal language patches inserted in database
121 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00521.html
124 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00496.html
126 [I think this has been merged, need to confirm - cagney]
130 Java (Anthony Green, David Taylor)
132 Anthony Green has a number of Java patches that did not make it into
133 the 5.0 release. The first two are in cvs now, but the third needs
134 some fixing up before it can go in.
137 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00512.html
140 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00515.html
142 Patch: handle N_MAIN stab
143 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00527.html
149 A predicate to this is the multi-arching of SOFTWARE_SINGLE_STEP(). A
150 patch has been submitted.
157 The following code cleanups will hopefully be applied to GDB 5.1.
161 Resolve the build status of all broken targets as identified by the
164 o arm-* vs NetBSD's lack of ``unix''
165 o arm-* vs IRIX (see below)
169 Fix copyright notices.
171 Turns out that ``1998-2000'' isn't considered valid :-(
173 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00467.html
177 GDB 5.1 - Known Problems
178 ========================
184 The z8k has suffered bit rot and is known to not build. The problem
185 was occuring in the opcodes directory.
191 The m88k has suffered bit rot and is known to not build.
195 Solaris 8 x86 CURSES_H problem
196 http://sources.redhat.com/ml/gdb/2000-07/msg00038.html
198 The original problem was worked around with:
202 * configure.in: Enable autoconf to find curses.h on Solaris 2.8.
203 * configure: Regenerate.
205 When building both GDB and SID using the same source tree the problem
206 will still occure. sid/component/configure.in mis-configures
207 <curses.h> and leaves wrong information in the config cache.
216 Thread support. Right now, as soon as a thread finishes and exits,
217 you're hosed. This problem is reported once a week or so.
221 GDB 5.2 - New features
222 ======================
226 GCC 3.0 ABI support (but hopefully sooner...).
230 Objective C/C++ support (but hopefully sooner...).
237 The following cleanups have been identified as part of GDB 5.2.
241 Remove old code that does not use ui_out functions and all the related
242 "ifdef"s. This also allows the elimination of -DUI_OUT from
243 Makefile.in and configure.in.
249 Eliminate warnings for all targets on at least one host for one of the
250 -W flags. Flags up for debate include: -Wswitch -Wcomment -trigraphs
251 -Wtrigraphs -Wunused-function -Wunused-label -Wunused-variable
252 -Wunused-value -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual
253 -Wcast-align -Wwrite-strings -Wconversion -Wstrict-prototypes
254 -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls
255 -Woverloaded-virtual -Winline
259 Deprecate, if not delete, the following:
265 Replaced by, on the target side
267 and on core-gdb side:
268 {read,write}_register_gen()
269 Remote.c will need to use something
270 other than REGISTER_BYTE() and
271 REGISTER_RAW_SIZE() when unpacking
274 STORE_PSEUDO_REGISTER
275 FETCH_PSEUDO_REGISTER
276 Now handed by the methods
277 gdbarch_{read,write}_register()
278 which sits between core GDB and
282 REGISTER_CONVERT_TO_RAW
283 REGISTER_CONVERT_TO_VIRTUAL
284 I think these three are redundant.
285 gdbarch_register_{read,write} can
286 do any conversion it likes.
288 REGISTER_VIRTUAL_SIZE
289 MAX_REGISTER_VIRTUAL_SIZE
290 REGISTER_VIRTUAL_TYPE
291 I think these can be replaced by
293 FRAME_REGISTER_TYPE(frame, regnum)
294 REGISTER_TYPE(regnum)
298 FRAME_REGISTER_INFO (frame, ...)
301 If nothing else rename this so that
302 how it relates to rawreg and the
306 The size of the cache can be computed
309 IS_TRAPPED_INTERNALVAR
310 The pseudo registers should eventually make
315 Obsolete the targets.
321 Obsolete the protocols:
325 ``As of version 5.3, WindRiver has removed the RDB server (RDB
326 protocol support is built into gdb).'' -- Till.
330 Restructure gdb directory tree so that it avoids any 8.3 and 14
335 Convert GDB build process to AUTOMAKE.
337 See also sub-directory configure below.
339 The current convention is (kind of) to use $(<header>_h) in all
340 dependency lists. It isn't done in a consistent way.
344 GDB 5.2 - Known Problems
345 ========================
349 Code Cleanups: General
350 ======================
352 The following are more general cleanups and fixes. They are not tied
353 to any specific release.
357 Investigate changing --target=a29k-amd-udi to a29k-*-coff* and
358 rationalize *.mt files. The got-ya is in remote-eb.c - it has its own
359 custom tty manipulation - it should be using the serial object.
363 Rename read_register{,_pid}() to read_unsigned_register{,_pid}().
367 Can't build IRIX -> arm GDB.
368 http://sourceware.cygnus.com/ml/gdb-patches/2000-04/msg00356.html
371 > Now I'm building for an embedded arm target. If there is a way of turning
372 > remote-rdi off, I couldn't find it. It looks like it gets built by default
373 > in gdb/configure.tgt(line 58) Anyway, the build dies in
374 > gdb/rdi-share/unixcomm.c. SERPORT1 et. al. never get defined because we
375 > aren't one of the architectures supported.
379 Problem with weak functions
380 http://sourceware.cygnus.com/ml/gdb/2000-05/msg00060.html
382 Dan Nicolaescu writes:
383 > It seems that gdb-4.95.1 does not display correctly the function when
384 > stoping in weak functions.
386 > It stops in a function that is defined as weak, not in the function
387 > that is actually run...
391 Follow through `make check' with --enable-shared.
393 When the srcware tree is configured with --enable-shared, the `expect'
394 program won't run properly. Jim Wilson found out gdb has a local hack
395 to set LD_LIBRARY_PATH, but, AFAIK, no other project has been hacked
398 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00845.html
402 Delete macro TARGET_BYTE_ORDER_SELECTABLE.
404 Patches in the database.
408 printcmd.c (print_address_numeric):
410 NOTE: This assumes that the significant address information is kept in
411 the least significant bits of ADDR - the upper bits were either zero
412 or sign extended. Should ADDRESS_TO_POINTER() or some
413 ADDRESS_TO_PRINTABLE() be used to do the conversion?
417 The BFD directory requires bug-fixed AUTOMAKE et.al.
419 AUTOMAKE 1.4 incorrectly set the TEXINPUTS environment variable. It
420 contained the full path to texinfo.tex when it should have only
421 contained the directory. The bug has been fixed in the current
422 AUTOMAKE sources. Automake snapshots can be found in:
423 ftp://sourceware.cygnus.com/pub/gdb/snapshots
424 and ftp://sourceware.cygnus.com/pub/binutils
428 Find something better than DEFAULT_BFD_ARCH, DEFAULT_BFD_VEC to
429 determine the default isa/byte-order.
433 Rely on BFD_BIG_ENDIAN and BFD_LITTLE_ENDIAN instead of host dependent
434 BIG_ENDIAN and LITTLE_ENDIAN.
438 Eliminate more compiler warnings.
440 Of course there also needs to be the usual debate over which warnings
441 are valid and how to best go about this.
443 One method: choose a single option; get agreement that it is
444 reasonable; try it out to see if there isn't anything silly about it
445 (-Wunused-parameters is an example of that) then incrementally hack
448 The other method is to enable all warnings and eliminate them from one
453 Elimination of ``(catch_errors_ftype *) func''.
455 Like make_cleanup_func it isn't portable.
456 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00791.html
457 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00814.html
461 Nuke #define CONST_PTR.
469 [PATCH/5] src/intl/Makefile.in:distclean additions
470 http://sourceware.cygnus.com/ml/gdb-patches/2000-04/msg00363.html
472 Do not forget to merge the patch back into the trunk.
476 Rationalize the host-endian code (grep for HOST_BYTE_ORDER).
478 At present defs.h includes <endian.h> (which is linux specific) yet
479 almost nothing depends on it. Suggest "gdb_endian.h" which can also
480 handle <machine/endian.h> and only include that where it is really
485 Replace savestring() with something from libiberty.
487 An xstrldup()? but that would have different semantics.
491 Rationalize use of floatformat_unknown in GDB sources.
493 Instead of defaulting to floatformat_unknown, should hosts/targets
494 specify the value explicitly?
496 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00447.html
500 Add a ``name'' member to include/floatformat.h:struct floatformat.
501 Print that name in gdbarch.c.
505 Sort out the harris mess in include/floatformat.h (it hardwires two
506 different floating point formats).
510 See of the GDB local floatformat_do_doublest() and libiberty's
511 floatformat_to_double (which was once GDB's ...) can be merged some
516 Eliminate mmalloc(), mstrsave() et.al. from GDB.
518 Also eliminate it from defs.h.
522 Eliminate PTR. ISO-C allows ``void *''.
528 GDB should never abort. GDB should either throw ``error ()'' or
529 ``internal_error ()''. Better still GDB should naturally unwind with
534 GDB probably doesn't build on FreeBSD pre 2.2.x
535 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00378.html
537 Fixes to get FreeBSD working on 2.2.x, 3.x and 4.x caused the code to
542 Deprecate "fg". Apparently ``fg'' is actually continue.
544 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00417.html
548 Deprecate current use of ``floatformat_unknown''.
550 Require all targets to explicitly provide their float format instead
551 of defaulting to floatformat unknown. Doing the latter leads to nasty
554 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00447.html
558 Rationalize floatformat_to_double() vs floatformat_to_doublest().
560 Looks like GDB migrated floatformat_to_double() to libiberty but then
561 turned around and created a ..._to_doublest() the latter containing
564 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00472.html
568 Move floatformat_ia64_ext to libiberty/include floatformat.[ch].
570 http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00466.html
574 The ``maintenance deprecate set endian big'' command doesn't notice
575 that it is deprecating ``set endian'' and not ``set endian big'' (big
576 is implemented using an enum). Is anyone going to notice this?
580 When tab expanding something like ``set arch<tab>'' ignore the
581 deprecated ``set archdebug'' and expand to ``set architecture''.
585 Eliminate ``arm_register_names[j] = (char *) regnames[j]'' and the
586 like from arm-tdep.c.
590 Fix uses of ->function.cfunc = set_function().
592 The command.c code calls sfunc() when a set command. Rather than
593 change it suggest fixing the callback function so that it is more
596 http://sourceware.cygnus.com/ml/gdb-patches/2000-06/msg00062.html
598 See also ``Fix implementation of ``target xxx''.'' below.
602 IRIX 3.x support is probably broken.
606 Delete sim/SIM_HAVE_BREAKPOINTS and gdb/SIM_HAS_BREAKPOINTS.
607 http://sourceware.cygnus.com/ml/gdb-patches/2000-07/msg00042.html
609 Apart from the d30v, are there any sim/common simulators that make use
612 A brief summary of what happened is that sim/common/sim-break.c was
613 created as a good idea. It turned out a better idea was to use
614 SIM_SIGBREAK and have GDB pass back sim_resume (..., SIGBREAK).
618 Move remote_remove_hw_breakpoint, remote_insert_hw_breakpoint,
619 remote_remove_watchpoint, remote_insert_watchpoint into target vector.
623 Eliminate ``extern'' from C files.
627 Replace ``STREQ()'' et.al. with ``strcmp() == 0'' et.al.
629 Extreme care is recommeded - perhaps only modify tests that are
630 exercised by the testsuite (as determined using some type of code
635 Replace the file gdb/CONTRIBUTE with a file that is generated from the
636 gdb/doc/*.texinfo directory.
640 Rewrite/break up sparcl-tdep.c so that it uses ser*.c as the mechanism
641 for accessing either the serial or UDP port.
645 New Features and Fixes
646 ======================
648 These are harder than cleanups but easier than work involving
649 fundamental architectural change.
653 Hardware watchpoint problems on x86 OSes, including Linux:
655 1. Delete/disable hardware watchpoints should free hardware debug
657 2. Watch for different values on a viariable with one hardware debug
662 These are not GDB/ia32 issues per se: the above features are all
663 implemented in the DJGPP port of GDB and work in v5.0. Every
664 x86-based target should be able to lift the relevant parts of
665 go32-nat.c and use them almost verbatim. You get debug register
666 sharing through reference counts, and the ability to watch large
667 regions (up to 16 bytes) using multiple registers. (The required
668 infrastructure in high-level GDB application code, mostly in
669 breakpoint.c, is also working since v5.0.)
673 Add built-by, build-date, tm, xm, nm and anything else into gdb binary
674 so that you can see how the GDB was created.
678 Add an "info bfd" command that displays supported object formats,
679 similarly to objdump -i.
681 Is there a command already?
685 Fix ``I'm sorry, Dave, I can't do that.'' from symfile.c.
687 This requires internationalization.
693 (gdb) p fwprintf(stdout,L"%S\n", f)
694 No symbol "L" in current context.
698 Cleanup configury support for optional sub-directories.
700 Check how GCC handles multiple front ends for an example of how things
701 could work. A tentative first step is to rationalize things so that
702 all sub directories are handled in a fashion similar to gdb/mi.
704 See also automake above.
708 Add a transcript mechanism to GDB.
710 Such a mechanism might log all gdb input and output to a file in a
711 form that would allow it to be replayed. It could involve ``gdb
712 --transcript=FILE'' or it could involve ``(gdb) transcript file''.
716 Can the xdep files be replaced by autoconf?
720 Document trace machinery
724 Document ui-out and ui-file.
726 http://sourceware.cygnus.com/ml/gdb/2000-04/msg00121.html
730 Update texinfo.tex to latest?
734 Incorporate agentexpr.texi into gdb.texinfo
736 agentexpr.texi mostly describes the details of the byte code used for
737 tracepoints, not the internals of the support for this in GDB. So it
738 looks like gdb.texinfo is a better place for this information.
740 http://sourceware.cygnus.com/ml/gdb-patches/2000-04/msg00566.html
744 Document overlay machinery.
748 ``(gdb) catch signal SIGNAL''
750 Overlaps with ``handle SIGNAL'' but the implied behavior is different.
751 You can attach commands to a catch but not a handle. A handle has a
752 limited number of hardwired actions.
758 o readline/*.h bitrot
760 The TUI isn't up-to-date with
761 respect to the readline currently
762 bundled with GDB. Importing a
763 new readline is on the 5.1 wish
764 list so this can only get worse.
766 Grep for things like term_cursor_move.
768 (To be honest, I don't see anyone
769 importing a new readline before 5.1 is
772 o tui.c:va_catch_errors() bitrot
774 This nasty piece of work used knowledge
775 of the internals of GDBs error functions :-(
776 Ever since those internals were cleaned
777 up this code has been broken. :-(
779 o tuiWin.c:c_makeVisibleWithNewHeight() broken
780 tuiLayout.c:_extractDisplayStartAddr() broken
782 Both these function call find_line_pc()
783 incorrectly (wrong args, wrong return value).
785 I suspect this bug has always been there!
786 It had been hidden because those files
787 didn't include the necessary header files
790 o tuiRegs() host dependant
792 Not suprisingly, this isn't a very portable
793 section of code. However, I'm sure people
794 could live with no regs in the short to
797 o defs.h: #include "tui.h" et.al.
799 I'm not sure where this came from.
800 It was a really bad idea.
802 To get things to compile I did a nasty
803 hack (Just declare what was needed and
804 replace any expressions like xx->y.z()
805 in GDB proper with function calls). I
806 could commit it slightly cleaned up if
809 Medium Term. the #ifdef TUI and TuiDo()
810 should be changed to hooks (like GDBTK).
811 The gdb-events.[hc] is there for that
814 o tui.c:_tuiReset() host dependant
816 tui.c contains a lump of termio[s]
817 I suspect an equivalent block of
818 code can be lifted from readline.
819 An equivalent readline function may
822 o curses.h vs ncurses.h.
824 Simple portability problem.
828 This function is a mystery - where is it?
830 o tui-file.[hc] cleanup
832 This can be significantly simplified.
834 o The code should be pacified. (-Werror -W...)
836 There are plenty of #includes,
837 duplicate #includes, missing function decls
840 Some of the problems I found were through
841 fixing a few of the warnings.
843 o The code should be GNUtified.
845 It would be very nice to have this code
846 look like the rest of GDB. That way people
847 would be more accepting of it as a true
850 Until it is GNUtified it is going to stick
851 out like a sore thumb to the programmer.
853 o The code should be clearly copyrighted
855 (FSF, with due credit to HP)
859 Add support for ``gdb --- PROGRAM ARGS ...''.
860 Add support for ``gdb -cmd=...''
862 Along with many variations. Check:
864 ????? for a full discussion.
870 Implement ``(gdb) !ls''.
872 Which is very different from ``(gdb) ! ls''. Implementing the latter
875 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00034.html
879 Change the (char *list[]) to (const char (*)[]) so that dynamic lists can
884 When tab expanding something like ``set arch<tab>'' ignore the
885 deprecated ``set archdebug'' and expand to ``set architecture''.
889 Replace the code that uses the host FPU with an emulator of the target
894 The "ocd reset" command needs to flush the dcache, which requires breaking
895 the abstraction layer between the target independent and target code. One
896 way to address this is provide a generic "reset" command and target vector.
898 http://sources.redhat.com/ml/gdb-patches/2000-10/msg00011.html
907 Generic: lin-thread cannot handle thread exit (Mark Kettenis, Michael
908 Snyder) http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00525.html
910 The thread_db assisted debugging code doesn't handle exiting threads
911 properly, at least in combination with glibc 2.1.3 (the framework is
912 there, just not the actual code). There are at least two problems
913 that prevent this from working.
915 As an additional reference point, the pre thread_db code did not work
920 GNU/Linux/x86 and random thread signals (and Solaris/SPARC but not
922 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00336.html
924 Christopher Blizzard writes:
926 So, I've done some more digging into this and it looks like Jim
927 Kingdon has reported this problem in the past:
929 http://sourceware.cygnus.com/ml/bug-gdb/1999-10/msg00058.html
931 I can reproduce this problem both with and without Tom's patch. Has
932 anyone seen this before? Maybe have a solution for it hanging around?
935 There's a test case for this documented at:
937 when debugging threaded applications you get extra SIGTRAPs
938 http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=9565
940 [There should be a GDB testcase - cagney]
944 GDB5 TOT on unixware 7
945 http://sourceware.cygnus.com/ml/gdb/2000-04/msg00119.html
948 > I just spun the top of tree of the GDB5 branch on UnixWare 7. As a
949 > practical matter, the current thread support is somewhat more annoying
950 > than when GDB was thread-unaware.
957 New languages come onto the scene all the time.
961 Re: Various C++ things
963 value_headof/value_from_vtable_info are worthless, and should be
964 removed. The one place in printcmd.c that uses it should use the RTTI
967 RTTI for g++ should be using the typeinfo functions rather than the
968 vtables. The typeinfo functions are always at offset 4 from the
969 beginning of the vtable, and are always right. The vtables will have
970 weird names like E::VB sometimes. The typeinfo function will always
971 be "E type_info function", or somesuch.
973 value_virtual_fn_field needs to be fixed so there are no failures for
974 virtual functions for C++ using g++.
976 Testsuite cases are the major priority right now for C++ support,
977 since i have to make a lot of changes that could potentially break
982 Add support for Modula3
984 Get DEC/Compaq to contribute their Modula-3 support.
988 Remote Protocol Support
989 =======================
993 Revised UDP support (was: Re: [Fwd: [patch] UDP transport support])
994 http://sourceware.cygnus.com/ml/gdb-patches/2000-04/msg00000.html
996 (Broken) support for GDB's remote protocol across UDP is to be
997 included in the follow-on release.
999 It should be noted that UDP can only work when the [Gg] packet fits in
1000 a single UDP packet.
1002 There is also much debate over the merit of this.
1006 Migrate qfThreadInfo packet -> qThreadInfo. (Andrew Cagney)
1008 Add support for packet enable/disable commands with these thread
1009 packets. General cleanup.
1011 [PATCH] Document the ThreadInfo remote protocol queries
1012 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00832.html
1014 [PATCH] "info threads" queries for remote.c
1015 http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00831.html
1019 Remote protocol doco feedback.
1021 Too much feedback to mention needs to be merged in (901660). Search
1022 for the word ``remote''.
1025 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00023.html
1026 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00056.html
1027 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00382.html
1031 GDB doesn't recover gracefully from remote protocol errors.
1033 GDB wasn't checking for NAKs from the remote target. Instead a NAK is
1034 ignored and a timeout is required before GDB retries. A pre-cursor to
1035 fixing this this is making GDB's remote protocol packet more robust.
1037 While downloading to a remote protocol target, gdb ignores packet
1038 errors in so far as it will continue to download with chunk N+1 even
1039 if chunk N was not correctly sent. This causes gdb.base/remote.exp to
1040 take a painfully long time to run. As a PS that test needs to be
1041 fixed so that it builds on 16 bit machines.
1045 Fix the ``!'' packet.
1047 JT reported that the existing targets do, in fact return ``OK'' so it
1048 is possible to merge remote and extended-remote targets.
1052 Drop ``<address>'' from the [SsCc] packets.
1054 I don't think that GDB generates them so having it in the protocol is
1059 Fix doco on the ``q'' packet.
1061 It has evolved into a generic RPC. The notes should reflect this and,
1062 perhaps, the ``Q'' packet can be deprecated.
1064 The doco should mention that ``OK'' is a valid packet response.
1066 The doco should explain why ``OK'' needs to be a valid packet
1071 Add the cycle step command.
1073 http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00237.html
1077 Resolve how to scale things to support very large packets.
1081 Resolve how to handle a target that changes things like its endianess
1082 on the fly - should it be returned in the ``T'' packet?
1084 Underlying problem is that the register file is target endian. If the
1085 target endianess changes gdb doesn't know.
1087 Suggest encoding registers as NN!VALUE.
1091 GDB should allow incomming packets to be larger than outgoing ones. A
1092 fully loaded T packet (containing all registers) can be very large -
1093 definitly larger than a corresponding Gg packet.
1100 If / when GDB starts to support the debugging of multi-processor
1101 (rather than multi-thread) applications the symtab code will need to
1102 be updated a little so that several independent symbol tables are
1103 active at a given time.
1105 The other interesting change is a clarification of the exact meaning
1106 of CORE_ADDR and that has had consequences for a few targets (that
1107 were abusing that data type).
1111 Investiagate ways of reducing memory.
1115 Investigate ways of improving load time.
1119 Get the d10v to use POINTER_TO_ADDRESS and ADDRESS_TO_POINTER.
1121 Consequence of recent symtab clarification. No marks for figuring out
1122 who maintains the d10v.
1126 Get the MIPS to correctly sign extend all address <-> pointer
1129 Consequence of recent symtab clarification. No marks for figuring out
1130 who maintains the MIPS.
1134 GDB truncates 64 bit enums.
1136 http://sourceware.cygnus.com/ml/gdb-patches/2000-06/msg00290.html
1143 There are never to many testcases.
1147 Better thread testsuite.
1151 Better C++ testsuite.
1155 Look at adding a GDB specific testsuite directory so that white box
1156 tests of key internals can be added (eg ui_file).
1160 Separate out tests that involve the floating point (FP).
1162 (Something for people brining up new targets). FP and non-fp tests
1163 are combined. I think there should be set of basic tests that
1164 exercise pure integer support and then a more expanded set that
1165 exercise FP and FP/integer interactions.
1167 As an example, the MIPS, for n32 as problems with passing FP's and
1168 structs. Since most inferior call tests include FP it is difficult to
1169 determine of the integer tests are ok.
1173 Architectural Changes: General
1174 ==============================
1176 These are harder than simple cleanups / fixes and, consequently
1177 involve more work. Typically an Architectural Change will be broken
1178 down into a more digestible set of cleanups and fixes.
1182 Cleanup software single step.
1184 At present many targets implement software single step by directly
1185 blatting memory (see rs6000-tdep.c). Those targets should register
1186 the applicable breakpoints using the breakpoint framework. Perhaphs a
1187 new internal breakpoint class ``step'' is needed.
1191 Replace READ_FP() with FRAME_HANDLE().
1193 READ_FP() is a hangover from the days of the vax when the ABI really
1194 did have a frame pointer register. Modern architectures typically
1195 construct a virtual frame-handle from the stack pointer and various
1196 other bits of string.
1198 Unfortunately GDB still treats this synthetic FP register as though it
1199 is real. That in turn really confuses users (arm and ``print $fp'' VS
1200 ``info registers fp''). The synthetic FP should be separated out of
1201 the true register set presented to the user.
1205 Register Cache Cleanup (below from Andrew Cagney)
1207 I would depict the current register architecture as something like:
1209 High GDB --> Low GDB
1214 register + REGISTER_BYTE(reg_nr)
1217 -------------------------
1218 | extern register[] |
1219 -------------------------
1221 where neither the high (valops.c et.al.) or low gdb (*-tdep.c) are
1222 really clear on what mechanisms they should be using to manipulate that
1223 buffer. Further, much code assumes, dangerously, that registers are
1224 contigious. Having got mips-tdep.c to support multiple ABIs, believe
1225 me, that is a bad assumption. Finally, that register cache layout is
1226 determined by the current remote/local target and _not_ the less
1227 specific target ISA. In fact, in many cases it is determined by the
1228 somewhat arbitrary layout of the [gG] packets!
1231 How I would like the register file to work is more like:
1259 The main objectives being:
1261 o a clear separation between the low
1262 level target and the high level GDB
1264 o a mechanism that solves the general
1265 problem of register aliases, overlaps
1266 etc instead of treating them as optional
1267 extras that can be wedged in as an after
1268 thought (that is a reasonable description
1269 of the current code).
1271 Identify then solve the hard case and the
1272 rest just falls out. GDB solved the easy
1273 case and then tried to ignore the real
1276 o a removal of the assumption that the
1277 mapping between the register cache
1278 and virtual registers is largely static.
1279 If you flip the USR/SSR stack register
1280 select bit in the status-register then
1281 the corresponding stack registers should
1284 o a mechanism that clearly separates the
1285 gdb internal register cache from any
1286 target (not architecture) dependent
1287 specifics such as [gG] packets.
1289 Of course, like anything, it sounds good in theory. In reality, it
1290 would have to contend with many<->many relationships at both the
1291 virt<->cache and cache<->target level. For instance:
1294 Modifying an mmx register may involve
1295 scattering values across both FP and
1296 mmpx specific parts of a buffer
1299 When writing back a SP it may need to
1300 both be written to both SP and USP.
1305 Rather than let this like the last time it was discussed, just slip, I'm
1306 first going to add this e-mail (+ references) to TODO. I'd then like to
1307 sketch out a broad strategy I think could get us there.
1310 First thing I'd suggest is separating out the ``extern registers[]''
1311 code so that we can at least identify what is using it. At present
1312 things are scattered across many files. That way we can at least
1313 pretend that there is a cache instead of a global array :-)
1315 I'd then suggest someone putting up a proposal for the pseudo-reg /
1316 high-level side interface so that code can be adopted to it. For old
1317 code, initially a blanket rename of write_register_bytes() to
1318 deprecated_write_register_bytes() would help.
1320 Following that would, finaly be the corresponding changes to the target.
1324 Check that GDB can handle all BFD architectures (Andrew Cagney)
1326 There should be a test that checks that BFD/GDB are in sync with
1327 regard to architecture changes. Something like a test that first
1328 queries GDB for all supported architectures and then feeds each back
1329 to GDB.. Anyone interested in learning how to write tests? :-)
1333 Architectural Change: Multi-arch et al.
1334 =======================================
1336 The long term objective is to remove all assumptions that there is a
1337 single target with a single address space with a single instruction
1338 set architecture and single application binary interface.
1340 This is an ongoing effort. The first milestone is to enable
1341 ``multi-arch'' where by all architectural decisions are made at
1344 It should be noted that ``gdbarch'' is really ``gdbabi'' and
1345 ``gdbisa''. Once things are multi-arched breaking that down correctly
1346 will become much easier.
1350 GDBARCH cleanup (Andrew Cagney)
1352 The non-generated parts of gdbarch.{sh,h,c} should be separated out
1353 into arch-utils.[hc].
1355 Document that gdbarch_init_ftype could easily fail because it didn't
1356 identify an architecture.
1360 Fix BELIEVE_PPC_PROMOTION. Change it to BELIEVE_PPC_PROMOTION_P?
1362 At present there is still #ifdef BELIEVE_PPC_PROMOTION code in the
1367 Fix target_signal_from_host() etc.
1369 The name is wrong for starters. ``target_signal'' should probably be
1370 ``gdb_signal''. ``from_host'' should be ``from_target_signal''.
1371 After that it needs to be multi-arched and made independent of any
1372 host signal numbering.
1374 Once this is done, the signal enum can probably be moved to
1375 include/gdb so that it is available to embedded stubs.
1379 Update ALPHA so that it uses ``struct frame_extra_info'' instead of
1382 This is a barrier to replacing mips_extra_func_info with something
1383 that works with multi-arch.
1387 Multi-arch mips_extra_func_info.
1389 This first needs the alpha to be updated so that it uses ``struct
1394 Rationalize TARGET_SINGLE_FORMAT and TARGET_SINGLE_BIT et al.
1396 Surely one of them is redundant.
1400 Convert ALL architectures to MULTI-ARCH.
1404 Select the initial multi-arch ISA / ABI based on --target or similar.
1406 At present the default is based on what ever is first in the BFD
1407 archures table. It should be determined based on the ``--target=...''
1412 Make MIPS pure multi-arch.
1414 It is only at the multi-arch enabled stage.
1420 Enable the code to recognize --enable-targets=.... like BINUTILS does.
1422 Can the tm.h and nm.h files be eliminated by multi-arch.
1426 Architectural Change: MI, LIBGDB and scripting languages
1427 ========================================================
1429 See also architectural changes related to the event loop. LIBGDB
1430 can't be finished until there is a generic event loop being used by
1433 The long term objective is it to be possible to integrate GDB into
1434 scripting languages.
1438 Implement generic ``(gdb) commmand > file''
1440 Once everything is going through ui_file it should be come fairly
1443 http://sourceware.cygnus.com/ml/gdb/2000-04/msg00104.html
1447 Replace gdb_stdtarg with gdb_targout (and possibly gdb_targerr).
1449 gdb_stdtarg is easily confused with gdb_stdarg.
1453 Extra ui_file methods - dump.
1455 Very useful for whitebox testing.
1459 Eliminate error_begin().
1461 With ui_file, there is no need for the statefull error_begin ()
1466 Send normal output to gdb_stdout.
1467 Send error messages to gdb_stderror.
1468 Send debug and log output log gdb_stdlog.
1470 GDB still contains many cases where (f)printf or printf_filtered () is
1471 used when it should be sending the messages to gdb_stderror or
1472 gdb_stdlog. The thought of #defining printf to something has crossed
1477 Re-do GDB's output pager.
1479 GDB's output pager still relies on people correctly using *_filtered
1480 for gdb_stdout and *_unfiltered for gdb_stdlog / gdb_stderr.
1481 Hopefully, with all normal output going to gdb_stdout, the pager can
1482 just look at the ui_file that the output is on and then use that to
1483 decide what to do about paging. Sounds good in theory.
1487 Check/cleanup MI documentation.
1489 The list of commands specified in the documentation needs to be
1490 checked against the mi-cmds.c table in a mechanical way (so that they
1491 two can be kept up-to-date).
1495 Convert MI into libgdb
1497 MI provides a text interface into what should be many of the libgdb
1498 functions. The implementation of those functions should be separated
1499 into the MI interface and the functions proper. Those functions being
1500 moved to gdb/lib say.
1506 The first part can already be found in defs.h.
1510 MI's input does not use buffering.
1512 At present the MI interface reads raw characters of from an unbuffered
1513 FD. This is to avoid several nasty buffer/race conditions. That code
1514 should be changed so that it registers its self with the event loop
1515 (on the input FD) and then push commands up to MI as they arrive.
1517 The serial code already does this.
1521 Make MI interface accessible from existing CLI.
1525 Add a breakpoint-edit command to MI.
1527 It would be similar to MI's breakpoint create but would apply to an
1528 existing breakpoint. It saves the need to delete/create breakpoints
1529 when ever they are changed.
1533 Add directory path to MI breakpoint.
1535 That way the GUI's task of finding the file within which the
1536 breakpoint was set is simplified.
1540 Add a mechanism to reject certain expression classes to MI
1542 There are situtations where you don't want GDB's expression
1543 parser/evaluator to perform inferior function calls or variable
1544 assignments. A way of restricting the expression parser so that such
1545 operations are not accepted would be very helpful.
1549 Remove sideffects from libgdb breakpoint create function.
1551 The user can use the CLI to create a breakpoint with partial
1552 information - no file (gdb would use the file from the last
1555 The libgdb interface currently affects that environment which can lead
1556 to confusion when a user is setting breakpoints via both the MI and
1559 This is also a good example of how getting the CLI ``right'' will be
1564 Move gdb_lasterr to ui_out?
1566 The way GDB throws errors and records them needs a re-think. ui_out
1567 handles the correct output well. It doesn't resolve what to do with
1568 output / error-messages when things go wrong.
1572 do_setshow_command contains a 1024 byte buffer.
1574 The function assumes that there will never be any more than 1024 bytes
1575 of enum. It should use mem_file.
1579 Should struct cmd_list_element . completer take the command as an
1584 Should the bulk of top.c:line_completion_function() be moved to
1585 command.[hc]? complete_on_cmdlist() and complete_on_enums() could
1586 then be made private.
1590 top.c (execute_command): Should a command being valid when the target
1591 is running be made an attribute (predicate) to the command rather than
1592 an explicit set of tests.
1596 top.c (execute_command): Should the bulk of this function be moved
1597 into command.[hc] so that top.c doesn't grub around in the command
1602 Architectural Change: Async
1603 ===========================
1605 While GDB uses an event loop when prompting the user for input. That
1606 event loop is not exploited by targets when they allow the target
1607 program to continue. Typically targets still block in (target_wait())
1608 until the program again halts.
1610 The closest a target comes to supporting full asynchronous mode are
1611 the remote targets ``async'' and ``extended-async''.
1615 Asynchronous expression evaluator
1617 Inferior function calls hang GDB.
1621 Fix implementation of ``target xxx''.
1623 At present when the user specifies ``target xxxx'', the CLI maps that
1624 directly onto a target open method. It is then assumed that the
1625 target open method should do all sorts of complicated things as this
1626 is the only chance it has. Check how the various remote targets
1627 duplicate the target operations. Check also how the various targets
1628 behave differently for purely arbitrary reasons.
1630 What should happen is that ``target xxxx'' should call a generic
1631 ``target'' function and that should then co-ordinate the opening of
1632 ``xxxx''. This becomes especially important when you're trying to
1633 open an asynchronous target that may need to perform background tasks
1634 as part of the ``attach'' phase.
1636 Unfortunately, due to limitations in the old/creaking command.h
1637 interface, that isn't possible. The function being called isn't told
1638 of the ``xxx'' or any other context information.
1640 Consequently a precursor to fixing ``target xxxx'' is to clean up the
1641 CLI code so that it passes to the callback function (attatched to a
1642 command) useful information such as the actual command and a context
1643 for that command. Other changes such as making ``struct command''
1644 opaque may also help.
1647 http://sourceware.cygnus.com/ml/gdb-patches/2000-06/msg00062.html
1651 Make "target xxx" command interruptible.
1653 As things become async this becomes possible. A target would start
1654 the connect and then return control to the event loop. A cntrl-c
1655 would notify the target that the operation is to be abandoned and the
1656 target code could respond.
1660 Add a "suspend" subcommand of the "continue" command to suspend gdb
1661 while continuing execution of the subprocess. Useful when you are
1662 debugging servers and you want to dodge out and initiate a connection
1663 to a server running under gdb.
1672 Frequently requested but not approved requests.
1676 Eliminate unused argument warnings using ATTRIBUTE_UNUSED.
1678 The benefits on this one are thought to be marginal - GDBs design
1679 means that unused parameters are very common. GCC 3.0 will also
1680 include the option -Wno-unused-parameter which means that ``-Wall
1681 -Wno-unused-parameters -Werror'' can be specified.
1690 This list is not up to date, and opinions vary about the importance or
1691 even desirability of some of the items. If you do fix something, it
1692 always pays to check the below.
1696 @c This does not work (yet if ever). FIXME.
1697 @c @item --parse=@var{lang} @dots{}
1698 @c Configure the @value{GDBN} expression parser to parse the listed languages.
1699 @c @samp{all} configures @value{GDBN} for all supported languages. To get a
1700 @c list of all supported languages, omit the argument. Without this
1701 @c option, @value{GDBN} is configured to parse all supported languages.
1705 START_INFERIOR_TRAPS_EXPECTED need never be defined to 2, since that
1706 is its default value. Clean this up.
1710 It should be possible to use symbols from shared libraries before we know
1711 exactly where the libraries will be loaded. E.g. "b perror" before running
1712 the program. This could maybe be done as an extension of the "breakpoint
1713 re-evaluation" after new symbols are loaded.
1717 Make single_step() insert and remove breakpoints in one operation.
1719 [If this is talking about having single_step() insert the breakpoints,
1720 run the target then pull the breakpoints then it is wrong. The
1721 function has to return as control has to eventually be passed back to
1722 the main event loop.]
1726 Speed up single stepping by avoiding extraneous ptrace calls.
1730 Speed up single stepping by not inserting and removing breakpoints
1731 each time the inferior starts and stops.
1733 Breakpoints should not be inserted and deleted all the time. Only the
1734 one(s) there should be removed when we have to step over one. Support
1735 breakpoints that don't have to be removed to step over them.
1737 [this has resulted in numerous debates. The issue isn't clear cut]
1741 Provide "voodoo" debugging of core files. This creates a zombie
1742 process as a child of the debugger, and loads it up with the data,
1743 stack, and regs of the core file. This allows you to call functions
1744 in the executable, to manipulate the data in the core file.
1750 GDB reopens the source file on every line, as you "next" through it.
1752 [still true? I've a memory of this being fixed]
1756 Perhaps "i source" should take an argument like that of "list".
1760 Remove "at 0xnnnn" from the "b foo" response, if `print address off' and if
1761 it matches the source line indicated.
1765 The prompt at end of screen should accept space as well as CR.
1769 Backtrace should point out what the currently selected frame is, in
1770 its display, perhaps showing "@3 foo (bar, ...)" or ">3 foo (bar,
1771 ...)" rather than "#3 foo (bar, ...)".
1775 "i program" should work for core files, and display more info, like what
1776 actually caused it to die.
1780 "x/10i" should shorten the long name, if any, on subsequent lines.
1784 "next" over a function that longjumps, never stops until next time you happen
1785 to get to that spot by accident. E.g. "n" over execute_command which has
1790 "set zeroprint off", don't bother printing members of structs which
1791 are entirely zero. Useful for those big structs with few useful
1796 GDB does four ioctl's for every command, probably switching terminal modes
1797 to/from inferior or for readline or something.
1801 terminal_ours versus terminal_inferior: cache state. Switch should be a noop
1802 if the state is the same, too.
1806 "i frame" shows wrong "arglist at" location, doesn't show where the args
1807 should be found, only their actual values.
1811 There should be a way for "set" commands to validate the new setting
1812 before it takes effect.
1816 "ena d" is ambiguous, why? "ena delete" seems to think it is a command!
1820 i line VAR produces "Line number not known for symbol ``var''.". I
1821 thought we were stashing that info now!
1825 We should be able to write to random files at hex offsets like adb.
1829 [elena - delete this]
1831 Handle add_file with separate text, data, and bss addresses. Maybe
1832 handle separate addresses for each segment in the object file?
1836 [Jimb/Elena delete this one]
1838 Handle free_named_symtab to cope with multiply-loaded object files
1839 in a dynamic linking environment. Should remember the last copy loaded,
1840 but not get too snowed if it finds references to the older copy.
1844 [elena delete this also]
1846 Remove all references to:
1853 now that we have BFD. All remaining are in machine dependent files.
1857 Re-organize help categories into things that tend to fit on a screen
1862 Add in commands like ADB's for searching for patterns, etc. We should
1863 be able to examine and patch raw unsymboled binaries as well in gdb as
1864 we can in adb. (E.g. increase the timeout in /bin/login without source).
1866 [actually, add ADB interface :-]
1870 When doing "step" or "next", if a few lines of source are skipped between
1871 the previous line and the current one, print those lines, not just the
1872 last line of a multiline statement.
1876 Handling of "&" address-of operator needs some serious overhaul
1877 for ANSI C and consistency on arrays and functions.
1878 For "float point[15];":
1879 ptype &point[4] ==> Attempt to take address of non-lvalue.
1880 For "char *malloc();":
1881 ptype malloc ==> "char *()"; should be same as
1882 ptype &malloc ==> "char *(*)()"
1883 call printf ("%x\n", malloc) ==> weird value, should be same as
1884 call printf ("%x\n", &malloc) ==> correct value
1888 Fix dbxread.c symbol reading in the presence of interrupts. It
1889 currently leaves a cleanup to blow away the entire symbol table when a
1890 QUIT occurs. (What's wrong with that? -kingdon, 28 Oct 1993).
1892 [I suspect that the grype was that, on a slow system, you might want
1893 to cntrl-c and get just half the symbols and then load the rest later
1894 - scary to be honest]
1898 Mipsread.c reads include files depth-first, because the dependencies
1899 in the psymtabs are way too inclusive (it seems to me). Figure out what
1900 really depends on what, to avoid recursing 20 or 30 times while reading
1905 value_add() should be subtracting the lower bound of arrays, if known,
1906 and possibly checking against the upper bound for error reporting.
1910 When listing source lines, check for a preceding \n, to verify that
1911 the file hasn't changed out from under us.
1913 [fixed by some other means I think. That hack wouldn't actually work
1914 reliably - the file might move such that another \n appears. ]
1918 Get all the remote systems (where the protocol allows it) to be able to
1919 stop the remote system when the GDB user types ^C (like remote.c
1920 does). For ebmon, use ^Ak.
1924 Possible feature: A version of the "disassemble" command which shows
1925 both source and assembly code ("set symbol-filename on" is a partial
1928 [has this been done? It was certainly done for MI and GDBtk]
1932 investigate "x/s 0" (right now stops early) (I think maybe GDB is
1933 using a 0 address for bad purposes internally).
1937 Make "info path" and path_command work again (but independent of the
1938 environment either of gdb or that we'll pass to the inferior).
1942 Make GDB understand the GCC feature for putting octal constants in
1943 enums. Make it so overflow on an enum constant does not error_type
1944 the whole type. Allow arbitrarily large enums with type attributes.
1945 Put all this stuff in the testsuite.
1949 Make TYPE_CODE_ERROR with a non-zero TYPE_LENGTH more useful (print
1950 the value in hex; process type attributes). Add this to the
1951 testsuite. This way future compilers can add new types and old
1952 versions of GDB can do something halfway reasonable.
1956 Fix mdebugread.c:parse_type to do fundamental types right (see
1957 rs6000_builtin_type in stabsread.c for what "right" is--the point is
1958 that the debug format fixes the sizes of these things and it shouldn't
1959 depend on stuff like TARGET_PTR_BIT and so on. For mdebug, there seem
1960 to be separate bt* codes for 64 bit and 32 bit things, and GDB should
1961 be aware of that). Also use a switch statement for clarity and speed.
1965 Investigate adding symbols in target_load--some targets do, some
1970 Put dirname in psymtabs and change lookup*symtab to use dirname (so
1971 /foo/bar.c works whether compiled by cc /foo/bar.c, or cd /foo; cc
1976 Merge xcoffread.c and coffread.c. Use breakpoint_re_set instead of
1981 Make a watchpoint which contains a function call an error (it is
1982 broken now, making it work is probably not worth the effort).
1986 New test case based on weird.exp but in which type numbers are not
1987 renumbered (thus multiply defining a type). This currently causes an
1988 infinite loop on "p v_comb".
1992 [Hey! Hint Hint Delete Delete!!!]
1994 Fix 386 floating point so that floating point registers are real
1995 registers (but code can deal at run-time if they are missing, like
1996 mips and 68k). This would clean up "info float" and related stuff.
2000 gcc -g -c enummask.c then gdb enummask.o, then "p v". GDB complains
2001 about not being able to access memory location 0.
2003 -------------------- enummask.c
2024 If try to modify value in file with "set write off" should give
2025 appropriate error not "cannot access memory at address 0x65e0".
2029 Allow core file without exec file on RS/6000.
2033 Make sure "shell" with no arguments works right on DOS.
2037 Make gdb.ini (as well as .gdbinit) be checked on all platforms, so
2038 the same directory can be NFS-mounted on unix or DOS, and work the
2043 [Is this another delete???]
2045 Get SECT_OFF_TEXT stuff out of objfile_relocate (might be needed to
2046 get RS/6000 to work right, might not be immediately relevant).
2050 Work out some kind of way to allow running the inferior to be done as
2051 a sub-execution of, eg. breakpoint command lists. Currently running
2052 the inferior interupts any command list execution. This would require
2053 some rewriting of wait_for_inferior & friends, and hence should
2054 probably be done in concert with the above.
2058 Add function arguments to gdb user defined functions.
2062 Add convenience variables that refer to exec file, symbol file,
2063 selected frame source file, selected frame function, selected frame
2068 Modify the handling of symbols grouped through BINCL/EINCL stabs to
2069 allocate a partial symtab for each BINCL/EINCL grouping. This will
2070 seriously decrease the size of inter-psymtab dependencies and hence
2071 lessen the amount that needs to be read in when a new source file is
2076 Add a command for searching memory, a la adb. It specifies size,
2077 mask, value, start address. ADB searches until it finds it or hits
2078 an error (or is interrupted).
2082 Remove the range and type checking code and documentation, if not