libctf/ChangeLog

   1 2019-08-09  Nick Alcock  <[email protected]>
   2
   3         * ctf-impl.h (ctf_names_t): New.
   4         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
   5         (ctf_file_t) <ctf_structs>: Likewise.
   6         <ctf_unions>: Likewise.
   7         <ctf_enums>: Likewise.
   8         <ctf_names>: Likewise.
   9         <ctf_lookups>: Improve comment.
  10         <ctf_ptrtab_len>: New.
  11         <ctf_prov_strtab>: New.
  12         <ctf_str_prov_offset>: New.
  13         <ctf_dtbyname>: Remove, redundant to the names hashes.
  14         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
  15         (ctf_dtdef_t) <dtd_name>: Remove.
  16         <dtd_data>: Note that the ctt_name is now populated.
  17         (ctf_str_atom_t) <csa_offset>: This is now the strtab
  18         offset for internal strings too.
  19         <csa_external_offset>: New, the external strtab offset.
  20         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
  21         (ctf_name_table): New declaration.
  22         (ctf_lookup_by_rawname): Likewise.
  23         (ctf_lookup_by_rawhash): Likewise.
  24         (ctf_set_ctl_hashes): Likewise.
  25         (ctf_serialize): Likewise.
  26         (ctf_dtd_insert): Adjust.
  27         (ctf_simple_open_internal): Likewise.
  28         (ctf_bufopen_internal): Likewise.
  29         (ctf_list_empty_p): Likewise.
  30         (ctf_str_remove_ref): Likewise.
  31         (ctf_str_add): Returns uint32_t now.
  32         (ctf_str_add_ref): Likewise.
  33         (ctf_str_add_external): Now returns a boolean (int).
  34         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
  35         for strings in the appropriate range.
  36         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
  37         when adding the null string to the new strtab.
  38         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
  39         (ctf_str_add_ref_internal): Add make_provisional argument.  If
  40         make_provisional, populate the offset and fill in the
  41         ctf_prov_strtab accordingly.
  42         (ctf_str_add): Return the offset, not the string.
  43         (ctf_str_add_ref): Likewise.
  44         (ctf_str_add_external): Return a success integer.
  45         (ctf_str_remove_ref): New, remove a single ref.
  46         (ctf_str_count_strtab): Do not count the initial null string's
  47         length or the existence or length of any unreferenced internal
  48         atoms.
  49         (ctf_str_populate_sorttab): Skip atoms with no refs.
  50         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
  51         to the cts_len for the null string, since it is no longer done
  52         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
  53         Populate the csa_offset for both internal and external cases.
  54         Flush the ctf_prov_strtab afterwards, and reset the
  55         ctf_str_prov_offset.
  56         * ctf-create.c (ctf_grow_ptrtab): New.
  57         (ctf_create): Call it.  Initialize new fields rather than old
  58         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
  59         Set the ctl hashes and data model.
  60         (ctf_update): Rename to...
  61         (ctf_serialize): ... this.  Leave a compatibility function behind.
  62         Tell ctf_simple_open_internal that this is a writable dictionary.
  63         Pass the new fields along from the old dictionary.  Drop
  64         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
  65         Do not zero out the DTD's ctt_name.
  66         (ctf_prefixed_name): Rename to...
  67         (ctf_name_table): ... this.  No longer return a prefixed name: return
  68         the applicable name table instead.
  69         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
  70         kind we're adding.  Migrate away from dtd_name.
  71         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
  72         deleted ctt_name.
  73         (ctf_dtd_lookup_type_by_name): Remove.
  74         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
  75         No longer check ctf_dtnextid: check ctf_typemax instead.
  76         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
  77         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
  78         ctf_name_table and the right name table, and migrate away from
  79         dtd_name as in ctf_dtd_delete.
  80         (ctf_add_generic): Pass in the kind explicitly and pass it to
  81         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
  82         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
  83         Grow the ptrtab if needed.
  84         (ctf_add_encoded): Pass in the kind.
  85         (ctf_add_slice): Likewise.
  86         (ctf_add_array): Likewise.
  87         (ctf_add_function): Likewise.
  88         (ctf_add_typedef): Likewise.
  89         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
  90         ctt_name rather than dtd_name.
  91         (ctf_add_struct_sized): Pass in the kind.  Use
  92         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
  93         ctf_dtd_lookup_type_by_name.
  94         (ctf_add_union_sized): Likewise.
  95         (ctf_add_enum): Likewise.
  96         (ctf_add_enum_encoded): Likewise.
  97         (ctf_add_forward): Likewise.
  98         (ctf_add_type): Likewise.
  99         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 100         being initialized until after the call.
 101         (ctf_write_mem): Likewise.
 102         (ctf_write): Likewise.
 103         * ctf-archive.c (arc_write_one_ctf): Likewise.
 104         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 105         ctf_hash_lookup_type.
 106         (ctf_lookup_by_id): No longer check the readonly types if the
 107         dictionary is writable.
 108         * ctf-open.c (init_types): Assert that this dictionary is not
 109         writable.  Adjust to use the new name hashes, ctf_name_table,
 110         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 111         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 112         if set.  Drop out early when dictionary is writable.  Split the
 113         ctf_lookups initialization into...
 114         (ctf_set_cth_hashes): ... this new function.
 115         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 116         (ctf_simple_open): Adjust accordingly.
 117         (ctf_bufopen): Likewise.
 118         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 119         destroy ctf_dtbyname, which is gone.
 120         (ctf_getdatasect): Remove spurious "extern".
 121         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 122         specified name table, given a kind.
 123         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 124         (ctf_member_iter): Add support for iterating over the
 125         dynamic type list.
 126         (ctf_enum_iter): Likewise.
 127         (ctf_variable_iter): Likewise.
 128         (ctf_type_rvisit): Likewise.
 129         (ctf_member_info): Add support for types in the dynamic type list.
 130         (ctf_enum_name): Likewise.
 131         (ctf_enum_value): Likewise.
 132         (ctf_func_type_info): Likewise.
 133         (ctf_func_type_args): Likewise.
 134         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 135         ctf_update.
 136         (ctf_link_write): Likewise.
 137         (ctf_link_intern_extern_string): Adjust for new
 138         ctf_str_add_external return value.
 139         (ctf_link_add_strtab): Likewise.
 140         * ctf-util.c (ctf_list_empty_p): New.
 141
 142 2019-08-05  Nick Alcock  <[email protected]>
 143
 144         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 145         type zero.
 146         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 147         members and types.
 148         (ctf_add_variable): Likewise for variables pointing to them.
 149         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 150         type link failure, but do warn for others.
 151         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 152         errors to be ENOMEM.
 153         (ctf_dump_member): Likewise.
 154         (ctf_dump_type): Likewise.
 155         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 156         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 157         (ctf_dump_header): Likewise.
 158         (ctf_dump_label): likewise.
 159         (ctf_dump_objts): likewise.
 160         (ctf_dump_funcs): likewise.
 161         (ctf_dump_var): likewise.
 162         (ctf_dump_str): Likewise.
 163
 164 2019-09-30  Nick Alcock  <[email protected]>
 165
 166         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 167         (LT_INIT): Likewise.
 168         (AM_INSTALL_LIBBFD): Likewise.
 169         (dlopen): Note why this is necessary in a comment.
 170         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 171         opcodes/.
 172         (SHARED_LDFLAGS): Likewise.
 173         (BFD_LIBADD): Likewise, for libbfd.
 174         (BFD_DEPENDENCIES): Likewise.
 175         (VERSION_FLAGS): Initialize, using a version script if ld supports
 176         one, or libtool -export-symbols-regex otherwise.
 177         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 178         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 179         (INCDIR): New.
 180         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 181         (noinst_LIBRARIES): Replace with...
 182         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 183         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 184         libctf-nobfd.la as well.
 185         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 186         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 187         (libctf_a_SOURCES): Rename to...
 188         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 189         ctf-open-bfd.c.
 190         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 191         with ctf-open-bfd.c added.
 192         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 193         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 194         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 195         * Makefile.am [INSTALL_LIBCTF]: Use it.
 196         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 197         libtool macros.
 198         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 199         the unstable components).
 200         * Makefile.in: Regenerated.
 201         * config.h.in: Likewise.
 202         * configure: Likewise.
 203
 204 2019-07-30  Nick Alcock  <[email protected]>
 205
 206         * configure.ac (INSTALL_LIBCTF): New, controlled by
 207         --enable-install-libctf.
 208         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 209         * Makefile.in: Regenerated.
 210         * configure: Regenerated.
 211
 212 2019-07-30  Nick Alcock  <[email protected]>
 213
 214         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 215         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 216
 217 2019-07-30  Nick Alcock  <[email protected]>
 218
 219         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 220
 221 2019-07-13  Nick Alcock  <[email protected]>
 222
 223         * ctf-impl.h (includes): Include <sys/param.h> here.
 224
 225 2019-07-30  Nick Alcock  <[email protected]>
 226
 227         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 228         (flip_objts): Likewise.
 229         (flip_vars): Likewise.
 230         (flip_types): Likewise.
 231
 232 2019-07-30  Nick Alcock  <[email protected]>
 233
 234         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 235         freeing functions: if set, free the key and value if the slot
 236         already exists.  Always reassign the key.
 237         (ctf_dynhash_insert): Adjust call appropriately.
 238         (ctf_hash_insert_type): Likewise.
 239
 240 2019-08-03  Nick Alcock  <[email protected]>
 241
 242         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 243         type kind.  Allow forwards to unify with pre-existing structs/
 244         unions/enums.
 245
 246 2019-07-30  Nick Alcock  <[email protected]>
 247
 248         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 249         <ctf_link_memb_name_changer>: Likewise.
 250         <ctf_link_memb_name_changer_arg>: Likewise.
 251         * ctf-create.c (ctf_update): Update accordingly.
 252         * ctf-open.c (ctf_file_close): Likewise.
 253         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 254         (ctf_link_add_cu_mapping): New.
 255         (ctf_link_set_memb_name_changer): Likewise.
 256         (ctf_change_parent_name): New.
 257         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 258         allocated by the caller's ctf_link_memb_name_changer.
 259         <ndynames>: Likewise.
 260         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 261         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 262         ctf_change_parent_name.  Free any resulting names.
 263
 264 2019-07-13  Nick Alcock  <[email protected]>
 265
 266         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 267         (ctf_link_one_type): ... here, with parent-name setting added.
 268         (check_variable): New.
 269         (ctf_link_one_variable): Likewise.
 270         (ctf_link_one_input_archive_member): Call it.
 271         * ctf-error.c (_ctf_errlist): Updated with new errors.
 272
 273 2019-07-13  Nick Alcock  <[email protected]>
 274
 275         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 276         (struct ctf_link_type_mapping_key): New.
 277         (ctf_hash_type_mapping_key): Likewise.
 278         (ctf_hash_eq_type_mapping_key): Likewise.
 279         (ctf_add_type_mapping): Likewise.
 280         (ctf_type_mapping): Likewise.
 281         (ctf_dynhash_empty): Likewise.
 282         * ctf-open.c (ctf_file_close): Update accordingly.
 283         * ctf-create.c (ctf_update): Likewise.
 284         (ctf_add_type): Populate the mapping.
 285         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 286         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 287         (ctf_dynhash_insert): Fix comment typo.
 288         (ctf_dynhash_empty): New.
 289         * ctf-link.c (ctf_add_type_mapping): New.
 290         (ctf_type_mapping): Likewise.
 291         (empty_link_type_mapping): New.
 292         (ctf_link_one_input_archive): Call it.
 293
 294 2019-07-13  Nick Alcock  <[email protected]>
 295
 296         * ctf-link.c: New file, linking of the string and type sections.
 297         * Makefile.am (libctf_a_SOURCES): Add it.
 298         * Makefile.in: Regenerate.
 299
 300         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 301         ctf_link_outputs.
 302         * ctf-create.c (ctf_update): Update accordingly.
 303         * ctf-open.c (ctf_file_close): Likewise.
 304         * ctf-error.c (_ctf_errlist): Updated with new errors.
 305
 306 2019-07-13  Nick Alcock  <[email protected]>
 307
 308         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 309
 310 2019-07-13  Nick Alcock  <[email protected]>
 311
 312         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 313         ctf_type_iter.
 314         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 315         (ctf_dump_format_type): Add non-root-type { } notation.
 316         Add root flag to prototype.
 317         (ctf_dump_label): Adjust accordingly.
 318         (ctf_dump_objts): Likewise.
 319         (ctf_dump_var): Likewise.
 320
 321 2019-07-13  Nick Alcock  <[email protected]>
 322
 323         * ctf-create.c (ctf_compress_write): Fix double-free.
 324
 325 2019-07-13  Nick Alcock  <[email protected]>
 326
 327         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 328         of...
 329         (ctf_arc_write_fd): ... this new function.
 330         * ctf-create.c (ctf_write_mem): New.
 331
 332 2019-07-13  Nick Alcock  <[email protected]>
 333
 334         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 335         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 336         (ctf_str_add_ref): Name the last arg.
 337         (ctf_str_add_external) New.
 338         (ctf_str_add_strraw_explicit): Likewise.
 339         (ctf_simple_open_internal): Likewise.
 340         (ctf_bufopen_internal): Likewise.
 341
 342         * ctf-string.c (ctf_strraw_explicit): Split from...
 343         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 344         (ctf_str_add_ref_internal): Return the atom, not the
 345         string.
 346         (ctf_str_add): Adjust accordingly.
 347         (ctf_str_add_ref): Likewise.  Move up in the file.
 348         (ctf_str_add_external): New: update the csa_offset.
 349         (ctf_str_count_strtab): Only account for strings with no csa_offset
 350         in the internal strtab length.
 351         (ctf_str_write_strtab): If the csa_offset is set, update the
 352         string's refs without writing the string out, and update the
 353         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 354         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 355         (ctf_update): Handle failure to populate the strtab.  Pass in the
 356         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 357         Call ctf_simple_open_internal, not ctf_simple_open.
 358         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 359         strings by hand.
 360         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 361         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 362         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 363         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 364         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 365         (ctf_simple_open_internal): ... this new function, which calls
 366         ctf_bufopen_internal.
 367         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 368         (ctf_bufopen_internal): ... this new function, which sets
 369         ctf_syn_ext_strtab.
 370
 371 2019-07-13  Nick Alcock  <[email protected]>
 372
 373         * ctf_types.c (ctf_type_iter_all): New.
 374
 375 2019-07-13  Nick Alcock  <[email protected]>
 376
 377         * ctf-open.c (init_symtab): Check for overflow against the right
 378         section.
 379         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 380         (upgrade_types_v1): Note that these sections are not checked.
 381         (flip_header): Endian-swap the header fields.
 382         (flip_ctf): Endian-swap the sections.
 383         (flip_objts): Update comment.
 384         (ctf_bufopen): Check header offsets and alignment for validity.
 385
 386 2019-07-13  Nick Alcock  <[email protected]>
 387
 388         * ctf-open-bfd.c: Add <assert.h>.
 389         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 390         techniques borrowed from bfd_elf_sym_name.
 391         (ctf_new_archive_internal): Improve comment.
 392         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 393         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 394         no symbol section, but not vice versa.
 395
 396 2019-07-08  Nick Alcock  <[email protected]>
 397
 398         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 399         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 400         * ctf-dump.c (dump_header): New function, dump the CTF header.
 401         (ctf_dump): Call it.
 402         (ctf_dump_header_strfield): New function.
 403         (ctf_dump_header_sectfield): Likewise.
 404
 405 2019-07-06  Nick Alcock  <[email protected]>
 406
 407         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 408         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 409         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 410         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 411         Print out ctf_cuname: only print out ctf_parname if set.
 412         (ctf_free_base): Removed, ctf_base is no longer freed: free
 413         ctf_dynbase instead.
 414         (ctf_set_version): Fix spacing.
 415         (upgrade_header): New, in-place header upgrading.
 416         (upgrade_types): Rename to...
 417         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 418         longer track old and new headers separately.  No longer allow for
 419         header sizes explicitly: squeeze the headers out on upgrade (they
 420         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 421         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 422         (upgrade_types): New, also handle ctf_parmax updating.
 423         (flip_header): Flip ctf_cuname.
 424         (flip_types): Flip BUF explicitly rather than deriving BUF from
 425         BASE.
 426         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 427         required alignment of objtoff and funcoff.  No longer store it in
 428         the ctf_buf unless that buf is derived unmodified from the input.
 429         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 430         that duplicate fields in ctf_file: move allocation of ctf_file
 431         further up instead.  Call upgrade_header as needed.  Move
 432         version-specific ctf_parmax initialization into upgrade_types.  More
 433         concise error handling.
 434         (ctf_file_close): No longer test for null pointers before freeing.
 435         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 436         ctf_free_base.
 437         (ctf_cuname): New.
 438         (ctf_cuname_set): New.
 439         * ctf-create.c (ctf_update): Populate ctf_cuname.
 440         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 441         comment.
 442         (ctf_write): Likewise.
 443         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 444         Fix the compression length: fp->ctf_size never counted the CTF
 445         header.  Simplify the compress call accordingly.
 446
 447 2019-07-11  Hans-Peter Nilsson  <[email protected]>
 448
 449         * ctf-endian.h: Don't assume htole64 and le64toh are always
 450         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 451         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 452         not bswap_identity_64.
 453
 454 2019-09-18  Alan Modra  <[email protected]>
 455
 456         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 457
 458 2019-09-09  Phil Blundell  <[email protected]>
 459
 460         binutils 2.33 branch created.
 461
 462 2019-07-18  Nick Alcock  <[email protected]>
 463
 464         * ctf-types.c (ctf_type_aname_raw): New.
 465         (ctf_func_type_info): Likewise.
 466         (ctf_func_type_args): Likewise.
 467         * ctf-error.c (_ctf_errlist): Fix description.
 468         * ctf-lookup.c: Fix file description.
 469
 470 2019-06-28  Nick Alcock  <[email protected]>
 471
 472         * ctf-create.c (ctf_create): Fix off-by-one error.
 473
 474 2019-06-28  Nick Alcock  <[email protected]>
 475
 476         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 477         struct ctf_strs.
 478         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 479         (struct ctf_str_atom): New, disambiguated single string.
 480         (struct ctf_str_atom_ref): New, points to some other location that
 481         references this string's offset.
 482         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 483         Remove member ctf_dtvstrlen: we no longer track the total strlen
 484         as we add strings.
 485         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 486         (ctf_str_free_atoms): Likewise.
 487         (ctf_str_add): Likewise.
 488         (ctf_str_add_ref): Likewise.
 489         (ctf_str_rollback): Likewise.
 490         (ctf_str_purge_refs): Likewise.
 491         (ctf_str_write_strtab): Likewise.
 492         (ctf_realloc): Declare new function in ctf-util.c.
 493
 494         * ctf-open.c (ctf_bufopen): Create the atoms table.
 495         (ctf_file_close): Destroy it.
 496         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 497         special-case the position of the parname string.  Construct the
 498         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 499         rest of each buffer element is constructed, not via open-coding:
 500         realloc the CTF buffer and append the strtab to it.  No longer
 501         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 502         strtab construction.
 503         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 504         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 505         after buffer element construction instead.
 506         (ctf_copy_lmembers): Likewise.
 507         (ctf_copy_emembers): Likewise.
 508         (ctf_create): No longer maintain the ctf_dtvstrlen.
 509         (ctf_dtd_delete): Likewise.
 510         (ctf_dvd_delete): Likewise.
 511         (ctf_add_generic): Likewise.
 512         (ctf_add_enumerator): Likewise.
 513         (ctf_add_member_offset): Likewise.
 514         (ctf_add_variable): Likewise.
 515         (membadd): Likewise.
 516         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 517         if there are active ctf_str_num_refs.
 518         (ctf_strraw): Move to ctf-string.c.
 519         (ctf_strptr): Likewise.
 520         * ctf-string.c: New file, strtab manipulation.
 521
 522         * Makefile.am (libctf_a_SOURCES): Add it.
 523         * Makefile.in: Regenerate.
 524
 525 2019-06-28  Nick Alcock  <[email protected]>
 526
 527         * ctf-impl.h (ctf_hash_iter_f): New.
 528         (ctf_dynhash_iter): New declaration.
 529         (ctf_dynhash_iter_remove): New declaration.
 530         * ctf-hash.c (ctf_dynhash_iter): Define.
 531         (ctf_dynhash_iter_remove): Likewise.
 532         (ctf_hashtab_traverse): New.
 533         (ctf_hashtab_traverse_remove): Likewise.
 534         (struct ctf_traverse_cb_arg): Likewise.
 535         (struct ctf_traverse_remove_cb_arg): Likewise.
 536
 537 2019-06-28  Nick Alcock  <[email protected]>
 538
 539         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 540
 541 2019-06-28  Nick Alcock  <[email protected]>
 542
 543         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 544         (ctf_dump_funcs): Likewise.
 545
 546 2019-06-19  Nick Alcock  <[email protected]>
 547
 548         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 549         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 550         little-endian CTF archive magic.  Do not check the CTF version:
 551         ctf_simple_open does that in endian-safe ways.  Do not dereference
 552         null pointers on open failure.
 553
 554 2019-06-19  Nick Alcock  <[email protected]>
 555
 556         * ctf-open.c (get_vbytes_common): Return the new slice size.
 557         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 558         Remember to copy in the CTF data when opening an uncompressed
 559         foreign-endian CTF file.  Prune useless variable manipulation.
 560
 561 2019-06-19  Nick Alcock  <[email protected]>
 562
 563         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 564         seen.
 565
 566 2019-06-19  Nick Alcock  <[email protected]>
 567
 568         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 569         output.
 570
 571 2019-06-19  Nick Alcock  <[email protected]>
 572
 573         * ctf-subr.c (_PAGESIZE): Remove.
 574         (ctf_data_alloc): Likewise.
 575         (ctf_data_free): Likewise.
 576         (ctf_data_protect): Likewise.
 577         * ctf-impl.h: Remove declarations.
 578         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 579         ctf_free, not ctf_data_free.
 580         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 581         the buffer again on compression error.
 582         * ctf-open.c (ctf_set_base): No longer track the size: call
 583         ctf_free, not ctf_data_free.
 584         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 585         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 586
 587 2019-06-19  Nick Alcock  <[email protected]>
 588
 589         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 590         ctf_dynhash_insert.
 591         (ctf_dvd_insert): Likewise.
 592         (ctf_add_generic): Likewise.
 593         (ctf_add_variable): Likewise.
 594         * ctf-impl.h: Adjust declarations.
 595
 596 2019-06-14  Alan Modra  <[email protected]>
 597
 598         * configure: Regenerate.
 599
 600 2019-06-06  Nick Alcock  <[email protected]>
 601
 602         * ctf-decls.h: Include <libiberty.h>.
 603         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 604
 605 2019-06-06  Nick Alcock  <[email protected]>
 606
 607         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 608         (ctf_dump_objts): Likewise.
 609         (ctf_dump_funcs): Likewise.
 610         (ctf_dump_member): Likewise.
 611         (ctf_dump_str): Likewise.
 612
 613 2019-06-06  Nick Alcock  <[email protected]>
 614
 615         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 616         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 617
 618 2019-06-05  Nick Alcock  <[email protected]>
 619
 620         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 621         (ctf_arc_open_by_offset): Likewise.
 622         * ctf-create.c (ctf_add_type): Likewise.
 623
 624 2019-06-04  Tom Tromey  <[email protected]>
 625
 626         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 627         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 628
 629 2019-06-04  Nick Alcock  <[email protected]>
 630
 631         * configure.ac: Check for O_CLOEXEC.
 632         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 633         * config.h.in: Regenerate.
 634         * configure: Likewise.
 635
 636 2019-06-04  Nick Alcock  <[email protected]>
 637
 638         * qsort_r.c: Rename to...
 639         * ctf-qsort_r.c: ... this.
 640         (_quicksort): Define to ctf_qsort_r.
 641         * ctf-decls.h (qsort_r): Remove.
 642         (ctf_qsort_r): Add.
 643         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 644         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 645         * Makefile.am (libctf_a_LIBADD): Remove.
 646         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 647         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 648         * ctf-create.c (ctf_update): Likewise.
 649         * configure.ac: Check for BSD versus GNU qsort_r signature.
 650         * Makefile.in: Regenerate.
 651         * config.h.in: Likewise.
 652         * configure: Likewise.
 653
 654 2019-06-03  Nick Alcock  <[email protected]>
 655
 656         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 657
 658 2019-05-29  Nick Alcock  <[email protected]>
 659
 660         * Makefile.am (ZLIB): New.
 661         (ZLIBINC): Likewise.
 662         (AM_CFLAGS): Use them.
 663         (libctf_a_LIBADD): New, for LIBOBJS.
 664         * configure.ac: Check for zlib, endian.h, and qsort_r.
 665         * ctf-endian.h: New, providing htole64 and le64toh.
 666         * swap.h: Code style fixes.
 667         (bswap_identity_64): New.
 668         * qsort_r.c: New, from gnulib (with one added #include).
 669         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 670         and unconditional definitions of MIN and MAX.
 671         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 672         (ctf_set_errno): Now returns unsigned long.
 673         * ctf-util.c (ctf_set_errno): Adjust here too.
 674         * ctf-archive.c: Use ctf-endian.h.
 675         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 676         cts_flags and cts_offset.
 677         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 678         * ctf-create.c: Provide a definition of roundup if not defined.
 679         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 680         (ctf_add_reftype): Do not check if type IDs are below zero.
 681         (ctf_add_slice): Likewise.
 682         (ctf_add_typedef): Likewise.
 683         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 684         when known error-free.  Drop CTF_ERR usage for functions returning
 685         int.
 686         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 687         int.
 688         (ctf_add_variable): Likewise.
 689         (enumcmp): Likewise.
 690         (enumadd): Likewise.
 691         (membcmp): Likewise.
 692         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 693         when known error-free.
 694         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 695         returning int: use CTF_ERR for functions returning ctf_type_id.
 696         (ctf_dump_label): Likewise.
 697         (ctf_dump_objts): Likewise.
 698         * ctf-labels.c (ctf_label_topmost): Likewise.
 699         (ctf_label_iter): Likewise.
 700         (ctf_label_info): Likewise.
 701         * ctf-lookup.c (ctf_func_args): Likewise.
 702         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 703         (ctf_bufopen): Likewise.  Use zlib types as needed.
 704         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 705         returning int.
 706         (ctf_enum_iter): Likewise.
 707         (ctf_type_size): Likewise.
 708         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 709         (ctf_type_kind_unsliced): Likewise.
 710         (ctf_type_kind): Likewise.
 711         (ctf_type_encoding): Likewise.
 712         (ctf_member_info): Likewise.
 713         (ctf_array_info): Likewise.
 714         (ctf_enum_value): Likewise.
 715         (ctf_type_rvisit): Likewise.
 716         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 717         cts_offset.
 718         (ctf_simple_open): Likewise.
 719         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 720         * Makefile.in: Regenerate.
 721         * aclocal.m4: Likewise.
 722         * config.h: Likewise.
 723         * configure: Likewise.
 724
 725 2019-05-28  Nick Alcock  <[email protected]>
 726
 727         * configure.in: Check for bfd_section_from_elf_index.
 728         * configure: Regenerate.
 729         * config.h.in [HAVE_BFD_ELF]: Likewise.
 730         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 731         abfd is potentially unused now.
 732
 733 2019-05-28  Nick Alcock  <[email protected]>
 734
 735         * Makefile.am: New.
 736         * Makefile.in: Regenerated.
 737         * config.h.in: Likewise.
 738         * aclocal.m4: Likewise.
 739         * configure: Likewise.
 740
 741 2019-05-28  Nick Alcock  <[email protected]>
 742
 743         * ctf-dump.c: New.
 744
 745 2019-05-28  Nick Alcock  <[email protected]>
 746
 747         * ctf-labels.c: New.
 748
 749 2019-05-28  Nick Alcock  <[email protected]>
 750
 751         * ctf-impl.h (_libctf_version): New declaration.
 752         * ctf-subr.c (_libctf_version): Define it.
 753         (ctf_version): New.
 754
 755 2019-05-28  Nick Alcock  <[email protected]>
 756
 757         * ctf-create.c (enumcmp): New.
 758         (enumadd): Likewise.
 759         (membcmp): Likewise.
 760         (membadd): Likewise.
 761         (ctf_add_type): Likewise.
 762
 763 2019-05-28  Nick Alcock  <[email protected]>
 764
 765         * ctf-lookup.c (isqualifier): New.
 766         (ctf_lookup_by_name): Likewise.
 767         (struct ctf_lookup_var_key): Likewise.
 768         (ctf_lookup_var): Likewise.
 769         (ctf_lookup_variable): Likewise.
 770         (ctf_lookup_symbol_name): Likewise.
 771         (ctf_lookup_by_symbol): Likewise.
 772         (ctf_func_info): Likewise.
 773         (ctf_func_args): Likewise.
 774
 775 2019-05-28  Nick Alcock  <[email protected]>
 776
 777         * ctf-decl.c: New file.
 778         * ctf-types.c: Likewise.
 779         * ctf-impl.h: New declarations.
 780
 781 2019-05-28  Nick Alcock  <[email protected]>
 782
 783         * ctf-open-bfd.c: New file.
 784         * ctf-open.c (ctf_close): New.
 785         * ctf-impl.h: Include bfd.h.
 786         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 787         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 788         ctfi_bfd_close.
 789         (ctf_bfdopen_ctfsect): New declaration.
 790         (_CTF_SECTION): likewise.
 791
 792 2019-05-28  Nick Alcock  <[email protected]>
 793
 794         * ctf-archive.c: New.
 795         * ctf-impl.h (ctf_archive_internal): New type.
 796         (ctf_arc_open_internal): New declaration.
 797         (ctf_arc_bufopen): Likewise.
 798         (ctf_arc_close_internal): Likewise.
 799
 800 2019-05-28  Nick Alcock  <[email protected]>
 801
 802         * ctf-open.c: New file.
 803         * swap.h: Likewise.
 804
 805 2019-05-28  Nick Alcock  <[email protected]>
 806
 807         * ctf-create.c: New file.
 808         * ctf-lookup.c: New file.
 809
 810 2019-05-28  Nick Alcock  <[email protected]>
 811
 812         * ctf-impl.h: New definitions and declarations for type creation
 813         and lookup.
 814
 815 2019-05-28  Nick Alcock  <[email protected]>
 816
 817         * ctf-hash.c: New file.
 818         * ctf-impl.h: New declarations.
 819
 820 2019-05-28  Nick Alcock  <[email protected]>
 821
 822         * ctf-error.c: New file.
 823
 824 2019-05-28  Nick Alcock  <[email protected]>
 825
 826         * ctf-util.c: New file.
 827         * elf.h: Likewise.
 828         * ctf-impl.h: Include it, and add declarations.
 829
 830 2019-05-28  Nick Alcock  <[email protected]>
 831
 832         * ctf-impl.h: New file.
 833         * ctf-subr.c: New file.
 834
 835 \f
 836 Local Variables:
 837 mode: change-log
 838 left-margin: 8
 839 fill-column: 76
 840 version-control: never
 841 End: