3 * buildsym.c (end_symtab_get_static_block): Use std::stable_sort.
7 * memattr.h: Don't include vec.h.
8 (struct mem_attrib): Initialize fields.
9 <unknown>: New static method.
10 (struct mem_region): Add constructors, operator<, initialize
12 * memattr.c: Include algorithm.
13 (default_mem_attrib, unknown_mem_attrib): Remove.
14 (user_mem_region_list): New global.
15 (target_mem_region_list, mem_region_list): Change type to
16 std::vector<mem_region>.
17 (mem_use_target): Now a function.
18 (target_mem_regions_valid): Change type to bool.
19 (mem_region_lessthan, mem_region_cmp, mem_region_init): Remove.
20 (require_user_regions): Adjust.
21 (require_target_regions): Adjust.
22 (create_mem_region): Adjust.
23 (lookup_mem_region): Adjust.
24 (invalidate_target_mem_regions): Adjust.
25 (mem_clear): Rename to...
26 (user_mem_clear): ... this, and adjust.
27 (mem_command): Adjust.
28 (info_mem_command): Adjust.
29 (mem_enable, enable_mem_command, mem_disable,
30 disable_mem_command): Adjust.
32 (delete_mem_command): Adjust.
33 * memory-map.h (parse_memory_map): Return an std::vector.
34 * memory-map.c (parse_memory_map): Likewise.
35 (struct memory_map_parsing_data): Add constructor.
36 <memory_map>: Point to std::vector.
37 (memory_map_start_memory): Adjust.
38 (memory_map_end_memory): Adjust.
39 (memory_map_end_property): Adjust.
40 (clear_result): Remove.
41 * remote.c (remote_memory_map): Return an std::vector.
42 * target-debug.h (target_debug_print_VEC_mem_region_s__p):
44 (target_debug_print_mem_region_vector): New.
45 * target-delegates.c: Regenerate.
46 * target.h (mem_region_vector): New typedef.
47 (to_memory_map): Return mem_region_vector.
48 (target_memory_map): Return an std::vector.
49 * target.c (target_memory_map): Return an std::vector.
50 (flash_erase_command): Adjust.
54 * memory-map.c (struct memory_map_parsing_data) <property_name>:
55 Change type to std::string.
56 (memory_map_start_property): Adjust.
57 (memory_map_end_property): Adjust.
61 * infrun.h: Include common/byte-vector.h.
62 (struct displaced_step_closure): New struct.
63 (struct buf_displaced_step_closure): New struct.
64 * infrun.c (displaced_step_closure::~displaced_step_closure):
65 Provide default implementation.
66 (displaced_step_clear): Deallocate step closure with delete.
67 * aarch64-tdep.c (displaced_step_closure): Rename to ...
68 (aarch64_displaced_step_closure): ... this, extend
69 displaced_step_closure.
70 (aarch64_displaced_step_data) <dsc>: Change type to
71 aarch64_displaced_step_closure.
72 (aarch64_displaced_step_copy_insn): Adjust to type change, use
74 (aarch64_displaced_step_fixup): Add cast for displaced step
76 * amd64-tdep.c (displaced_step_closure): Rename to ...
77 (amd64_displaced_step_closure): ... this, extend
78 displaced_step_closure.
79 <insn_buf>: Change type to std::vector<gdb_byte>.
81 (fixup_riprel): Change type of DSC parameter, adjust to type
83 (fixup_displaced_copy): Change type of DSC parameter.
84 (amd64_displaced_step_copy_insn): Instantiate
85 amd64_displaced_step_closure.
86 (amd64_displaced_step_fixup): Add cast for closure type, adjust
87 to type change of insn_buf.
88 * arm-linux-tdep.c (arm_linux_cleanup_svc): Change type of
90 (arm_linux_copy_svc): Likewise.
91 (cleanup_kernel_helper_return): Likewise.
92 (arm_catch_kernel_helper_return): Likewise.
93 (arm_linux_displaced_step_copy_insn): Instantiate
94 arm_displaced_step_closure.
95 * arm-tdep.c (arm_pc_is_thumb): Add cast for closure.
96 (displaced_read_reg): Change type of parameter DSC.
97 (branch_write_pc): Likewise.
98 (load_write_pc): Likewise.
99 (alu_write_pc): Likewise.
100 (displaced_write_reg): Likewise.
101 (arm_copy_unmodified): Likewise.
102 (thumb_copy_unmodified_32bit): Likewise.
103 (thumb_copy_unmodified_16bit): Likewise.
104 (cleanup_preload): Likewise.
105 (install_preload): Likewise.
106 (arm_copy_preload): Likewise.
107 (thumb2_copy_preload): Likewise.
108 (install_preload_reg): Likewise.
109 (arm_copy_preload_reg): Likewise.
110 (cleanup_copro_load_store): Likewise.
111 (install_copro_load_store): Likewise.
112 (arm_copy_copro_load_store) Likewise.
113 (thumb2_copy_copro_load_store): Likewise.
114 (cleanup_branch): Likewise.
115 (install_b_bl_blx): Likewise.
116 (arm_copy_b_bl_blx): Likewise.
117 (thumb2_copy_b_bl_blx): Likewise.
118 (thumb_copy_b): Likewise.
119 (install_bx_blx_reg): Likewise.
120 (arm_copy_bx_blx_reg): Likewise.
121 (thumb_copy_bx_blx_reg): Likewise.
122 (cleanup_alu_imm): Likewise.
123 (arm_copy_alu_imm): Likewise.
124 (thumb2_copy_alu_imm): Likewise.
125 (cleanup_alu_reg): Likewise.
126 (install_alu_reg): Likewise.
127 (arm_copy_alu_reg): Likewise.
128 (thumb_copy_alu_reg): Likewise.
129 (cleanup_alu_shifted_reg): Likewise.
130 (install_alu_shifted_reg): Likewise.
131 (arm_copy_alu_shifted_reg): Likewise.
132 (cleanup_load): Likewise.
133 (cleanup_store): Likewise.
134 (arm_copy_extra_ld_st): Likewise.
135 (install_load_store): Likewise.
136 (thumb2_copy_load_literal): Likewise.
137 (thumb2_copy_load_reg_imm): Likewise.
138 (arm_copy_ldr_str_ldrb_strb): Likewise.
139 (cleanup_block_load_all): Likewise.
140 (cleanup_block_store_pc): Likewise.
141 (cleanup_block_load_pc): Likewise.
142 (arm_copy_block_xfer): Likewise.
143 (thumb2_copy_block_xfer): Likewise.
144 (cleanup_svc): Likewise.
145 (install_svc): Likewise.
146 (arm_copy_svc): Likewise.
147 (thumb_copy_svc): Likewise.
148 (arm_copy_undef): Likewise.
149 (thumb_32bit_copy_undef): Likewise.
150 (arm_copy_unpred): Likewise.
151 (arm_decode_misc_memhint_neon): Likewise.
152 (arm_decode_unconditional): Likewise.
153 (arm_decode_miscellaneous): Likewise.
154 (arm_decode_dp_misc): Likewise.
155 (arm_decode_ld_st_word_ubyte): Likewise.
156 (arm_decode_media): Likewise.
157 (arm_decode_b_bl_ldmstm): Likewise.
158 (arm_decode_ext_reg_ld_st): Likewise.
159 (thumb2_decode_dp_shift_reg): Likewise.
160 (thumb2_decode_ext_reg_ld_st): Likewise.
161 (arm_decode_svc_copro): Likewise.
162 (thumb2_decode_svc_copro): Likewise.
163 (install_pc_relative): Likewise.
164 (thumb_copy_pc_relative_16bit): Likewise.
165 (thumb_decode_pc_relative_16bit): Likewise.
166 (thumb_copy_pc_relative_32bit): Likewise.
167 (thumb_copy_16bit_ldr_literal): Likewise.
168 (thumb_copy_cbnz_cbz): Likewise.
169 (thumb2_copy_table_branch): Likewise.
170 (cleanup_pop_pc_16bit_all): Likewise.
171 (thumb_copy_pop_pc_16bit): Likewise.
172 (thumb_process_displaced_16bit_insn): Likewise.
173 (decode_thumb_32bit_ld_mem_hints): Likewise.
174 (thumb_process_displaced_32bit_insn): Likewise.
175 (thumb_process_displaced_insn): Likewise.
176 (arm_process_displaced_insn): Likewise.
177 (arm_displaced_init_closure): Likewise.
178 (arm_displaced_step_fixup): Add cast for closure.
179 * arm-tdep.h: Include infrun.h.
180 (displaced_step_closure): Rename to ...
181 (arm_displaced_step_closure): ... this, extend
182 displaced_step_closure.
183 <u::svc::copy_svc_os>: Change type of parameter DSC.
185 (arm_process_displaced_insn): Likewise.
186 (arm_displaced_init_closure): Likewise.
187 (displaced_read_reg): Likewise.
188 (displaced_write_reg): Likewise.
189 * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn):
191 * i386-tdep.h: Include infrun.h.
192 (i386_displaced_step_closure): New typedef.
193 * i386-tdep.c (i386_displaced_step_copy_insn): Use
194 i386_displaced_step_closure.
195 (i386_displaced_step_fixup): Adjust.
196 * rs6000-tdep.c (ppc_displaced_step_closure): New typedef.
197 (ppc_displaced_step_copy_insn): Use ppc_displaced_step_closure
199 (ppc_displaced_step_fixup): Adjust.
200 * s390-linux-tdep.c (s390_displaced_step_closure): New typedef.
201 (s390_displaced_step_copy_insn): Use s390_displaced_step_closure
203 (s390_displaced_step_fixup): Adjust.
207 * interps.h (interp_resume, interp_suspend, interp_set_temp):
212 * gdb_bfd.c (struct gdb_bfd_data) <included_bfds>: Now a
214 (gdb_bfd_record_inclusion): Update.
215 (bfdp): Remove typedef.
219 * gdb_bfd.c (gdb_bfd_ref): Use new.
220 (struct gdb_bfd_data): Add constructor, destructor, and member
222 (gdb_bfd_unref): Use delete.
226 * exec.c (exec_file_attach): Use new_bfd_ref.
227 * symfile-mem.c (symbol_file_add_from_memory): Use new_bfd_ref.
228 * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
229 (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_fdopenr): Use
231 * gdb_bfd.h (new_bfd_ref): New function.
235 * main.c (captured_command_loop): Add attribute noinline.
239 * interps.c (struct interp_factory): Add constructor.
240 (interp_factory_p): Remove typedef.
241 (DEF_VEC_P(interp_factory_p)): Remove.
242 (interpreter_factories): Change type to std::vector.
243 (interp_factory_register): Adjust.
244 (interp_lookup): Adjust.
245 (interpreter_completer): Adjust.
249 * break-catch-syscall.c (catch_syscall_completer): Use
250 std::string, gdb::unique_xmalloc_ptr.
254 * infcall.c (call_function_by_hand_dummy): Use std::string.
258 * mi/mi-main.c (mi_cmd_execute): Update.
259 * top.h (prepare_execute_command): Return scoped_value_mark.
260 * value.h (class scoped_value_mark): Use DISABLE_COPY_AND_ASSIGN.
261 Add move constructor.
262 * top.c (prepare_execute_command): Return scoped_value_mark.
263 (execute_command): Update.
267 * xml-support.c (xml_fetch_content_from_file): Check fread's
272 * ser-base.c (ser_base_read_error_fd): Delete the file handler if
274 (handle_error_fd): New function.
275 (ser_base_async): Add/delete an event loop file handler for
280 * xml-support.c (xml_fetch_content_from_file): Don't read in
281 chunks. Instead use fseek to determine the file's size, and read
286 * c-exp.y (oper): Canonicalize conversion operators of user-defined
288 Add whitespace to front of type name.
292 * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled
297 * features/tic6x-c62x-linux.c: Remove.
301 * disasm.c (do_mixed_source_and_assembly_deprecated): Use
302 gdb::optional, ui_out_emit_list, ui_out_emit_tuple.
303 (do_mixed_source_and_assembly): Likewise.
307 * regcache.c (regcache::xfer_part): Remove assertion.
311 * xml-support.c (xml_fetch_content_from_file): Call
312 unique_ptr::release() instead unique_ptr::get() when passing
317 * regcache.c (regcache::xfer_part): Remove parameters read and
318 write, add parameter is_raw. All callers are updated.
322 * c-typeprint.c (enum access_specifier): Moved here from
324 (output_access_specifier): New function.
325 (c_type_print_base): Consider typedefs when assessing
326 whether access labels are needed.
327 Use output_access_specifier as needed.
328 Output access specifier for typedefs, if needed.
329 * dwarf2read.c (dwarf2_add_typedef): Record DW_AT_accessibility.
330 * gdbtypes.h (struct typedef_field) <is_protected, is_private>: New
332 (TYPE_TYPEDEF_FIELD_PROTECTED, TYPE_TYPEDEF_FIELD_PRIVATE): New
337 * linux-tdep.c (linux_info_proc, linux_find_memory_regions_full)
338 (linux_fill_prpsinfo, linux_vsyscall_range_raw): Update.
339 * target.c (target_fileio_read_stralloc): Update.
340 * sparc64-tdep.c (adi_is_addr_mapped): Update.
341 * target.h (target_fileio_read_stralloc): Return
346 * xml-syscall.c (xml_init_syscalls_info): Update.
347 * xml-support.c (xinclude_start_include): Update.
348 (xml_fetch_content_from_file): Return unique_xmalloc_ptr.
349 * xml-support.h (xml_fetch_another): Return unique_xmalloc_ptr.
350 (xml_fetch_content_from_file): Likewise.
351 * osdata.c (get_osdata): Update.
352 * target.h (target_read_stralloc, target_get_osdata): Return
354 * solib-aix.c (solib_aix_get_library_list): Update.
355 * solib-target.c (solib_target_current_sos): Update.
356 * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Update.
357 * xml-tdesc.c (fetch_available_features_from_target): Update.
358 (target_fetch_description_xml): Update.
359 (file_read_description_xml): Update.
360 * remote.c (remote_get_threads_with_qxfer, remote_memory_map)
361 (remote_traceframe_info, btrace_read_config, remote_read_btrace)
362 (remote_pid_to_exec_file): Update.
363 * target.c (target_read_stralloc): Return unique_xmalloc_ptr.
364 (target_get_osdata): Likewise.
368 * remote.c (remote_register_number_and_offset): Use std::vector.
369 (remote_set_syscall_catchpoint): Use gdb::unique_xmalloc_ptr.
370 (putpkt_binary): Use gdb::def_vector.
371 (compare_sections_command): Use gdb::byte_vector.
375 * ppc-linux-nat.c (hwdebug_insert_point): Use
376 gdb::unique_xmalloc_ptr, XDUP.
380 * probe.c (parse_probes): Use std::string.
381 (info_probes_for_ops, enable_probes_command)
382 (disable_probes_command): Remove cleanups.
386 * buildsym.c (block_compar): Remove.
387 (end_symtab_get_static_block): Use std::vector.
391 * memrange.h (struct mem_range): Define operator< and operator==.
392 (mem_range_s): Remove.
393 (DEF_VEC_O (mem_range_s)): Remove.
394 (normalize_mem_ranges): Change parameter type to std::vector.
395 * memrange.c (compare_mem_ranges): Remove.
396 (normalize_mem_ranges): Change parameter type to std::vector,
397 adjust to vector change.
398 * exec.c (section_table_available_memory): Return vector, remove
400 (section_table_read_available_memory): Adjust to std::vector
402 * remote.c (remote_read_bytes): Adjust to std::vector
404 * tracepoint.h (traceframe_available_memory): Change parameter
406 * tracepoint.c (traceframe_available_memory): Change parameter
407 type to std::vector, adjust.
408 * gdb/mi/mi-main.c (mi_cmd_trace_frame_collected): Adjust to
410 * gdb/Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
411 unittests/memrange-selftests.c.
412 (SUBDIR_UNITTESTS_OBS): Add memrange-selftests.o.
413 * gdb/unittests/memrange-selftests.c: New file.
417 * elfread.c (probe_key_free): Rename range-for variable.
418 * probe.c (parse_probes_in_pspace, find_probes_in_objfile)
419 (find_probe_by_pc, collect_probes): Rename range-for variable.
423 * features/Makefile (XMLTOC): Remove tic6x-*.xml.
424 * features/tic6x-c62x.c: Remove.
425 * features/tic6x-c64x-linux.c: Remove.
426 * features/tic6x-c64x.c: Remove.
427 * features/tic6x-c64xp-linux.c: Remove.
428 * features/tic6x-c64xp.c: Remove.
429 * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Don't call
430 initialize_tdesc_tic6x_*_linux functions.
431 * tic6x-tdep.c (_initialize_tic6x_tdep): Don't call
432 initialize_tdesc_tic6x_* functions.
436 * features/Makefile (WHICH): Remove tic6x-c64xp, tic6x-c64x
438 * regformats/tic6x-c62x.dat: Remove.
439 * regformats/tic6x-c64x.dat: Remove.
440 * regformats/tic6x-c64xp.dat: Remove.
444 * tracepoint.c (parse_traceframe_info): Return a unique_ptr
445 (the !HAVE_LIBEXPAT version).
449 * nat/linux-osdata.c (struct pid_pgid_entry) <operator<>: Make
454 * target.h: Include tracepoint.h.
455 (enum trace_find_type): Move to tracepoint.h.
456 (struct target_ops) <to_traceframe_info>: Return a unique ptr.
457 * tracepoint.h: Don't include target.h
458 (enum trace_find_type): Move from target.h.
459 (parse_traceframe_info): Return a unique ptr.
460 * tracepoint.c (current_traceframe_info): Change type to unique
462 (free_traceframe_info): Remove.
463 (clear_traceframe_info): Don't manually free
464 current_traceframe_info.
465 (free_result): Remove.
466 (parse_traceframe_info): Return a unique ptr.
467 (get_traceframe_info): Adjust to unique ptr.
468 * ctf.c (ctf_traceframe_info): Return a unique ptr.
469 * remote.c (remote_traceframe_info): Return a unique ptr.
470 * tracefile-tfile.c (tfile_traceframe_info): Return a unique
472 * target-debug.h (target_debug_print_traceframe_info_up): New
474 * target-delegates.c: Regenerate.
478 * memrange.h (struct mem_range): Add constructors.
479 * tracepoint.h (struct traceframe_info) <memory>: Change type to
480 std::vector<mem_range>.
481 * tracepoint.c (free_traceframe_info): Don't manually free
483 (traceframe_info_start_memory): Adjust to vector change.
484 (traceframe_available_memory): Likewise.
485 * tracefile-tfile.c (build_traceframe_info): Likewise.
486 * ctf.c (ctf_traceframe_info): Likewise.
490 * tracepoint.h (struct traceframe_info) <tvars>: Change type to
492 * tracepoint.c (free_traceframe_info): Deallocate with delete.
493 (traceframe_info_start_tvar): Adjust to vector change.
494 (parse_traceframe_info): Allocate with new.
495 * ctf.c (ctf_traceframe_info): Allocate with new, adjust to
497 * tracefile-tfile.c (build_traceframe_info): Adjust to vector
499 tfile_traceframe_info): Allocate with new.
500 * mi/mi-main.c (mi_cmd_trace_frame_collected): Adjust to vector
505 * tracepoint.c (traceframe_info): Rename to...
506 (current_traceframe_info): ...this.
507 (clear_traceframe_info): Adjust.
508 (get_traceframe_info): Adjust.
512 * nat/linux-osdata.c: Include algorithm.
513 (compare_processes): Remove.
514 (struct pid_pgid_entry): New struct.
515 (linux_xfer_osdata_processgroups): Use std::vector instead of
520 * objfiles.h: Don't include symfile.h.
521 (struct partial_symbol): Remove forward-declaration.
522 (struct objfile) <global_psymbols, static_psymbols>: Change type
523 to std::vector<partial_symbol *>.
524 * objfiles.c (objfile::objfile): Don't memset those fields.
525 (objfile::~objfile): Don't free those fields.
526 * psympriv.h (struct psymbol_allocation_list): Remove
528 (add_psymbol_to_list): Change psymbol_allocation_list parameter
530 (start_psymtab_common): Change parameters to std::vector.
531 * psymtab.c: Include algorithm.
532 (require_partial_symbols): Call shrink_to_fit.
533 (find_pc_sect_psymbol): Adjust to vector change.
534 (match_partial_symbol): Likewise.
535 (lookup_partial_symbol): Likewise.
536 (psym_relocate): Likewise.
537 (dump_psymtab): Likewise.
538 (recursively_search_psymtabs): Likewise.
539 (compare_psymbols): Remove.
540 (sort_pst_symbols): Adjust to vector change.
541 (start_psymtab_common): Likewise.
542 (end_psymtab_common): Likewise.
543 (psymbol_bcache_full): De-constify return value.
544 (add_psymbol_to_bcache): Likewise.
545 (extend_psymbol_list): Remove.
546 (append_psymbol_to_list): Adjust to vector change.
547 (add_psymbol_to_list): Likewise.
548 (init_psymbol_list): Likewise.
549 (maintenance_info_psymtabs): Likewise.
550 (maintenance_check_psymtabs): Likewise.
551 * symfile.h (struct psymbol_allocation_list): Remove.
552 * symfile.c (reread_symbols): Adjust to vector change.
553 * dbxread.c (start_psymtab): Change type of parameters.
554 (dbx_symfile_read): Adjust to vector change.
555 (read_dbx_symtab): Likewise.
556 (start_psymtab): Change type of parameters.
557 * dwarf2read.c (dwarf2_build_psymtabs): Adjust to vector change.
558 (create_partial_symtab): Likewise.
559 (add_partial_symbol): Likewise.
560 (write_one_signatured_type): Likewise.
561 (recursively_write_psymbols): Likewise.
562 * mdebugread.c (parse_partial_symbols): Likewise.
563 * xcoffread.c (xcoff_start_psymtab): Change type of parameters.
564 (scan_xcoff_symtab): Adjust to vector change.
565 (xcoff_initial_scan): Likewise.
569 * ada-typeprint.c (print_dynamic_range_bound): Use std::string.
573 * features/Makefile: Remove tic6x-*-expedite, add tic6x-expedite.
574 Remove s390x-*-expedite, add s390x-expedite.
578 * features/s390-gs-linux64.c: Regenerated.
579 * features/s390x-gs-linux64.c: Regenerated.
583 * compile/compile-object-run.c (do_module_cleanup): Use delete.
584 * solib.c (update_solib_list, reload_shared_libraries_1): Use
586 * symfile.c (symbol_file_add_with_addrs): Use new.
587 (symbol_file_add_separate): Update comment.
588 (syms_from_objfile_1, remove_symbol_file_command): Use delete.
589 * jit.c (jit_object_close_impl): Use new.
590 (jit_unregister_code): Use delete.
591 * objfiles.c (objfile::objfile): Rename from allocate_objfile.
592 (~objfile): Rename from free_objfile.
593 (free_objfile_separate_debug, do_free_objfile_cleanup)
594 (free_all_objfiles, objfile_purge_solibs): Use delete.
595 * objfiles.h (struct objfile): Add constructor and destructor.
596 Use DISABLE_COPY_AND_ASSIGN. Add initializers to data members.
597 (allocate_objfile, free_objfile): Don't declare.
598 (struct objstats): Add initializers.
602 * arch-utils.h (simple_displaced_step_copy_insn): Remove.
603 * arch-utils.c (simple_displaced_step_copy_insn): Remove.
604 * gdbarch.sh (displaced_step_copy_insn): Adjust comment.
605 * gdbarch.h: Regenerate.
606 * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn):
608 * i386-tdep.c (i386_displaced_step_copy_insn): Adjust comment.
609 (i386_displaced_step_fixup): Adjust comment.
610 * rs6000-tdep.c (ppc_displaced_step_copy_insn): Adjust comment.
614 * prologue-value.h (pv_area::store_would_trash): Return bool.
615 (pv_area::find_reg): Likewise.
616 * prologue-value.c (pv_area::store_would_trash): Return bool.
617 (pv_area::find_reg): Likewise.
621 * s390-linux-tdep.c (s390_store, s390_load)
622 (s390_check_for_saved, s390_analyze_prologue): Update.
623 * rx-tdep.c (check_for_saved, rx_analyze_prologue): Update.
624 * rl78-tdep.c (rl78_analyze_prologue, check_for_saved): Update.
625 * prologue-value.h (class pv_area): Move from prologue-value.c.
626 Change names of members. Add constructor, destructor, member
628 (make_pv_area, free_pv_area, make_cleanup_free_pv_area)
629 (pv_area_store, pv_area_fetch, pv_area_store_would_trash)
630 (pv_area_fetch, pv_area_scan): Don't declare.
631 * prologue-value.c (struct pv_area::area_entry): Now member of
633 (struct pv_area): Move to prologue-value.h.
634 (pv_area::pv_area): Rename from make_pv_area.
635 (pv_area::~pv_area): Rename from free_pv_area.
636 (do_free_pv_area_cleanup, make_cleanup_free_pv_area): Remove.
637 (clear_entries, find_entry, overlaps, store_would_trash, store)
638 (fetch, find_reg, scan): Now member of pv_area.
639 Remove "area" argument. Update.
640 * msp430-tdep.c (check_for_saved, msp430_analyze_prologue):
642 * mn10300-tdep.c (push_reg, check_for_saved)
643 (mn10300_analyze_prologue): Update.
644 * mep-tdep.c (is_arg_spill, check_for_saved)
645 (mep_analyze_prologue): Update.
646 * m32c-tdep.c (m32c_pv_push, m32c_srcdest_fetch)
647 (m32c_srcdest_store, m32c_pv_enter, m32c_is_arg_spill)
648 (m32c_is_struct_return, m32c_analyze_prologue): Update.
649 * arm-tdep.c (thumb_analyze_prologue, arm_analyze_prologue):
651 * arc-tdep.c (arc_is_in_prologue, arc_analyze_prologue): Update.
652 * aarch64-tdep.c (aarch64_analyze_prologue): Update.
656 * linux-nat.h (linux_nat_set_delete_thread): New declaration.
657 * linux-nat.c (linux_nat_delete_thread): New variable.
658 (lwp_free): Invoke linux_nat_delete_thread if set.
659 (linux_nat_set_delete_thread): New function.
660 * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Assign
661 thread delete callback.
662 * arm-linux-nat.c (arm_linux_delete_thread): New function.
663 (_initialize_arm_linux_nat): Assign thread delete callback.
664 * s390-linux-nat.c (s390_delete_thread): New function.
665 (_initialize_s390_nat): Assign thread delete callback.
666 * x86-linux-nat.c (x86_linux_add_target): Likewise.
667 * nat/aarch64-linux.c (aarch64_linux_delete_thread): New
669 * nat/aarch64-linux.h (aarch64_linux_delete_thread): New
671 * nat/x86-linux.c (x86_linux_delete_thread): New function.
672 * nat/x86-linux.h (x86_linux_delete_thread): New declaration.
676 * tui/tui-win.c (tui_set_win_height, parse_scrolling_args): Use
678 * tui/tui-layout.c (enum tui_status): Use std::string.
682 * gdbthread.h (thread_command): Constify.
683 * inferior.h (detach_command): Constify.
684 * top.h (set_history, show_history): Constify.
685 * arm-tdep.c (set_arm_command, show_arm_command): Constify.
686 * serial.c (serial_set_cmd, serial_show_cmd): Constify.
687 * bsd-kvm.c (bsd_kvm_cmd): Constify.
688 * printcmd.c (set_command): Constify.
689 (non_const_set_command): New function.
690 * dcache.c (set_dcache_command, show_dcache_command): Constify.
691 * breakpoint.c (enable_command, disable_command, delete_command)
692 (catch_command, tcatch_command, set_breakpoint_cmd)
693 (show_breakpoint_cmd): Constify.
694 * macrocmd.c (macro_command): Constify.
695 * infcmd.c (unset_command, kill_command, detach_command)
696 (info_proc_cmd): Constify.
697 * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Constify.
698 * auto-load.c (show_auto_load_cmd, set_auto_load_cmd)
699 (info_auto_load_cmd): Constify.
700 * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
701 (unset_tdesc_cmd): Constify.
702 * ada-lang.c (set_ada_command, show_ada_command)
703 (maint_set_ada_cmd, maint_show_ada_cmd): Constify.
704 * guile/guile.c (set_guile_command, show_guile_command)
705 (info_guile_command): Constify.
706 * tui/tui-win.c (tui_command, set_tui_cmd, show_tui_cmd):
708 * skip.c (skip_command): Constify.
709 * compile/compile.c (_initialize_compile): Constify.
710 * dwarf2read.c (set_dwarf_cmd, show_dwarf_cmd): Constify.
711 * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
712 (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
713 (maint_btrace_pt_show_cmd): Constify.
714 * remote.c (set_remote_cmd, show_remote_cmd, remote_command):
716 * python/python.c (user_show_python, user_set_python): Constify.
717 * mips-tdep.c (set_mips_command, show_mips_command)
718 (set_mipsfpu_command): Constify.
719 * record-btrace.c (cmd_record_btrace_start)
720 (cmd_set_record_btrace, cmd_show_record_btrace)
721 (cmd_set_record_btrace_bts, cmd_show_record_btrace_bts)
722 (cmd_set_record_btrace_pt, cmd_show_record_btrace_pt): Constify.
723 * rs6000-tdep.c (set_powerpc_command, show_powerpc_command):
725 * symfile.c (overlay_command): Constify.
726 * spu-tdep.c (set_spu_command, show_spu_command): Constify.
727 * cli/cli-logging.c (set_logging_command, show_logging_command):
729 * cli/cli-dump.c (dump_command, append_command)
730 (srec_dump_command, ihex_dump_command, verilog_dump_command)
731 (tekhex_dump_command, binary_dump_command)
732 (binary_append_command): Constify.
733 * cli/cli-decode.c (struct cmd_list_element): Change type of
735 * cli/cli-cmds.c (info_command, show_command, set_debug)
736 (show_debug): Constify.
737 (show_command): Add non-const overload.
738 * top.c (set_history, show_history): Constify.
739 * sh-tdep.c (set_sh_command, show_sh_command): Constify.
740 * command.h (add_prefix_cmd): Accept a cmd_const_cfunc_ftype.
741 * target.c (target_command): Constify.
742 * sparc64-tdep.c (info_adi_command): Constify.
743 * record-full.c (cmd_record_full_start): Constify.
744 (set_record_full_command): Constify. Fix typo.
745 (show_record_full_command): Constify.
746 * thread.c (thread_command, thread_apply_command): Constify.
747 * memattr.c (dummy_cmd): Constify.
748 * value.c (function_command): Constify.
749 * frame.c (set_backtrace_cmd, show_backtrace_cmd): Constify.
750 * probe.c (info_probes_command): Constify.
751 * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Constify.
752 * gnu-nat.c (set_task_cmd, show_task_cmd, set_thread_cmd)
753 (show_thread_cmd, set_thread_default_cmd)
754 (show_thread_default_cmd): Constify.
755 (check_empty): Constify.
756 * tracepoint.c (tfind_command): Constify.
757 * cp-support.c (maint_cplus_command): Constify.
758 * windows-tdep.c (info_w32_command): Constify.
759 * record.c (cmd_record_start, set_record_command)
760 (show_record_command, info_record_command, cmd_record_goto):
762 * ravenscar-thread.c (set_ravenscar_command)
763 (show_ravenscar_command): Constify.
764 * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
766 (add_internal_problem_command): Remove casts.
767 * arc-tdep.c (maintenance_print_arc_command): Constify.
768 * valprint.c (set_print, show_print, set_print_raw)
769 (show_print_raw): Constify.
770 * maint.c (maintenance_command, maintenance_info_command)
771 (maintenance_print_command, maintenance_set_cmd)
772 (maintenance_show_cmd, set_per_command_cmd)
773 (show_per_command_cmd, maintenance_check_command): Constify.
774 * language.c (set_check, show_check): Constify.
775 * typeprint.c (show_print_type, set_print_type): Constify.
776 * go32-nat.c (go32_info_dos_command): Constify.
780 * breakpoint.c (prepare_re_set_context): Remove.
781 (breakpoint_re_set_one): Update. Don't use cleanups.
782 (breakpoint_re_set): Use scoped_restore, std::string, and
783 scoped_restore_current_language.
787 * breakpoint.c (commands_command_1): Use std::string.
788 (cleanup_executing_breakpoints): Remove.
789 (bpstat_do_actions_1): Use scoped_restore.
790 (bpstat_check_watchpoint): Use std::string.
791 (decode_static_tracepoint_spec): Likewise.
792 (break_range_command): Likewise.
793 (watch_command_1): Likewise.
794 (compare_breakpoints): Change argument types.
795 (clear_command): Use std::vector.
796 (cleanup_executing_breakpoints): Remove.
797 (update_global_location_list): Use unique_xmalloc_ptr.
798 (strace_command): Remove unused declaration.
802 * Makefile.in (ALLDEPFILES): Add arm-fbsd-nat.c.
803 * NEWS: Mention new FreeBSD/arm native configuration.
804 * configure.host: Add arm*-*-freebsd*.
805 * configure.nat: Likewise.
806 * arm-fbsd-nat.c: New file.
810 * Makefile.in (ALL_TARGET_OBS): Add arm-fbsd-tdep.o.
811 (ALLDEPFILES): Add arm-fbsd-tdep.c.
812 * NEWS: Mention new FreeBSD/arm target.
813 * configure.tgt: Add arm*-*-freebsd*.
814 * arm-fbsd-tdep.c: New file.
815 * arm-fbsd-tdep.h: New file.
819 * linux-tdep.c (linux_make_corefile_notes): Remove call to
820 `gdbarch_elfcore_write_linux_prpsinfo'.
821 * gdbarch.sh (elfcore_write_linux_prpsinfo): Remove architecture
823 (elf_internal_linux_prpsinfo): Remove declaration.
824 * gdbarch.h: Regenerate.
825 * gdbarch.c: Regenerate.
829 * ppc-linux-tdep.c (ppc_linux_init_abi): Remove call to
830 `set_gdbarch_elfcore_write_linux_prpsinfo'.
834 * breakpoint.c (reattach_breakpoints): Delete.
835 * breakpoint.h (reattach_breakpoints): Delete.
839 * symfile.c (registered_sym_fns): Make struct, not typedef.
840 (DEF_VEC_O (registered_sym_fns)): Remove.
841 (symtab_fns): Change type to std::vector.
842 (add_symtab_fns): Adjust.
843 (find_sym_fns): Adjust.
847 * arc-tdep.c (arc_gdbarch_init): Pass proper cpu value to disassembler.
848 * arc-tdep.h (arc_arch_is_em): New function.
849 (arc_arch_is_hs): Likewise.
853 * macrotab.h (macro_lookup_inclusion): Remove unnecessary
854 parentheses in the declaration.
855 (macro_lookup_inclusion): Likewise.
856 (macro_lookup_definition): Likewise.
857 * p-lang.h (pascal_builtin_types): Likewise.
858 * tui/tui-data.c (tui_win_list): Likewise.
859 * tui/tui-data.h (tui_win_list): Likewise.
860 * utils.h (make_cleanup_free_section_addr_info): Likewise.
864 * target-memory.c (block_boundaries): Fix for block address not
865 aligned on block size.
870 * breakpoint.c (struct captured_breakpoint_query_args)
871 (do_captured_breakpoint_query, gdb_breakpoint_query): Delete.
872 (print_breakpoint): New.
873 * breakpoint.h (print_breakpoint): Declare.
874 * common/common-exceptions.h (enum return_reason): Remove
875 references to catch_exceptions.
876 * exceptions.c (catch_exceptions, catch_exceptions_with_msg):
878 * exceptions.h (catch_exceptions_ftype, catch_exceptions)
879 (catch_exception_ftype, catch_exceptions_with_msg): Delete.
881 * gdbthread.h (thread_select): Declare.
882 * mi/mi-cmd-break.c: Don't include gdb.h.
883 (breakpoint_notify): Use print_breakpoint.
884 * mi/mi-cmd-catch.c: Don't include gdb.h.
885 * mi/mi-interp.c: Don't include gdb.h.
886 (mi_print_breakpoint_for_event): New.
887 (mi_breakpoint_created, mi_breakpoint_modified): Use
888 mi_print_breakpoint_for_event.
889 * mi/mi-main.c: Don't include gdb.h.
890 (mi_cmd_thread_select): Parse the global thread ID here. Use
891 thread_select instead of gdb_thread_select.
892 (mi_cmd_thread_list_ids): Output "thread-ids" tuple here instead
893 of using gdb_list_thread_ids.
894 * remote-fileio.c (do_remote_fileio_request): Change type. Reply
896 (remote_fileio_request): Use TRY/CATCH instead of
898 * symfile-mem.c (struct symbol_file_add_from_memory_args)
899 (symbol_file_add_from_memory_wrapper): Delete.
900 (add_vsyscall_page): Use TRY/CATCH instead of catch_exceptions.
901 * thread.c: Don't include gdb.h.
902 (do_captured_list_thread_ids, gdb_list_thread_ids): Delete.
903 (thread_alive): Use thread_select.
904 (do_captured_thread_select): Delete, parts salvaged as ...
905 (thread_select): ... this new function.
906 (gdb_thread_select): Delete.
911 * breakpoint.c (breakpoint_cond_eval): Change return type to bool
913 (WP_DELETED, WP_VALUE_CHANGED, WP_VALUE_NOT_CHANGED, WP_IGNORE):
914 No longer macros. Instead ...
915 (enum wp_check_result): They're now values of this new
917 (watchpoint_check): Change return type to wp_check_result and
918 parameter type to bpstat.
919 (bpstat_check_watchpoint): Use TRY/CATCH instead of catch_errors.
920 (bpstat_check_breakpoint_conditions): Use TRY/CATCH instead of
921 catch_errors. Reverse logic of watchpoint_check call.
922 (breakpoint_re_set_one): Now returns void and takes a breakpoint
923 pointer as parameter.
924 (breakpoint_re_set): Use TRY/CATCH instead of catch_errors.
925 * common/common-exceptions.c (throw_exception_sjlj): Update
926 comments to avoid mentioning catch_errors.
927 * exceptions.c (catch_errors): Delete.
928 * exceptions.h: Update comments to avoid mentioning catch_errors.
929 (catch_errors_ftype, catch_errors): Delete.
930 * infrun.c (normal_stop): Use TRY/CATCH instead of catch_errors.
931 (hook_stop_stub): Delete.
932 (restore_selected_frame): Change return type to void, and
933 parameter type to const frame_id &.
934 (restore_infcall_control_state): Use TRY/CATCH instead of
936 * main.c (captured_command_loop): Return void and remove
937 parameter. Remove references to catch_errors.
938 (captured_main): Use TRY/CATCH instead of catch_errors.
939 * objc-lang.c (objc_submethod_helper_data)
940 (find_objc_msgcall_submethod_helper): Delete.
941 (find_objc_msgcall_submethod): Use TRY/CATCH instead of
943 * record-full.c (record_full_message): Return void.
944 (record_full_message_args, record_full_message_wrapper): Delete.
945 (record_full_message_wrapper_safe): Return bool and use TRY/CATCH
946 instead of catch_errors.
947 * solib-aix.c (solib_aix_open_symbol_file_object): Change
948 parameter type to int.
949 * solib-darwin.c (open_symbol_file_object): Ditto.
950 * solib-dsbt.c (open_symbol_file_object): Ditto.
951 * solib-frv.c (open_symbol_file_object): Ditto.
952 * solib-svr4.c (open_symbol_file_object): Ditto.
953 * solib-target.c (solib_target_open_symbol_file_object): Ditto.
954 * solib.c (update_solib_list): Use TRY/CATCH instead of
956 * solist.h (struct target_so_ops) <open_symbol_file_object>:
958 * symmisc.c (struct print_symbol_args): Remove.
959 (dump_symtab_1): Use TRY/CATCH instead of catch_errors.
960 (print_symbol): Change type.
961 * windows-nat.c (handle_load_dll, handle_unload_dll): Return void
962 and remove parameters.
964 (get_windows_debug_event): Adjust.
968 * mi/mi-main.c (free_splay_tree): Remove.
969 (list_available_thread_groups): Use splay_tree_up.
970 * common/gdb_splay_tree.h: New file.
974 * mi/mi-main.c (do_nothing): Remove.
975 (list_available_thread_groups): Update.
979 * infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>: Skip
980 reading registers when switching context.
984 * fbsd-nat.c (fbsd_siginfo_size): Use gdbarch_long_bit.
985 (fbsd_convert_siginfo): Likewise.
986 * fbsd-tdep.c (fbsd_core_xfer_siginfo): Likewise.
990 * configure.ac (try_guile_versions): Remove guile-2.2.
991 * configure: Regenerate.
995 * Makefile.in (COMPILE.post, POSTCOMPILE): Restore $(basename).
996 (COMPILE.pre): Use $(CXX).
1000 * cp-support.c (cp_remove_params): Return a gdb::unique_xmalloc_ptr.
1002 (overload_list_add_symbol): Adjust to use gdb::unique_xmalloc_ptr.
1003 * cp-support.h (cp_remove_params): Now returns a
1004 gdb::unique_xmalloc_ptr.
1005 * dwarf2read.c (find_slot_in_mapped_hash): Now returns bool.
1006 Adjust to cp_remove_params returning a gdb::unique_xmalloc_ptr.
1007 * psymtab.c (psymtab_search_name): Adjust to cp_remove_params
1008 returning a gdb::unique_xmalloc_ptr.
1009 (lookup_partial_symbol): Adjust to use gdb::unique_xmalloc_ptr.
1010 * stack.c (find_frame_funname): Adjust to cp_remove_params
1011 returning a gdb::unique_xmalloc_ptr.
1015 * dwarf2read.c (dwarf2_get_dwz_file): Use
1016 gdb::unique_xmalloc_ptr.
1017 (find_slot_in_mapped_hash): Likewise.
1018 (dwarf2_physname): Likewise.
1019 (create_dwo_unit_in_dwp_v1): Use std::string.
1020 (create_dwo_unit_in_dwp_v2): Likewise.
1021 (lookup_dwo_cutu): Likewise.
1022 (inherit_abstract_dies): Use std::vector.
1023 (read_array_type): Likewise.
1024 (dwarf_decode_macros): Remove unused declaration.
1025 (unsigned_int_compar): Remove.
1026 (dwarf2_build_psymtabs_hard): Use scoped_restore.
1027 (psymtabs_addrmap_cleanup): Remove.
1031 * frame-unwind.c (frame_unwind_try_unwinder): Update.
1032 * frame.h (frame_cleanup_after_sniffer): Declare.
1033 (frame_prepare_for_sniffer): Return void.
1034 * frame.c (frame_cleanup_after_sniffer): No longer static. Change
1036 (frame_prepare_for_sniffer): Return void.
1040 * utils.h (make_cleanup_value_free): Remove.
1041 * utils.c (do_value_free, struct cleanup): Remove.
1042 * dwarf2loc.c (dwarf2_evaluate_loc_desc_full) <DWARF_VALUE_STACK>:
1044 * value.h (struct value_deleter): New.
1045 (gdb_value_up): New typedef.
1049 * symtab.c (free_search_symbols, do_free_search_symbols_cleanup)
1050 (make_cleanup_free_search_symbols): Remove.
1051 (search_symbols): Return std::vector.
1052 (symbol_search::compare_search_syms): Now member of
1053 symbol_search. Change arguments.
1054 (sort_search_symbols_remove_dups): Change arguments. Rewrite.
1055 (symtab_symbol_info, rbreak_command): Update.
1056 * symtab.h (struct symbol_search) <next>: Remove.
1058 (symbol_search::operator<): New function.
1059 (symbol_search::operator==): New function.
1060 (search_symbols): Remove std::vector.
1061 (free_search_symbols, make_cleanup_free_search_symbols): Remove.
1062 (symbol_search::compare_search_syms): Declare.
1066 * Makefile.in (ALL_64_TARGET_OBS): Replace aarch64-insn.o with
1067 arch/aarch64-insn.o.
1069 * configure.tgt: Replace aarch64-insn.o with arch/aarch64-insn.o.
1073 * Makefile.in (ALL_TARGET_OBS): Replace arm.o, arm-get-next-pcs.o,
1074 and arm-linux.o with arch/arm.o, arch/arm-get-next-pcs.o and
1075 arch/arm-linux.o respectively.
1076 * configure.tgt: Likewise.
1080 * Makefile.in (ALL_TARGET_OBS): Rename i386.o to arch/i386.o.
1081 * configure.tgt (i386_tobjs): Replace i386.o with arch/i386.o.
1085 * windows-nat.c: Include <algorithm>.
1089 * configure.tgt (i386_tobjs): New variable.
1090 (amd64_tobjs): New variable.
1091 Set $cpu_obs and $os_obs.
1095 * Makefile.in (CONFIG_SRC_SUBDIR): New.
1096 (ALL_64_TARGET_OBS): Replace amd64.o with arch/amd64.o.
1097 (clean): Remove object files and dependency files.
1098 (distclean): Remove the directory.
1099 * configure.ac: Invoke AC_CONFIG_COMMANDS.
1100 * configure: Re-generated.
1101 * configure.tgt: Replace amd64.o with arch/amd64.o.
1106 * arm-tdep.c (arm_decode_misc_memhint_neon): Fix decoding of CPS
1111 * linux-nat.c (linux_child_follow_fork): When following the parent
1112 and detaching the child, consult the parent thread's architecture
1113 instead of the child's.
1117 * ax.h: Do not include "doublest.h".
1118 (union agent_val): Remove.
1122 * dfp.h (MAX_DECIMAL_STRING): Move to dfp.c.
1123 (decimal_to_string): Return std::string object.
1124 (decimal_from_string): Accept std::string object. Return bool.
1125 (decimal_from_integral, decimal_from_doublest): Remove.
1126 (decimal_from_longest): Add prototype.
1127 (decimal_from_ulongest): Likewise.
1128 (decimal_to_longest): Likewise.
1129 (decimal_from_doublest): Likewise.
1130 * dfp.c: Do not include "gdbtypes.h" or "value.h".
1131 (MAX_DECIMAL_STRING): Move here.
1132 (decimal_to_string): Return std::string object.
1133 (decimal_from_string): Accept std::string object. Return bool.
1134 (decimal_from_integral): Remove, replace by ...
1135 (decimal_from_longest, decimal_from_ulongest): ... these new functions.
1136 (decimal_to_longest): New function.
1137 (decimal_from_floating): Remove, replace by ...
1138 (decimal_from_doublest): ... this new function.
1139 (decimal_to_doublest): Update to new decimal_to_string interface.
1141 * value.c (unpack_long): Use decimal_to_longest.
1142 * valops.c (value_cast): Use decimal_from_doublest instead of
1143 decimal_from_floating. Use decimal_from_[u]longest isntead of
1144 decimal_from_integral.
1145 * valarith.c (value_args_as_decimal): Likewise.
1146 * valprint.c (print_decimal_floating): Update to new
1147 decimal_to_string interface.
1148 * printcmd.c (printf_decfloat): Likewise.
1149 * c-exp.y (parse_number): Update to new decimal_from_string interface.
1153 * doublest.h: Do not include "floatformat.h". Remove stale comments.
1154 * gdbtypes.c: Include "floatformat.h".
1155 * value.c: Likewise.
1156 * m68k-tdep.c: Likewise.
1158 * findvar.c: Do not include "floatformat.h".
1159 * amd64-darwin-tdep.c: Likewise.
1160 * arm-linux-tdep.c: Likewise.
1161 * i386-darwin-tdep.c: Likewise.
1162 * i387-tdep.c: Likewise.
1163 * m68k-linux-tdep.c: Likewise.
1164 * mep-tdep.c: Likewise.
1165 * mips-tdep.c: Likewise.
1166 * nios2-tdep.c: Likewise.
1167 * s390-linux-tdep.c: Likewise.
1168 * sparc-obsd-tdep.c: Likewise.
1169 * sparc-tdep.c: Likewise.
1170 * sparc64-tdep.c: Likewise.
1171 * spu-tdep.c: Likewise.
1172 * tic6x-tdep.c: Likewise.
1173 * tilegx-tdep.c: Likewise.
1174 * vax-tdep.c: Likewise.
1175 * xstormy16-tdep.c: Likewise.
1176 * xtensa-tdep.c: Likewise.
1178 * top.c: Do not include "doublest.h".
1179 * aarch64-tdep.c: Likewise.
1180 * alpha-tdep.c: Likewise.
1181 * arm-linux-tdep.c: Likewise.
1182 * m68k-linux-tdep.c: Likewise.
1183 * tilegx-tdep.c: Likewise.
1184 * xstormy16-tdep.c: Likewise.
1188 * mips-fbsd-tdep.c (MIPS_INST_ADDIU_A0_SP_N32): Define.
1189 (mipsn32_fbsd_sigframe): Define.
1190 (mips_fbsd_init_abi): Install mipsn32_fbsd_sigframe unwinder
1191 for FreeBSD/mipsn32.
1195 * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_EHDRFLAGS and
1200 * MAINTAINERS (Misc): Update my email address.
1204 * remote.c (get_remote_arch_state): New 'gdbarch' parameter. Use
1205 it instead of target_gdbarch.
1206 (get_remote_state, get_remote_packet_size): Adjust
1207 get_remote_arch_state calls, passing down target_gdbarch
1209 (packet_reg_from_regnum, packet_reg_from_pnum): New parameter
1210 'gdbarch' and use it instead of target_gdbarch.
1211 (get_memory_packet_size): Adjust get_remote_arch_state calls,
1212 passing down target_gdbarch explicitly.
1213 (struct stop_reply) <arch>: New field.
1214 (remote_parse_stop_reply): Use the stopped thread's architecture,
1215 not the current inferior's. Save the architecture in the
1217 (process_stop_reply): Use the stop reply's architecture.
1218 (process_g_packet, remote_fetch_registers)
1219 (remote_prepare_to_store, store_registers_using_G)
1220 (remote_store_registers): Adjust get_remote_arch_state calls,
1221 using the regcache's architecture.
1222 (remote_get_trace_status): Adjust get_remote_arch_state calls,
1223 passing down target_gdbarch explicitly.
1224 * spu-multiarch.c (spu_thread_architecture): Defer to the target
1225 beneath instead of calling target_gdbarch.
1226 * target.c (default_thread_architecture): Use the specified
1227 inferior's architecture, instead of the current inferior's
1228 architecture (via target_gdbarch).
1232 * regcache.c (get_thread_arch_regcache): Remove null_ptid special
1234 (regcache_print): Handle !target_has_registers here instead.
1238 * frame.c (create_test_frame): Delete.
1239 * frame.h (create_test_frame): Delete.
1240 * gdbarch-selftests.c: Include gdbthread.h and target.h.
1241 (class regcache_test): Delete.
1242 (test_target_has_registers, test_target_has_stack)
1243 (test_target_has_memory, test_target_prepare_to_store)
1244 (test_target_store_registers): New functions.
1245 (test_target_ops): New class.
1246 (register_to_value_test): Error out if there's already a
1247 process_stratum (or higher) target pushed. Create a fuller mock
1248 environment, with mock target_ops, inferior, address space, thread
1250 * progspace.c (struct address_space): Move to ...
1251 * progspace.h (struct address_space): ... here.
1252 * regcache.h (regcache::~regcache, regcache::raw_write)
1253 [GDB_SELF_TEST]: No longer virtual.
1257 * mi/mi-main.c (list_available_thread_groups): Reverse filter logic.
1261 * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Move code
1262 out of 'between TRY and CATCH'.
1266 * cli/cli-cmds.c (complete_command): Add missing END_CATCH.
1267 * common/common-exceptions.h (TRY): Open an outermost scope.
1268 Expand intro comment.
1270 (END_CATCH): Close the outermost scope.
1271 * completer.c (complete_line_internal): Add missing END_CATCH.
1275 * NEWS (Changes since GDB 8.0): Add entry about new
1276 'set-cwd-on-gdbserver' feature.
1277 (New remote packets): Add entry for QSetWorkingDir.
1278 * common/common-inferior.h (set_inferior_cwd): New prototype.
1279 * infcmd.c (set_inferior_cwd): Remove "static".
1280 (show_cwd_command): Expand text to include remote debugging.
1281 * remote.c: Add PACKET_QSetWorkingDir.
1282 (remote_protocol_features) <QSetWorkingDir>: New entry for
1283 PACKET_QSetWorkingDir.
1284 (extended_remote_set_inferior_cwd): New function.
1285 (extended_remote_create_inferior): Call
1286 "extended_remote_set_inferior_cwd".
1287 (_initialize_remote): Call "add_packet_config_cmd" for
1292 * NEWS (New commands): Mention "set/show cwd".
1293 * cli/cli-cmds.c (_initialize_cli_cmds): Mention "set cwd" on
1294 "cd" command's help text.
1295 * common/common-inferior.h (get_inferior_cwd): New prototype.
1296 * infcmd.c (inferior_cwd_scratch): New global variable.
1297 (set_inferior_cwd): New function.
1298 (get_inferior_cwd): Likewise.
1299 (set_cwd_command): Likewise.
1300 (show_cwd_command): Likewise.
1301 (_initialize_infcmd): Add "set/show cwd" commands.
1302 * inferior.h (class inferior) <cwd>: New field.
1303 * nat/fork-inferior.c: Include "gdb_tilde_expand.h".
1304 (fork_inferior): Change inferior's cwd before its execution.
1305 * windows-nat.c (windows_create_inferior): Pass inferior's cwd
1310 * Makefile.in (SFILES): Add gdb_tilde_expand.c.
1311 (HFILES_NO_SRCDIR): Add gdb_tilde_expand.h.
1312 (COMMON_OBS): Add gdb_tilde_expand.o.
1313 * common/gdb_tilde_expand.c: New file.
1314 * common/gdb_tilde_expand.h: Likewise.
1318 * gdbarch.sh (objfile): Remove duplicate declaration.
1319 * gdbarch.h: Regenerate.
1323 * utils.c (internal_vproblem): Use string_vprintf.
1327 * printcmd.c (info_symbol_command): Use std::string.
1331 * top.c (gdb_safe_append_history): Use std::string.
1335 * event-top.c (stdin_event_handler): Update.
1336 * main.c (captured_main_1): Update.
1337 * top.h (make_delete_ui_cleanup): Remove.
1338 (struct ui): Add constructor and destructor.
1339 (new_ui, delete_ui): Remove.
1340 * top.c (make_delete_ui_cleanup): Remove.
1341 (new_ui_command): Use std::unique_ptr.
1342 (delete_ui_cleanup): Remove.
1343 (ui::ui): Rename from new_ui. Update.
1345 (ui::~ui): Rename from delete_ui. Update.
1349 * symfile.c (load_progress): Use gdb::byte_vector.
1353 * mi/mi-main.c (mi_cmd_trace_frame_collected): Remove unused
1355 * printcmd.c (x_command): Remove unused declaration.
1356 * symfile.c (symbol_file_command): Remove unused declaration.
1360 * utils.c (internal_vproblem): Use std::string.
1361 (defaulted_query): Likewise.
1365 * guile/scm-ports.c (ioscm_with_output_to_port_worker): Update.
1366 * top.c (execute_command_to_string): Update.
1367 * utils.c (make_cleanup_restore_page_info): Remove.
1368 (do_restore_page_info_cleanup): Remove.
1369 (set_batch_flag_and_restore_page_info):
1371 (make_cleanup_restore_page_info): Remove.
1372 (set_batch_flag_and_make_cleanup_restore_page_info): Remove.
1373 (~set_batch_flag_and_restore_page_info): New
1374 (make_cleanup_restore_uinteger): Remove.
1375 (make_cleanup_restore_integer): Remove.
1376 (struct restore_integer_closure): Remove.
1377 (restore_integer): Remove.
1378 * utils.h (struct set_batch_flag_and_restore_page_info): New
1380 (set_batch_flag_and_make_cleanup_restore_page_info): Remove.
1381 (make_cleanup_restore_page_info): Remove.
1382 (make_cleanup_restore_uinteger) Remove.
1383 (make_cleanup_restore_integer) Remove.
1387 * record-full.h (record_full_gdb_operation_disable_set): Return
1388 scoped_restore_tmpl<int>.
1389 * infrun.c (adjust_pc_after_break): Update.
1390 (handle_signal_stop): Update.
1391 * record-full.c (record_full_gdb_operation_disable_set): Return
1392 scoped_restore_tmpl<int>.
1393 (record_full_wait_1, record_full_insert_breakpoint)
1394 (record_full_remove_breakpoint, record_full_save)
1395 (record_full_goto_insn): Update.
1400 * rust-lang.c (rust_val_print_str): New function.
1401 (val_print_struct): Call it.
1402 (rust_subscript): Preserve name of slice type.
1406 * rust-lang.c (rust_subscript): Handle slices in
1407 EVAL_AVOID_SIDE_EFFECTS case.
1411 * rust-lang.c (rust_slice_type_p): Recognize &str as a slice type.
1415 * rust-lang.h (rust_slice_type): Add "extern".
1420 * ada-lang.h (ada_exc_info::operator<): Make const.
1421 (ada_exc_info::operator==): Make const.
1422 * ada-lang.c (ada_exc_info::operator<, ada_exc_info::operator==):
1427 * target.c (read_whatever_is_readable): Change type of "result".
1429 (free_memory_read_result_vector): Remove.
1430 (read_memory_robust): Change return type. Update.
1431 * mi/mi-main.c (mi_cmd_data_read_memory_bytes): Update. Use
1432 bin2hex, std::string.
1433 * target.h (memory_read_result_s): Remove typedef.
1434 (free_memory_read_result_vector): Remove.
1435 (read_memory_robust): Return std::vector.
1439 * mi/mi-main.c (captured_mi_execute_command): Use scope_restore.
1443 * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions): Update.
1444 * ada-lang.h (struct ada_exc_info): Remove typedef. Declare
1445 operator< and operator==.
1446 (ada_exceptions_list): Return a std::vector.
1447 * ada-lang.c (ada_exc_info::operator<): Rename from
1448 compare_ada_exception_info.
1449 (ada_exc_info::operator==): New.
1450 (sort_remove_dups_ada_exceptions_list): Change type of
1452 (ada_add_standard_exceptions, ada_add_exceptions_from_frame)
1453 (ada_add_global_exceptions): Likewise.
1454 (ada_exceptions_list_1): Return a std::vector.
1455 (ada_exceptions_list): Likewise.
1459 * mi/mi-main.c (struct print_one_inferior_data) <inferiors>: Now a
1461 (print_one_inferior): Update.
1462 (free_vector_of_ints): Remove.
1463 (list_available_thread_groups): Change "ids" to std::set.
1464 (mi_cmd_list_thread_groups): Update.
1465 (struct collect_cores_data) <core>: Now a std::set.
1466 (collect_cores): Update.
1468 (print_one_inferior): Update.
1472 * mi/mi-main.c (mi_execute_cli_command): Use std::string.
1473 (mi_execute_async_cli_command): Likewise.
1474 (mi_cmd_trace_frame_collected): Use field_fmt.
1478 * mi/mi-main.c (mi_cmd_data_write_memory_bytes): Use
1483 * mi/mi-parse.c (mi_parse): Remove unused declaration.
1487 * mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg".
1491 * varobj.h (varobj_gen_name): Return std::string.
1492 * varobj.c (varobj_gen_name): Return std::string.
1493 * mi/mi-cmd-var.c (mi_cmd_var_create): Use std::string.
1494 (mi_cmd_var_delete): Don't copy "name".
1498 * mi/mi-cmd-break.c (mi_argv_to_format): Return std::string.
1499 (mi_cmd_break_insert_1): Update.
1503 * target.h (make_scoped_defer_target_commit_resume): Update.
1504 * target.c (make_scoped_defer_target_commit_resume): Rename from
1505 make_cleanup_defer_target_commit_resume. Return a
1507 * infrun.c (proceed): Use make_scoped_defer_target_commit_resume.
1511 * main.c (captured_main_1): Remove unused declaration.
1512 * spu-multiarch.c (parse_spufs_run): Remove unused declaration.
1516 * symtab.c (search_symbols): Remove unused outer cleanup.
1517 (make_source_files_completion_list): Remove unused declaration.
1521 * mt-tdep.c (mt_push_dummy_call): Use gdb::byte_vector.
1525 * xstormy16-tdep.c (xstormy16_push_dummy_call): Use
1530 * complaints.c (vcomplaint): Use std::string.
1534 * tracepoint.c (trace_variable_command): Use std::string.
1535 (encode_actions_1): Remove unused declarations.
1536 (create_tsv_from_upload): Use std::string.
1540 * cp-support.c (gdb_demangle): Use std::string.
1544 * stack.c (parse_frame_specification): Use std::string
1545 (info_frame_command): Use gdb::unique_xmalloc_ptr.
1549 * tilegx-tdep.c (tilegx_push_dummy_call): Use gdb::byte_vector.
1553 * utils.c (vfprintf_maybe_filtered): Use std::string.
1554 (vfprintf_unfiltered): Likewise.
1558 * event-top.c (top_level_prompt): Return std::string.
1559 (display_gdb_prompt): Update.
1563 * unittests/common-utils-selftests.c (format): New function.
1564 (string_vprintf_tests): New function.
1565 (_initialize_common_utils_selftests): Register new tests.
1566 * common/common-utils.c (string_vprintf): New function.
1567 * common/common-utils.h (string_vprintf): Declare.
1571 * common/rsp-low.c (unpack_varlen_hex): Constify.
1572 * common/rsp-low.h (unpack_varlen_hex): Constify.
1573 * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
1575 * remote.c (remote_set_permissions, read_ptid)
1576 (remote_current_thread, remote_get_threads_with_qthreadinfo)
1577 (remote_static_tracepoint_marker_at)
1578 (remote_static_tracepoint_markers_by_strid)
1579 (stop_reply_extract_thread, remote_parse_stop_reply): Constify.
1580 * tracepoint.c (parse_trace_status, parse_tracepoint_status)
1581 (parse_tracepoint_definition, parse_tsv_definition)
1582 (parse_static_tracepoint_marker_definition): Constify.
1583 * tracepoint.h (parse_static_tracepoint_marker_definition)
1584 (parse_trace_status, parse_tracepoint_status)
1585 (parse_tracepoint_definition, parse_tsv_definition): Constify.
1589 * remote.c (target_buf, target_buf_size): Delete.
1590 (remote_get_noisy_reply): Remove buf_p and sizeof_buf parameters.
1591 Use the connection's packet buffer instead.
1592 All callers adjusted.
1593 (_initialize_remote): Remove references to target_buf and
1598 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1599 unittests/common-utils-selftests.c.
1600 (SUBDIR_UNITTESTS_OBS): Add common-utils-selftests.o.
1601 (COMMON_OBS): Remove utils-selftests.o.
1602 * utils-selftests.c: Move to ...
1603 * unittests/common-utils-selftests.c: ... here and rename self
1604 test to "string_printf".
1608 * dwarf2read.c (open_and_init_dwp_file): Protect against dwp_file
1609 having NULL cus or tus.
1613 * arm-tdep.c: (convert_from_extended): Remove.
1614 (convert_to_extended): Likewise.
1615 (arm_extract_return_value): Use convert_typed_floating.
1616 (arm_store_return_value): Likewise.
1618 * sh-tdep.h (struct gdbarch_tdep): Add sh_littlebyte_bigword_type.
1619 * sh-tdep.c: Do not include "floatformat.h".
1620 (sh_littlebyte_bigword_type): New function.
1621 (sh_register_convert_to_virtual): Use convert_typed_floating.
1622 (sh_register_convert_to_raw): Likewise.
1623 * sh64-tdep.c: (struct gdbarch_tdep): Add sh_littlebyte_bigword_type.
1624 (sh64_littlebyte_bigword_type): New function.
1625 (sh64_extract_return_value): Use convert_typed_floating.
1626 (sh64_register_convert_to_virtual): Likewise.
1627 (sh64_register_convert_to_raw): Likewise.
1631 * doublest.h (floatformat_from_type): Move to gdbtypes.h.
1632 * doublest.c (floatformat_from_type): Move to gdbtypes.c.
1634 * gdbtypes.h (union type_specific): Make field floatformat hold
1635 just a single struct floatformat, not an array.
1636 (floatformat_from_type): Move here.
1637 * gdbtypes.c (floatformat_from_type): Move here. Update to
1638 changed TYPE_FLOATFORMAT definition.
1639 (verify_floatformat): Update to changed TYPE_FLOATFORMAT.
1640 (recursive_dump_type): Likewise.
1641 (init_float_type): Install correct floatformat for byte order.
1642 (arch_float_type): Likewise.
1646 * gdbtypes.c (init_type): Change incoming argument from
1647 length-in-bytes to length-in-bits. Assert length is a
1648 multiple of TARGET_CHAR_BITS.
1649 (arch_type, arch_flags_type): Likewise.
1650 (init_integer_type): Update call to init_type.
1651 (init_character_type): Likewise.
1652 (init_boolean_type): Likewise.
1653 (init_float_type): Likewise.
1654 (init_decfloat_type): Likewise.
1655 (init_complex_type): Likewise.
1656 (init_pointer_type): Likewise.
1657 (objfile_type): Likewise.
1658 (arch_integer_type): Update call to arch_type.
1659 (arch_character_type): Likewise.
1660 (arch_boolean_type): Likewise.
1661 (arch_float_type): Likewise.
1662 (arch_decfloat_type): Likewise.
1663 (arch_complex_type): Likewise.
1664 (arch_pointer_type): Likewise.
1665 (gdbtypes_post_init): Likewise.
1667 * dwarf2read.c (dwarf2_init_float_type): Update call to init_type.
1668 (read_base_type): Likewise.
1669 * mdebugread.c (basic_type): Likewise.
1670 * stabsread.c (dbx_init_float_type): Likewise.
1671 (rs6000_builtin_type): Likewise.
1672 (read_range_type): Likewise. Also, fix call to init_integer_type
1673 with erroneous length argument.
1675 * ada-lang.c (ada_language_arch_info): Update call to arch_type.
1676 * d-lang.c (build_d_types): Likewise.
1677 * f-lang.c (build_fortran_types): Likewise.
1678 * go-lang.c (build_go_types): Likewise.
1679 * opencl-lang.c (build_opencl_types): Likewise.
1680 * jit.c (finalize_symtab): Likewise.
1681 * gnu-v3-abi.c (build_gdb_vtable_type): Likewise.
1682 (build_std_type_info_type): Likewise.
1683 * target-descriptions.c (tdesc_gdb_type): Likewise. Also,
1684 update call to arch_flags_type.
1686 * linux-tdep.c (linux_get_siginfo_type_with_fields): Update call to
1688 * fbsd-tdep.c (fbsd_get_siginfo_type): Likewise.
1689 * windows-tdep.c (windows_get_tlb_type): Likewise.
1691 * avr-tdep.c (avr_gdbarch_init): Update call to arch_type.
1692 * ft32-tdep.c (ft32_gdbarch_init): Likewise.
1693 * m32c-tdep.c (make_types): Likewise.
1694 * rl78-tdep.c (rl78_gdbarch_init): Likewise.
1695 (rl78_psw_type): Update call to arch_flags_type.
1696 * m68k-tdep.c (m68k_ps_type): Update call to arch_flags_type.
1697 * rx-tdep.c (rx_psw_type): Likewise.
1698 (rx_fpsw_type): Likewise.
1699 * sparc-tdep.c (sparc_psr_type): Likewise.
1700 (sparc_fsr_type): Likewise.
1701 * sparc64-tdep.c (sparc64_pstate_type): Likewise.
1702 (sparc64_ccr_type): Likewise.
1703 (sparc64_fsr_type): Likewise.
1704 (sparc64_fprs_type): Likewise.
1708 * findcmd.c (find_command): Constify.
1712 * ada-tasks.c (task_command_1, task_command): Constify.
1716 * symtab.c (maintenance_print_symbol_cache)
1717 (maintenance_flush_symbol_cache)
1718 (maintenance_print_symbol_cache_statistics): Constify.
1722 * inferior.c (detach_inferior_command, kill_inferior_command)
1723 (inferior_command): Constify.
1727 * regcache.c (regcache_print, maintenance_print_registers)
1728 (maintenance_print_raw_registers)
1729 (maintenance_print_cooked_registers)
1730 (maintenance_print_register_groups)
1731 (maintenance_print_remote_registers): Constify.
1735 * printcmd.c (map_display_numbers, undisplay_command)
1736 (enable_disable_display_command, enable_display_command)
1737 (disable_display_command): Constify.
1741 * breakpoint.h (delete_command): Don't declare.
1742 * breakpoint.c (delete_command, enable_once_command)
1743 (enable_count_command, enable_delete_command, breakpoint_1)
1744 (maintenance_info_breakpoints, stopin_command, stopat_command)
1745 (delete_command, delete_trace_command, save_breakpoints)
1746 (save_breakpoints_command, save_tracepoints_command): Constify.
1750 * macrocmd.c (macro_expand_command, macro_expand_once_command)
1751 (skip_ws, extract_identifier, macro_define_command)
1752 (macro_undef_command, macro_list_command): Constify.
1756 * infcmd.c (environment_info, set_environment_command)
1757 (unset_environment_command, path_info, info_proc_cmd_1)
1758 (info_proc_cmd_mappings, info_proc_cmd_stat)
1759 (info_proc_cmd_status, info_proc_cmd_cwd, info_proc_cmd_cmdline)
1760 (info_proc_cmd_exe, info_proc_cmd_all): Constify.
1764 * i386-tdep.c (i386_mpx_info_bounds, i386_mpx_set_bounds):
1769 * symfile-mem.c (add_symbol_file_from_memory_command): Constify.
1773 * demangle.c (demangle_command): Constify.
1777 * progspace.c (maintenance_info_program_spaces_command):
1782 * compile/compile.c (check_raw_argument, compile_file_command)
1783 (compile_code_command, compile_print_command): Constify.
1787 * reggroups.c (maintenance_print_reggroups): Constify.
1791 * dwarf2read.c (save_gdb_index_command): Constify.
1795 * stap-probe.c (info_probes_stap_command): Constify.
1799 * fork-child.c (unset_exec_wrapper_command): Constify.
1803 * btrace.c (get_uint, get_context_size, no_chunk)
1804 (maint_btrace_packet_history_cmd)
1805 (maint_btrace_clear_packet_history_cmd, maint_btrace_clear_cmd)
1806 (maint_info_btrace_cmd): Constify.
1810 * reverse.c (delete_bookmark_command): Constify.
1814 * remote.c (set_memory_packet_size)
1815 (set_memory_write_packet_size, show_memory_write_packet_size)
1816 (set_memory_read_packet_size, show_memory_read_packet_size)
1817 (compare_sections_command, packet_command, remote_put_command)
1818 (remote_get_command, remote_delete_command): Constify.
1822 * mips-tdep.c (show_mipsfpu_command, set_mipsfpu_single_command)
1823 (set_mipsfpu_double_command, set_mipsfpu_none_command)
1824 (set_mipsfpu_auto_command): Constify.
1828 * cli/cli-cmds.h (cd_command): Constify.
1829 * cli/cli-cmds.c (cd_command): Constify.
1833 * thread.c (thread_name_command, thread_find_command): Constify.
1837 * probe.c (enable_probes_command, disable_probes_command):
1842 * symfile.c (symbol_file_command): Constify.
1843 * gdbcore.h (deprecated_file_changed_hook): Constify.
1844 * exec.c (deprecated_file_changed_hook, exec_file_command)
1845 (file_command): Constify.
1846 * defs.h (symbol_file_command): Constify.
1850 * remote-fileio.c (set_system_call_allowed)
1851 (show_system_call_allowed): Constify.
1855 * tracepoint.c (delete_trace_variable_command)
1856 (tfind_end_command, tfind_start_command, tfind_pc_command)
1857 (tfind_tracepoint_command, tfind_line_command)
1858 (tfind_range_command, tfind_outside_command): Constify.
1862 * ax-gdb.c (maint_agent_printf_command, agent_command)
1863 (agent_eval_command): Constify.
1867 * tracepoint.c (info_scope_command): Constify.
1868 * python/python.c (gdbpy_decode_line): Constify.
1869 * python/py-breakpoint.c (bppy_init): Constify.
1870 * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Constify.
1871 * location.h: (new_linespec_location)
1872 (string_to_event_location_basic, string_to_event_location):
1874 * location.c (new_linespec_location)
1875 (string_to_event_location_basic, string_to_event_location):
1877 * linespec.h (decode_line_with_current_source)
1878 (decode_line_with_last_displayed, linespec_lex_to_end): Constify.
1879 * linespec.c (linespec_lex_to_end)
1880 (decode_line_with_current_source)
1881 (decode_line_with_last_displayed): Constify.
1882 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x):
1884 * cli/cli-cmds.c (edit_command, list_command): Constify.
1885 * breakpoint.h (until_break_command, watch_command_wrapper)
1886 (awatch_command_wrapper, rwatch_command_wrapper)
1887 (init_ada_exception_breakpoint): Constify.
1888 * breakpoint.c (break_command_1, dprintf_command)
1889 (break_range_command, watch_command_wrapper)
1890 (rwatch_command_wrapper, awatch_command_wrapper)
1891 (until_break_command, init_ada_exception_breakpoint)
1892 (strace_marker_create_sals_from_location, trace_command)
1893 (ftrace_command, strace_command, struct tracepoint): Constify.
1894 * ax-gdb.c (agent_command_1): Constify.
1895 * ada-lang.c (ada_exception_sal): Constify.
1899 * record.c (cmd_record_delete, cmd_record_stop, cmd_record_save)
1900 (cmd_record_goto_begin, cmd_record_goto_end, get_insn_number)
1901 (get_context_size, no_chunk, get_insn_history_modifiers)
1902 (cmd_record_insn_history, get_call_history_modifiers)
1903 (cmd_record_call_history): Constify.
1907 * source.c (show_substitute_path_command)
1908 (unset_substitute_path_command, set_substitute_path_command):
1913 * typeprint.c (maintenance_print_type): Constify.
1914 * maint.c (maintenance_dump_me, maintenance_demangle)
1915 (maintenance_time_display, maintenance_info_sections)
1916 (maintenance_print_statistics, maintenance_deprecate)
1917 (maintenance_undeprecate): Constify.
1918 (maintenance_do_deprecate): Constify. Use std::string.
1919 (maintenance_selftest): Constify.
1920 * gdbtypes.h (maintenance_print_type): Constify.
1924 * hppa-tdep.c (unwind_command): Constify.
1928 * target-descriptions.c (unset_tdesc_filename_cmd)
1929 (maint_print_c_tdesc_cmd, maintenance_check_xml_descriptions):
1934 * dummy-frame.c (maintenance_print_dummy_frames): Constify.
1938 * tui/tui.c (tui_enable_command, tui_disable_command): Constify.
1942 * tui/tui-regs.c (tui_reg_command): Constify.
1946 * skip.c (skip_file_command, skip_function_command)
1947 (skip_enable_command, skip_disable_command, skip_delete_command):
1952 * record-btrace.c (cmd_record_btrace_bts_start)
1953 (cmd_record_btrace_pt_start): Constify.
1957 * symmisc.c (maintenance_print_symbols)
1958 (maintenance_print_msymbols, maintenance_print_objfiles)
1959 (maintenance_info_symtabs, maintenance_check_symtabs)
1960 (maintenance_expand_symtabs, maintenance_info_line_tables):
1965 * top.c (new_ui_command): Constify.
1969 * symfile.c (add_symbol_file_command)
1970 (remove_symbol_file_command, list_overlays_command)
1971 (map_overlay_command, unmap_overlay_command)
1972 (overlay_auto_command, overlay_manual_command)
1973 (overlay_off_command, overlay_load_command): Constify.
1977 * spu-tdep.c (info_spu_event_command, info_spu_signal_command)
1978 (info_spu_mailbox_command, info_spu_dma_command)
1979 (info_spu_proxydma_command): Constify.
1983 * cli/cli-logging.c (set_logging_on, set_logging_off): Constify.
1987 * cli/cli-script.c (user_defined_command): Constify.
1991 * cli/cli-dump.c (dump_memory_command, dump_value_command)
1992 (dump_srec_memory, dump_srec_value, dump_ihex_memory)
1993 (dump_ihex_value, dump_verilog_memory, dump_verilog_value)
1994 (dump_tekhex_memory, dump_tekhex_value, dump_binary_memory)
1995 (dump_binary_value, append_binary_memory, append_binary_value):
1997 (struct dump_context) <func>: Constify.
1998 (add_dump_command): Update.
2002 * cli/cli-cmds.c (show_version, show_configuration)
2003 (source_command, show_user): Constify.
2007 * target.c (maintenance_print_target_stack): Constify.
2011 * interps.c (interpreter_exec_cmd): Constify.
2015 * record-full.c (cmd_record_full_restore): Constify.
2019 * memattr.c (enable_mem_command, disable_mem_command)
2020 (delete_mem_command): Constify.
2024 * value.c (show_convenience): Constify.
2028 * gdbcore.h (core_file_command): Update.
2029 * corefile.c (core_file_command): Constify.
2033 * user-regs.c (maintenance_print_user_registers): Constify.
2037 * cp-namespace.c (maintenance_cplus_namespace): Constify.
2041 * cp-support.c (first_component_command): Constify.
2045 * psymtab.c (maintenance_print_psymbols)
2046 (maintenance_info_psymtabs, maintenance_check_psymtabs):
2051 * windows-tdep.c (display_tib): Constify.
2055 * linux-fork.c (delete_checkpoint_command)
2056 (detach_checkpoint_command): Constify.
2060 * cp-abi.c (set_cp_abi_cmd, show_cp_abi_cmd): Constify.
2064 * arc-tdep.c (dump_arc_instruction_command): Constify.
2068 * valprint.c (set_radix, show_radix): Constify.
2072 * dtrace-probe.c (info_probes_dtrace_command): Constify.
2076 * command.h (not_just_help_class_command): Update.
2077 * cli/cli-decode.h (not_just_help_class_command): Update.
2078 * cli/cli-decode.c (not_just_help_class_command): Constify.
2082 * gdb_bfd.c (maintenance_info_bfds): Constify.
2086 * cli/cli-decode.c (add_cmd, set_cmd_cfunc): New function
2088 (do_add_cmd): Rename from add_cmd. Don't call set_cmd_cfunc.
2089 (do_const_cfunc): New function.
2090 (cmd_cfunc_eq): New overload.
2091 (cli_user_command_p): Check do_const_cfunc.
2092 * cli/cli-decode.h (struct cmd_list_element) <function>: New field
2094 * command.h (add_cmd): Add const overload and no-function
2096 (set_cmd_cfunc): Add const overload.
2097 (cmd_const_cfunc_ftype): Declare.
2098 (cmd_cfunc_eq): Add const overload.
2099 * breakpoint.c, cli-cmds.c, cli-dump.c, guile/scm-cmd.c,
2100 python/py-cmd.c, target.c, tracepoint.c: Use no-function add_cmd
2105 * macroexp.c (get_next_token_for_substitution): New function.
2106 (substitute_args): Call it. Check for __VA_OPT__.
2111 * dwarf2read.c (dwarf2_cu): Remove field producer_is_icc and add
2112 producer_is_icc_lt_14.
2113 (producer_is_icc_lt_14): New function.
2114 (check_producer): Add code for checking version of ICC.
2115 (producer_is_icc): Move to producer.c.
2116 (read_structure_type): Restrict ICC workaround to ICC<14.
2117 * producer.c: Include selftest.h.
2118 (producer_is_icc, producer_parsing_tests, _initialize_producer):
2120 * producer.h (producer_is_icc): New declaration.
2124 * Makefile.in (SFILES): Add producer.c.
2125 (COMMON_OBS): Add producer.o
2126 * amd64-tdep.c (producer.h): Add new include.
2127 * dwarf2read.c (producer.h): Add new include.
2128 * producer.c: New file.
2129 * producer.h: New file.
2130 * utils.c (producer_is_gcc, producer_is_gcc_ge_4): Move to
2132 * utils.h (producer_is_gcc, producer_is_gcc_ge_4): Move to
2137 * configure.ac: Search ncursesw before ncurses.
2138 Check ncursesw/ncurses.h before ncurses/ncurses.h.
2139 * gdb_curses.h: Include <ncursesw/ncurses.h>
2140 * config.in, configure: Regenerate.
2145 * configure.host <*-*-solaris2.[01], *-*-solaris2.[2-9]*>: Mark as
2147 Use gdb_host sol2 for i[34567]86-*-solaris2*, x86_64-*-solaris2*.
2148 Remove i386sol2 support.
2149 * configure.nat <i386sol2>: Remove.
2150 <sol2-64>: Fold into ...
2152 Move common settings to default section.
2154 * configure.tgt <i[34567]86-*-solaris2.1[0-9]*,
2155 x86_64-*-solaris2.1[0-9]*>: Rename to ...
2156 <i[34567]86-*-solaris2*, x86_64-*-solaris2*>: ... this.
2157 <i[34567]86-*-solaris*>: Remove.
2158 <sparc-*-solaris2.[0-6], sparc-*-solaris2.[0-6].*>: Remove.
2160 * configure.ac: Remove wctype in libw check.
2161 (_MSE_INT_H): Don't define on Solaris 7-9.
2162 <solaris*>: Remove libthread_db.so.1 check.
2163 * configure: Regenerate.
2164 * config.in: Regenerate.
2166 * proc-service.c: Remove PROC_SERVICE_IS_OLD handling.
2167 (gdb_ps_prochandle_t, gdb_ps_read_buf_t, gdb_ps_write_buf_t)
2168 (gdb_ps_size_t): Remove.
2169 Use base types in users.
2170 * sol-thread.c: Likewise, also for gdb_ps_addr_t.
2172 * NEWS (Changes since GDB 8.0): Document Solaris 2.0-9 removal.
2177 * sparc64-tdep.c (adi_tag_fd): Print pid as long.
2178 (adi_is_addr_mapped): Likewise.
2179 (PSR_ICC): Don't redefine.
2180 (PSR_IMPL): Likewise.
2184 * regcache.c (regcache::dump): Use string_printf.
2188 * regcache.c (class regcache_invalidator): New.
2189 (struct register_to_invalidate): Remove.
2190 (make_cleanup_regcache_invalidate): Remove.
2191 (regcache::raw_write): Use regcache_invalidator.
2195 * spu-tdep.c (spu2ppu_sniffer): Update.
2196 * regcache.h (make_cleanup_regcache_xfree): Don't declare.
2197 * regcache.c (do_regcache_xfree, make_cleanup_regcache_xfree):
2199 * ppc-linux-tdep.c (ppu2spu_sniffer): Update.
2200 * mi/mi-main.c (mi_cmd_data_list_changed_registers): Update.
2201 * frame.h (frame_save_as_regcache): Return std::unique_ptr.
2202 * frame.c (frame_save_as_regcache): Return std::unique_ptr.
2203 (frame_pop): Update.
2207 * spu-tdep.c (spu2ppu_dealloc_cache): Use delete.
2208 * regcache.h (regcache_xfree): Don't declare.
2209 * regcache.c (regcache_xfree): Remove.
2210 (do_regcache_xfree): Use delete.
2211 * ppc-linux-tdep.c (ppu2spu_dealloc_cache): Use delete.
2212 * linux-fork.c (free_fork): Use delete.
2213 (fork_save_infrun_state): Likewise.
2214 * jit.c (jit_dealloc_cache): Use delete.
2215 * infrun.c (discard_infcall_suspend_state): Use delete.
2219 * regcache.h (regcache_xmalloc): Don't declare.
2220 (regcache_raw_set_cached_value): Update comment.
2221 * regcache.c (regcache_xmalloc): Remove.
2222 * ppc-linux-tdep.c (ppu2spu_sniffer): Use new.
2223 * jit.c (jit_frame_sniffer): Use new.
2224 * frame.c (frame_save_as_regcache): Use new.
2228 * NEWS: Advertise support for guarded-storage registers on IBM z.
2232 * s390-linux-nat.c (have_regset_gs): New static variable.
2233 (s390_linux_fetch_inferior_registers): Handle guarded-storage
2234 control block and guarded-storage broadcast control regsets.
2235 (s390_read_description): Detect whether the target has
2236 guarded-storage support, return appropriate tdesc.
2237 * s390-linux-tdep.c (features/s390-gs-linux64.c): New include.
2238 (features/s390x-gs-linux64.c): Likewise.
2239 (struct gdbarch_tdep) <have_gs>: New field.
2240 (s390_regmap_gs, s390_regmap_gsbc, s390_gs_regset)
2241 (s390_gsbc_regset): New variables.
2242 (s390_iterate_over_regset_sections): Iterate over s390_gs_regset
2243 and s390_gsbc_regset, if applicable.
2244 (s390_core_read_description): Check whether core file was from a
2245 target with guarded-storage support; include appropriate regsets.
2246 (s390_gdbarch_init): Add registers for guarded-storage support.
2247 (_initialize_s390_tdep): Initialize new target descriptions that
2248 include registers for guarded-storage support.
2249 * s390-linux-tdep.h (HWCAP_S390_GS, S390_GSD_REGNUM)
2250 (S390_GSSM_REGNUM, S390_GSEPLA_REGNUM)
2251 (S390_BC_GSD_REGNUM, S390_BC_GSSM_REGNUM): New defines.
2252 (S390_NUM_REGS): Adjust macro definition.
2253 (s390_gs_regset, s390_gsbc_regset, tdesc_s390_gs_linux64)
2254 (tdesc_s390x_gs_linux64): New declarations.
2258 * features/s390-gs-linux64.xml: New file.
2259 * features/s390-gs.xml: New file.
2260 * features/s390-gsbc.xml: New file.
2261 * features/s390x-gs-linux64.xml: New file.
2262 * features/Makefile (WHICH): Add s390-gs-linux64 and
2264 (s390-gs-linux64-expedite, s390x-gs-linux64-expedite): New macros.
2265 (XMLTOC): Add s390-gs-linux64.xml and s390x-linux64.xml.
2266 * features/s390-gs-linux64.c: New generated file.
2267 * features/s390x-gs-linux64.c: New file.
2268 * regformats/s390-gs-linux64.dat: New file.
2269 * regformats/s390x-gs-linux64.dat: New file.
2273 * defs.h (make_cleanup_override_quit_handler): Don't declare.
2277 * utils.c (class scoped_input_handler) <m_quit_handler>: Change
2278 type to scoped_restore_tmpl.
2279 <scoped_input_handler>: Initialize m_quit_handler directly.
2283 * cli/cli-cmds.c (pwd_command): Use "getcwd (NULL, 0)".
2284 (cd_command): Likewise. Free "current_directory" before
2286 * main.c (captured_main_1): Use "getcwd (NULL, 0)".
2287 * mi/mi-cmd-env.c (mi_cmd_env_pwd): Likewise.
2288 * top.c (gdb_dirbuf): Remove global declaration.
2289 * top.h (gdb_dirbuf): Likewise.
2293 * gnulib/aclocal.m4: Regenerate.
2294 * gnulib/config.in: Regenerate.
2295 * gnulib/configure: Regenerate.
2296 * gnulib/import/Makefile.am: Regenerate.
2297 * gnulib/import/Makefile.in: Regenerate.
2298 * gnulib/import/assure.h: New file.
2299 * gnulib/import/at-func.c: Likewise
2300 * gnulib/import/chdir-long.c: New file.
2301 * gnulib/import/chdir-long.h: New file.
2302 * gnulib/import/cloexec.c: New file.
2303 * gnulib/import/cloexec.h: New file.
2304 * gnulib/import/close.c: New file.
2305 * gnulib/import/closedir.c: New file.
2306 * gnulib/import/dirent-private.h: New file.
2307 * gnulib/import/dup-safer.c: New file.
2308 * gnulib/import/dup.c: New file.
2309 * gnulib/import/dup2.c: New file.
2310 * gnulib/import/error.c: New file.
2311 * gnulib/import/error.h: New file.
2312 * gnulib/import/exitfail.c: New file.
2313 * gnulib/import/exitfail.h: New file.
2314 * gnulib/import/fchdir.c: New file.
2315 * gnulib/import/fcntl.c: New file.
2316 * gnulib/import/fcntl.in.h: New file.
2317 * gnulib/import/fd-hook.c: New file.
2318 * gnulib/import/fd-hook.h: New file.
2319 * gnulib/import/fd-safer.c: New file.
2320 * gnulib/import/fdopendir.c: New file.
2321 * gnulib/import/filename.h: New file.
2322 * gnulib/import/filenamecat-lgpl.c: New file.
2323 * gnulib/import/filenamecat.h: New file.
2324 * gnulib/import/fstat.c: New file.
2325 * gnulib/import/fstatat.c: New file.
2326 * gnulib/import/getcwd-lgpl.c: New file.
2327 * gnulib/import/getcwd.c: New file.
2328 * gnulib/import/getdtablesize.c: New file.
2329 * gnulib/import/getlogin_r.c: New file.
2330 * gnulib/import/getprogname.c: New file.
2331 * gnulib/import/getprogname.h: New file.
2332 * gnulib/import/gettext.h: New file.
2333 * gnulib/import/glob-libc.h: New file.
2334 * gnulib/import/glob.c: New file.
2335 * gnulib/import/glob.in.h: New file.
2336 * gnulib/import/intprops.h: New file.
2337 * gnulib/import/m4/chdir-long.m4: New file.
2338 * gnulib/import/m4/close.m4: New file.
2339 * gnulib/import/m4/closedir.m4: New file.
2340 * gnulib/import/m4/d-ino.m4: New file.
2341 * gnulib/import/m4/d-type.m4: New file.
2342 * gnulib/import/m4/dup.m4: New file.
2343 * gnulib/import/m4/dup2.m4: New file.
2344 * gnulib/import/m4/error.m4: New file.
2345 * gnulib/import/m4/fchdir.m4: New file.
2346 * gnulib/import/m4/fcntl.m4: New file.
2347 * gnulib/import/m4/fcntl_h.m4: New file.
2348 * gnulib/import/m4/fdopendir.m4: New file.
2349 * gnulib/import/m4/filenamecat.m4: New file.
2350 * gnulib/import/m4/fstat.m4: New file.
2351 * gnulib/import/m4/fstatat.m4: New file.
2352 * gnulib/import/m4/getcwd-abort-bug.m4: New file.
2353 * gnulib/import/m4/getcwd-path-max.m4: New file.
2354 * gnulib/import/m4/getcwd.m4: New file.
2355 * gnulib/import/m4/getdtablesize.m4: New file.
2356 * gnulib/import/m4/getlogin_r.m4: New file.
2357 * gnulib/import/m4/getprogname.m4: New file.
2358 * gnulib/import/m4/glob.m4: New file.
2359 * gnulib/import/m4/gnulib-cache.m4: Regenerate.
2360 * gnulib/import/m4/gnulib-comp.m4: Regenerate.
2361 * gnulib/import/m4/mempcpy.m4: New file.
2362 * gnulib/import/m4/memrchr.m4: New file.
2363 * gnulib/import/m4/mode_t.m4: New file.
2364 * gnulib/import/m4/msvc-inval.m4: New file.
2365 * gnulib/import/m4/msvc-nothrow.m4: New file.
2366 * gnulib/import/m4/open.m4: New file.
2367 * gnulib/import/m4/openat.m4: New file.
2368 * gnulib/import/m4/opendir.m4: New file.
2369 * gnulib/import/m4/readdir.m4: New file.
2370 * gnulib/import/m4/realloc.m4: New file.
2371 * gnulib/import/m4/rewinddir.m4: New file.
2372 * gnulib/import/m4/save-cwd.m4: New file.
2373 * gnulib/import/m4/strdup.m4: New file.
2374 * gnulib/import/m4/strerror.m4: New file.
2375 * gnulib/import/m4/unistd-safer.m4: New file.
2376 * gnulib/import/mempcpy.c: New file.
2377 * gnulib/import/memrchr.c: New file.
2378 * gnulib/import/msvc-inval.c: New file.
2379 * gnulib/import/msvc-inval.h: New file.
2380 * gnulib/import/msvc-nothrow.c: New file.
2381 * gnulib/import/msvc-nothrow.h: New file.
2382 * gnulib/import/open.c: New file.
2383 * gnulib/import/openat-die.c: New file.
2384 * gnulib/import/openat-priv.h: New file.
2385 * gnulib/import/openat-proc.c: New file.
2386 * gnulib/import/openat.c: New file.
2387 * gnulib/import/openat.h: New file.
2388 * gnulib/import/opendir.c: New file.
2389 * gnulib/import/pipe-safer.c: New file.
2390 * gnulib/import/readdir.c: New file.
2391 * gnulib/import/realloc.c: New file.
2392 * gnulib/import/rewinddir.c: New file.
2393 * gnulib/import/save-cwd.c: New file.
2394 * gnulib/import/save-cwd.h: New file.
2395 * gnulib/import/strdup.c: New file.
2396 * gnulib/import/strerror-override.c: New file.
2397 * gnulib/import/strerror-override.h: New file.
2398 * gnulib/import/strerror.c: New file.
2399 * gnulib/import/unistd--.h: New file.
2400 * gnulib/import/unistd-safer.h: New file.
2401 * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add
2402 "getcwd" and "glob".
2403 * ser-tcp.c: Undefine "close" before redefining it.
2407 * guile/scm-value.c (gdbscm_value_address): Initialize address,
2412 * configure.nat <i386sol2,i386>: Add fork-inferior.o to NATDEPFILES.
2413 <sol2,sparc>: Likewise.
2414 <sol2-64,i386>: Likewise.
2416 * warning.m4 (AM_GDB_WARNINGS): Disable -Wunknown-pragmas,
2417 -Wdeprecated-declarations on *-*-solaris*.
2418 * configure: Regenerate.
2420 * procfs.c: Include "nat/inferior.h".
2421 (procfs_info_proc): Fix typo.
2425 * remote.c (vector): Include.
2426 (struct private_thread_info): Add field, thread_handle.
2427 (free_private_thread_info): Deallocate storage associated with
2429 (get_private_info_thread): Initialize `thread_handle' field.
2430 (struct thread_item): Add field, thread_handle.
2431 (clear_threads_listing_context): Deallocate storage associated
2433 (start_thread): Add support for "handle" attribute.
2434 (thread_attributes): Add "handle".
2435 (remote_get_threads_with_qthreadinfo): Initialize thread_handle
2437 (remote_update_thread_list): Update thread_handle.
2438 (remote_thread_handle_to_thread_info): New function.
2439 (init_remote_ops): Initialize to_thread_handle_to_thread_info.
2443 * python/py-inferior.c (gdbpy_thread_from_thread_handle): New
2445 (inferior_object_methods): Add gdbpy_thread_from_thread_handle.
2446 * python/python-internal.h (thread_object_type): Declare.
2450 * target.h (struct target_ops): Add to_thread_handle_to_thread_info.
2451 (target_thread_handle_to_thread_info): Declare.
2452 * target.c (target_thread_handle_to_thread_info): New function.
2453 * target-delegates.c: Regenerate.
2454 * gdbthread.h (find_thread_by_handle): Declare.
2455 * thread.c (find_thread_by_handle): New function.
2456 * linux-thread-db.c (thread_db_thread_handle_to_thread_info): New
2458 (init_thread_db_ops): Register thread_db_thread_handle_to_thread_info.
2462 * nat/linux-waitpid.c (linux_debug): Add ATTRIBUTE_PRINTF.
2466 * microblaze-tdep.c (microblaze_debug): Add ATTRIBUTE_PRINTF.
2470 * configure.tgt (aarch64*-*-freebsd*): Add fbsd-tdep.o solib-svr4.o
2475 * breakpoint.c (struct counted_command_line): Remove.
2476 (breakpoint_commands): Update.
2477 (alloc_counted_command_line, incref_counted_command_line)
2478 (decref_counted_command_line, do_cleanup_counted_command_line)
2479 (make_cleanup_decref_counted_command_line): Remove.
2480 (breakpoint_set_commands, commands_command_1, ~bpstats, bpstats)
2481 (bpstat_clear_actions, bpstat_do_actions_1, watchpoint_check)
2482 (bpstat_stop_status, print_one_breakpoint_location, ~breakpoint)
2483 (save_breakpoints): Update.
2484 * breakpoint.h (counted_command_line): Now a typedef to
2486 (struct breakpoint) <commands>: Now a counted_command_line.
2487 (struct bpstats) <command>: Likewise.
2491 * breakpoint.c (struct commands_info, do_map_commands_command):
2493 (commands_command_1): Update.
2494 (iterate_over_related_breakpoints): Take a function_view.
2495 (do_delete_breakpoint, do_map_delete_breakpoint): Remove.
2496 (delete_command): Update.
2497 (map_breakpoint_numbers): Take a function_view.
2498 (do_disable_breakpoint, do_map_delete_breakpoint): Remove.
2499 (disable_command): Update.
2500 (do_enable_breakpoint, do_map_enable_breakpoint): Remove.
2501 (enable_command): Update.
2502 (struct disp_data, do_enable_breakpoint_disp)
2503 (do_map_enable_once_breakpoint, do_map_enable_count_breakpoint)
2504 (do_map_enable_delete_breakpoint): Remove.
2505 (enable_once_command, enable_count_command, enable_delete_command)
2506 (delete_trace_variable_command): Update.
2510 * breakpoint.c (~bpstats): Rename from bpstat_free. Update.
2511 (bpstat_clear): Use delete.
2512 (bpstats): New constructors.
2513 (bpstat_copy, bpstat_stop_status): Use new.
2514 (dprintf_after_condition_true): Update.
2515 * breakpoint.h (bpstats::bpstats): Add constructors.
2516 (bpstats::~bpstats): Add destructor.
2520 * eval.c (make_params): Delete, refactored as ...
2521 (class fake_method): ... this new type's ctor.
2522 (fake_method::~fake_method): New.
2523 (evaluate_subexp_standard): Use 'fake_method'.
2527 * windows-nat.c (get_windows_debug_event, windows_wait)
2528 (do_initial_windows_stuff, windows_attach): Update.
2529 * utils.c (vwarning, internal_vproblem): Update.
2530 (ui_unregister_input_event_handler_cleanup)
2531 (prepare_to_handle_input): Remove.
2532 (class scoped_input_handler): New.
2533 (defaulted_query, prompt_for_continue): Update.
2534 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
2536 * top.c (undo_terminal_modifications_before_exit): Update.
2537 * target/target.h (target_terminal_init, target_terminal_inferior)
2538 (target_terminal_ours): Don't declare.
2539 (class target_terminal): New.
2540 * target.h (target_terminal_is_inferior, target_terminal_is_ours)
2541 (target_terminal_ours_for_output)
2542 (make_cleanup_restore_target_terminal): Don't declare.
2543 (target_terminal_info): Remove.
2544 * target.c (enum terminal_state, terminal_state): Remove.
2545 (target_terminal::terminal_state): Define.
2546 (target_terminal::init): Rename from target_terminal_init.
2547 (target_terminal::inferior): Rename from
2548 target_terminal_inferior.
2549 (target_terminal::ours): Rename from target_terminal_ours.
2550 (target_terminal::ours_for_output): Rename from
2551 target_terminal_ours_for_output.
2552 (target_terminal::info): New method.
2553 (cleanup_restore_target_terminal)
2554 (make_cleanup_restore_target_terminal): Remove.
2555 * solib.c (handle_solib_event): Update.
2556 * remote.c (remote_serial_quit_handler): Update.
2557 (remote_terminal_inferior, remote_wait_as): Update.
2558 * record-full.c (record_full_wait_1): Update.
2559 * nto-procfs.c (procfs_create_inferior): Update.
2560 * nat/fork-inferior.c (startup_inferior): Update.
2561 * mi/mi-interp.c (mi_new_thread, mi_thread_exit)
2562 (mi_record_changed, mi_inferior_added, mi_inferior_appeared)
2563 (mi_inferior_exit, mi_inferior_removed, mi_traceframe_changed)
2564 (mi_tsv_created, mi_tsv_deleted, mi_tsv_modified)
2565 (mi_breakpoint_created, mi_breakpoint_deleted)
2566 (mi_breakpoint_modified, mi_on_resume, mi_solib_loaded)
2567 (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
2568 (mi_user_selected_context_changed, report_initial_inferior):
2570 * linux-nat.c (linux_nat_attach, linux_nat_terminal_ours)
2571 (linux_nat_terminal_inferior): Update.
2572 * infrun.c (follow_fork_inferior)
2573 (handle_vfork_child_exec_or_exit, do_target_resume)
2574 (check_curr_ui_sync_execution_done, handle_inferior_event_1)
2575 (handle_signal_stop, maybe_remove_breakpoints, normal_stop):
2577 * inflow.c (child_terminal_init, info_terminal_command): Update.
2578 * infcmd.c (post_create_inferior, continue_1, prepare_one_step)
2579 (attach_command): Update.
2580 * infcall.c (call_thread_fsm_should_stop): Update.
2581 * gnu-nat.c (gnu_attach): Update.
2582 * extension.c (struct active_ext_lang_state)
2583 (restore_active_ext_lang): Update.
2584 * exceptions.c (print_flush): Update.
2585 * event-top.c (async_enable_stdin, default_quit_handler): Update.
2586 (struct quit_handler_cleanup_data, restore_quit_handler)
2587 (restore_quit_handler_dtor, make_cleanup_override_quit_handler):
2589 * cp-support.c (gdb_demangle): Update.
2590 * breakpoint.c (update_inserted_breakpoint_locations)
2591 (insert_breakpoint_locations, handle_jit_event)
2592 (disable_breakpoints_in_unloaded_shlib): Update.
2593 * annotate.c (annotate_breakpoints_invalid)
2594 (annotate_frames_invalid): Update.
2598 * main.c (catch_command_errors): Rename from
2599 catch_command_errors_const.
2600 (captured_main_1): Update.
2604 * cli/cli-cmds.c (list_command): Use print_sal_location.
2605 (print_sal_location): New function.
2606 (ambiguous_line_spec): Use print_sal_location.
2607 * linespec.c (symbol_to_sal): Record the symbol in the sal.
2608 * symtab.c (find_function_start_sal): Likewise.
2609 * symtab.h (symtab_and_line::symbol): New field.
2613 * linespec.c (minsym_found): Handle non-text minsyms.
2614 (symbol_to_sal): Record a sal.pc for non-block, non-label symbols.
2618 * features/Makefile (i386-avx-mpx-avx512-pku.dat): Add missing
2623 * gdb.arch/i386-avx512.c (move_zmm_data_to_reg): Use
2624 vmovups instead vmovaps.
2625 (move_zmm_data_to_memory): Use vmovups instead vmovaps.
2629 * NEWS (Changes since GDB 8.0): Add starti.
2630 * infcmd.c (enum run_break): New.
2631 (run_command_1): Queue pending event for RUN_STOP_AT_FIRST_INSN
2633 (run_command): Use enum run_how.
2634 (start_command): Likewise.
2635 (starti_command): New function.
2636 (RUN_ARGS_HELP): New macro.
2637 (_initialize_infcmd): Use RUN_ARGS_HELP for run and start
2638 commands. Add starti command.
2642 * Makefile.in (monitor.o): Remove the rule.
2646 * annotate.h (struct annotate_arg_emitter): Use
2647 DISABLE_COPY_AND_ASSIGN.
2648 * common/refcounted-object.h (refcounted_object): Likewise.
2649 * completer.h (struct completion_result): Likewise.
2650 * dwarf2read.c (struct dwarf2_per_objfile): Likewise.
2651 * filename-seen-cache.h (filename_seen_cache): Likewise.
2652 * gdbcore.h (thread_section_name): Likewise.
2653 * gdb_regex.h (compiled_regex): Likewise.
2654 * gdbthread.h (scoped_restore_current_thread): Likewise.
2655 * inferior.h (scoped_restore_current_inferior): Likewise.
2656 * jit.c (jit_reader): Likewise.
2657 * linespec.h (struct linespec_result): Likewise.
2658 * mi/mi-parse.h (struct mi_parse): Likewise.
2659 * nat/fork-inferior.c (execv_argv): Likewise.
2660 * progspace.h (scoped_restore_current_program_space): Likewise.
2661 * python/python-internal.h (class gdbpy_enter): Likewise.
2662 * regcache.h (regcache): Likewise.
2663 * target-descriptions.c (struct tdesc_reg): Likewise.
2664 (struct tdesc_type): Likewise.
2665 (struct tdesc_feature): Likewise.
2666 * ui-out.h (ui_out_emit_type): Likewise.
2670 * dwarf2expr.c (dwarf_expr_context::execute_stack_op): Remove
2671 label abort_expression.
2675 * common/buffer.c (buffer_xml_printf): Adjust.
2676 * common/xml-utils.c (xml_escape_text): Change return type to
2677 std::string, update code accordingly.
2678 * common/xml-utils.h (xml_escape_text): Change return type to
2680 * rs6000-aix-tdep.c (rs6000_aix_shared_library_to_xml): Adjust.
2681 * windows-tdep.c (windows_xfer_shared_library): Adjust.
2682 * unittests/xml-utils-selftests.c (test_xml_escape_text):
2687 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new source file.
2688 (SUBDIR_UNITTESTS_OBS): Add new object file.
2689 * unittests/xml-utils-selftests.c: New file.
2693 * common/selftest.h (selftest): New struct/interface.
2694 (register_test): Add name parameter, add new overload.
2695 (run_tests): Add filter parameter.
2696 (for_each_selftest_ftype): New typedef.
2697 (for_each_selftest): New declaration.
2698 * common/selftest.c (tests): Change type to
2699 map<string, unique_ptr<selftest>>.
2700 (simple_selftest): New struct.
2701 (register_test): New function.
2702 (register_test): Add name parameter and use it.
2703 (run_tests): Add filter parameter and use it. Add prints.
2704 Adjust to vector -> map change.
2705 * aarch64-tdep.c (_initialize_aarch64_tdep): Add names when
2706 registering selftests.
2707 * arm-tdep.c (_initialize_arm_tdep): Likewise.
2708 * disasm-selftests.c (_initialize_disasm_selftests): Likewise.
2709 * dwarf2-frame.c (_initialize_dwarf2_frame): Likewise.
2710 * dwarf2loc.c (_initialize_dwarf2loc): Likewise.
2711 * findvar.c (_initialize_findvar): Likewise.
2712 * gdbarch-selftests.c (_initialize_gdbarch_selftests): Likewise.
2713 * maint.c (maintenance_selftest): Update call to run_tests.
2714 (maintenance_info_selftests): New function.
2715 (_initialize_maint_cmds): Register "maintenance info selftests"
2716 command. Update "maintenance selftest" doc.
2717 * regcache.c (_initialize_regcache): Add names when registering
2719 * rust-exp.y (_initialize_rust_exp): Likewise.
2720 * selftest-arch.c (gdbarch_selftest): New struct.
2721 (gdbarch_tests): Remove.
2722 (register_test_foreach_arch): Add name parameter. Call
2724 (tests_with_arch): Remove, move most content to
2725 gdbarch_selftest::operator().
2726 (_initialize_selftests_foreach_arch): Remove.
2727 * selftest-arch.h (register_test_foreach_arch): Add name
2729 (run_tests_with_arch): New declaration.
2730 * utils-selftests.c (_initialize_utils_selftests): Add names
2731 when registering selftests.
2732 * utils.c (_initialize_utils): Likewise.
2733 * unittests/array-view-selftests.c
2734 (_initialize_array_view_selftests): Likewise.
2735 * unittests/environ-selftests.c (_initialize_environ_selftests):
2737 * unittests/function-view-selftests.c
2738 (_initialize_function_view_selftests): Likewise.
2739 * unittests/offset-type-selftests.c
2740 (_initialize_offset_type_selftests): Likewise.
2741 * unittests/optional-selftests.c
2742 (_initialize_optional_selftests): Likewise.
2743 * unittests/scoped_restore-selftests.c
2744 (_initialize_scoped_restore_selftests): Likewise.
2745 * NEWS: Document "maintenance selftest" and "maint info
2750 * mi/mi-main.c (mi_load_progress): Restore current_uiout using a
2755 * mi/mi-main.c (mi_load_progress): Make uiout variable
2760 * compile/compile-c-types.c (convert_enum, convert_int)
2761 (convert_float): Adjust to refer to int_type_v0 and float_type_v0.
2765 * dwarf2read.c (copy_string): Remove.
2766 (parse_macro_definition): Replace copy_string with savestring.
2770 * configure.tgt (i[34567]86-*-darwin*): Append amd64.o to
2772 (i[34567]86-*-solaris2.1[0-9]* | x86_64-*-solaris2.1[0-9]*):
2774 (i[34567]86-*-linux*): Likewise.
2778 * dwarf2expr.h (dwarf_stack_value): Add constructor.
2779 (dwarf_expr_context) <~dwarf_expr_context>: Define as default.
2780 <stack>: Change type to std::vector.
2781 <stack_len, stack_allocated>: Remove.
2782 <grow_stack>: Remove.
2783 * dwarf2expr.c (dwarf_expr_context::dwarf_expr_context): Adjust.
2784 (dwarf_expr_context::~dwarf_expr_context): Remove.
2785 (dwarf_expr_context::grow_stack): Remove.
2786 (dwarf_expr_context::push): Adjust.
2787 (dwarf_expr_context::pop): Adjust.
2788 (dwarf_expr_context::fetch): Adjust.
2789 (dwarf_expr_context::fetch_in_stack_memory): Adjust.
2790 (dwarf_expr_context::stack_empty_p): Adjust.
2791 (dwarf_expr_context::execute_stack_op): Adjust.
2795 * dwarf2expr.h (dwarf_expr_context) <stack_empty_p>: Change
2796 return type to bool.
2797 * dwarf2expr.c (dwarf_expr_context::stack_empty_p): Likewise.
2801 * dwarf2expr.h (dwarf_expr_piece) <v.mem.in_stack_memory>:
2802 Change type to bool.
2803 (dwarf_stack_value) <in_stack_memory>: Likewise.
2804 (dwarf_expr_context) <push_address>: Change parameter type to
2806 <fetch_in_stack_memory>: Change return type to bool.
2807 <push>: Change parameter type to bool.
2808 * dwarf2expr.c (dwarf_expr_context::push): Change parameter type
2810 (dwarf_expr_context::push_address): Likewise.
2811 (dwarf_expr_context::fetch_in_stack_memory): Change return type
2813 (dwarf_expr_context::execute_stack_op): Adjust.
2814 * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Adjust.
2818 * dwarf2expr.h (struct dwarf_expr_piece): Move up.
2819 (struct dwarf_expr_context) <n_pieces>: Remove.
2820 <pieces>: Change type to std::vector.
2821 * dwarf2expr.c (dwarf_expr_context::dwarf_expr_context): Adjust.
2822 (dwarf_expr_context::~dwarf_expr_context): Don't manually free
2824 (dwarf_expr_context::add_piece): Adjust.
2825 * dwarf2loc.c (struct piece_closure): Initialize fields.
2827 <pieces>: Change type to std::vector.
2828 (allocate_piece_closure): Adjust, change parameter to
2829 std::vector rvalue and std::move it to piece_closure.
2830 (rw_pieced_value): Adjust.
2831 (check_pieced_synthetic_pointer): Adjust.
2832 (indirect_synthetic_pointer): Adjust.
2833 (coerce_pieced_ref): Adjust.
2834 (free_pieced_value_closure): Adjust. Use delete to free
2836 (dwarf2_evaluate_loc_desc_full): Adjust. std::move ctx.pieces
2837 to allocate_piece_closure.
2838 (dwarf2_loc_desc_get_symbol_read_needs): Adjust.
2842 * probe.h (probe_ops_cp): Remove typedef.
2843 (DEF_VEC_P (probe_ops_cp)): Remove.
2844 (all_probe_ops): Change type to std::vector.
2845 * probe.c (info_probes_for_ops): Adjust to vector change.
2846 (probe_linespec_to_ops): Likewise.
2847 (all_probe_ops): Change type to std::vector.
2848 (_initialize_probe): Adjust to vector change.
2849 * dtrace-probe.c (_initialize_dtrace_probe): Likewise.
2850 * elfread.c (elf_get_probes): Likewise.
2851 * stap-probe.c (_initialize_stap_probe): Likewise.
2855 * probe.h (struct bound_probe): Define constructors.
2856 * probe.c (bound_probe_s): Remove typedef.
2857 (DEF_VEC_O (bound_probe_s)): Remove VEC.
2858 (collect_probes): Change return type to std::vector, remove
2860 (compare_probes): Return bool, change parameter type. Change
2861 semantic to "less than".
2862 (gen_ui_out_table_header_info): Change parameter to std::vector
2864 (exists_probe_with_pops): Likewise.
2865 (info_probes_for_ops): Update to std::vector change.
2866 (enable_probes_command): Likewise.
2867 (disable_probes_command): Likewise.
2871 * probe.h (struct probe_ops) <get_probes>: Change parameter from
2873 * probe.c (parse_probes_in_pspace): Update.
2874 (find_probes_in_objfile): Update.
2875 (find_probe_by_pc): Update.
2876 (collect_probes): Update.
2877 (probe_any_get_probes): Update.
2878 * symfile.h (struct sym_probe_fns) <sym_get_probes> Change
2879 return type to reference to std::vector.
2880 * dtrace-probe.c (dtrace_process_dof_probe): Change parameter to
2881 std::vector and update.
2882 (dtrace_process_dof): Likewise.
2883 (dtrace_get_probes): Likewise.
2884 * elfread.c (elf_get_probes): Change return type to std::vector,
2885 store an std::vector in bfd_data.
2886 (probe_key_free): Update to std::vector.
2887 * stap-probe.c (handle_stap_probe): Change parameter to
2888 std::vector and update.
2889 (stap_get_probes): Likewise.
2890 * symfile-debug.c (debug_sym_get_probes): Change return type to
2891 std::vector and update.
2895 * breakpoint.c (program_breakpoint_here_p): Update.
2896 * target.c (make_scoped_restore_show_memory_breakpoints): Rename
2897 from make_show_memory_breakpoints_cleanup. Return a
2898 scoped_restore_tmpl<int>.
2899 (restore_show_memory_breakpoints): Remove.
2900 * ppc-linux-tdep.c (ppc_linux_memory_remove_breakpoint): Update.
2901 * mem-break.c (memory_validate_breakpoint): Update.
2902 * ia64-tdep.c (ia64_memory_insert_breakpoint): Update.
2903 (ia64_memory_remove_breakpoint): Update.
2904 (ia64_breakpoint_from_pc): Update.
2905 * target.h (make_scoped_restore_show_memory_breakpoints): Rename
2906 from make_show_memory_breakpoints_cleanup.
2910 * d-namespace.c (d_lookup_symbol): Use std::string.
2911 (find_symbol_in_baseclass): Likewise.
2915 * ctf.c (ctf_start): Use std::string.
2919 * ada-lang.c (is_known_support_routine): Update.
2920 (ada_unhandled_exception_name_addr_from_raise): Update.
2921 * guile/scm-frame.c (gdbscm_frame_name): Update.
2922 * python/py-frame.c (frapy_name): Update.
2923 (frapy_function): Update.
2924 * stack.h (find_frame_funname): Update.
2925 * stack.c (find_frame_funname): Return unique_xmalloc_ptr.
2926 (print_frame): Update.
2930 * findcmd.c (put_bits): Take a gdb::byte_vector.
2931 (parse_find_args): Return gdb::byte_vector. "args" now const.
2932 Remove "pattern_bufp" and "pattern_lenp" parameters. Remove
2934 (find_command): Update.
2938 * cli/cli-script.c (class scoped_restore_hook_in): New.
2939 (clear_hook_in_cleanup): Remove.
2940 (execute_cmd_pre_hook, execute_cmd_post_hook): Use
2941 scoped_restore_hook_in.
2945 * cli/cli-script.c (restore_interp): Remove.
2946 (read_command_lines): Use scoped_restore_interp.
2947 * interps.c (scoped_restore_interp::set_temp): Rename from
2949 * interps.h (class scoped_restore_interp): New.
2950 (interp_set_temp): Remove.
2954 * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
2955 (mi_cmd_catch_exception, mi_catch_load_unload): Update.
2956 * mi/mi-cmd-break.c (setup_breakpoint_reporting): Return a
2958 (mi_cmd_break_insert_1): Update.
2959 * mi/mi-cmd-break.h (setup_breakpoint_reporting): Return a
2964 * demangle.c (demangle_command): Update.
2965 * breakpoint.c (disable_command): Update.
2966 (enable_command): Update.
2967 (find_location_by_number): Make "number" const. Use
2969 * cli/cli-utils.c (extract_arg): Return std::string.
2970 * probe.c (parse_probe_linespec): Update. Change types.
2971 (collect_probes): Take string arguments.
2972 (parse_probe_linespec): Likewise.
2973 (info_probes_for_ops): Update.
2974 (enable_probes_command): Update.
2975 (disable_probes_command): Update.
2976 * break-catch-sig.c (catch_signal_split_args): Update.
2977 * mi/mi-parse.c (mi_parse): Update.
2981 * language.h (language_enum): Make argument const.
2982 * language.c (language_enum): Make argument const.
2986 * common/common-utils.h (skip_to_space): Remove macro, redeclare
2988 (skip_to_space): Rename from skip_to_space_const.
2989 * common/common-utils.c (skip_to_space): New function.
2990 (skip_to_space): Rename from skip_to_space_const.
2991 * cli/cli-utils.h (get_number): Rename from get_number_const.
2992 (extract_arg): Rename from extract_arg_const.
2993 * cli/cli-utils.c (get_number): Rename from get_number_const.
2994 (extract_arg): Rename from extract_arg_const.
2995 (number_or_range_parser::get_number): Use ::get_number.
2996 * aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c,
2997 break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c,
2998 cli/cli-script.c, cli/cli-setshow.c, compile/compile.c,
2999 completer.c, demangle.c, disasm.c, findcmd.c, linespec.c,
3000 linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c,
3001 minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c,
3002 python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c,
3003 stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
3007 * python/python.c (do_start_initialization): Use
3008 py-event-types.def to initialize types.
3009 Define all object type structures.
3010 * python/python-internal.h: Don't declare event initialization
3012 * python/py-threadevent.c (thread_event_object_type): Don't
3014 * python/py-stopevent.c (stop_event_object_type): Don't define.
3015 * python/py-signalevent.c (signal_event_object_type): Don't
3017 * python/py-newobjfileevent.c (new_objfile_event_object_type)
3018 (clear_objfiles_event_object_type): Don't declare or define.
3019 * python/py-infevents.c (inferior_call_pre_event_object_type)
3020 (inferior_call_post_event_object_type)
3021 (register_changed_event_object_type)
3022 (memory_changed_event_object_type): Don't declare or define.
3023 * python/py-inferior.c (new_thread_event_object_type)
3024 (new_inferior_event_object_type)
3025 (inferior_deleted_event_object_type): Don't declare or define.
3026 * python/py-exitedevent.c (exited_event_object_type): Don't
3028 * python/py-evts.c (gdbpy_initialize_py_events): Use
3030 * python/py-events.h (thread_event_object_type): Don't declare.
3031 (events_object): Use py-all-events.def.
3032 * python/py-event.h (GDBPY_NEW_EVENT_TYPE): Remove. Use
3034 * python/py-event-types.def: New file.
3035 * python/py-continueevent.c (create_continue_event_object): Don't
3037 * python/py-bpevent.c (breakpoint_event_object_type): Don't
3039 * python/py-all-events.def: New file.
3043 * python/py-threadevent.c (create_thread_event_object): Return
3045 * python/py-stopevent.h (create_stop_event_object)
3046 (create_breakpoint_event_object, create_signal_event_object):
3048 * python/py-stopevent.c (create_stop_event_object): Return
3050 (emit_stop_event): Update.
3051 * python/py-signalevent.c (create_signal_event_object): Return
3053 * python/py-infevents.c (create_inferior_call_event_object):
3055 * python/py-event.h (create_event_object)
3056 (create_thread_event_object): Update.
3057 * python/py-event.c (create_event_object): Return gdbpy_ref.
3058 * python/py-continueevent.c: Return gdbpy_ref.
3059 * python/py-bpevent.c (create_breakpoint_event_object): Return
3066 * python/python.c (do_start_initialization): Initialize new event
3068 * python/python-internal.h (gdbpy_initialize_new_inferior_event)
3069 (gdbpy_initialize_inferior_deleted_event)
3070 (gdbpy_initialize_new_thread_event): Declare.
3071 * python/py-threadevent.c (create_thread_event_object): Add option
3073 * python/py-inferior.c (new_thread_event_object_type)
3074 (new_inferior_event_object_type)
3075 (inferior_deleted_event_object_type): Declare.
3076 (python_new_inferior, python_inferior_deleted): New functions.
3077 (add_thread_object): Emit new_thread event.
3078 (gdbpy_initialize_inferior): Attach new functions to corresponding
3080 (new_thread, new_inferior, inferior_deleted): Define new event
3082 * python/py-evts.c (gdbpy_initialize_py_events): Add new
3084 * python/py-events.h (events_object) <new_inferior,
3085 inferior_deleted, new_thread>: New fields.
3086 * python/py-event.h (create_thread_event_breakpoint): Add optional
3091 * utils.c (abort_with_message): Don't compare gdb_stderr to NULL,
3092 check current_ui instead.
3093 (internal_vproblem): Likewise.
3097 * thread.c (print_thread_info_1): Remove unnecessary calls to
3098 uiout->is_mi_like_p.
3102 * namespace.h (add_using_directive): Update.
3103 * namespace.c (add_using_directive): Change type of excludes to
3105 * dwarf2read.c (read_import_statement): Use std::vector.
3106 (read_namespace): Update.
3107 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
3111 * linespec.c (create_sals_line_offset): Use gdb::def_vector.
3115 * p-valprint.c (pascal_object_print_value): Use gdb::byte_vector.
3119 * stack.c (func_command): Use gdb::def_vector.
3123 * mi/mi-cmd-var.c (mi_cmd_var_list_children): Use gdb::optional,
3124 ui_out_emit_list, ui_out_emit_tuple.
3125 (mi_cmd_var_update): Likewise.
3129 * mi/mi-interp.c (mi_user_selected_context_changed): Use
3130 ui_out_redirect_pop.
3131 * guile/scm-ports.c (ioscm_with_output_to_port_worker): Use
3132 ui_out_redirect_pop.
3133 * utils.c (do_ui_out_redirect_pop)
3134 (make_cleanup_ui_out_redirect_pop): Remove.
3135 * top.c (execute_command_to_string): Use ui_out_redirect_pop.
3136 * utils.h (make_cleanup_ui_out_redirect_pop): Remove.
3137 * ui-out.h (ui_out_redirect_pop): New class.
3141 * mi/mi-main.c (output_cores): Use ui_out_emit_list.
3142 (list_available_thread_groups, mi_cmd_list_thread_groups)
3143 (mi_cmd_data_list_changed_registers, mi_cmd_data_read_memory)
3144 (mi_cmd_data_read_memory_bytes, mi_cmd_trace_frame_collected):
3149 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3154 * target.c (flash_erase_command): Use ui_out_emit_tuple.
3155 * stack.c (print_frame): Use ui_out_emit_tuple.
3156 * spu-tdep.c (info_spu_event_command): Use ui_out_emit_tuple.
3157 (info_spu_mailbox_command, info_spu_dma_command)
3158 (info_spu_proxydma_command): Likewise.
3159 * mi/mi-main.c (mi_cmd_trace_frame_collected): Use
3160 ui_out_emit_tuple, gdb::byte_vector, bin2hex.
3161 * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Use
3163 * breakpoint.c (print_it_watchpoint): Use ui_out_emit_tuple.
3167 * ui-out.h (make_cleanup_ui_out_table_begin_end): Remove.
3168 (class ui_out_emit_table): Update comment.
3169 * ui-out.c (do_cleanup_table_end)
3170 (make_cleanup_ui_out_table_begin_end): Remove.
3171 * spu-tdep.c (info_spu_mailbox_list): Use ui_out_emit_table.
3172 (info_spu_dma_cmdlist): Likewise.
3173 * probe.c (info_probes_for_ops): Use ui_out_emit_table.
3174 * darwin-nat-info.c (darwin_debug_regions_recurse): Use
3179 * thread.c (print_thread_info_1): Use ui_out_emit_table,
3180 ui_out_emit_list, gdb::optional.
3184 * aarch64-linux-nat.c: Remove _initialize_aarch64_linux_nat
3186 * aarch64-linux-tdep.c: Remove _initialize_aarch64_linux_tdep
3188 * aarch64-newlib-tdep.c: Remove _initialize_aarch64_newlib_tdep
3190 * aarch64-tdep.c: Remove _initialize_aarch64_tdep prototype.
3191 * ada-exp.y: Remove _initialize_ada_exp prototype.
3192 * ada-lang.c: Remove _initialize_ada_language prototype.
3193 * ada-tasks.c: Remove _initialize_tasks prototype.
3194 * addrmap.c: Remove _initialize_addrmap prototype.
3195 * agent.c: Remove _initialize_agent prototype.
3196 * aix-thread.c: Remove _initialize_aix_thread prototype.
3197 * alpha-bsd-nat.c: Remove _initialize_alphabsd_nat prototype.
3198 * alpha-linux-nat.c: Remove _initialize_alpha_linux_nat prototype.
3199 * alpha-linux-tdep.c: Remove _initialize_alpha_linux_tdep
3201 * alpha-nbsd-tdep.c: Remove _initialize_alphanbsd_tdep prototype.
3202 * alpha-obsd-tdep.c: Remove _initialize_alphaobsd_tdep prototype.
3203 * alpha-tdep.c: Remove _initialize_alpha_tdep prototype.
3204 * amd64-darwin-tdep.c: Remove _initialize_amd64_darwin_tdep
3206 * amd64-dicos-tdep.c: Remove _initialize_amd64_dicos_tdep
3208 * amd64-fbsd-nat.c: Remove _initialize_amd64fbsd_nat prototype.
3209 * amd64-fbsd-tdep.c: Remove _initialize_amd64fbsd_tdep prototype.
3210 * amd64-linux-nat.c: Remove _initialize_amd64_linux_nat prototype.
3211 * amd64-linux-tdep.c: Remove _initialize_amd64_linux_tdep
3213 * amd64-nbsd-nat.c: Remove _initialize_amd64nbsd_nat prototype.
3214 * amd64-nbsd-tdep.c: Remove _initialize_amd64nbsd_tdep prototype.
3215 * amd64-obsd-nat.c: Remove _initialize_amd64obsd_nat prototype.
3216 * amd64-obsd-tdep.c: Remove _initialize_amd64obsd_tdep prototype.
3217 * amd64-sol2-tdep.c: Remove _initialize_amd64_sol2_tdep prototype.
3218 * amd64-tdep.c: Remove _initialize_amd64_tdep prototype.
3219 * amd64-windows-nat.c: Remove _initialize_amd64_windows_nat
3221 * amd64-windows-tdep.c: Remove _initialize_amd64_windows_tdep
3223 * annotate.c: Remove _initialize_annotate prototype.
3224 * arc-newlib-tdep.c: Remove _initialize_arc_newlib_tdep prototype.
3225 * arc-tdep.c: Remove _initialize_arc_tdep prototype.
3226 * arch-utils.c: Remove _initialize_gdbarch_utils prototype.
3227 * arm-linux-nat.c: Remove _initialize_arm_linux_nat prototype.
3228 * arm-linux-tdep.c: Remove _initialize_arm_linux_tdep prototype.
3229 * arm-nbsd-tdep.c: Remove _initialize_arm_netbsd_tdep prototype.
3230 * arm-obsd-tdep.c: Remove _initialize_armobsd_tdep prototype.
3231 * arm-symbian-tdep.c: Remove _initialize_arm_symbian_tdep
3233 * arm-tdep.c: Remove _initialize_arm_tdep prototype.
3234 * arm-wince-tdep.c: Remove _initialize_arm_wince_tdep prototype.
3235 * auto-load.c: Remove _initialize_auto_load prototype.
3236 * auxv.c: Remove _initialize_auxv prototype.
3237 * avr-tdep.c: Remove _initialize_avr_tdep prototype.
3238 * ax-gdb.c: Remove _initialize_ax_gdb prototype.
3239 * bfin-linux-tdep.c: Remove _initialize_bfin_linux_tdep prototype.
3240 * bfin-tdep.c: Remove _initialize_bfin_tdep prototype.
3241 * break-catch-sig.c: Remove _initialize_break_catch_sig prototype.
3242 * break-catch-syscall.c: Remove _initialize_break_catch_syscall
3244 * break-catch-throw.c: Remove _initialize_break_catch_throw
3246 * breakpoint.c: Remove _initialize_breakpoint prototype.
3247 * bsd-uthread.c: Remove _initialize_bsd_uthread prototype.
3248 * btrace.c: Remove _initialize_btrace prototype.
3249 * charset.c: Remove _initialize_charset prototype.
3250 * cli/cli-cmds.c: Remove _initialize_cli_cmds prototype.
3251 * cli/cli-dump.c: Remove _initialize_cli_dump prototype.
3252 * cli/cli-interp.c: Remove _initialize_cli_interp prototype.
3253 * cli/cli-logging.c: Remove _initialize_cli_logging prototype.
3254 * cli/cli-script.c: Remove _initialize_cli_script prototype.
3255 * coff-pe-read.c: Remove _initialize_coff_pe_read prototype.
3256 * coffread.c: Remove _initialize_coffread prototype.
3257 * compile/compile.c: Remove _initialize_compile prototype.
3258 * complaints.c: Remove _initialize_complaints prototype.
3259 * completer.c: Remove _initialize_completer prototype.
3260 * copying.awk: Remove _initialize_copying prototype.
3261 * copying.c: Regenerate.
3262 * core-regset.c: Remove _initialize_core_regset prototype.
3263 * corefile.c: Remove _initialize_core prototype.
3264 * corelow.c: Remove _initialize_corelow prototype.
3265 * cp-abi.c: Remove _initialize_cp_abi prototype.
3266 * cp-namespace.c: Remove _initialize_cp_namespace prototype.
3267 * cp-support.c: Remove _initialize_cp_support prototype.
3268 * cp-valprint.c: Remove _initialize_cp_valprint prototype.
3269 * cris-linux-tdep.c: Remove _initialize_cris_linux_tdep prototype.
3270 * cris-tdep.c: Remove _initialize_cris_tdep prototype.
3271 * ctf.c: Remove _initialize_ctf prototype.
3272 * d-lang.c: Remove _initialize_d_language prototype.
3273 * darwin-nat-info.c: Remove _initialize_darwin_info_commands
3275 * darwin-nat.c: Remove _initialize_darwin_inferior prototype.
3276 * dbxread.c: Remove _initialize_dbxread prototype.
3277 * dcache.c: Remove _initialize_dcache prototype.
3278 * demangle.c: Remove _initialize_demangler prototype.
3279 * disasm-selftests.c: Remove _initialize_disasm_selftests
3281 * disasm.c: Remove _initialize_disasm prototype.
3282 * dtrace-probe.c: Remove _initialize_dtrace_probe prototype.
3283 * dummy-frame.c: Remove _initialize_dummy_frame prototype.
3284 * dwarf2-frame-tailcall.c: Remove _initialize_tailcall_frame
3286 * dwarf2-frame.c: Remove _initialize_dwarf2_frame prototype.
3287 * dwarf2expr.c: Remove _initialize_dwarf2expr prototype.
3288 * dwarf2loc.c: Remove _initialize_dwarf2loc prototype.
3289 * dwarf2read.c: Remove _initialize_dwarf2_read prototype.
3290 * elfread.c: Remove _initialize_elfread prototype.
3291 * exec.c: Remove _initialize_exec prototype.
3292 * extension.c: Remove _initialize_extension prototype.
3293 * f-lang.c: Remove _initialize_f_language prototype.
3294 * f-valprint.c: Remove _initialize_f_valprint prototype.
3295 * fbsd-nat.c: Remove _initialize_fbsd_nat prototype.
3296 * fbsd-tdep.c: Remove _initialize_fbsd_tdep prototype.
3297 * filesystem.c: Remove _initialize_filesystem prototype.
3298 * findcmd.c: Remove _initialize_mem_search prototype.
3299 * fork-child.c: Remove _initialize_fork_child prototype.
3300 * frame-base.c: Remove _initialize_frame_base prototype.
3301 * frame-unwind.c: Remove _initialize_frame_unwind prototype.
3302 * frame.c: Remove _initialize_frame prototype.
3303 * frv-linux-tdep.c: Remove _initialize_frv_linux_tdep prototype.
3304 * frv-tdep.c: Remove _initialize_frv_tdep prototype.
3305 * ft32-tdep.c: Remove _initialize_ft32_tdep prototype.
3306 * gcore.c: Remove _initialize_gcore prototype.
3307 * gdb_bfd.c: Remove _initialize_gdb_bfd prototype.
3308 * gdbarch.c: Regenerate.
3309 * gdbarch.sh: Remove _initialize_gdbarch prototype.
3310 * gdbtypes.c: Remove _initialize_gdbtypes prototype.
3311 * gnu-nat.c: Remove _initialize_gnu_nat prototype.
3312 * gnu-v2-abi.c: Remove _initialize_gnu_v2_abi prototype.
3313 * gnu-v3-abi.c: Remove _initialize_gnu_v3_abi prototype.
3314 * go-lang.c: Remove _initialize_go_language prototype.
3315 * go32-nat.c: Remove _initialize_go32_nat prototype.
3316 * guile/guile.c: Remove _initialize_guile prototype.
3317 * h8300-tdep.c: Remove _initialize_h8300_tdep prototype.
3318 * hppa-linux-nat.c: Remove _initialize_hppa_linux_nat prototype.
3319 * hppa-linux-tdep.c: Remove _initialize_hppa_linux_tdep prototype.
3320 * hppa-nbsd-nat.c: Remove _initialize_hppanbsd_nat prototype.
3321 * hppa-nbsd-tdep.c: Remove _initialize_hppanbsd_tdep prototype.
3322 * hppa-obsd-nat.c: Remove _initialize_hppaobsd_nat prototype.
3323 * hppa-obsd-tdep.c: Remove _initialize_hppaobsd_tdep prototype.
3324 * hppa-tdep.c: Remove _initialize_hppa_tdep prototype.
3325 * i386-bsd-nat.c: Remove _initialize_i386bsd_nat prototype.
3326 * i386-cygwin-tdep.c: Remove _initialize_i386_cygwin_tdep
3328 * i386-darwin-tdep.c: Remove _initialize_i386_darwin_tdep
3330 * i386-dicos-tdep.c: Remove _initialize_i386_dicos_tdep prototype.
3331 * i386-fbsd-nat.c: Remove _initialize_i386fbsd_nat prototype.
3332 * i386-fbsd-tdep.c: Remove _initialize_i386fbsd_tdep prototype.
3333 * i386-gnu-nat.c: Remove _initialize_i386gnu_nat prototype.
3334 * i386-gnu-tdep.c: Remove _initialize_i386gnu_tdep prototype.
3335 * i386-linux-nat.c: Remove _initialize_i386_linux_nat prototype.
3336 * i386-linux-tdep.c: Remove _initialize_i386_linux_tdep prototype.
3337 * i386-nbsd-nat.c: Remove _initialize_i386nbsd_nat prototype.
3338 * i386-nbsd-tdep.c: Remove _initialize_i386nbsd_tdep prototype.
3339 * i386-nto-tdep.c: Remove _initialize_i386nto_tdep prototype.
3340 * i386-obsd-nat.c: Remove _initialize_i386obsd_nat prototype.
3341 * i386-obsd-tdep.c: Remove _initialize_i386obsd_tdep prototype.
3342 * i386-sol2-nat.c: Remove _initialize_amd64_sol2_nat prototype.
3343 * i386-sol2-tdep.c: Remove _initialize_amd64_sol2_tdep prototype.
3344 * i386-tdep.c: Remove _initialize_i386_tdep prototype.
3345 * i386-windows-nat.c: Remove _initialize_i386_windows_nat
3347 * ia64-libunwind-tdep.c: Remove _initialize_libunwind_frame
3349 * ia64-linux-nat.c: Remove _initialize_ia64_linux_nat prototype.
3350 * ia64-linux-tdep.c: Remove _initialize_ia64_linux_tdep prototype.
3351 * ia64-tdep.c: Remove _initialize_ia64_tdep prototype.
3352 * ia64-vms-tdep.c: Remove _initialize_ia64_vms_tdep prototype.
3353 * infcall.c: Remove _initialize_infcall prototype.
3354 * infcmd.c: Remove _initialize_infcmd prototype.
3355 * inferior.c: Remove _initialize_inferiors prototype.
3356 * inflow.c: Remove _initialize_inflow prototype.
3357 * infrun.c: Remove _initialize_infrun prototype.
3358 * interps.c: Remove _initialize_interpreter prototype.
3359 * iq2000-tdep.c: Remove _initialize_iq2000_tdep prototype.
3360 * jit.c: Remove _initialize_jit prototype.
3361 * language.c: Remove _initialize_language prototype.
3362 * linux-fork.c: Remove _initialize_linux_fork prototype.
3363 * linux-nat.c: Remove _initialize_linux_nat prototype.
3364 * linux-tdep.c: Remove _initialize_linux_tdep prototype.
3365 * linux-thread-db.c: Remove _initialize_thread_db prototype.
3366 * lm32-tdep.c: Remove _initialize_lm32_tdep prototype.
3367 * m2-lang.c: Remove _initialize_m2_language prototype.
3368 * m32c-tdep.c: Remove _initialize_m32c_tdep prototype.
3369 * m32r-linux-nat.c: Remove _initialize_m32r_linux_nat prototype.
3370 * m32r-linux-tdep.c: Remove _initialize_m32r_linux_tdep prototype.
3371 * m32r-tdep.c: Remove _initialize_m32r_tdep prototype.
3372 * m68hc11-tdep.c: Remove _initialize_m68hc11_tdep prototype.
3373 * m68k-bsd-nat.c: Remove _initialize_m68kbsd_nat prototype.
3374 * m68k-bsd-tdep.c: Remove _initialize_m68kbsd_tdep prototype.
3375 * m68k-linux-nat.c: Remove _initialize_m68k_linux_tdep prototype.
3376 * m68k-linux-tdep.c: Remove _initialize_m68k_linux_tdep prototype.
3377 * m68k-tdep.c: Remove _initialize_m68k_tdep prototype.
3378 * m88k-bsd-nat.c: Remove _initialize_m68kbsd_nat prototype.
3379 * m88k-tdep.c: Remove _initialize_m68kbsd_tdep prototype.
3380 * machoread.c: Remove _initialize_machoread prototype.
3381 * macrocmd.c: Remove _initialize_macrocmd prototype.
3382 * macroscope.c: Remove _initialize_macroscope prototype.
3383 * maint.c: Remove _initialize_maint_cmds prototype.
3384 * mdebugread.c: Remove _initialize_mdebugread prototype.
3385 * memattr.c: Remove _initialize_mem prototype.
3386 * mep-tdep.c: Remove _initialize_mep_tdep prototype.
3387 * mi/mi-cmd-env.c: Remove _initialize_mi_cmd_env prototype.
3388 * mi/mi-cmds.c: Remove _initialize_mi_cmds prototype.
3389 * mi/mi-interp.c: Remove _initialize_mi_interp prototype.
3390 * mi/mi-main.c: Remove _initialize_mi_main prototype.
3391 * microblaze-linux-tdep.c: Remove
3392 _initialize_microblaze_linux_tdep prototype.
3393 * microblaze-tdep.c: Remove _initialize_microblaze_tdep prototype.
3394 * mips-fbsd-nat.c: Remove _initialize_mips_fbsd_nat prototype.
3395 * mips-fbsd-tdep.c: Remove _initialize_mips_fbsd_tdep prototype.
3396 * mips-linux-nat.c: Remove _initialize_mips_linux_nat prototype.
3397 * mips-linux-tdep.c: Remove _initialize_mips_linux_tdep prototype.
3398 * mips-nbsd-nat.c: Remove _initialize_mipsnbsd_nat prototype.
3399 * mips-nbsd-tdep.c: Remove _initialize_mipsnbsd_tdep prototype.
3400 * mips-sde-tdep.c: Remove _initialize_mips_sde_tdep prototype.
3401 * mips-tdep.c: Remove _initialize_mips_tdep prototype.
3402 * mips64-obsd-nat.c: Remove _initialize_mips64obsd_nat prototype.
3403 * mips64-obsd-tdep.c: Remove _initialize_mips64obsd_tdep
3405 * mipsread.c: Remove _initialize_mipsread prototype.
3406 * mn10300-linux-tdep.c: Remove _initialize_mn10300_linux_tdep
3408 * mn10300-tdep.c: Remove _initialize_mn10300_tdep prototype.
3409 * moxie-tdep.c: Remove _initialize_moxie_tdep prototype.
3410 * msp430-tdep.c: Remove _initialize_msp430_tdep prototype.
3411 * mt-tdep.c: Remove _initialize_mt_tdep prototype.
3412 * nds32-tdep.c: Remove _initialize_nds32_tdep prototype.
3413 * nios2-linux-tdep.c: Remove _initialize_nios2_linux_tdep
3415 * nios2-tdep.c: Remove _initialize_nios2_tdep prototype.
3416 * nto-procfs.c: Remove _initialize_procfs prototype.
3417 * nto-tdep.c: Remove _initialize_nto_tdep prototype.
3418 * objc-lang.c: Remove _initialize_objc_language prototype.
3419 * objfiles.c: Remove _initialize_objfiles prototype.
3420 * observer.c: Remove observer_test_first_notification_function,
3421 observer_test_second_notification_function,
3422 observer_test_third_notification_function, and
3423 _initialize_observer prototypes.
3424 * opencl-lang.c: Remove _initialize_opencl_language prototypes.
3425 * osabi.c: Remove _initialize_gdb_osabi prototype.
3426 * osdata.c: Remove _initialize_osdata prototype.
3427 * p-valprint.c: Remove _initialize_pascal_valprint prototype.
3428 * parse.c: Remove _initialize_parse prototype.
3429 * ppc-fbsd-nat.c: Remove _initialize_ppcfbsd_nat prototype.
3430 * ppc-fbsd-tdep.c: Remove _initialize_ppcfbsd_tdep prototype.
3431 * ppc-linux-nat.c: Remove _initialize_ppc_linux_nat prototype.
3432 * ppc-linux-tdep.c: Remove _initialize_ppc_linux_tdep prototype.
3433 * ppc-nbsd-nat.c: Remove _initialize_ppcnbsd_nat prototype.
3434 * ppc-nbsd-tdep.c: Remove _initialize_ppcnbsd_tdep prototype.
3435 * ppc-obsd-nat.c: Remove _initialize_ppcobsd_nat prototype.
3436 * ppc-obsd-tdep.c: Remove _initialize_ppcobsd_tdep prototype.
3437 * printcmd.c: Remove _initialize_printcmd prototype.
3438 * probe.c: Remove _initialize_probe prototype.
3439 * proc-api.c: Remove _initialize_proc_api prototype.
3440 * proc-events.c: Remove _initialize_proc_events prototype.
3441 * proc-service.c: Remove _initialize_proc_service prototype.
3442 * procfs.c: Remove _initialize_procfs prototype.
3443 * psymtab.c: Remove _initialize_psymtab prototype.
3444 * python/python.c: Remove _initialize_python prototype.
3445 * ravenscar-thread.c: Remove _initialize_ravenscar prototype.
3446 * record-btrace.c: Remove _initialize_record_btrace prototype.
3447 * record-full.c: Remove _initialize_record_full prototype.
3448 * record.c: Remove _initialize_record prototype.
3449 * regcache.c: Remove _initialize_regcache prototype.
3450 * reggroups.c: Remove _initialize_reggroup prototype.
3451 * remote-notif.c: Remove _initialize_notif prototype.
3452 * remote-sim.c: Remove _initialize_remote_sim prototype.
3453 * remote.c: Remove _initialize_remote prototype.
3454 * reverse.c: Remove _initialize_reverse prototype.
3455 * rl78-tdep.c: Remove _initialize_rl78_tdep prototype.
3456 * rs6000-aix-tdep.c: Remove _initialize_rs6000_aix_tdep prototype.
3457 * rs6000-lynx178-tdep.c: Remove _initialize_rs6000_lynx178_tdep
3459 * rs6000-nat.c: Remove _initialize_rs6000_nat prototype.
3460 * rs6000-tdep.c: Remove _initialize_rs6000_tdep prototype.
3461 * rust-exp.y: Remove _initialize_rust_exp prototype.
3462 * rx-tdep.c: Remove _initialize_rx_tdep prototype.
3463 * s390-linux-nat.c: Remove _initialize_s390_nat prototype.
3464 * s390-linux-tdep.c: Remove _initialize_s390_tdep prototype.
3465 * score-tdep.c: Remove _initialize_score_tdep prototype.
3466 * selftest-arch.c: Remove _initialize_selftests_foreach_arch
3468 * ser-go32.c: Remove _initialize_ser_dos prototype.
3469 * ser-mingw.c: Remove _initialize_ser_windows prototype.
3470 * ser-pipe.c: Remove _initialize_ser_pipe prototype.
3471 * ser-tcp.c: Remove _initialize_ser_tcp prototype.
3472 * ser-unix.c: Remove _initialize_ser_hardwire prototype.
3473 * serial.c: Remove _initialize_serial prototype.
3474 * sh-linux-tdep.c: Remove _initialize_sh_linux_tdep prototype.
3475 * sh-nbsd-nat.c: Remove _initialize_shnbsd_nat prototype.
3476 * sh-nbsd-tdep.c: Remove _initialize_shnbsd_tdep prototype.
3477 * sh-tdep.c: Remove _initialize_sh_tdep prototype.
3478 * skip.c: Remove _initialize_step_skip prototype.
3479 * sol-thread.c: Remove _initialize_sol_thread prototype.
3480 * solib-aix.c: Remove _initialize_solib_aix prototype.
3481 * solib-darwin.c: Remove _initialize_darwin_solib prototype.
3482 * solib-dsbt.c: Remove _initialize_dsbt_solib prototype.
3483 * solib-frv.c: Remove _initialize_frv_solib prototype.
3484 * solib-spu.c: Remove _initialize_spu_solib prototype.
3485 * solib-svr4.c: Remove _initialize_svr4_solib prototype.
3486 * solib-target.c: Remove _initialize_solib_target prototype.
3487 * solib.c: Remove _initialize_solib prototype.
3488 * source.c: Remove _initialize_source prototype.
3489 * sparc-linux-nat.c: Remove _initialize_sparc_linux_nat prototype.
3490 * sparc-linux-tdep.c: Remove _initialize_sparc_linux_tdep
3492 * sparc-nat.c: Remove _initialize_sparc_nat prototype.
3493 * sparc-nbsd-nat.c: Remove _initialize_sparcnbsd_nat prototype.
3494 * sparc-nbsd-tdep.c: Remove _initialize_sparcnbsd_tdep prototype.
3495 * sparc-obsd-tdep.c: Remove _initialize_sparc32obsd_tdep
3497 * sparc-sol2-nat.c: Remove _initialize_sparc_sol2_nat prototype.
3498 * sparc-sol2-tdep.c: Remove _initialize_sparc_sol2_tdep prototype.
3499 * sparc-tdep.c: Remove _initialize_sparc_tdep prototype.
3500 * sparc64-fbsd-nat.c: Remove _initialize_sparc64fbsd_nat
3502 * sparc64-fbsd-tdep.c: Remove _initialize_sparc64fbsd_tdep
3504 * sparc64-linux-nat.c: Remove _initialize_sparc64_linux_nat
3506 * sparc64-linux-tdep.c: Remove _initialize_sparc64_linux_tdep
3508 * sparc64-nat.c: Remove _initialize_sparc64_nat prototype.
3509 * sparc64-nbsd-nat.c: Remove _initialize_sparc64nbsd_nat
3511 * sparc64-nbsd-tdep.c: Remove _initialize_sparc64nbsd_tdep
3513 * sparc64-obsd-nat.c: Remove _initialize_sparc64obsd_nat
3515 * sparc64-obsd-tdep.c: Remove _initialize_sparc64obsd_tdep
3517 * sparc64-sol2-tdep.c: Remove _initialize_sparc64_sol2_tdep
3519 * spu-linux-nat.c: Remove _initialize_spu_nat prototype.
3520 * spu-multiarch.c: Remove _initialize_spu_multiarch prototype.
3521 * spu-tdep.c: Remove _initialize_spu_tdep prototype.
3522 * stabsread.c: Remove _initialize_stabsread prototype.
3523 * stack.c: Remove _initialize_stack prototype.
3524 * stap-probe.c: Remove _initialize_stap_probe prototype.
3525 * std-regs.c: Remove _initialize_frame_reg prototype.
3526 * symfile-debug.c: Remove _initialize_symfile_debug prototype.
3527 * symfile-mem.c: Remove _initialize_symfile_mem prototype.
3528 * symfile.c: Remove _initialize_symfile prototype.
3529 * symmisc.c: Remove _initialize_symmisc prototype.
3530 * symtab.c: Remove _initialize_symtab prototype.
3531 * target-dcache.c: Remove _initialize_target_dcache prototype.
3532 * target-descriptions.c: Remove _initialize_target_descriptions
3534 * thread.c: Remove _initialize_thread prototype.
3535 * tic6x-linux-tdep.c: Remove _initialize_tic6x_linux_tdep
3537 * tic6x-tdep.c: Remove _initialize_tic6x_tdep prototype.
3538 * tilegx-linux-nat.c: Remove _initialize_tile_linux_nat prototype.
3539 * tilegx-linux-tdep.c: Remove _initialize_tilegx_linux_tdep
3541 * tilegx-tdep.c: Remove _initialize_tilegx_tdep prototype.
3542 * tracefile-tfile.c: Remove _initialize_tracefile_tfile prototype.
3543 * tracefile.c: Remove _initialize_tracefile prototype.
3544 * tracepoint.c: Remove _initialize_tracepoint prototype.
3545 * tui/tui-hooks.c: Remove _initialize_tui_hooks prototype.
3546 * tui/tui-interp.c: Remove _initialize_tui_interp prototype.
3547 * tui/tui-layout.c: Remove _initialize_tui_layout prototype.
3548 * tui/tui-regs.c: Remove _initialize_tui_regs prototype.
3549 * tui/tui-stack.c: Remove _initialize_tui_stack prototype.
3550 * tui/tui-win.c: Remove _initialize_tui_win prototype.
3551 * tui/tui.c: Remove _initialize_tui prototype.
3552 * typeprint.c: Remove _initialize_typeprint prototype.
3553 * user-regs.c: Remove _initialize_user_regs prototype.
3554 * utils.c: Remove _initialize_utils prototype.
3555 * v850-tdep.c: Remove _initialize_v850_tdep prototype.
3556 * valarith.c: Remove _initialize_valarith prototype.
3557 * valops.c: Remove _initialize_valops prototype.
3558 * valprint.c: Remove _initialize_valprint prototype.
3559 * value.c: Remove _initialize_values prototype.
3560 * varobj.c: Remove _initialize_varobj prototype.
3561 * vax-bsd-nat.c: Remove _initialize_vaxbsd_nat prototype.
3562 * vax-nbsd-tdep.c: Remove _initialize_vaxnbsd_tdep prototype.
3563 * vax-tdep.c: Remove _initialize_vax_tdep prototype.
3564 * windows-nat.c: Remove _initialize_windows_nat,
3565 _initialize_check_for_gdb_ini, and _initialize_loadable
3567 * windows-tdep.c: Remove _initialize_windows_tdep prototype.
3568 * xcoffread.c: Remove _initialize_xcoffread prototype.
3569 * xml-support.c: Remove _initialize_xml_support prototype.
3570 * xstormy16-tdep.c: Remove _initialize_xstormy16_tdep prototype.
3571 * xtensa-linux-nat.c: Remove _initialize_xtensa_linux_nat
3573 * xtensa-linux-tdep.c: Remove _initialize_xtensa_linux_tdep
3575 * xtensa-tdep.c: Remove _initialize_xtensa_tdep prototype.
3579 * dwarf2read.c (struct field_info) <fnfields>: Remove unused
3584 * f-valprint.c (f_val_print): Remove check for one byte
3585 sized integers. Remove printing of character type.
3591 * f-typeprint.c (f_type_print_base): Use fprintfi_filtered
3592 to maintain proper indentation when printing pointers/refs.
3600 * NEWS (Changes in GDB 7.11): Remove entry for QStartupWithShell.
3604 * parse.c (funcall_chain): Now a std::vector.
3605 (start_arglist, end_arglist): Simplify.
3606 (free_funcalls): Remove.
3607 (parse_exp_in_context_1): Remove cleanup.
3611 * go-exp.y (go_parse): Don't create a cleanup.
3615 * d-exp.y (PrimaryExpression): Use std::string.
3616 (d_parse): Don't create a cleanup.
3620 * utils.c (do_clear_parser_state): Remove.
3621 (make_cleanup_clear_parser_state): Remove.
3622 * p-exp.y (pascal_parse): Use scoped_restore.
3623 * m2-exp.y (m2_parse): Use scoped_restore.
3624 * f-exp.y (f_parse): Use scoped_restore.
3625 * d-exp.y (d_parse): Use scoped_restore.
3626 * c-exp.y (c_parse): Use scoped_restore.
3627 * ada-exp.y (ada_parse): Use scoped_restore.
3628 * utils.h (make_cleanup_clear_parser_state): Remove.
3632 * dwarf2read.c (dw2_linkage_name_attr): New function.
3633 (dw2_linkage_name): New function.
3634 (dwarf2_compute_name, dwarf2_physname, read_call_site_scope)
3635 (guess_full_die_structure_name, dwarf2_name): Use dw2_linkage_name.
3636 (anonymous_struct_prefix, dwarf2_name): Use dw2_linkage_name_attr.
3640 * config/djgpp/djconfig.sh: Correct shell portability issue.
3644 * configure.nat: Define HAVE_NATIVE_GCORE_HOST on NetBSD.
3648 * Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c.
3649 * NEWS: Mention new FreeBSD/mips native configuration.
3650 * configure.host: Add aarch64*-*-freebsd*.
3651 * configure.nat: Likewise.
3652 * aarch64-fbsd-nat.c: New file.
3656 * Makefile.in (ALL_64_TARGET_OBS): Add aarch64-fbsd-tdep.o.
3657 (ALLDEPFILES): Add aarch64-fbsd-tdep.c.
3658 * NEWS: Mention new FreeBSD/aarch64 target.
3659 * configure.tgt: Add aarch64*-*-freebsd*.
3660 * aarch64-fbsd-tdep.c: New file.
3661 * aarch64-fbsd-tdep.h: New file.
3665 * MAINTAINERS (Write After Approval): Add Kamil Rytarowski.
3669 * parse.c (find_minsym_type_and_address): Don't relocate addresses
3674 * objfiles.c (get_objfile_bfd_data): Remove useless obstack_init
3679 * infrun.c (follow_exec): Call add_thread after
3680 target_find_description.
3684 * infrun.c (handle_inferior_event_1): When exec'ing, read
3685 stop_pc after follow_exec.
3689 * remote.c (process_g_packet): Update error message.
3693 * configure.tgt (gdb_target_obs): Add i386.o for x86_64-*
3698 * eval.c (eval_call, evaluate_funcall): New functions, factored
3700 (evaluate_subexp_standard): ... this.
3704 * amd64-tdep.c (amd64_target_description): Create target
3706 (_initialize_amd64_tdep): Don't call functions
3707 initialize_tdesc_amd64_*. Add self tests.
3708 * arch/amd64.c (amd64_create_target_description): Add parameter
3709 is_linux. Call set_tdesc_osabi if is_linux is true.
3710 * arch/amd64.h (amd64_create_target_description): Update the
3712 * arch/i386.c (i386_create_target_description): Add parameter
3713 is_linux. Call set_tdesc_osabi if is_linux is true.
3714 * arch/i386.h (i386_create_target_description): Update
3716 * configure.tgt: Add i386.o to gdb_target_obs.
3717 * features/Makefile (XMLTOC): Remove i386/*.xml.
3718 * features/i386/amd64-avx-avx512.c: Remove.
3719 * features/i386/amd64-avx-mpx-avx512-pku.c: Remove.
3720 * features/i386/amd64-avx-mpx.c: Remove.
3721 * features/i386/amd64-avx.c: Remove.
3722 * features/i386/amd64-mpx.c: Remove.
3723 * features/i386/amd64.c: Remove.
3724 * features/i386/i386-avx-avx512.c: Remove.
3725 * features/i386/i386-avx-mpx-avx512-pku.c: Remove.
3726 * features/i386/i386-avx-mpx.c: Remove.
3727 * features/i386/i386-avx.c: Remove.
3728 * features/i386/i386-mmx.c: Remove.
3729 * features/i386/i386-mpx.c: Remove.
3730 * features/i386/i386.c: Remove.
3731 * i386-tdep.c: Don't include features/i386/i386*.c., include
3732 target-descriptions.h and arch/i386.h.
3733 (i386_target_description): Create target descriptions.
3734 (i386_gdbarch_init): Don't call initialize_tdesc_i386_*
3735 functions. Do self tests.
3739 * features/Makefile (XMLTOC): Remove i386/amd64XXX-linux.xml.
3740 * features/i386/amd64-avx-avx512-linux.c: Removed.
3741 * features/i386/amd64-avx-linux.c: Removed.
3742 * features/i386/amd64-avx-mpx-avx512-pku-linux.c: Removed.
3743 * features/i386/amd64-avx-mpx-linux.c: Removed.
3744 * features/i386/amd64-linux.c: Removed.
3745 * features/i386/amd64-mpx-linux.c: Removed.
3746 * features/i386/x32-avx-avx512-linux.c: Removed.
3747 * features/i386/x32-avx-linux.c: Removed.
3748 * features/i386/x32-linux.c: Removed.
3752 * amd64-linux-tdep.c: Include arch/amd64.h. Don't include
3754 (amd64_linux_read_description): Call
3755 amd64_create_target_description.
3756 * arch/amd64.c: New file.
3757 * arch/amd64.h: New file.
3758 * configure.tgt (x86_64-*-linux*): Append amd64.o.
3759 * Makefile.in (ALL_64_TARGET_OBS): Append amd64.o.
3763 * amd64-linux-tdep.c: Don't include amd64-XXX-linux and
3764 x32-XXX-linux.c. Include 64bit-XX.c and x32-XX.c.
3765 (amd64_linux_read_description): Create target descriptions.
3766 (_initialize_amd64_linux_tdep): Don't call initialize_tdesc_XXX
3767 functions. Add unit tests.
3768 * features/Makefile (FEATURE_XMLFILES): Append 64bit-XXX.xml and
3770 * features/i386/64bit-avx.c: Generated.
3771 * features/i386/64bit-avx512.c: Generated.
3772 * features/i386/64bit-core.c: Generated.
3773 * features/i386/64bit-linux.c: Generated.
3774 * features/i386/64bit-mpx.c: Generated.
3775 * features/i386/64bit-pkeys.c: Generated.
3776 * features/i386/64bit-segments.c: Generated.
3777 * features/i386/64bit-sse.c: Generated.
3778 * features/i386/x32-core.c: Generated.
3779 * target-descriptions.c (maint_print_c_tdesc_cmd): Print feature
3780 c files for amd64-linux and x32-linux.
3784 * amd64-linux-tdep.c (amd64_linux_read_description): New
3786 (amd64_linux_core_read_description): Call
3787 amd64_linux_read_description.
3788 (amd64_linux_init_abi): Likewise.
3789 (amd64_x32_linux_init_abi): Likewise.
3790 * amd64-linux-tdep.h (amd64_linux_read_description): Declare.
3791 * x86-linux-nat.c (x86_linux_read_description): Call
3792 amd64_linux_read_description.
3796 * amd64-linux-tdep.c (amd64_linux_core_read_description): Update
3801 * features/Makefile (XMLTOC): Remove i386/i386-XX-linux.xml.
3802 * features/i386/i386-avx-avx512-linux.c: Remove.
3803 * features/i386/i386-avx-linux.c: Remove.
3804 * features/i386/i386-avx-mpx-avx512-pku-linux.c: Remove.
3805 * features/i386/i386-avx-mpx-linux.c: Remove.
3806 * features/i386/i386-linux.c: Remove.
3807 * features/i386/i386-mmx-linux.c: Remove.
3808 * features/i386/i386-mpx-linux.c: Remove.
3812 * Makefile.in (ALL_TARGET_OBS): Add i386.o.
3813 (SFILES): Add arch/i386.c.
3814 (HFILES_NO_SRCDIR): Add arch/i386.h.
3815 * arch/i386.c: New file.
3816 * arch/i386.h: New file.
3817 * arch/tdesc.h (allocate_target_description): Declare.
3818 (set_tdesc_architecture): Declare.
3819 (set_tdesc_osabi): Declare.
3820 * configure.tgt (i[34567]86-*-linux*): Add i386.o.
3821 * i386-linux-tdep.c: Don't include ../features/i386/32bit-XXX.c.
3822 include arch/i386.h.
3823 (i386_linux_read_description): Remove code and call
3824 i386_create_target_description.
3825 (set_tdesc_architecture): New function.
3826 (set_tdesc_osabi): New function.
3827 * target-descriptions.h (allocate_target_description): Remove.
3831 * arch/tdesc.h (tdesc_create_feature): Add an argument xml.
3832 * target-descriptions.c (tdesc_create_feature): Likewise, and
3834 * features/i386/32bit-avx.c: Re-generated.
3835 * features/i386/32bit-avx512.c: Re-generated.
3836 * features/i386/32bit-core.c: Re-generated.
3837 * features/i386/32bit-linux.c: Re-generated.
3838 * features/i386/32bit-mpx.c: Re-generated.
3839 * features/i386/32bit-pkeys.c: Re-generated.
3840 * features/i386/32bit-sse.c: Re-generated.
3844 * regformats/regdef.h (struct reg): Override operator == and !=.
3848 * arch/tdesc.h: New file.
3849 * regformats/regdat.sh: Generate code using tdesc_create_reg.
3850 * target-descriptions.c: Update comments.
3851 * target-descriptions.h: Include "arch/tdesc.h". Remove the
3853 * features/i386/32bit-avx.c: Re-generated.
3854 * features/i386/32bit-avx512.c: Re-generated.
3855 * features/i386/32bit-core.c: Re-generated.
3856 * features/i386/32bit-linux.c: Re-generated.
3857 * features/i386/32bit-mpx.c: Re-generated.
3858 * features/i386/32bit-pkeys.c: Re-generated.
3859 * features/i386/32bit-sse.c: Re-generated.
3863 * regformats/regdat.sh: Update generated code.
3867 * regformats/regdat.sh: Adjust code order.
3871 * expprint.c (dump_subexp_body_standard): Use constant format
3872 string in fprintf_filtered call.
3876 * configure.nat: Add "x86-nat.o x86-dregs.o" for NetBSD/amd64 and
3878 * x86-bsd-nat.c [!DBREG_DRX && __NetBSD__]: Define DBREG_DRX.
3882 * bsd-kvm.o: Make <sys/user.h> conditional on HAVE_SYS_USER_H.
3886 * bsd-kvm.o: Define _KMEMUSER.
3887 * configure.ac: Define _KMEMUSER when checking for "struct lwp".
3888 * configure: Regenerate.
3892 * amd64-fbsd-nat.c: Add include of "x86-xstate.h".
3893 * i386-fbsd-nat.c: Likewise.
3897 * unittests/array-view-selftests.c: Add include of <array>.
3901 * spu-tdep.c (flush_ea_cache): Add missing argument to
3902 call_function_by_hand.
3906 * NEWS (Safer support for debugging with no debug info): New.
3910 * c-exp.y (function_method, function_method_void): Add current
3911 instance flags to TYPE_INSTANCE.
3912 * dwarf2read.c (check_modifier): New.
3913 (compute_delayed_physnames): Assert that only C++ adds delayed
3914 physnames. Mark fn_fields as const/volatile depending on
3916 * eval.c (make_params): New type_instance_flags parameter. Use
3917 it as the new type's instance flags.
3918 (evaluate_subexp_standard) <TYPE_INSTANCE>: Extract the instance
3919 flags element and pass it to make_params.
3920 * expprint.c (print_subexp_standard) <TYPE_INSTANCE>: Handle
3921 instance flags element.
3922 (dump_subexp_body_standard) <TYPE_INSTANCE>: Likewise.
3923 * gdbtypes.h: Include "enum-flags.h".
3924 (type_instance_flags): New enum-flags type.
3925 (TYPE_CONST, TYPE_VOLATILE, TYPE_RESTRICT, TYPE_ATOMIC)
3926 (TYPE_CODE_SPACE, TYPE_DATA_SPACE): Return boolean.
3927 * parse.c (operator_length_standard) <TYPE_INSTANCE>: Adjust.
3928 (follow_type_instance_flags): New function.
3929 (operator_check_standard) <TYPE_INSTANCE>: Adjust.
3930 * parser-defs.h (follow_type_instance_flags): Declare.
3931 * valops.c (value_struct_elt_for_reference): const/volatile must
3936 * cp-namespace.c (cp_search_static_and_baseclasses): Handle
3937 function/method scopes; lookup the nested name as a function local
3942 (%type <voidval>): Add function_method.
3943 * c-exp.y (exp): New production for calls with no arguments.
3944 (function_method, function_method_void_or_typelist): New
3946 (exp): New production for "method()::static_var".
3947 * eval.c (evaluate_subexp_standard): Handle OP_FUNC_STATIC_VAR.
3948 * expprint.c (print_subexp_standard, dump_subexp_body_standard):
3949 Handle OP_FUNC_STATIC_VAR.
3950 * parse.c (operator_length_standard):
3951 Handle OP_FUNC_STATIC_VAR.
3955 * eval.c (evaluate_subexp_standard): Remove UNOP_MEMVAL_TLS
3957 * expprint.c (print_subexp_standard, dump_subexp_body_standard):
3959 * parse.c (operator_length_standard, operator_check_standard):
3961 * std-operator.def (UNOP_MEMVAL_TLS): Delete.
3965 * ax-gdb.c: Include "typeprint.h".
3966 (gen_expr_for_cast): New function.
3967 (gen_expr) <OP_CAST, OP_CAST_TYPE>: Use it.
3968 <OP_VAR_VALUE, OP_MSYM_VAR_VALUE>: Error out if the variable's
3970 * dwarf2read.c (new_symbol_full): Fallback to int instead of
3971 nodebug_data_symbol.
3972 * eval.c: Include "typeprint.h".
3973 (evaluate_subexp_standard) <OP_VAR_VALUE, OP_VAR_MSYM_VALUE>:
3974 Error out if symbol has unknown type.
3975 <UNOP_CAST, UNOP_CAST_TYPE>: Common bits factored out to
3976 evaluate_subexp_for_cast.
3977 (evaluate_subexp_for_address, evaluate_subexp_for_sizeof): Handle
3979 (evaluate_subexp_for_cast): New function.
3980 * gdbtypes.c (init_nodebug_var_type): New function.
3981 (objfile_type): Use it to initialize types of variables with no
3983 * typeprint.c (error_unknown_type): New.
3984 * typeprint.h (error_unknown_type): New declaration.
3985 * compile/compile-c-types.c (convert_type_basic): Handle
3986 TYPE_CODE_ERROR; warn and fallback to int for variables with
3991 * eval.c (evaluate_var_value): New function, factored out from ...
3992 (evaluate_subexp_standard): ... here.
3996 * eval.c (evaluate_subexp_standard) <UNOP_COMPLEMENT, UNOP_ADDR>:
3997 Remove useless assignments to 'op'.
4001 * eval.c (eval_skip_value): New function.
4002 (evaluate_subexp_standard): Use it.
4006 * eval.c (evaluate_subexp_standard): <OP_FUNCALL>: Extract
4007 function name from symbol/minsym and pass it to
4008 error_call_unknown_return_type.
4012 * ada-lang.c (resolve_subexp): Handle OP_VAR_MSYM_VALUE.
4013 * ax-gdb.c (gen_msym_var_ref): New function.
4014 (gen_expr): Handle OP_VAR_MSYM_VALUE.
4015 * eval.c (evaluate_var_msym_value): New function.
4016 * eval.c (evaluate_subexp_standard): Handle OP_VAR_MSYM_VALUE.
4017 <OP_FUNCALL>: Extract function name from symbol/minsym and pass it
4018 to call_function_by_hand.
4019 * expprint.c (print_subexp_standard, dump_subexp_body_standard):
4020 Handle OP_VAR_MSYM_VALUE.
4021 (union exp_element) <msymbol>: New field.
4022 * minsyms.h (struct type): Forward declare.
4023 (find_minsym_type_and_address): Declare.
4024 * parse.c (write_exp_elt_msym): New function.
4025 (write_exp_msymbol): Delete, refactored as ...
4026 (find_minsym_type_and_address): ... this new function.
4027 (write_exp_msymbol): Reimplement using OP_VAR_MSYM_VALUE.
4028 (operator_length_standard, operator_check_standard): Handle
4030 * std-operator.def (OP_VAR_MSYM_VALUE): New.
4034 * ada-lang.c (ada_evaluate_subexp) <TYPE_CODE_FUNC>: Don't handle
4035 TYPE_GNU_IFUNC specially here. Throw error if return type is
4037 * ada-typeprint.c (print_func_type): Handle functions with unknown
4039 * c-typeprint.c (c_type_print_base): Handle functions and methods
4040 with unknown return type.
4041 * compile/compile-c-symbols.c (convert_symbol_bmsym)
4042 <mst_text_gnu_ifunc>: Use nodebug_text_gnu_ifunc_symbol.
4043 * compile/compile-c-types.c: Include "objfiles.h".
4044 (convert_func): For functions with unknown return type, warn and
4046 * compile/compile-object-run.c (compile_object_run): Adjust call
4047 to call_function_by_hand_dummy.
4048 * elfread.c (elf_gnu_ifunc_resolve_addr): Adjust call to
4049 call_function_by_hand.
4050 * eval.c (evaluate_subexp_standard): Adjust calls to
4051 call_function_by_hand. Handle functions and methods with unknown
4052 return type. Pass expect_type to call_function_by_hand.
4053 * f-typeprint.c (f_type_print_base): Handle functions with unknown
4055 * gcore.c (call_target_sbrk): Adjust call to
4056 call_function_by_hand.
4057 * gdbtypes.c (objfile_type): Leave nodebug text symbol with NULL
4058 return type instead of int. Make nodebug_text_gnu_ifunc_symbol be
4059 an integer address type instead of nodebug.
4060 * guile/scm-value.c (gdbscm_value_call): Adjust call to
4061 call_function_by_hand.
4062 * infcall.c (error_call_unknown_return_type): New function.
4063 (call_function_by_hand): New "default_return_type" parameter.
4065 (call_function_by_hand_dummy): New "default_return_type"
4066 parameter. Use it instead of defaulting to int. If there's no
4067 default and the return type is unknown, throw an error. If
4068 there's a default return type, and the called function has no
4069 debug info, then assume the function is prototyped.
4070 * infcall.h (call_function_by_hand, call_function_by_hand_dummy):
4071 New "default_return_type" parameter.
4072 (error_call_unknown_return_type): New declaration.
4073 * linux-fork.c (call_lseek): Cast return type of lseek.
4074 (inferior_call_waitpid, checkpoint_command): Adjust calls to
4075 call_function_by_hand.
4076 * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap): Adjust
4077 calls to call_function_by_hand.
4078 * m2-typeprint.c (m2_procedure): Handle functions with unknown
4080 * objc-lang.c (lookup_objc_class, lookup_child_selector)
4081 (value_nsstring, print_object_command): Adjust calls to
4082 call_function_by_hand.
4083 * p-typeprint.c (pascal_type_print_varspec_prefix): Handle
4084 functions with unknown return type.
4085 (pascal_type_print_func_varspec_suffix): New function.
4086 (pascal_type_print_varspec_suffix) <TYPE_CODE_FUNC,
4087 TYPE_CODE_METHOD>: Use it.
4088 * python/py-value.c (valpy_call): Adjust call to
4089 call_function_by_hand.
4090 * rust-lang.c (rust_evaluate_funcall): Adjust call to
4091 call_function_by_hand.
4092 * valarith.c (value_x_binop, value_x_unop): Adjust calls to
4093 call_function_by_hand.
4094 * valops.c (value_allocate_space_in_inferior): Adjust call to
4095 call_function_by_hand.
4096 * typeprint.c (type_print_unknown_return_type): New function.
4097 * typeprint.h (type_print_unknown_return_type): New declaration.
4101 * gdbtypes.c (lookup_function_type_with_arguments): Mark function
4102 types with more than one parameter as prototyped.
4106 * cli/cli-cmds.c (print_disassembly, disassemble_current_function)
4107 (disassemble_command): Use gdb_disassembly_flags instead of bare
4109 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn)
4110 (dump_insns, do_mixed_source_and_assembly_deprecated)
4111 (do_mixed_source_and_assembly, do_assembly_only, gdb_disassembly):
4112 Use gdb_disassembly_flags instead of bare int.
4113 * disasm.h (DISASSEMBLY_SOURCE_DEPRECATED, DISASSEMBLY_RAW_INSN)
4114 (DISASSEMBLY_OMIT_FNAME, DISASSEMBLY_FILENAME)
4115 (DISASSEMBLY_OMIT_PC, DISASSEMBLY_SOURCE)
4116 (DISASSEMBLY_SPECULATIVE): No longer macros. Instead they're...
4117 (enum gdb_disassembly_flag): ... values of this new enumeration.
4118 (gdb_disassembly_flags): Define.
4120 (gdb_pretty_print_disassembler::pretty_print_insn): Use it.
4121 * mi/mi-cmd-disas.c (mi_cmd_disassemble): Use
4122 gdb_disassembly_flags instead of bare int.
4123 * record-btrace.c (btrace_insn_history)
4124 (record_btrace_insn_history, record_btrace_insn_history_range)
4125 (record_btrace_insn_history_from): Use gdb_disassembly_flags
4126 instead of bare int.
4127 * record.c (get_insn_history_modifiers, cmd_record_insn_history):
4128 Use gdb_disassembly_flags instead of bare int.
4129 * target-debug.h (target_debug_print_gdb_disassembly_flags):
4131 * target-delegates.c: Regenerate.
4132 * target.c (target_insn_history, target_insn_history_from)
4133 (target_insn_history_range): Use gdb_disassembly_flags instead of
4135 * target.h: Include "disasm.h".
4136 (struct target_ops) <to_insn_history, to_insn_history_from,
4137 to_insn_history_range>: Use gdb_disassembly_flags instead of bare
4139 (target_insn_history, target_insn_history_from)
4140 (target_insn_history_range): Use gdb_disassembly_flags instead of
4145 * cli/cli-script.c (build_command_line): For if/while commands,
4146 check whether args is empty.
4150 * cli/cli-script.h (enum misc_command_type): Move from defs.h.
4151 (enum command_control_type): Likewise.
4152 (struct command_line): Likewise.
4153 (free_command_lines): Likewise.
4154 (struct command_lines_deleter): Likewise.
4155 (command_line_up): Likewise.
4156 (read_command_lines): Likewise.
4157 (read_command_lines_1): Likewise.
4158 * defs.h (enum misc_command_type): Move to cli/cli-script.h.
4159 (enum command_control_type): Likewise.
4160 (struct command_line): Likewise.
4161 (free_command_lines): Likewise.
4162 (struct command_lines_deleter): Likewise.
4163 (command_line_up): Likewise.
4164 (read_command_lines): Likewise.
4165 (read_command_lines_1): Likewise.
4166 * breakpoint.h: Include cli/cli-script.h.
4167 * extension-priv.h: Likewise.
4168 * gdbcmd.h: Likewise.
4172 * ada-lang.c (is_known_support_routine): Move sal declaration to
4173 where it is initialized.
4174 * breakpoint.c (create_internal_breakpoint, init_catchpoint)
4175 (parse_breakpoint_sals, decode_static_tracepoint_spec)
4176 (clear_command, update_static_tracepoint): Remove init_sal
4177 references. Move declarations closer to initializations.
4178 * cli/cli-cmds.c (list_command): Move sal declarations closer to
4180 * elfread.c (elf_gnu_ifunc_resolver_stop): Remove init_sal
4181 references. Move sal declarations closer to initializations.
4182 * frame.c (find_frame_sal): Return a symtab_and_line via function
4183 return instead of output parameter. Remove init_sal references.
4184 * frame.h (find_frame_sal): Return a symtab_and_line via function
4185 return instead of output parameter.
4186 * guile/scm-frame.c (gdbscm_frame_sal): Adjust.
4187 * guile/scm-symtab.c (stscm_make_sal_smob): Use in-place new
4189 (gdbscm_find_pc_line): Remove init_sal reference.
4190 * infcall.c (call_function_by_hand_dummy): Remove init_sal
4191 references. Move declarations closer to initializations.
4192 * infcmd.c (set_step_frame): Update. Move declarations closer to
4194 (finish_backward): Remove init_sal references. Move declarations
4195 closer to initializations.
4196 * infrun.c (process_event_stop_test, handle_step_into_function)
4197 (insert_hp_step_resume_breakpoint_at_frame)
4198 (insert_step_resume_breakpoint_at_caller): Likewise.
4199 * linespec.c (create_sals_line_offset, decode_digits_ordinary)
4200 (symbol_to_sal): Likewise.
4201 * probe.c (parse_probes_in_pspace): Remove init_sal reference.
4202 * python/py-frame.c (frapy_find_sal): Move sal declaration closer
4203 to its initialization.
4204 * reverse.c (save_bookmark_command): Use new/delete. Remove
4205 init_sal references. Move declarations closer to initializations.
4206 * source.c (get_current_source_symtab_and_line): Remove brace
4208 (set_current_source_symtab_and_line): Now takes the sal by const
4209 reference. Remove brace initialization.
4210 (line_info): Remove init_sal reference.
4211 * source.h (set_current_source_symtab_and_line): Now takes a
4212 symtab_and_line via const reference.
4213 * stack.c (set_current_sal_from_frame): Adjust.
4214 (print_frame_info): Adjust.
4215 (get_last_displayed_sal): Return the sal via function return
4216 instead of via output parameter. Simplify.
4217 (frame_info): Adjust.
4218 * stack.h (get_last_displayed_sal): Return the sal via function
4219 return instead of via output parameter.
4220 * symtab.c (init_sal): Delete.
4221 (find_pc_sect_line): Remove init_sal references. Move
4222 declarations closer to initializations.
4223 (find_function_start_sal): Remove init_sal references. Move
4224 declarations closer to initializations.
4225 * symtab.h (struct symtab_and_line): In-class initialize all
4227 * tracepoint.c (set_traceframe_context)
4228 (print_one_static_tracepoint_marker): Remove init_sal references.
4229 Move declarations closer to initializations.
4230 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Adjust.
4231 * tui/tui-stack.c (tui_show_frame_info): Adjust. Move
4232 declarations closer to initializations.
4233 * tui/tui-winsource.c (tui_update_source_window_as_is): Remove
4234 init_sal references. Adjust.
4238 * ax-gdb.c (agent_command_1): Use range-for.
4239 * break-catch-throw.c (re_set_exception_catchpoint): Update.
4240 * breakpoint.c: Include "common/array-view.h".
4241 (init_breakpoint_sal, create_breakpoint_sal): Change sals
4242 parameter from struct symtabs_and_lines to
4243 array_view<symtab_and_line>. Adjust. Use range-for. Update.
4244 (breakpoint_sals_to_pc): Change sals parameter from struct
4245 symtabs_and_lines to std::vector reference.
4246 (check_fast_tracepoint_sals): Change sals parameter from struct
4247 symtabs_and_lines to std::array_view. Use range-for.
4248 (decode_static_tracepoint_spec): Return a std::vector instead of
4249 symtabs_and_lines. Update.
4250 (create_breakpoint): Update.
4251 (break_range_command, until_break_command, clear_command): Update.
4252 (base_breakpoint_decode_location, bkpt_decode_location)
4253 (bkpt_probe_create_sals_from_location)
4254 (bkpt_probe_decode_location, tracepoint_decode_location)
4255 (tracepoint_probe_decode_location)
4256 (strace_marker_create_sals_from_location): Return a std::vector
4257 instead of symtabs_and_lines.
4258 (strace_marker_create_breakpoints_sal): Update.
4259 (strace_marker_decode_location): Return a std::vector instead of
4260 symtabs_and_lines. Update.
4261 (update_breakpoint_locations): Change struct symtabs_and_lines
4262 parameters to gdb::array_view. Adjust.
4263 (location_to_sals): Return a std::vector instead of
4264 symtabs_and_lines. Update.
4265 (breakpoint_re_set_default): Use std::vector instead of struct
4267 (decode_location_default): Return a std::vector instead of
4268 symtabs_and_lines. Update.
4269 * breakpoint.h: Include "common/array-view.h".
4270 (struct breakpoint_ops) <decode_location>: Now returns a
4271 std::vector instead of returning a symtabs_and_lines via output
4273 (update_breakpoint_locations): Change sals parameters to use
4275 * cli/cli-cmds.c (edit_command, list_command): Update to use
4276 std::vector and gdb::array_view.
4277 (ambiguous_line_spec): Adjust to use gdb::array_view and
4279 (compare_symtabs): Rename to ...
4280 (cmp_symtabs): ... this. Change parameters to symtab_and_line
4281 const reference and adjust.
4282 (filter_sals): Rewrite using std::vector and standard algorithms.
4283 * elfread.c (elf_gnu_ifunc_resolver_return_stop): Simplify.
4284 (jump_command): Update to use std::vector.
4285 * linespec.c (struct linespec_state) <canonical_names>: Update
4287 (add_sal_to_sals_basic): Delete.
4288 (add_sal_to_sals, filter_results, convert_results_to_lsals)
4289 (decode_line_2, create_sals_line_offset)
4290 (convert_address_location_to_sals, convert_linespec_to_sals)
4291 (convert_explicit_location_to_sals, parse_linespec)
4292 (event_location_to_sals, decode_line_full, decode_line_1)
4293 (decode_line_with_current_source)
4294 (decode_line_with_last_displayed, decode_objc)
4295 (decode_digits_list_mode, decode_digits_ordinary, minsym_found)
4296 (linespec_result::~linespec_result): Adjust to use std::vector
4297 instead of symtabs_and_lines.
4298 * linespec.h (linespec_sals::sals): Now a std::vector.
4299 (struct linespec_result): Use std::vector, bool, and in-class
4301 (decode_line_1, decode_line_with_current_source)
4302 (decode_line_with_last_displayed): Return std::vector.
4303 * macrocmd.c (info_macros_command): Use std::vector.
4304 * mi/mi-main.c (mi_cmd_trace_find): Use std::vector.
4305 * probe.c (parse_probes_in_pspace, parse_probes): Adjust to use
4307 * probe.h (parse_probes): Return a std::vector.
4308 * python/python.c (gdbpy_decode_line): Use std::vector and
4310 * source.c (select_source_symtab, line_info): Use std::vector.
4311 * stack.c (func_command): Use std::vector.
4312 * symtab.h (struct symtabs_and_lines): Delete.
4313 * tracepoint.c (tfind_line_command, scope_info): Use std::vector.
4317 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4318 unittests/array-view-selftests.c.
4319 (SUBDIR_UNITTESTS_OBS): Add array-view-selftests.o.
4320 * common/array-view.h: New file.
4321 * unittests/array-view-selftests.c: New file.
4325 * cli/cli-cmds.c (edit_command): Pass message to
4326 ambiguous_line_spec.
4327 (list_command): Pass message to ambiguous_line_spec. Say
4328 "first"/"last" instead of "start" and "end" to be consistent with
4330 (ambiguous_line_spec): Add 'format' and vararg parameters. Use
4331 them to print formatted message.
4335 * btrace.c (ftrace_add_pt): Pass btrace_insn to
4336 ftrace_update_insns by reference instead of pointer.
4340 * i386-go32-tdep.c: Include x86-xstate.h.
4341 (i386_go32_init_abi): Call i386_target_description.
4342 * i386-tdep.c (i386_target_description): Return tdesc_i386_mmx
4343 if xcr0 is X86_XSTATE_X87_MASK.
4344 * i386-tdep.h (tdesc_i386): Remove the declaration.
4345 (tdesc_i386_mmx): Likewise.
4349 * i386-fbsd-tdep.c (i386fbsd_core_read_xcr0): Return
4350 X86_XSTATE_SSE_MASK instead of 0.
4354 * amd64-fbsd-nat.c (amd64fbsd_read_description): Call
4355 i386_target_description.
4356 * i386-fbsd-nat.c (i386fbsd_read_description): Call
4357 i386_target_description.
4358 * i386-tdep.c (i386_gdbarch_init): Likewise.
4362 * amd64-darwin-tdep.c: Include "x86-xstate.h".
4363 (x86_darwin_init_abi_64): Call amd64_target_description.
4364 * amd64-dicos-tdep.c: Likewise.
4365 * amd64-fbsd-nat.c: Likewise.
4366 * amd64-fbsd-tdep.c: Likewise.
4367 * amd64-nbsd-tdep.c: Likewise.
4368 * amd64-obsd-tdep.c: Likewise.
4369 * amd64-sol2-tdep.c: Likewise.
4370 * amd64-windows-tdep.c: Likewise.
4371 * amd64-tdep.h (tdesc_amd64): Remove the declaration.
4375 * btrace.h (btrace_insn_s, DEF_VEC_O (btrace_insn_s)): Remove.
4376 (btrace_function) <insn>: Change type to use std::vector.
4377 * btrace.c (ftrace_debug, ftrace_call_num_insn,
4378 ftrace_find_call, ftrace_new_gap, ftrace_update_function,
4379 ftrace_update_insns, ftrace_compute_global_level_offset,
4380 btrace_stitch_bts, btrace_clear, btrace_insn_get,
4381 btrace_insn_end, btrace_insn_next, btrace_insn_prev): Adjust to
4382 change to std::vector.
4383 (ftrace_update_insns): Adjust to change to std::vector, change
4384 type of INSN parameter.
4385 (btrace_compute_ftrace_bts): Adjust call to ftrace_update_insns.
4386 * record-btrace.c (btrace_call_history_insn_range,
4387 btrace_compute_src_line_range,
4388 record_btrace_frame_prev_register): Adjust to change to
4390 * python/py-record-btrace.c (recpy_bt_func_instructions): Adjust
4391 to change to std::vector.
4395 * corefile.c (reopen_exec_file): Use std::string.
4399 * compile/compile.c (compile_register_name_mangled): Return
4401 * compile/compile-loc2c.c (pushf_register_address): Update.
4402 (pushf_register): Update.
4403 * compile/compile-c-types.c (convert_array): Update.
4404 * compile/compile-c-symbols.c (generate_vla_size): Update.
4405 (error_symbol_once): Use a gdb::unique_xmalloc_ptr.
4406 (symbol_substitution_name): Return a gdb::unique_xmalloc_ptr.
4407 (convert_one_symbol): Update.
4408 (generate_c_for_for_one_variable): Update.
4409 * compile/compile-c-support.c (c_get_range_decl_name): Return a
4411 (generate_register_struct): Update.
4412 * compile/compile-internal.h (c_get_range_decl_name): Return a
4414 (compile_register_name_mangled): Return std::string.
4418 * utils.c (perror_string): Return a std::string.
4419 (throw_perror_with_name, perror_warning_with_name): Update.
4423 * demangle.c (demangle_command): Use std::string,
4428 * cli/cli-setshow.c (do_set_command): Use std::string.
4432 * cli/cli-cmds.c (cd_command): Use gdb::unique_xmalloc_ptr.
4436 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use std::string.
4440 * mi/mi-cmd-env.c (env_execute_cli_command): Use
4441 gdb::unique_xmalloc_ptr.
4445 * thread.c (print_thread_info_1): Use string_printf.
4446 (thread_apply_command, thread_apply_all_command): Use
4451 * valprint.c (val_print_string): Update.
4452 * gdbcore.h (memory_error_message): Return std::string.
4453 * corefile.c (memory_error_message): Return std::string.
4454 (memory_error): Update.
4455 * breakpoint.c (insert_bp_location): Update.
4459 * target/waitstatus.h (target_waitstatus_to_string): Change
4460 return type to std::string.
4461 * target/waitstatus.c (target_waitstatus_to_string): Return
4463 * target.h (target_waitstatus_to_string): Remove declaration.
4464 * infrun.c (resume, clear_proceed_status_thread,
4465 print_target_wait_results, do_target_wait, save_waitstatus,
4466 stop_all_threads): Adjust.
4467 * record-btrace.c (record_btrace_wait): Adjust.
4469 (target_debug_print_struct_target_waitstatus_p): Adjust.
4474 * nat/linux-procfs.c (parse_proc_status_state): Fix PROC_STATE_STOPPED
4479 * NEWS (Changes since GDB 8.0): Add entry mentioning new support
4480 for setting/unsetting environment variables on the remote target.
4481 (New remote packets): Add entries for QEnvironmentHexEncoded,
4482 QEnvironmentUnset and QEnvironmentReset.
4483 * common/environ.c (gdb_environ::operator=): Extend method to
4484 handle m_user_set_env_list and m_user_unset_env_list.
4485 (gdb_environ::clear): Likewise.
4486 (match_var_in_string): Change type of first parameter from 'char
4487 *' to 'const char *'.
4488 (gdb_environ::set): Extend method to handle
4489 m_user_set_env_list and m_user_unset_env_list.
4490 (gdb_environ::unset): Likewise.
4491 (gdb_environ::clear_user_set_env): New method.
4492 (gdb_environ::user_set_envp): Likewise.
4493 (gdb_environ::user_unset_envp): Likewise.
4494 * common/environ.h (gdb_environ): Handle m_user_set_env_list and
4495 m_user_unset_env_list on move constructor/assignment.
4496 (unset): Add new default parameter 'update_unset_list = true'.
4497 (clear_user_set_env): New method.
4498 (user_set_envp): Likewise.
4499 (user_unset_envp): Likewise.
4500 (m_user_set_env_list): New std::set.
4501 (m_user_unset_env_list): Likewise.
4502 * common/rsp-low.c (hex2str): New function.
4503 (bin2hex): New overload for bin2hex function.
4504 * common/rsp-low.c (hex2str): New prototype.
4505 (str2hex): New overload prototype.
4506 * remote.c: Include "environ.h". Add QEnvironmentHexEncoded,
4507 QEnvironmentUnset and QEnvironmentReset.
4508 (remote_protocol_features): Add QEnvironmentHexEncoded,
4509 QEnvironmentUnset and QEnvironmentReset packets.
4510 (send_environment_packet): New function.
4511 (extended_remote_environment_support): Likewise.
4512 (extended_remote_create_inferior): Call
4513 extended_remote_environment_support.
4514 (_initialize_remote): Add QEnvironmentHexEncoded,
4515 QEnvironmentUnset and QEnvironmentReset packet configs.
4516 * unittests/environ-selftests.c (gdb_selftest_env_var):
4518 (test_vector_initialization): New function.
4519 (test_init_from_host_environ): Likewise.
4520 (test_reinit_from_host_environ): Likewise.
4521 (test_set_A_unset_B_unset_A_cannot_find_A_can_find_B):
4523 (test_unset_set_empty_vector): Likewise.
4524 (test_vector_clear): Likewise.
4525 (test_std_move): Likewise.
4526 (test_move_constructor):
4527 (test_self_move): Likewise.
4528 (test_set_unset_reset): Likewise.
4529 (run_tests): Rewrite in terms of the functions above.
4533 * sparc64-tdep.c (adi_stat_t): Fix comment formatting.
4534 (adi_available): Use a temp variable of type CORE_ADDR as argument
4535 3 when calling target_auxv_search.
4536 (adi_normalize_address): Use masks and xor operators to calculate
4538 (adi_read_versions, adi_write_versions, adi_print_versions)
4539 (do_examine, do_assign): Use paddress.
4543 * mips-fbsd-nat.c (getfpregs_supplies): Return true for FIR.
4544 * mips-fbsd-tdep.c (mips_fbsd_supply_fpregs): Split supply of FSR
4545 out of loop and add supply of FIR.
4546 (mips_fbsd_collect_fpregs): Split collect of FSR out of loop and
4552 * cli/cli-script.c (define_command): Don't convert command name
4557 * ada-lang.c (ada_lookup_struct_elt_type): Remove parameter "dispp".
4558 Update all callers accordingly. Remove all code blocks handling
4559 the case where DISPP is not NULL.
4564 * dwarf2read.c (dwarf2_const_value_attr, dump_die_shallow)
4565 (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
4566 (skip_form_bytes, attr_form_is_constant): Handle DW_FORM_implicit_const.
4570 * dwarf2read.c (build_type_psymtabs_reader): New prototype.
4571 (process_psymtab_comp_unit): Accept IS_DEBUG_TYPES.
4572 (read_comp_units_from_section): New parameter abbrev_section, use
4573 read_and_check_comp_unit_head, allocate signatured_type if needed.
4574 (create_all_comp_units): Update read_comp_units_from_section caller.
4579 * remote.c (add_current_inferior_and_thread): Set inferior_ptid
4580 to null_ptid and switch to thread without reading the registers
4581 after adding the inferior.
4585 * NEWS (Changes since GDB 8.0): Add set compile-gcc and show
4587 * compile/compile.c (compile_gcc, show_compile_gcc): New.
4588 (compile_to_object): Implement compile_gcc.
4589 (_initialize_compile): Install "set compile-gcc". Initialize
4594 * compile/compile.c (compile_to_object): Conditionally call
4595 set_verbose. Conditionally call compile or compile_v0.
4599 * sparc64-tdep.h: (adi_normalize_address): New export.
4600 * sparc-nat.h: (open_adi_tag_fd): New export.
4601 * sparc64-linux-nat.c: (open_adi_tag_fd): New function.
4602 * sparc64-linux-tdep.c:
4603 (SEGV_ACCADI, SEGV_ADIDERR, SEGV_ADIPERR) New defines.
4604 (sparc64_linux_handle_segmentation_fault): New function.
4605 (sparc64_linux_init_abi): Register
4606 sparc64_linux_handle_segmentation_fault
4607 * sparc64-tdep.c: Include cli-utils.h,gdbcmd.h,auxv.h.
4608 (sparc64_addr_bits_remove): New function.
4609 (sparc64_init_abi): Register sparc64_addr_bits_remove.
4610 (MAX_PROC_NAME_SIZE): New macro.
4611 (AT_ADI_BLKSZ, AT_ADI_NBITS, AT_ADI_UEONADI) New defines.
4612 (sparc64adilist): New variable.
4613 (adi_proc_list): New variable.
4614 (find_adi_info): New function.
4615 (add_adi_info): New function.
4616 (get_adi_info_proc): New function.
4617 (get_adi_info): New function.
4618 (info_adi_command): New function.
4619 (read_maps_entry): New function.
4620 (adi_available): New function.
4621 (adi_normalize_address): New function.
4622 (adi_align_address): New function.
4623 (adi_convert_byte_count): New function.
4624 (adi_tag_fd): New function.
4625 (adi_is_addr_mapped): New function.
4626 (adi_read_versions): New function.
4627 (adi_write_versions): New function.
4628 (adi_print_versions): New function.
4629 (do_examine): New function.
4630 (do_assign): New function.
4631 (adi_examine_command): New function.
4632 (adi_assign_command): New function.
4633 (_initialize_sparc64_adi_tdep): New function.
4637 * breakpoint.c (breakpoints_info): Rename to ...
4638 (info_breakpoints_command): ... this.
4639 (watchpoints_info): Rename to ...
4640 (info_watchpoints_command): ... this.
4641 (tracepoints_info): Rename to ...
4642 (info_tracepoints_command): ... this.
4643 (_initialize_breakpoint): Adjust.
4644 * dcache.c (dcache_info): Rename to ...
4645 (info_display_command): ... this.
4646 (_initialize_dcache): Adjust.
4647 * frame.h (args_info): Rename to ...
4648 (info_args_command): ... this.
4649 (locals_info): Rename to ...
4650 (info_locals_command): ... this.
4651 * infcmd.c (nofp_registers_info): Rename to ...
4652 (info_registers_command): ... this.
4653 (float_info): Rename to ...
4654 (info_float_command): ... this.
4655 (program_info): Rename to ...
4656 (info_program_command): ... this.
4657 (all_registers_info): Rename to ...
4658 (info_all_registers_command): ... this.
4659 (vector_info): Rename to ...
4660 (info_vector_command): ... this.
4661 (float_info): Rename to ...
4662 (info_float_command): ... this.
4663 (_initialize_infcmd): Adjust.
4664 * inferior.h (term_info): Rename to ...
4665 (info_terminal_command): ... this.
4666 * inflow.c (term_info): Rename to ...
4667 (info_terminal_command): ... this.
4668 (_initialize_inflow): Adjust.
4669 * infrun.c (signals_info): Rename to ...
4670 (info_signals_command): ... this.
4671 (_initialize_infrun): Adjust.
4672 * objc-lang.c (classes_info): Rename to ...
4673 (info_classes_command): ... this.
4674 (selectors_info): Rename to ...
4675 (info_selectors_command): ... this.
4676 (_initialize_objc_language): Adjust.
4677 * printcmd.c (sym_info): Rename to ...
4678 (info_symbol_command): ... this.
4679 (address_info): Rename to ...
4680 (info_address_command): ... this.
4681 (display_info): Rename to ...
4682 (info_display_command): ... this.
4683 (_initialize_printcmd): Adjust.
4684 * reverse.c (bookmarks_info): Rename to ...
4685 (info_breakpoints_command): ... this.
4686 (_initialize_reverse): Adjust.
4687 * ser-go32.c (dos_info): Rename to ...
4688 (info_serial_command): ... this.
4689 (_initialize_ser_dos): Adjust.
4690 * skip.c (skip_info): Rename to ...
4691 (info_skip_command): ... this.
4692 (_initialize_step_skip): Adjust.
4693 * source.c (line_info): Rename to ...
4694 (info_line_command): ... this.
4695 (source_info): Rename to ...
4696 (info_source_command)
4697 * stack.c (frame_info): Rename to ...
4698 (info_frame_command): ... this.
4699 (locals_info): Rename to ...
4700 (info_locals_command): ... this.
4701 (args_info): Rename to ...
4702 (info_args_command): ... this.
4703 (_initialize_stack): Adjust.
4704 * symtab.c (sources_info): Rename to ...
4705 (info_sources_command): ... this.
4706 (variables_info): Rename to ...
4707 (info_variables_command): ... this.
4708 (functions_info): Rename to ...
4709 (info_functions_command): ... this.
4710 (types_info): Rename to ...
4711 (info_types_command): ... this.
4712 (_initialize_symtab): Adjust.
4713 * target.c (target_info): Rename to ...
4714 (info_target_command): ... this.
4715 (initialize_targets): Adjust.
4716 * tracepoint.c (tvariables_info): Rename to ...
4717 (info_tvariables_command): ... this.
4718 (scope_info): Rename to ...
4719 (info_scope_command): ... this.
4720 (trace_dump_actions): Adjust.
4721 (_initialize_tracepoint): Adjust.
4725 * breakpoint.h (install_breakpoint): Update.
4726 * breakpoint.c (add_solib_catchpoint): Update.
4727 (install_breakpoint): Change argument to a std::unique_ptr.
4728 (create_fork_vfork_event_catchpoint): Use std::unique_ptr.
4729 (create_breakpoint_sal, create_breakpoint): Update.
4730 (watch_command_1, catch_exec_command_1)
4731 (strace_marker_create_breakpoints_sal): Use std::unique_ptr.
4732 (add_to_breakpoint_chain): Change argument to a std::unique_ptr.
4733 Return the breakpoint.
4734 (set_raw_breakpoint_without_location, set_raw_breakpoint)
4735 (new_single_step_breakpoint): Update.
4736 * break-catch-throw.c (handle_gnu_v3_exceptions): Use
4738 * break-catch-syscall.c (create_syscall_event_catchpoint): Use
4740 * break-catch-sig.c (create_signal_catchpoint): Use
4742 * ada-lang.c (create_ada_exception_catchpoint): Use
4747 * breakpoint.c (add_solib_catchpoint): Use std::unique_ptr.
4751 * psymtab.c (psymtab_search_name): Return a unique_xmalloc_ptr.
4752 (lookup_partial_symbol): Update.
4756 * source.h (rewrite_source_path): Return a unique_xmalloc_ptr.
4757 * source.c (rewrite_source_path): Return a unique_xmalloc_ptr.
4758 (find_and_open_source, symtab_to_fullname): Update.
4759 * psymtab.c (psymtab_to_fullname): Update.
4763 * exec.c (exec_file_attach): Update.
4764 * linux-thread-db.c (try_thread_db_load): Update.
4765 * guile/scm-safe-call.c (gdbscm_safe_source_script): Update.
4766 * utils.c (gdb_realpath): Change return type.
4767 (gdb_realpath_keepfile): Update.
4768 (gdb_realpath_check_trailer, gdb_realpath_tests): New functions.
4769 (_initialize_utils): Register the new self test.
4770 * source.c (openp): Update.
4771 (find_and_open_source): Update.
4772 * nto-tdep.c (nto_find_and_open_solib): Update.
4773 * main.c (set_gdb_data_directory): Update.
4774 (captured_main_1): Update.
4775 * dwarf2read.c (dwarf2_get_dwz_file): Update
4776 (dw2_map_symbol_filenames): Update.
4777 * auto-load.c (auto_load_safe_path_vec_update): Update.
4778 (filename_is_in_auto_load_safe_path_vec): Change type of
4780 (auto_load_objfile_script): Update.
4781 (file_is_auto_load_safe): Update. Use std::string.
4782 * utils.h (gdb_realpath): Return a gdb::unique_xmalloc_ptr.
4786 * utils.c (gdb_realpath_keepfile): Return a
4787 gdb::unique_xmalloc_ptr.
4788 * exec.c (exec_file_attach): Update.
4789 * utils.h (gdb_realpath_keepfile): Return a
4790 gdb::unique_xmalloc_ptr.
4794 * compile/compile.c (compile_file_command): Use
4795 gdb::unique_xmalloc_ptr, std::string.
4796 * utils.c (gdb_abspath): Change return type.
4797 * source.c (openp): Update.
4798 * objfiles.c (allocate_objfile): Update.
4799 * main.c (set_gdb_data_directory): Update.
4800 * utils.h (gdb_abspath): Return a gdb::unique_xmalloc_ptr.
4804 * cli-cmds.c (list_commands): List actual code around more than
4809 * fbsd-nat.c (fbsd_add_threads): Use array type for `lwps'.
4814 * c-exp.y (variable production): Handle function aliases.
4815 * minsyms.c (msymbol_is_text): New function.
4816 * minsyms.h (msymbol_is_text): Declare.
4817 * symtab.c (find_function_alias_target): New function.
4818 * symtab.h (find_function_alias_target): Declare.
4822 * eval.c (evaluate_subexp_standard) <OP_TYPE>: Don't dig past
4824 * typeprint.c (whatis_exp): If handling "whatis", and expression
4825 is OP_TYPE, strip one typedef level. Otherwise don't strip
4827 * valops.c (value_cast): Save "to" type before resolving
4828 stubs/typedefs. Use that type as resulting value's type.
4833 * spu-multiarch.c (parse_spufs_run): Use scoped_restore.
4834 * sol-thread.c (sol_thread_resume, sol_thread_wait)
4835 (sol_thread_xfer_partial, rw_common): Use scoped_restore.
4836 * procfs.c (procfs_do_thread_registers): Use scoped_restore.
4837 * proc-service.c (ps_xfer_memory): Use scoped_restore.
4838 * linux-tdep.c (linux_corefile_thread): Remove a cleanup.
4839 (linux_get_siginfo_data): Add "thread" argument. Use
4841 * linux-nat.c (linux_child_follow_fork)
4842 (check_stopped_by_watchpoint): Use scoped_restore.
4843 * infrun.c (displaced_step_prepare_throw, write_memory_ptid)
4844 (THREAD_STOPPED_BY, handle_signal_stop): Use scoped_restore.
4845 (restore_inferior_ptid, save_inferior_ptid): Remove.
4846 * btrace.c (btrace_fetch): Use scoped_restore.
4847 * bsd-uthread.c (bsd_uthread_fetch_registers)
4848 (bsd_uthread_store_registers): Use scoped_restore.
4849 * breakpoint.c (reattach_breakpoints, detach_breakpoints): Use
4851 * aix-thread.c (aix_thread_resume, aix_thread_wait)
4852 (aix_thread_xfer_partial): Use scoped_restore.
4853 * inferior.h (save_inferior_ptid): Remove.
4858 * arm-tdep.c (gdb_print_insn_arm): Mark
4859 USER_SPECIFIED_MACHINE_TYPE if exec_bfd isn't NULL.
4863 * NEWS: Mention GDBserver's new option "--selftest".
4864 * Makefile.in (SFILES): Remove selftest.c, add common/selftest.c.
4865 * selftest.c: Move it to common/selftest.c.
4866 * selftest.h: Move it to common/selftest.h.
4867 * selftest-arch.c (reset): New function.
4868 (tests_with_arch): Call reset.
4872 * selftest.c (run_tests): Don't call QUIT. Call debug_printf
4873 instead of exception_fprintf and printf_filtered.
4877 * selftest.c (register_self_test): Rename it to
4878 selftests::register_test.
4879 (run_self_tests): selftest::run_tests.
4880 * selftest.h: Update declarations.
4881 * selftest-arch.c (register_self_test_foreach_arch): Rename it to
4882 selftests::register_test_foreach_arch.
4883 * selftest-arch.h: Update declaration.
4884 * aarch64-tdep.c: Update.
4885 * arm-tdep.c: Likewise.
4886 * disasm-selftests.c: Likewise.
4887 * dwarf2loc.c: Likewise.
4888 * dwarf2-frame.c: Likewise.
4889 * findvar.c: Likewise.
4890 * gdbarch-selftests.c: Likewise.
4891 * maint.c (maintenance_selftest): Likewise.
4892 * regcache.c: Likewise.
4893 * rust-exp.y: Likewise.
4894 * selftest-arch.c: Likewise.
4895 * unittests/environ-selftests.c: Likewise.
4896 * unittests/function-view-selftests.c: Likewise.
4897 * unittests/offset-type-selftests.c: Likewise.
4898 * unittests/optional-selftests.c: Likewise.
4899 * unittests/scoped_restore-selftests.c: Likewise.
4900 * utils-selftests.c: Likewise.
4904 * cli/cli-cmds.c (source_command): Delete 'old_source_verbose'
4909 * dwarf2read.c (struct dwarf2_cu) <line_header_die_owner>: New
4911 (reset_die_in_process): Delete, replaced by ...
4912 (process_die_scope): ... this new class. Make it responsible for
4913 freeing cu->line_header too.
4914 (process_die): Use process_die_scope.
4915 (handle_DW_AT_stmt_list): Record the line header's owner CU/DIE in
4916 cu->line_header_die_owner. Don't release the line header if it's
4918 (setup_type_unit_groups): Make the CU/DIE own the line header.
4919 Don't release the line header here.
4923 * elfread.c (elf_read_minimal_symbols): xfree synthsyms.
4927 * NEWS: Mention new shortcuts for nexti and stepi in TUI
4932 * tui/tui.c (tui_commands): Add "nexti" and "stepi" to the Single-Key
4937 * MAINTAINERS (Write After Approval): Add Stafford Horne.
4941 * xtensa-tdep.c (xtensa_init_reggroups): Use xstrdup for cpname.
4946 * infcmd.c (unset_environment_command): Use the 'clear' method on
4947 the environment instead of resetting it.
4951 * fbsd-nat.c (fbsd_convert_siginfo): Fix compile on big-endian
4956 * valprint.c (print_octal_chars): Use HOST_CHAR_BIT.
4957 (print_binary_chars): Likewise.
4958 (BITS_IN_BYTES): Remove.
4963 * valprint.c (LOW_ZERO): Change value to 034.
4964 (print_octal_chars): Add static_asserts for octal constants.
4965 * printcmd.c (print_scalar_formatted): Add 'd' case.
4969 * symfile.c (add_symbol_file_command): Use std::vector.
4973 * break-catch-throw.c (handle_gnu_v3_exceptions): Use std::move.
4974 * break-catch-syscall.c (create_syscall_event_catchpoint): Use
4976 * break-catch-sig.c (create_signal_catchpoint): Use std::move.
4980 * infrun.c (process_event_stop_test): Adjust
4981 function_name_is_marked_for_skip call.
4982 * skip.c: Include <list>.
4983 (skiplist_entry): Make it a class with private fields, and
4985 (skiplist_entry_chain): Delete.
4986 (skiplist_entries): New.
4987 (skiplist_entry_count): Delete.
4988 (highest_skiplist_entry_num): New.
4989 (ALL_SKIPLIST_ENTRIES, ALL_SKIPLIST_ENTRIES_SAFE): Delete.
4990 (add_skiplist_entry): Delete.
4991 (skiplist_entry::skiplist_entry): New.
4992 (skiplist_entry::add_entry): New.
4993 (skip_file_command, skip_function): Adjust.
4994 (compile_skip_regexp): Delete.
4995 (skip_command): Don't compile regexp here. Adjust to use
4996 skiplist_entry::add_entry.
4997 (skip_info): Adjust to use range-for and getters.
4998 (skip_enable_command, skip_disable_command): Adjust to use
4999 range-for and setters.
5000 (skip_delete_command): Adjust to use std::list.
5001 (add_skiplist_entry): Delete.
5002 (skip_file_p): Delete, refactored as ...
5003 (skiplist_entry::do_skip_file_p): ... this new method.
5004 (skip_gfile_p): Delete, refactored as ...
5005 (skiplist_entry::do_gskip_file_p): ... this new method.
5006 (skip_function_p, skip_rfunction_p): Delete, refactored as ...
5007 (skiplist_entry::skip_function_p): ... this new method.
5008 (function_name_is_marked_for_skip): Now returns bool, and takes
5009 the function sal by const reference. Adjust to use range-for and
5010 skiplist_entry methods.
5011 (_initialize_step_skip): Remove references to
5012 skiplist_entry_chain, skiplist_entry_count.
5013 * skip.h (function_name_is_marked_for_skip): Now returns bool, and
5014 takes the function sal by const reference.
5018 * dwarf2-frame.c (clear_pointer_cleanup): Remove.
5019 (dwarf2_frame_cache): Remove reset_cache_cleanup.
5020 (dwarf2_frame_cache):
5021 * frame-unwind.c (frame_unwind_try_unwinder): Catch
5022 RETURN_MASK_ALL and set *this_case to NULL.
5023 * frame-unwind.h: Update comments.
5027 * dwarf2-frame.c (dwarf2_frame_state_alloc_regs): Remove.
5028 (dwarf2_frame_state_copy_regs): Remove.
5029 (dwarf2_frame_state_free_regs): Remove.
5030 (dwarf2_frame_state::~dwarf2_frame_state): Remove.
5031 (dwarf2_restore_rule): Call method .alloc_regs instead of
5032 dwarf2_frame_state_alloc_regs.
5033 (execute_cfa_program): Likewise. Call dwarf2_frame_state_reg_info
5034 constructor. Call std::move.
5035 (dwarf2_fetch_cfa_info): Don't call dwarf2_frame_state_copy_regs.
5036 (dwarf2_frame_cache): Likewise.
5038 [GDB_SELF_TEST]: Include selftest.h and
5040 [GDB_SELF_TEST] (execute_cfa_program_test): New function.
5041 (_initialize_dwarf2_frame) [GDB_SELF_TEST]: Register
5042 execute_cfa_program_test.
5044 * dwarf2-frame.h (dwarf2_frame_state_reg_info): Add ctor, dtor,
5045 copy ctor, assignment operator, move assignment.
5046 <alloc_regs>: New method.
5048 (struct dwarf2_frame_state): Delete dtor.
5049 (dwarf2_frame_state_alloc_regs): Remove declaration.
5050 * sparc-tdep.c (sparc_execute_dwarf_cfa_vendor_op): Don't call
5051 dwarf2_frame_state_alloc_regs, use .alloc_regs instead.
5055 * dwarf2-frame.c (dwarf2_frame_state_free): Remove.
5056 (dwarf2_frame_state::dwarf2_frame_state): New.
5057 (dwarf2_frame_state::~dwarf2_frame_state): New.
5058 (dwarf2_fetch_cfa_info): Update.
5059 (dwarf2_frame_cache): Remove old_chain. Change 'fs' to an object
5060 rather than a pointer. Update code.
5061 * dwarf2-frame.h (struct dwarf2_frame_state): Declare ctor and
5063 <data_align, code_align, retaddr_column>: Change them to const.
5064 <armcc_cfa_offsets_sf, armcc_cfa_offsets_reversed>: Change them
5069 * dwarf2-frame.h (struct dwarf2_frame_state_reg) <exp_len>: Remove.
5070 <loc.exp>: New field.
5071 * dwarf2-frame.c (execute_cfa_program): Update.
5072 (dwarf2_frame_prev_register): Update.
5076 * common/gdb_unique_ptr.h (xfree_deleter<T[]>): Define.
5080 * fbsd-nat.c (struct fbsd_fork_info): Remove.
5081 (fbsd_pending_children): Use std::list.
5082 (fbsd_remember_child): Likewise.
5083 (fbsd_is_child_pending): Likewise.
5084 (fbsd_pending_vfork_done): Use std::forward_list.
5085 (fbsd_add_vfork_done): Likewise.
5086 (fbsd_is_vfork_done_pending): Likewise.
5087 (fbsd_next_vfork_done): Likewise.
5091 * fbsd-nat.c [HAVE_KINFO_GETVMMAP] (struct free_deleter): New.
5092 (fbsd_find_memory_regions): Use free_deleter with std::unique_ptr.
5093 [!HAVE_KINFO_GETVMMAP] (fbsd_find_memory_regions): Use std::string
5095 (fbsd_xfer_partial): Use gdb::byte_vector.
5096 (fbsd_add_threads): Use gdb::unique_xmalloc_ptr.
5100 * fbsd-nat.c: [!HAVE_KINFO_GETVMMAP]: Include <sys/user.h> and
5102 (fbsd_find_memory_regions): Fix `mapfile' initialization.
5106 * skip.c (skiplist_entry): New constructor.
5107 (skiplist_entry::enabled, skiplist_entry::function_is_regexp)
5108 (skiplist_entry::file_is_glob): Now bool.
5109 (skiplist_entry::file, skiplist_entry::function): Now
5111 (make_skip_entry): Return a unique_ptr. Use new.
5112 (free_skiplist_entry, free_skiplist_entry_cleanup)
5113 (make_free_skiplist_entry_cleanup): Remove.
5114 (skip_command, skip_disable_command, add_skiplist_entry)
5115 (skip_form_bytes, compile_skip_regexp, skip_command, skip_info)
5116 (skip_file_p, skip_gfile_p, skip_function_p, skip_rfunction_p)
5117 (function_name_is_marked_for_skip): Update.
5118 (skip_delete_command): Update. Use delete.
5122 * aarch64-linux-tdep.c: Include "auxv.h" and "elf/common.h".
5123 (aarch64_linux_core_read_description): New function.
5124 (aarch64_linux_init_abi): Register gdbarch_core_read_description.
5128 * cp-name-parser.y (cp_comp_to_string): Return a
5129 gdb::unique_xmalloc_ptr<char>.
5130 * cp-support.c (replace_typedefs_qualified_name)
5131 (replace_typedefs): Adjust to use gdb::unique_xmalloc_ptr<char>.
5132 (cp_canonicalize_string_full): Use op= instead of explicit
5134 (cp_class_name_from_physname, method_name_from_physname)
5135 (cp_func_name, cp_remove_params): Adjust to use
5136 gdb::unique_xmalloc_ptr<char>.
5137 * cp-support.h (cp_comp_to_string): Return a
5138 gdb::unique_xmalloc_ptr<char>.
5139 * python/py-type.c (typy_lookup_type): Adjust to use
5140 gdb::unique_xmalloc_ptr<char>.
5144 * dwarf2read.c (dwarf2_string_attr): Fix a typo.
5149 * cp-support.c (cp_canonicalize_string_full): Use
5150 gdb::unique_xmalloc_ptr<char>.
5151 (cp_canonicalize_string): Likewise.
5155 * features/Makefile (WHICH): Remove i386/ non-linux stuff.
5156 * regformats/i386/amd64-avx-avx512.dat: Remove.
5157 * regformats/i386/amd64-avx-mpx-avx512-pku.dat: Remove.
5158 * regformats/i386/amd64-avx-mpx.dat:Remove.
5159 * regformats/i386/amd64-avx.dat: Remove.
5160 * regformats/i386/amd64-mpx.dat: Remove.
5161 * regformats/i386/i386-avx-avx512.dat: Remove.
5162 * regformats/i386/i386-avx-mpx-avx512-pku.dat: Remove.
5163 * regformats/i386/i386-avx-mpx.dat: Remove.
5164 * regformats/i386/i386-mmx.dat: Remove.
5165 * regformats/i386/i386-mpx.dat: Remove.
5169 * amd64-tdep.h (tdesc_x32): Remove the declaration.
5170 * amd64-tdep.c: Don't include features/i386/x32*.c.
5171 (_initialize_amd64_tdep): Don't call initialize_tdesc_x32*
5173 * features/Makefile (WHICH): Remove i386/x32, i386/x32-avx,
5174 and i386/x32-avx-avx512.
5175 (XMLTOC): Remove i386/x32-avx.xml, i386/x32-avx-avx512.xml,
5177 * features/i386/x32-avx-avx512.c: Removed.
5178 * features/i386/x32-avx-avx512.xml: Removed.
5179 * features/i386/x32-avx.c: Removed.
5180 * features/i386/x32-avx.xml: Removed.
5181 * features/i386/x32.c: Removed.
5182 * features/i386/x32.xml: Removed.
5183 * regformats/i386/x32-avx-avx512.dat: Removed.
5184 * regformats/i386/x32-avx.dat: Removed.
5185 * regformats/i386/x32.dat: Removed.
5189 PR breakpoints/21886
5190 * mem-break.c (default_memory_insert_breakpoint): Use
5191 `->placed_address' rather than `->reqstd_address' for the
5192 breakpoint location.
5196 * arch-utils.c (default_print_insn): Remove arch/mach/endian
5201 * gdbarch.sh (gdbarch_info): Replace the `tdep_info' member with
5202 a union of `tdep_info', `tdesc_data' and `id'.
5203 * aarch64-tdep.c (aarch64_gdbarch_init): Use `info.tdesc_data'
5204 rather than `info.tdep_info'.
5205 * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise.
5206 * i386-linux-tdep.c (i386_linux_init_abi): Likewise.
5207 * i386-tdep.c (i386_gdbarch_init): Likewise.
5208 * mips-linux-tdep.c (mips_linux_init_abi): Likewise.
5209 * mips-tdep.c (mips_gdbarch_init): Likewise.
5210 * nds32-tdep.c (nds32_gdbarch_init): Likewise.
5211 * rs6000-tdep.c (rs6000_gdbarch_init): Likewise.
5212 * ppc-linux-tdep.c (ppu2spu_sniffer): Use `info.id' rather than
5214 (ppc_linux_init_abi): Use `info.tdesc_data' rather than
5216 * sparc-tdep.c (sparc32_gdbarch_init): Likewise.
5217 * spu-multiarch.c (spu_gdbarch): Use `info.id' rather than
5219 * spu-tdep.c (spu_gdbarch_init): Likewise.
5220 * gdbarch.h: Regenerate.
5225 * dwarf2read.c (dwarf2_string_attr): Allow DW_FORM_GNU_strp_alt.
5229 * remote-sim.c (gdbsim_load): Remove char **argv local variable.
5230 (gdbsim_open): Rename gdb_argv args object to argv.
5234 * compile/compile-object-load.c (compile_object_load): Use
5235 gdb::unique_xmalloc_ptr.
5236 * cli/cli-dump.c (scan_filename): Rename from
5237 scan_filename_with_cleanup. Change return type.
5238 (scan_expression): Rename from scan_expression_with_cleanup.
5240 (dump_memory_to_file, dump_value_to_file, restore_command):
5241 Use gdb::unique_xmalloc_ptr. Update.
5242 * cli/cli-cmds.c (find_and_open_script): Use
5243 gdb::unique_xmalloc_ptr.
5244 * tracefile-tfile.c (tfile_open): Use gdb::unique_xmalloc_ptr.
5245 * symmisc.c (maintenance_print_symbols)
5246 (maintenance_print_msymbols): Use gdb::unique_xmalloc_ptr.
5247 * symfile.c (symfile_bfd_open, generic_load)
5248 (add_symbol_file_command, remove_symbol_file_command): Use
5249 gdb::unique_xmalloc_ptr.
5250 * source.c (openp): Use gdb::unique_xmalloc_ptr.
5251 * psymtab.c (maintenance_print_psymbols): Use
5252 gdb::unique_xmalloc_ptr.
5253 * corelow.c (core_open): Use gdb::unique_xmalloc_ptr.
5254 * breakpoint.c (save_breakpoints): Use gdb::unique_xmalloc_ptr.
5255 * solib.c (solib_map_sections): Use gdb::unique_xmalloc_ptr.
5256 (reload_shared_libraries_1): Likewise.
5260 * rust-exp.y (rust_op_ptr, set_field): Remove typedefs.
5261 (rust_op_vector, rust_set_vector): New typedefs.
5262 (current_parser): New global.
5263 (work_obstack): Change to pointer type. Update all users.
5264 (rust_ast, pstate): Remove globals.
5265 (struct rust_parser): New.
5266 (%union) <params, field_inits>: Change type.
5267 (start, tuple_expr, unit_expr, struct_expr_list, literal)
5268 (field_expr, expr_list, maybe_expr_list, type_list): Update.
5269 (ast_call_ish, ast_path, ast_function_type, ast_tuple_type)
5270 (convert_params_to_types, convert_params_to_expression): Change
5272 (ast_string): Change type of "fields".
5273 (rust_parse): Make a rust_parser. Remove cleanups.
5274 (rust_lex_tests): Make and install an auto_obstack.
5278 * configure.srv (ipa_x32_linux_regobj): New.
5279 * linux-amd64-ipa.c (get_ipa_tdesc): Use X86_TDESC_AVX_AVX512
5280 instead of X86_TDESC_AVX512.
5281 (initialize_low_tracepoint): Call
5282 init_registers_x32_avx_avx512_linux.
5286 * utils.h (gdb_argv): Add namespace std for nullptr_t.
5290 * MAINTAINERS (Write After Approval): Add Ruslan Kabatsayev.
5294 * utils.c (make_cleanup_freeargv, do_freeargv, gdb_buildargv):
5296 * utils.h (make_cleanup_freeargv, gdb_buildargv): Remove.
5300 * python/py-param.c (compute_enum_values): Use gdb_argv.
5304 * utils.h (struct gdb_argv_deleter): New.
5305 (gdb_argv): New class.
5306 * utils.c (gdb_argv::reset): New method.
5307 * tracepoint.c (delete_trace_variable_command): Use gdb_argv.
5308 * tracefile.c (tsave_command): Use gdb_argv.
5309 * top.c (new_ui_command): Use gdb_argv.
5310 * symmisc.c (maintenance_print_symbols)
5311 (maintenance_print_msymbols, maintenance_expand_symtabs): Use gdb_argv.
5312 * symfile.c (symbol_file_command, generic_load)
5313 (remove_symbol_file_command): Use gdb_argv.
5314 * stack.c (backtrace_command): Use gdb_argv.
5315 * source.c (add_path, show_substitute_path_command)
5316 (unset_substitute_path_command, set_substitute_path_command):
5318 * skip.c (skip_command): Use gdb_argv. Use gdb_buildargv.
5319 * ser-mingw.c (pipe_windows_open): Use gdb_argv.
5320 * remote.c (extended_remote_run, remote_put_command)
5321 (remote_get_command, remote_delete_command): Use gdb_argv.
5322 * remote-sim.c (gdbsim_load, gdbsim_create_inferior)
5323 (gdbsim_open): Use gdb_argv.
5324 * python/py-cmd.c (gdbpy_string_to_argv): Use gdb_argv.
5325 * psymtab.c (maintenance_print_psymbols): Use gdb_argv.
5326 * procfs.c (procfs_info_proc): Use gdb_argv.
5327 * interps.c (interpreter_exec_cmd): Use gdb_argv.
5328 * infrun.c (handle_command): Use gdb_argv.
5329 * inferior.c (add_inferior_command, clone_inferior_command):
5331 * guile/scm-string.c (gdbscm_string_to_argv): Use gdb_argv.
5332 * exec.c (exec_file_command): Use gdb_argv.
5333 * cli/cli-cmds.c (alias_command): Use gdb_argv.
5334 * compile/compile.c (build_argc_argv): Use gdb_argv.
5338 * python/python.c (gdbpy_decode_line): Use unique_xmalloc_ptr.
5342 * python/python.c (compute_python_string): Return std::string.
5343 (gdbpy_eval_from_control_command): Update.
5344 (do_start_initialization): Use std::string.
5345 * python/py-varobj.c (py_varobj_iter_next): Use string_printf, not
5347 * python/py-breakpoint.c (local_setattro): Use string_printf, not
5352 * top.h (do_restore_instream_cleanup): Remove.
5353 * top.c (do_restore_instream_cleanup): Remove.
5354 (read_command_file): Use scoped_restore.
5355 * cli/cli-script.c (execute_user_command): Use scoped_restore.
5359 * cli/cli-script.c (execute_user_command)
5360 (execute_control_command): Use scoped_restore.
5364 * cli/cli-script.c (do_restore_user_call_depth): Remove.
5365 (execute_user_command): Remove user_call_depth; use
5366 user_args_stack's size instead.
5370 * top.h (in_user_command): Remove.
5371 * top.c (in_user_command): Remove.
5372 * cli/cli-script.c (do_restore_user_call_depth)
5373 (execute_user_command): Update.
5377 * valops.c (search_struct_method): Use gdb::byte_vector.
5378 * valarith.c (value_concat): Use std::vector.
5379 * target.c (memory_xfer_partial): Use gdb::byte_vector.
5380 (simple_search_memory): Likewise.
5381 * printcmd.c (find_string_backward): Use gdb::byte_vector.
5382 * mi/mi-main.c (mi_cmd_data_write_memory): Use gdb::byte_vector.
5383 * gcore.c (gcore_copy_callback): Use gdb::byte_vector.
5384 * elfread.c (elf_rel_plt_read): Use std::string.
5385 * cp-valprint.c (cp_print_value): Use gdb::byte_vector.
5386 * cli/cli-dump.c (restore_section_callback): Use
5391 * jit.c (jit_reader_load_command): Use unique_xmalloc_ptr.
5395 * tui/tui-regs.c (tui_restore_gdbout): Remove.
5396 (tui_register_format): Use scoped_restore.
5400 * reverse.c (exec_direction_default): Remove.
5401 (exec_reverse_once): Use scoped_restore.
5402 * remote.c (restore_remote_timeout): Remove.
5403 (remote_flash_erase, remote_flash_write, remote_flash_done)
5404 (readchar, remote_serial_write): Use scoped_restore.
5405 * cli/cli-script.c (struct source_cleanup_lines_args)
5406 (source_cleanup_lines): Remove.
5407 (script_from_file): Use scoped_restore.
5408 * cli/cli-cmds.c (source_verbose_cleanup): Remove.
5409 (source_command): Use scoped_restore.
5413 * utils.h (make_cleanup_free_so): Remove.
5414 * utils.c (do_free_so, make_cleanup_free_so): Remove.
5415 * solist.h (struct so_deleter): New.
5416 (so_list_up): New typedef.
5417 * solib-svr4.c (svr4_read_so_list): Use so_list_up.
5421 * utils.h (make_cleanup_restore_current_language): Remove.
5422 * utils.c (do_restore_current_language)
5423 (make_cleanup_restore_current_language): Remove.
5424 * parse.c (parse_exp_in_context_1)
5425 (parse_expression_with_language): Use
5426 scoped_restore_current_language.
5427 * mi/mi-main.c (mi_cmd_execute): Use
5428 scoped_restore_current_language.
5429 * language.h (scoped_restore_current_language): New class.
5433 * compile/compile.c (cleanup_unlink_file): Remove.
5434 (compile_to_object): Use gdb::unlinker.
5435 (eval_compile_command): Likewise.
5439 * utils.h (make_cleanup_fclose): Remove.
5440 * utils.c (do_fclose_cleanup, make_cleanup_fclose): Remove.
5444 * top.c (open_terminal_stream): Return gdb_file_up.
5445 (new_ui_command): Update.
5449 * source.c (print_source_lines_base, forward_search_command)
5450 (reverse_search_command): Use gdb_file_up.
5454 * fbsd-nat.c (fbsd_find_memory_regions): Update.
5458 * cli/cli-cmds.c (find_and_open_script): Change return type.
5459 Remove "streamp" and "full_path" parameters.
5460 (source_script_with_search): Update.
5461 * auto-load.c (source_script_file): Update.
5462 * cli/cli-cmds.h (find_and_open_script): Change type.
5463 (open_script): New struct.
5467 * xml-support.c (xml_fetch_content_from_file): Update.
5468 * ui-file.c (stdio_file::open): Update.
5469 * tracefile-tfile.c (tfile_start): Update.
5470 * remote.c (remote_file_put, remote_file_get): Update.
5471 * nat/linux-procfs.c (linux_proc_get_int)
5472 (linux_proc_pid_get_state, linux_proc_tid_get_name): Update.
5473 * nat/linux-osdata.c (linux_common_core_of_thread): Update.
5474 (command_from_pid, commandline_from_pid, linux_xfer_osdata_cpus)
5475 (print_sockets, linux_xfer_osdata_shm, linux_xfer_osdata_sem)
5476 (linux_xfer_osdata_msg, linux_xfer_osdata_modules): Update.
5477 * nat/linux-btrace.c (linux_determine_kernel_start): Update.
5478 * linux-nat.c (linux_proc_pending_signals): Update.
5479 * dwarf2read.c (write_psymtabs_to_index): Use gdb_file_up.
5480 (file_closer): Remove.
5481 * compile/compile.c (compile_to_object): Update.
5482 * common/filestuff.h (struct gdb_file_deleter): New.
5483 (gdb_file_up): New typedef.
5484 (gdb_fopen_cloexec): Change return type.
5485 * common/filestuff.c (gdb_fopen_cloexec): Return gdb_file_up.
5486 * cli/cli-dump.c (fopen_with_cleanup): Remove.
5487 (dump_binary_file, restore_binary_file): Update.
5488 * auto-load.c (auto_load_objfile_script_1): Update.
5492 * tracepoint.c (tvariables_info_1): Use ui_out_emit_table.
5493 (info_static_tracepoint_markers_command): Likewise.
5494 * solib.c (info_sharedlibrary_command): Use ui_out_emit_table.
5495 * skip.c (skip_info): Use ui_out_emit_table.
5496 * progspace.c (print_program_space): Use ui_out_emit_table.
5497 * osdata.c (info_osdata): Use ui_out_emit_table.
5498 * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions): Use
5500 * linux-thread-db.c (info_auto_load_libthread_db): Use
5502 * inferior.c (print_inferior): Use ui_out_emit_table.
5503 * gdb_bfd.c (maintenance_info_bfds): Use ui_out_emit_table.
5504 * breakpoint.c (breakpoint_1): Use ui_out_emit_table.
5505 * auto-load.c (auto_load_info_scripts): Use ui_out_emit_table.
5506 * ada-tasks.c (print_ada_task_info): Use ui_out_emit_table.
5507 * ui-out.h (class ui_out_emit_table): New.
5511 * mips-tdep.c (mips_fpu_type_str): New function.
5512 (mips_dump_tdep): Call it.
5516 * mips-tdep.c (mips_gdbarch_init): Use MIPS_FPU_TYPE to access
5521 * solib-darwin.c (DYLD_VERSION_MAX): Increase value.
5525 * MAINTAINERS (Write After Approval): Add Xavier Roirand.
5529 * cli/cli-cmds.c (maintenancechecklist): New variable.
5530 * gdbcmd.h (maintenancechecklist): Declare it.
5531 * i386-linux-tdep.c (_initialize_i386_linux_tdep) [GDB_SELF_TEST]:
5532 Call i386_linux_read_description with different masks.
5533 * maint.c (maintenance_check_command): New function.
5534 (_initialize_maint_cmds): Call add_prefix_cmd.
5535 * target-descriptions.c (tdesc_reg): override operator != and ==.
5536 (tdesc_type): Likewise.
5537 (tdesc_feature): Likewise.
5538 (target_desc): Likewise.
5539 [GDB_SELF_TEST] (selftests::record_xml_tdesc): New function.
5540 (maintenance_check_xml_descriptions): New function.
5541 (_initialize_target_descriptions) Add command "xml-descriptions".
5542 * target-descriptions.h (selftests::record_xml_tdesc): Declare.
5546 * i386-linux-tdep.c: Don't include features/i386/i386-*linux.c.
5547 Include features/i386/32bit-*.c.
5548 (i386_linux_read_description): Generate target description if it
5550 (_initialize_i386_linux_tdep): Don't call _initialize_tdesc_i386
5552 * features/i386/32bit-linux.c: Re-generated.
5553 * features/i386/32bit-sse.c: Likewise.
5554 * target-descriptions.c (print_c_feature::visit): Print code to
5555 set register number if needed.
5556 (print_c_feature) <m_next_regnum>: New field.
5560 * features/Makefile (CFILES): Rename with TDESC_CFILES.
5561 (FEATURE_XMLFILES): New.
5562 (FEATURE_CFILES): New.
5564 (clean-cfiles): Remove generated c files.
5565 * features/i386/32bit-avx.c: Generated.
5566 * features/i386/32bit-avx512.c: Generated.
5567 * features/i386/32bit-core.c: Generated.
5568 * features/i386/32bit-linux.c: Generated.
5569 * features/i386/32bit-mpx.c: Generated.
5570 * features/i386/32bit-pkeys.c: Generated.
5571 * features/i386/32bit-sse.c: Generated.
5572 * target-descriptions.c: Include algorithm.
5573 (tdesc_element_visitor): Add method visit_end.
5574 (print_c_tdesc): Implement visit_end.
5575 (print_c_tdesc:: m_filename_after_features): Move it to
5577 (print_c_feature): New class.
5578 (maint_print_c_tdesc_cmd): Use print_c_feature if XML file
5579 name starts with "i386/32bit-".
5583 * target-descriptions.c (tdesc_element_visitor): New class.
5584 (tdesc_element): New class.
5585 (tdesc_reg): Inherit from tdesc_element.
5586 (tdesc_reg::accept): New function.
5587 (tdesc_type): Inherit from tdesc_element.
5588 (tdesc_type::accept): New function.
5589 (tdesc_feature): Inherit from tdesc_element.
5590 (tdesc_feature::accept): New function.
5591 (target_desc): Inherit from tdesc_element.
5592 (target_desc::target_desc): New.
5593 (target_desc::~target_desc): New.
5594 (target_desc::accept): New.
5595 (allocate_target_description): Use new.
5596 (free_target_description): Use delete.
5597 (print_c_tdesc): New class.
5598 (maint_print_c_tdesc_cmd): Adjust.
5600 * features/aarch64.c: Re-generated.
5601 * features/arc-arcompact.c: Re-generated.
5602 * features/arc-v2.c: Re-generated.
5603 * features/arm/arm-with-iwmmxt.c: Re-generated.
5604 * features/arm/arm-with-m.c: Re-generated.
5605 * features/arm/arm-with-m-fpa-layout.c: Re-generated.
5606 * features/arm/arm-with-m-vfp-d16.c: Re-generated.
5607 * features/arm/arm-with-neon.c: Re-generated.
5608 * features/arm/arm-with-vfpv2.c: Re-generated.
5609 * features/arm/arm-with-vfpv3.c: Re-generated.
5610 * features/i386/amd64-avx-avx512.c: Re-generated.
5611 * features/i386/amd64-avx-avx512-linux.c: Re-generated.
5612 * features/i386/amd64-avx.c: Re-generated.
5613 * features/i386/amd64-avx-linux.c: Re-generated.
5614 * features/i386/amd64-avx-mpx-avx512-pku.c: Re-generated.
5615 * features/i386/amd64-avx-mpx-avx512-pku-linux.c: Re-generated.
5616 * features/i386/amd64-avx-mpx.c: Re-generated.
5617 * features/i386/amd64-avx-mpx-linux.c: Re-generated.
5618 * features/i386/amd64.c: Re-generated.
5619 * features/i386/amd64-linux.c: Re-generated.
5620 * features/i386/amd64-mpx.c: Re-generated.
5621 * features/i386/amd64-mpx-linux.c: Re-generated.
5622 * features/i386/i386-avx-avx512.c: Re-generated.
5623 * features/i386/i386-avx-avx512-linux.c: Re-generated.
5624 * features/i386/i386-avx.c: Re-generated.
5625 * features/i386/i386-avx-linux.c: Re-generated.
5626 * features/i386/i386-avx-mpx-avx512-pku.c: Re-generated.
5627 * features/i386/i386-avx-mpx-avx512-pku-linux.c: Re-generated.
5628 * features/i386/i386-avx-mpx.c: Re-generated.
5629 * features/i386/i386-avx-mpx-linux.c: Re-generated.
5630 * features/i386/i386.c: Re-generated.
5631 * features/i386/i386-linux.c: Re-generated.
5632 * features/i386/i386-mmx.c: Re-generated.
5633 * features/i386/i386-mmx-linux.c: Re-generated.
5634 * features/i386/i386-mpx.c: Re-generated.
5635 * features/i386/i386-mpx-linux.c: Re-generated.
5636 * features/i386/x32-avx-avx512.c: Re-generated.
5637 * features/i386/x32-avx-avx512-linux.c: Re-generated.
5638 * features/i386/x32-avx.c: Re-generated.
5639 * features/i386/x32-avx-linux.c: Re-generated.
5640 * features/i386/x32.c: Re-generated.
5641 * features/i386/x32-linux.c: Re-generated.
5642 * features/microblaze.c: Re-generated.
5643 * features/microblaze-with-stack-protect.c: Re-generated.
5644 * features/mips64-dsp-linux.c: Re-generated.
5645 * features/mips64-linux.c: Re-generated.
5646 * features/mips-dsp-linux.c: Re-generated.
5647 * features/mips-linux.c: Re-generated.
5648 * features/nds32.c: Re-generated.
5649 * features/nios2.c: Re-generated.
5650 * features/nios2-linux.c: Re-generated.
5651 * features/rs6000/powerpc-32.c: Re-generated.
5652 * features/rs6000/powerpc-32l.c: Re-generated.
5653 * features/rs6000/powerpc-403.c: Re-generated.
5654 * features/rs6000/powerpc-403gc.c : Re-generated.
5655 * features/rs6000/powerpc-405.c: Re-generated.
5656 * features/rs6000/powerpc-505.c: Re-generated.
5657 * features/rs6000/powerpc-601.c: Re-generated.
5658 * features/rs6000/powerpc-602.c: Re-generated.
5659 * features/rs6000/powerpc-603.c: Re-generated.
5660 * features/rs6000/powerpc-604.c: Re-generated.
5661 * features/rs6000/powerpc-64.c: Re-generated.
5662 * features/rs6000/powerpc-64l.c: Re-generated.
5663 * features/rs6000/powerpc-7400.c: Re-generated.
5664 * features/rs6000/powerpc-750.c: Re-generated.
5665 * features/rs6000/powerpc-860.c: Re-generated.
5666 * features/rs6000/powerpc-altivec32.c: Re-generated.
5667 * features/rs6000/powerpc-altivec32l.c: Re-generated.
5668 * features/rs6000/powerpc-altivec64.c: Re-generated.
5669 * features/rs6000/powerpc-altivec64l.c: Re-generated.
5670 * features/rs6000/powerpc-cell32l.c: Re-generated.
5671 * features/rs6000/powerpc-cell64l.c: Re-generated.
5672 * features/rs6000/powerpc-e500.c: Re-generated.
5673 * features/rs6000/powerpc-e500l.c: Re-generated.
5674 * features/rs6000/powerpc-isa205-32l.c: Re-generated.
5675 * features/rs6000/powerpc-isa205-64l.c: Re-generated.
5676 * features/rs6000/powerpc-isa205-altivec32l.c: Re-generated.
5677 * features/rs6000/powerpc-isa205-altivec64l.c: Re-generated.
5678 * features/rs6000/powerpc-isa205-vsx32l.c: Re-generated.
5679 * features/rs6000/powerpc-isa205-vsx64l.c: Re-generated.
5680 * features/rs6000/powerpc-vsx32.c: Re-generated.
5681 * features/rs6000/powerpc-vsx32l.c: Re-generated.
5682 * features/rs6000/powerpc-vsx64.c: Re-generated.
5683 * features/rs6000/powerpc-vsx64l.c: Re-generated.
5684 * features/rs6000/rs6000.c: Re-generated.
5685 * features/s390-linux32.c: Re-generated.
5686 * features/s390-linux32v1.c: Re-generated.
5687 * features/s390-linux32v2.c: Re-generated.
5688 * features/s390-linux64.c: Re-generated.
5689 * features/s390-linux64v1.c: Re-generated.
5690 * features/s390-linux64v2.c: Re-generated.
5691 * features/s390-te-linux64.c: Re-generated.
5692 * features/s390-tevx-linux64.c: Re-generated.
5693 * features/s390-vx-linux64.c: Re-generated.
5694 * features/s390x-linux64.c: Re-generated.
5695 * features/s390x-linux64v1.c: Re-generated.
5696 * features/s390x-linux64v2.c: Re-generated.
5697 * features/s390x-te-linux64.c: Re-generated.
5698 * features/s390x-tevx-linux64.c: Re-generated.
5699 * features/s390x-vx-linux64.c: Re-generated.
5700 * features/sparc/sparc32-solaris.c: Re-generated.
5701 * features/sparc/sparc64-solaris.c: Re-generated.
5702 * features/tic6x-c62x.c: Re-generated.
5703 * features/tic6x-c62x-linux.c: Re-generated.
5704 * features/tic6x-c64x.c: Re-generated.
5705 * features/tic6x-c64x-linux.c: Re-generated.
5706 * features/tic6x-c64xp.c: Re-generated.
5707 * features/tic6x-c64xp-linux.c: Re-generated.
5711 * i386-linux-tdep.c (i386_linux_read_description): New function.
5712 (i386_linux_core_read_description): Call
5713 i386_linux_read_description.
5714 * i386-linux-tdep.h (i386_linux_read_description): Declare.
5715 (tdesc_i386_linux, tdesc_i386_mmx_linux): Remove declarations.
5716 (tdesc_i386_avx_linux, tdesc_i386_mpx_linux): Likewise
5717 (tdesc_i386_avx_mpx_linux, tdesc_i386_avx_avx512_linux): Likewise.
5718 (tdesc_i386_avx_mpx_avx512_pku_linux): Likewise.
5719 * x86-linux-nat.c (x86_linux_read_description): Call
5720 i386_linux_read_description.
5725 * features/Makefile (%.c: %.xml): Pass the xml file name to
5726 command "maint print c-tdesc".
5727 * target-descriptions.c (maint_print_c_tdesc_cmd): Get file
5732 * target-descriptions.c (target_desc): Add ctor and dtor. Do
5733 in-class initialization.
5734 (tdesc_create_feature): Call new instead of XCNEW.
5735 (free_target_description): Ue delete.
5739 * configure.nat: Add "-lkvm" for NetBSD/sparc64 and fix typo.
5743 * amd64-tdep.c (amd64_init_abi): Make argument default_tdesc
5745 (amd64_x32_init_abi): Likewise.
5746 * amd64-tdep.h (amd64_init_abi): Update declaration.
5747 (amd64_x32_init_abi): Likewise.
5752 * arm-linux-nat.c (arm_linux_fetch_inferior_registers): Update
5753 condition for FPSCR.
5754 (arm_linux_store_inferior_registers): Likewise.
5758 * break-catch-syscall.c (struct catch_syscall_inferior_data)
5759 <syscalls_counts>: Now a std::vector.
5760 (get_catch_syscall_inferior_data): Use "new".
5761 (catch_syscall_inferior_data_cleanup): Use "delete".
5762 (insert_catch_syscall, remove_catch_syscall)
5763 (clear_syscall_counts): Update.
5767 * break-catch-syscall.c (syscall_catchpoint)
5768 <syscalls_to_be_caught>: Now a std::vector<int>
5769 (~syscall_catchpoint): Remove.
5770 (insert_catch_syscall, remove_catch_syscall)
5771 (breakpoint_hit_catch_syscall, print_one_catch_syscall)
5772 (print_mention_catch_syscall, print_recreate_catch_syscall):
5774 (create_syscall_event_catchpoint): Change type of "filter"
5776 (catch_syscall_split_args): Return a std::vector.
5777 (catch_syscall_command_1, catching_syscall_number_1): Update.
5781 * break-catch-throw.c (struct exception_catchpoint)
5782 <exception_rx>: Now a std::string.
5783 (~exception_catchpoint): Remove.
5784 (print_one_detail_exception_catchpoint): Update.
5785 (handle_gnu_v3_exceptions): Change type of except_rx.
5786 (extract_exception_regexp): Return a std::string.
5787 (catch_exception_command_1): Update.
5791 * break-catch-sig.c (gdb_signal_type): Remove typedef.
5792 (struct signal_catchpoint) <signals_to_be_caught>: Now a
5794 <catch_all>: Now a bool.
5795 (~signal_catchpoint): Remove.
5796 (signal_catchpoint_insert_location)
5797 (signal_catchpoint_remove_location)
5798 (signal_catchpoint_breakpoint_hit, signal_catchpoint_print_one)
5799 (signal_catchpoint_print_mention)
5800 (signal_catchpoint_print_recreate)
5801 (signal_catchpoint_explains_signal): Update.
5802 (create_signal_catchpoint): Change type of "filter" and
5804 (catch_signal_split_args): Return a std::vector. Change type of
5806 (catch_signal_command): Update.
5810 * ada-lang.c (ada_language_defn): Make extern.
5811 (_initialize_ada_language): Remove add_language call.
5812 * c-lang.c (c_language_defn, cplus_language_defn)
5813 (asm_language_defn, minimal_language_defn): Make extern.
5814 (_initialize_c_language): Delete.
5815 * completer.c (compare_cstrings): Delete, moved to utils.h.
5816 * d-lang.c (d_language_defn): Make extern.
5817 (_initialize_d_language): Remove add_language calls.
5818 * defs.h (enum language): Add comment.
5819 * f-lang.c (f_language_defn): Make extern.
5820 (_initialize_f_language): Remove add_language call.
5821 * go-lang.c (go_language_defn): Make extern.
5822 (_initialize_go_language): Remove add_language call.
5823 * language.c: Include <algorithm>.
5824 (languages): Redefine as const array.
5825 (languages_size, languages_allocsize, DEFAULT_ALLOCSIZE): Delete.
5826 (set_language_command): Handle "local". Use for-range loop.
5827 (set_language): Remove loop.
5828 (language_enum): Rewrite.
5829 (language_def, language_str): Remove loops.
5830 (add_language): Delete.
5831 (add_set_language_command): New, based on add_languages.
5832 (skip_language_trampoline): Adjust.
5833 (local_language_defn): Delete.
5834 (language_gdbarch_post_init): Adjust.
5835 (_initialize_language): Remove add_language calls. Call
5836 add_set_language_command.
5837 * language.h (add_language): Delete.
5838 (auto_language_defn)
5839 (unknown_language_defn, minimal_language_defn, ada_language_defn)
5840 (asm_language_defn, c_language_defn, cplus_language_defn)
5841 (d_language_defn, f_language_defn, go_language_defn)
5842 (m2_language_defn, objc_language_defn, opencl_language_defn)
5843 (pascal_language_defn, rust_language_defn): Declare.
5844 * m2-lang.c (m2_language_defn): Make extern.
5845 (_initialize_m2_language): Remove add_language call.
5846 * objc-lang.c (objc_language_defn): Make extern.
5847 (_initialize_objc_language): Remove add_language call.
5848 * opencl-lang.c (opencl_language_defn): Make extern.
5849 (_initialize_opencl_language): Remove add_language call.
5850 * p-lang.c (pascal_language_defn): Make extern.
5851 (_initialize_pascal_language): Delete.
5852 * rust-lang.c (rust_language_defn): Make extern.
5853 (_initialize_rust_language): Delete.
5854 * utils.h (compare_cstrings): New static inline function.
5858 * ada-lang.c (ada_to_fixed_type_1): Adjust.
5859 (get_var_value): Constify parameters.
5860 (get_int_var_value): Change prototype.
5861 (to_fixed_range_type): Adjust.
5862 * ada-lang.h (get_int_var_value): Change prototype.
5866 * dwarf2read.c (dw2_lookup_symbol): Use
5867 SYMBOL_MATCHES_SEARCH_NAME.
5868 * psymtab.c (psym_lookup_symbol): Use SYMBOL_MATCHES_SEARCH_NAME.
5872 * block.c (block_iter_name_step, block_iter_name_first)
5873 (block_iter_name_next): Delete.
5874 (block_lookup_symbol_primary): Adjust to use
5875 dict_iter_match_first/dict_iter_match_next.
5876 * block.h (block_iter_name_first, block_iter_name_next): Delete
5878 (ALL_BLOCK_SYMBOLS_WITH_NAME): Adjust to use
5879 dict_iter_match_first/dict_iter_match_next.
5883 * cp-support.c (cp_find_first_component_aux): Add missing case for
5888 * dwarf2read.c (create_cus_hash_table): Re-add lost initialization
5889 of dwo_cu's dwo_file.
5893 * remote.c (store_registers_using_G): Remove one line comment.
5897 * regcache.c (regcache_cpy): Simplify it.
5898 (regcache::cpy_no_passthrough): Remove it.
5899 * regcache.h (cpy_no_passthrough): Remove it.
5900 (regcache_dup, regcache_cpy): Update comments.
5904 * remote-sim.c (sim_command_completer): Adjust to work with a
5905 completion_tracker instead of a VEC.
5909 * completer.c (complete_source_filenames): New function.
5910 (complete_address_and_linespec_locations): New function.
5911 (location_completer): Use complete_address_and_linespec_locations.
5912 (completion_tracker::build_completion_result): Honor the tracker's
5913 request to suppress append.
5914 * completer.h (completion_tracker::suppress_append_ws)
5915 (completion_tracker::set_suppress_append_ws): New methods.
5916 (completion_tracker::m_suppress_append_ws): New field.
5917 (complete_source_filenames): New declaration.
5918 * linespec.c (linespec_complete_what): New.
5919 (struct ls_parser) <complete_what, completion_word,
5920 completion_quote_char, completion_quote_end, completion_tracker>:
5922 (string_find_incomplete_keyword_at_end): New.
5923 (linespec_lexer_lex_string): Record quote char. If in completion
5925 (linespec_lexer_consume_token): Advance the completion word point.
5926 (linespec_lexer_peek_token): Save/restore completion info.
5927 (save_stream_and_consume_token): New.
5928 (set_completion_after_number): New.
5929 (linespec_parse_basic): Set what to complete next depending on
5930 token. Handle function and label completions specially.
5931 (parse_linespec): Disable objc shortcut in completion mode. Set
5932 what to complete next depending on token type. Skip keyword if in
5934 (complete_linespec_component, linespec_complete): New.
5935 * linespec.h (linespec_complete): Declare.
5939 * linespec.c (linespec_lexer_lex_string, find_toplevel_char):
5940 Handle 'operator<' / 'operator<<'.
5944 * completer.c (collect_explicit_location_matches): Handle
5946 (convert_explicit_location_to_linespec): New, factored out from
5948 (convert_explicit_location_to_sals): ... this.
5949 (complete_label): New.
5950 (linespec_complete_label, find_label_symbols_in_block): New.
5951 (find_label_symbols): Add completion_mode parameter and adjust to
5952 call find_label_symbols_in_block.
5953 * linespec.h (linespec_complete_label): Declare.
5957 * ada-lang.c (ada_collect_symbol_completion_matches): Add
5958 complete_symbol_mode parameter.
5959 * cli/cli-cmds.c (complete_command): Get the completion result out
5960 of the handle_brkchars tracker if used a custom word point.
5961 * completer.c: Include "linespec.h".
5962 (enum explicit_location_match_type) <MATCH_LINE>: New enumerator.
5963 (advance_to_expression_complete_word_point): New.
5964 (completion_tracker::completes_to_completion_word): New.
5965 (complete_files_symbols): Pass down
5966 complete_symbol_mode::EXPRESSION.
5967 (explicit_options, probe_options): New.
5968 (collect_explicit_location_matches): Complete on the
5969 explictit_loc->foo instead of word. Use
5970 linespec_complete_function. Handle MATCH_LINE. Handle offering
5971 keyword and options completions.
5972 (backup_text_ptr): Delete.
5973 (skip_keyword): New.
5974 (complete_explicit_location): Remove 'word' parameter. Add
5975 language, quoted_arg_start and quoted_arg_end parameters.
5976 Rewrite, parsing left to right.
5977 (location_completer): Rewrite.
5978 (location_completer_handle_brkchars): New function.
5979 (symbol_completer): Pass down complete_symbol_mode::EXPRESSION.
5980 (enum complete_line_internal_reason): Adjust comments.
5981 (completion_tracker::discard_completions): New.
5982 (completer_handle_brkchars_func_for_completer): Handle
5984 (gdb_custom_word_point_brkchars)
5985 (gdb_org_rl_basic_quote_characters): New.
5986 (gdb_completion_word_break_characters_throw)
5987 (completion_find_completion_word): Handle trackers that use a
5989 (completion_tracker::advance_custom_word_point_by): New.
5990 (completion_tracker::build_completion_result): Don't rely on
5991 readline appending the quote char.
5992 (gdb_rl_attempted_completion_function_throw): Handle trackers that
5993 use a custom word point.
5994 (gdb_rl_attempted_completion_function): Restore
5995 rl_basic_quote_characters.
5996 * completer.h (class completion_tracker): Extend intro comment.
5997 (completion_tracker::set_quote_char)
5998 (completion_tracker::quote_char)
5999 (completion_tracker::set_use_custom_word_point)
6000 (completion_tracker::use_custom_word_point)
6001 (completion_tracker::custom_word_point)
6002 (completion_tracker::set_custom_word_point)
6003 (completion_tracker::advance_custom_word_point_by)
6004 (completion_tracker::completes_to_completion_word)
6005 (completion_tracker::discard_completions): New methods.
6006 (completion_tracker::m_quote_char)
6007 (completion_tracker::m_use_custom_word_point)
6008 (completion_tracker::m_custom_word_point): New fields.
6009 (advance_to_expression_complete_word_point): Declare.
6010 * f-lang.c (f_collect_symbol_completion_matches): Add
6011 complete_symbol_mode parameter.
6012 * language.h (struct language_defn)
6013 <la_collect_symbol_completion_matches>: Add complete_symbol_mode
6015 * linespec.c (linespec_keywords): Add NULL terminator. Make extern.
6016 (linespec_complete_function): New function.
6017 (linespec_lexer_lex_keyword): Adjust.
6018 * linespec.h (linespec_keywords, linespec_complete_function): New
6020 * location.c (find_end_quote): New function.
6021 (explicit_location_lex_one): Add explicit_completion_info
6022 parameter. Save quoting info. Don't throw if being called for
6023 completion. Don't handle Ada operators here.
6024 (is_cp_operator, skip_op_false_positives, first_of)
6025 (explicit_location_lex_one_function): New function.
6026 (string_to_explicit_location): Replace 'dont_throw' parameter with
6027 an explicit_completion_info pointer parameter. Handle it. Don't
6028 use explicit_location_lex_one to lex function names. Use
6029 explicit_location_lex_one_function instead.
6030 * location.h (struct explicit_completion_info): New.
6031 (string_to_explicit_location): Replace 'dont_throw' parameter with
6032 an explicit_completion_info pointer parameter.
6033 * symtab.c (default_collect_symbol_completion_matches_break_on):
6034 Add complete_symbol_mode parameter. Handle LINESPEC mode.
6035 (default_collect_symbol_completion_matches)
6036 (collect_symbol_completion_matches): Add complete_symbol_mode
6038 (collect_symbol_completion_matches_type): Pass down
6039 complete_symbol_mode::EXPRESSION.
6040 (collect_file_symbol_completion_matches): Add complete_symbol_mode
6041 parameter. Handle LINESPEC mode.
6042 * symtab.h (complete_symbol_mode): New.
6043 (default_collect_symbol_completion_matches_break_on)
6044 (default_collect_symbol_completion_matches)
6045 (collect_symbol_completion_matches)
6046 (collect_file_symbol_completion_matches): Add complete_symbol_mode
6051 * utils.c (enum class strncmp_iw_mode): New.
6052 (strcmp_iw): Rename to ...
6053 (strncmp_iw_with_mode): ... this. Add string2_len and mode
6054 parameters. Handle them.
6056 (strcmp_iw): Reimplement as wrapper around strncmp_iw_with_mode.
6057 * utils.h (strncmp_iw): Declare.
6058 (strcmp_iw): Move describing comments here.
6062 * c-exp.y (operator_stoken): Use CP_OPERATOR_LEN and
6064 * c-typeprint.c (is_type_conversion_operator): Use
6066 * cp-support.c (LENGTH_OF_OPERATOR): Delete.
6067 (cp_find_first_component_aux): Use CP_OPERATOR_STR and
6069 * cp-support.h (CP_OPERATOR_STR, CP_OPERATOR_LEN): New.
6070 * gnu-v2-abi.c (gnuv2_is_operator_name): Use CP_OPERATOR_STR.
6071 * gnu-v3-abi.c (gnuv3_is_operator_name): Use CP_OPERATOR_STR.
6072 * linespec.c (linespec_lexer_lex_string): Use CP_OPERATOR_LEN and
6074 * location.c: Include "cp-support.h".
6075 (explicit_location_lex_one): Use CP_OPERATOR_LEN and
6077 * symtab.c (operator_chars): Use CP_OPERATOR_STR and
6082 * cli/cli-cmds.c (complete_command): Use a completion tracker
6083 along with completion_find_completion_word for handle_brkchars
6085 * completer.c (RL_QF_SINGLE_QUOTE, RL_QF_DOUBLE_QUOTE)
6086 (RL_QF_BACKSLASH, RL_QF_OTHER_QUOTE): New.
6087 (struct gdb_rl_completion_word_info): New.
6088 (gdb_rl_find_completion_word): New.
6089 (completion_find_completion_word): New.
6090 * completer.h (completion_find_completion_word): Declare.
6094 * ada-lang.c (symbol_completion_match): Adjust comments.
6095 (symbol_completion_add): Replace vector parameter with
6096 completion_tracker parameter. Use it.
6097 (ada_make_symbol_completion_list): Rename to...
6098 (ada_collect_symbol_completion_matches): ... this. Add
6099 completion_tracker parameter and use it.
6100 (ada_language_defn): Adjust.
6101 * break-catch-syscall.c (catch_syscall_completer): Adjust
6102 prototype and work with completion_tracker instead of VEC.
6103 * breakpoint.c (condition_completer): Adjust prototype and work
6104 with completion_tracker instead of VEC.
6105 * c-lang.c (c_language_defn, cplus_language_defn)
6106 (asm_language_defn, minimal_language_defn): Adjust to renames.
6107 * cli/cli-cmds.c (complete_command): Rework using
6108 completion_tracker. Catch exceptions when completing.
6109 * cli/cli-decode.c (integer_unlimited_completer)
6110 (complete_on_cmdlist, complete_on_enum): Adjust prototype and work
6111 with completion_tracker instead of VEC.
6112 * command.h (struct completion_tracker): Forward declare.
6113 (completer_ftype, completer_handle_brkchars_ftype): Change
6115 (complete_on_cmdlist, complete_on_enum): Adjust.
6116 * completer.c: Include <algorithm>.
6117 (struct gdb_completer_state): New.
6118 (current_completion): New global.
6119 (readline_line_completion_function): Delete.
6120 (noop_completer, filename_completer)
6121 (filename_completer_handle_brkchars, complete_files_symbols)
6122 (linespec_location_completer): Adjust to work with a
6123 completion_tracker instead of a VEC.
6124 (string_or_empty): New.
6125 (collect_explicit_location_matches): Adjust to work with a
6126 completion_tracker instead of a VEC.
6127 (explicit_location_completer): Rename to ...
6128 (complete_explicit_location): ... this and adjust to work with a
6129 completion_tracker instead of a VEC.
6130 (location_completer): Adjust to work with a completion_tracker
6132 (add_struct_fields): Adjust to work with a completion_list instead
6134 (expression_completer): Rename to ...
6135 (complete_expression): ... this and adjust to work with a
6136 completion_tracker instead of a VEC. Use complete_files_symbols.
6137 (expression_completer): Reimplement on top of complete_expression.
6138 (symbol_completer): Adjust to work with a completion_tracker
6140 (enum complete_line_internal_reason): Add describing comments.
6141 (complete_line_internal_normal_command): Adjust to work with a
6142 completion_tracker instead of a VEC.
6143 (complete_line_internal): Rename to ...
6144 (complete_line_internal_1): ... this and adjust to work with a
6145 completion_tracker instead of a VEC. Assert TEXT is NULL in the
6146 handle_brkchars phase.
6147 (new_completion_tracker): Delete.
6148 (complete_line_internal): Reimplement as TRY/CATCH wrapper around
6149 complete_line_internal_1.
6150 (free_completion_tracker): Delete.
6151 (INITIAL_COMPLETION_HTAB_SIZE): New.
6152 (completion_tracker::completion_tracker)
6153 (completion_tracker::~completion_tracker): New.
6154 (maybe_add_completion): Delete.
6155 (completion_tracker::maybe_add_completion)
6156 (completion_tracker::add_completion)
6157 (completion_tracker::add_completions): New.
6158 (throw_max_completions_reached_error): Delete.
6159 (complete_line): Adjust to work with a completion_tracker instead
6160 of a VEC. Don't create a completion_tracker_t or check for max
6162 (command_completer, command_completer_handle_brkchars)
6163 (signal_completer, reg_or_group_completer_1)
6164 (reg_or_group_completer, default_completer_handle_brkchars):
6165 Adjust to work with a completion_tracker.
6166 (gdb_completion_word_break_characters_throw): New.
6167 (gdb_completion_word_break_characters): Reimplement.
6168 (line_completion_function): Delete.
6169 (completion_tracker::recompute_lowest_common_denominator)
6170 (expand_preserving_ws)
6171 (completion_tracker::build_completion_result)
6172 (completion_result::completion_result)
6173 (completion_result::completion_result)
6174 (completion_result::~completion_result)
6175 (completion_result::completion_result)
6176 (completion_result::release_match_list, compare_cstrings)
6177 (completion_result::sort_match_list)
6178 (completion_result::reset_match_list)
6179 (gdb_rl_attempted_completion_function_throw)
6180 (gdb_rl_attempted_completion_function): New.
6181 * completer.h (completion_list, struct completion_result)
6182 (class completion_tracker): New.
6183 (complete_line): Add completion_tracker parameter.
6184 (readline_line_completion_function): Delete.
6185 (gdb_rl_attempted_completion_function): New.
6186 (noop_completer, filename_completer, expression_completer)
6187 (location_completer, symbol_completer, command_completer)
6188 (signal_completer, reg_or_group_completer): Update prototypes.
6189 (completion_tracker_t, new_completion_tracker)
6190 (make_cleanup_free_completion_tracker): Delete.
6191 (enum maybe_add_completion_enum): Delete.
6192 (maybe_add_completion): Delete.
6193 (throw_max_completions_reached_error): Delete.
6194 * corefile.c (complete_set_gnutarget): Adjust to work with a
6195 completion_tracker instead of a VEC.
6196 * cp-abi.c (cp_abi_completer): Adjust to work with a
6197 completion_tracker instead of a VEC.
6198 * d-lang.c (d_language_defn): Adjust.
6199 * disasm.c (disassembler_options_completer): Adjust to work with a
6200 completion_tracker instead of a VEC.
6201 * f-lang.c (f_make_symbol_completion_list): Rename to ...
6202 (f_collect_symbol_completion_matches): ... this. Adjust to work
6203 with a completion_tracker instead of a VEC.
6204 (f_language_defn): Adjust.
6205 * go-lang.c (go_language_defn): Adjust.
6206 * guile/scm-cmd.c (cmdscm_add_completion, cmdscm_completer):
6207 Adjust to work with a completion_tracker instead of a VEC.
6208 * infrun.c (handle_completer): Likewise.
6209 * interps.c (interpreter_completer): Likewise.
6210 * interps.h (interpreter_completer): Likewise.
6211 * language.c (unknown_language_defn, auto_language_defn)
6212 (local_language_defn): Adjust.
6213 * language.h (language_defn::la_make_symbol_completion_list):
6215 (language_defn::la_collect_symbol_completion_matches): ... this
6216 and adjust to work with a completion_tracker instead of a VEC.
6217 * m2-lang.c (m2_language_defn): Adjust.
6218 * objc-lang.c (objc_language_defn): Adjust.
6219 * opencl-lang.c (opencl_language_defn): Adjust.
6220 * p-lang.c (pascal_language_defn): Adjust.
6221 * python/py-cmd.c (cmdpy_completer_helper): Handle NULL word.
6222 (cmdpy_completer_handle_brkchars, cmdpy_completer): Adjust to work
6223 with a completion_tracker.
6224 * rust-lang.c (rust_language_defn): Adjust.
6225 * symtab.c (free_completion_list, do_free_completion_list)
6226 (return_val, completion_tracker): Delete.
6227 (completion_list_add_name, completion_list_add_symbol)
6228 (completion_list_add_msymbol, completion_list_objc_symbol)
6229 (completion_list_add_fields, add_symtab_completions): Add
6230 completion_tracker parameter and use it.
6231 (default_make_symbol_completion_list_break_on_1): Rename to...
6232 (default_collect_symbol_completion_matches_break_on): ... this.
6233 Add completion_tracker parameter and use it instead of allocating
6234 a completion tracker here.
6235 (default_make_symbol_completion_list_break_on): Delete old
6237 (default_make_symbol_completion_list): Delete.
6238 (default_collect_symbol_completion_matches): New.
6239 (make_symbol_completion_list): Delete.
6240 (collect_symbol_completion_matches): New.
6241 (make_symbol_completion_type): Rename to ...
6242 (collect_symbol_completion_matches_type): ... this. Add
6243 completion_tracker parameter and use it instead of VEC.
6244 (make_file_symbol_completion_list_1): Rename to...
6245 (collect_file_symbol_completion_matches): ... this. Add
6246 completion_tracker parameter and use it instead of VEC.
6247 (make_file_symbol_completion_list): Delete.
6248 (add_filename_to_list): Use completion_list instead of a VEC.
6249 (add_partial_filename_data::list): Now a completion_list.
6250 (make_source_files_completion_list): Work with a completion_list
6252 * symtab.h: Include "completer.h".
6253 (default_make_symbol_completion_list_break_on)
6254 (default_make_symbol_completion_list, make_symbol_completion_list)
6255 (make_symbol_completion_type, make_file_symbol_completion_list)
6256 (make_source_files_completion_list): Delete.
6257 (default_collect_symbol_completion_matches_break_on)
6258 (default_collect_symbol_completion_matches)
6259 (collect_symbol_completion_matches)
6260 (collect_symbol_completion_matches_type)
6261 (collect_file_symbol_completion_matches)
6262 (make_source_files_completion_list): New.
6263 * top.c (init_main): Don't install a rl_completion_entry_function
6264 hook. Install a rl_attempted_completion_function hook instead.
6265 * tui/tui-layout.c (layout_completer): Adjust to work with a
6267 * tui/tui-regs.c (tui_reggroup_completer):
6268 * tui/tui-win.c (window_name_completer, focus_completer)
6269 (winheight_completer): Adjust to work with a completion_tracker.
6270 * value.c: Include "completer.h".
6271 (complete_internalvar): Adjust to work with a completion_tracker.
6272 * value.h (complete_internalvar): Likewise.
6276 * cli/cli-decode.c (set_cmd_completer_handle_brkchars): Adjust to
6278 * cli/cli-decode.h (struct cmd_list_element) <completer>: Move
6279 comments to completer_ftype's declaration.
6280 <completer_handle_brkchars>: Change type to
6281 completer_handle_brkchars_ftype.
6282 * command.h (completer_ftype): Add describing comment and give
6283 names to parameters.
6284 (completer_ftype_void): Rename to ...
6285 (completer_handle_brkchars_ftype) ... this. Add describing comment.
6286 (set_cmd_completer_handle_brkchars): Adjust.
6287 * completer.c (filename_completer_handle_brkchars): New function.
6288 (complete_line_internal_normal_command): New function, factored
6290 (complete_line_internal): ... here.
6291 (command_completer_handle_brkchars)
6292 (default_completer_handle_brkchars)
6293 (completer_handle_brkchars_func_for_completer): New functions.
6294 * completer.h (set_gdb_completion_word_break_characters): Delete
6296 (completer_handle_brkchars_func_for_completer): New declaration.
6297 * python/py-cmd.c (cmdpy_completer_handle_brkchars): Adjust to use
6298 completer_handle_brkchars_func_for_completer.
6302 * completer.c (symbol_completer): New function, based on
6303 make_symbol_completion_list_fn.
6304 * completer.h (symbol_completer): New declaration.
6305 * guile/scm-cmd.c (cmdscm_completers): Adjust.
6306 * python/py-cmd.c (completers): Adjust.
6307 * symtab.c (make_symbol_completion_list_fn): Delete.
6308 * symtab.h (make_symbol_completion_list_fn): Delete.
6309 * cli/cli-decode.c (add_cmd): Adjust.
6313 * Makefile.in (COMMON_OBS): Add filename-seen-cache.o.
6314 * dwarf2read.c: Include "filename-seen-cache.h".
6315 * dwarf2read.c (dwarf2_per_objfile) <filenames_cache>: New field.
6316 (dw2_map_symbol_filenames): Build and use a filenames_seen_cache.
6317 * filename-seen-cache.c: New file.
6318 * filename-seen-cache.h: New file.
6319 * symtab.c: Include "filename-seen-cache.h".
6320 (struct filename_seen_cache, INITIAL_FILENAME_SEEN_CACHE_SIZE)
6321 (create_filename_seen_cache, clear_filename_seen_cache)
6322 (delete_filename_seen_cache, filename_seen): Delete, parts moved
6323 to filename-seen-cache.h/filename-seen-cache.c.
6324 (output_source_filename, sources_info)
6325 (maybe_add_partial_symtab_filename)
6326 (make_source_files_completion_list): Adjust to use
6327 filename_seen_cache.
6331 * dwarf2read.c (dwarf2_per_objfile): In-class initialize all
6333 (dwarf2_per_objfile::dwarf2_per_objfile(objfile*, const
6334 dwarf2_debug_sections*)): New.
6335 (dwarf2_per_objfile::dwarf2_per_objfile(const
6336 dwarf2_per_objfile&)): Declare as deleted.
6337 (dwarf2_per_objfile::operator=): Declare as deleted.
6338 (dwarf2_per_objfile::dwarf2_per_objfile)
6339 (dwarf2_per_objfile::~dwarf2_per_objfile)
6340 (dwarf2_per_objfile::free_cached_comp_units): New.
6341 (dwarf2_has_info): dwarf2_per_objfile initialization code moved to
6342 ctor. Call dwarf2_per_objfile's ctor manually.
6343 (dwarf2_locate_sections): Deleted/refactored as ...
6344 (dwarf2_per_objfile::locate_sections): ... this new method.
6345 (free_cached_comp_units): Defer to
6346 dwarf2_per_objfile::free_cached_comp_units.
6347 (dwarf2_free_objfile): Call dwarf2_per_objfile's dtor manually.
6352 * rust-exp.y (convert_ast_to_expression): Add "want_type"
6354 <UNOP_SIZEOF>: Split into separate case.
6355 <UNOP_VAR_VALUE>: Handle want_type. Add error case.
6360 * symtab.c (symbol_matches_domain): Add language_rust to special
6362 * rust-exp.y (convert_ast_to_expression) <OP_VAR_VALUE>: Don't
6363 treat LOC_TYPEDEF symbols as variables.
6367 * symtab.c (make_file_symbol_completion_list_1): Iterate over
6368 symtabs matching all symtabs with SRCFILE as file name instead of
6369 only considering the first hit, with lookup_symtab.
6373 * ax-gdb.c (gen_aggregate_elt_ref): Remove operand_name and
6374 operator_name parameters.
6375 (gen_expr): Update function call.
6379 * dwarf2loc.h (dwarf2_compile_expr_to_ax): Remove gdbarch
6381 * symtab.h (struct symbol_computed_ops::tracepoint_var_ref):
6383 * dwarf2loc.c (dwarf2_compile_expr_to_ax): Remove gdbarch
6384 parameter, use agent_expr::gdbarch instead, update function
6386 (locexpr_tracepoint_var_ref): Likewise.
6387 (loclist_tracepoint_var_ref): Likewise.
6388 * ax-gdb.c (gen_trace_static_fields): Likewise.
6389 (gen_traced_pop): Likewise.
6390 (gen_frame_args_address): Likewise.
6391 (gen_frame_locals_address): Likewise.
6392 (gen_var_ref): Likewise.
6393 (gen_struct_ref_recursive): Likewise.
6394 (gen_static_field): Likewise.
6395 (gen_maybe_namespace_elt): Likewise.
6396 (gen_expr): Likewise.
6397 (gen_trace_for_var): Likewise.
6398 (gen_trace_for_expr): Likewise.
6399 (gen_trace_for_return_address): Likewise.
6403 * ax-gdb.c (gen_deref, gen_address_of): Remove unused ax
6405 (gen_struct_ref, gen_expr, gen_expr_binop_rest): Update call.
6409 * ax-gdb.c (gen_usual_unary): Remove exp parameter, get gdbarch
6410 from ax, update calls.
6411 (gen_usual_arithmetic): Likewise.
6412 (gen_integral_promotions): Likewise.
6413 (gen_bitfield_ref): Likewise.
6414 (gen_primitive_field): Likewise.
6415 (gen_struct_ref_recursive): Likewise.
6416 (gen_struct_ref): Likewise.
6417 (gen_maybe_namespace_elt): Likewise.
6418 (gen_struct_elt_for_reference): Likewise.
6419 (gen_namespace_elt): Likewise.
6420 (gen_aggregate_elt_ref): Likewise.
6421 (gen_expr): Get gdbarch from ax, update calls.
6422 (gen_expr_binop_rest): Likewise.
6426 * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Pass tdesc_amd64
6428 * amd64-dicos-tdep.c (amd64_dicos_init_abi):
6429 * amd64-fbsd-tdep.c (amd64fbsd_init_abi):
6430 * amd64-linux-tdep.c (amd64_linux_init_abi): Pass
6431 tdesc_amd64_linux as default tdesc. Get final tdesc from the
6433 (amd64_x32_linux_init_abi): Pass tdesc_x32_linux as default tdesc.
6434 Get final tdesc from the tdep.
6435 * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Pass tdesc_amd64 as
6437 * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
6438 * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
6439 * amd64-tdep.c (amd64_init_abi): Add 'default_tdesc' parameter.
6440 Use it as default tdesc.
6441 (amd64_x32_init_abi): Add 'default_tdesc' parameter, and pass it
6442 down to amd_init_abi. No longer handle fallback tdesc here.
6443 * amd64-tdep.h (tdesc_x32): Declare.
6444 (amd64_init_abi, amd64_x32_init_abi): Add 'default_tdesc'
6446 * amd64-windows-tdep.c (amd64_windows_init_abi): Pass tdesc_amd64
6451 * s390-linux-tdep.c (s390_process_record): Add support for
6452 instructions new in arch12.
6456 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6457 PT_GETFSBASE and PT_GETGSBASE.
6458 (amd64bsd_store_inferior_registers): Use PT_SETFSBASE and
6463 * features/Makefile (amd64.dat, amd64-avx.dat, amd64-mpx.dat)
6464 (amd64-avx-mpx.dat, amd64-avx-avx512.dat)
6465 (amd64-avx-mpx-avx512-pku.dat): Add i386/64bit-segments.xml in
6467 * features/i386/amd64-avx-avx512.xml: Add 64bit-segments.xml.
6468 * features/i386/amd64-avx-mpx-avx512-pku.xml: Add 64bit-segments.xml.
6469 * features/i386/amd64-avx-mpx.xml: Add 64bit-segments.xml.
6470 * features/i386/amd64-avx.xml: Add 64bit-segments.xml.
6471 * features/i386/amd64-mpx.xml: Add 64bit-segments.xml.
6472 * features/i386/amd64.xml: Add 64bit-segments.xml.
6473 * features/i386/amd64-avx-avx512.c: Regenerated.
6474 * features/i386/amd64-avx-mpx-avx512-pku.c: Regenerated.
6475 * features/i386/amd64-avx-mpx.c: Regenerated.
6476 * features/i386/amd64-avx.c: Regenerated.
6477 * features/i386/amd64-mpx.c: Regenerated.
6478 * features/i386/amd64.c: Regenerated.
6479 * regformats/i386/amd64-avx-avx512.dat: Regenerated.
6480 * regformats/i386/amd64-avx-mpx-avx512-pku.dat: Regenerated.
6481 * regformats/i386/amd64-avx-mpx.dat: Regenerated.
6482 * regformats/i386/amd64-avx.dat: Regenerated.
6483 * regformats/i386/amd64-mpx.dat: Regenerated.
6484 * regformats/i386/amd64.dat: Regenerated.
6488 * features/i386/amd64-avx-avx512-linux.c: Re-generated.
6489 * features/i386/amd64-avx-mpx-avx512-pku-linux.c: Re-generated.
6493 * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add setenv and
6495 * gnulib/aclocal.m4: Regenerate.
6496 * gnulib/config.in: Regenerate.
6497 * gnulib/configure: Regenerate.
6498 * gnulib/import/Makefile.am: Regenerate.
6499 * gnulib/import/Makefile.in: Regenerate.
6500 * gnulib/import/m4/gnulib-cache.m4: Regenerate.
6501 * gnulib/import/m4/gnulib-comp.m4: Regenerate.
6502 * gnulib/import/m4/environ.m4: New file.
6503 * gnulib/import/m4/setenv.m4: New file.
6504 * gnulib/import/setenv.c: New file.
6505 * gnulib/import/unsetenv.c: New file.
6509 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Read
6510 address when op is DW_OP_addr.
6514 * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Reverse size
6515 check and apply to outer type.
6519 * fbsd-tdep.c (LWPINFO_OFFSET, LWPINFO_PL_FLAGS)
6520 (LWPINFO64_PL_SIGINFO, LWPINFO32_PL_SIGINFO, PL_FLAG_SI)
6521 (SIZE64_SIGINFO_T, SIZE32_SIGINFO_T, fbsd_core_xfer_siginfo): New.
6522 (fbsd_init_abi): Install gdbarch "core_xfer_siginfo" method.
6526 * fbsd-tdep.c (fbsd_core_thread_name): Use thread_section_name.
6530 * corelow.c (get_core_siginfo): Remove.
6531 (core_xfer_partial): Use the gdbarch "core_xfer_siginfo" method
6532 instead of get_core_siginfo.
6533 * gdbarch.sh (core_xfer_siginfo): New gdbarch callback.
6534 * gdbarch.h: Re-generate.
6535 * gdbarch.c: Re-generate.
6536 * linux-tdep.c (linux_core_xfer_siginfo): New.
6537 (linux_init_abi): Install gdbarch "core_xfer_siginfo" method.
6541 * corelow.c (thread_section_name): Move to ...
6542 * gdbcore.h (thread_section_name): ... here.
6546 * fbsd-nat.c [PT_LWPINFO && __LP64__] (union sigval32)
6547 (struct siginfo32): New.
6548 [PT_LWPINFO] (fbsd_siginfo_size, fbsd_convert_siginfo): New.
6549 (fbsd_xfer_partial) [PT_LWPINFO]: Handle TARGET_OBJECT_SIGNAL_INFO
6550 via ptrace(PT_LWPINFO).
6554 * fbsd-tdep.c (fbsd_gdbarch_data_handle, struct fbsd_gdbarch_data)
6555 (init_fbsd_gdbarch_data, get_fbsd_gdbarch_data)
6556 (fbsd_get_siginfo_type): New.
6557 (fbsd_init_abi): Install gdbarch "get_siginfo_type" method.
6558 (_initialize_fbsd_tdep): New.
6562 * dwarf2read.c (struct dwo_file): Use a htab of dwo_unit* (rather than
6563 a singular dwo_unit*) to support multiple CUs in the same way that
6564 multiple TUs are supported.
6565 (create_cus_hash_table): Replace create_dwo_cu with a function for
6566 parsing multiple CUs from a DWO file.
6567 (open_and_init_dwo_file): Use create_cus_hash_table rather than
6569 (lookup_dwo_cutu): Lookup CU in the hash table in the dwo_file with
6570 htab_find, rather than comparing the signature to a singleton CU in
6575 * python/py-unwind.c (pyuw_dealloc_cache): Fix for loop condition.
6579 * gdbtypes.c (recursive_dump_type): Don't reference TYPE_STATIC.
6580 * gdbtypes.h (TYPE_STATIC): Delete.
6581 (struct fn_field) <is_public, is_abstract, is_static, is_final,
6582 is_synchronized, is_native>: Delete.
6584 (TYPE_FN_FIELD_PUBLIC, TYPE_FN_FIELD_STATIC, TYPE_FN_FIELD_FINAL)
6585 (TYPE_FN_FIELD_SYNCHRONIZED, TYPE_FN_FIELD_NATIVE)
6586 (TYPE_FN_FIELD_ABSTRACT): Delete.
6590 * buffer.h (buffer_finish): Fix spelling mistakes.
6594 * .dir-locals.el: Automatically switch to C-style comments in
6595 versions of Emacs that support the feature.
6601 * cli/cli-script.c (command_name_equals_not_inline): Remove function.
6602 (process_next_line): New variable 'inline_cmd'.
6603 Adjust 'if' clauses for "python", "compile" and "guile" to use
6604 'command_name_equals' and check for '!inline_cmd'.
6609 * cli/cli-script.c (command_name_equals_not_inline): New function.
6610 (process_next_line): Adjust 'if' clauses for "python", "compile"
6611 and "guile" to use command_name_equals_not_inline.
6615 * completer.c (expression_completer): Call
6616 linespec_location_completer instead of location_completer.
6620 * completer.c (expression_completer): Remove code that recomputes
6625 * regformats/regdat.sh: Generate code with
6626 "ifndef IN_PROCESS_AGENT".
6630 * command.h: Include "common/scoped_restore.h".
6634 * mi/mi-cmd-break.c (mi_argv_to_format): Use obstack_grow_str
6635 instead of obstack_grow.
6640 * symfile.c (reread_symbols): Call objfiles_changed just before
6645 * symtab.c (COMPLETION_LIST_ADD_SYMBOL)
6646 (MCOMPLETION_LIST_ADD_SYMBOL): Delete macros, replace with ...
6647 (completion_list_add_symbol, completion_list_add_msymbol):
6648 ... these new functions.
6649 (add_symtab_completions)
6650 (default_make_symbol_completion_list_break_on_1): Adjust.
6654 * objfiles.c (get_objfile_bfd_data): Call bfd_alloc instead of
6655 bfd_zalloc. Call objfile_per_bfd_storage's ctor.
6656 (free_objfile_per_bfd_storage): Call objfile_per_bfd_storage's
6658 * objfiles.h (objfile_per_bfd_storage): Add ctor. Make
6659 'storage_obstack' field an auto_obstack. In-class initialize all
6660 non-bitfield fields. Make minsyms_read bool.
6661 * symfile.c (read_symbols): Adjust.
6665 * remote-sim.c (gdbsim_fetch_register): Use byte_vector.
6666 (gdbsim_store_register): Likewise.
6670 * c-exp.y (name_obstack): Now an auto_obstack.
6671 (yylex): Use auto_obstack::clear.
6672 (c_parse): Use auto_obstack::clear instead of reinitializing and
6673 freeing the obstack.
6674 * c-lang.c (evaluate_subexp_c): Use auto_obstack.
6675 * d-exp.y (name_obstack): Now an auto_obstack.
6676 (yylex): Use auto_obstack::clear.
6677 (d_parse): Use auto_obstack::clear instead of reinitializing and
6678 freeing the obstack.
6679 * dwarf2loc.c (fetch_const_value_from_synthetic_pointer): Use
6681 * dwarf2read.c (create_addrmap_from_index)
6682 (dwarf2_build_psymtabs_hard)
6683 (update_enumeration_type_from_children): Likewise.
6684 * gdb_obstack.h (auto_obstack): New type.
6685 * go-exp.y (name_obstack): Now an auto_obstack.
6686 (build_packaged_name): Use auto_obstack::clear.
6687 (go_parse): Use auto_obstack::clear instead of reinitializing and
6688 freeing the obstack.
6689 * linux-tdep.c (linux_make_mappings_corefile_notes): Use
6691 * printcmd.c (printf_wide_c_string, ui_printf): Use auto_obstack.
6692 * rust-exp.y (work_obstack): Now an auto_obstack.
6693 (rust_parse, rust_lex_tests): Use auto_obstack::clear instead of
6694 reinitializing and freeing the obstack.
6695 * utils.c (do_obstack_free, make_cleanup_obstack_free): Delete.
6696 (host_char_to_target): Use auto_obstack.
6697 * utils.h (make_cleanup_obstack_free): Delete declaration.
6698 * valprint.c (generic_emit_char, generic_printstr): Use
6703 * darwin-nat.c (darwin_check_new_threads): Don't handle dummy
6705 (darwin_init_thread_list): Don't update dummy thread.
6706 (darwin_create_inferior, darwin_attach): Don't add a dummy thread.
6710 * record-full.c (netorder16): Remove.
6714 * common/diagnostics.h: Define macros for GCC.
6715 (DIAGNOSTIC_IGNORE_UNUSED_FUNCTION): New macro.
6716 * common/vec.h: Include diagnostics.h.
6717 (DIAGNOSTIC_IGNORE_UNUSED_VEC_FUNCTION): New macro.
6718 (DEF_VEC_I, DEF_VEC_P, DEF_VEC_O): Ignore -Wunused-function
6723 * common/diagnostics.h (DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER):
6725 * ada-lex.l: Ignore deprecated register warnings.
6729 * main.c (get_init_files): Replace "SYSTEM_GDBINIT +
6730 datadir_len" with "&SYSTEM_GDBINIT[datadir_len]".
6734 * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on
6739 * nat/x86-dregs.c (x86_show_dr): Print registers one per line.
6743 * xtensa-tdep.c (XTENSA_MAX_REGISTER_SIZE): Add.
6744 (xtensa_register_write_masked): Use XTENSA_MAX_REGISTER_SIZE.
6745 (xtensa_register_read_masked): Likewise.
6749 * common/environ.c (gdb_environ::unset): Update comment.
6753 * python/py-unwind.c (pyuw_sniffer): Allocate space for
6758 * record-full.c (record_full_exec_insn): Use byte_vector.
6762 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Regenerated.
6763 * regformats/i386/amd64-avx-mpx-avx512-pku.dat: Regenerated.
6767 * remote.c (cached_reg): Move from here...
6768 * regcache.h (cached_reg): ...to here.
6769 * python/py-unwind.c (struct reg_info): Remove.
6770 (cached_frame_info): Use cached_reg_t.
6771 (pyuw_prev_register): Likewise.
6772 (pyuw_sniffer): Use cached_reg_t and allocate registers.
6773 (pyuw_dealloc_cache): Free all registers.
6778 * unittests/environ-selftests.c (run_tests): Ignore -Wself-move
6780 * common/diagnostics.h: New file.
6784 * common/agent.h: Add include guards.
6788 * target.h (struct target_ops) <to_xfer_partial>: Update doc to
6789 talk about addressable units instead of bytes.
6793 * common/environ.c (gdb_environ::unset): Use '::iterator' instead
6794 of '::const_iterator'.
6798 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6799 'unittests/environ-selftests.c'.
6800 (SUBDIR_UNITTESTS_OBS): Add 'environ-selftests.o'.
6801 * charset.c (find_charset_names): Declare object 'iconv_env'.
6802 Update code to use 'iconv_env' object. Remove call to
6804 * common/environ.c: Include <utility>.
6805 (make_environ): Delete function.
6806 (free_environ): Delete function.
6807 (gdb_environ::clear): New function.
6808 (gdb_environ::operator=): New function.
6809 (gdb_environ::get): Likewise.
6810 (environ_vector): Delete function.
6811 (set_in_environ): Delete function.
6812 (gdb_environ::set): New function.
6813 (unset_in_environ): Delete function.
6814 (gdb_environ::unset): New function.
6815 (gdb_environ::envp): Likewise.
6816 * common/environ.h: Include <vector>.
6817 (struct gdb_environ): Delete; transform into...
6818 (class gdb_environ): ... this class.
6819 (free_environ): Delete prototype.
6820 (init_environ, get_in_environ, set_in_environ, unset_in_environ,
6821 environ_vector): Likewise.
6822 * infcmd.c (run_command_1): Update code to call
6823 'envp' from 'gdb_environ' class.
6824 (environment_info): Update code to call methods from 'gdb_environ'
6826 (unset_environment_command): Likewise.
6827 (path_info): Likewise.
6828 (path_command): Likewise.
6829 * inferior.c (inferior::~inferior): Delete call to 'free_environ'.
6830 (inferior::inferior): Initialize 'environment' using the host's
6832 * inferior.h: Remove forward declaration of 'struct gdb_environ'.
6833 Include "environ.h".
6834 (class inferior) <environment>: Change type from 'struct
6835 gdb_environ' to 'gdb_environ'.
6836 * mi/mi-cmd-env.c (mi_cmd_env_path): Update code to call
6837 methods from 'gdb_environ' class.
6838 * solib.c (solib_find_1): Likewise
6839 * unittests/environ-selftests.c: New file.
6843 * features/i386/i386-linux.xml: Exchange the order of including
6844 32bit-linux.xml and 32bit-sse.xml.
6845 * features/i386/i386-linux.c: Regenerated.
6849 * target-descriptions.c (tdesc_reg): Add ctor, dtor.
6850 Delete copy ctor and assignment operator.
6851 (tdesc_type): Likewise.
6852 (tdesc_feature): Likewise.
6853 (tdesc_free_reg): Remove.
6854 (tdesc_create_reg): Use new.
6855 (tdesc_free_type): Remove.
6856 (tdesc_create_vector): Use new.
6857 (tdesc_create_union): Likewise.
6858 (tdesc_create_flags): Likewise.
6859 (tdesc_create_enum): Likewise.
6860 (tdesc_free_feature): Delete.
6861 (free_target_description): Use delete.
6865 * mips-tdep.c (print_gp_register_row): Don't error for unavailable
6870 * dwarf2read.c (write_psymtabs_to_index): Construct file_closer
6871 after gdb::unlinker.
6875 * mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of
6876 gdb_environ to access an environment variable.
6880 * nat/linux-ptrace.c (linux_fork_to_function): Add cast to
6885 * nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF.
6889 * configure: Re-generate.
6890 * warning.m4 (build_warnings): Add -Wno-mismatched-tags.
6894 * configure: Re-generate.
6895 * warning.m4: Pass -Werror to compiler when checking for
6896 supported warning flags.
6900 * Makefile.in (COMPILE.pre): Add "-x c++".
6906 * defs.h (RequireLongest): New.
6907 (extract_integer): Declare function template.
6908 (extract_signed_integer): Remove the declaration, but define it
6910 (extract_unsigned_integer): Likewise.
6911 (store_integer): Declare function template.
6912 (store_signed_integer): Remove the declaration, but define it
6914 (store_unsigned_integer): Likewise.
6915 * findvar.c (extract_integer): New function template.
6916 (extract_signed_integer): Remove.
6917 (extract_unsigned_integer): Remove.
6918 (extract_integer<LONGEST>, extract_integer<ULONGEST>): Explicit
6920 (store_integer): New function template.
6921 (store_signed_integer): Remove.
6922 (store_unsigned_integer): Remove.
6923 (store_integer): Explicit instantiations.
6924 * regcache.c (regcache_raw_read_signed): Update.
6925 (regcache::raw_read): New function.
6926 (regcache::raw_read_signed): Remove.
6927 (regcache::raw_read_unsigned): Remove.
6928 (regcache_raw_read_unsigned): Update.
6929 (regcache_raw_write_unsigned): Update.
6930 (regcache::raw_write_signed): Remove.
6931 (regcache::raw_write): New function.
6932 (regcache_cooked_read_signed): Update.
6933 (regcache::raw_write_unsigned): Remove.
6934 (regcache::cooked_read_signed): Remove.
6935 (regcache_cooked_read_unsigned): Update.
6936 (regcache::cooked_read_unsigned): Remove.
6937 (regcache_cooked_write_signed): Update.
6938 (regcache_cooked_write_unsigned): Update.
6939 * regcache.h (regcache) <raw_read_signed>: Remove.
6940 <raw_write_signed, raw_read_unsigned, raw_write_unsigned>: Remove.
6941 <raw_read, raw_write>: New.
6942 <cooked_read_signed, cooked_write_signed>: Remove.
6943 <cooked_write_unsigned, cooked_read_unsigned>: Remove.
6944 <cooked_read, cooked_write>: New.
6945 * sh64-tdep.c (sh64_pseudo_register_read): Update.
6946 (sh64_pseudo_register_write): Update.
6950 * arc-tdep.c (arc_disassembler_options): New variable.
6951 (arc_gdbarch_init): Set and use it. Use arc_delayed_print_insn instead
6952 of default_print_insn.
6953 (arc_delayed_print_insn): Set info->section when needed,
6954 use default_print_insn to retrieve a disassembler.
6959 * infcmd.c (_initialize_infcmd): Expand "help run" documentation
6960 to mention $SHELL and startup-with-shell.
6964 * MAINTAINERS: Move Maxim Grigoriev to the Past Maintainers.
6968 * aarch64-tdep.c (aarch64_gdb_print_insn): Call
6969 default_print_insn instead of print_insn_aarch64.
6970 * arm-tdep.c (gdb_print_insn_arm): Call
6971 default_print_insn instead of print_insn_big_arm
6972 and print_insn_little_arm.
6973 * i386-tdep.c (i386_print_insn): Call default_print_insn
6974 instead of print_insn_i386.
6975 * ia64-tdep.c (ia64_print_insn): Call
6976 default_print_insn instead of print_insn_ia64.
6977 * mips-tdep.c (gdb_print_insn_mips): Call
6978 default_print_insn instead of print_insn_big_mips
6979 and print_insn_little_mips.
6980 * spu-tdep.c (gdb_print_insn_spu): Call default_print_insn
6981 instead of print_insn_spu.
6985 * ada-lang.c: Include "common/byte-vector.h".
6986 (ada_value_primitive_packed_val): Use gdb::byte_vector.
6987 * charset.c (wchar_iterator::iterate): Resize the vector instead
6989 * common/byte-vector.h: Include "common/def-vector.h".
6990 (wchar_iterator::m_out): Now a gdb::def_vector<gdb_wchar_t>.
6991 * cli/cli-dump.c: Include "common/byte-vector.h".
6992 (dump_memory_to_file, restore_binary_file): Use gdb::byte_vector.
6993 * common/byte-vector.h: New file.
6994 * common/def-vector.h: New file.
6995 * common/default-init-alloc.h: New file.
6996 * dwarf2loc.c: Include "common/byte-vector.h".
6997 (rw_pieced_value): Use gdb::byte_vector, and resize the vector
6998 instead of reserving it.
6999 * dwarf2read.c: Include "common/byte-vector.h".
7000 (data_buf::m_vec): Now a gdb::byte_vector.
7001 * gdb_regex.c: Include "common/def-vector.h".
7002 (compiled_regex::compiled_regex): Use gdb::def_vector<char>.
7003 * mi/mi-main.c: Include "common/byte-vector.h".
7004 (mi_cmd_data_read_memory): Use gdb::byte_vector.
7005 * printcmd.c: Include "common/byte-vector.h".
7006 (print_scalar_formatted): Use gdb::byte_vector.
7007 * valprint.c: Include "common/byte-vector.h".
7008 (maybe_negate_by_bytes, print_decimal_chars): Use
7013 * darwin-nat.c: Include "nat/fork-inferior.h".
7017 * configure.nat: Factor out Darwin bits that are not
7018 architecture-specific. Add fork-inferior.o.
7022 * configure.nat: Factor out AIX bits that are not
7023 architecture-specific. Add fork-inferior.o.
7027 * dwarf2loc.c (rw_pieced_value): New. Merge logic from...
7028 (read_pieced_value, write_pieced_value): ...here. Reduce to
7029 wrappers that just call rw_pieced_value.
7033 * dwarf2loc.c (write_pieced_value): When writing the data for a
7034 memory piece, use write_memory_with_notification instead of
7039 * valops.c (read_value_memory): Change embedded_offset to
7040 represent a bit offset instead of a byte offset.
7041 * value.h (read_value_memory): Adjust comment.
7045 * dwarf2loc.c (read_pieced_value): Remove unnecessary variables
7046 dest_offset_bits and source_offset_bits.
7047 (write_pieced_value): Likewise.
7051 * dwarf2loc.c (read_pieced_value): Respect the piece offset, as
7052 given by DW_OP_bit_piece.
7053 (write_pieced_value): Likewise.
7057 * dwarf2loc.c (read_pieced_value): Move the buffer allocation and
7058 some other preparations to the places where sufficient information
7060 (write_pieced_value): Likewise.
7064 * dwarf2loc.c (bits_to_bytes): New function.
7065 (read_pieced_value): Fix offset calculations for register pieces
7066 on big-endian targets.
7067 (write_pieced_value): Likewise.
7071 * dwarf2loc.c (read_pieced_value): Remove buffer_size variable.
7072 (write_pieced_value): Likewise.
7076 * dwarf2loc.c (write_pieced_value): When writing to a bit-field,
7077 transfer the source value's least significant bits, instead of its
7078 lowest-addressed ones. Rename type_len to max_offset.
7079 (read_pieced_value): Mirror above changes to write_pieced_value as
7084 * dwarf2loc.c (write_pieced_value): In DWARF_VALUE_MEMORY,
7085 truncate full bytes from dest_offset_bits before using it as an
7086 offset into the buffer.
7090 * dwarf2loc.c (write_pieced_value): Include transfer size in
7095 * dwarf2loc.c (write_pieced_value): Fix copy/paste error in the
7096 calculation of this_size.
7100 * dwarf2loc.c (read_pieced_value): Respect parent value's offset
7101 when targeting a bit-field.
7102 (write_pieced_value): Likewise.
7106 * dwarf2loc.c (struct piece_closure) <addr_size>: Remove field.
7107 (allocate_piece_closure): Drop addr_size parameter.
7108 (dwarf2_evaluate_loc_desc_full): Adjust call to
7109 allocate_piece_closure.
7114 * dwarf2loc.c (read_pieced_value): Anchor stack value pieces at
7115 the LSB end, independent of endianness.
7119 * dwarf2loc.c (write_pieced_value): Fix order of calculations for
7124 * mips-linux-nat.c: Move include features/mips*-linux.c to
7126 (_initialize_mips_linux_nat): Move initialize_tdesc_mips* calls
7127 to mips-linux-tdep.c.
7128 * mips-linux-tdep.c: Include features/mips*-linux.c
7129 (_initialize_mips_linux_tdep): Call initialize_tdesc_mips*
7131 * mips-linux-tdep.h (tdesc_mips_linux): Declare.
7132 (tdesc_mips_dsp_linux, tdesc_mips64_linux): Declare.
7133 (tdesc_mips64_dsp_linux): Declare.
7137 * valprint.h (val_print_type_code_int): Remove.
7138 * valprint.c (generic_val_print_int): Always call
7139 val_print_scalar_formatted.
7140 (val_print_type_code_int): Remove.
7141 * printcmd.c (print_scalar_formatted): Handle options->format==0.
7142 * f-valprint.c (f_val_print): Use val_print_scalar_formatted.
7143 * c-valprint.c (c_val_print_int): Use val_print_scalar_formatted.
7144 * ada-valprint.c (ada_val_print_num): Use
7145 val_print_scalar_formatted.
7149 * printcmd.c (print_scalar_formatted): Unify the two switches.
7150 Don't convert scalars to LONGEST.
7155 * valprint.h (print_decimal_chars): Update.
7156 * valprint.c (maybe_negate_by_bytes): New function.
7157 (print_decimal_chars): Add "is_signed" argument.
7158 * printcmd.c (print_scalar_formatted): Update.
7163 * valprint.h (print_binary_chars, print_hex_chars): Update.
7164 * valprint.c (val_print_type_code_int): Update.
7165 (print_binary_chars): Add "zero_pad" argument.
7166 (emit_octal_digit): New function.
7167 (print_octal_chars): Don't zero-pad.
7168 (print_decimal_chars): Likewise.
7169 (print_hex_chars): Add "zero_pad" argument.
7170 * sh64-tdep.c (sh64_do_fp_register): Update.
7171 * regcache.c (regcache::dump): Update.
7172 * printcmd.c (print_scalar_formatted): Update.
7173 * infcmd.c (default_print_one_register_info): Update.
7178 * mips-tdep.c (MAX_MIPS_ABI_REGSIZE): New.
7179 (mips_eabi_push_dummy_call): Rename local 'regsize' to
7180 'abi_regsize'. Rename local array 'valbuf' to 'ref_valbuf', and
7181 use MAX_MIPS_ABI_REGSIZE instead of MAX_REGISTER_SIZE to size it.
7182 Assert that abi_regsize bytes fit in 'ref_valbuf'.
7186 * dwarf2read.c (mapped_symtab::data): Now a vector of
7187 symtab_index_entry instead of vector of
7188 std::unique_ptr<symtab_index_entry>. All users adjusted to check
7189 whether an element's name is NULL instead of checking whether the
7190 element itself is NULL.
7191 (find_slot): Change return type. Adjust.
7192 (hash_expand, , add_index_entry, uniquify_cu_indices)
7193 (write_hash_table): Adjust.
7197 * dwarf2read.c (recursively_count_psymbols): New function.
7198 (write_psymtabs_to_index): Call it to compute number of psyms and
7199 pass estimate size of psyms_seen to unordered_set's ctor.
7203 * dwarf2read.c (write_hash_table): Check if key already exists
7208 * dwarf2read.c (data_buf::append_space): Rename to...
7209 (data_buf::grow): ... this, and make private. Adjust all callers.
7210 (data_buf::append_uint): New method.
7211 (add_address_entry, write_one_signatured_type)
7212 (write_psymtabs_to_index): Use it.
7216 * dwarf2read.c (file_write(FILE *, const void *, size_t)): Delete.
7217 (file_write (FILE *, const std::vector<Elem>&)): Delete.
7218 (data_buf::file_write): Call ::fwrite directly.
7222 * dwarf2read.c (uniquify_cu_indices): Use std::unique and
7227 Code cleanup: C++ify .gdb_index producer.
7228 * dwarf2read.c: Include <unordered_set> and <unordered_map>.
7229 (MAYBE_SWAP) [WORDS_BIGENDIAN]: Cast to offset_type.
7230 (struct strtab_entry, hash_strtab_entry, eq_strtab_entry)
7231 (create_strtab, add_string): Remove.
7232 (file_write, data_buf): New.
7233 (struct symtab_index_entry): Use std::vector for cu_indices.
7234 (struct mapped_symtab): Use std::vector for data.
7235 (hash_symtab_entry, eq_symtab_entry, delete_symtab_entry)
7236 (create_symbol_hash_table, create_mapped_symtab, cleanup_mapped_symtab):
7238 (find_slot): Change return type. Update it to the new data structures.
7239 (hash_expand, add_index_entry): Update it to the new data structures.
7240 (offset_type_compare): Remove.
7241 (uniquify_cu_indices): Update it to the new data structures.
7242 (c_str_view, c_str_view_hasher, vector_hasher): New.
7243 (add_indices_to_cpool): Remove.
7244 (write_hash_table): Update it to the new data structures.
7245 (struct psymtab_cu_index_map, hash_psymtab_cu_index)
7246 (eq_psymtab_cu_index): Remove.
7247 (psym_index_map): New typedef.
7248 (struct addrmap_index_data): Change addr_obstack pointer to data_buf
7249 reference and std::unordered_map for cu_index_htab.
7250 (add_address_entry, add_address_entry_worker, write_address_map)
7251 (write_psymbols): Update it to the new data structures.
7252 (write_obstack): Remove.
7253 (struct signatured_type_index_data): Change types_list to a data_buf
7254 reference and psyms_seen to a std::unordered_set reference.
7255 (write_one_signatured_type, recursively_write_psymbols)
7256 (write_psymtabs_to_index): Update it to the new data structures.
7260 * NEWS (Changes since GDB 8.0): Announce {set,show} debug
7261 separate-debug-file commands.
7262 * symfile.h (separate_debug_file_debug): New global.
7263 * symfile.c (separate_debug_file_debug): New global.
7264 (separate_debug_file_exists, find_separate_debug_file): Add
7266 (_initialize_symfile): Add "set debug separate-debug-file"
7268 * build-id.c (build_id_to_debug_bfd,
7269 find_separate_debug_file_by_buildid): Add debug output.
7273 * gdbarch.sh (displaced_step_free_closure): Remove.
7274 * gdbarch.h, gdbarch.c: Re-generate.
7275 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Don't set
7276 displaced_step_free_closure.
7277 * amd64-linux-tdep.c (amd64_linux_init_abi_common): Likewise.
7278 * arm-linux-tdep.c (arm_linux_init_abi): Likewise.
7279 * i386-linux-tdep.c (i386_linux_init_abi): Likewise.
7280 * rs6000-aix-tdep.c (rs6000_aix_init_osabi): Likewise.
7281 * rs6000-tdep.c (rs6000_gdbarch_init): Likewise.
7282 * s390-linux-tdep.c (s390_gdbarch_init): Likewise.
7283 * arch-utils.h (simple_displaced_step_free_closure): Remove.
7284 * arch-utils.c (simple_displaced_step_free_closure): Remove.
7285 * infrun.c (displaced_step_clear): Call xfree instead of
7286 gdbarch_displaced_step_free_closure.
7290 * common/common-utils.c (stringify_argv): Check for "arg[0] !=
7295 * mn10300-tdep.c (MN10300_MAX_REGISTER_SIZE): Add.
7296 (mn10300_extract_return_value): Use MN10300_MAX_REGISTER_SIZE.
7297 (mn10300_push_dummy_call): Likewise.
7301 * mi/mi-main.c (register_changed_p): Use value_contents_eq.
7305 * mi/mi-main.c (register_changed_p): Use cooked_read_value.
7309 * NEWS (Changes since GDB 8.0): Announce that GDBserver is now
7310 able to start inferiors using a shell.
7311 (New remote packets): Announce new packet "QStartupWithShell".
7312 * remote.c: Add PACKET_QStartupWithShell.
7313 (extended_remote_create_inferior): Handle new
7314 PACKET_QStartupWithShell.
7315 (remote_protocol_features) <QStartupWithShell>: New entry for
7316 PACKET_QStartupWithShell.
7317 (_initialize_remote): Call "add_packet_config_cmd" for
7323 * Makefile.in (HFILES_NO_SRCDIR): Add "common/common-inferior.h"
7324 and "nat/fork-inferior.h".
7325 * common/common-inferior.h: New file, with contents from
7327 * commom/common-utils.c: Include "common-utils.h".
7328 (stringify_argv): New function.
7329 * common/common-utils.h (stringify_argv): New prototype.
7330 * configure.nat: Add "fork-inferior.o" as a dependency for
7331 "*linux*", "fbsd*" and "nbsd*" hosts.
7332 * corefile.c (get_exec_file): Update comment.
7333 * darwin-nat.c (darwin_ptrace_him): Call "gdb_startup_inferior"
7334 instead of "startup_inferior".
7335 (darwin_create_inferior): Call "add_thread_silent" after
7337 * fork-child.c: Cleanup unnecessary includes.
7338 (SHELL_FILE): Move to "common/common-fork-child.c".
7339 (environ): Likewise.
7340 (exec_wrapper): Initialize.
7341 (get_exec_wrapper): New function.
7342 (breakup_args): Move to "common/common-fork-child.c"; rename to
7343 "breakup_args_for_exec".
7344 (escape_bang_in_quoted_argument): Move to
7345 "common/common-fork-child.c".
7346 (saved_ui): New variable.
7347 (prefork_hook): New function.
7348 (postfork_hook): Likewise.
7349 (postfork_child_hook): Likewise.
7350 (gdb_startup_inferior): Likewise.
7351 (fork_inferior): Move to "common/common-fork-child.c". Update
7352 function to support gdbserver.
7353 (startup_inferior): Likewise.
7354 * gdbcore.h (get_exec_file): Remove declaration.
7355 * gnu-nat.c (gnu_create_inferior): Call "gdb_startup_inferior"
7356 instead of "startup_inferior". Call "add_thread_silent" after
7358 * inf-ptrace.c: Include "nat/fork-inferior.h" and "utils.h".
7359 (inf_ptrace_create_inferior): Call "gdb_startup_inferior"
7360 instead of "startup_inferior". Call "add_thread_silent" after
7362 * inferior.h: Include "common-inferior.h".
7363 (trace_start_error): Move to "common/common-utils.h".
7364 (trace_start_error_with_name): Likewise.
7365 (fork_inferior): Move prototype to "nat/fork-inferior.h".
7366 (startup_inferior): Likewise.
7367 (gdb_startup_inferior): New prototype.
7368 * nat/fork-inferior.c: New file, with contents from "fork-child.c".
7369 * nat/fork-inferior.h: New file.
7370 * procfs.c (procfs_init_inferior): Call "gdb_startup_inferior"
7371 instead of "startup_inferior". Call "add_thread_silent" after
7373 * target.h (target_terminal_init): Move prototype to
7375 (target_terminal_inferior): Likewise.
7376 (target_terminal_ours): Likewise.
7377 * target/target.h (target_terminal_init): New prototype, moved
7379 (target_terminal_inferior): Likewise.
7380 (target_terminal_ours): Likewise.
7381 * utils.c (gdb_flush_out_err): New function.
7385 * Makefile.in (HFILES_NO_SRCDIR): Add "common/common-gdbthread.h".
7386 * common/common-gdbthread.h: New file, with parts from
7388 * gdbthread.h: Include "common-gdbthread.h".
7389 (switch_to_thread): Moved to "common/common-gdbthread.h".
7393 * Makefile.in (SFILES): Add "common/job-control.c".
7394 (HFILES_NO_SRCDIR): Add "common/job-control.h".
7395 (COMMON_OBS): Add "job-control.o".
7396 * common/job-control.c: New file, with contents from
7398 * common/job-control.h: New file, with contents from "terminal.h".
7399 * fork-child.c: Include "job-control.h".
7400 * inflow.c: Include "job-control.h".
7401 (gdb_setpgid): Move to "common/common-inflow.c".
7402 (_initialize_inflow): Move setting of "job_control" to
7403 "handle_job_control".
7404 * terminal.h (job_control): Moved to "common/common-terminal.h".
7405 (gdb_setpgid): Likewise.
7406 * top.c: Include "job_control.h".
7407 * utils.c: Likewise.
7408 (job_control): Moved to "job-control.c".
7412 * Makefile.in (SFILES): Add gdb_regex.c.
7413 (COMMON_OBS): Add gdb_regex.o.
7414 * ada-lang.c (ada_add_standard_exceptions)
7415 (ada_add_exceptions_from_frame, name_matches_regex)
7416 (ada_add_global_exceptions, ada_exceptions_list_1): Change regex
7417 parameter type to compiled_regex. Adjust.
7418 (ada_exceptions_list): Use compiled_regex.
7419 * break-catch-throw.c (exception_catchpoint::pattern): Now a
7420 std::unique_ptr<compiled_regex>.
7421 (exception_catchpoint::~exception_catchpoint): Remove regfree
7423 (check_status_exception_catchpoint): Adjust to use compiled_regex.
7424 (handle_gnu_v3_exceptions): Adjust to use compiled_regex.
7425 * breakpoint.c (solib_catchpoint::compiled): Now a
7426 std::unique_ptr<compiled_regex>.
7427 (solib_catchpoint::~solib_catchpoint): Remove regfree call.
7428 (check_status_catch_solib): Adjust to use compiled_regex.
7429 (add_solib_catchpoint): Adjust to use compiled_regex.
7430 * cli/cli-cmds.c (apropos_command): Use compiled_regex.
7431 * cli/cli-decode.c (apropos_cmd): Change regex parameter to
7432 compiled_regex reference. Adjust to use it.
7433 * cli/cli-decode.h: Remove struct re_pattern_buffer forward
7434 declaration. Include "gdb_regex.h".
7435 (apropos_cmd): Change regex parameter to compiled_regex reference.
7436 * gdb_regex.c: New file.
7437 * gdb_regex.h (make_regfree_cleanup, get_regcomp_error): Delete
7439 (class compiled_regex): New.
7440 * linux-tdep.c: Include "common/gdb_optional.h".
7441 (struct mapping_regexes): New, factored out from
7442 mapping_is_anonymous_p, and adjusted to use compiled_regex.
7443 (mapping_is_anonymous_p): Use mapping_regexes wrapped in a
7444 gdb::optional and remove cleanups. Adjust to compiled_regex.
7445 * probe.c: Include "common/gdb_optional.h".
7446 (collect_probes): Use compiled_regex and gdb::optional and remove
7448 * skip.c: Include "common/gdb_optional.h".
7449 (skiplist_entry::compiled_function_regexp): Now a
7450 gdb::optional<compiled_regex>.
7451 (skiplist_entry::compiled_function_regexp_is_valid): Delete field.
7452 (free_skiplist_entry): Remove regfree call.
7453 (compile_skip_regexp, skip_rfunction_p): Adjust to use
7454 compiled_regex and gdb::optional.
7455 * symtab.c: Include "common/gdb_optional.h".
7456 (search_symbols): Use compiled_regex and gdb::optional.
7457 * utils.c (do_regfree_cleanup, make_regfree_cleanup)
7458 (get_regcomp_error, compile_rx_or_error): Delete. Some bits moved
7463 * regcache.c (regcache::save): Avoid buffer use.
7464 (regcache::dump): Likewise.
7468 * sh-tdep.c (sh_pseudo_register_read): Remove
7470 (sh_pseudo_register_write): Likewise.
7471 * sh64-tdep.c (sh64_pseudo_register_read): Likewise.
7472 (sh64_pseudo_register_write): Likewise
7476 * aarch64-tdep.c (aarch64_store_return_value): Use
7478 (aarch64_pseudo_read_value): Likewise.
7479 (aarch64_pseudo_write): Likewise.
7483 * regformats/regdef.h (set_register_cache): Remove the
7488 * frame.c (frame_unwind_register_signed): Use
7489 frame_unwind_register_value.
7493 PR breakpoints/21553
7494 * breakpoint.c (create_breakpoints_sal_default)
7495 (init_breakpoint_sal, create_breakpoint_sal): Use
7496 gdb::unique_xmalloc_ptr for string parameters.
7497 (create_breakpoint): Constify 'extra_string' and 'cond_string'
7498 parameters. Replace cleanups with gdb::unique_xmalloc_ptr.
7499 (base_breakpoint_create_breakpoints_sal)
7500 (bkpt_create_breakpoints_sal, tracepoint_create_breakpoints_sal)
7501 (strace_marker_create_breakpoints_sal)
7502 (create_breakpoints_sal_default): Use gdb::unique_xmalloc_ptr for
7504 * breakpoint.h (breakpoint_ops::create_breakpoints_sal): Use
7505 gdb::unique_xmalloc_ptr for string parameters.
7506 (create_breakpoint): Constify 'extra_string' and 'cond_string'
7511 * alpha-tdep.c (alpha_register_to_value): Use
7512 get_frame_register_value.
7513 (alpha_value_to_register): Use ALPHA_REGISTER_SIZE.
7517 * ia64-tdep.c (IA64_MAX_FP_REGISTER_SIZE) Add.
7518 (ia64_register_to_value): Use IA64_MAX_FP_REGISTER_SIZE.
7519 (ia64_value_to_register): Likewise.
7520 (ia64_extract_return_value): Likewise.
7521 (ia64_store_return_value): Likewise.
7522 (ia64_push_dummy_call): Likewise.
7530 * x86-linux-nat.c (struct arch_lwp_info): Remove.
7534 * linux-nat.c (linux_nat_post_attach_wait): Remove FIRST
7536 (linux_nat_attach): Adjust call to linux_nat_post_attach_wait.
7540 * event-loop.c (poll_timers): Unallocate timer using delete
7545 * breakpoint.h (struct breakpoint_ops) <dtor>: Remove.
7546 (struct breakpoint) <~breakpoint>: New.
7547 (struct watchpoint): Inherit from breakpoint.
7550 (struct tracepoint): Inherit from breakpoint.
7552 * breakpoint.c (longjmp_breakpoint_ops): Remove.
7553 (struct longjmp_breakpoint): Inherit from breakpoint.
7554 <~longjmp_breakpoint>: New.
7556 (new_breakpoint_from_type): Remove casts.
7557 (watchpoint_in_thread_scope): Remove reference to base field.
7558 (watchpoint_del_at_next_stop): Likewise.
7559 (update_watchpoint): Likewise.
7560 (watchpoint_check): Likewise.
7561 (bpstat_check_watchpoint): Likewise.
7562 (set_longjmp_breakpoint): Likewise.
7563 (struct fork_catchpoint): Inherit from breakpoint.
7565 (struct solib_catchpoint): Inherit from breakpoint.
7566 <~solib_catchpoint>: New.
7568 (dtor_catch_solib): Change to ...
7569 (solib_catchpoint::~solib_catchpoint): ... this.
7570 (breakpoint_hit_catch_solib): Remove reference to base field.
7571 (add_solib_catchpoint): Likewise.
7572 (create_fork_vfork_event_catchpoint): Likewise.
7573 (struct exec_catchpoint): Inherit from breakpoint.
7574 <~exec_catchpoint>: New.
7576 (dtor_catch_exec): Change to ...
7577 (exec_catchpoint::~exec_catchpoint): ... this.
7578 (dtor_watchpoint): Change to ...
7579 (watchpoint::~watchpoint): ... this.
7580 (watch_command_1): Remove reference to base field.
7581 (catch_exec_command_1): Likewise.
7582 (base_breakpoint_dtor): Change to ...
7583 (breakpoint::~breakpoint): ... this.
7584 (base_breakpoint_ops): Remove dtor field value.
7585 (longjmp_bkpt_dtor): Change to ...
7586 (longjmp_breakpoint::~longjmp_breakpoint): ... this.
7587 (strace_marker_create_breakpoints_sal): Remove reference to base
7589 (delete_breakpoint): Don't manually call breakpoint destructor.
7590 (create_tracepoint_from_upload): Remove reference to base field.
7591 (trace_pass_set_count): Likewise.
7592 (initialize_breakpoint_ops): Don't initialize
7593 momentary_breakpoint_ops, don't set dtors.
7594 * ada-lang.c (struct ada_catchpoint): Inherit from breakpoint.
7595 <~ada_catchpoint>: New.
7597 (create_excep_cond_exprs): Remove reference to base field.
7598 (dtor_exception): Change to ...
7599 (ada_catchpoint::~ada_catchpoint): ... this.
7600 (dtor_catch_exception): Remove.
7601 (dtor_catch_exception_unhandled): Remove.
7602 (dtor_catch_assert): Remove.
7603 (create_ada_exception_catchpoint): Remove reference to base
7605 (initialize_ada_catchpoint_ops): Don't set dtors.
7606 * break-catch-sig.c (struct signal_catchpoint): Inherit from
7608 <~signal_catchpoint>: New.
7610 (signal_catchpoint_dtor): Change to ...
7611 (signal_catchpoint::~signal_catchpoint): ... this.
7612 (create_signal_catchpoint): Remove reference to base field.
7613 (initialize_signal_catchpoint_ops): Don't set dtor.
7614 * break-catch-syscall.c (struct syscall_catchpoint): Inherit
7616 <~syscall_catchpoint>: New.
7618 (dtor_catch_syscall): Change to ...
7619 (syscall_catchpoint::~syscall_catchpoint): ... this.
7620 (create_syscall_event_catchpoint): Remove reference to base
7622 (initialize_syscall_catchpoint_ops): Don't set dtor.
7623 * break-catch-throw.c (struct exception_catchpoint): Inherit
7625 <~exception_catchpoint>: New.
7627 (dtor_exception_catchpoint): Change to ...
7628 (exception_catchpoint::~exception_catchpoint): ... this.
7629 (handle_gnu_v3_exceptions): Remove reference to base field.
7630 (initialize_throw_catchpoint_ops): Don't set dtor.
7631 * ctf.c (ctf_get_traceframe_address): Remove reference to base
7633 * remote.c (remote_get_tracepoint_status): Likewise.
7634 * tracefile-tfile.c (tfile_get_traceframe_address): Likewise.
7635 * tracefile.c (tracefile_fetch_registers): Likewise.
7636 * tracepoint.c (actions_command): Likewise.
7637 (validate_actionline): Likewise.
7638 (tfind_1): Likewise.
7639 (get_traceframe_location): Likewise.
7640 (find_matching_tracepoint_location): Likewise.
7641 (parse_tracepoint_status): Likewise.
7642 * mi/mi-cmd-break.c (mi_cmd_break_passcount): Likewise.
7646 * breakpoint.c (struct longjmp_breakpoint): New struct.
7647 (is_tracepoint_type): Change return type to bool.
7648 (is_longjmp_type): New function.
7649 (new_breakpoint_from_type): Handle longjmp kinds of breakpoints.
7650 (set_raw_breakpoint_without_location): Use
7651 new_breakpoint_from_type.
7652 (set_raw_breakpoint): Likewise.
7656 * breakpoint.c (new_breakpoint_from_type): New function.
7657 (create_breakpoint_sal): Use new_breakpoint_from_type and
7659 (create_breakpoint): Likewise.
7663 * memattr.c (mem_info_command): Rename to ...
7664 (info_mem_command): ... this.
7665 (mem_enable_command): Rename to ...
7666 (enable_mem_command): ... this.
7667 (mem_disable_command): Rename to ...
7668 (disable_mem_command): ... this.
7669 (mem_delete_command): Rename to ...
7670 (delete_mem_command): ... this.
7671 (_initialize_mem): Adjust function names.
7675 * btrace.c (handle_pt_insn_events): New.
7676 (ftrace_add_pt): Call handle_pt_insn_events. Rename ERRCODE into
7677 STATUS. Split into this and ...
7678 (handle_pt_insn_event_flags): ... this.
7682 * configure.ac: Check for pt_insn_event, struct pt_insn.enabled,
7683 and struct pt_insn.resynced.
7684 * configure: Regenerated.
7685 * config.in: Regenerated.
7689 * btrace.c (ftrace_find_call_by_number): New function.
7690 (ftrace_new_function): Store objects, not pointers.
7691 (ftrace_find_call_by_number, ftrace_new_return, ftrace_new_switch,
7692 ftrace_new_gap, ftrace_update_function,
7693 ftrace_compute_global_level_offset, btrace_stich_bts, btrace_clear,
7694 btrace_insn_get, btrace_insn_get_error, btrace_insn_end,
7695 btrace_insn_next, btrace_insn_prev, ptrace_find_insn_by_number,
7696 btrace_ends_with_single_insn, btrace_call_get): Account for
7697 btrace_thread_info::functions now storing objects.
7698 * btrace.h (struct btrace_thread_info): Add constructor.
7699 (struct btrace_thread_info) <functions>: Make std::vector.
7700 (struct btrace_thread_info) <prev, next, up, insn, errcode, flags):
7701 Initialize with default values.
7702 * record-btrace.c (record_btrace_frame_sniffer): Account for
7703 btrace_thread_info::functions now storing objects.
7707 * btrace.c: Remove typedef bfun_s.
7708 (ftrace_new_gap): Directly add gaps to the list of gaps.
7709 (btrace_bridge_gaps, btrace_compute_ftrace_bts, pt_btrace_insn_flags,
7710 ftrace_add_pt, btrace_compute_ftrace_pt, btrace_compute_ftrace_1,
7711 btrace_finalize_ftrace, btrace_compute_ftrace): Use std::vector
7716 * btrace.c (ftrace_fixup_caller, ftrace_new_return, ftrace_connect_bfun,
7717 ftrace_bridge_gap): Replace references to btrace_thread_info::segment
7718 with btrace_thread_info::next_segment and
7719 btrace_thread_info::prev_segment.
7720 * btrace.h: Remove struct btrace_func_link.
7721 (struct btrace_function): Replace pair of function segment pointers
7722 with pair of indices.
7723 * python/py-record-btrace.c (btpy_call_prev_sibling,
7724 btpy_call_next_sibling): Replace references to
7725 btrace_thread_info::segment with btrace_thread_info::next_segment and
7726 btrace_thread_info::prev_segment.
7727 * record-btrace.c (record_btrace_frame_this_id): Use
7728 btrace_find_call_by_number.
7732 * btrace.c (ftrace_new_function, ftrace_fixup_level,
7733 ftrace_connect_bfun, ftrace_bridge_gap, btrace_bridge_gaps,
7734 btrace_insn_next, btrace_insn_prev): Remove references to
7735 btrace_thread_info::flow.
7736 * btrace.h (struct btrace_function): Remove FLOW.
7740 * btrace.c (ftrace_find_call_by_number): New function.
7741 (ftrace_update_caller, ftrace_new_call, ftrace_new_tailcall,
7742 ftrace_get_caller, ftrace_find_call, ftrace_new_return,
7743 ftrace_match_backtrace, ftrace_connect_bfun, ftrace_connect_backtrace,
7744 ftrace_bridge_gap, btrace_bridge_gaps): Use btrace_function::up as an
7746 * btrace.h (struct btrace_function): Turn UP into an index.
7747 * python/py-record-btrace.c (btpy_call_up): Use btrace_function::up
7749 * record-btrace.c (record_btrace_frame_unwind_stop_reason,
7750 record_btrace_frame_prev_register, record_btrace_frame_sniffer,
7751 record_btrace_tailcall_frame_sniffe): Use btrace_find_call_by_number.
7755 * btrace.c (ftrace_new_function, ftrace_new_call, ftrace_new_tailcall,
7756 ftrace_new_return, ftrace_new_switch, ftrace_new_gap,
7757 ftrace_update_function, ftrace_compute_global_level_offset,
7758 btrace_compute_ftrace_bts, ftrace_add_pt, btrace_compute_ftrace_pt,
7759 btrace_stitch_bts, btrace_fetch, btrace_clear, btrace_insn_number,
7760 btrace_insn_end, btrace_is_empty): Remove references to
7761 btrace_thread_info::begin and btrace_thread_info::end.
7762 * btrace.h (struct btrace_thread_info): Remove BEGIN and END.
7763 (struct btrace_thread_info) <functions>: Adjust comment.
7764 * record-btrace.c (record_btrace_start_replaying): Remove reference to
7765 btrace_thread_info::begin.
7769 * btrace.c (ftrace_new_function, ftrace_new_call, ftrace_new_tailcall,
7770 ftrace_new_return, ftrace_new_switch, ftrace_new_gap,
7771 ftrace_update_function): Remove arguments that implicitly were always
7773 (btrace_compute_ftrace_bts, ftrace_add_pt, btrace_compute_ftrace_pt):
7774 Don't pass BTINFO->END.
7778 * btrace.c: (btrace_insn_get, btrace_insn_get_error, btrace_insn_number,
7779 btrace_insn_begin, btrace_insn_end, btrace_insn_next, btrace_insn_prev,
7780 btrace_find_insn_by_number): Replace function segment pointer with
7782 (btrace_insn_cmp): Simplify.
7783 * btrace.h: (struct btrace_insn_iterator) Rename index to
7784 insn_index. Replace function segment pointer with index into function
7786 * record-btrace.c (record_btrace_call_history): Replace function
7787 segment pointer use with index.
7788 (record_btrace_frame_sniffer): Retrieve function call segment through
7790 (record_btrace_set_replay): Remove defunc't safety check.
7794 * btrace.c (btrace_ends_with_single_insn): New function.
7795 (btrace_call_get, btrace_call_number, btrace_call_begin,
7796 btrace_call_end, btrace_call_next, btrace_call_prev,
7797 btrace_find_call_by_number): Use index into call segment vector
7799 (btrace_call_cmp): Simplify.
7800 * btrace.h (struct btrace_call_iterator): Replace function call segment
7801 pointer with index into vector.
7802 * record-btrace.c (record_btrace_call_history): Use index instead of
7807 * btrace.c (btrace_insn_begin, btrace_insn_end,
7808 btrace_find_insn_by_number): Add btinfo to iterator.
7809 * btrace.h (struct btrace_insn_iterator): Add btinfo.
7813 * btrace.c (ftrace_new_function): Add btrace_thread_info to arguments
7814 and save pointers directly.
7815 (ftrace_new_call, ftrace_new_tailcall, ftrace_new_return,
7816 ftrace_new_switch, ftrace_new_gap, ftrace_update_function,
7817 ftrace_add_pt): Add btrace_thread_info to arguments. Adjust for
7818 changed signature of functions.
7819 (btrace_compute_ftrace_pt): Adjust for changed signature of functions.
7820 (btrace_fetch): Remove code that adds btrace_function pointers to
7821 vector of btrace_functions.
7822 (btrace_clear): Simplify freeing vector of btrace_functions.
7826 * btrace.c (btrace_fetch, btrace_clear, btrace_find_insn_by_number):
7827 Replace VEC_* with std::vector functions.
7828 * btrace.h: Add include: vector. Remove typedef for DEF_VEC_P.
7829 (struct btrace_thread_info)<functions>: Change type to std::vector.
7833 * NEWS (Changes in GDB 8.0): Remove extra empty line. Move
7834 "Removed targets and native configurations" up. Merge duplicate
7835 "New commands" sub-sections. Add "New options" sub-sections.
7839 * defs.h (copy_integer_to_size): New declaration.
7840 * findvar.c (copy_integer_to_size): New function.
7841 (do_cint_test): New selftest function.
7842 (copy_integer_to_size_test): Likewise.
7843 (_initialize_findvar): Likewise.
7844 * mips-fbsd-tdep.c (mips_fbsd_supply_reg): Use raw_supply_integer.
7845 (mips_fbsd_collect_reg): Use raw_collect_integer.
7846 * mips-linux-tdep.c (supply_32bit_reg): Use raw_supply_integer.
7847 (mips64_fill_gregset): Use raw_collect_integer
7848 (mips64_fill_fpregset): Use raw_supply_integer.
7849 * regcache.c (regcache::raw_supply_integer): New function.
7850 (regcache::raw_collect_integer): Likewise.
7851 * regcache.h: (regcache::raw_supply_integer): New declaration.
7852 (regcache::raw_collect_integer): Likewise.
7856 * Makefile.in (SFILES): Add gdbarch-selftests.c.
7857 (COMMON_OBS): Add gdbarch-selftests.o.
7858 * frame.c [GDB_SELF_TESTS] (create_new_frame): New function.
7859 * frame.h [GDB_SELF_TESTS] (create_new_frame): Declare.
7860 * gdbarch-selftests.c: New file.
7861 * regcache.h (regcache) <~regcache>: Mark it virtual if
7863 <raw_write>: Likewise.
7867 * regcache.c (current_regcache): Change it to
7868 regcache::current_regcache.
7869 (regcache_observer_target_changed): Update.
7870 (regcache_thread_ptid_changed): Make it a regcache static
7872 (regcache_thread_ptid_changed): Update.
7873 (class regcache_access): New.
7874 (current_regcache_test): Update.
7875 (_initialize_regcache): Update.
7876 * regcache.h: Include forward_list.
7877 (regcache): Declare regcache_thread_ptid_changed and declare
7878 registers_changed_ptid as friend.
7882 * i387-tdep.c (i387_register_to_value): Use register_size
7883 instead of TYPE_LENGTH.
7884 * m68k-tdep.c (m68k_register_to_value): Likewise.
7888 * i387-tdep.c (i387_convert_register_p): Return false if type
7889 code isn't TYPE_CODE_FLT.
7893 * alpha-tdep.c (alpha_convert_register_p): Return true if type
7895 (alpha_register_to_value): Remove type length check.
7896 (alpha_value_to_register): Likewise.
7900 * ia64-tdep.c (ia64_convert_register_p): Check type's code is
7905 * m68k-tdep.c (m68k_convert_register_p): Check type's code is
7906 TYPE_CODE_FLT or not.
7910 * alpha-tdep.c (alpha_gdbarch_init): Use XCNEW instead of XNEW.
7911 * avr-tdep.c (avr_gdbarch_init): Likewise.
7912 * bfin-tdep.c (bfin_gdbarch_init): Likewise.
7913 * cris-tdep.c (cris_gdbarch_init): Likewise.
7914 * ft32-tdep.c (ft32_gdbarch_init): Likewise.
7915 * lm32-tdep.c (lm32_gdbarch_init): Likewise.
7916 * m32r-tdep.c (m32r_gdbarch_init): Likewise.
7917 * m68hc11-tdep.c (m68hc11_gdbarch_init): Likewise.
7918 * mep-tdep.c (mep_gdbarch_init): Likewise.
7919 * microblaze-tdep.c (microblaze_gdbarch_init): Likewise.
7920 * mips-tdep.c (mips_gdbarch_init): Likewise.
7921 * mn10300-tdep.c (mn10300_gdbarch_init): Likewise.
7922 * moxie-tdep.c (moxie_gdbarch_init): Likewise.
7923 * msp430-tdep.c (msp430_gdbarch_init): Likewise.
7924 * sh64-tdep.c (sh64_gdbarch_init): Likewise.
7925 * v850-tdep.c (v850_gdbarch_init): Likewise.
7929 * selftest-arch.c (tests_with_arch): Call registers_changed
7930 and reinit_frame_cache.
7931 * selftest.c (run_self_tests): Likewise.
7935 * rs6000-tdep.c (gdb_print_insn_powerpc): Remove.
7936 (rs6000_gdbarch_init): Don't call set_gdbarch_print_insn.
7940 * rl78-tdep.c (rl78_gdbarch_init): Don't call
7941 set_gdbarch_print_insn.
7945 * h8300-tdep.c (h8300_gdbarch_init): Don't call
7946 set_gdbarch_print_insn.
7950 * alpha-tdep.c (alpha_gdbarch_init): Don't call
7951 set_gdbarch_print_insn.
7952 * arc-tdep.c (arc_gdbarch_init): Likewise.
7953 * arch-utils.c: include dis-asm.h.
7954 (default_print_insn): New function.
7955 * arch-utils.h (default_print_insn): Declare.
7956 * avr-tdep.c (avr_gdbarch_init): Don't call set_gdbarch_print_insn.
7957 * bfin-tdep.c (bfin_gdbarch_init): Likewise.
7958 * cris-tdep.c (cris_delayed_get_disassembler): Remove.
7959 (cris_gdbarch_init): Don't call set_gdbarch_print_insn.
7960 * frv-tdep.c (frv_gdbarch_init): Likewise.
7961 * ft32-tdep.c (ft32_gdbarch_init): Likewise.
7962 * gdbarch.sh (print_insn): Use default_print_insn.
7963 * gdbarch.c: Regenerated.
7964 * hppa-tdep.c (hppa_gdbarch_init): Likewise.
7965 * iq2000-tdep.c (iq2000_gdbarch_init): Likewise.
7966 * lm32-tdep.c (lm32_gdbarch_init): Likewise.
7967 * m32c-tdep.c (m32c_gdbarch_init): Likewise.
7968 * m32r-tdep.c (m32r_gdbarch_init): Likewise.
7969 * m68hc11-tdep.c (gdb_print_insn_m68hc11): Remove.
7970 (m68hc11_gdbarch_init): Don't call set_gdbarch_print_insn.
7971 * m68k-tdep.c (m68k_gdbarch_init): Likewise.
7972 * m88k-tdep.c (m88k_gdbarch_init): Likewise.
7973 * microblaze-tdep.c (microblaze_gdbarch_init): Likewise.
7974 * mn10300-tdep.c (mn10300_gdbarch_init): Likewise.
7975 * moxie-tdep.c (moxie_gdbarch_init): Likewise.
7976 * msp430-tdep.c (msp430_gdbarch_init): Likewise.
7977 * mt-tdep.c (mt_gdbarch_init): Likewise.
7978 * nds32-tdep.c (nds32_gdbarch_init): Likewise.
7979 * nios2-tdep.c (nios2_print_insn): Remove.
7980 (nios2_gdbarch_init): Don't call set_gdbarch_print_insn.
7981 * rx-tdep.c (rx_gdbarch_init): Likewise.
7982 * s390-linux-tdep.c (s390_gdbarch_init): Likewise.
7983 * score-tdep.c (score_print_insn): Remove.
7984 (score_gdbarch_init): Don't call set_gdbarch_print_insn.
7985 * sh-tdep.c (sh_gdbarch_init): Likewise.
7986 * sh64-tdep.c (sh64_gdbarch_init): Likewise.
7987 * sparc-tdep.c (sparc32_gdbarch_init): Likewise.
7988 * tic6x-tdep.c (tic6x_print_insn): Remove.
7989 (tic6x_gdbarch_init): Don't call set_gdbarch_print_insn.
7990 * tilegx-tdep.c (tilegx_gdbarch_init): Likewise.
7991 * v850-tdep.c (v850_gdbarch_init): Likewise.
7992 * vax-tdep.c (vax_gdbarch_init): Likewise.
7993 * xstormy16-tdep.c (xstormy16_gdbarch_init): Likewise.
7994 * xtensa-tdep.c (xtensa_gdbarch_init): Likewise.
7998 * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove.
7999 (MIPS_FP0_REGNUM): Remove.
8000 (MIPS_FSR_REGNUM): Remove.
8001 (mips_fbsd_supply_fpregs): Use mips_regnum.
8002 (mips_fbsd_supply_gregs): Likewise.
8003 (mips_fbsd_collect_fpregs): Likewise.
8004 (mips_fbsd_collect_gregs): Likewise.
8008 * mips-fbsd-nat.c (getregs_supplies): Fix upper bound comparison.
8009 (getpfpregs_supplies): New function.
8010 (mips_fbsd_fetch_inferior_registers): Remove early exit and use
8012 (mips_fbsd_store_inferior_registers): Likewise.
8016 * MAINTAINERS (Host/Native): Add John Baldwin as FreeBSD
8021 * ppc-linux-nat.c (fetch_register): Use PPC_MAX_REGISTER_SIZE.
8022 (store_register): Likewise.
8023 * ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Likewise.
8024 (get_decimal_float_return_value): Likewise.
8025 (do_ppc_sysv_return_value): Likewise.
8026 (ppc64_sysv_abi_push_integer): Likewise.
8027 (ppc64_sysv_abi_push_freg): Likewise.
8028 (ppc64_sysv_abi_return_value_base): Likewise.
8029 (ppc64_sysv_abi_return_value): Likewise.
8030 * rs6000-aix-tdep.c (rs6000_push_dummy_call): Likewise.
8031 * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Likewise.
8032 * rs6000-nat.c: Likewise.
8033 * rs6000-tdep.c (rs6000_register_to_value): Likewise.
8034 (rs6000_value_to_register): Likewise.
8035 * ppc-tdep.h (PPC_MAX_REGISTER_SIZE): Add.
8040 * rust-lang.c (rust_print_type) <TYPE_CODE_ARRAY>: Print unsized
8041 arrays as "[T]", not "[T; ]".
8046 * rust-lang.c (exp_descriptor_rust): New function.
8047 (rust_language_defn): Use it.
8048 * p-lang.c (pascal_language_defn): Update.
8049 * opencl-lang.c (opencl_language_defn): Update.
8050 * objc-lang.c (objc_language_defn): Update.
8051 * m2-lang.c (m2_language_defn): Update.
8052 * language.h (struct language_defn)
8053 <la_watch_location_expression>: New member.
8054 * language.c (unknown_language_defn, auto_language_defn)
8055 (local_language_defn): Update.
8056 * go-lang.c (go_language_defn): Update.
8057 * f-lang.c (f_language_defn): Update.
8058 * d-lang.c (d_language_defn): Update.
8059 * c-lang.h (c_watch_location_expression): Declare.
8060 * c-lang.c (c_watch_location_expression): New function.
8061 (c_language_defn, cplus_language_defn, asm_language_defn)
8062 (minimal_language_defn): Use it.
8063 * breakpoint.c (watch_command_1): Call
8064 la_watch_location_expression.
8065 * ada-lang.c (ada_language_defn): Update.
8070 * gdb_curses.h (NOMACROS): Define.
8071 (NCURSES_NOMACROS): Define.
8076 * tui/tui-windata.c (tui_erase_data_content): Cast last mvwaddstr
8078 * tui/tui-wingeneral.c (box_win): Likewise.
8079 * tui/tui-winsource.c (tui_erase_source_content): Likewise.
8080 (tui_show_source_line): Likewise.
8081 (tui_show_exec_info_content): Likewise.
8085 * sparc-tdep.c (sparc_structure_return_p)
8086 (sparc_arg_on_registers_p): New functions.
8087 (sparc32_store_arguments): Use them.
8088 * sparc64-tdep.c (sparc64_16_byte_align_p)
8089 (sparc64_store_floating_fields, sparc64_extract_floating_fields):
8090 Handle TYPE_CODE_ARRAY.
8094 * cli/cli-decode.c (add_alias_cmd): New function.
8095 * command.h (add_alias_cmd): Declare.
8096 * infcmd.c (_initialize_infcmd): Don't call add_com_alias,
8097 instead call add_alias_cmd.
8101 * Makefile.in (nat_extra_makefile_frag): Rename to ...
8102 (nat_makefile_frag): ... this. All references updated.
8103 * configure.ac: Likewise.
8104 * configure.nat: Likewise. Enhance comments.
8105 * configure: Regenerate.
8109 * procfs.c (procfs_create_inferior): Change prototype to match
8114 * tui/tui.c (tui_enable): Cast "unknown" to 'char *' to avoid a
8115 C++ compiler warning.
8120 * rust-lang.c (rust_evaluate_subexp) <STRUCTOP_STRUCT>: Don't
8121 recurse, just call value_struct_elt directly.
8125 * rust-lang.c (rust_dump_subexp_body) <STRUCTOP_ANONYMOUS,
8126 OP_RUST_ARRAY>: Fix.
8130 * rust-lang.c (rust_print_subexp): Replace "return" with "break".
8134 * regcache.c: Include <forward_list>.
8135 (struct regcache_list): Remove.
8136 (current_regcache): Update.
8137 (get_thread_arch_aspace_regcache): Update for std::forward_list.
8138 (regcache_thread_ptid_changed): Likewise.
8139 (registers_changed_ptid): Likewise.
8140 (current_regcache_size): Likewise.
8144 * regcache.c [GDB_SELF_TEST]: Include selftest.h.
8145 (current_regcache_size): New function.
8146 (current_regcache_test): New function.
8147 (_initialize_regcache) [GDB_SELF_TEST]: Register the unit test.
8151 * mips-tdep.c (mips_o32_return_value): Remove unused buffer.
8152 (print_gp_register_row): Use get_frame_register_value.
8156 * mips-linux-tdep.c (mips_supply_gregset): Use raw_supply_zeroed.
8157 (mips_supply_fpregset): Likewise.
8158 (mips64_supply_gregset): Likewise.
8162 * mn10300-linux-tdep.c (am33_supply_gregset_method): Use
8163 regcache->raw_supply_zeroed.
8167 * configure.nat: Rearrange 'case' statements to match
8172 * Makefile.in: Remove "@host_makefile_frag@". Add variables
8173 NAT_FILE, NATDEPFILES, NAT_CDEPS, LOADLIBES, MH_CFLAGS, XM_CLIBS,
8174 NAT_GENERATED_FILES, HAVE_NATIVE_GCORE_HOST. Add
8175 "@nat_extra_makefile_frag@".
8176 (Makefile): Remove dependency on "@frags@".
8177 ($(GNULIB_BUILDDIR)/Makefile): Likewise.
8178 (data-directory/Makefile): Likewise.
8179 * config/aarch64/linux.mh: Deleted; moved contents to
8180 "gdb/configure.nat".
8181 * config/alpha/alpha-linux.mh: Likewise.
8182 * config/alpha/nbsd.mh: Likewise.
8183 * config/arm/linux.mh: Likewise.
8184 * config/arm/nbsdelf.mh: Likewise.
8185 * config/i386/cygwin.mh: Likewise.
8186 * config/i386/cygwin64.mh: Likewise.
8187 * config/i386/darwin.mh: Likewise.
8188 * config/i386/fbsd.mh: Likewise.
8189 * config/i386/fbsd64.mh: Likewise.
8190 * config/i386/go32.mh: Likewise.
8191 * config/i386/i386gnu.mh: Likewise.
8192 * config/i386/i386sol2.mh: Likewise.
8193 * config/i386/linux.mh: Likewise.
8194 * config/i386/linux64.mh: Likewise.
8195 * config/i386/mingw.mh: Likewise.
8196 * config/i386/mingw64.mh: Likewise.
8197 * config/i386/nbsd64.mh: Likewise.
8198 * config/i386/nbsdelf.mh: Likewise.
8199 * config/i386/nto.mh: Likewise.
8200 * config/i386/obsd.mh: Likewise.
8201 * config/i386/obsd64.mh: Likewise.
8202 * config/i386/sol2-64.mh: Likewise.
8203 * config/ia64/linux.mh: Likewise.
8204 * config/m32r/linux.mh: Likewise.
8205 * config/m68k/linux.mh: Likewise.
8206 * config/m68k/nbsdelf.mh: Likewise.
8207 * config/m68k/obsd.mh: Likewise.
8208 * config/m88k/obsd.mh: Likewise.
8209 * config/mips/fbsd.mh: Likewise.
8210 * config/mips/linux.mh: Likewise.
8211 * config/mips/nbsd.mh: Likewise.
8212 * config/mips/obsd64.mh: Likewise.
8213 * config/pa/linux.mh: Likewise.
8214 * config/pa/nbsd.mh: Likewise.
8215 * config/pa/obsd.mh: Likewise.
8216 * config/powerpc/aix.mh: Likewise.
8217 * config/powerpc/fbsd.mh: Likewise.
8218 * config/powerpc/linux.mh: Likewise.
8219 * config/powerpc/nbsd.mh: Likewise.
8220 * config/powerpc/obsd.mh: Likewise.
8221 * config/powerpc/ppc64-linux.mh: Likewise.
8222 * config/powerpc/spu-linux.mh: Likewise.
8223 * config/s390/linux.mh: Likewise.
8224 * config/sh/nbsd.mh: Likewise.
8225 * config/sparc/fbsd.mh: Likewise.
8226 * config/sparc/linux.mh: Likewise.
8227 * config/sparc/linux64.mh: Likewise.
8228 * config/sparc/nbsd64.mh: Likewise.
8229 * config/sparc/nbsdelf.mh: Likewise.
8230 * config/sparc/obsd64.mh: Likewise.
8231 * config/sparc/sol2.mh: Likewise.
8232 * config/tilegx/linux.mh: Likewise.
8233 * config/vax/nbsdelf.mh: Likewise.
8234 * config/vax/obsd.mh: Likewise.
8235 * config/xtensa/linux.mh: Likewise.
8236 * config/i386/i386gnu.mn: New file, with excerpts from
8237 "config/i386/i386gnu.mh".
8238 * configure: Regenerate.
8239 * configure.ac: Rewrite code to use "gdb/configure.nat" instead of
8240 *.mh files under "gdb/config".
8241 * configure.nat: New file, with contents from the
8242 "gdb/config/*/*.mh" files.
8246 * btrace.c (btrace_clear): Free insn vector.
8250 * warning.m4 (build_warnings): Add -Wno-error=maybe-uninitialized.
8251 * configure: Regenerate.
8255 * Makefile.in (SFILES): Add progspace-and-thread.c.
8256 (HFILES_NO_SRCDIR): Add progspace-and-thread.h.
8257 (COMMON_OBS): Add progspace-and-thread.o.
8258 * breakpoint.c: Include "progspace-and-thread.h".
8259 (update_inserted_breakpoint_locations)
8260 (insert_breakpoint_locations, create_longjmp_master_breakpoint):
8261 Use scoped_restore_current_pspace_and_thread.
8262 (create_std_terminate_master_breakpoint): Use
8263 scoped_restore_current_program_space.
8264 (remove_breakpoint): Use scoped_restore_current_pspace_and_thread.
8265 (print_breakpoint_location): Use
8266 scoped_restore_current_program_space.
8267 (bp_loc_is_permanent): Use
8268 scoped_restore_current_pspace_and_thread.
8269 (resolve_sal_pc): Use scoped_restore_current_pspace_and_thread.
8270 (download_tracepoint_locations): Use
8271 scoped_restore_current_pspace_and_thread.
8272 (breakpoint_re_set): Use scoped_restore_current_pspace_and_thread.
8273 * exec.c (exec_close_1): Use scoped_restore_current_program_space.
8274 (enum step_over_calls_kind): Moved from inferior.h.
8275 (class scoped_restore_current_thread): New class.
8276 * gdbthread.h (make_cleanup_restore_current_thread): Delete
8278 (scoped_restore_current_thread): New class.
8279 * infcmd.c: Include "common/gdb_optional.h".
8280 (continue_1, proceed_after_attach): Use
8281 scoped_restore_current_thread.
8282 (notice_new_inferior): Use scoped_restore_current_thread.
8283 * inferior.c: Include "progspace-and-thread.h".
8284 (restore_inferior, save_current_inferior): Delete.
8285 (add_inferior_command, clone_inferior_command): Use
8286 scoped_restore_current_pspace_and_thread.
8287 * inferior.h (scoped_restore_current_inferior): New class.
8288 * infrun.c: Include "progspace-and-thread.h" and
8289 "common/gdb_optional.h".
8290 (follow_fork_inferior): Use
8291 scoped_restore_current_pspace_and_thread.
8292 (scoped_restore_exited_inferior): New class.
8293 (handle_vfork_child_exec_or_exit): Use
8294 scoped_restore_exited_inferior,
8295 scoped_restore_current_pspace_and_thread,
8296 scoped_restore_current_thread and scoped_restore.
8297 (fetch_inferior_event): Use scoped_restore_current_thread.
8298 * linespec.c (decode_line_full, decode_line_1): Use
8299 scoped_restore_current_program_space.
8300 * mi/mi-main.c: Include "progspace-and-thread.h".
8301 (exec_continue): Use scoped_restore_current_thread.
8302 (mi_cmd_exec_run): Use scoped_restore_current_pspace_and_thread.
8303 (mi_cmd_trace_frame_collected): Use scoped_restore_current_thread.
8304 * proc-service.c (ps_pglobal_lookup): Use
8305 scoped_restore_current_program_space.
8306 * progspace-and-thread.c: New file.
8307 * progspace-and-thread.h: New file.
8308 * progspace.c (release_program_space, clone_program_space): Use
8309 scoped_restore_current_program_space.
8310 (restore_program_space, save_current_program_space)
8311 (save_current_space_and_thread): Delete.
8312 (switch_to_program_space_and_thread): Moved to
8313 progspace-and-thread.c.
8314 * progspace.h (save_current_program_space)
8315 (save_current_space_and_thread): Delete declarations.
8316 (scoped_restore_current_program_space): New class.
8317 * remote.c (remote_btrace_maybe_reopen): Use
8318 scoped_restore_current_thread.
8319 * symtab.c: Include "progspace-and-thread.h".
8320 (skip_prologue_sal): Use scoped_restore_current_pspace_and_thread.
8321 * thread.c (print_thread_info_1): Use
8322 scoped_restore_current_thread.
8323 (struct current_thread_cleanup): Delete.
8324 (do_restore_current_thread_cleanup)
8325 (restore_current_thread_cleanup_dtor): Rename/convert both to ...
8326 (scoped_restore_current_thread::~scoped_restore_current_thread):
8328 (make_cleanup_restore_current_thread): Rename/convert to ...
8329 (scoped_restore_current_thread::scoped_restore_current_thread):
8331 (thread_apply_all_command): Use scoped_restore_current_thread.
8332 (thread_apply_command): Use scoped_restore_current_thread.
8333 * tracepoint.c (tdump_command): Use scoped_restore_current_thread.
8334 * varobj.c (value_of_root_1): Use scoped_restore_current_thread.
8338 * thread.c (make_cleanup_restore_current_thread): Move
8339 find_thread_ptid call before the is_stopped call. Assert that the
8340 thread is found. Replace is_stopped call by checking the thread's
8341 state directly. Remove unnecessary NULL-thread check.
8345 * corelow.c (thread_section_name): New class.
8346 (get_core_register_section, get_core_siginfo): Use it.
8350 * corelow.c (sniff_core_bfd): Remove extra semicolon.
8351 (get_core_register_section): Remove xfree of NULL pointer.
8355 * frv-linux-tdep.c (frv_linux_supply_gregset): Use raw_supply_zeroed.
8356 * regcache.c (regcache::raw_supply_zeroed): New function.
8357 * regcache.h (regcache::raw_supply_zeroed): New declaration.
8361 * gdbarch.sh: Remove commented out definition of
8363 * gdbarch.h: Re-generate.
8367 * configure: Regenerate.
8371 * solib-target.c (solib_target_relocate_section_addresses):
8372 Remove num_section_bases, num_bases, segment_bases variables.
8376 * common/gdb_vecs.h (DEF_VEC_I (CORE_ADDR)): Remove.
8380 * solib-target.c: Include <vector>
8381 (struct lm_info_target) <~lm_info_target>: Remove.
8382 <segment_bases, section_bases>: Change type to
8383 std::vector<CORE_ADDR>.
8384 (library_list_start_segment, library_list_start_section,
8385 library_list_end_library,
8386 solib_target_relocate_section_addresses): Adjust.
8390 * gdbarch.sh (software_single_step): Change return type to
8391 std::vector<CORE_ADDR>.
8392 * gdbarch.c, gdbarch.h: Re-generate.
8393 * arch/arm-get-next-pcs.c (thumb_deal_with_atomic_sequence_raw):
8395 (arm_deal_with_atomic_sequence_raw): Adjust.
8396 (thumb_get_next_pcs_raw): Adjust.
8397 (arm_get_next_pcs_raw): Adjust.
8398 (arm_get_next_pcs): Adjust.
8399 * arch/arm-get-next-pcs.h (arm_get_next_pcs): Adjust.
8400 * aarch64-tdep.c (aarch64_software_single_step): Adjust.
8401 * alpha-tdep.c (alpha_deal_with_atomic_sequence): Adjust.
8402 (alpha_software_single_step): Adjust.
8403 * alpha-tdep.h (alpha_software_single_step): Adjust.
8404 * arm-linux-tdep.c (arm_linux_software_single_step): Adjust.
8405 * arm-tdep.c (arm_software_single_step): Adjust.
8406 (arm_breakpoint_kind_from_current_state): Adjust.
8407 * arm-tdep.h (arm_software_single_step): Adjust.
8408 * breakpoint.c (insert_single_step_breakpoint): Adjust.
8409 * cris-tdep.c (cris_software_single_step): Adjust.
8410 * mips-tdep.c (mips_deal_with_atomic_sequence): Adjust.
8411 (micromips_deal_with_atomic_sequence): Adjust.
8412 (deal_with_atomic_sequence): Adjust.
8413 (mips_software_single_step): Adjust.
8414 * mips-tdep.h (mips_software_single_step): Adjust.
8415 * moxie-tdep.c (moxie_software_single_step): Adjust.
8416 * nios2-tdep.c (nios2_software_single_step): Adjust.
8417 * ppc-tdep.h (ppc_deal_with_atomic_sequence): Adjust.
8418 * rs6000-aix-tdep.c (rs6000_software_single_step): Adjust.
8419 * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Adjust.
8420 * s390-linux-tdep.c (s390_software_single_step): Adjust.
8421 * sparc-tdep.c (sparc_software_single_step): Adjust.
8422 * spu-tdep.c (spu_software_single_step): Adjust.
8423 * tic6x-tdep.c (tic6x_software_single_step): Adjust.
8427 * gdbarch.sh: Use semi-colon as field separator instead of colon.
8428 * gdbarch.h: Re-generate.
8432 * Makefile.in (SUBDIR_PYTHON_OBS): Add py-instruction.o.
8433 (SUBDIR_PYTHON_SRCS): Add py-instruction.c.
8434 * python/py-instruction.c, python/py-instruction.h: New file.
8435 * python/py-record.c: Add py-instruction.h include.
8436 (gdbpy_initialize_record): Make gdb.Instruction a super class of
8437 gdb.RecordInstruction.
8438 * python/python-internal.h: Add gdbpy_initialize_instruction
8440 * python/python.c (do_start_initialization): Add
8441 gdbpy_initialize_instruction.
8445 * python/py-record-btrace.c (BTPY_REQUIRE_VALID_CALL, btpy_call_type):
8447 (btrace_func_from_recpy_func): New function.
8448 (btpy_call_new, btpy_number, btpy_hash, btpy_richcompare): Remove.
8449 (btpy_call_level, btpy_call_symbol, btpy_call_instructions,
8450 btpy_call_up, btpy_call_prev_sibling, btpy_call_next_sibling): Rename to ...
8451 (recpy_bt_func_level, recpy_bt_func_symbol, recpy_bt_func_instructions,
8452 recpy_bt_func_up, recpy_bt_func_prev, recpy_bt_func_next): This.
8453 Also, use new helper functions.
8454 (btpy_list_item): Use new helper functions.
8455 (recpy_bt_function_call_history): Use new type name.
8456 (btpy_call_getset): Remove.
8457 (gdbpy_initialize_btrace): Remove code to initialize
8458 gdb.BtraceFunctionCall.
8459 * python/py-record-btrace.h (recpy_bt_func_number, recpy_btb_func_level,
8460 recpy_btb_func_symbol, recpy_bt_func_instructions, recpy_bt_func_up,
8461 recpy_bt_func_prev, recpy_bt_func_next): New export.
8462 * python/py-record.c (recpy_func_type): New static object.
8463 (recpy_func_new, recpy_func_level, recpy_func_symbol,
8464 recpy_func_instructions, recpy_func_up, recpy_func_prev,
8465 recpy_func_next): New function.
8466 (recpy_element_hash, recpy_element_richcompare): Updated comment.
8467 (recpy_func_getset): New static object.
8468 (gdbpy_initialize_record): Add code to initialize gdb.RecordInstruction.
8469 * python/py-record.h (recpy_func_type, recpy_func_new): New export.
8473 * python/py-record-btrace.c (BTPY_REQUIRE_VALID_INSN): Remove.
8474 (btpy_object, btpy_insn_type, btpy_new): Remove.
8475 (btpy_list_object): Use gdb.RecordInstruction type instead of
8476 gdb.BtraceInstruction type.
8477 (btrace_insn_from_recpy_insn): New function.
8478 (btpy_insn_or_gap_new): Adjust comment. Use recpy_insn_new instead of
8480 (btpy_call_new, btpy_list_item): Do not use btpy_new anymore.
8481 (btpy_number, btpy_hash, btpy_call_level, btpy_call_symbol,
8482 btpy_call_instructions, btpy_call_up, btpy_call_prev_sibling,
8483 btpy_call_next_sibling, btpy_richcompare): Use recpy_element_object
8484 instead of btpy_object.
8485 (btpy_insn_sal, btpy_insn_pc, btpy_insn_size, btpy_insn_is_speculative,
8486 btpy_insn_data, btpy_insn_decode): Rename to ...
8487 (recpy_bt_insn_sal, recpy_bt_insn_pc, recpy_bt_insn_size,
8488 recpy_bt_insn_is_speculative, recpy_bt_insn_data,
8489 recpy_bt_insn_decode): This. Also, use new helper functions.
8490 (btpy_list_position, recpy_bt_goto): Use recpy_element_object and
8492 (btpy_insn_getset): Remove.
8493 (gdbpy_initialize_btrace): Remove code to initialize
8494 gdb.BtraceInstruction. Use recpy_element_object.
8495 * python/py-record-btrace.h (recpy_bt_insn_number, recpy_bt_insn_sal,
8496 recpy_bt_insn_pc, recpy_bt_insn_data, recpy_bt_insn_decoded,
8497 recpy_bt_insn_size, recpy_bt_insn_is_speculative): New export.
8498 * python/py-record.c (recpy_insn_type): New static object.
8499 (recpy_insn_new, recpy_insn_sal, recpy_insn_pc, recpy_insn_data,
8500 recpy_insn_decoded, recpy_insn_size, recpy_insn_is_speculative,
8501 recpy_element_number, recpy_element_hash, recpy_element_richcompare):
8503 (recpy_insn_getset): New static object.
8504 (gdbpy_initialize_record): Initialize gdb.RecordInstruction.
8505 * python/py-record.h (recpy_element_object): New typedef.
8506 (recpy_insn_type, recpy_insn_new): New export.
8510 * py-record-btrace.c (btpy_insn_new): Removed.
8511 (btpy_insn_or_gap_new): New function.
8512 (btpy_insn_error): Removed.
8513 (btpy_insn_sal, btpy_insn_pc, btpy_insn_size, btpy_insn_is_speculative,
8514 btpy_insn_data, btpy_insn_decode): Remove code path for gaps.
8515 (recpy_bt_replay_position, recpy_bt_begin, recpy_bt_end): Call
8516 btpy_insn_or_gap_new instead of btpy_insn_new.
8517 (btpy_insn_getset): Remove btpy_insn_error.
8518 * py-record.c (recpy_gap_type): New static object.
8519 (recpy_gap_object): New typedef.
8520 (recpy_gap_new, recpy_gap_number, recpy_gap_reason_code,
8521 recpy_gap_reason_string): New function.
8522 (recpy_gap_getset): New static object.
8523 (gdbpy_initialize_record): Initialize gdb.RecordGap type.
8524 * py-record.h (recpy_gap_new): New export.
8528 * python/py-record.c (recpy_ptid): Remove.
8529 (recpy_record_getset): Remove recpy_ptid.
8533 * btrace.c (btrace_fetch): Set inferior_ptid.
8534 * python/py-record-btrace.c: Add "py-record.h" include.
8535 (recpy_bt_format, recpy_bt_replay_position, recpy_bt_begin,
8536 recpy_bt_end, recpy_bt_instruction_history,
8537 recpy_bt_function_call_history, recpy_bt_goto): Use ptid stored
8538 in gdb.Record object instead of current ptid.
8539 * python/py-record.c: Include new "py-record.h" file.
8540 (recpy_record_object): Moved to py-record.h.
8541 * python/py-record.h: New file.
8545 * python/py-record-btrace.c (BTPY_REQUIRE_VALID_INSN,
8546 BTPY_REQUIRE_VALID_CALL, recpy_bt_function_call_history): Fix
8551 * MAINTAINERS: Move Daniel Jacobowitz and Mark Kettenis to
8552 the past maintainers section.
8556 * infcmd.c (get_return_value): Use regcache ctor, and remove
8562 * regcache.c (regcache::regcache): New tag dispatch ctor.
8563 (do_cooked_read): Moved above.
8564 (regcache_dup): Use the tag dispatch ctor..
8565 * regcache.h (regcache): Declare ctor, delete copy ctor and
8566 assignment operator, remove friend regcache_dup.
8570 * regcache.c (regcache_dup): Assert !src->m_readonly_p and
8571 call method save instead of regcache_cpy.
8572 * regcache.h (struct regcache): Make regcache_dup a friend.
8576 * regcache.c (struct regcache): Move to regcache.h
8577 (regcache::arch): New method.
8578 (regcache_get_ptid): Update.
8579 (get_regcache_arch): Call arch method.
8580 (get_regcache_aspace): Call method aspace.
8581 (register_buffer): Change it to method.
8582 (regcache_save): Change it to regcache::save.
8583 (regcache_restore): Likewise.
8584 (regcache_cpy_no_passthrough): Remove the declaration.
8585 (regcache_cpy): Call methods restore and cpy_no_passthrough.
8586 (regcache_cpy_no_passthrough): Change it to method
8588 (regcache_register_status): Change it to method
8589 get_register_status.
8590 (regcache_invalidate): Change it to method invalidate.
8591 (regcache_thread_ptid_changed): Use methods ptid and set_ptid.
8592 (regcache_raw_update): Change it to method raw_update.
8593 (regcache_raw_read): Likewise.
8594 (regcache_raw_read_signed): Likewise.
8595 (regcache_raw_read_unsigned): Likewise.
8596 (regcache_raw_write_signed): Likewise.
8597 (regcache_raw_write_unsigned): Likewise.
8598 (regcache_cooked_read): Likewise.
8599 (regcache_cooked_read_value): Likewise.
8600 (regcache_cooked_read_signed): Likewise.
8601 (regcache_cooked_read_unsigned): Likewise.
8602 (regcache_cooked_write_signed): Likewise.
8603 (regcache_cooked_write_unsigned): Likewise.
8604 (regcache_raw_set_cached_value): Likewise.
8605 (regcache_raw_write): Likewise.
8606 (regcache_cooked_write): Likewise.
8607 (regcache_xfer_part): Likewise.
8608 (regcache_raw_read_part): Likewise.
8609 (regcache_raw_write_part): Likewise.
8610 (regcache_cooked_read_part): Likewise.
8611 (regcache_cooked_write_part): Likewise.
8612 (regcache_raw_supply): Likewise.
8613 (regcache_raw_collect): Likewise.
8614 (regcache_transfer_regset): Likewise.
8615 (regcache_supply_regset): Likewise.
8616 (regcache_collect_regset): Likewise.
8617 (regcache_debug_print_register): Likewise.
8618 (enum regcache_dump_what): Move it to regcache.h.
8619 (regcache_dump): Change it to method dump.
8620 * regcache.h (enum regcache_dump_what): New.
8621 (class regcache): New.
8622 * target.c (target_fetch_registers): Call method
8623 debug_print_register.
8624 (target_store_registers): Likewise.
8628 * windows-nat.c (struct lm_info_windows): Initialize field.
8629 (windows_make_so): Allocate lm_info_windows with new.
8630 (windows_free_so): Free lm_info_windows with delete.
8634 * solib-darwin.c (struct lm_info_darwin): Initialize field.
8635 (darwin_current_sos): Allocate lm_info_darwin with new, remove
8637 (darwin_free_so): Free lm_info_darwin with delete.
8641 * solib-svr4.h (struct lm_info_svr4): Initialize fields.
8642 <l_addr_p>: Change type to bool.
8643 * solib-svr4.c (lm_info_read): Allocate lm_info_svr4 with new.
8644 (svr4_free_so): Free lm_info_svr4 with delete.
8645 (svr4_copy_library_list): Replace memcpy with call to copy
8647 (library_list_start_library, svr4_default_sos): Allocate
8648 lm_info_svr4 with new.
8652 * solib-target.c (struct lm_info_target): Add destructor,
8654 <name>: Change type to std::string.
8655 (library_list_start_library): Allocate lm_info_target with new.
8656 (solib_target_free_library_list): Free lm_info_target with
8658 (solib_target_current_sos): Adapt to std::string.
8659 (solib_target_free_so): Free lm_info_target with delete.
8663 * solib-frv.c (struct lm_info_frv): Add destructor, initialize
8665 (frv_current_sos): Allocate lm_info_frv with new.
8666 (frv_relocate_main_executable): Free lm_info_frv with delete,
8668 (frv_clear_solib, frv_free_so): Free lm_info_frv with delete.
8672 * solib-frv.c (struct lm_info_frv): Fix indentation.
8676 * solib-dsbt.c (struct lm_info_dsbt): Add destructor, initialize
8678 (dsbt_current_sos): Allocate lm_info_dsbt with new.
8679 (dsbt_relocate_main_executable): Free lm_info_dsbt with delete
8680 and allocate with new.
8681 (dsbt_clear_solib, dsbt_free_so): Free lm_info_dsbt with delete.
8685 * solib-aix.c (struct lm_info_aix): Initialize fields in-class.
8686 <filename, member_name>: Change type to std::string.
8687 (solib_aix_new_lm_info, solib_aix_xfree_lm_info): Remove.
8688 (library_list_start_library): Allocate lm_info_aix with new.
8689 (solib_aix_free_library_list, solib_aix_free_so): Free with delete.
8690 (solib_aix_current_sos): Adapt to std::string, copy lm_info_aix
8691 with copy constructor.
8695 * solist.h (struct lm_info): Remove.
8696 (struct lm_info_base): New class.
8697 (struct so_list) <lm_info>: Change type to lm_info_base *.
8698 * nto-tdep.c (struct lm_info): Remove.
8700 * solib-aix.c (struct lm_info): Rename to ...
8701 (struct lm_info_aix): ... this. Extend lm_info_base.
8702 (lm_info_p): Rename to ...
8703 (lm_info_aix_p): ... this, and adjust.
8704 (solib_aix_new_lm_info, solib_aix_xfree_lm_info,
8705 solib_aix_parse_libraries, library_list_start_library,
8706 solib_aix_free_library_list, solib_aix_parse_libraries,
8707 solib_aix_get_library_list,
8708 solib_aix_relocate_section_addresses, solib_aix_free_so,
8709 solib_aix_get_section_offsets,
8710 solib_aix_solib_create_inferior_hook, solib_aix_current_sos):
8712 (struct solib_aix_inferior_data) <library_list>: Adjust.
8713 * solib-darwin.c (struct lm_info): Rename to ...
8714 (struct lm_info_darwin): ... this. Extend lm_info_base.
8715 (darwin_current_sos, darwin_relocate_section_addresses): Adjust.
8716 * solib-dsbt.c (struct lm_info): Rename to ...
8717 (struct lm_info_dsbt): ... this. Extend lm_info_base.
8718 (struct dsbt_info) <main_executable_lm_info): Adjust.
8719 (dsbt_current_sos, dsbt_relocate_main_executable, dsbt_free_so,
8720 dsbt_relocate_section_addresses): Adjust.
8721 * solib-frv.c (struct lm_info): Rename to ...
8722 (struct lm_info_frv): ... this. Extend lm_info_base.
8723 (main_executable_lm_info): Adjust.
8724 (frv_current_sos, frv_relocate_main_executable, frv_free_so,
8725 frv_relocate_section_addresses, frv_fdpic_find_global_pointer,
8726 find_canonical_descriptor_in_load_object,
8727 frv_fdpic_find_canonical_descriptor): Adjust.
8728 * solib-svr4.c (struct lm_info): Move to solib-svr4.h, renamed
8730 (lm_info_read, lm_addr_check, svr4_keep_data_in_core,
8731 svr4_clear_so, svr4_copy_library_list,
8732 library_list_start_library, svr4_default_sos, svr4_read_so_list,
8733 svr4_current_sos, svr4_fetch_objfile_link_map,
8734 solist_update_incremental): Adjust.
8735 * solib-svr4.h (struct lm_info_svr4): Move here from
8737 * solib-target.c (struct lm_info): Rename to ...
8738 (struct lm_info_target): ... this. Extend lm_info_base.
8739 (lm_info_p): Rename to ...
8740 (lm_info_target_p): ... this.
8741 (solib_target_parse_libraries, library_list_start_segment,
8742 library_list_start_section, library_list_start_library,
8743 library_list_end_library, solib_target_free_library_list,
8744 solib_target_current_sos, solib_target_free_so,
8745 solib_target_relocate_section_addresses): Adjust.
8746 * windows-nat.c (struct lm_info): Rename to ...
8747 (struct lm_info_windows): ... this. Extend lm_info_base.
8748 (windows_make_so, handle_load_dll, handle_unload_dll,
8749 windows_xfer_shared_libraries): Adjust.
8753 * solib-darwin.c (struct darwin_so_list): Remove.
8754 (darwin_current_sos): Allocate an so_list object instead of a
8755 darwin_so_list, separately allocate an lm_info object.
8756 (darwin_free_so): Free lm_info.
8760 * mips-tdep.c (print_gp_register_row): Replace printf_filtered
8761 with fprintf_filtered.
8765 * regcache.c (regcache::regcache): New function.
8766 (regcache::~regcache): New function.
8767 (regcache_xmalloc_1): Remove.
8768 (regcache_xmalloc): Call new regcache.
8769 (regcache_xfree): Call delete regcache.
8770 (get_thread_arch_aspace_regcache): Call new regcache.
8774 * mips-linux-nat.c (mips_linux_new_thread): Use ptid method
8775 lwp instead of ptid_get_lwp.
8779 * mips-linux-nat.c (mips_linux_new_thread): Get lwpid from
8780 lwp_info instead of getting from inferior_ptid.
8784 * gdbtypes.c (LVALUE_REFERENCE_TO_RVALUE_BINDING_BADNESS)
8785 DIFFERENT_REFERENCE_TYPE_BADNESS): Remove.
8786 (CV_CONVERSION_BADNESS): Define.
8787 (rank_one_type): Remove overly restrictive rvalue reference
8789 Add cv-qualifier checks and subranks for type equality.
8790 * gdbtypes.h (REFERENCE_CONVERSION_RVALUE,
8791 REFERENCE_CONVERSION_CONST_LVALUE, CV_CONVERSION_BADNESS,
8792 CV_CONVERSION_CONST, CV_CONVERSION_VOLATILE): Declare.
8796 * python/py-inferior.c (inferior_to_inferior_object): Increment reference
8797 count when creating the object.
8802 * xcoffread.c (read_xcoff_symtab): Read correct function auxiliary
8803 entry if xlc -qfuncsect or gcc -ffunction-sections compiler option
8805 (read_xcoff_symtab): Handle C_WEAKEXT storage class.
8806 (process_xcoff_symbol): Likewise.
8807 (scan_xcoff_symtab): Likewise.
8811 * ia64-tdep.c (examine_prologue): Use get_frame_register_unsigned.
8812 (ia64_sigtramp_frame_prev_register): Use read_memory_unsigned_integer.
8813 (ia64_access_reg): Use get_frame_register_unsigned.
8814 (ia64_access_rse_reg): Likewise.
8815 (ia64_libunwind_frame_prev_register): Likewise.
8819 * gdbarch.sh: New gdbarch method execute_dwarf_cfa_vendor_op.
8820 * gdbarch.c: Regenerated.
8821 * gdbarch.h: Regenerated.
8822 * dwarf2-frame.c (dwarf2_frame_state_alloc_regs): Made the
8823 visibility external.
8824 (execute_cfa_program): Call execute_dwarf_cfa_vendor_op for CFI
8825 between DW_CFA_lo_user and DW_CFA_high_user inclusive.
8826 (enum cfa_how_kind): Move to ...
8827 (struct dwarf2_frame_state_reg_info): Likewise.
8828 (struct dwarf2_frame_state): Likewise.
8829 * dwarf2-frame.h: ... here.
8830 (dwarf2_frame_state_alloc_regs): New declaration.
8831 * sparc-tdep.c (sparc_execute_dwarf_cfa_vendor_op): New function.
8832 (sparc32_gdbarch_init): Register execute_dwarf_cfa_vendor_op hook.
8836 * xtensa-tdep.c (xtensa_pseudo_register_read): Use
8837 regcache_raw_read_unsigned.
8838 (xtensa_pseudo_register_write): Likewise.
8842 * nds32-tdep.c (nds32_pseudo_register_read): Abort on errors.
8843 (nds32_pseudo_register_write): Likewise.
8847 * regcache.c (struct regcache) <readonly_p>: Change its type
8849 (regcache_xmalloc_1): Update parameter type and callers update.
8853 * aarch64-tdep.c (aarch64_gdbarch_init): Don't call
8854 set_gdbarch_wchar_bit.
8855 * arm-tdep.c (arm_gdbarch_init): Likewise.
8859 * common/poison.h [!HAVE_IS_TRIVIALLY_COPYABLE] (IsRelocatable)
8860 (BothAreRelocatable, memcopy, memmove): Don't define.
8861 * common/traits.h (__has_feature, HAVE_IS_TRIVIALLY_COPYABLE): New
8866 * common/common-defs.h: Include "common/poison.h".
8867 * common/function-view.h: (Not, Or, Requires): Move to traits.h
8869 * common/poison.h: New file.
8870 * common/traits.h: Include <type_traits>.
8871 (Not, Or, Requires): New, moved from common/function-view.h.
8875 * breakpoint.h (struct breakpoint): In-class initialize all
8876 fields. Make boolean fields "bool".
8877 * breakpoint.c (init_raw_breakpoint_without_location): Remove
8878 memset call and initializations no longer necessary.
8882 * btrace.c (pt_btrace_insn_flags): Change parameter type to
8884 (pt_btrace_insn): New function.
8885 (ftrace_add_pt): Remove memset call and use pt_btrace_insn.
8889 * ada-lang.c (ada_catchpoint_location): Now a "class". Remove
8890 "base" field and inherit from "bp_location" instead. Add
8892 (allocate_location_exception): Use new non-default ctor.
8893 * breakpoint.c (get_first_locp_gte_addr): Remove memset call.
8894 (init_bp_location): Convert to ...
8895 (bp_location::bp_location): ... this new ctor, and remove memset
8897 (base_breakpoint_allocate_location): Use the new non-default ctor.
8898 * breakpoint.h (bp_location): Now a class. Declare default and
8899 non-default ctors. In-class initialize all members.
8900 (init_bp_location): Remove declaration.
8904 * common/enum-flags.h (enum_flags): Don't implement copy ctor and
8905 assignment operator.
8909 * doublest.c (convert_doublest_to_floatformat): Call
8910 floatformat_totalsize_bytes.
8914 * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Use
8916 * stack.c (print_frame): Use ui_out_emit_list.
8917 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Use
8919 * mi/mi-main.c (print_one_inferior)
8920 (mi_cmd_data_list_register_names)
8921 (mi_cmd_data_list_register_values, mi_cmd_list_features)
8922 (mi_cmd_list_target_features, mi_cmd_trace_frame_collected): Use
8924 * mi/mi-interp.c (mi_on_normal_stop_1): Use ui_out_emit_list.
8925 (mi_output_solib_attribs): Use ui_out_emit_list,
8927 * mi/mi-cmd-var.c (varobj_update_one): Use ui_out_emit_list.
8928 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8929 (mi_cmd_stack_list_args, list_args_or_locals): Use
8931 * disasm.c (do_assembly_only): Use ui_out_emit_list.
8932 * breakpoint.c (print_solib_event, output_thread_groups): Use
8937 * mi/mi-main.c (print_variable_or_computed): Use ui_out_emit_tuple.
8938 * mi/mi-cmd-var.c (varobj_update_one): Use ui_out_emit_tuple.
8939 * mi/mi-cmd-stack.c (list_arg_or_local): Use ui_out_emit_tuple.
8943 * tracepoint.c (tvariables_info_1)
8944 (print_one_static_tracepoint_marker): Use ui_out_emit_tuple.
8948 * stack.c (print_frame_arg): Use ui_out_emit_tuple,
8949 annotate_arg_emitter.
8950 * breakpoint.c (print_mention_watchpoint)
8951 (print_mention_masked_watchpoint): Use ui_out_emit_tuple.
8952 * annotate.h (struct annotate_arg_emitter): New.
8956 * record-btrace.c (record_btrace_insn_history)
8957 (record_btrace_insn_history_range, record_btrace_call_history)
8958 (record_btrace_call_history_range): Use ui_out_emit_tuple.
8959 * thread.c (do_captured_list_thread_ids, print_thread_info_1): Use
8961 * stack.c (print_frame_info): Use ui_out_emit_tuple.
8962 * solib.c (info_sharedlibrary_command): Use ui_out_emit_tuple.
8963 * skip.c (skip_info): Use ui_out_emit_tuple.
8964 * remote.c (show_remote_cmd): Use ui_out_emit_tuple.
8965 * progspace.c (print_program_space): Use ui_out_emit_tuple.
8966 * probe.c (info_probes_for_ops): Use ui_out_emit_tuple.
8967 * osdata.c (info_osdata): Use ui_out_emit_tuple.
8968 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Use
8970 * mi/mi-main.c (print_one_inferior, list_available_thread_groups)
8971 (output_register, mi_cmd_data_read_memory)
8972 (mi_cmd_data_read_memory_bytes, mi_load_progress)
8973 (mi_cmd_trace_frame_collected): Use ui_out_emit_tuple.
8974 * mi/mi-cmd-var.c (mi_cmd_var_list_children, varobj_update_one):
8975 Use ui_out_emit_tuple.
8976 * mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Use
8978 * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions)
8979 (mi_cmd_info_gdb_mi_command): Use ui_out_emit_tuple.
8980 * linux-thread-db.c (info_auto_load_libthread_db): Use
8982 * inferior.c (print_inferior): Use ui_out_emit_tuple.
8983 * gdb_bfd.c (print_one_bfd): Use ui_out_emit_tuple.
8984 * disasm.c (do_mixed_source_and_assembly_deprecated)
8985 (do_mixed_source_and_assembly): Use ui_out_emit_tuple.
8986 * cp-abi.c (list_cp_abis): Use ui_out_emit_tuple.
8987 * cli/cli-setshow.c (cmd_show_list): Use ui_out_emit_tuple.
8988 * breakpoint.c (print_one_breakpoint_location)
8989 (print_one_breakpoint): Use ui_out_emit_tuple.
8990 * auto-load.c (print_script, info_auto_load_cmd): Use
8992 * ada-tasks.c (print_ada_task_info): Use ui_out_emit_tuple.
8996 * thread.c (print_thread_info_1): Remove dead code.
9000 * aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if
9002 * arm-tdep.c (selftests::arm_record_test): Likewise.
9006 * regcache.c (regcache_restore): Remove argument 2. Replace
9007 argument 3 with regcache. Get register status from
9008 src->register_status and get register contents from
9009 register_buffer (src, regnum).
9010 (regcache_cpy): Update.
9014 * gdbthread.h (thread): Add missing closing parenthesis in
9019 * common/refcounted-object.h: New file.
9020 * gdbthread.h: Include "common/refcounted-object.h".
9021 (thread_info): Inherit from refcounted_object and add comments.
9022 (thread_info::incref, thread_info::decref)
9023 (thread_info::m_refcount): Delete.
9024 (thread_info::deletable): Use the refcounted_object::refcount()
9026 * inferior.c (current_inferior_): Add comment.
9027 (set_current_inferior): Increment/decrement refcounts.
9028 (prune_inferiors, remove_inferior_command): Skip inferiors marked
9029 not-deletable instead of comparing with the current inferior.
9030 (initialize_inferiors): Increment the initial inferior's refcount.
9031 * inferior.h (struct inferior): Forward declare.
9032 Include "common/refcounted-object.h".
9033 (current_inferior, set_current_inferior): Move declaration to
9034 before struct inferior's definition, and fix comment.
9035 (inferior): Inherit from refcounted_object. Add comments.
9036 * thread.c (switch_to_thread_no_regs): Reference the thread's
9037 inferior pointer directly instead of doing a ptid lookup.
9038 (switch_to_no_thread): New function.
9039 (switch_to_thread(thread_info *)): New function, factored out
9041 (switch_to_thread(ptid_t)): ... this.
9042 (restore_current_thread): Delete.
9043 (current_thread_cleanup): Remove 'inf_id' and 'was_removable'
9044 fields, and add 'inf' field.
9045 (do_restore_current_thread_cleanup): Check whether old->inf is
9046 alive instead of looking up an inferior by ptid. Use
9047 switch_to_thread and switch_to_no_thread.
9048 (restore_current_thread_cleanup_dtor): Use old->inf directly
9049 instead of lookup up an inferior by id. Decref the inferior.
9050 Don't restore 'removable'.
9051 (make_cleanup_restore_current_thread): Same the inferior pointer
9052 in old, instead of the inferior number. Incref the inferior.
9053 Don't save/clear 'removable'.
9057 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9058 unittests/scoped_restore-selftests.c.
9059 (SUBDIR_UNITTESTS_OBS): Add scoped_restore-selftests.o.
9060 * common/scoped_restore.h (scoped_restore_base): Make "class".
9061 (scoped_restore_base::release): New public method.
9062 (scoped_restore_base::scoped_restore_base): New protected ctor.
9063 (scoped_restore_base::m_saved_var): New protected field.
9064 (scoped_restore_tmpl::scoped_restore_tmpl(T*)): Initialize the
9065 scoped_restore_base base class instead of m_saved_var directly.
9066 (scoped_restore_tmpl::scoped_restore_tmpl(T*, T2)): Likewise.
9067 (scoped_restore_tmpl::scoped_restore_tmpl(const
9068 scoped_restore_tmpl<T>&)): Likewise.
9069 (scoped_restore_tmpl::~scoped_restore_tmpl): Use the saved_var
9071 (scoped_restore_tmpl::saved_var): New method.
9072 (scoped_restore_tmpl::m_saved_var): Delete.
9073 * inferior.h (inferior::detaching): Now a bool.
9074 * infrun.c (prepare_for_detach): Use a scoped_restore instead of a
9076 * unittests/scoped_restore-selftests.c: New file.
9080 * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS):
9081 Re-sort in alphabetic order.
9085 * xml-support.c (obstack_xml_printf): Delete.
9086 * xml-support.h (obstack_xml_printf): Delete.
9090 * xml-support.c (gdb_xml_parser) <use_dtd, dtd_name, parse,
9091 vdebug, verror, body_text, start_element, end_element, name,
9092 user_data, set_is_xinclude, set_error, expat_parser>: New methods.
9093 <name, user_data, expat_parser, scopes, error, last_line, dtd_name,
9094 is_xinclude>: Make private and add m_ prefix.
9095 (gdb_xml_parser::body_text): New method, based on ...
9096 (gdb_xml_body_text): ... this. Adjust.
9097 (gdb_xml_parser::vdebug): New method, based on ...
9098 (gdb_xml_debug): ... this. Adjust.
9099 (gdb_xml_parser::verror): New method, based on ...
9100 (gdb_xml_error): ... this. Adjust.
9101 (gdb_xml_parser::start_element): New method, based on ...
9102 (gdb_xml_start_element): ... this. Adjust.
9103 (gdb_xml_start_element_wrapper): Defer to
9104 gdb_xml_parser::start_element and gdb_xml_parser::set_error.
9105 (gdb_xml_parser::end_element): New method, based on ...
9106 (gdb_xml_end_element_wrapper): ... this. Adjust.
9107 (gdb_xml_parser::~gdb_xml_parser): Adjust.
9108 (gdb_xml_parser::gdb_xml_parser): Adjust to field renames.
9109 (gdb_xml_parser::use_dtd): New method, based on ...
9110 (gdb_xml_use_dtd): ... this. Adjust.
9111 (gdb_xml_parser::parse): New method, based on ...
9112 (gdb_xml_parse): ... this. Adjust.
9113 (gdb_xml_parse_quick): Adjust to call the parser's parse method.
9114 (xinclude_start_include): Adjust to call the parser's name method.
9115 (xml_xinclude_default, xml_xinclude_start_doctype)
9116 (xml_xinclude_end_doctype): Adjust to call the parser's user_data
9118 (xml_process_xincludes): Adjust to call parser methods.
9119 * xml-support.h (gdb_xml_use_dtd, gdb_xml_parse): Delete
9124 * tracefile-tfile.c (tfile_write_tdesc): Adjust to use
9125 gdb::optional<std::string>.
9126 * xml-support.c: Include <string>.
9127 (scope_level::scope_level(scope_level &&))
9128 (scope_level::~scope_level): Delete.
9129 (scope_level::body): Now a std::string.
9130 (gdb_xml_body_text, gdb_xml_end_element): Adjust.
9131 (xinclude_parsing_data::xinclude_parsing_data): Add 'output'
9133 (xinclude_parsing_data::~xinclude_parsing_data): Delete.
9134 (xinclude_parsing_data::output): Now a std::string reference.
9135 (xinclude_start_include): Adjust.
9136 (xml_xinclude_default): Adjust.
9137 (xml_process_xincludes): Add 'output' parameter, and return bool.
9138 * xml-support.h (xml_process_xincludes): Add 'output' parameter,
9140 * xml-tdesc.c: Include <unordered_map> and <string>.
9141 (tdesc_xml_cache): Delete.
9142 (tdesc_xml_cache_s): Delete.
9143 (xml_cache): Now an std::unordered_map.
9144 (tdesc_parse_xml): Adjust to use std::string and unordered_map.
9145 (target_fetch_description_xml): Change return type to
9146 gdb::optional<std::string>, and adjust.
9147 * xml-tdesc.h: Include "common/gdb_optional.h" and <string>.
9148 (target_fetch_description_xml): Change return type to
9149 gdb::optional<std::string>.
9153 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9154 unittests/optional-selftests.c.
9155 (SUBDIR_UNITTESTS_OBS): Add optional-selftests.o.
9156 * unittests/optional-selftests.c: New file.
9157 * unittests/optional/assignment/1.cc: New file.
9158 * unittests/optional/assignment/2.cc: New file.
9159 * unittests/optional/assignment/3.cc: New file.
9160 * unittests/optional/assignment/4.cc: New file.
9161 * unittests/optional/assignment/5.cc: New file.
9162 * unittests/optional/assignment/6.cc: New file.
9163 * unittests/optional/assignment/7.cc: New file.
9164 * unittests/optional/cons/copy.cc: New file.
9165 * unittests/optional/cons/default.cc: New file.
9166 * unittests/optional/cons/move.cc: New file.
9167 * unittests/optional/cons/value.cc: New file.
9168 * unittests/optional/in_place.cc: New file.
9169 * unittests/optional/observers/1.cc: New file.
9170 * unittests/optional/observers/2.cc: New file.
9174 * common/gdb_optional.h: Include common/traits.h.
9175 (in_place_t): New type.
9176 (in_place): New constexpr variable.
9177 (optional::optional): Remove member initialization of
9179 (optional::optional(in_place_t...)): New constructor.
9180 (optional::~optional): Use reset.
9181 (optional::optional(const optional&)): New.
9182 (optional::optional(const optional&&)): New.
9183 (optional::optional(T &)): New.
9184 (optional::optional(T &&)): New.
9185 (operator::operator=(const optional &)): New.
9186 (operator::operator=(optional &&)): New.
9187 (operator::operator= (const T &))
9188 (operator::operator= (T &&))
9189 (operator::emplace (Args &&... args)): Return a T&. Use reset.
9190 (operator::reset): New.
9191 (operator::m_instantiated):: Add in-class initializer.
9192 * common/traits.h: Include <type_traits>.
9193 (struct And): New types.
9197 * xml-support.c: Include <vector>.
9198 (scope_level::scope_level(const gdb_xml_element *))
9199 (scope_level::scope_level(scope_level&&)): New.
9200 (scope_level::~scope_level): New.
9201 (scope_level_s): Delete.
9202 (gdb_xml_parser::scopes): Now a std::vector.
9203 (gdb_xml_body_text, gdb_xml_start_element, gdb_xml_end_element):
9205 (gdb_xml_parser::~gdb_xml_parser): Remove now unnecessary
9207 (gdb_xml_parser::gdb_xml_parser): Remove explicit initialization
9208 of the scopes member. Use std::vector::emplace_back.
9212 * xml-support.c (gdb_xml_parser): Add ctor/dtor. Make is_xinclude
9214 (gdb_xml_end_element): Change type of first parameter.
9215 (gdb_xml_cleanup): Rename to ...
9216 (gdb_xml_parser::~gdb_xml_parser): ... this.
9217 (gdb_xml_create_parser_and_cleanup): Delete with ...
9218 (gdb_xml_parser::gdb_xml_parser): ... creation parts factored out
9220 (gdb_xml_parse_quick): Create a local gdb_xml_parser instead of
9221 using gdb_xml_create_parser_and_cleanup.
9222 (xinclude_parsing_data): Add ctor/dtor.
9223 (xml_xinclude_cleanup): Delete.
9224 (xml_process_xincludes): Create a local xinclude_parsing_data
9225 instead of heap-allocating one. Create a local gdb_xml_parser
9226 instead of heap-allocating one with
9227 gdb_xml_create_parser_and_cleanup.
9232 * fbsd-nat.c (resume_one_thread_cb): Remove.
9233 (resume_all_threads_cb): Remove.
9234 (fbsd_resume): Use ALL_NON_EXITED_THREADS instead of
9235 iterate_over_threads.
9239 * NEWS: Create a new section for the next release branch.
9240 Rename the section of the current branch, now that it has
9245 GDB 8.0 branch created (725bf5cf125783c2a7ca4ab63d3768e220bab2db):
9246 * version.in: Bump version to 8.0.50.DATE-git.
9251 * windows-nat.c (windows_create_inferior): Declare 'allargs'
9252 independently of the host, and fix build breakage on Cygwin.
9256 * inferior.c (free_inferior): Convert to ...
9257 (inferior::~inferior): ... this dtor.
9258 (inferior::inferior): New ctor, factored out from ...
9259 (add_inferior_silent): ... here. Allocate the inferior with a new
9261 (delete_inferior): Call delete instead of free_inferior.
9262 * inferior.h (gdb_environ, continuation): Forward declare.
9263 (inferior): Now a class. Add in-class initialization to all
9264 members. Make boolean fields bool, except 'detaching'.
9265 (inferior::inferior): New explicit ctor.
9266 (inferior::~inferior): New.
9270 * inferior.c (init_inferior_list): Delete.
9271 * inferior.h (init_inferior_list): Delete.
9276 * gdb.threads/threadapply.exp (thr_apply_detach): New procedure.
9277 (top level): Call it twice, with different thread sets.
9281 * thread.c: Include <algorithm>.
9282 (thread_array_cleanup): Delete.
9283 (scoped_inc_dec_ref): New class.
9284 (live_threads_count): New function.
9285 (set_thread_refcount): Delete.
9286 (tp_array_compar_ascending): Now a bool.
9287 (tp_array_compar): Convert to a std::sort comparison function.
9288 (thread_apply_all_command): Use std::vector and scoped_inc_dec_ref
9289 and live_threads_count.
9293 * infrun.c (follow_fork_inferior): Also switch the current
9298 * breakpoint.c (watch_command_1): Save watchpoint-frame info
9299 before calling create_internal_breakpoint.
9303 * fork-child.c (execv_argv): New class.
9304 (breakup_args): Refactored as ...
9305 (execv_argv::init_for_no_shell): .. this method of execv_argv.
9306 Copy arguments to storage and replace separators with NULL
9307 terminators in place.
9308 (escape_bang_in_quoted_argument): Adjust to return bool.
9309 (execv_argv::execv_argv): New ctor.
9310 (execv_argv::init_for_shell): New method, factored out from
9311 fork_inferior. Don't strdup strings into the vector.
9312 (fork_inferior): Eliminate "shell" local and use execv_argv. Use
9313 Remove free_vector_argv call.
9317 * rx-tdep.c (rx_fpsw_type): Check tdep->rx_fpsw_type instead of
9322 * rl78-tdep.c (rl78_gdbarch_init): Use XCNEW instead of XNEW.
9323 * rx-tdep.c (rx_gdbarch_init): Likewise.
9327 * breakpoint.h (struct breakpoint): Reindent.
9331 * breakpoint.c (bp_location): Rename to ...
9332 (bp_locations): ... this. All references updated.
9333 (bp_location_count): Rename to ...
9334 (bp_locations_count): ... this. All references updated.
9335 (bp_location_placed_address_before_address_max): Rename to ...
9336 (bp_locations_placed_address_before_address_max): ... this. All
9338 (bp_location_shadow_len_after_address_max): Rename to ...
9339 (bp_locations_shadow_len_after_address_max): ... this. All
9341 (bp_location_compare_addrs): Rename to ...
9342 (bp_locations_compare_addrs): ... this. All references updated.
9343 (bp_location_compare):Rename to ...
9344 (bp_locations_compare): ... this. All references updated.
9345 (bp_location_target_extensions_update): Rename to ...
9346 (bp_locations_target_extensions_update): ... this. All references
9351 * Makefile.in (HFILES_NO_SRCDIR): Add "common/gdb_termios.h".
9352 * common/common.m4: Check headers 'termios.h', 'termio.h' and
9354 * common/gdb_termios.h: New file, with parts of "terminal.h".
9355 * inflow.c: Include "gdb_termios.h".
9356 * ser-unix.c: Include "gdb_termios.h".
9357 * terminal.h: Move terminal-related defines to
9358 "common/gdb_termios.h".
9362 * probe.c (parse_probes): Update.
9363 * location.h (delete_event_location): Don't declare.
9364 (event_location_deleter::operator()): Update.
9365 * location.c (event_location_deleter::operator()): Rename from
9366 delete_event_location.
9367 * linespec.h (linespec_result) <location>: Change type to
9369 * linespec.c (canonicalize_linespec, event_location_to_sals)
9370 (decode_objc): Update.
9371 (linespec_result): Don't call delete_event_location.
9372 * breakpoint.c (create_breakpoints_sal)
9373 (bkpt_probe_create_sals_from_location)
9374 (strace_marker_create_sals_from_location): Update.
9378 * linespec.h (struct linespec_result): Add constructor and
9380 (init_linespec_result, destroy_linespec_result)
9381 (make_cleanup_destroy_linespec_result): Don't declare.
9382 * linespec.c (init_linespec_result): Remove.
9383 (linespec_result::~linespec_result): Rename from
9384 destroy_linespec_result. Update.
9385 (cleanup_linespec_result, make_cleanup_destroy_linespec_result):
9387 * breakpoint.c (create_breakpoint, break_range_command)
9388 (decode_location_default): Update.
9389 * ax-gdb.c (agent_command_1): Update.
9393 * remote.c (remote_download_tracepoint): Update.
9394 * python/py-breakpoint.c (bppy_get_location): Update.
9395 * guile/scm-breakpoint.c (bpscm_print_breakpoint_smob)
9396 (gdbscm_breakpoint_location): Update.
9397 * elfread.c (elf_gnu_ifunc_resolver_return_stop): Update.
9398 * breakpoint.h (struct breakpoint) <location, location_range_end>:
9399 Change type to event_location_up.
9400 * breakpoint.c (create_overlay_event_breakpoint)
9401 (create_longjmp_master_breakpoint)
9402 (create_std_terminate_master_breakpoint)
9403 (create_exception_master_breakpoint)
9404 (breakpoint_event_location_empty_p, print_breakpoint_location)
9405 (print_one_breakpoint_location, create_thread_event_breakpoint)
9406 (init_breakpoint_sal, create_breakpoint)
9407 (print_recreate_ranged_breakpoint, break_range_command)
9408 (init_ada_exception_breakpoint, say_where): Update.
9409 (base_breakpoint_dtor): Don't call delete_event_location.
9410 (bkpt_print_recreate, tracepoint_print_recreate)
9411 (dprintf_print_recreate, update_static_tracepoint)
9412 (breakpoint_re_set_default): Update.
9416 * compile/compile-loc2c.c (compute_stack_depth_worker): Change
9417 type of "to_do". Update.
9418 (compute_stack_depth): Use std::vector.
9422 * printcmd.c (find_instruction_backward): Use std::vector.
9426 * symfile.c (objfilep): Remove typedef.
9427 (reread_symbols): Use a std::vector.
9431 * mi/mi-main.c (exec_direction_forward): Remove.
9432 (exec_reverse_continue, mi_execute_command): Use scoped_restore.
9433 * guile/scm-ports.c (ioscm_with_output_to_port_worker): Use
9435 * guile/guile.c (guile_repl_command, guile_command)
9436 (gdbscm_execute_gdb_command): Use scoped_restore.
9437 * go-exp.y (go_parse): Use scoped_restore.
9438 * d-exp.y (d_parse): Use scoped_restore.
9439 * cli/cli-decode.c (cmd_func): Use scoped_restore.
9440 * c-exp.y (c_parse): Use scoped_restore.
9444 * mi/mi-parse.h (struct mi_parse): Add constructor, destructor.
9445 (mi_parse): Update return type.
9446 (mi_parse_free): Remove.
9447 * mi/mi-parse.c (mi_parse::mi_parse): New constructor.
9448 (mi_parse::~mi_parse): Rename from mi_parse_free.
9449 (mi_parse_cleanup): Remove.
9450 (mi_parse): Return a unique_ptr. Use new.
9451 * mi/mi-main.c (mi_execute_command): Update.
9455 * location.c (explicit_location_lex_one): Return a
9457 (string_to_explicit_location): Update. Remove cleanups.
9461 * gnu-v3-abi.c (value_and_voffset_p): Remove typedef.
9462 (compare_value_and_voffset): Change type. Update.
9463 (compute_vtable_size): Change type of "offset_vec".
9464 (gnuv3_print_vtable): Use std::vector. Remove cleanups.
9465 (gnuv3_get_typeid): Remove extraneous declaration.
9469 * charset.h (wchar_iterator): Fix comment.
9473 * charset.c (iconv_wrapper): New class.
9474 (cleanup_iconv): Remove.
9475 (convert_between_encodings): Use it.
9479 * symfile.h (increment_reading_symtab): Update type.
9480 * symfile.c (decrement_reading_symtab): Remove.
9481 (increment_reading_symtab): Return a scoped_restore_tmpl<int>.
9482 * psymtab.c (psymtab_to_symtab): Update.
9483 * dwarf2read.c (dw2_instantiate_symtab): Update.
9487 * jit.c (struct jit_reader): Declare separately. Add constructor
9488 and destructor. Change type of "handle".
9489 (loaded_jit_reader): Define separately.
9490 (jit_reader_load): Update. New "new".
9491 (jit_reader_unload_command): Use "delete".
9492 * gdb-dlfcn.h (struct dlclose_deleter): New.
9493 (gdb_dlhandle_up): New typedef.
9494 (gdb_dlopen, gdb_dlsym): Update types.
9495 (gdb_dlclose): Remove.
9496 * gdb-dlfcn.c (gdb_dlopen): Return a gdb_dlhandle_up.
9497 (gdb_dlsym): Change type of "handle".
9498 (make_cleanup_dlclose): Remove.
9499 (dlclose_deleter::operator()): Rename from gdb_dlclose.
9500 * compile/compile-c-support.c (load_libcc): Update.
9504 * symtab.h (find_pcs_for_symtab_line): Change return type.
9505 * symtab.c (find_pcs_for_symtab_line): Change return type.
9506 * python/py-linetable.c (build_line_table_tuple_from_pcs): Change
9507 type of "vec". Update.
9508 (ltpy_get_pcs_for_line): Update.
9509 * linespec.c (decode_digits_ordinary): Update.
9513 * tracepoint.c (actions_command): Update.
9514 * python/python.c (python_command, python_interactive_command):
9516 * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
9517 * guile/guile.c (guile_command): Update.
9518 * defs.h (read_command_lines, read_command_lines_1): Return
9520 (command_lines_deleter): New struct.
9521 (command_line_up): New typedef.
9522 * compile/compile.c (compile_code_command)
9523 (compile_print_command): Update.
9524 * cli/cli-script.h (get_command_line, copy_command_lines): Return
9526 (make_cleanup_free_command_lines): Remove.
9527 * cli/cli-script.c (get_command_line, read_command_lines_1)
9528 (copy_command_lines): Return command_line_up.
9529 (while_command, if_command, read_command_lines, define_command)
9530 (document_command): Update.
9531 (do_free_command_lines_cleanup, make_cleanup_free_command_lines):
9533 * breakpoint.h (breakpoint_set_commands): Change type of
9535 * breakpoint.c (breakpoint_set_commands): Change type of
9537 (do_map_commands_command, update_dprintf_command_list)
9538 (create_tracepoint_from_upload): Update.
9542 * tracepoint.c (scope_info): Update.
9543 * spu-tdep.c (spu_catch_start): Update.
9544 * python/python.c (gdbpy_decode_line): Update.
9545 * python/py-finishbreakpoint.c (bpfinishpy_init): Update.
9546 * python/py-breakpoint.c (bppy_init): Update.
9547 * probe.c (parse_probes): Update.
9548 * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Update.
9549 * location.h (event_location_deleter): New struct.
9550 (event_location_up): New typedef.
9551 (new_linespec_location, new_address_location, new_probe_location)
9552 (new_explicit_location, copy_event_location)
9553 (string_to_event_location, string_to_event_location_basic)
9554 (string_to_explicit_location): Update return type.
9555 (make_cleanup_delete_event_location): Remove.
9556 * location.c (new_linespec_location, new_address_location)
9557 (new_probe_location, new_explicit_location, copy_event_location):
9558 Return event_location_up.
9559 (delete_event_location_cleanup)
9560 (make_cleanup_delete_event_location): Remove.
9561 (string_to_explicit_location, string_to_event_location_basic)
9562 (string_to_event_location): Return event_location_up.
9563 * linespec.c (canonicalize_linespec, event_location_to_sals)
9564 (decode_line_with_current_source)
9565 (decode_line_with_last_displayed, decode_objc): Update.
9566 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9567 * completer.c (location_completer): Update.
9568 * cli/cli-cmds.c (edit_command, list_command): Update.
9569 * breakpoint.c (create_overlay_event_breakpoint)
9570 (create_longjmp_master_breakpoint)
9571 (create_std_terminate_master_breakpoint)
9572 (create_exception_master_breakpoint)
9573 (create_thread_event_breakpoint): Update.
9574 (init_breakpoint_sal): Update. Remove some dead code.
9575 (create_breakpoint_sal): Change type of "location". Update.
9576 (create_breakpoints_sal, create_breakpoint, break_command_1)
9577 (dprintf_command, break_range_command, until_break_command)
9578 (init_ada_exception_breakpoint)
9579 (strace_marker_create_sals_from_location)
9580 (update_static_tracepoint, trace_command, ftrace_command)
9581 (strace_command, create_tracepoint_from_upload): Update.
9582 * break-catch-throw.c (re_set_exception_catchpoint): Update.
9583 * ax-gdb.c (agent_command_1): Update.
9587 * Makefile.in (ALL_TARGET_OBS): Add i386-go32-tdep.o.
9588 * configure.tgt: Handle i[34567]86-*-go32* and
9589 i[34567]86-*-msdosdjgpp*.
9590 * i386-tdep.c (i386_svr4_reg_to_regnum):
9592 (i386_go32_init_abi, i386_coff_osabi_sniffer): Moved to
9594 (_initialize_i386_tdep): DJGPP bits moved to i386-go32-tdep.c.
9595 * i386-go32-tdep.c: New file.
9596 * i386-tdep.h (tdesc_i386_mmx, i386_svr4_reg_to_regnum): New
9601 * aix-thread.c (pd_status2str): Change return type to const char *.
9605 * i386-tdep.c (i386_elf_init_abi, i386_go32_init_abi): Remove
9606 calls to set_gdbarch_gnu_triplet_regexp.
9611 * c-lang.c (cplus_primitive_types) <cplus_primitive_type_wchar_t>:
9613 (cplus_language_arch_info): Register cplus_primitive_type_wchar_t.
9614 * gdbtypes.h (struct builtin_type) <builtin_wchar>: New field.
9615 * gdbtypes.c (gdbtypes_post_init): Create the "wchar_t" type.
9616 * gdbarch.sh (wchar_bit, wchar_signed): New per-arch values.
9617 * gdbarch.h, gdbarch.c: Regenerate.
9618 * aarch64-tdep.c (aarch64_gdbarch_init): Override
9619 gdbarch_wchar_bit and gdbarch_wchar_signed.
9620 * alpha-tdep.c (alpha_gdbarch_init): Likewise.
9621 * arm-tdep.c (arm_gdbarch_init): Likewise.
9622 * avr-tdep.c (avr_gdbarch_init): Likewise.
9623 * h8300-tdep.c (h8300_gdbarch_init): Likewise.
9624 * i386-nto-tdep.c (i386nto_init_abi): Likewise.
9625 * i386-tdep.c (i386_go32_init_abi): Likewise.
9626 * m32r-tdep.c (m32r_gdbarch_init): Likewise.
9627 * moxie-tdep.c (moxie_gdbarch_init): Likewise.
9628 * nds32-tdep.c (nds32_gdbarch_init): Likewise.
9629 * rs6000-aix-tdep.c (rs6000_aix_init_osabi): Likewise.
9630 * sh-tdep.c (sh_gdbarch_init): Likewise.
9631 * sparc-tdep.c (sparc32_gdbarch_init): Likewise.
9632 * sparc64-tdep.c (sparc64_init_abi): Likewise.
9633 * windows-tdep.c (windows_init_abi): Likewise.
9634 * xstormy16-tdep.c (xstormy16_gdbarch_init): Likewise.
9639 * c-lang.c (cplus_primitive_types) <cplus_primitive_type_char16_t,
9640 cplus_primitive_type_char32_t>: New enum values.
9641 (cplus_language_arch_info): Register cplus_primitive_type_char16_t
9642 and cplus_primitive_type_char32_t.
9643 * dwarf2read.c (read_base_type) <DW_ATE_UTF>: If bit size is 16 or
9644 32, use the archtecture's built-in type for char16_t and char32_t,
9645 respectively. Otherwise, fallback to init_integer_type as before,
9646 but make the type unsigned, and issue a complaint.
9647 * gdbtypes.c (gdbtypes_post_init): Make char16_t and char32_t unsigned.
9651 * m32r-tdep.c (M32R_ARG_REGISTER_SIZE): Added.
9652 (m32r_push_dummy_call): Use M32R_ARG_REGISTER_SIZE.
9656 * windows-nat.c (windows_create_inferior): Declare 'toexec' as
9661 * common/common-utils.c (free_vector_argv): New function.
9662 * common/common-utils.h: Include <vector>.
9663 (free_vector_argv): New prototype.
9664 * darwin-nat.c (darwin_create_inferior): Rewrite function
9665 prototype in order to constify "exec_file" and accept a
9666 "std::string" for "allargs".
9667 * fork-child.c: Include <vector>.
9668 (breakup_args): Rewrite function, using C++.
9669 (fork_inferior): Rewrite function header, constify "exec_file_arg"
9670 and accept "std::string" for "allargs". Update the code to
9671 calculate "argv" based on "allargs". Update calls to "exec_fun"
9673 * gnu-nat.c (gnu_create_inferior): Rewrite function prototype in
9674 order to constify "exec_file" and accept a "std::string" for
9676 * go32-nat.c (go32_create_inferior): Likewise.
9677 * inf-ptrace.c (inf_ptrace_create_inferior): Likewise.
9678 * infcmd.c (run_command_1): Constify "exec_file". Use
9679 "std::string" for inferior arguments.
9680 * inferior.h (fork_inferior): Update prototype.
9681 * linux-nat.c (linux_nat_create_inferior): Rewrite function
9682 prototype in order to constify "exec_file" and accept a
9683 "std::string" for "allargs".
9684 * nto-procfs.c (procfs_create_inferior): Likewise.
9685 * procfs.c (procfs_create_inferior): Likewise.
9686 * remote-sim.c (gdbsim_create_inferior): Likewise.
9687 * remote.c (extended_remote_run): Update code to accept
9688 "std::string" as argument.
9689 (extended_remote_create_inferior): Rewrite function prototype in
9690 order to constify "exec_file" and accept a "std::string" for
9692 * rs6000-nat.c (super_create_inferior): Likewise.
9693 (rs6000_create_inferior): Likewise.
9694 * target.h (struct target_ops) <to_create_inferior>: Likewise.
9695 * windows-nat.c (windows_create_inferior): Likewise.
9699 * thread.c: Fix whitespace throughout.
9703 * linux-nat.c (linux_nat_detach): Remove delete_lwp call.
9707 * arm-tdep.c (arm_store_return_value): Use FP_REGISTER_SIZE
9712 * osdata.c (info_osdata): Check if 'type' is an empty string
9717 * thread.c (add_thread_silent, delete_thread_1, find_thread_ptid)
9718 (ptid_to_global_thread_id, in_thread_list)
9719 (do_captured_list_thread_ids, set_resumed, set_running)
9720 (set_executing, set_stop_requested, finish_thread_state)
9721 (validate_registers_access, can_access_registers_ptid)
9722 (print_thread_info_1, switch_to_thread)
9723 (do_restore_current_thread_cleanup)
9724 (make_cleanup_restore_current_thread, thread_command)
9725 (thread_name_command): Use operator== instead of ptid_equal.
9729 * thread.c (struct current_thread_cleanup) <next>: Delete field.
9730 (current_thread_cleanup_chain): Delete.
9731 (restore_current_thread_cleanup_dtor)
9732 (make_cleanup_restore_current_thread): Remove references to
9733 current_thread_cleanup_chain.
9737 * msp430-tdep.c (msp430_pseudo_register_read): Never return
9743 * gdbthread.h (thread_info::deletable): New method.
9744 (thread_info::incref): New method.
9745 (thread_info::decref): New method.
9746 (thread_info::refcount): Move it to private.
9747 * infrun.c (save_stop_context): Call inc_refcount.
9748 (release_stop_context_cleanup): Likewise.
9749 * thread.c (set_thread_exited): New function.
9750 (init_thread_list): Delete "tp" only it is deletable, otherwise
9751 call set_thread_exited.
9752 (delete_thread_1): Call set_thread_exited.
9753 (current_thread_cleanup) <inferior_pid>: Remove.
9754 <thread>: New field.
9755 (restore_current_thread_ptid_changed): Removed.
9756 (do_restore_current_thread_cleanup): Adjust.
9757 (restore_current_thread_cleanup_dtor): Don't call
9759 (set_thread_refcount): Use dec_refcount.
9760 (make_cleanup_restore_current_thread): Adjust.
9761 (thread_apply_all_command): Call inc_refcount.
9762 (_initialize_thread): Don't call
9763 observer_attach_thread_ptid_changed.
9767 * thread.c (delete_thread_1): Hoist code on marking thread as
9772 * windows-nat.c (windows_detach): Initialize ptid with
9777 * unittests/ptid-selftests.c: Fix erroneous assert messages.
9781 * bfin-tdep.c (BFIN_MAX_REGISTER_SIZE): Add.
9782 (bfin_pseudo_register_read): Use BFIN_MAX_REGISTER_SIZE.
9783 (bfin_pseudo_register_write): Likewise
9787 * common/ptid.h (struct ptid): Change to...
9788 (class ptid_t): ... this.
9789 <ptid_t>: New constructors.
9790 <pid, lwp_p, lwp, tid_p, tid, is_pid, operator==, operator!=,
9791 matches>: New methods.
9792 <make_null, make_minus_one>: New static methods.
9799 (ptid_build, ptid_get_pid, ptid_get_lwp, ptid_get_tid, ptid_equal,
9800 ptid_is_pid, ptid_lwp_p, ptid_tid_p, ptid_match): Take ptid arguments
9801 as references, move comment to class ptid_t.
9802 * common/ptid.c (null_ptid, minus_one_ptid): Initialize with
9803 ptid_t static methods.
9804 (ptid_build, pid_to_ptid, ptid_get_pid, ptid_get_tid,
9805 ptid_equal, ptid_is_pid, ptid_lwp_p, ptid_tid_p, ptid_match):
9806 Take ptid arguments as references, implement using ptid_t methods.
9807 * unittests/ptid-selftests.c: New file.
9808 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9809 unittests/ptid-selftests.c.
9810 (SUBDIR_UNITTESTS_OBS): Add unittests/ptid-selftests.o.
9814 * python/python.c (python_run_simple_file): Cast mode literal to
9815 non-const char pointer as expected by PyFile_FromString.
9819 * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with
9820 minus_one_ptid and null_ptid.
9824 * warning.m4 (build_warnings): Remove -Wno-write-strings.
9825 * configure: Regenerate.
9829 * ada-exp.y (yyerror): Constify.
9830 * ada-lang.c (bound_name, get_selections)
9831 (ada_variant_discrim_type)
9832 (ada_variant_discrim_name, ada_value_struct_elt)
9833 (ada_lookup_struct_elt_type, is_unchecked_variant)
9834 (ada_which_variant_applies, standard_exc, ada_get_next_arg)
9835 (catch_ada_exception_command_split)
9836 (catch_ada_assert_command_split, catch_assert_command)
9837 (ada_op_name): Constify.
9838 * ada-lang.h (ada_yyerror, get_selections)
9839 (ada_variant_discrim_name, ada_value_struct_elt): Constify.
9840 * arc-tdep.c (arc_print_frame_cache): Constify.
9841 * arm-tdep.c (arm_skip_stub): Constify.
9842 * ax-gdb.c (gen_binop, gen_struct_ref_recursive, gen_struct_ref)
9843 (gen_aggregate_elt_ref): Constify.
9844 * bcache.c (print_bcache_statistics): Constify.
9845 * bcache.h (print_bcache_statistics): Constify.
9846 * break-catch-throw.c (catch_exception_command_1):
9847 * breakpoint.c (struct ep_type_description::description):
9849 (add_solib_catchpoint): Constify.
9850 (catch_fork_command_1): Add cast.
9851 (add_catch_command): Constify.
9852 * breakpoint.h (add_catch_command, add_solib_catchpoint):
9854 * bsd-uthread.c (bsd_uthread_state): Constify.
9855 * buildsym.c (patch_subfile_names): Constify.
9856 * buildsym.h (next_symbol_text_func, patch_subfile_names):
9858 * c-exp.y (yyerror): Constify.
9859 (token::oper): Constify.
9860 * c-lang.h (c_yyerror, cp_print_class_member): Constify.
9861 * c-varobj.c (cplus_describe_child): Constify.
9862 * charset.c (find_charset_names): Add cast.
9863 (find_charset_names): Constify array and add const_cast.
9864 * cli/cli-cmds.c (complete_command, cd_command): Constify.
9865 (edit_command): Constify.
9866 * cli/cli-decode.c (lookup_cmd): Constify.
9867 * cli/cli-dump.c (dump_memory_command, dump_value_command):
9869 (struct dump_context): Constify.
9870 (add_dump_command, restore_command): Constify.
9871 * cli/cli-script.c (get_command_line): Constify.
9872 * cli/cli-script.h (get_command_line): Constify.
9873 * cli/cli-utils.c (check_for_argument): Constify.
9874 * cli/cli-utils.h (check_for_argument): Constify.
9875 * coff-pe-read.c (struct read_pe_section_data): Constify.
9876 * command.h (lookup_cmd): Constify.
9877 * common/print-utils.c (decimal2str): Constify.
9878 * completer.c (gdb_print_filename): Constify.
9879 * corefile.c (set_gnutarget): Constify.
9880 * cp-name-parser.y (yyerror): Constify.
9881 * cp-valprint.c (cp_print_class_member): Constify.
9882 * cris-tdep.c (cris_register_name, crisv32_register_name):
9884 * d-exp.y (yyerror): Constify.
9885 (struct token::oper): Constify.
9886 * d-lang.h (d_yyerror): Constify.
9887 * dbxread.c (struct header_file_location::name): Constify.
9888 (add_old_header_file, add_new_header_file, last_function_name)
9889 (dbx_next_symbol_text, add_bincl_to_list)
9890 (find_corresponding_bincl_psymtab, set_namestring)
9891 (find_stab_function_addr, read_dbx_symtab, start_psymtab)
9892 (dbx_end_psymtab, read_ofile_symtab, process_one_symbol):
9893 * defs.h (command_line_input, print_address_symbolic)
9894 (deprecated_readline_begin_hook): Constify.
9895 * dwarf2read.c (anonymous_struct_prefix, dwarf_bool_name):
9897 * event-top.c (handle_line_of_input): Constify and add cast.
9898 * exceptions.c (catch_errors): Constify.
9899 * exceptions.h (catch_errors): Constify.
9900 * expprint.c (print_subexp_standard, op_string, op_name)
9901 (op_name_standard, dump_raw_expression, dump_raw_expression):
9902 * expression.h (op_name, op_string, dump_raw_expression):
9904 * f-exp.y (yyerror): Constify.
9905 (struct token::oper): Constify.
9906 (struct f77_boolean_val::name): Constify.
9907 * f-lang.c (f_word_break_characters): Constify.
9908 * f-lang.h (f_yyerror): Constify.
9909 * fork-child.c (fork_inferior): Add cast.
9910 * frv-tdep.c (struct gdbarch_tdep::register_names): Constify.
9911 (new_variant): Constify.
9912 * gdbarch.sh (pstring_ptr, pstring_list): Constify.
9913 * gdbarch.c: Regenerate.
9914 * gdbcore.h (set_gnutarget): Constify.
9915 * go-exp.y (yyerror): Constify.
9916 (token::oper): Constify.
9917 * go-lang.h (go_yyerror): Constify.
9918 * go32-nat.c (go32_sysinfo): Constify.
9919 * guile/scm-breakpoint.c (gdbscm_breakpoint_expression): Constify.
9920 * guile/scm-cmd.c (cmdscm_function): Constify.
9921 * guile/scm-param.c (pascm_param_value): Constify.
9922 * h8300-tdep.c (h8300_register_name, h8300s_register_name)
9923 (h8300sx_register_name): Constify.
9924 * hppa-tdep.c (hppa32_register_name, hppa64_register_name):
9926 * ia64-tdep.c (ia64_register_names): Constify.
9927 * infcmd.c (construct_inferior_arguments): Constify.
9928 (path_command, attach_post_wait): Constify.
9929 * language.c (show_range_command, show_case_command)
9930 (unk_lang_error): Constify.
9931 * language.h (language_defn::la_error)
9932 (language_defn::la_name_of_this): Constify.
9933 * linespec.c (decode_line_2): Constify.
9934 * linux-thread-db.c (thread_db_err_str): Constify.
9935 * lm32-tdep.c (lm32_register_name): Constify.
9936 * m2-exp.y (yyerror): Constify.
9937 * m2-lang.h (m2_yyerror): Constify.
9938 * m32r-tdep.c (m32r_register_names): Constify and make static.
9939 * m68hc11-tdep.c (m68hc11_register_names): Constify.
9940 * m88k-tdep.c (m88k_register_name): Constify.
9941 * macroexp.c (appendmem): Constify.
9942 * mdebugread.c (fdr_name, add_data_symbol, parse_type)
9943 (upgrade_type, parse_external, parse_partial_symbols)
9944 (mdebug_next_symbol_text, cross_ref, mylookup_symbol, new_psymtab)
9945 (new_symbol): Constify.
9946 * memattr.c (mem_info_command): Constify.
9947 * mep-tdep.c (register_name_from_keyword): Constify.
9948 * mi/mi-cmd-env.c (mi_cmd_env_path, _initialize_mi_cmd_env):
9950 * mi/mi-cmd-stack.c (list_args_or_locals): Constify.
9951 * mi/mi-cmd-var.c (mi_cmd_var_show_attributes): Constify.
9952 * mi/mi-main.c (captured_mi_execute_command): Constify and add
9954 (mi_execute_async_cli_command): Constify.
9955 * mips-tdep.c (mips_register_name): Constify.
9956 * mn10300-tdep.c (register_name, mn10300_generic_register_name)
9957 (am33_register_name, am33_2_register_name)
9958 * moxie-tdep.c (moxie_register_names): Constify.
9959 * nat/linux-osdata.c (osdata_type): Constify fields.
9960 * nto-tdep.c (nto_parse_redirection): Constify.
9961 * objc-lang.c (lookup_struct_typedef, lookup_objc_class)
9962 (lookup_child_selector): Constify.
9963 (objc_methcall::name): Constify.
9964 * objc-lang.h (lookup_objc_class, lookup_child_selector)
9965 (lookup_struct_typedef): Constify.
9966 * objfiles.c (pc_in_section): Constify.
9967 * objfiles.h (pc_in_section): Constify.
9968 * p-exp.y (struct token::oper): Constify.
9969 (yyerror): Constify.
9970 * p-lang.h (pascal_yyerror): Constify.
9971 * parser-defs.h (op_name_standard): Constify.
9972 (op_print::string): Constify.
9973 (exp_descriptor::op_name): Constify.
9974 * printcmd.c (print_address_symbolic): Constify.
9975 * psymtab.c (print_partial_symbols): Constify.
9976 * python/py-breakpoint.c (stop_func): Constify.
9977 (bppy_get_expression): Constify.
9978 * python/py-cmd.c (cmdpy_completer::name): Constify.
9979 (cmdpy_function): Constify.
9980 * python/py-event.c (evpy_add_attribute)
9981 (gdbpy_initialize_event_generic): Constify.
9982 * python/py-event.h (evpy_add_attribute)
9983 (gdbpy_initialize_event_generic): Constify.
9984 * python/py-evts.c (add_new_registry): Constify.
9985 * python/py-finishbreakpoint.c (outofscope_func): Constify.
9986 * python/py-framefilter.c (get_py_iter_from_func): Constify.
9987 * python/py-inferior.c (get_buffer): Add cast.
9988 * python/py-param.c (parm_constant::name): Constify.
9989 * python/py-unwind.c (fprint_frame_id): Constify.
9990 * python/python.c (gdbpy_parameter_value): Constify.
9991 * remote-fileio.c (remote_fio_func_map): Make 'name' const.
9992 * remote.c (memory_packet_config::name): Constify.
9993 (show_packet_config_cmd, remote_write_bytes)
9994 (remote_buffer_add_string):
9995 * reverse.c (exec_reverse_once): Constify.
9996 * rs6000-tdep.c (variant::name, variant::description): Constify.
9997 * rust-exp.y (rustyyerror): Constify.
9998 * rust-lang.c (rust_op_name): Constify.
9999 * rust-lang.h (rustyyerror): Constify.
10000 * serial.h (serial_ops::name): Constify.
10001 * sh-tdep.c (sh_sh_register_name, sh_sh3_register_name)
10002 (sh_sh3e_register_name, sh_sh2e_register_name)
10003 (sh_sh2a_register_name, sh_sh2a_nofpu_register_name)
10004 (sh_sh_dsp_register_name, sh_sh3_dsp_register_name)
10005 (sh_sh4_register_name, sh_sh4_nofpu_register_name)
10006 (sh_sh4al_dsp_register_name): Constify.
10007 * sh64-tdep.c (sh64_register_name): Constify.
10008 * solib-darwin.c (lookup_symbol_from_bfd): Constify.
10009 * spu-tdep.c (spu_register_name, info_spu_dma_cmdlist): Constify.
10010 * stabsread.c (patch_block_stabs, read_type_number)
10011 (ref_map::stabs, ref_add, process_reference)
10012 (symbol_reference_defined, define_symbol, define_symbol)
10013 (error_type, read_type, read_member_functions, read_cpp_abbrev)
10014 (read_one_struct_field, read_struct_fields, read_baseclasses)
10015 (read_tilde_fields, read_struct_type, read_array_type)
10016 (read_enum_type, read_sun_builtin_type, read_sun_floating_type)
10017 (read_huge_number, read_range_type, read_args, common_block_start)
10018 (find_name_end): Constify.
10019 * stabsread.h (common_block_start, define_symbol)
10020 (process_one_symbol, symbol_reference_defined, ref_add):
10021 * symfile.c (get_section_index, add_symbol_file_command):
10022 * symfile.h (get_section_index): Constify.
10023 * target-descriptions.c (tdesc_type::name): Constify.
10024 (tdesc_free_type): Add cast.
10025 * target.c (find_default_run_target):
10026 (add_deprecated_target_alias, find_default_run_target)
10027 (target_announce_detach): Constify.
10028 (do_option): Constify.
10029 * target.h (add_deprecated_target_alias): Constify.
10030 * thread.c (print_thread_info_1): Constify.
10031 * top.c (deprecated_readline_begin_hook, command_line_input):
10033 (init_main): Add casts.
10034 * top.h (handle_line_of_input): Constify.
10035 * tracefile-tfile.c (tfile_write_uploaded_tsv): Constify.
10036 * tracepoint.c (tvariables_info_1, trace_status_mi): Constify.
10037 (tfind_command): Rename to ...
10038 (tfind_command_1): ... this and constify.
10039 (tfind_command): New function.
10040 (tfind_end_command, tfind_start_command): Adjust.
10041 (encode_source_string): Constify.
10042 * tracepoint.h (encode_source_string): Constify.
10043 * tui/tui-data.c (tui_partial_win_by_name): Constify.
10044 * tui/tui-data.h (tui_partial_win_by_name): Constify.
10045 * tui/tui-source.c (tui_set_source_content_nil): Constify.
10046 * tui/tui-source.h (tui_set_source_content_nil): Constify.
10047 * tui/tui-win.c (parse_scrolling_args): Constify.
10048 * tui/tui-windata.c (tui_erase_data_content): Constify.
10049 * tui/tui-windata.h (tui_erase_data_content): Constify.
10050 * tui/tui-winsource.c (tui_erase_source_content): Constify.
10051 * tui/tui.c (tui_enable): Add cast.
10052 * utils.c (defaulted_query): Constify.
10053 (init_page_info): Add cast.
10054 (puts_debug, subset_compare): Constify.
10055 * utils.h (subset_compare): Constify.
10056 * varobj.c (varobj_format_string): Constify.
10057 * varobj.h (varobj_format_string): Constify.
10058 * vax-tdep.c (vax_register_name): Constify.
10059 * windows-nat.c (windows_detach): Constify.
10060 * xcoffread.c (process_linenos, xcoff_next_symbol_text): Constify.
10061 * xml-support.c (gdb_xml_end_element): Constify.
10062 * xml-tdesc.c (tdesc_start_reg): Constify.
10063 * xstormy16-tdep.c (xstormy16_register_name): Constify.
10064 * xtensa-tdep.c (xtensa_find_register_by_name): Constify.
10065 * xtensa-tdep.h (xtensa_register_t::name): Constify.
10069 * proc-api.c (struct trans): Constify.
10070 (procfs_note): Constify.
10071 * proc-events.c (struct trans, syscall_table):
10072 * proc-flags.c (struct trans): Constify.
10073 * proc-utils.h (procfs_note): Constify.
10074 * proc-why.c (struct trans): Constify.
10075 * procfs.c (dead_procinfo, find_syscall, proc_warn, proc_error)
10076 (procfs_detach): Constify.
10077 * sol-thread.c (struct string_map): Constify.
10078 (td_err_string, td_state_string): Constify.
10082 * proc-api.c (procfs_filename): Don't initialize
10084 (prepare_to_trace): Assume procfs_filename is non-NULL.
10085 (_initialize_proc_api): Give procfs_filename a default value here.
10089 * break-catch-throw.c (handle_gnu_v3_exceptions): Constify
10090 'cond_string' parameter.
10091 (extract_exception_regexp): Constify 'string' parameter.
10092 (catch_exception_command_1): Constify.
10093 * breakpoint.c (init_catchpoint)
10094 (create_fork_vfork_event_catchpoint): Constify 'cond_string'
10096 (ep_parse_optional_if_clause, catch_fork_command_1)
10097 (catch_exec_command_1): Constify.
10098 * breakpoint.h (init_catchpoint): Constify 'cond_string'
10100 (ep_parse_optional_if_clause): Constify.
10101 * cli/cli-utils.c (remove_trailing_whitespace)
10102 (check_for_argument): Constify.
10103 * cli/cli-utils.h (remove_trailing_whitespace): Constify and add
10104 non-const overload.
10105 (check_for_argument): Likewise.
10109 * event-top.c (command_line_handler): Add cast to execute_command
10111 * record-btrace.c (cmd_record_btrace_bts_start)
10112 (cmd_record_btrace_pt_start, cmd_record_btrace_start)
10113 (cmd_record_btrace_start): Add cast to execute_command call.
10114 * record-full.c (record_full_goto_insn):
10115 * record.c (record_start, record_stop): Add cast to
10116 execute_command_to_string calls.
10117 (cmd_record_start): Add cast to execute_command calls.
10121 * python/python-internal.h (gdb_PyArg_ParseTupleAndKeywords): New
10122 static inline function.
10123 * python/py-arch.c (archpy_disassemble): Constify 'keywords'
10124 array and use gdb_PyArg_ParseTupleAndKeywords.
10125 * python/py-cmd.c (cmdpy_init): Likewise.
10126 * python/py-finishbreakpoint.c (bpfinishpy_init): Likewise.
10127 * python/py-inferior.c (infpy_read_memory, infpy_write_memory)
10128 (infpy_search_memory): Likewise.
10129 * python/py-objfile.c (objfpy_add_separate_debug_file)
10130 (gdbpy_lookup_objfile): Likewise.
10131 * python/py-symbol.c (gdbpy_lookup_symbol)
10132 (gdbpy_lookup_global_symbol): Likewise.
10133 * python/py-type.c (gdbpy_lookup_type): Likewise.
10134 * python/py-value.c (valpy_lazy_string, valpy_string): Likewise.
10135 * python/python.c (execute_gdb_command, gdbpy_write, gdbpy_flush):
10140 * python/python-internal.h (gdb_PyGetSetDef): New type.
10141 * python/py-block.c (block_object_getset)
10142 (breakpoint_object_getset): Now a gdb_PyGetSetDef array.
10143 * python/py-event.c (event_object_getset)
10144 (finish_breakpoint_object_getset): Likewise.
10145 * python/py-inferior.c (inferior_object_getset): Likewise.
10146 * python/py-infthread.c (thread_object_getset): Likewise.
10147 * python/py-lazy-string.c (lazy_string_object_getset): Likewise.
10148 * python/py-linetable.c (linetable_entry_object_getset): Likewise.
10149 * python/py-objfile.c (objfile_getset): Likewise.
10150 * python/py-progspace.c (pspace_getset): Likewise.
10151 * python/py-record-btrace.c (btpy_insn_getset, btpy_call_getset):
10153 * python/py-record.c (recpy_record_getset): Likewise.
10154 * python/py-symbol.c (symbol_object_getset): Likewise.
10155 * python/py-symtab.c (symtab_object_getset, sal_object_getset):
10157 * python/py-type.c (type_object_getset, field_object_getset):
10159 * python/py-value.c (value_object_getset): Likewise.
10163 * python/python-internal.h (gdb_PyObject_CallMethod)
10164 (gdb_PyErr_NewException, gdb_PySys_GetObject, gdb_PySys_SetPath):
10166 (GDB_PYSYS_SETPATH_CHAR, PyObject_CallMethod, PyErr_NewException)
10167 (PySys_GetObject, PySys_SetPath): New macros.
10171 * mi/mi-cmd-info.c (mi_cmd_info_os): Call info_osdata instead of
10172 info_osdata_command.
10173 * osdata.c (info_osdata_command): Rename to ...
10174 (info_osdata): ... this. Constify 'type' parameter, and remove
10175 the 'from_tty' parameter. Accept NULL TYPE.
10176 (info_osdata_command): New function.
10177 * osdata.h (info_osdata_command): Remove declaration.
10178 (info_osdata): New declaration.
10182 * mi/mi-cmd-break.c (mi_cmd_break_insert_1, mi_cmd_break_insert)
10183 (mi_cmd_dprintf_insert, mi_cmd_break_passcount)
10184 (mi_cmd_break_watch, mi_cmd_break_commands): Constify 'command'
10186 * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception)
10187 (mi_cmd_catch_load, mi_cmd_catch_unload): Constify cmd' parameter.
10188 * mi/mi-cmd-disas.c (mi_cmd_disassemble): Constify 'command'
10190 * mi/mi-cmd-env.c (mi_cmd_env_pwd, mi_cmd_env_cd, mi_cmd_env_path)
10191 (mi_cmd_env_dir, mi_cmd_inferior_tty_set, _cmd_inferior_tty_show)
10192 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file)
10193 (mi_cmd_file_list_exec_source_files)
10194 (mi_cmd_file_list_shared_libraries): Constify 'command' parameter.
10195 * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions)
10196 (mi_cmd_info_gdb_mi_command, mi_cmd_info_os): Constify 'command'
10198 * mi/mi-cmd-stack.c (mi_cmd_enable_frame_filters)
10199 (mi_cmd_stack_list_frames, mi_cmd_stack_info_depth)
10200 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
10201 (mi_cmd_stack_list_variables, mi_cmd_stack_select_frame)
10202 (mi_cmd_stack_info_frame): Constify 'command' parameter.
10203 * mi/mi-cmd-target.c (mi_cmd_target_file_get)
10204 (mi_cmd_target_file_put, mi_cmd_target_file_delete): Constify
10205 'command' parameter.
10206 * mi/mi-cmd-var.c (mi_cmd_var_create, mi_cmd_var_delete)
10207 (mi_cmd_var_set_format, mi_cmd_var_set_visualizer)
10208 (mi_cmd_var_set_frozen, mi_cmd_var_show_format)
10209 (mi_cmd_var_info_num_children, mi_cmd_var_list_children)
10210 (mi_cmd_var_info_type, mi_cmd_var_info_path_expression)
10211 (mi_cmd_var_info_expression, mi_cmd_var_show_attributes)
10212 (mi_cmd_var_evaluate_expression, mi_cmd_var_assign)
10213 (mi_cmd_var_update, mi_cmd_enable_pretty_printing)
10214 (mi_cmd_var_set_update_range): Constify 'command' parameter.
10215 * mi/mi-cmds.h (mi_cmd_argv_ftype): Constify 'command' parameter.
10216 * mi/mi-interp.c (mi_cmd_interpreter_exec): Constify 'command'
10218 * mi/mi-main.c (mi_cmd_gdb_exit, mi_cmd_exec_next)
10219 (mi_cmd_exec_next_instruction, mi_cmd_exec_step)
10220 (mi_cmd_exec_step_instruction, mi_cmd_exec_finish)
10221 (mi_cmd_exec_return ,mi_cmd_exec_jump, mi_cmd_exec_continue)
10222 (mi_cmd_exec_interrupt, mi_cmd_exec_run, mi_cmd_target_detach)
10223 (mi_cmd_target_flash_erase, mi_cmd_thread_select)
10224 (mi_cmd_thread_list_ids, mi_cmd_thread_info)
10225 (mi_cmd_list_thread_groups, mi_cmd_data_list_register_names)
10226 (mi_cmd_data_list_changed_registers)
10227 (mi_cmd_data_write_register_values)
10228 (mi_cmd_data_evaluate_expression, mi_cmd_data_read_memory)
10229 (mi_cmd_data_read_memory_bytes, mi_cmd_data_write_memory)
10230 (mi_cmd_data_write_memory_bytes, mi_cmd_enable_timings)
10231 (mi_cmd_list_features, mi_cmd_list_target_features)
10232 (mi_cmd_add_inferior, mi_cmd_remove_inferior)
10233 (mi_cmd_trace_define_variable, mi_cmd_trace_list_variables)
10234 (mi_cmd_trace_find, mi_cmd_trace_save, mi_cmd_trace_start)
10235 (mi_cmd_trace_status, mi_cmd_trace_stop, mi_cmd_ada_task_info)
10236 (mi_cmd_trace_frame_collected): Constify 'command'
10238 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Constify
10239 'command' parameter.
10243 * ada-lang.c (ada_completer_word_break_characters): Now a const
10245 (ada_get_gdb_completer_word_break_characters): Constify.
10246 * completer.c (gdb_completer_command_word_break_characters)
10247 (gdb_completer_file_name_break_characters)
10248 (gdb_completer_quote_characters): Now const arrays.
10249 (get_gdb_completer_quote_characters): Constify.
10250 (set_rl_completer_word_break_characters): New function.
10251 (set_gdb_completion_word_break_characters)
10252 (complete_line_internal): Use it.
10253 * completer.h (get_gdb_completer_quote_characters): Constify.
10254 (set_rl_completer_word_break_characters): Declare.
10255 * f-lang.c (f_word_break_characters): Constify.
10256 * language.c (default_word_break_characters): Constify.
10257 * language.h (language_defn::la_word_break_characters): Constify.
10258 (default_word_break_characters): Constify.
10259 * top.c (init_main): Use set_rl_completer_word_break_characters.
10263 * aix-thread.c (aix_thread_pid_to_str)
10264 (aix_thread_extra_thread_info): Constify.
10265 * bsd-kvm.c (bsd_kvm_pid_to_str): Constify.
10266 * bsd-uthread.c (bsd_uthread_extra_thread_info)
10267 (bsd_uthread_pid_to_str): Constify.
10268 * corelow.c (core_pid_to_str): Constify.
10269 * darwin-nat.c (darwin_pid_to_str): Constify.
10270 * fbsd-nat.c (fbsd_pid_to_str): Constify.
10271 * fbsd-tdep.c (fbsd_core_pid_to_str, gdbarch_core_pid_to_str):
10273 * gnu-nat.c (gnu_pid_to_str): Constify.
10274 * go32-nat.c (go32_pid_to_str): Constify.
10275 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Constify.
10276 * inf-ptrace.c (inf_ptrace_pid_to_str): Constify.
10277 * inferior.c (inferior_pid_to_str): Constify.
10278 * linux-nat.c (linux_nat_pid_to_str): Constify.
10279 * linux-tdep.c (linux_core_pid_to_str): Constify.
10280 * linux-thread-db.c (thread_db_pid_to_str)
10281 (thread_db_extra_thread_info): Constify.
10282 * nto-tdep.c (nto_extra_thread_info): Constify.
10283 * nto-tdep.h (nto_extra_thread_info): Constify.
10284 * obsd-nat.c (obsd_pid_to_str): Constify.
10285 * procfs.c (procfs_pid_to_str): Constify.
10286 * ravenscar-thread.c (ravenscar_extra_thread_info)
10287 (ravenscar_pid_to_str): Constify.
10288 * remote-sim.c (gdbsim_pid_to_str): Constify.
10289 * remote.c (remote_threads_extra_info, remote_pid_to_str):
10291 * sol-thread.c (solaris_pid_to_str): Constify.
10292 * sol2-tdep.c (sol2_core_pid_to_str): Constify.
10293 * sol2-tdep.h (sol2_core_pid_to_str): Constify.
10294 * target.c (default_pid_to_str, target_pid_to_str)
10295 (normal_pid_to_str, default_pid_to_str): Constify.
10296 * target.h (target_ops::to_pid_to_str)
10297 (target_ops::to_extra_thread_info): Constify.
10298 (target_pid_to_str, normal_pid_to_str): Constify.
10299 * windows-nat.c (windows_pid_to_str): Constify.
10300 * gdbarch.sh (core_pid_to_str): Constify.
10301 * target-delegates.c: Regenerate.
10302 * gdbarch.h, gdbarch.c: Regenerate.
10306 * main.c (captured_main_1): Use gdb::unique_xmalloc_ptr to manage
10307 the memory of the temporary warning_pre_print override.
10308 * utils.c (warning_pre_print): Constify.
10309 * utils.h (warning_pre_print): Constify.
10313 * cli/cli-cmds.c (shell_escape): Constify 'arg' parameter.
10314 (shell_command): New function.
10315 (make_command): Use std::string.
10316 (init_cli_cmds): Register shell_command instead of shell_escape.
10320 * breakpoint.c (dprintf_function, dprintf_channel): Don't initialize.
10321 * tracepoint.c (default_collect): Don't initialize.
10325 * macroexp.c (macro_buffer::shared): Now a bool.
10326 (init_buffer): Update.
10327 (init_shared_buffer): Constify 'addr' parameter.
10328 (substitute_args, expand, macro_expand, macro_expand_next): Remove
10333 * arm-tdep.c (show_disassembly_style_sfunc): Constify local.
10334 * disasm.c (set_disassembler_options): Constify local.
10335 * i386-tdep.c (i386_print_insn): Remove cast and FIXME comment.
10340 * tracefile.c (tsave_command): Fix argument parsing for '-r'
10345 * frame.c (frame_unwind_register_unsigned): Call
10346 frame_unwind_register_value.
10350 * gdb.threads/thread-specific-bp.exp (check_thread_specific_breakpoint):
10351 Use gdb_test_multiple, and don't match anchor.
10355 * MAINTAINERS (Global Maintainers): Add Simon Marchi.
10356 (Write After Approval): Remove Simon Marchi.
10360 * common/gdb_optional.h (optional::optional): Make constexpr and
10361 initialize m_dummy.
10365 * amd64-fbsd-tdep.c: Remove "bsd-uthread.h" include.
10366 (amd64fbsd_jmp_buf_reg_offset): Remove.
10367 (amd64fbsd_supply_uthread): Remove function.
10368 (amd64fbsd_collect_uthread): Remove function.
10369 (amd64fbsd_init_abi): Don't set bsd-uthread callbacks.
10370 * configure.tgt (i[34567]86-*-freebsd*): Remove bsd-uthread.o.
10371 (x86_64-*-freebsd*): Remove bsd-uthread.o.
10372 (fbsd-nat.c): Update comment.
10373 * i386-fbsd-tdep.c: Remove "bsd-uthread.h" include.
10374 (i386fbsd_jmp_buf_reg_offset): Remove.
10375 (i386fbsd_supply_uthread): Remove function.
10376 (i386fbsd_collect_uthread): Remove function.
10377 (i386fbsd_init_abi): Don't set bsd-uthread callbacks.
10381 * Makefile.in (ALL_64_TARGET_OBS): Remove alpha-fbsd-tdep.o.
10382 (ALLDEPFILES): Remove alpha-fbsd-tdep.c
10383 * NEWS: Mention that support for FreeBSD/alpha was removed.
10384 * alpha-fbsd-tdep.c: Delete file.
10385 * config/alpha/fbsd.mh: Delete file.
10386 * configure.host: Delete alpha*-*-freebsd* and
10387 alpha*-*-kfreebsd*-gnu.
10388 * configure.tgt: Delete alpha*-*-freebsd* and
10389 alpha*-*-kfreebsd*-gnu.
10393 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers,
10394 amd64bsd_store_inferior_registers): Use ptid from regcache.
10398 * dwarf2read.c (lnp_state_machine): Now a class. Initialize all
10399 data fields, make them private and add "m_" prefixes.
10400 (lnp_state_machine::lnp_state_machine): New ctor.
10401 (record_line, check_line_address, handle_set_discriminator)
10402 (handle_set_address, handle_advance_pc, handle_special_opcode)
10403 (handle_advance_line, handle_set_file, handle_negate_stmt)
10404 (handle_const_add_pc, handle_fixed_advance_pc, handle_copy)
10405 (end_sequence, advance_line): New methods.
10406 (m_gdbarch, m_record_lines_p): New fields.
10407 (lnp_reader_state): Delete.
10408 (dwarf_record_line): Rename to ...
10409 (lnp_state_machine::record_line): ... adjust.
10410 (init_lnp_state_machine): Delete.
10411 (lnp_state_machine::lnp_state_machine): New.
10412 (check_line_address): Rename to ...
10413 (lnp_state_machine::check_line_address): This.
10414 (dwarf_decode_lines_1): Remove reference to "reader_state".
10415 Adjust lnp_state_machine having a non-default ctor. Use bool.
10416 State machine internal state manipulation moved to
10417 lnp_state_machine methods.
10421 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10422 unittests/offset-type-selftests.c.
10423 (SUBDIR_UNITTESTS_OBS): Add offset-type-selftests.o.
10424 * common/offset-type.h: New file.
10425 * common/preprocessor.h: New file.
10426 * common/traits.h: New file.
10427 * common/valid-expr.h: New file.
10428 * dwarf2expr.c: Include "common/underlying.h". Adjust to use
10429 sect_offset and cu_offset strong typedefs throughout.
10430 * dwarf2expr.h: Adjust to use sect_offset and cu_offset strong
10431 typedefs throughout.
10432 * dwarf2loc.c: Include "common/underlying.h". Adjust to use
10433 sect_offset and cu_offset strong typedefs throughout.
10434 * dwarf2read.c: Adjust to use sect_offset and cu_offset strong
10435 typedefs throughout.
10436 * gdbtypes.h: Include "common/offset-type.h".
10437 (cu_offset): Now an offset type (strong typedef) instead of a
10439 (sect_offset): Likewise.
10440 (union call_site_parameter_u): Rename "param_offset" field to
10442 * unittests/offset-type-selftests.c: New file.
10446 * common/underlying.h: New file.
10447 * dwarf2read.c: Include "common/gdb_optional.h" and
10448 "common/underlying.h".
10449 (dir_index, file_name_index): New types.
10450 (file_entry): Use them.
10451 (file_entry::include): Use to_underlying.
10452 (line_header::add_file_name): Use dir_index.
10453 (read_formatted_entries): Use gdb::optional. Read form before
10454 writting to file_entry.
10455 (dwarf_decode_line_header): Use dir_index.
10456 (lnp_state_machine::current_file): Use to_underlying.
10457 (lnp_state_machine::file): Change type to file_name_index.
10458 (dwarf_record_line): Use to_underlying.
10459 (init_lnp_state_machine): Use file_name_index.
10460 (dwarf_decode_lines_1): Use dir_index and file_name_index.
10464 * common/gdb_optional.h (gdb::optiona): Add operator->, operator*,
10465 operator bool, has_value and get methods.
10469 * dwarf2read.c (struct file_entry): Add ctors, and initialize all
10471 (line_header): Initialize all data fields. Change type of
10472 standard_opcode_lengths to std::unique_ptr<unsigned char[]>.
10473 Change type of include_dirs to std::vector<const char *>. Remove
10474 num_include_dirs, include_dirs_size. Change type of file_names to
10475 std::vector<file_entry>. Remove num_file_names, file_names_size.
10476 (line_header::line_header): New.
10477 (line_header::add_include_dir, line_header::add_file_name): New
10479 (line_header::include_dir_at): Remove NULL check.
10480 (line_header::file_name_at): Add const overload.
10481 (line_header_up): New unique_ptr typedef.
10482 (dw2_get_file_names_reader): Use line_header_up. Adjust to use
10483 std::vector. Remove free_line_header call.
10484 (dwarf2_build_include_psymtabs): Use line_header_up. Remove
10485 free_line_header call.
10486 (free_cu_line_header): Delete.
10487 (handle_DW_AT_stmt_list, handle_DW_AT_stmt_list)
10488 (setup_type_unit_groups): Use line_header_up instead of cleanups.
10489 Adjust to use std::vector.
10490 (free_line_header): Delete.
10491 (free_line_header_voidp): Use delete.
10492 (add_include_dir): Replace with ...
10493 (line_header::add_include_dir): ... this method. Use std::vector.
10494 (add_file_name): Replace with ...
10495 (line_header::add_file_name): ... this method. Use std::vector.
10496 (add_include_dir_stub): Delete.
10497 (read_formatted_entries): Remove memset.
10498 (dwarf_decode_line_header): Return a line_header_up instead of a
10499 raw pointer. Remove cleanup handling. Pass lambdas to
10500 read_formatted_entries. Adjust to use line_header methods.
10501 (dwarf_decode_lines_1): Adjust to use line_header methods.
10502 (dwarf_decode_lines, file_file_name, file_full_name): Adjust to
10507 * remote.c (set_general_thread, set_continue_thread): Use ptid_t
10508 instead of struct ptid.
10512 * frame.c (get_frame_register_bytes): Unwind using value.
10513 (put_frame_register_bytes): Likewise.
10517 * d-exp.y (type_aggregate_p): Treat TYPE_CODE_MODULE as being
10522 * auto-load.c (auto_load_section_scripts): Check SEC_HAS_CONTENTS.
10526 * gdbthread.h (struct thread_info): Declare constructor and
10527 destructor. Add some in-class member initializers.
10528 * thread.c (free_thread): Remove.
10529 (init_thread_list): Call delete instead of free_thread.
10530 (new_thread): Call thread_info constructor.
10531 (thread_info::thread_info): New function.
10532 (thread_info::~thread_info): New function.
10533 (delete_thread_1): Call delete instead of free_thread.
10534 (make_cleanup_restore_current_thread): Move tp and frame to
10539 * arc-tdep.c (arc_frame_cache): Add support for prologue analysis.
10540 (arc_skip_prologue): Likewise.
10541 (arc_make_frame_cache): Likewise.
10542 (arc_pv_get_operand): New function.
10543 (arc_is_in_prologue): Likewise.
10544 (arc_analyze_prologue): Likewise.
10545 (arc_print_frame_cache): Likewise.
10546 (MAX_PROLOGUE_LENGTH): New constant.
10550 * configure.tgt: Add arc-insn.o.
10551 * arc-tdep.c (arc_delayed_print_insn): Make non-static.
10552 (dump_arc_instruction_command): New function.
10553 (arc_fprintf_disasm): Likewise.
10554 (arc_disassemble_info): Likewise.
10555 (arc_insn_get_operand_value): Likewise.
10556 (arc_insn_get_operand_value_signed): Likewise.
10557 (arc_insn_get_memory_base_reg): Likewise.
10558 (arc_insn_get_memory_offset): Likewise.
10559 (arc_insn_get_branch_target): Likewise.
10560 (arc_insn_dump): Likewise.
10561 (arc_insn_get_linear_next_pc): Likewise.
10562 * arc-tdep.h (arc_delayed_print_insn): Add function declaration.
10563 (arc_disassemble_info): Likewise.
10564 (arc_insn_get_branch_target): Likewise.
10565 (arc_insn_get_linear_next_pc): Likewise.
10566 * NEWS: Mention new "maint print arc arc-instruction".
10570 * arc-tdep (maintenance_print_arc_list): New variable.
10571 (maintenance_print_arc_command): New function.
10575 * arc-tdep.c (core_v2_register_names, core_arcompact_register_names)
10576 Add "limm" and "reserved".
10577 (arc_cannot_fetch_register, arc_cannot_store_register): Add
10578 ARC_RESERVED_REGNUM and ARC_LIMM_REGNUM.
10579 * arc-tdep.h (arc_regnum): Likewise.
10583 * xtensa-linux-nat.c (fill_gregset): Call regcache_raw_collect
10584 for THREADPTR register.
10585 (supply_gregset_reg): Call regcache_raw_supply for THREADPTR
10587 * xtensa-tdep.c (XTENSA_DBREGN_UREG): New definition.
10588 (xtensa_derive_tdep): Initialize tdep->threadptr_regnum.
10589 * xtensa-tdep.h (gdbarch_tdep::threadptr_regnum): New field.
10593 * xtensa-tdep.c (xtensa_pseudo_register_read): Treat all
10594 registers above gdbarch_num_regs (gdbarch) as privileged in
10599 * xtensa-linux-nat.c (fill_gregset): Call regcache_raw_collect
10600 for a single specified register or for all registers in
10601 a0_base..a0_base + C0_NREGS range.
10602 (supply_gregset_reg): Call regcache_raw_supply for a single
10603 specified register or for all registers in a0_base..a0_base +
10608 * arch/xtensa.h (C0_NREGS): Add definition.
10609 * xtensa-tdep.c (C0_NREGS): Remove definition.
10613 * xtensa-tdep.c (xtensa_scan_prologue, call0_analyze_prologue):
10614 Drop xtensa_default_isa initialization.
10615 (xtensa_gdbarch_init): Initialize xtensa_default_isa.
10619 * dwarf2read.c (file_entry) <dir_index>: Add comment.
10620 (file_entry::include_dir): New method.
10621 (line_header::include_dir_at, line_header::file_name_at): New
10623 (setup_type_unit_groups, setup_type_unit_groups)
10624 (psymtab_include_file_name): Simplify using the new methods.
10625 (lnp_state_machine) <the_line_header>: New field.
10626 <file>: Add comment.
10627 (lnp_state_machine::current_file): New method.
10628 (dwarf_record_line): Simplify using the new methods.
10629 (init_lnp_state_machine): Initialize the "the_line_header" field.
10630 (dwarf_decode_lines_1, dwarf_decode_lines, file_file_name):
10631 Simplify using the new methods.
10635 * cp-name-parser.y (make_empty): Delete.
10636 (demangler_special, nested_name, ptr_operator, array_indicator)
10637 (direct_declarator, declarator_1): Use fill_comp instead of
10642 * xml-support.h (gdb_xml_debug): Pass a "first-to-check" argument
10643 to ATTRIBUTE_PRINTF.
10644 * solib-target.c (library_list_start_list): Print "string" not
10646 * xml-tdesc.c (tdesc_start_field): Pass "field_name" to
10647 gdb_xml_error call.
10651 * dwarf2read.c (struct file_and_directory): New.
10652 (dwarf2_get_dwz_file): Adjust to use std::string.
10653 (dw2_get_file_names_reader): Adjust to use file_and_directory.
10654 (find_file_and_directory): Adjust to return a file_and_directory
10656 (read_file_scope): Adjust to use file_and_directory. Remove
10657 make_cleanup/do_cleanups calls.
10658 (open_and_init_dwp_file): Adjust to use std::string. Remove
10659 make_cleanup/do_cleanups calls.
10660 * python/python.c (do_start_initialization): Adjust to ldirname
10661 returning a std::string.
10662 * utils.c (ldirname): Now returns a std::string.
10663 * utils.h (ldirname): Change return type to std::string.
10664 * xml-syscall.c (xml_init_syscalls_info): Adjust to ldirname
10665 returning a std::string.
10666 * xml-tdesc.c (file_read_description_xml): Likewise.
10670 * regcache.c (regcache_debug_print_register): New function.
10671 * regcache.h (regcache_debug_print_register): New declaration.
10672 * target.c (debug_print_register): Remove.
10673 (target_fetch_registers): Call regcache_debug_print_register.
10674 (target_store_registers): Likewise.
10678 * dwarf2read.c (setup_type_unit_groups): Ensure dir_index doesn't
10679 reference beyond the 'lh->include_dirs' array before accessing to
10681 (psymtab_include_file_name): Likewise.
10682 (dwarf_decode_lines_1): Likewise.
10683 (dwarf_decode_lines): Likewise.
10684 (file_file_name): Likewise.
10688 * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore
10690 * proc-service.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs,
10691 ps_lsetfpregs): Likewise.
10692 * regcache.c (regcache_raw_update, regcache_raw_write): Likewise.
10693 * sol-thread.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs,
10694 ps_lsetfpregs): Likewise.
10695 * target.c (target_fetch_registers, target_store_registers):
10700 * sol-thread.c (sol_thread_store_registers): Remove regcache calls.
10704 * aarch64-tdep.c (aarch64_process_record_test): Declare.
10705 (_initialize_aarch64_tdep): Register it.
10706 (aarch64_record_load_store): Handle PRFM instruction.
10707 (aarch64_process_record_test): New function.
10711 * aarch64-tdep.c (aarch64_record_load_store): Fix code
10716 * aarch64-tdep.c: Remove AARCH64_RECORD_FAILURE.
10720 python/python.c (do_start_initialization): Fix memory leak.
10724 * inf-ptrace.c (inf_ptrace_xfer_partial): Get pid from ptid
10725 using get_ptrace_pid.
10726 * linux-nat.c (linux_nat_xfer_partial): Don't set/restore
10728 (linux_proc_xfer_partial, linux_proc_xfer_spu): Use lwp of
10729 inferior_ptid instead of pid.
10733 * aarch64-tdep.c: Wrap locally used classes in anonymous
10735 * arm-tdep.c: Likewise.
10736 * linespec.c: Likewise.
10737 * ui-out.c: Likewise.
10742 * python/lib/gdb/printer/bound_registers.py: Import sys.
10746 * windows-nat.c (do_windows_fetch_inferior_registers): Add
10747 windows_thread_info parameter and use it instead of
10749 (windows_fetch_inferior_registers): Don't set current_thread,
10750 pass the thread to do_windows_fetch_inferior_registers. Use
10751 ptid from regcache instead of inferior_ptid.
10752 (do_windows_store_inferior_registers): Add windows_thread_info
10753 parameter and use it instead of current_thread.
10754 (windows_store_inferior_registers): Don't set current_thread,
10755 pass the thread to do_windows_store_inferior_registers. Use
10756 ptid from regcache instead of inferior_ptid.
10760 * ser-mingw.c (ser_windows_raw): Remove reference to
10761 struct serial::current_timeout.
10766 * gdb/sparc-tdep.h (gdbarch_tdep) <sparc64_ccr_type>: New field.
10767 * gdb/sparc64-tdep.c (sparc64_ccr_type): New function.
10768 (sparc64_fsr_type): Fix %fsr decoding.
10772 * python/py-record-btrace.c (btpy_insn_data): Change return type
10777 * spu-linux-nat.c (spu_fetch_inferior_registers,
10778 spu_store_inferior_registers): Use ptid from regcache, set and
10779 restore inferior_ptid.
10780 * spu-multiarch.c (spu_fetch_registers, spu_store_registers):
10785 * i386-linux-nat.c (fetch_register, store_register,
10786 i386_linux_fetch_inferior_registers,
10787 i386_linux_store_inferior_registers): Use ptid from regcache.
10788 * ia64-linux-nat.c (ia64_linux_fetch_register,
10789 ia64_linux_store_register): Likewise.
10790 * inf-ptrace.c (inf_ptrace_fetch_register,
10791 inf_ptrace_store_register): Likewise.
10792 * m32r-linux-nat.c (m32r_linux_fetch_inferior_registers,
10793 m32r_linux_store_inferior_registers): Likewise.
10794 * m68k-bsd-nat.c (m68kbsd_fetch_inferior_registers,
10795 m68kbsd_store_inferior_registers): Likewise.
10796 * m68k-linux-nat.c (fetch_register, store_register,
10797 m68k_linux_fetch_inferior_registers,
10798 m68k_linux_store_inferior_registers): Likewise.
10799 * m88k-bsd-nat.c (m88kbsd_fetch_inferior_registers,
10800 m88kbsd_store_inferior_registers): Likewise.
10801 * mips-fbsd-nat.c (mips_fbsd_fetch_inferior_registers,
10802 mips_fbsd_store_inferior_registers): Likewise.
10803 * mips-linux-nat.c (mips64_linux_regsets_fetch_registers,
10804 mips64_linux_regsets_store_registers): Likewise.
10805 * mips-nbsd-nat.c (mipsnbsd_fetch_inferior_registers,
10806 mipsnbsd_store_inferior_registers): Likewise.
10807 * mips-obsd-nat.c (mips64obsd_fetch_inferior_registers,
10808 mips64obsd_store_inferior_registers): Likewise.
10809 * nto-procfs.c (procfs_fetch_registers, procfs_store_registers):
10811 * ppc-fbsd-nat.c (ppcfbsd_fetch_inferior_registers,
10812 ppcfbsd_store_inferior_registers): Likewise.
10813 * ppc-linux-nat.c (ppc_linux_fetch_inferior_registers,
10814 ppc_linux_store_inferior_registers): Likewise.
10815 * ppc-nbsd-nat.c (ppcnbsd_fetch_inferior_registers,
10816 ppcnbsd_store_inferior_registers): Likewise.
10817 * ppc-obsd-nat.c (ppcobsd_fetch_registers,
10818 ppcobsd_store_registers): Likewise.
10819 * procfs.c (procfs_fetch_registers, procfs_store_registers):
10821 * ravenscar-thread.c (ravenscar_fetch_registers,
10822 ravenscar_store_registers, ravenscar_prepare_to_store):
10824 * record-btrace.c (record_btrace_fetch_registers,
10825 record_btrace_store_registers, record_btrace_prepare_to_store):
10827 * remote-sim.c (gdbsim_fetch_register, gdbsim_store_register):
10828 Lookup inferior using ptid from regcache, instead of
10830 * remote.c (remote_fetch_registers, remote_store_registers): Use
10831 ptid from regcache.
10832 * rs6000-nat.c (fetch_register, store_register): Likewise.
10833 * s390-linux-nat.c (s390_linux_fetch_inferior_registers,
10834 s390_linux_store_inferior_registers): Likewise.
10835 * sh-nbsd-nat.c (shnbsd_fetch_inferior_registers,
10836 shnbsd_store_inferior_registers): Likewise.
10837 * sol-thread.c (sol_thread_fetch_registers,
10838 sol_thread_store_registers): Likewise.
10839 * sparc-nat.c (sparc_fetch_inferior_registers,
10840 sparc_store_inferior_registers): Likewise.
10841 * tilegx-linux-nat.c (fetch_inferior_registers,
10842 store_inferior_registers): Likewise.
10843 * vax-bsd-nat.c (vaxbsd_fetch_inferior_registers,
10844 vaxbsd_store_inferior_registers): Likewise.
10845 * xtensa-linux-nat.c (fetch_gregs, store_gregs, fetch_xtregs,
10846 store_xtregs): Likewise.
10851 * NEWS: Mention support for rvalue references in GDB and python.
10852 * doc/gdb.texinfo (C Plus Plus Expressions): Mention that GDB
10853 supports both lvalue and rvalue references.
10858 * gdbtypes.c (rank_one_type): Implement overloading
10859 resolution rules regarding rvalue references.
10864 * aarch64-tdep.c (aarch64_type_align)
10865 (aarch64_extract_return_value, aarch64_store_return_value): Change
10866 lvalue reference type checks to general reference type checks.
10867 * amd64-tdep.c (amd64_classify): Likewise.
10868 * amd64-windows-tdep.c (amd64_windows_passed_by_integer_register):
10870 * arm-tdep.c (arm_type_align, arm_extract_return_value)
10871 (arm_store_return_value): Likewise.
10872 * ax-gdb.c (gen_fetch, gen_cast): Likewise.
10873 * c-typeprint.c (c_print_type): Likewise.
10874 * c-varobj.c (adjust_value_for_child_access, c_value_of_variable)
10875 (cplus_number_of_children, cplus_describe_child): Likewise.
10876 * compile/compile-c-symbols.c (generate_vla_size): Likewise.
10877 * completer.c (expression_completer): Likewise.
10878 * cp-support.c (make_symbol_overload_list_adl_namespace):
10880 * darwin-nat-info.c (info_mach_region_command): Likewise.
10881 * dwarf2loc.c (entry_data_value_coerce_ref)
10882 (value_of_dwarf_reg_entry): Likewise.
10883 * eval.c (ptrmath_type_p, evaluate_subexp_standard)
10884 (evaluate_subexp_for_address, evaluate_subexp_for_sizeof):
10886 * findvar.c (extract_typed_address, store_typed_address):
10888 * gdbtypes.c (rank_one_type): Likewise.
10889 * hppa-tdep.c (hppa64_integral_or_pointer_p): Likewise.
10890 * infcall.c (value_arg_coerce): Likewise.
10891 * language.c (pointer_type): Likewise.
10892 * m32c-tdep.c (m32c_reg_arg_type, m32c_m16c_address_to_pointer):
10894 * m88k-tdep.c (m88k_integral_or_pointer_p): Likewise.
10895 * mn10300-tdep.c (mn10300_type_align): Likewise.
10896 * msp430-tdep.c (msp430_push_dummy_call): Likewise.
10897 * ppc-sysv-tdep.c (do_ppc_sysv_return_value)
10898 (ppc64_sysv_abi_push_param, ppc64_sysv_abi_return_value):
10900 * printcmd.c (print_formatted, x_command): Likewise.
10901 * python/py-type.c (typy_get_composite, typy_template_argument):
10903 * python/py-value.c (valpy_referenced_value)
10904 (valpy_get_dynamic_type, value_has_field): Likewise.
10905 * s390-linux-tdep.c (s390_function_arg_integer): Likewise.
10906 * sparc-tdep.c (sparc_integral_or_pointer_p): Likewise.
10907 * sparc64-tdep.c (sparc64_integral_or_pointer_p): Likewise.
10908 * spu-tdep.c (spu_scalar_value_p): Likewise.
10909 * symtab.c (lookup_symbol_aux): Likewise.
10910 * typeprint.c (whatis_exp, print_type_scalar): Likewise.
10911 * valarith.c (binop_types_user_defined_p, unop_user_defined_p):
10913 * valops.c (value_cast_pointers, value_cast)
10914 (value_reinterpret_cast, value_dynamic_cast, value_addr, typecmp)
10915 (value_struct_elt, value_struct_elt_bitpos)
10916 (value_find_oload_method_list, find_overload_match)
10917 (value_rtti_indirect_type): Likewise.
10918 * valprint.c (val_print_scalar_type_p, generic_val_print):
10920 * value.c (value_actual_type, value_as_address, unpack_long)
10921 (pack_long, pack_unsigned_long, coerce_ref_if_computed)
10922 (coerce_ref): Likewise.
10923 * varobj.c (varobj_get_value_type): Likewise.
10928 * doc/python.texi (Types in Python): Add TYPE_CODE_RVALUE_REF to
10929 table of constants.
10930 * python/lib/gdb/command/explore.py: Support exploring values
10931 of rvalue reference types.
10932 * python/lib/gdb/types.py: Implement get_basic_type() for
10933 rvalue reference types.
10934 * python/py-type.c (pyty_codes) <TYPE_CODE_RVALUE_REF>: New
10936 * python/py-value.c (valpy_getitem): Add an rvalue reference
10938 (valpy_reference_value): Add new parameter "refcode".
10939 (valpy_lvalue_reference_value, valpy_rvalue_reference_value):
10940 New wrappers for valpy_reference_value().
10941 * python/py-xmethods.c (gdbpy_get_xmethod_result_type)
10942 (gdbpy_invoke_xmethod): Likewise.
10947 * dwarf2read.c (process_die, read_type_die_1): Handle the
10948 DW_TAG_rvalue_reference_type DIE.
10949 (read_tag_reference_type): Add new parameter "refcode".
10954 * c-typeprint.c (c_print_type, c_type_print_varspec_prefix)
10955 (c_type_print_modifier, c_type_print_varspec_suffix)
10956 (c_type_print_base): Support printing rvalue reference types.
10957 * c-valprint.c (c_val_print, c_value_print): Support printing
10958 rvalue reference values.
10963 * cp-name-parser.y (ptr_operator): Handle the '&&' token in
10965 * cp-support.c (replace_typedefs): Handle
10966 DEMANGLE_COMPONENT_RVALUE_REFERENCE.
10967 * python/py-type.c (typy_lookup_type): Likewise.
10972 * c-exp.y (ptr_operator): Handle the '&&' token in the typename.
10973 * parse.c (insert_type): Change assert statement.
10974 (follow_types): Handle rvalue reference types.
10975 * parser-defs.h (enum type_pieces) <tp_rvalue_reference>: New
10981 * ada-lang.c (ada_evaluate_subexp): Adhere to the new
10982 value_ref() interface.
10983 * c-valprint.c (c_value_print): Likewise.
10984 * infcall.c (value_arg_coerce): Likewise.
10985 * python/py-value.c (valpy_reference_value): Likewise.
10986 * valops.c (value_cast, value_reinterpret_cast)
10987 (value_dynamic_cast, typecmp): Likewise.
10988 (value_ref): Parameterize by kind of return value reference type.
10989 * value.h (value_ref): Add new parameter "refcode".
10994 * dwarf2read.c (read_tag_reference_type): Use
10995 lookup_lvalue_reference_type() instead of lookup_reference_type().
10996 * eval.c (evaluate_subexp_standard): Likewise.
10997 * f-exp.y: Likewise.
10998 * gdbtypes.c (make_reference_type, lookup_reference_type):
10999 Generalize with rvalue reference types.
11000 (lookup_lvalue_reference_type, lookup_rvalue_reference_type): New
11001 convenience wrappers for lookup_reference_type().
11002 * gdbtypes.h (make_reference_type, lookup_reference_type): Add a
11003 reference kind parameter.
11004 (lookup_lvalue_reference_type, lookup_rvalue_reference_type): Add
11005 wrappers for lookup_reference_type().
11006 * guile/scm-type.c (gdbscm_type_reference): Use
11007 lookup_lvalue_reference_type() instead of lookup_reference_type().
11008 * guile/scm-value.c (gdbscm_value_dynamic_type): Likewise.
11009 * parse.c (follow_types): Likewise.
11010 * python/py-type.c (typy_reference, typy_lookup_type): Likewise.
11011 * python/py-value.c (valpy_get_dynamic_type, valpy_getitem):
11013 * python/py-xmethods.c (gdbpy_get_xmethod_result_type)
11014 (gdbpy_invoke_xmethod): Likewise.
11015 * stabsread.c: Provide extra argument to make_reference_type()
11017 * valops.c (value_ref, value_rtti_indirect_type): Use
11018 lookup_lvalue_reference_type() instead of lookup_reference_type().
11023 * gdbtypes.h (enum type_code) <TYPE_CODE_RVALUE_REF>: New constant.
11024 (TYPE_IS_REFERENCE): New macro.
11025 (struct type): Add rvalue_reference_type field.
11026 (TYPE_RVALUE_REFERENCE_TYPE): New macro.
11030 * NEWS: Add an entry about new '-file-list-shared-libraries' command.
11031 * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries):
11032 New function definition.
11033 * mi/mi-cmds.c (mi_cmds): Add -file-list-shared-libraries command.
11034 * mi/mi-cmds.h (mi_cmd_file_list_shared_libraries):
11035 New function declaration.
11036 * mi/mi-interp.c (mi_output_solib_attribs): New Function.
11037 * mi/mi-interp.h: New file.
11038 * solib.c (info_sharedlibrary_command): Replace for loop with
11040 * solib.h (update_solib_list): New function declaration.
11041 (so_list_head): Move macro.
11042 * solist.h (ALL_SO_LIBS): New macro.
11046 * infcmd.c (post_create_inferior): Remove unused argument in
11048 * remote.c (remote_start_remote): Likewise.
11049 * solib-frv.c (frv_fetch_objfile_link_map): Likewise.
11050 * solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise.
11051 (enable_break): Likewise.
11052 * solib.c (update_solib_list): Remove unused target argument
11053 and its documentation.
11054 (solib_add): Remove unused target argument. Remove unused
11055 argument in call to update_solib_list.
11056 (info_sharedlibrary_command): Remove unused argument in call
11057 to update_solib_list.
11058 (sharedlibrary_command): Remove unused argument in call to
11060 (handle_solib_event): Likewise.
11061 (reload_shared_libraries): Likewise.
11062 * solib.h (solib_add): Remove unused target argument.
11066 * s390-linux-tdep.c (is_rsi, is_rie): Remove functions.
11067 (s390_displaced_step_fixup): Cover relative branches with the
11068 default fixup handling. This fixes lack of support for some
11069 relative branch instructions.
11073 * i386-gnu-nat.c (gnu_fetch_registers, gnu_store_registers): Use
11074 ptid from regcache.
11078 * i386-darwin-nat.c (i386_darwin_fetch_inferior_registers,
11079 i386_darwin_store_inferior_registers): Use ptid from regcache.
11083 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers,
11084 i386bsd_store_inferior_registers): Use ptid from regcache.
11088 * hppa-obsd-nat.c (hppaobsd_fetch_registers,
11089 hppaobsd_store_registers): Use ptid from regcache.
11093 * hppa-nbsd-nat.c (hppanbsd_fetch_registers,
11094 hppanbsd_store_registers): Use ptid from regcache.
11098 * hppa-linux-nat.c (fetch_register, store_register): Use ptid
11099 from regcache. Use get_ptrace_pid.
11103 * corelow.c (get_core_register_section): Use ptid from regcache,
11108 * bsd-uthread.c (bsd_uthread_fetch_registers,
11109 bsd_uthread_store_registers): Use ptid from regcache, set and
11110 restore inferior_ptid.
11114 * arm-nbsd-nat.c (fetch_register, fetch_regs, fetch_fp_register,
11115 fetch_fp_regs, store_register, store_regs, store_fp_register,
11116 store_fp_regs): Use ptid from regcache.
11120 * arm-linux-nat.c (fetch_fpregs, store_fpregs, fetch_regs,
11121 store_regs, fetch_wmmx_regs, store_wmmx_regs, fetch_vfp_regs,
11122 store_vfp_regs): Use ptid from regcache.
11127 * ser-base.c (ser_base_wait_for): Add comment.
11128 (do_ser_base_readchar): Improve comment based on the ser-unix.c's
11130 * ser-unix.c (hardwire_raw): Remove reference to
11131 scb->current_timeout.
11132 (wait_for, do_hardwire_readchar, hardwire_readchar): Delete.
11133 (hardwire_ops): Install ser_base_readchar instead of
11135 * serial.h (struct serial) <current_timeout, timeout_remaining>:
11141 * python/lib/gdb/printer/bound_registers.py: Add support for
11146 * dwarf2loc.c (indirect_synthetic_pointer): Get data type of
11147 pointed-to DIE and pass it to dwarf2_evaluate_loc_desc_full.
11148 (dwarf2_evaluate_loc_desc_full): New parameter subobj_type; rename
11149 byte_offset to subobj_byte_offset. Fix the handling of
11150 DWARF_VALUE_STACK on big-endian targets when coming via an
11152 (dwarf2_evaluate_loc_desc): Adjust call to
11153 dwarf2_evaluate_loc_desc_full.
11154 * dwarf2loc.h (dwarf2_fetch_die_type_sect_off): New declaration.
11155 * dwarf2read.c (dwarf2_fetch_die_type_sect_off): New function.
11159 * arm-tdep.c (thumb_record_misc): Decode CBNZ, CBZ, REV16,
11160 and REVSH instructions.
11164 * arm-tdep.c [GDB_SELF_TEST]: include "selftests.h".
11165 (arm_record_test): Declare.
11166 (_initialize_arm_tdep) [GDB_SELF_TEST]: call register_self_test.
11167 (thumb_record_ld_st_reg_offset): Rewrite the opcode matching to
11168 align with the manual.
11169 (thumb_record_misc): Adjust the code order to align with the
11171 (thumb2_record_decode_insn_handler): Fix instruction matching.
11172 (instruction_reader_thumb): New class.
11173 (arm_record_test): New function.
11177 * arm-tdep.c (abstract_memory_reader): New class.
11178 (instruction_reader): New class.
11179 (extract_arm_insn): Add argument 'reader'. Callers updated.
11180 (decode_insn): Likewise.
11184 * guile/scm-lazy-string.c (lazy_string_smob): Clarify use of LENGTH
11185 member. Change type of TYPE member to SCM. All uses updated.
11186 (lsscm_make_lazy_string_smob): Add assert.
11187 (lsscm_make_lazy_string): Flag bad length values.
11188 (lsscm_elt_type): New function.
11189 (gdbscm_lazy_string_to_value): Rewrite to use
11190 lsscm_safe_lazy_string_to_value.
11191 (lsscm_safe_lazy_string_to_value): Fix handling of TYPE_CODE_PTR.
11192 * guile/scm-value.c (gdbscm_value_to_lazy_string): Flag bad length
11193 values. Fix TYPE_CODE_PTR. Handle TYPE_CODE_ARRAY. Handle typedefs
11195 * guile/guile-internal.h (tyscm_scm_to_type): Declare.
11196 * guile/scm-type.c (tyscm_scm_to_type): New function.
11200 PR python/17728, python/18439, python/18779
11201 * python/py-lazy-string.c (lazy_string_object): Clarify use of LENGTH
11202 member. Change type of TYPE member to PyObject *. All uses updated.
11203 (stpy_convert_to_value): Fix handling of TYPE_CODE_PTR.
11204 (gdbpy_create_lazy_string_object): Flag bad length values.
11205 Handle TYPE_CODE_ARRAY with possibly different user-provided length.
11206 Handle typedefs in incoming type.
11207 (stpy_lazy_string_elt_type): New function.
11208 (gdbpy_extract_lazy_string): Call it.
11209 * python/py-value.c (valpy_lazy_string): Flag bad length values.
11210 Fix handling of TYPE_CODE_PTR. Handle TYPE_CODE_ARRAY. Handle
11211 typedefs in incoming type.
11215 * guile/guile-internal.h (tyscm_scm_to_type): Declare.
11216 * guile/scm-type.c (tyscm_scm_to_type): New function.
11220 * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to
11221 "ULONGEST" for "skip".
11226 * inf-ptrace.c (inf_ptrace_xfer_partial): In "case
11227 TARGET_OBJECT_MEMORY", extract the logic for ptrace peek/poke...
11228 (inf_ptrace_peek_poke): ...here. New function. Now also loop
11229 over ptrace peek/poke until end of buffer or error.
11233 * parse.c (length_of_subexp): Make static.
11234 * parser-defs.h (length_of_subexp): Remove.
11238 * linux-nat.c (linux_proc_xfer_partial): Handle write operations
11243 * cp-name-parser.y (cp_demangled_name_to_comp): Update comment.
11244 (main): Use std::unique_ptr. Remove calls to
11245 cp_demangled_name_parse_free.
11249 * alpha-bsd-nat.c (alphabsd_fetch_inferior_registers,
11250 alphabsd_store_inferior_registers): Use regcache->ptid instead
11255 * aix-thread.c (aix_thread_fetch_registers,
11256 aix_thread_store_registers): Use regcache->ptid instead of
11261 * aarch64-linux-nat.c (fetch_gregs_from_thread,
11262 store_gregs_to_thread, fetch_fpregs_from_thread,
11263 store_fpregs_to_thread): Use regcache->ptid instead of
11268 * amd64-linux-nat.c (amd64_linux_fetch_inferior_registers,
11269 amd64_linux_fetch_inferior_registers): Use regcache->ptid
11270 instead of inferior_ptid.
11274 * target.c (target_fetch_registers, target_store_registers): Add
11279 * regcache.h (regcache_get_ptid): New function.
11280 * regcache.c (regcache_get_ptid): New function.
11284 * cp-name-parser.y (make_empty): Initialize d_printing to zero.
11289 * c-typeprint.c (cp_type_print_method_args): Skip artificial arguments.
11294 * infrun.c (start_step_over, do_target_resume, resume)
11295 (restart_threads): Assert we're not resuming a thread that is
11296 meant to be stopped.
11297 (infrun_thread_stop_requested_callback): Delete.
11298 (infrun_thread_stop_requested): If the thread is internally
11299 stopped, queue a pending stop event and clear the thread's
11300 inline-frame state.
11301 (handle_stop_requested): New function.
11302 (handle_syscall_event, handle_inferior_event_1): Use
11303 handle_stop_requested.
11304 (handle_stop_requested): New function.
11305 (handle_signal_stop): Set the thread's stop_signal here instead of
11307 (finish_step_over): Clear step over info unconditionally.
11308 (handle_signal_stop): If the user had interrupted the event
11309 thread, consider the stop a random signal.
11310 (handle_signal_stop) <signal arrived while stepping over
11311 breakpoint>: Don't restart threads here.
11312 (stop_waiting): Don't clear step-over info here.
11317 * common/gdb_unlinker.h (unlinker::unlinker): Attribute nonnull
11318 goes to argument 2, not 1.
11323 * top.c (gdb_readline_wrapper): Avoid passing NULL to
11324 display_gdb_prompt.
11325 (command_line_input): Add comment.
11330 * tui/tui-file.c (tui_file::write): New.
11331 * tui/tui-file.h (tui_file): Override "write".
11332 * tui/tui-io.c (do_tui_putc, update_start_line): New functions,
11333 factored out from ...
11334 (tui_puts): ... here.
11335 (tui_putc): Use them.
11336 (tui_write): New function.
11337 * tui/tui-io.h (tui_write): Declare.
11341 * Makefile.in (SFILES): Replace "environ.c" with
11342 "common/environ.c".
11343 (HFILES_NO_SRCDIR): Likewise, for "environ.h".
11344 * environ.c: Include "common-defs.h" instead of "defs.h. Moved
11346 * common/environ.c: ... here.
11347 * environ.h: Moved to...
11348 * common/environ.h: ... here.
11352 * gdbarch.sh (pstring_ptr): New static function.
11353 (gdbarch_disassembler_options): Use it.
11354 (gdbarch_verify_disassembler_options): Print valid_disassembler_options,
11355 not valid_disassembler_option->name.
11356 * gdbarch.c: Regenerate.
11360 * config/powerpc/ppc64-linux.mh (MH_CFLAGS): Delete.
11364 * tui/tui-regs.c (tui_restore_gdbout): Don't delete gdb_stdout.
11368 * i387-tdep.h (i387_reset_bnd_regs): Add function definition.
11369 * i387-tdep.c (i387_reset_bnd_regs): Add function implementation.
11370 * i386-tdep.c (i386_push_dummy_call): Call i387_reset_bnd_regs.
11371 * amd64-tdep.c (amd64_push_dummy_call): Call i387_reset_bnd_regs.
11375 * xtensa-linux-nat.c (fetch_gregs): Remove const.
11379 * remote.c (remote_add_target_side_commands): Use range-based
11385 * ada-valprint.c (ada_val_print_ref): Call value_fetch_lazy if
11387 * valprint.c (common_val_print): Likewise.
11391 * NEWS: Mention new set/show disassembler-options commands.
11392 * doc/gdb.texinfo: Document new set/show disassembler-options commands.
11393 * disasm.c: Include "arch-utils.h", "gdbcmd.h" and "safe-ctype.h".
11394 (prospective_options): New static variable.
11395 (gdb_disassembler::gdb_disassembler): Initialize
11396 m_di.disassembler_options.
11397 (gdb_buffered_insn_length_init_dis): Initilize di->disassembler_options.
11398 (get_disassembler_options): New function.
11399 (set_disassembler_options): Likewise.
11400 (set_disassembler_options_sfunc): Likewise.
11401 (show_disassembler_options_sfunc): Likewise.
11402 (disassembler_options_completer): Likewise.
11403 (_initialize_disasm): Likewise.
11404 * disasm.h (get_disassembler_options): New prototype.
11405 (set_disassembler_options): Likewise.
11406 * gdbarch.sh (gdbarch_disassembler_options): New variable.
11407 (gdbarch_verify_disassembler_options): Likewise.
11408 * gdbarch.c: Regenerate.
11409 * gdbarch.h: Likewise.
11410 * arm-tdep.c (num_disassembly_options): Delete.
11411 (set_disassembly_style): Likewise.
11412 (arm_disassembler_options): New static variable.
11413 (set_disassembly_style_sfunc): Convert short style name into long
11414 option name. Call set_disassembler_options.
11415 (show_disassembly_style_sfunc): New function.
11416 (arm_gdbarch_init): Call set_gdbarch_disassembler_options and
11417 set_gdbarch_verify_disassembler_options.
11418 (_initialize_arm_tdep): Delete regnames variable and update callers.
11419 (arm_disassembler_options): Initialize.
11420 (disasm_options): New variable.
11421 (num_disassembly_options): Rename from this...
11422 (num_disassembly_styles): ...to this. Compute by scanning through
11424 (valid_disassembly_styles): Initialize using disasm_options.
11425 Remove calls to parse_arm_disassembler_option, get_arm_regnames and
11426 set_arm_regname_option.
11427 Pass show_disassembly_style_sfunc to the "disassembler" setshow command.
11428 * rs6000-tdep.c (powerpc_disassembler_options): New static variable.
11429 (rs6000_gdbarch_init): Call set_gdbarch_disassembler_options and
11430 set_gdbarch_verify_disassembler_options.
11431 * s390-tdep.c (s390_disassembler_options): New static variable.
11432 (s390_gdbarch_init):all set_gdbarch_disassembler_options and
11433 set_gdbarch_verify_disassembler_options.
11437 * remote.c (remote_add_target_side_condition): Remove "struct"
11438 keyword from range-based for loop.
11442 * remote.c (remote_add_target_side_condition): Use range-based
11443 for loop. Update comment.
11447 * f-typeprint.c (f_print_type): Check "varstring" is empty first.
11451 * regcache.c (regcache_raw_update): New function.
11452 (regcache_raw_read): Move code to regcache_raw_update.
11453 * regcache.h (regcache_raw_update): New declaration.
11454 * remote.c (remote_prepare_to_store): Call regcache_raw_update.
11458 * dwarf2read.c (create_debug_type_hash_table): Initialize
11459 header.signature and header.type_offset_in_tu.
11463 * symtab.c (make_file_symbol_completion_list_1): Use
11464 add_symtab_completions.
11468 * stack.c (frame_info): Use frame_unwind_register_value to avoid buf.
11472 * i386-tdep.c (i386_pseudo_register_read_into_value): Use
11473 I386_MAX_REGISTER_SIZE.
11474 (i386_pseudo_register_write): Likewise.
11475 (i386_process_record): Likewise.
11476 * i387-tdep.c (i387_supply_xsave): Likewise.
11477 * m68k-linux-nat.c (fetch_register): Use M68K_MAX_REGISTER_SIZE.
11478 (store_register): Likewise.
11482 * ada-lang.c: Include "common/function-view.h".
11483 (ada_iterate_over_symbols): Adjust to use function_view as
11485 (struct add_partial_datum, ada_complete_symbol_matcher): Delete.
11486 (ada_make_symbol_completion_list): Use a lambda.
11487 (ada_exc_search_name_matches): Delete.
11488 (name_matches_regex): New.
11489 (ada_add_global_exceptions): Use a lambda and name_matches_regex.
11490 * compile/compile-c-support.c: Include "common/function-view.h".
11491 (print_one_macro): Change prototype to accept a ui_file pointer.
11492 (write_macro_definitions): Use a lambda.
11493 * dwarf2read.c: Include "common/function-view.h".
11494 (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
11495 (dw2_expand_symtabs_matching): Adjust to use function_view as
11497 * language.h: Include "common/function-view.h".
11498 (struct language_defn) <la_iterate_over_symbols>: Adjust to use
11499 function_view as callback type.
11500 (LA_ITERATE_OVER_SYMBOLS): Remove DATA parameter.
11501 * linespec.c: Include "common/function-view.h".
11502 (collect_info::add_symbol): New method.
11503 (struct symbol_and_data_callback, iterate_inline_only, struct
11504 symbol_matcher_data, iterate_name_matcher): Delete.
11505 (iterate_over_all_matching_symtabs): Adjust to use function_view
11506 as callback type and lambdas.
11507 (iterate_over_file_blocks): Adjust to use function_view as
11509 (decode_compound_collector): Now a class with private fields.
11510 (decode_compound_collector::release_symbols): New method.
11511 (collect_one_symbol): Rename to...
11512 (decode_compound_collector::operator()): ... this and adjust.
11513 (lookup_prefix_sym): decode_compound_collector construction bits
11514 move to decode_compound_collector ctor. Pass the
11515 decode_compound_collector object directly as callback. Remove
11516 cleanups and use decode_compound_collector::release_symbols
11518 (symtab_collector): Now a class with private fields.
11519 (symtab_collector::release_symtabs): New method.
11520 (add_symtabs_to_list): Rename to...
11521 (symtab_collector::operator()): ... this and adjust.
11522 (collect_symtabs_from_filename): symtab_collector construction
11523 bits move to symtab_collector ctor. Pass the symtab_collector
11524 object directly as callback. Remove cleanups and use
11525 symtab_collector::release_symtabs instead.
11526 (collect_symbols): Delete.
11527 (add_matching_symbols_to_info): Use lambdas.
11528 * macrocmd.c (print_macro_callback): Delete.
11529 (info_macro_command): Use a lambda.
11530 (info_macros_command): Pass print_macro_definition as callable
11532 (print_one_macro): Remove 'ignore' parameter.
11533 (macro_list_command): Adjust.
11534 * macrotab.c (macro_for_each_data::fn): Now a function_view.
11535 (macro_for_each_data::user_data): Delete field.
11536 (foreach_macro): Adjust to call the function_view.
11537 (macro_for_each): Adjust to use function_view as callback type.
11538 (foreach_macro_in_scope): Adjust to call the function_view.
11539 (macro_for_each_in_scope): Adjust to use function_view as callback
11541 * macrotab.h: Include "common/function-view.h".
11542 (macro_callback_fn): Declare a prototype instead of a pointer.
11543 Remove "user_data" parameter.
11544 (macro_for_each, macro_for_each_in_scope): Adjust to use
11545 function_view as callback type.
11546 * psymtab.c (partial_map_expand_apply)
11547 (psym_map_symtabs_matching_filename, recursively_search_psymtabs):
11548 Adjust to use function_view as callback type and to return bool.
11549 (psym_expand_symtabs_matching): Adjust to use function_view as
11551 * symfile-debug.c (debug_qf_map_symtabs_matching_filename): Adjust
11552 to use function_view as callback type and to return bool.
11553 (debug_qf_expand_symtabs_matching): Adjust to use function_view as
11555 * symfile.c (expand_symtabs_matching): Adjust to use function_view
11557 * symfile.h: Include "common/function-view.h".
11558 (expand_symtabs_file_matcher_ftype)
11559 (expand_symtabs_symbol_matcher_ftype)
11560 (expand_symtabs_exp_notify_ftype): Remove "data" parameter and
11562 (quick_symbol_functions::map_symtabs_matching_filename)
11563 (quick_symbol_functions::expand_symtabs_matching): Adjust to use
11564 function_view as callback type and return bool.
11565 (expand_symtabs_matching): Adjust to use function_view as callback
11567 (maintenance_expand_name_matcher)
11568 (maintenance_expand_file_matcher): Delete.
11569 (maintenance_expand_symtabs): Use lambdas.
11570 * symtab.c (iterate_over_some_symtabs): Adjust to use
11571 function_view as callback types and return bool.
11572 (iterate_over_symtabs): Likewise. Use unique_xmalloc_ptr instead
11574 (lookup_symtab_callback): Delete.
11575 (lookup_symtab): Use a lambda.
11576 (iterate_over_symbols): Adjust to use function_view as callback
11578 (struct search_symbols_data, search_symbols_file_matches)
11579 (search_symbols_name_matches): Delete.
11580 (search_symbols): Use a pair of lambdas.
11581 (struct add_name_data, add_macro_name, symbol_completion_matcher)
11582 (symtab_expansion_callback): Delete.
11583 (default_make_symbol_completion_list_break_on_1): Use lambdas.
11584 * symtab.h: Include "common/function-view.h".
11585 (iterate_over_some_symtabs): Adjust to use function_view as
11586 callback type and return bool.
11587 (iterate_over_symtabs): Adjust to use function_view as callback
11589 (symbol_found_callback_ftype): Remove 'data' parameter and return
11591 (iterate_over_symbols): Adjust to use function_view as callback
11596 * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New.
11597 (%.o) <unittests/%.c>: New pattern.
11598 * configure.ac ($development): Add $(SUBDIR_UNITTESTS_OBS) to
11599 CONFIG_OBS, and $(SUBDIR_UNITTESTS_SRCS) to CONFIG_SRCS.
11600 * common/function-view.h: New file.
11601 * unittests/function-view-selftests.c: New file.
11602 * configure: Regenerate.
11606 * bsd-uthread.c (bsd_uthread_thread_alive): Use ptid instead of
11608 * go32-nat.c (go32_thread_alive): Likewise.
11612 * varobj-iter.h (varobj_iter_delete): Call xfree instead of
11617 * varobj.c (varobj_clear_saved_item): Use delete instead of
11619 (update_dynamic_varobj_children): Likewise.
11623 * dwarf2read.c (dwarf2_record_block_ranges): Add forgotten BASEADDR.
11627 * common/enum-flags.h (enum_flags::enum_flags): Initialize
11628 m_enum_value to 0 in default constructor.
11632 * rs6000-tdep.c (LOAD_AND_RESERVE_MASK): Rename from LWARX_MASK.
11633 (STORE_CONDITIONAL_MASK): Rename from STWCX_MASK.
11634 (LBARX_INSTRUCTION, LHARX_INSTRUCTION, LQARX_INSTRUCTION,
11635 STBCX_INSTRUCTION, STHCX_INSTRUCTION, STQCX_INSTRUCTION): New defines.
11636 (IS_LOAD_AND_RESERVE_INSN, IS_STORE_CONDITIONAL_INSN): New macros.
11637 (ppc_displaced_step_copy_insn): Use IS_LOAD_AND_RESERVE_INSN.
11638 (ppc_deal_with_atomic_sequence): Use IS_LOAD_AND_RESERVE_INSN and
11639 IS_STORE_CONDITIONAL_INSN.
11643 * dwarf2_rnglists_process: Initialize range_beginning and range_end.
11647 * NEWS (Changes since GDB 7.12): Add DWARF-5.
11651 * dwarf2read.c (skip_one_die, read_attribute_value)
11652 (dwarf2_const_value_attr, dump_die_shallow)
11653 (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
11654 (skip_form_bytes, attr_form_is_constant): Handle DW_FORM_data16.
11658 * dwarf2read.c (read_file_scope): Rename DW_MACRO_GNU_*.
11659 (dwarf_parse_macro_header): Accept DWARF version 5.
11660 (dwarf_decode_macro_bytes, dwarf_decode_macros): Rename DW_MACRO_GNU_*.
11664 * block.c (call_site_for_pc): Rename DW_OP_GNU_*, DW_TAG_GNU_* and
11666 * common/common-exceptions.h (enum errors): Likewise.
11667 * dwarf2-frame.c (class dwarf_expr_executor): Likewise.
11668 * dwarf2expr.c (dwarf_block_to_dwarf_reg)
11669 (dwarf_expr_context::execute_stack_op): Likewise.
11670 * dwarf2expr.h (struct dwarf_expr_context, struct dwarf_expr_piece):
11672 * dwarf2loc.c (dwarf_evaluate_loc_desc::get_base_type)
11673 (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
11674 (show_entry_values_debug, call_site_to_target_addr)
11675 (func_addr_to_tail_call_list, func_verify_no_selftailcall)
11676 (dwarf_expr_reg_to_entry_parameter, dwarf_entry_parameter_to_value)
11677 (entry_data_value_free_closure, value_of_dwarf_reg_entry)
11678 (value_of_dwarf_block_entry, indirect_pieced_value)
11679 (symbol_needs_eval_context::push_dwarf_reg_entry_value):
11680 (disassemble_dwarf_expression): Likewise.
11681 * dwarf2read.c (process_die, inherit_abstract_dies)
11682 (read_call_site_scope): Likewise.
11683 * gdbtypes.h (struct func_type, struct call_site_parameter)
11684 (struct call_site): Likewise.
11685 * stack.c (read_frame_arg): Likewise.
11686 * std-operator.def (OP_VAR_ENTRY_VALUE): Likewise.
11690 * defs.h (read_unsigned_leb128): New declaration.
11691 * dwarf2loc.c (decode_debug_loclists_addresses): New function.
11692 (decode_debug_loc_dwo_addresses): Update DEBUG_LOC_* to DW_LLE_*.
11693 (dwarf2_find_location_expression): Call also
11694 decode_debug_loclists_addresses. Handle DWARF-5 ULEB128 length.
11695 * dwarf2loc.h (dwarf2_version): New declaration.
11696 * dwarf2read.c (struct dwarf2_per_objfile): Add loclists, line_str,
11698 (dwarf2_elf_names): Add .debug_loclists, .debug_line_str,
11700 (struct dwop_section_names): Add loclists_dwo.
11701 (dwop_section_names): Add .debug_loclists.dwo.
11702 (struct comp_unit_head): Add unit_type, signature, type_offset_in_tu.
11703 (struct dwarf2_per_cu_data): Add dwarf_version.
11704 (struct dwo_sections): Add loclists.
11705 (struct attr_abbrev): Add implicit_const.
11706 (read_indirect_line_string): New declaration.
11707 (read_unsigned_leb128): Delete declaration.
11708 (rcuh_kind): New definition.
11709 (read_and_check_comp_unit_head): Change parameter
11710 is_debug_types_section to section_kind.
11711 (dwarf2_locate_sections): Handle loclists, line_str and rnglists.
11712 (read_comp_unit_head): Change parameter abfd to section, add parameter
11713 section_kind. Handle DWARF-5.
11714 (error_check_comp_unit_head): Accept also DWARF version 5.
11715 (read_and_check_comp_unit_head): Change parameter
11716 is_debug_types_section to section_kind.
11717 (read_and_check_type_unit_head): Delete function.
11718 (read_abbrev_offset): Handle DWARF-5.
11719 (create_debug_type_hash_table): Add parameter section_kind. Process
11720 only DW_UT_type. Use signature and type_offset_in_tu from struct
11722 (create_debug_types_hash_table): Update create_debug_type_hash_table
11724 (create_all_type_units): Call create_debug_type_hash_table.
11725 (read_cutu_die_from_dwo, init_cutu_and_read_dies): Change
11726 read_and_check_type_unit_head caller to read_and_check_comp_unit_head
11728 (skip_one_die): Handle DW_FORM_implicit_const.
11729 (dwarf2_rnglists_process): New function.
11730 (dwarf2_ranges_process): Call dwarf2_rnglists_process for DWARF-5.
11731 (abbrev_table_read_table): Handle DW_FORM_implicit_const.
11732 (read_attribute_value): Handle DW_FORM_implicit_const,
11734 (read_attribute): Handle DW_FORM_implicit_const.
11735 (read_indirect_string_at_offset_from): New function from
11736 read_indirect_string_at_offset.
11737 (read_indirect_string_at_offset): Call
11738 read_indirect_string_at_offset_from.
11739 (read_indirect_line_string_at_offset): New function.
11740 (read_indirect_string): New function comment.
11741 (read_indirect_line_string): New function.
11742 (read_unsigned_leb128): Make it global.
11743 (dwarf2_string_attr): Handle DWARF-5.
11744 (add_include_dir_stub, read_formatted_entries): New functions.
11745 (dwarf_decode_line_header, dump_die_shallow, cu_debug_loc_section):
11747 (per_cu_header_read_in): Update read_comp_unit_head caller.
11748 (dwarf2_version): New function.
11749 * symfile.h (struct dwarf2_debug_sections): Add loclists, line_str and
11751 * xcoffread.c (dwarf2_xcoff_names): Update struct dwarf2_debug_sections
11756 * dwarf2read.c (abbrev_table_read_table): Read the data only once.
11760 * dwarf2read.c (dwarf2_ranges_process): New function from
11761 dwarf2_ranges_read.
11762 (dwarf2_ranges_read, dwarf2_record_block_ranges): Use
11763 dwarf2_ranges_process.
11767 * dwarf2read.c (create_debug_type_hash_table): New function from
11768 create_debug_types_hash_table.
11769 (create_debug_types_hash_table): Call create_debug_type_hash_table.
11770 (create_all_type_units, open_and_init_dwo_file): Update
11771 create_debug_types_hash_table callers.
11776 * fork-child.c (trace_start_error): Fix thinko. va_end should
11777 refer to 'ap', not 'args'.
11783 * darwin-nat.c (darwin_ptrace_me): Check if calls to system
11785 * fork-child.c (trace_start_error): New function.
11786 (trace_start_error_with_name): Likewise.
11787 * gnu-nat.c (gnu_ptrace_me): Check if call to PTRACE succeeded.
11788 * inf-ptrace.c (inf_ptrace_me): Likewise.
11789 * inferior.h (trace_start_error): New prototype.
11790 (trace_start_error_with_name): Likewise.
11795 * psymtab.c (maintenance_print_psymbols): Verify if 'argv' is not
11796 NULL before using it.
11797 * symmisc.c (maintenance_print_symbols): Likewise.
11798 (maintenance_print_msymbols): Likewise.
11802 * NEWS: Add record Python bindings entry.
11806 * Makefile.in (SUBDIR_PYTHON_OBS): Add py-record-btrace.o,
11808 (SUBDIR_PYTHON_SRCS): Add py-record-btrace.c, py-record-full.c.
11809 * python/py-record-btrace.c, python/py-record-btrace.h,
11810 python/py-record-full.c, python/py-record-full.h: New file.
11811 * python/py-record.c: Add include for py-record-btrace.h and
11813 (recpy_method, recpy_format, recpy_goto, recpy_replay_position,
11814 recpy_instruction_history, recpy_function_call_history, recpy_begin,
11815 recpy_end): Use functions from py-record-btrace.c and py-record-full.c.
11816 * python/python-internal.h (PyInt_FromSsize_t, PyInt_AsSsize_t):
11818 (gdbpy_initialize_btrace): New export.
11819 * python/python.c (_initialize_python): Add gdbpy_initialize_btrace.
11823 * Makefile.in (SUBDIR_PYTHON_OBS): Add python/py-record.o.
11824 (SUBDIR_PYTHON_SRCS): Add python/py-record.c.
11825 * python/py-record.c: New file.
11826 * python/python-internal.h (gdbpy_start_recording,
11827 gdbpy_current_recording, gdpy_stop_recording,
11828 gdbpy_initialize_record): New export.
11829 * python/python.c (_initialize_python): Add gdbpy_initialize_record.
11830 (python_GdbMethods): Add gdbpy_start_recording,
11831 gdbpy_current_recording and gdbpy_stop_recording.
11835 * record-btrace.c (record_btrace_record_method): New function.
11836 (init_record_btrace_ops): Initialize to_record_method.
11837 * record-full.c (record_full_record_method): New function.
11838 (init_record_full_ops, init_record_full_core_ops): Add
11839 record_full_record_method.
11840 * record.h (enum record_method): New enum.
11841 * target-debug.h (target_debug_print_enum_record_method: New define.
11842 * target-delegates.c: Regenerate.
11843 * target.c (target_record_method): New function.
11844 * target.h: Include record.h.
11845 (struct target_ops) <to_record_method>: New field.
11846 (target_record_method): New export.
11850 * record.h (record_start, record_stop): New export.
11851 * record.c (record_start, record_stop): New function.
11855 * btrace.c (btrace_fetch): Copy function call segments pointer
11857 (btrace_clear): Clear the vector.
11858 (btrace_find_insn_by_number): Use binary search to find the correct
11859 function call segment.
11860 * btrace.h (brace_fun_p): New typedef.
11861 (struct btrace_thread_info) <functions>: New field.
11865 * record-btrace.c (btrace_ui_out_decode_error): Move most of it ...
11866 * btrace.c (btrace_decode_error): ... here. New function.
11867 * btrace.h (btrace_decode_error): New export.
11871 * btrace.c (ftrace_call_num_insn, btrace_insn_get_error): New function.
11872 (ftrace_new_function, btrace_insn_number, btrace_insn_cmp,
11873 btrace_find_insn_by_number): Remove special case for gaps.
11874 * btrace.h (btrace_insn_get_error): New export.
11875 (btrace_insn_number, btrace_find_insn_by_number): Adjust comment.
11876 * record-btrace.c (btrace_insn_history): Print number for gaps.
11877 (record_btrace_info, record_btrace_goto): Handle gaps.
11882 * python/python.c (gdbpy_before_prompt_hook): Emit before_prompt
11884 * python/py-evts.c (gdbpy_initialize_py_events): Add
11885 before_prompt registry.
11886 * python/py-events.h (events_object) <before_prompt>: New field.
11890 * btrace.c (ftrace_new_switch): Preserve up link and flags.
11894 * symfile (_initialize_symfile): Add usage text to the load command's
11899 * utils.c (defaulted_query): Don't query on secondary UIs.
11903 * rust-lang.c (rust_get_disr_info): Remove unused variable.
11907 * python/py-value.c (valpy_richcompare_throw): Remove unnecessary
11909 * python/py-type.c (typy_legacy_template_argument): Remove
11910 unnecessary "cleanup" local.
11914 * python/python.c (do_start_initialization): New function, from
11915 _initialize_python.
11916 (_initialize_python): Call do_start_initialization.
11917 * python/py-linetable.c (ltpy_iternext): Use explicit returns, not
11922 * python/py-prettyprint.c (pretty_print_one_value): Use
11927 * python/py-cmd.c (cmdpy_destroyer): Use gdbpy_ref.
11928 * python/py-breakpoint.c (gdbpy_breakpoint_deleted): Use
11930 * python/py-type.c (field_new): Use gdbpy_ref.
11931 * python/py-symtab.c (symtab_and_line_to_sal_object): Use
11933 * python/py-progspace.c (pspy_new): Use gdbpy_ref.
11934 (py_free_pspace): Likewise.
11935 (pspace_to_pspace_object): Likewise.
11936 * python/py-objfile.c (objfpy_new): Use gdbpy_ref.
11937 (py_free_objfile): Likewise.
11938 (objfile_to_objfile_object): Likewise.
11939 * python/py-inferior.c (delete_thread_object): Use
11941 (infpy_read_memory): Likewise.
11942 (py_free_inferior): Likewise.
11943 * python/py-evtregistry.c (create_eventregistry_object): Use
11945 * python/py-event.c (create_event_object): Use gdbpy_ref.
11949 * python/py-ref.h (gdbpy_ref_policy): Now a template.
11950 (gdbpy_ref): Now a template; allow subclasses of PyObject to be
11952 * python/py-arch.c, python/py-bpevent.c, python/py-breakpoint.c,
11953 python/py-cmd.c, python/py-continueevent.c, python/py-event.c,
11954 python/py-exitedevent.c, python/py-finishbreakpoint.c,
11955 python/py-framefilter.c, python/py-function.c,
11956 python/py-inferior.c, python/py-infevents.c,
11957 python/py-linetable.c, python/py-newobjfileevent.c,
11958 python/py-param.c, python/py-prettyprint.c, python/py-ref.h,
11959 python/py-signalevent.c, python/py-stopevent.c,
11960 python/py-symbol.c, python/py-threadevent.c, python/py-type.c,
11961 python/py-unwind.c, python/py-utils.c, python/py-value.c,
11962 python/py-varobj.c, python/py-xmethods.c, python/python.c,
11963 varobj.c: Change gdbpy_ref to gdbpy_ref<>.
11967 * ui-out.h (ui_out_emit_type): New class.
11968 (ui_out_emit_tuple, ui_out_emit_list): New typedefs.
11969 * python/py-framefilter.c (py_print_single_arg): Use gdb::optional
11970 and ui_out_emit_tuple.
11971 (enumerate_locals): Likewise.
11972 (py_mi_print_variables, py_print_locals, py_print_args): Use
11974 (py_print_frame): Use gdb::optional, ui_out_emit_tuple,
11976 * common/gdb_optional.h: New file.
11980 * MAINTAINERS (Write After Approval): Update my e-mail address.
11985 * breakpoint.c (_initialize_breakpoint): Update the help description
11986 of the 'commands' command to indicate that it takes a list argument.
11990 * interps.c (current_interp_set_logging): Remove "return".
11994 * symtab.c (add_symtab_completions): Prevent NULL pointer
11999 * interps.c (interp::interp): Remove reference to quiet_p.
12000 (interp_set): Make static. Remove dead "Switching to" output
12002 (interp_quiet_p, interp_set_quiet): Delete.
12003 (interpreter_exec_cmd): Don't set the interpreter quiet.
12004 * interps.h (interp_quiet_p): Make static.
12005 (class interp) <quiet_p>: Remove field
12009 * cli/cli-decode.c (find_command_name_length): Make it extern.
12010 * cli/cli-decode.h (find_command_name_length): Declare.
12011 * cli/cli-script.c (command_name_equals, line_first_arg):
12013 (process_next_line): Use cli-decode to parse command names.
12014 (build_command_line): Make args a constant pointer.
12018 * cli-decode.c (lookup_cmd_1, lookup_cmd_composition):
12019 Remove case-insensitive search.
12023 * sparc-tdep.c (sparc32_gdbarch_init): Do not place a + operator
12024 at the end of the line. Avoids an ARI warning.
12028 * NEWS: Mention support for record/replay of Intel 64 rdrand and
12029 rdseed instructions.
12030 i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed.
12035 Provide and use sparc32 and sparc64 target description XML files.
12036 * features/sparc/sparc32-cp0.xml, features/sparc/sparc32-cpu.xml,
12037 features/sparc/sparc32-fpu.xml: New files for sparc 32-bit.
12038 * features/sparc/sparc64-cp0.xml, features/sparc/sparc64-cpu.xml,
12039 features/sparc/sparc64-fpu.xml: New files for sparc 64-bit.
12040 * features/sparc/sparc32-solaris.xml: New file.
12041 * features/sparc/sparc64-solaris.xml: New file.
12042 * features/sparc/sparc32-solaris.c: Generated.
12043 * features/sparc/sparc64-solaris.c: Generated.
12044 * sparc-tdep.h: Account for differences in target descriptions.
12045 * sparc-tdep.c (sparc32_register_name): Use target provided registers.
12046 (sparc32_register_type): Use target provided registers.
12047 (validate_tdesc_registers): New function.
12048 (sparc32_gdbarch_init): Use tdesc_has_registers.
12049 Set pseudoregister functions.
12050 * sparc64-tdep.c (sparc64_register_name): Use target provided registers.
12051 (sparc64_register_type): Use target provided registers.
12052 (sparc64_init_abi): Set pseudoregister functions.
12057 * rust-lang.c (rust_print_type) <TYPE_CODE_UNION>: Handle enums
12058 with a single member.
12062 * cli/cli-interp.c (cli_interp_base::cli_interp_base)
12063 (cli_interp_base::~cli_interp_base): New.
12064 (cli_interp): New struct.
12065 (as_cli_interp): Cast the interp itself to cli_interp.
12066 (cli_interpreter_pre_command_loop): Rename to ...
12067 (cli_interp_base::pre_command_loop): ... this. Remove 'self'
12069 (cli_interpreter_init): Rename to ...
12070 (cli_interp::init): ... this. Remove 'self' parameter. Use
12071 boolean. Make extern.
12072 (cli_interpreter_resume): Rename to ...
12073 (cli_interp::resume): ... this. Remove 'data' parameter. Make
12075 (cli_interpreter_suspend): Rename to ...
12076 (cli_interp::suspend): ... this. Remove 'data' parameter. Make
12078 (cli_interpreter_exec): Rename to ...
12079 (cli_interp::exec): ... this. Remove 'data' parameter. Make
12081 (cli_interpreter_supports_command_editing): Rename to ...
12082 (cli_interp_base::supports_command_editing): ... this. Remove
12083 'interp' parameter. Make extern.
12084 (cli_ui_out): Rename to ...
12085 (cli_interp::interp_ui_out): ... this. Remove 'interp' parameter.
12087 (cli_set_logging): Rename to ...
12088 (cli_interp_base::set_logging): ... this. Remove 'interp'
12089 parameter. Make extern.
12090 (cli_interp_procs): Delete.
12091 (cli_interp_factory): Adjust to use "new".
12092 * cli/cli-interp.h: Include "interps.h".
12093 (struct cli_interp_base): New struct.
12094 * interps.c (struct interp): Delete. Fields moved to interps.h.
12095 (interp_new): Delete.
12096 (interp::interp, interp::~interp): New.
12097 (interp_set): Use bool, and return void. Assume the interpreter
12098 has suspend, init and resume methods, and that the all return
12100 (set_top_level_interpreter): interp_set returns void.
12101 (interp_ui_out): Adapt.
12102 (current_interp_set_logging): Adapt.
12103 (interp_data): Delete.
12104 (interp_pre_command_loop, interp_supports_command_editing): Adapt.
12105 (interp_exec): Adapt.
12106 (top_level_interpreter_data): Delete.
12107 * interps.h (interp_init_ftype, interp_resume_ftype)
12108 (interp_suspend_ftype, interp_exec_ftype)
12109 (interp_pre_command_loop_ftype, interp_ui_out_ftype): Delete.
12110 (class interp): New.
12111 (interp_new): Delete.
12112 (interp_set): Now returns void. Use bool.
12113 (interp_data, top_level_interpreter_data): Delete.
12114 * mi/mi-common.h: Include interps.h.
12115 (class mi_interp): Inherit from interp. Define a ctor. Declare
12116 init, resume, suspect, exec, interp_ui_out, set_logging and
12117 pre_command_loop methods.
12118 * mi/mi-interp.c (as_mi_interp): Cast the interp itself.
12119 (mi_interpreter_init): Rename to ...
12120 (mi_interp::init): ... this. Remove the 'interp' parameter, use
12121 bool, return void and make extern. Adjust.
12122 (mi_interpreter_resume): ... Rename to ...
12123 (mi_interp::resume): ... this. Remove the 'data' parameter,
12124 return void and make extern. Adjust.
12125 (mi_interpreter_suspend): ... Rename to ...
12126 (mi_interp::suspend): ... this. Remove the 'data' parameter,
12127 return void and make extern. Adjust.
12128 (mi_interpreter_exec): ... Rename to ...
12129 (mi_interp::exec): ... this. Remove the 'data' parameter and make
12131 (mi_interpreter_pre_command_loop): ... Rename to ...
12132 (mi_interp::pre_command_loop): ... this. Remove the 'self'
12133 parameter and make extern.
12134 (mi_on_normal_stop_1): Adjust.
12135 (mi_ui_out): Rename to ...
12136 (mi_interp::interp_ui_out): ... this. Remove the 'interp'
12137 parameter and make extern. Adjust.
12138 (mi_set_logging): Rename to ...
12139 (mi_interp::set_logging): ... this. Remove the 'interp'
12140 parameter and make extern. Adjust.
12141 (mi_interp_procs): Delete.
12142 (mi_interp_factory): Adjust to use 'new'.
12143 * mi/mi-main.c (mi_cmd_gdb_exit, captured_mi_execute_command)
12144 (mi_print_exception, mi_execute_command, mi_load_progress):
12146 * tui/tui-interp.c (tui_interp): New class.
12147 (as_tui_interp): Return a tui_interp pointer.
12148 (tui_on_normal_stop, tui_on_signal_received)
12149 (tui_on_end_stepping_range, tui_on_signal_exited, tui_on_exited)
12150 (tui_on_no_history, tui_on_user_selected_context_changed): Adjust
12151 to use interp::interp_ui_out.
12152 (tui_init): Rename to ...
12153 (tui_interp::init): ... this. Remove the 'self' parameter, use
12154 bool, return void and make extern. Adjust.
12155 (tui_resume): Rename to ...
12156 (tui_interp::resume): ... this. Remove the 'data' parameter,
12157 return void and make extern. Adjust.
12158 (tui_suspend): Rename to ...
12159 (tui_interp::suspend): ... this. Remove the 'data' parameter,
12160 return void and make extern. Adjust.
12161 (tui_ui_out): Rename to ...
12162 (tui_interp::interp_ui_out): ... this. Remove the 'self'
12163 parameter, and make extern. Adjust.
12164 (tui_exec): Rename to ...
12165 (tui_interp::exec): ... this. Remove the 'data' parameter and
12167 (tui_interp_procs): Delete.
12168 (tui_interp_factory): Use "new".
12172 * rust-exp.y (ends_raw_string, space_then_number)
12173 (rust_identifier_start_p): Return bool.
12174 * rust-lang.c (rust_tuple_type_p, rust_underscore_fields)
12175 (rust_tuple_struct_type_p, rust_tuple_variant_type_p)
12176 (rust_slice_type_p, rust_range_type_p, rust_u8_type_p)
12177 (rust_chartype_p): Return bool.
12178 (val_print_struct, rust_print_struct_def, rust_print_type):
12180 * rust-lang.h (rust_tuple_type_p, rust_tuple_struct_type_p):
12185 * rust-lang.c: Reindent.
12189 * rust-lang.h (rust_crate_for_block): Update.
12190 * rust-lang.c (rust_crate_for_block): Return std::string.
12191 (rust_get_disr_info): Use std:;string, not
12192 gdb::unique_xmalloc_ptr.
12193 * rust-exp.y (crate_name): Update.
12197 * disasm-selftests.c (print_one_insn_test): Move the "verbose"
12198 field out of gdb_disassembler_test and make it static.
12202 * mi/mi-common.h (struct mi_interp): Delete the mi2_interp,
12203 mi1_interp and mi_interp fields.
12207 * cli/cli-interp.c (struct saved_output_files, saved_output):
12208 Moved from cli/cli-logging.c.
12209 (cli_set_logging): New function.
12210 (cli_interp_procs): Install cli_set_logging.
12211 * cli/cli-interp.h (make_logging_output, cli_set_logging):
12213 * cli/cli-logging.c (struct saved_output_files, saved_output):
12214 Moved to cli/cli-interp.c.
12215 (pop_output_files): Don't save outputs here.
12216 (make_logging_output): New function.
12217 (handle_redirections): Don't build tee nor save previous outputs
12219 * interps.c (current_interp_set_logging): Change prototype.
12220 Assume there's always a set_logging_proc method installed.
12221 * interps.h (interp_set_logging_ftype): Change prototype.
12222 (current_interp_set_logging): Change prototype and adjust comment.
12223 * mi/mi-interp.c (mi_set_logging): Change protototype. Adjust to
12224 use make_logging_output.
12225 * tui/tui-interp.c (tui_interp_procs): Install cli_set_logging.
12228 * cli/cli-logging.c (maybe_warn_already_logging): New factored out
12230 (set_logging_overwrite): ... here.
12231 (logging_no_redirect_file): Delete.
12232 (set_logging_redirect): Don't handle redirection on the fly.
12233 Instead warn that "logging off" / "logging on" is necessary.
12234 (pop_output_files): Delete references to logging_no_redirect_file.
12235 (show_logging_command): Always speak in terms of what will happen
12236 once logging is reenabled.
12240 * disasm.h (gdb_pretty_print_disassembler): Tweak intro comment.
12244 * disasm.c (gdb_pretty_print_insn): Rename to ...
12245 (gdb_pretty_print_disassembler::pretty_print_insn): ... this.
12246 Remove gdbarch parameter. Adapt to clear the object's buffers
12247 instead of allocating new buffers, and to print using the object's
12248 gdb_disassembler instead of calling gdb_print_insn.
12249 (dump_insns): Use gdb_pretty_print_disassembler.
12250 * disasm.h (gdb_pretty_print_insn): Delete declaration.
12251 (gdb_pretty_print_disassembler): New class.
12252 * record-btrace.c (btrace_insn_history): Use
12253 gdb_pretty_print_disassembler.
12257 * ada-lang.c (type_as_string): Use string_file.
12258 * ada-valprint.c (ada_print_floating): Use string_file.
12259 * ada-varobj.c (ada_varobj_scalar_image)
12260 (ada_varobj_get_value_image): Use string_file.
12261 * aix-thread.c (aix_thread_extra_thread_info): Use string_file.
12262 * arm-tdep.c (_initialize_arm_tdep): Use string_printf.
12263 * breakpoint.c (update_inserted_breakpoint_locations)
12264 (insert_breakpoint_locations, reattach_breakpoints)
12265 (print_breakpoint_location, print_one_detail_ranged_breakpoint)
12266 (print_it_watchpoint): Use string_file.
12267 (save_breakpoints): Use stdio_file.
12268 * c-exp.y (oper): Use string_file.
12269 * cli/cli-logging.c (set_logging_redirect): Use ui_file_up and
12271 (pop_output_files): Use delete.
12272 (handle_redirections): Use stdio_file and tee_file.
12273 * cli/cli-setshow.c (do_show_command): Use string_file.
12274 * compile/compile-c-support.c (c_compute_program): Use
12276 * compile/compile-c-symbols.c (generate_vla_size): Take a
12277 'string_file &' instead of a 'ui_file *'.
12278 (generate_c_for_for_one_variable): Take a 'string_file &' instead
12279 of a 'ui_file *'. Use string_file.
12280 (generate_c_for_variable_locations): Take a 'string_file &'
12281 instead of a 'ui_file *'.
12282 * compile/compile-internal.h (generate_c_for_for_one_variable):
12283 Take a 'string_file &' instead of a 'ui_file *'.
12284 * compile/compile-loc2c.c (push, pushf, unary, binary)
12285 (print_label, pushf_register_address, pushf_register)
12286 (do_compile_dwarf_expr_to_c): Take a 'string_file &' instead of a
12287 'ui_file *'. Adjust.
12288 * compile/compile.c (compile_to_object): Use string_file.
12289 * compile/compile.h (compile_dwarf_expr_to_c)
12290 (compile_dwarf_bounds_to_c): Take a 'string_file &' instead of a
12292 * cp-support.c (inspect_type): Use string_file and obstack_copy0.
12293 (replace_typedefs_qualified_name): Use string_file and
12295 * disasm.c (gdb_pretty_print_insn): Use string_file.
12296 (gdb_disassembly): Adjust reference the null_stream global.
12297 (do_ui_file_delete): Delete.
12298 (gdb_insn_length): Use null_stream.
12299 * dummy-frame.c (maintenance_print_dummy_frames): Use stdio_file.
12300 * dwarf2loc.c (dwarf2_compile_property_to_c)
12301 (locexpr_generate_c_location, loclist_generate_c_location): Take a
12302 'string_file &' instead of a 'ui_file *'.
12303 * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise.
12304 * dwarf2read.c (do_ui_file_peek_last): Delete.
12305 (dwarf2_compute_name): Use string_file.
12306 * event-top.c (gdb_setup_readline): Use stdio_file.
12307 * gdbarch.sh (verify_gdbarch): Use string_file.
12308 * gdbtypes.c (safe_parse_type): Use null_stream.
12309 * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Use
12311 * guile/scm-disasm.c (gdbscm_print_insn_from_port): Take a
12312 'string_file *' instead of a 'ui_file *'.
12313 (gdbscm_arch_disassemble): Use string_file.
12314 * guile/scm-frame.c (frscm_print_frame_smob): Use string_file.
12315 * guile/scm-ports.c (class ioscm_file_port): Now a class that
12316 inherits from ui_file.
12317 (ioscm_file_port_delete, ioscm_file_port_rewind)
12318 (ioscm_file_port_put): Delete.
12319 (ioscm_file_port_write): Rename to ...
12320 (ioscm_file_port::write): ... this. Remove file_port_magic
12322 (ioscm_file_port_new): Delete.
12323 (ioscm_with_output_to_port_worker): Use ioscm_file_port and
12325 * guile/scm-type.c (tyscm_type_name): Use string_file.
12326 * guile/scm-value.c (vlscm_print_value_smob, gdbscm_value_print):
12328 * infcmd.c (print_return_value_1): Use string_file.
12329 * infrun.c (print_target_wait_results): Use string_file.
12330 * language.c (add_language): Use string_file.
12331 * location.c (explicit_to_string_internal): Use string_file.
12332 * main.c (captured_main_1): Use null_file.
12333 * maint.c (maintenance_print_architecture): Use stdio_file.
12334 * mi/mi-cmd-stack.c (list_arg_or_local): Use string_file.
12335 * mi/mi-common.h (struct mi_interp) <out, err, log, targ,
12336 event_channel>: Change type to mi_console_file pointer.
12337 * mi/mi-console.c (mi_console_file_fputs, mi_console_file_flush)
12338 (mi_console_file_delete): Delete.
12339 (struct mi_console_file): Delete.
12340 (mi_console_file_magic): Delete.
12341 (mi_console_file_new): Delete.
12342 (mi_console_file::mi_console_file): New.
12343 (mi_console_file_delete): Delete.
12344 (mi_console_file_fputs): Delete.
12345 (mi_console_file::write): New.
12346 (mi_console_raw_packet): Delete.
12347 (mi_console_file::flush): New.
12348 (mi_console_file_flush): Delete.
12349 (mi_console_set_raw): Rename to ...
12350 (mi_console_file::set_raw): ... this.
12351 * mi/mi-console.h (class mi_console_file): New class.
12352 (mi_console_file_new, mi_console_set_raw): Delete.
12353 * mi/mi-interp.c (mi_interpreter_init): Use mi_console_file.
12354 (mi_set_logging): Use delete and tee_file. Adjust.
12355 * mi/mi-main.c (output_register): Use string_file.
12356 (mi_cmd_data_evaluate_expression): Use string_file.
12357 (mi_cmd_data_read_memory): Use string_file.
12358 (mi_cmd_execute, print_variable_or_computed): Use string_file.
12359 * mi/mi-out.c (mi_ui_out::main_stream): New.
12360 (mi_ui_out::rewind): Use main_stream and
12362 (mi_ui_out::put): Use main_stream and string_file.
12363 (mi_ui_out::mi_ui_out): Remove 'stream' parameter.
12364 Allocate a 'string_file' instead.
12365 (mi_out_new): Don't allocate a mem_fileopen stream here.
12366 * mi/mi-out.h (mi_ui_out::mi_ui_out): Remove 'stream' parameter.
12367 (mi_ui_out::main_stream): Declare method.
12368 * printcmd.c (eval_command): Use string_file.
12369 * psymtab.c (maintenance_print_psymbols): Use stdio_file.
12370 * python/py-arch.c (archpy_disassemble): Use string_file.
12371 * python/py-breakpoint.c (bppy_get_commands): Use string_file.
12372 * python/py-frame.c (frapy_str): Use string_file.
12373 * python/py-framefilter.c (py_print_type, py_print_single_arg):
12375 * python/py-type.c (typy_str): Use string_file.
12376 * python/py-unwind.c (unwind_infopy_str): Use string_file.
12377 * python/py-value.c (valpy_str): Use string_file.
12378 * record-btrace.c (btrace_insn_history): Use string_file.
12379 * regcache.c (regcache_print): Use stdio_file.
12380 * reggroups.c (maintenance_print_reggroups): Use stdio_file.
12381 * remote.c (escape_buffer): Use string_file.
12382 * rust-lang.c (rust_get_disr_info): Use string_file.
12383 * serial.c (serial_open_ops_1): Use stdio_file.
12384 (do_serial_close): Use delete.
12385 * stack.c (print_frame_arg): Use string_file.
12386 (print_frame_args): Remove local mem_fileopen stream, not used.
12387 (print_frame): Use string_file.
12388 * symmisc.c (maintenance_print_symbols): Use stdio_file.
12389 * symtab.h (struct symbol_computed_ops) <generate_c_location>:
12390 Take a 'string_file *' instead of a 'ui_file *'.
12391 * top.c (new_ui): Use stdio_file and stderr_file.
12392 (free_ui): Use delete.
12393 (execute_command_to_string): Use string_file.
12394 (quit_confirm): Use string_file.
12395 * tracepoint.c (collection_list::append_exp): Use string_file.
12396 * tui/tui-disasm.c (tui_disassemble): Use string_file.
12397 * tui/tui-file.c: Don't include "ui-file.h".
12398 (enum streamtype, struct tui_stream): Delete.
12399 (tui_file_new, tui_file_delete, tui_fileopen, tui_sfileopen)
12400 (tui_file_isatty, tui_file_rewind, tui_file_put): Delete.
12401 (tui_file::tui_file): New method.
12402 (tui_file_fputs): Delete.
12403 (tui_file_get_strbuf): Delete.
12404 (tui_file::puts): New method.
12405 (tui_file_adjust_strbuf): Delete.
12406 (tui_file_flush): Delete.
12407 (tui_file::flush): New method.
12408 * tui/tui-file.h: Tweak intro comment.
12410 (tui_fileopen, tui_sfileopen, tui_file_get_strbuf)
12411 (tui_file_adjust_strbuf): Delete declarations.
12412 (class tui_file): New class.
12413 * tui/tui-io.c (tui_initialize_io): Use tui_file.
12414 * tui/tui-regs.c (tui_restore_gdbout): Use delete.
12415 (tui_register_format): Use string_stream.
12416 * tui/tui-stack.c (tui_make_status_line): Use string_file.
12417 (tui_get_function_from_frame): Use string_file.
12418 * typeprint.c (type_to_string): Use string_file.
12419 * ui-file.c (struct ui_file, ui_file_magic, ui_file_new): Delete.
12420 (null_stream): New global.
12421 (ui_file_delete): Delete.
12422 (ui_file::ui_file): New.
12423 (null_file_isatty): Delete.
12424 (ui_file::~ui_file): New.
12425 (null_file_rewind): Delete.
12426 (ui_file::printf): New.
12427 (null_file_put): Delete.
12428 (null_file_flush): Delete.
12429 (ui_file::putstr): New.
12430 (null_file_write): Delete.
12431 (ui_file::putstrn): New.
12432 (null_file_read): Delete.
12433 (ui_file::putc): New.
12434 (null_file_fputs): Delete.
12435 (null_file_write_async_safe): Delete.
12436 (ui_file::vprintf): New.
12437 (null_file_delete): Delete.
12438 (null_file::write): New.
12439 (null_file_fseek): Delete.
12440 (null_file::puts): New.
12441 (ui_file_data): Delete.
12442 (null_file::write_async_safe): New.
12443 (gdb_flush, ui_file_isatty): Adjust.
12444 (ui_file_put, ui_file_rewind): Delete.
12445 (ui_file_write): Adjust.
12446 (ui_file_write_for_put): Delete.
12447 (ui_file_write_async_safe, ui_file_read): Adjust.
12448 (ui_file_fseek): Delete.
12449 (fputs_unfiltered): Adjust.
12450 (set_ui_file_flush, set_ui_file_isatty, set_ui_file_rewind)
12451 (set_ui_file_put, set_ui_file_write, set_ui_file_write_async_safe)
12452 (set_ui_file_read, set_ui_file_fputs, set_ui_file_fseek)
12453 (set_ui_file_data): Delete.
12454 (string_file::~string_file, string_file::write)
12455 (struct accumulated_ui_file, do_ui_file_xstrdup, ui_file_xstrdup)
12456 (do_ui_file_as_string, ui_file_as_string): Delete.
12457 (do_ui_file_obsavestring, ui_file_obsavestring): Delete.
12458 (struct mem_file): Delete.
12459 (mem_file_new): Delete.
12460 (stdio_file::stdio_file): New.
12461 (mem_file_delete): Delete.
12462 (stdio_file::stdio_file): New.
12463 (mem_fileopen): Delete.
12464 (stdio_file::~stdio_file): New.
12465 (mem_file_rewind): Delete.
12466 (stdio_file::set_stream): New.
12467 (mem_file_put): Delete.
12468 (stdio_file::open): New.
12469 (mem_file_write): Delete.
12470 (stdio_file_magic, struct stdio_file): Delete.
12471 (stdio_file_new, stdio_file_delete, stdio_file_flush): Delete.
12472 (stdio_file::flush): New.
12473 (stdio_file_read): Rename to ...
12474 (stdio_file::read): ... this. Adjust.
12475 (stdio_file_write): Rename to ...
12476 (stdio_file::write): ... this. Adjust.
12477 (stdio_file_write_async_safe): Rename to ...
12478 (stdio_file::write_async_safe) ... this. Adjust.
12479 (stdio_file_fputs): Rename to ...
12480 (stdio_file::puts) ... this. Adjust.
12481 (stdio_file_isatty): Delete.
12482 (stdio_file_fseek): Delete.
12483 (stdio_file::isatty): New.
12484 (stderr_file_write): Rename to ...
12485 (stderr_file::write) ... this. Adjust.
12486 (stderr_file_fputs): Rename to ...
12487 (stderr_file::puts) ... this. Adjust.
12488 (stderr_fileopen, stdio_fileopen, gdb_fopen): Delete.
12489 (stderr_file::stderr_file): New.
12490 (tee_file_magic): Delete.
12491 (struct tee_file): Delete.
12492 (tee_file::tee_file): New.
12493 (tee_file_new): Delete.
12494 (tee_file::~tee_file): New.
12495 (tee_file_delete): Delete.
12496 (tee_file_flush): Rename to ...
12497 (tee_file::flush): ... this. Adjust.
12498 (tee_file_write): Rename to ...
12499 (tee_file::write): ... this. Adjust.
12500 (tee_file::write_async_safe): New.
12501 (tee_file_fputs): Rename to ...
12502 (tee_file::puts): ... this. Adjust.
12503 (tee_file_isatty): Rename to ...
12504 (tee_file::isatty): ... this. Adjust.
12505 * ui-file.h (struct obstack, struct ui_file): Don't
12507 (ui_file_new, ui_file_flush_ftype, set_ui_file_flush)
12508 (ui_file_write_ftype)
12509 (set_ui_file_write, ui_file_fputs_ftype, set_ui_file_fputs)
12510 (ui_file_write_async_safe_ftype, set_ui_file_write_async_safe)
12511 (ui_file_read_ftype, set_ui_file_read, ui_file_isatty_ftype)
12512 (set_ui_file_isatty, ui_file_rewind_ftype, set_ui_file_rewind)
12513 (ui_file_put_method_ftype, ui_file_put_ftype, set_ui_file_put)
12514 (ui_file_delete_ftype, set_ui_file_data, ui_file_fseek_ftype)
12515 (set_ui_file_fseek): Delete.
12516 (ui_file_data, ui_file_delete, ui_file_rewind)
12517 (struct ui_file): New.
12519 (class null_file): New.
12520 (null_stream): Declare.
12521 (ui_file_write_for_put, ui_file_put): Delete.
12522 (ui_file_xstrdup, ui_file_as_string, ui_file_obsavestring):
12524 (ui_file_fseek, mem_fileopen, stdio_fileopen, stderr_fileopen)
12525 (gdb_fopen, tee_file_new): Delete.
12526 (struct string_file): New.
12527 (struct stdio_file): New.
12528 (stdio_file_up): New.
12529 (struct stderr_file): New.
12530 (class tee_file): New.
12531 * ui-out.c (ui_out::field_stream): Take a 'string_file &' instead
12532 of a 'ui_file *'. Adjust.
12533 * ui-out.h (class ui_out) <field_stream>: Likewise.
12534 * utils.c (do_ui_file_delete, make_cleanup_ui_file_delete)
12535 (null_stream): Delete.
12536 (error_stream): Take a 'string_file &' instead of a 'ui_file *'.
12538 * utils.h (struct ui_file): Delete forward declaration..
12539 (make_cleanup_ui_file_delete, null_stream): Delete declarations.
12540 (error_stream): Take a 'string_file &' instead of a
12542 * varobj.c (varobj_value_get_print_value): Use string_file.
12543 * xtensa-tdep.c (xtensa_verify_config): Use string_file.
12544 * gdbarch.c: Regenerate.
12548 * disasm.c (gdb_disassembler::pretty_print_insn): Rename to...
12549 (gdb_pretty_print_insn): ... this. Now a free function. Add back
12550 a 'gdbarch' parameter. Allocate a mem_fileopen stream here.
12551 Adjust to call gdb_print_insn instead of
12552 gdb_disassembler::print_insn.
12553 (dump_insns, do_mixed_source_and_assembly_deprecated)
12554 (do_mixed_source_and_assembly, do_assembly_only): Add back a
12555 'gdbarch' parameter. Remove gdb_disassembler parameter.
12556 (gdb_disassembly): Don't allocate a gdb_disassembler here.
12557 * disasm.h (gdb_disassembler::pretty_print_insn): Delete
12559 (gdb_pretty_print_insn): Re-add declaration.
12560 * record-btrace.c (btrace_insn_history): Don't allocate a
12561 gdb_disassembler here. Adjust to call gdb_pretty_print_insn.
12565 * disasm.h (gdb_disassembly): Remove file_string parameter.
12566 * disasm.c (gdb_disassembly): Likewise.
12567 * cli/cli-cmds.c (print_disassembly): Adapt.
12568 * mi/mi-cmd-disas.c (mi_cmd_disassemble): Likewise.
12569 * stack.c (do_gdb_disassembly): Likewise.
12573 * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): For
12574 DWARF_VALUE_LITERAL, no longer ignore the offset on big-endian
12575 targets. And if the implicit value is longer than needed, extract
12576 the first bytes instead of the "least significant" ones.
12580 * btrace.c (btrace_enable): Do not call btrace_add_pc for
12581 BTRACE_FORMAT_PT or if can_access_registers_ptid returns false.
12582 (btrace_fetch): Assert can_access_registers_ptid.
12583 * record-btrace.c (require_btrace_thread, record_btrace_info): Call
12584 validate_registers_access.
12588 * gdbthread.h (can_access_registers_ptid): New.
12589 * thread.c (can_access_registers_ptid): New.
12593 * i386-tdep.c (i386_fast_tracepoint_valid_at): Use gdb_insn_length.
12597 * mi/mi-interp.c (mi_breakpoint_created, mi_breakpoint_modified):
12602 * stack.c (print_frame_args): Remove local mem_fileopen stream,
12607 * varobj.c (varobj_value_get_print_value): Remove xstrdup call.
12611 * common/scoped_restore.h
12612 (scoped_restore_tmpl::scoped_restore_tmpl): Template on T2, and
12613 change the value's parameter type to T2.
12614 (make_scoped_restore): Likewise.
12619 * amd64-linux-nat.c (PTRACE_ARCH_PRCTL): New define.
12620 (amd64_linux_fetch_inferior_registers): Add case to fetch FS_BASE
12621 GS_BASE for older kernels.
12622 (amd64_linux_store_inferior_registers): Add case to store FS_BASE
12623 GS_BASE for older kernels.
12624 * amd64-linux-tdep.c (amd64_linux_gregset_reg_offset): Add FS_BASE
12625 and GS_BASE to the offset table.
12626 (amd64_linux_register_reggroup_p): Add FS_BASE and GS_BASE to the
12627 system register group.
12628 * amd64-nat.c (amd64_native_gregset_reg_offset): Implements case
12630 * amd64-tdep.c (amd64_init_abi): Add segment registers for the
12632 * amd64-tdep.h (amd64_regnum): Add AMD64_FSBASE_REGNUM and
12633 AMD64_GSBASE_REGNUM.
12634 (AMD64_NUM_REGS): Set to AMD64_GSBASE_REGNUM + 1.
12635 * features/Makefile (amd64-linux.dat, amd64-avx-linux.dat)
12636 (amd64-mpx-linux.dat, amd64-avx512-linux.dat, x32-linux.dat)
12637 (x32-avx-linux.dat, x32-avx512-linux.dat): Add
12638 i386/64bit-segments.xml in those rules.
12639 * features/i386/64bit-segments.xml: New file.
12640 * features/i386/amd64-avx-mpx-linux.xml: Add 64bit-segments.xml.
12641 * features/i386/amd64-avx-linux.xml: Add 64bit-segments.xml.
12642 * features/i386/amd64-avx512-linux.xml: Add 64bit-segments.xml.
12643 * features/i386/amd64-mpx-linux.xml: Add 64bit-segments.xml.
12644 * features/i386/x32-avx512-linux.xml: Add 64bit-segments.xml.
12645 * features/i386/x32-avx-linux.xml: Add 64bit-segments.xml.
12646 * features/i386/amd64-linux.xml: Add 64bit-segments.xml.
12647 * features/i386/amd64-avx-linux.c: Regenerated.
12648 * features/i386/amd64-avx-mpx-linux.c: Regenerated.
12649 * features/i386/amd64-avx-mpx.c: Regenerated.
12650 * features/i386/amd64-avx512-linux.c: Regenerated.
12651 * features/i386/amd64-linux.c: Regenerated.
12652 * features/i386/amd64-mpx-linux.c: Regenerated.
12653 * features/i386/i386-avx-mpx-linux.c: Regenerated.
12654 * features/i386/i386-avx-mpx.c: Regenerated.
12655 * features/i386/x32-avx-linux.c: Regenerated.
12656 * features/i386/x32-avx512-linux.c: Regenerated.
12657 * regformats/i386/amd64-avx-linux.dat: Regenerated.
12658 * regformats/i386/amd64-avx-mpx-linux.dat: Regenerated.
12659 * regformats/i386/amd64-avx512-linux.dat: Regenerated.
12660 * regformats/i386/amd64-linux.dat: Regenerated.
12661 * regformats/i386/amd64-mpx-linux.dat: Regenerated.
12662 * regformats/i386/x32-avx-linux.dat: Regenerated.
12663 * regformats/i386/x32-avx512-linux.dat: Regenerated.
12664 * regformats/i386/x32-linux.dat: Regenerated.
12668 * amd64-linux-tdep.h (AMD64_LINUX_ORIG_RAX_REGNUM):
12669 Set to AMD64_NUM_REGS.
12673 * amd64-nat.c (amd64_native_gregset_reg_offset): Simplify logic
12674 that checks validity of a register number.
12678 * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call
12679 fetch_fpregs if target has fpa registers.
12680 (arm_linux_store_inferior_registers): Call store_fpregs if target
12685 * cris-tdep.c (cris_gdbarch_init): Remove check for
12686 info.byte_order and force it to BFD_ENDIAN_LITTLE.
12690 * corelow.c (get_core_register_section): Check for regset
12691 existence before checking for REGSET_VARIABLE_SIZE.
12697 * disasm.c (gdb_disassembler::dis_asm_memory_error): Don't
12698 call memory_error, save memaddr instead.
12699 (gdb_disassembler::print_insn): If gdbarch_print_insn returns
12700 negative, cal memory_error.
12701 * disasm.h (gdb_disassembler) <m_err_memaddr>: New field.
12705 * disasm-selftests.c (memory_error_test): New function.
12706 (_initialize_disasm_selftests): Register memory_error_test.
12710 * Makefile.in (SFILES): Add disasm-selftests.c and
12712 (COMMON_OBS): Add disasm-selftests.o and selftest-arch.o.
12713 * disasm-selftests.c: New file.
12714 * selftest-arch.c: New file.
12715 * selftest-arch.h: New file.
12719 * mep-tdep.c (mep_gdb_print_insn): Set info->arch
12720 to bfd_arch_mep. Don't return 0 if section is not
12721 found. Call print_insn_mep.
12726 * arm-tdep.c: Include "disasm.h".
12727 (gdb_print_insn_arm): Update code to get gdbarch.
12728 * disasm.c (dis_asm_read_memory): Change it to
12729 gdb_disassembler::dis_asm_read_memory.
12730 (dis_asm_memory_error): Likewise.
12731 (dis_asm_print_address): Likewise.
12732 (gdb_pretty_print_insn): Change it to
12733 gdb_disassembler::pretty_print_insn.
12734 (dump_insns): Add one argument gdb_disassemlber. All
12736 (do_mixed_source_and_assembly_deprecated): Likewise.
12737 (do_mixed_source_and_assembly): Likewise.
12738 (do_assembly_only): Likewise.
12739 (gdb_disassembler::gdb_disassembler): New.
12740 (gdb_disassembler::print_insn): New.
12741 * disasm.h (class gdb_disassembler): New.
12742 (gdb_pretty_print_insn): Remove declaration.
12743 (gdb_disassemble_info): Likewise.
12744 * guile/scm-disasm.c (class gdbscm_disassembler): New.
12745 (gdbscm_disasm_read_memory_worker): Update.
12746 (gdbscm_disasm_read_memory): Update.
12747 (gdbscm_disasm_memory_error): Remove.
12748 (gdbscm_disasm_print_address): Remove.
12749 (gdbscm_disassembler::gdbscm_disassembler): New.
12750 (gdbscm_print_insn_from_port): Update.
12751 * mips-tdep.c: Include disasm.h.
12752 (gdb_print_insn_mips): Update code to get gdbarch.
12753 * record-btrace.c (btrace_insn_history): Update.
12754 * spu-tdep.c: Include disasm.h.
12755 (struct spu_dis_asm_data): Remove.
12756 (struct spu_dis_asm_info): New.
12757 (spu_dis_asm_print_address): Use spu_dis_asm_info to get
12759 (gdb_print_insn_spu): Cast disassemble_info to
12764 * disasm.c (do_ui_file_delete): Delete.
12765 (gdb_insn_length): Move code creating stream to ...
12766 * utils.c (null_stream): ... here. New function.
12767 * utils.h (null_stream): Declare.
12771 * python/py-inferior.c (find_thread_object): Return directly
12772 from the loop. Remove "found" variable.
12776 GDB 7.12.1 released.
12780 * python/py-function.c (fnpy_call): Reorder declarations to have
12781 the gdbpy_enter object declared first.
12782 * python/py-xmethods.c (gdbpy_get_xmethod_arg_types): Likewise.
12787 * python/python-internal.h (PyMem_RawMalloc): Define for
12789 * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use
12790 PyMem_RawMalloc instead of PyMem_Malloc.
12795 * NEWS (New commands): Mention flash-erase.
12796 (New MI commands): Mention target-flash-erase.
12797 * mi/mi-cmds.c (mi_cmd_target_flash_erase): Add target-flash-erase MI
12799 * mi/mi-cmds.h (mi_cmd_target_flash_erase): New declaration.
12800 * mi/mi-main.c (mi_cmd_target_flash_erase): New function.
12801 * target.c (flash_erase_command): New function.
12802 (initialize_targets): Add new flash-erase command.
12803 * target.h (flash_erase_command): New declaration.
12807 * nat/linux-ptrace.c: Only include <sys/procfs.h> if
12808 HAVE_SYS_PROCFS_H is defined.
12812 * remote.c (struct cached_reg): Change data into a pointer.
12813 * (stop_reply_dtr): Free data pointers before deleting vector.
12814 (process_stop_reply): Likewise.
12815 (remote_parse_stop_reply): Allocate space for data
12819 * amd64-tdep.c (amd64_pseudo_register_read_value): remove
12821 (amd64_pseudo_register_read_value): Likewise.
12822 * remote.c (fetch_register_using_p): Remove MAX_REGISTER_SIZE.
12823 (store_register_using_P): Likewise.
12824 * regcache.c (regcache_xfer_part): Likewise.
12828 Split real and pseudo registers.
12829 * sparc-tdep.h (SPARC_CORE_REGISTERS): New macro.
12830 (sparc32_pseudo_regnum): New enum.
12831 * sparc64-tdep.h (sparc64_pseudo_regnum): New enum.
12832 * sparc-tdep.c (SPARC32_FPU_REGISTERS): New macro.
12833 (SPARC32_CP0_REGISTERS): New macro.
12834 (sparc32_pseudo_register_name): New function.
12835 (sparc32_register_name): Use sparc32_pseudo_register_name.
12836 (sparc32_pseudo_register_type): New function.
12837 (sparc32_register_type): Use sparc32_pseudo_register_type.
12838 (sparc32_pseudo_register_read, sparc32_pseudo_register_write): Handle
12839 pseudo register numbers.
12840 * sparc64-tdep.c SPARC64_FPU_REGISTERS): New macro.
12841 (SPARC64_CP0_REGISTERS): New macro.
12842 (sparc64_pseudo_register_name): New function.
12843 (sparc64_register_name): Use sparc64_pseudo_register_name.
12844 (sparc64_pseudo_register_type): New function.
12845 (sparc64_register_type): Use sparc64_pseudo_register_type.
12846 (sparc64_pseudo_register_read, sparc64_pseudo_register_write): Handle
12847 pseudo register numbers.
12848 (sparc64_store_floating_fields, sparc64_extract_floating_fields,
12849 sparc64_store_arguments): Handle pseudo register numbers.
12853 * remote.c (REMOTE_DEBUG_MAX_CHAR): New macro.
12854 (putpkt_binary): Print only REMOTE_DEBUG_MAX_CHAR chars in debug
12856 (getpkt_or_notif_sane_1): Likewise.
12860 * Makefile.in (checker-headers): Use CXX and CXX_DIALET instead
12861 of CC. Pass "-x c++-header" instead of "-x c".
12865 * remote.c (remote_can_async_p): Update comment.
12869 * linux-nat.c (linux_nat_can_async_p): Update comment.
12873 * serial.c (serial_open): Forget about "pc" and "lpt" serial interface.
12877 * cli/cli-decode.c (lookup_cmd_1): Fix typo in comment.
12881 * python/py-type.c (typy_legacy_template_argument): Update.
12882 * cp-support.h (struct demangle_parse_info) (demangle_parse_info,
12883 ~demangle_parse_info): Declare new members.
12884 (cp_demangled_name_to_comp): Return unique_ptr.
12885 (cp_demangled_name_parse_free)
12886 (make_cleanup_cp_demangled_name_parse_free)
12887 (cp_new_demangle_parse_info): Remove.
12888 * cp-support.c (do_demangled_name_parse_free_cleanup)
12889 (make_cleanup_cp_demangled_name_parse_free): Remove.
12890 (inspect_type, cp_canonicalize_string_full)
12891 (cp_canonicalize_string): Update.
12892 (mangled_name_to_comp): Change return type.
12893 (cp_class_name_from_physname, method_name_from_physname)
12894 (cp_func_name, cp_remove_params): Update.
12895 * cp-name-parser.y (demangle_parse_info): New constructor, from
12896 cp_new_demangle_parse_info.
12897 (~demangle_parse_info): New destructor, from
12898 cp_demangled_name_parse_free.
12899 (cp_merge_demangle_parse_infos): Update.
12900 (cp_demangled_name_to_comp): Change return type.
12904 * top.c (prevent_dont_repeat): Change return type.
12905 * python/python.c (execute_gdb_command): Use std::string.
12907 * guile/guile.c (gdbscm_execute_gdb_command): Update.
12908 * command.h (prevent_dont_repeat): Change return type.
12909 * breakpoint.c (bpstat_do_actions_1): Update.
12913 * value.h (scoped_value_mark::~scoped_value_mark): Call
12915 (scoped_value_mark::free_to_mark): New method.
12916 * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use
12921 * python/py-value.c (valpy_dereference, valpy_referenced_value)
12922 (valpy_reference_value, valpy_const_value, valpy_get_address)
12923 (valpy_get_dynamic_type, valpy_lazy_string, valpy_do_cast)
12924 (valpy_getitem, valpy_call, valpy_binop_throw, valpy_negative)
12925 (valpy_absolute, valpy_richcompare_throw): Use scoped_value_mark.
12926 * dwarf2loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use
12928 * dwarf2-frame.c (execute_stack_op): Use scoped_value_mark.
12929 * value.h (scoped_value_mark): New class.
12933 * dwarf2read.c (dwarf2_build_psymtabs): Use psymtab_discarder.
12934 * psympriv.h (make_cleanup_discard_psymtabs): Don't declare.
12935 * psymtab.c (discard_psymtabs_upto): Remove.
12936 (make_cleanup_discard_psymtabs): Remove.
12937 (struct psymtab_state): Remove.
12941 * record-full.c (record_full_save_cleanups): Remove.
12942 (record_full_save): Use gdb::unlinker.
12943 * gcore.c (do_bfd_delete_cleanup): Remove.
12944 (gcore_command): Use gdb::unlinker, unique_xmalloc_ptr. Remove
12946 * dwarf2read.c (unlink_if_set): Remove.
12947 (write_psymtabs_to_index): Use gdb::unlinker.
12948 * common/gdb_unlinker.h: New file.
12952 * windows-tdep.c (windows_xfer_shared_library): Update.
12953 * windows-nat.c (windows_make_so): Update.
12954 * utils.h (make_cleanup_bfd_unref): Remove.
12955 * utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove.
12956 * symfile.h (symfile_bfd_open)
12957 (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr.
12958 * symfile.c (read_symbols, symbol_file_add)
12959 (separate_debug_file_exists): Update.
12960 (symfile_bfd_open): Return gdb_bfd_ref_ptr.
12961 (generic_load, reread_symbols): Update.
12962 * symfile-mem.c (symbol_file_add_from_memory): Update.
12963 * spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr.
12964 (spu_symbol_file_add_from_memory): Update.
12965 * solist.h (struct target_so_ops) <bfd_open>: Return
12967 (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr.
12968 * solib.c (solib_bfd_fopen, solib_bfd_open): Return
12970 (solib_map_sections, reload_shared_libraries_1): Update.
12971 * solib-svr4.c (enable_break): Update.
12972 * solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr.
12973 * solib-frv.c (enable_break2): Update.
12974 * solib-dsbt.c (enable_break): Update.
12975 * solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return
12977 (darwin_solib_get_all_image_info_addr_at_init): Update.
12978 (darwin_bfd_open): Return gdb_bfd_ref_ptr.
12979 * solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr.
12980 * record-full.c (record_full_save): Update.
12981 * python/py-objfile.c (objfpy_add_separate_debug_file): Update.
12982 * procfs.c (insert_dbx_link_bpt_in_file): Update.
12983 * minidebug.c (find_separate_debug_file_in_section): Return
12985 * machoread.c (macho_add_oso_symfile): Change abfd to
12987 (macho_symfile_read_all_oso): Update.
12988 (macho_check_dsym): Return gdb_bfd_ref_ptr.
12989 (macho_symfile_read): Update.
12990 * jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr.
12991 (jit_bfd_try_read_symtab): Update.
12992 * gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
12993 (gdb_bfd_openw, gdb_bfd_openr_iovec)
12994 (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
12996 (gdb_bfd_ref_policy): New struct.
12997 (gdb_bfd_ref_ptr): New typedef.
12998 * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
12999 (gdb_bfd_openw, gdb_bfd_openr_iovec)
13000 (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
13002 * gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr.
13003 * gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr.
13004 (gcore_command): Update.
13005 * exec.c (exec_file_attach): Update.
13006 * elfread.c (elf_symfile_read): Update.
13007 * dwarf2read.c (dwarf2_get_dwz_file): Update.
13008 (try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr.
13009 (open_and_init_dwo_file): Update.
13010 (open_dwp_file): Return gdb_bfd_ref_ptr.
13011 (open_and_init_dwp_file): Update.
13012 * corelow.c (core_open): Update.
13013 * compile/compile-object-load.c (compile_object_load): Update.
13014 * common/gdb_ref_ptr.h (ref_ptr::operator->): New operator.
13015 * coffread.c (coff_symfile_read): Update.
13016 * cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return
13017 gdb_bfd_ref_ptr. Rename.
13018 (dump_bfd_file, restore_command): Update.
13019 * build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
13020 * build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
13021 (find_separate_debug_file_by_buildid): Update.
13025 * common/gdb_ref_ptr.h: New file.
13026 * python/py-ref.h (struct gdbpy_ref_policy): New.
13027 (gdbpy_ref): Now a typedef.
13031 * utils.h (make_cleanup_htab_delete): Don't declare.
13032 * utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete):
13034 * linespec.c (decode_compound_collector): Add constructor,
13036 (lookup_prefix_sym): Remove cleanup.
13037 (symtab_collector): Add constructor, destructor.
13038 (collect_symtabs_from_filename): Remove cleanup.
13039 * disasm.c (do_mixed_source_and_assembly): Use htab_up.
13040 * compile/compile-c-symbols.c (generate_c_for_variable_locations):
13042 * gnu-v3-abi.c (gnuv3_print_vtable): Use htab_up.
13043 * dwarf2read.c (dw2_expand_symtabs_matching)
13044 (dw2_map_symbol_filenames, dwarf_decode_macros)
13045 (write_psymtabs_to_index): Use htab_up.
13046 * dwarf2loc.c (func_verify_no_selftailcall)
13047 (call_site_find_chain_1, func_verify_no_selftailcall)
13048 (chain_candidate, call_site_find_chain_1): Use std::unordered_set,
13049 std::vector, gdb::unique_xmalloc_ptr.
13050 (call_sitep): Remove typedef.
13051 (dwarf2_locexpr_baton_eval): Remove unused variable.
13055 * python/python-internal.h (make_cleanup_py_decref)
13056 (make_cleanup_py_xdecref): Don't declare.
13057 * python/py-utils.c (py_decref, make_cleanup_py_decref)
13058 (py_xdecref, make_cleanup_py_xdecref): Remove.
13062 * python/py-framefilter.c (py_mi_print_variables): Use gdbpy_ref.
13063 (py_print_locals, enumerate_locals, py_print_args): Use gdbpy_ref.
13067 * python/py-framefilter.c (enumerate_args): Use gdbpy_ref.
13071 * python/py-utils.c (unicode_to_encoded_string)
13072 (python_string_to_target_string)
13073 (python_string_to_target_python_string)
13074 (python_string_to_host_string, gdbpy_obj_to_string)
13075 (get_addr_from_python): Use gdbpy_ref.
13079 * python/py-unwind.c (pyuw_object_attribute_to_pointer): Use
13084 * python/python.c (eval_python_command, gdbpy_decode_line)
13085 (gdbpy_run_events, gdbpy_start_type_printers)
13086 (gdbpy_apply_type_printers): Use gdbpy_ref.
13090 * python/py-param.c (get_doc_string, compute_enum_values): Use
13095 * python/py-inferior.c (find_thread_object, build_inferior_list):
13100 * python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
13104 * python/py-finishbreakpoint.c (bpfinishpy_out_of_scope): Use
13109 * python/py-cmd.c (cmdpy_completer_helper): Use gdbpy_ref. Remove
13111 (cmdpy_completer_handle_brkchars, cmdpy_completer, cmdpy_init):
13116 * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Use
13121 * python/py-arch.c (archpy_disassemble): Use gdbpy_ref. Don't
13122 decref results of PyArg_ParseTupleAndKeywords.
13126 * python/python.c (python_run_simple_file): Use
13127 unique_xmalloc_ptr, gdbpy_ref.
13131 * python/py-prettyprint.c (print_stack_unless_memory_error)
13132 (print_string_repr, print_children): Use gdbpy_ref.
13133 (dummy_python_frame): New class.
13134 (dummy_python_frame::dummy_python_frame): Rename from
13135 push_dummy_python_frame.
13136 (py_restore_tstate): Remove.
13140 * python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
13144 * python/python.c (ensure_python_env, restore_python_env):
13146 * python/python-internal.h (ensure_python_env): Don't declare.
13147 * varobj.h (varobj_ensure_python_env): Don't declare.
13148 * varobj.c (varobj_ensure_python_env): Remove.
13152 * varobj.c (varobj_value_get_print_value): Use
13153 gdbpy_enter_varobj.
13157 * python/py-prettyprint.c (print_string_repr, print_children):
13159 * python/py-lazy-string.c (gdbpy_extract_lazy_string): Change type
13161 * varobj.c (varobj_value_get_print_value): Update.
13162 * python/python-internal.h (gdbpy_extract_lazy_string): Update.
13166 * varobj.c (varobj_get_display_hint)
13167 (dynamic_varobj_has_child_method, install_new_value_visualizer)
13168 (varobj_set_visualizer, free_variable): Use
13169 gdbpy_enter_varobj.
13173 * python/python.c (python_command): Use gdbpy_enter, gdbpy_ref.
13174 (do_finish_initialization): New function. Use gdbpy_ref.
13175 (gdbpy_finish_initialization): Use gdbpy_enter. Call
13176 do_finish_initialization.
13180 * python/py-param.c (get_set_value, get_show_value): Use
13181 gdbpy_enter, gdbpy_ref.
13185 * python/py-function.c (fnpy_call): Use gdbpy_enter, gdbpy_ref.
13189 * python/py-cmd.c (cmdpy_function): Use gdbpy_enter, gdbpy_ref.
13193 * python/py-varobj.c (py_varobj_iter_dtor, py_varobj_iter_next):
13194 Use gdbpy_enter_varobj.
13198 * varobj.c (gdbpy_enter_varobj): New constructor.
13199 * python/python-internal.h (gdbpy_enter_varobj): New class.
13200 * python/py-varobj.c (py_varobj_get_iterator): Use
13201 gdbpy_enter_varobj.
13205 * python/py-xmethods.c (gdbpy_get_xmethod_result_type): Use
13206 gdbpy_enter, gdbpy_ref, unique_xmalloc_ptr.
13207 (gdbpy_invoke_xmethod): Use gdbpy_ref, gdbpy_enter.
13208 (gdbpy_get_xmethod_arg_types): Use gdbpy_ref,
13209 unique_xmalloc_ptr.
13210 (gdbpy_get_xmethod_arg_types): Use gdbpy_ref, gdbpy_enter.
13214 * python/py-xmethods.c (invoke_match_method): Use
13219 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): use
13220 gdbpy_enter, gdbpy_ref.
13224 * python/python.c (python_interactive_command): Use gdbpy_enter.
13228 * python/python.c (gdbpy_before_prompt_hook): Use gdbpy_enter,
13233 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Use
13234 gdbpy_enter, gdbpy_ref, unique_xmalloc_ptr.
13238 * utils.h (htab_deleter): New struct.
13239 (htab_up): New typedef.
13240 * python/py-framefilter.c (gdbpy_apply_frame_filter): Use
13241 gdbpy_enter, gdbpy_ref, htab_up.
13245 * python/py-unwind.c (pending_frame_invalidate): Remove.
13246 (pyuw_sniffer): Use gdbpy_enter and gdbpy_ref.
13250 * python/py-xmethods.c (gdbpy_free_xmethod_worker_data)
13251 (gdbpy_clone_xmethod_worker_data): Use gdbpy_enter.
13255 * python/py-type.c (save_objfile_types): Use gdbpy_enter.
13259 * python/python.c (gdbpy_eval_from_control_command)
13260 (gdbpy_source_script, gdbpy_run_events)
13261 (gdbpy_source_objfile_script, gdbpy_execute_objfile_script)
13262 (gdbpy_free_type_printers, gdbpy_finish_initialization): Use
13267 * python/py-progspace.c (py_free_pspace): Use gdbpy_enter.
13271 * python/py-objfile.c (py_free_objfile): Use gdbpy_enter.
13275 * python/py-inferior.c (python_on_normal_stop, python_on_resume)
13276 (python_on_inferior_call_pre, python_on_inferior_call_post)
13277 (python_on_memory_change, python_on_register_change)
13278 (python_inferior_exit, python_new_objfile, add_thread_object)
13279 (delete_thread_object, py_free_inferior): Use gdbpy_enter.
13283 * python/py-finishbreakpoint.c (bpfinishpy_handle_stop)
13284 (bpfinishpy_handle_exit): Use gdbpy_enter.
13288 * python/py-cmd.c (cmdpy_destroyer)
13289 (cmdpy_completer_handle_brkchars, cmdpy_completer): Use
13294 * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Use
13296 (gdbpy_breakpoint_has_cond): Likewise.
13300 * python/python.c (gdbpy_enter): New constructor.
13301 (~gdbpy_enter): New destructor.
13302 (restore_python_env, ensure_python_env): Rewrite.
13303 * python/python-internal.h (gdbpy_enter): New class.
13307 * python/py-symbol.c (gdbpy_lookup_symbol): Use gdbpy_ref.
13311 * python/py-value.c (value_has_field, get_field_flag)
13312 (get_field_type, valpy_getitem, convert_value_from_python): Use
13317 * python/python.c (gdbpy_progspaces, gdbpy_objfiles): Use
13322 * python/py-prettyprint.c (search_pp_list)
13323 (find_pretty_printer_from_objfiles)
13324 (find_pretty_printer_from_progspace)
13325 (find_pretty_printer_from_gdb, find_pretty_printer)
13326 (gdbpy_get_display_hint, gdbpy_get_varobj_pretty_printer): Use
13331 * python/py-param.c (call_doc_function): Use gdbpy_ref.
13335 * python/py-linetable.c (build_line_table_tuple_from_pcs)
13336 (ltpy_get_all_source_lines): Use gdbpy_ref.
13340 * python/py-framefilter.c (extract_sym, extract_value)
13341 (get_py_iter_from_func, bootstrap_python_frame_filters): Use
13346 * python/py-breakpoint.c (gdbpy_breakpoints): Use gdbpy_ref.
13350 * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref.
13354 * python/py-function.c (convert_values_to_python, fnpy_init): Use
13359 * python/py-cmd.c (gdbpy_string_to_argv): Use gdbpy_ref.
13363 * python/py-type.c (convert_field, make_fielditem, typy_fields)
13364 (typy_range): Use gdbpy_ref.
13368 * python/py-threadevent.c (create_thread_event_object): Use
13370 * python/py-stopevent.c (create_stop_event_object): Simplify.
13371 (emit_stop_event): Use gdbpy_ref.
13372 * python/py-signalevent.c (create_signal_event_object): Use
13374 * python/py-newobjfileevent.c (create_new_objfile_event_object)
13375 (emit_new_objfile_event, create_clear_objfiles_event_object)
13376 (emit_clear_objfiles_event): Use gdbpy_ref.
13377 * python/py-infevents.c (create_inferior_call_event_object)
13378 (create_register_changed_event_object)
13379 (create_memory_changed_event_object, emit_inferior_call_event)
13380 (emit_memory_changed_event, emit_register_changed_event): Use
13382 * python/py-exitedevent.c (create_exited_event_object)
13383 (emit_exited_event): Use gdbpy_ref.
13384 * python/py-event.h (evpy_emit_event): Remove
13385 CPYCHECKER_STEALS_REFERENCE_TO_ARG annotation.
13386 * python/py-event.c (evpy_emit_event): Use gdbpy_ref.
13387 * python/py-continueevent.c (emit_continue_event): Use
13389 * python/py-breakpoint.c (gdbpy_breakpoint_created)
13390 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
13392 * python/py-bpevent.c (create_breakpoint_event_object): Use
13397 * python/py-ref.h: New file.
13401 * cli-out.c (cli_ui_out::do_redirect): Change return type to
13403 * cli-out.h (cli_ui_out::do_redirect): Likewise.
13404 * mi/mi-out.c (mi_ui_out::do_redirect): Likewise.
13405 * mi/mi-out.h (mi_ui_out::do_redirect): Likewise.
13406 * ui-out.c (ui_out::redirect): Likewise.
13407 * ui-out.h (ui_out::redirect, ui_out::do_redirect): Likewise.
13408 * cli/cli-logging.c (set_logging_redirect): Update call site of
13410 (handle_redirections): Likewise.
13411 * scm-ports.c (ioscm_with_output_to_port_worker): Likewise.
13412 * top.c (execute_command_to_string): Likewise.
13413 * utils.c (do_ui_out_redirect_pop): Likewise.
13417 * stack.c (_initialize_stack): Update "frame" command help message.
13421 * d-exp.y (CastExpression): Emit UNOP_CAST_TYPE.
13425 * x86-linux-nat.h: Include gdb_proc_service.h.
13429 * ser-base.h: Include serial.h.
13433 * ppc-linux-tdep.h: Include ppc-tdep.h.
13437 * nat/amd64-linux-siginfo.h: Include signal.h.
13441 * nat/aarch64-linux-hw-point.h: Include break-common.h.
13445 * mi/mi-parse.h: Include mi-cmds.h.
13449 * inf-loop.c: Don't include "target.h".
13450 * inf-loop.h: Include it here.
13454 * dfp.h: Include "dboulest.h" and "expression.h".
13458 * ax-gdb.h: Include "ax.h".
13462 * Makefile.in (HFILES_NO_SRCDIR): Replace gdb_ptrace.h
13463 with nat/gdb_ptrace.h.
13467 * mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to
13469 (mips64_fbsd_sigframe_init): Likewise.
13473 * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Use
13474 GDB_OSABI_FREEBSD instead of GDB_OSABI_FREEBSD_ELF.
13478 * Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c.
13479 * NEWS: Mention new FreeBSD/mips native configuration.
13480 * config/mips/fbsd.mh: New file.
13481 * configure.host: Add mips*-*-freebsd*.
13482 * mips-fbsd-nat.c: New file.
13486 * Makefile.in (ALL_TARGET_OBS): Add mips-fbsd-tdep.o.
13487 (ALLDEPFILES): Add mips-fbsd-tdep.c.
13488 * NEWS: Mention new FreeBSD/mips target.
13489 * configure.tgt: Add mips*-*-freebsd*.
13490 * mips-fbsd-tdep.c: New file.
13491 * mips-fbsd-tdep.h: New file.
13495 * dwarf2loc.c (write_pieced_value): Don't use VALUE_FRAME_ID (to),
13496 use c->frame_id when the piece location is DWARF_VALUE_REGISTER.
13500 Update copyright year range in all GDB files.
13504 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2016.
13506 For older changes see ChangeLog-2016.
13512 version-control: never