3 * Makefile.in: Changed check target to use DejaGnu.
7 * Makefile.in: Remove am29k-pinsn.c, i960-pinsn.c.
8 objdump.c: a29k and i960 are `disassemble' not `print'.
10 * objdump.c: Rename print_address to objdump_print_address
11 and change parameters.
12 (disassemble_data): Use objdump_print_address.
16 * objdump.c (disassemble_data): print_insn_sparc is now a
17 `disassemble' not a `print'.
18 Makefile.in: Remove sparc-pinsn.c (now in libopcodes.a).
20 * objdump.c (disassemble_data): Use new read_memory_func stuff.
24 * objdump.c (fprintf): Declaration of variadic function had better
25 be a prototype for ANSI C systems.
27 Mon Mar 22 23:19:46 1993 david d `zoo' zuhn (zoo at cirdan.cygnus.com)
29 * Makefile.in: rename test-install to install-check
33 * objdump.c (disassemble_data): Add H8500.
37 * objdump.c (usage): Mention long options.
41 * nm.c: Modify behavior of -o flag for archives to match
42 BSD4.4 and Sunos 4: Prefix archive name before each line.
44 * m68k-pinsn.c: Removed. Subsumed by ../opcodes/m68k-dis.c.
45 * i386-pinsn.c: Removed. Subsumed by ../opcodes/i386-dis.c.
46 * Makefile.in: Adjust accordingly.
47 * objdump.c: Support new-style disassemblers (ones that use
48 the interface of ../include/dis-asm.h).
52 * Makefile.in: When making tar file, remove texinfo/*,
53 except for texinfo/texinfo.tex.
54 * ardup.c: Add extern declaration of strdup.
55 * Makefile.in (testsuite): Add 'else true' since otherwise
56 Ultrix /bin/sh complains.
60 * Makefile.in: Set VERSION to 2.1.
61 * README, NEWS: Updates.
62 * nm.c: Add -v as a synonym for -V.
66 * configure.in: added testsuite to configdirs.
67 * Makefile.in: added support for building testsuite.
71 * objdump.c (disassemble_data): Print function names when
72 given by bfd_find_nearest_line. If not - still print
77 * binutils/testsuite: made modifications to testcases, etc., to allow
78 them to work properly given the reorganization of deja-gnu and the
79 relocation of the testcases from deja-gnu to a "tool" subdirectory.
83 * objdump.c (dump_data): Free up section contents each time
88 * binutils/testsuite: Initial creation of binutils/testsuite.
89 Migrated dejagnu testcases and support files for testing nm to
90 binutils/testsuite from deja-gnu. These files were moved "as is"
91 with no modifications. This migration is part of a major overhaul
92 of dejagnu. The modifications to these testcases, etc., which
93 will allow them to work with the new version of dejagnu will be
94 made in a future update.
98 * Makefile.in (LIBIBERTY_SRC_DIR, LIBIBERTY_BIN_DIR): New macros.
99 * Makefile.in (LIBIBERTY): Use LIBIBERTY_BIN_DIR.
100 * Makefile.in (DEMANGLER_PROG): New program to build. Add macro
102 * Makefile.in (PROGS): Add DEMANGLER_PROG.
106 * copy.c, nm.c, objdump.c, size.c: Use new bfd_is_com_section
107 macro rather than checking for equality to bfd_com_section.
111 * objdump.c (disassemble_data): Fix code to find first useless
116 * objdump.c (disassemble_data): Use mips_print_insn for MIPS.
117 Don't core dump if bfd_find_nearest_line returns false.
121 * objdump.c (disassemble_data): know how to disassemble z8000s
126 * arsup.h (interactive), bucomm.h (program_name): Prefix
127 with 'extern', to avoid warnings from some compilers.
131 * arparse.y: fix unnecessary shift/reduce
135 * Makefile.in: Make check depend on all.
136 * Makefile.in (distclean): Remove sysdep.h.
137 * size.c: Use %u format where appropriate.
138 * objdump.c: Standardize: L_SET -> SEEK_SET.
139 * objdump.c: Use new macro bfd_asymbol_bfd.
140 * configure.in: Allow std-host as the default ${mys_host}.
142 Thu Dec 17 19:38:19 1992 david d `zoo' zuhn (zoo at cirdan.cygnus.com)
144 * Makefile.in: added dvi target, define and use TEXI2DVI
148 * Makefile.in (dist): Fix permissions before release.
149 * size.c: Use bfd_size_type (and long) where appropriate.
150 * ar.c: Make writing a map the default, to be compatible
151 with SYSV and Posix.2. Remove some bogus kludges that
152 handled __.SYMDEF directly.
155 Mon Nov 9 13:36:53 1992 david d `zoo' zuhn (zoo at cirdan.cygnus.com)
157 * Makefile.in: flex no longer needs the -S flag
159 Sat Nov 7 15:06:13 1992 david d `zoo' zuhn (zoo at cirdan.cygnus.com)
161 * ar.c (extract_file): utime needs a pointer to a utimbuf
163 * Makefile.in: handle -I includes better, adding $(BASEDIR)/bfd to
164 the list (since some of the bfd/hosts/*.h files include other
165 files from that directory)
169 * i960-pinsn.c (MEM_MAX, MEM_SIZ): Set upper bound properly.
173 Clean up some old BFD ansification macros.
175 * arsup.h, bucomm.h, objdump.h: Remove EXFUN from binutils.
176 It still remains as a local macro in gmalloc.c, which is derived
177 from some other copy of GNU Malloc somewhere (FIXME).
179 * ar.c, objdump.c, size.c: Replace EXFUN with PROTO. Make static
181 * arsup.h: Declare extract_files.
185 * ar.c (extract_file): instead of checking USG: if POSIX_UTIME,
186 use utime and utimbuf structure, otherwise if USE_UTIME use utime
187 and array of two longs, otherwise use utimes.
191 * binutils.tex: Document yesterday's changes to strip and copy.
195 * copy.c: Re-do command-line parsing to use getopt_long().
196 Add long option names. Re-think option letters to be more
198 * copy.c: New function filter_symbols() for stripping only
199 debug-symbols and/or local symbols. Use these to support
200 the previously-missing options of the old FSF strip.
204 * configure.in (host): Use ${srcdir}/../bfd/configure.host rather
205 than repeating a copy of it here.
209 * copy.c (main): Even if is_strip, accept -d argument indicating
210 alternate output format. Needed by gdb for Nindy.
212 * m68k-pinsn.c (print_insn_arg): Handle new "`" operand type.
216 * binutils.texi: added documentation for "copy"
218 Tue Oct 6 14:22:56 1992 Per Bothner (bothner at PersSony)
220 * Makefile.in (*clean rules): Some cleaning up.
221 * Makefile.in (dist): Make diststuff in gprof for a dist.
223 * ar.c (do_show_version): New function.
224 * ar.c (main): Fix so "ar -V" works.
226 Thu Oct 1 22:44:45 1992 david d `zoo' zuhn (zoo at cirdan.cygnus.com)
228 * configure.in: now uses the cpu-vendor-os triple instead of
233 * i960-pinsn.c: Change bzero to memset.
234 * sparc-pinsn.c: Change index to strchr.
238 * m68k-pinsn (print_insn_arg, fetch_arg): added support for
239 operands to memory management instructions, from WRS.
243 * Makefile.in (install): if $(tooldir) exists, install nm and
244 strip in $(tooldir)/bin.
248 * Makefile.in: Let's call it version 2.0.
252 * Makefile.in: Bump to version 0.98.
253 * TODO, README: Minor updates.
255 * Makefile.in: Added mostlyclean, distclean rules,
256 and cleaned up clean, realclean.
260 * Makefile.in: map program names through program_transform_name
265 * Makefile.in: Bump to versions 1.97.90.
266 * cplus-dem.c: Removed. Was nowhere used - and if some
267 programs are changed to to demangling should now use the
268 versions in libiberty.
272 * configure.in: add we32k
276 * ar.c (map_over_members): if the element of the archive has a
277 null name, fill it in.
279 * nm.c (do_one_rel_file): only warn if a bfd's flags say there
280 will be symbols and there aren't any.
284 * m68k-pinsn.c: handle new operand type 'r', introduced for cas2.
288 * nm.c objdump.c: Added support for a +version (-V)
289 to print the version number.
291 * ar.c, copy.c: Added support for a -V option to print
296 * config/mh-apollo68v: removed -g from CC definition.
298 * Makefile.in: always create installation directories.
302 * m68k-pinsn.c: Minor fix in style of output (don't use
303 range to indicate floating point control registers).
307 * ar.c (main): Don't *always* set the verbose flag!
311 * copy.c: When is_strip (because it is invoked as the strip
312 program), follow traditional argv processing:
313 'strip file1 file2' now strips file1 and file2, rather
314 than stripping file1 (as input), leaving output in file2.
318 * objdump.c (display_info, display_info_table): Call
319 bfd_set_format() on dummy bfd before using it (twice).
320 * ar.c: Make sure archive is created on command 'r'
321 even when no elements are inserted. (Clean up and
322 simplify some non-working related code.)
326 * configure.in: hppa support doesn't assume hp OS (from sef).
328 Sat Jul 18 14:35:22 1992 david d `zoo' zuhn (zoo at cirdan.cygnus.com)
330 * configure.in: recognize hppa hosts (bsd & hpux), error messages
331 to stderr, not stdout
335 * ar.1, binutils.texi, i960-pinsn.c, nm.1, objdump.1, ranlib.1,
336 size.1, sparc-pinsn.c, strip.1: removed rcsid's.
340 * Makefile.dos: removed rcsid.
344 * objdump.c (display_bfd): print state of BFD_IS_RELAXABLE too
348 * Makefile.in: Add program_suffix (parallel to program_prefix)
350 Thu Jun 25 04:52:45 1992 John Gilmore (gnu at cygnus.com)
352 * nm.c (sorters): Lint. Remove excess whitespace.
356 * nm.c (valueof macro): Add missing parentheses.
357 (Their lack screwed up numeric_forward().)
359 Sun Jun 14 10:33:27 1992 John Gilmore (gnu at cygnus.com)
361 * objdump.c (dump_elf_stabs): Also dump .stab.index and
363 (dump_elf_stabs_1): Split out main body of old dump_elf_stabs.
364 * objdump.1, binutils.texi: Document new sections dumped.
366 Fri Jun 12 22:23:35 1992 John Gilmore (gnu at cygnus.com)
368 * size.c, objdump.c, bucomm.c: Lint.
370 Thu Jun 11 01:19:06 1992 John Gilmore (gnu at cygnus.com)
372 * objdump.c (dump_elf_stabs): New feature: --stabs prints out a
373 .stab section from an ELF file. Installed under #ifdef
374 ELF_STAB_DISPLAY so it can be easily disabled, since it requires
375 bfd-internals header files and such.
376 * objdump.1, binutils.texi: Update for --stabs. Also fix
377 objdump's doc to use -- rather than + for long options.
378 (FIXME: Not yet fixed everywhere in binutils.texinfo.)
382 * objdump.c(display_info), patches from
388 * objdump.c: Add another enum->int cast, for the sake of
389 old compilers (such as PCC).
393 * arlex.l: Don't include <sysdep.h> (unneeded conflicts).
394 Add declaration of strdup().
398 * Makefile.in: Use srcdir instead of VPATH in ldgram/ldlex
399 rules, since these are used when building a distribution.
400 * Makefile.in (arlex.c): Don't re-direct output, since that
401 leaves a bogus output files if it fails.
403 * arlex.l: Make work with lex, for what it's worth.
404 * Makefile.in: Better lex support.
405 * Makefile.in (dist): Generate flex and bison outputs
410 * Makefile.in: get BISON definition right.
414 * sanity.sh: default TMPDIR to ".".
418 * binutils.texi: add doc for ar command language.
422 * arparse.y: make END call ar_end
423 * arsup.c (ar_end): added, deletes temp file if archive session
429 * Makefile.in: use bison & flex from ../ if they exist. Also,
432 * sanity.sh: remove temporary directory when finished.
436 * Makefile.in: Bump to version 1.97.
437 * ar.c: Declare errno for machines that need it.
441 * objdump.c (display_info): Handle error cases without coredump.
442 Close the dummy temporary file we open in the loop.
443 * Makefile.in (arsup.o): Add kludge to build with Sun Make.
447 * Makefile.in: added test-install target.
449 * sanity.sh: new file.
451 * Makefile.in: use sanity test on make check.
455 * Makefile.in: rework CFLAGS so that they can be passed on the
456 command line to make. Remove MINUS_G. Default CFLAGS to -g.
460 * arsup.c, arsup.h, arparse.y, arlex.l: support for archive
465 * Makefile.in: added check target.
469 * Makefile.in: added clean-info target.
473 * Makefile.in: remove $(COPY_PROG) from PROGS. It shouldn't be
474 installed. added tooldir and program_prefix.
478 * Makefile.in, configure.in: removed traces of namesubdir,
479 -subdirs, $(subdir), $(unsubdir), some rcs triggers. Forced
480 copyrights to '92, changed some from Cygnus to FSF.
482 Sun Feb 16 12:53:02 1992 Per Bothner (bothner at cygnus.com)
484 * Makefile.in: Bump version to 1.96, and remove -beta
485 suffix from distribution name.
486 * m68k-pinsn.c: New macro COERCE_SIGNED_CHAR to extract
487 the signed value of a character (even if chars are unsigned).
488 * sparc-pinsn.c: Add new operand types.
490 Thu Feb 6 12:14:19 1992 Steve Chamberlain (sac at rtl.cygnus.com)
492 * objdump.c (disassemble_data): don't print a section's contents
493 if it's not loadable (eg bss)
495 Tue Jan 28 11:11:06 1992 Steve Chamberlain (sac at rtl.cygnus.com)
497 * m68k-pinsn.c (print_insn_arg): fixed so that -ve branch
498 displacements don't get printed as large +ve ones.
500 Fri Jan 24 14:47:53 1992 Steve Chamberlain (sac at rtl.cygnus.com)
502 * copy.c, nm.c, objdump.c, size.c : changed to use the
506 Mon Dec 30 18:34:41 1991 Per Bothner (bothner at cygnus.com)
508 * bucomm.c (print_arelt_descr): Tweek the output format
509 so that 'ar tv' output follows Posix 1003.2/D11.
510 Output is now also identical to Sun's (except __.SYMDEF).
512 Mon Dec 30 06:09:53 1991 John Gilmore (gnu at cygnus.com)
514 * Makefile.in: Make `make' output more readable.
516 Wed Dec 18 15:04:45 1991 Per Bothner (bothner at cygnus.com)
518 * Makefile.in: Bump to version 1.94.
520 Wed Dec 11 16:48:09 1991 Steve Chamberlain (sac at cygnus.com)
522 * ar.c: added "b" to fopens for dos
523 * configdj.bat, makefile.dos new files from DJ
525 Tue Dec 10 04:07:26 1991 K. Richard Pixley (rich at rtl.cygnus.com)
527 * Makefile.in: infodir belongs in datadir.
529 Sat Dec 7 17:09:37 1991 Steve Chamberlain (sac at rtl.cygnus.com)
531 * bucomm.h: created to hold prototypes of bucomm.c
532 * objdump.h: created to hold prototyes of objdump.c
533 * am29k-pinsn.c: include objdump.h
534 * ar.c: include bucomm.h, get ar.h from the right place and
536 * bucomm.c: defunize bfd_fatal
537 * copy.c: include bucomm.h, lint.
538 * i960-pinsn.h: include bucomm.h
540 * nm.c: include bucomm.h, lint
542 * sparc-pinsn.c: include objdump.h
546 Fri Dec 6 23:02:14 1991 K. Richard Pixley (rich at rtl.cygnus.com)
548 * Makefile.in: added standards.text support. install using
549 INSTALL_PROGRAM and INSTALL_DATA.
551 * configure.in: configure now does all of it's work from objdir so
552 make file existence tests against ${srcdir}.
554 Thu Dec 5 22:46:22 1991 K. Richard Pixley (rich at rtl.cygnus.com)
556 * Makefile.in: idestdir and ddestdir go away. Added copyrights
557 and shift gpl to v2. Added ChangeLog if it didn't exist. docdir
558 and mandir now keyed off datadir by default.
560 Wed Dec 4 22:42:03 1991 Per Bothner (bothner at cygnus.com)
562 * Makefile.in: Bump to version 1.93.
563 * Makefile.in: Add make-strip.o:maybe-strip.c dependency
564 for make versions that provide half-baked VPATH-support (e.g. Sun's).
565 * size.c: Improvements suggested by
567 - Don't emit (Berkeley) headers if no files were found.
568 - Return a non-zero return code on failure.
570 Sat Nov 30 21:34:19 1991 Steve Chamberlain (sac at rtl.cygnus.com)
572 Changes due to include file renaming:
573 * am29k-pinsn.c: a29k-opcode.h -> opcode/a29k.h
574 * sparc-pinsn.c: sparc-opcode.h -> opcode/sparc.h
575 * m68k-pinsn.c: m68k-opcode.h -> opcode/m68k.h
576 * nm.c: stab.gnu.h -> aout/stab_gnu.h
578 Tue Nov 19 19:20:43 1991 Per Bothner (bothner at cygnus.com)
580 * README: Mention MINIMIZE flag for bfd's make.
582 Mon Nov 18 12:05:37 1991 Per Bothner (bothner at cygnus.com)
584 * README: Various improvements.
586 Sun Nov 17 23:40:59 1991 Per Bothner (bothner at cygnus.com)
588 * Makefile.in: Bump to version 1.92.
589 * version.c, Makefile.in: Get version string from Makefile.
590 * copy.c, is-strip.c, not-strip.c, maybe-strip.c, Makefile.in:
591 Make the same change that we earlier did for ar/ranlib:
592 Generate two different binaries for strip and copy and use
593 a global variable with different values to distinguish
594 ostrip from copy. (-1 means to use argv[0] to decide,
595 so you can get the old behavior, but it is no longer the default).
596 * copy.c (copy_file): Set EXEC_P of output bfd if input is so.
597 * copy.c (main): If is_strip==-1, compare last 5 chars
598 of argv[0], not the whole path.
599 * copy.c (main): Return 0, not 1.
600 * copy.c (setup_sections): Fix due to change in bfd_make_section
601 now failing if asked for a duplicate section.
602 * strip.c, ostrip.c: Removed obsolete files.
603 * ar.c, not-ranlib.c, maybe-ranlib.c:
604 Change encoding of is_ranlib variable to be consistent
605 with is_strip for strip.copy (i.e -1 to means use argv[0]).
607 Thu Nov 14 20:11:02 1991 Per Bothner (bothner at cygnus.com)
609 * version.c (program_version): Update to version 1.92.
611 Tue Nov 12 16:17:53 1991 Per Bothner (bothner at cygnus.com)
613 * ar.c (get_pos_bfd): Previous fix was missing a "break".
615 Thu Nov 7 08:55:56 1991 Steve Chamberlain (sac at cygnus.com)
617 * am29k-pinsn.c: Fixed bug in mtacc, dmac and fmac instruction
618 encodings. (Thaks to David Wood)
620 Sun Nov 3 14:50:23 1991 Per Bothner (bothner at cygnus.com)
622 * Makefile.in ($(DIST_NAME).tar.Z), TODO: Various fixes.
623 * ar.c (get_pos_bfd): Fix to handling of before/after
625 * bucomm.c (fatal): MISSING_VFPRINTF is no longer an issue,
626 since libiberty contains vfprintf etc if otherwise missing.
627 * m68k-pinsn.c (print_insn_arg): Support BB/BW/BL
628 type operands, as used by branch instructions.
629 * nm.c: Delegate printing of symbols to BFD,
630 by using bfd_print_symbol to do the formatting.
632 Mon Oct 28 11:20:47 1991 Steve Chamberlain (steve at cygnus.com)
634 * ar.c (write_archive.c): added unlink before rename since some
635 systems can't rename onto an existant file.
637 Mon Oct 21 09:47:23 1991 Steve Chamberlain (steve at rtl.cygnus.com)
639 * nm.c: now doesn't crash if a symbol with no section and no
642 Thu Oct 17 15:25:50 1991 Per Bothner (bothner at cygnus.com)
644 * Makefile.in, version.c: Bump to version 1.91.
646 Wed Oct 16 11:45:36 1991 Per Bothner (bothner at cygnus.com)
648 * Makefile.in, ar.c, bucomm.c, copy.c, cplus-dem.c, filemode.c,
649 i960-pinsn.c, m68k-pinsn.c, nm.c, objdump.c, size.c, sparc-pinsn.c,
650 * strip.c: Add or update Copyright notice.
651 * TODO: Add note on 'nm -a'.
652 * version.c: Update version number to 1.90.
653 * Makefile.in: Fix making of documentation for dist.
655 Tue Oct 15 00:17:17 1991 Per Bothner (bothner at cygnus.com)
658 * Makefile.in: New kludgy rules for making a tarfile.
659 * Makefile.in: Fix bindir path.
661 Mon Oct 14 17:34:29 1991 Roland H. Pesch (pesch at cygnus.com)
663 * Makefile.in: add targets binutils.mm, binutils.me
665 Fri Oct 11 22:44:21 1991 John Gilmore (gnu at cygnus.com)
667 * Makefile.in: Avoid Sun Make VPATH bugs by adding dependencies.
669 Fri Oct 11 12:51:33 1991 Roland H. Pesch (pesch at cygnus.com)
671 * Makefile.in: add target "binutils.ms"
673 * binutils.texinfo: minor restructuring for texi2roff comfort.
675 Fri Oct 11 04:12:28 1991 John Gilmore (gnu at cygnus.com)
677 Restructure configuration scheme for bfd, binutils, ld.
679 * include/sys/h-*.h: Move to bfd/hosts/h-*.h.
680 * configure.in: Revise to symlink sysdep.h to ../bfd/hosts/h-xxx.h.
681 Change some config names to match other dirs.
682 * *.c: Include bfd.h before sysdep.h, so ansidecl and PROTO()
684 * Makefile.in: Use -I. to get sysdep.h.
686 Wed Oct 9 22:42:56 1991 Per Bothner (bothner at cygnus.com)
688 * nm.c (print_symbols): Handle NULL name field of symbol.
689 * Makefile.in: Removed spurious comment.
691 Tue Oct 8 16:55:03 1991 Roland H. Pesch (pesch at cygnus.com)
693 * binutils.texinfo: minor typos, phrasing, formatting fixes.
695 Tue Oct 8 15:13:20 1991 Per Bothner (bothner at cygnus.com)
697 * configure.in: Get host file from ../bfd/config, not config.
698 * config/*: Remove config directory and its files.
700 Tue Oct 8 13:58:59 1991 Roland H. Pesch (pesch at cygnus.com)
702 * Makefile.in: new targets binutils.dvi, binutils.info
704 * binutils.texinfo: remove most remaining FIXME's, delete
705 references to __.SYMDEF by name
708 Tue Oct 8 10:23:44 1991 Steve Chamberlain (steve at cygnus.com)
710 * objdump.c (print_address) Print addresses nicely.
712 Mon Oct 7 11:31:05 1991 Per Bothner (bothner at cygnus.com)
714 * ar.c, Makefile.in, new files {is,not,maybe}-ranlib.c:
715 Make two different binaries for ar and ranlib, instead of
716 distinguishing them at run time using argv[0].
717 (Old behavior is still available if you "make ar_with_ranlib",
718 but it is not the default.)
719 * ranlib.sh (new): An alternative one-line
720 shell implementation of ranlib.
722 Fri Oct 4 21:49:44 1991 John Gilmore (gnu at cygnus.com)
724 * objdump.c: Cope with renames of a few BFD types & enums.
726 Fri Oct 4 19:08:09 1991 Roland H. Pesch (pesch at cygnus.com)
728 * binutils.texinfo: add new file (rudimentary docn)
730 Mon Sep 30 12:30:39 1991 Per Bothner (bothner at cygnus.com)
732 * config/hmake-news: Add new file (for Sony NEWSOS3).
733 * bucomm.c (fatal): Conditionally compile fatal() depending on
734 MISSING_VFPRINTF, and don't confuse the issue with NO_VARARGS.
735 * objdump.c (dump_headers): Trivial output format change.
736 * objdump.c (display_info): Loop over integers, not enums,
737 to appease old compilers.
739 Mon May 20 16:14:07 1991 Steve Chamberlain (steve at cygint.cygnus.com)
741 *objdump.c *nm.c *copy.c :hanged some types to work with 64 bit object files
743 Thu May 16 16:06:55 1991 Steve Chamberlain (steve at cygint.cygnus.com)
745 * objdump.c (print_address): Make disasembled output more
746 consistent with gdb and as: Add 0x when printing hex.
747 Don't print extra leading zeros.
748 Attempt to not print "filename.o".
749 * objdump.c: Add some enum-to-int casts to accomodate old compilers.
752 Fri May 3 22:21:44 1991 John Gilmore (gnu at cygint.cygnus.com)
754 * copy.c: Change =& constructs to = &, since they confuse older