]> Git Repo - J-u-boot.git/commitdiff
lmb: notify when adjacent regions are added
authorCaleb Connolly <[email protected]>
Fri, 18 Oct 2024 13:51:07 +0000 (15:51 +0200)
committerTom Rini <[email protected]>
Fri, 18 Oct 2024 20:16:10 +0000 (14:16 -0600)
lmb_add_region() returns a positive integer if the added regions causes
existing regions to be coalesced. We still want to notify the EFI
subsystem about these added regions though, so adjust lmb_add() to only
bail on errors.

This fixes EFI memory allocation on boards with adjacent memory banks as is the
case on several Qualcomm boards like the RB3 Gen 2.

Fixes: 2f6191526a13 (lmb: notify of any changes to the LMB memory map)
Signed-off-by: Caleb Connolly <[email protected]>
Reviewed-by: Sughosh Ganu <[email protected]>
Tested-by: Neil Armstrong <[email protected]>
Reviewed-by: Ilias Apalodimas <[email protected]>
lib/lmb.c

index 78fe2d4de7c61b3d9af9a3313028ff1d466827d7..7e90f178763b8cc1b44170f4578f82604118cfcd 100644 (file)
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -487,7 +487,7 @@ long lmb_add(phys_addr_t base, phys_size_t size)
        struct alist *lmb_rgn_lst = &lmb.free_mem;
 
        ret = lmb_add_region(lmb_rgn_lst, base, size);
-       if (ret)
+       if (ret < 0)
                return ret;
 
        if (lmb_should_notify(LMB_NONE))
This page took 0.027779 seconds and 4 git commands to generate.