pinctrl: single: fix a never true comparison

As reported by Coverity Scan for Das U-Boot, the 'less-than-zero'
comparison of an unsigned value is never true.

Signed-off-by: Dario Binacchi <[email protected]>
Reviewed-by: Pratyush Yadav <[email protected]>

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 17f3818dd11eb9c011f2fca2fc3df2f702a2eef5..ebb7602dde80b13300838f7a2c4a33715507a2b9 100644 (file)
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -295,7 +295,7 @@ static int single_configure_pins(struct udevice *dev,
        func->npins = 0;
        for (n = 0; n < count; n++, pins++) {
                offset = fdt32_to_cpu(pins->reg);
-               if (offset < 0 || offset > pdata->offset) {
+               if (offset > pdata->offset) {
                        dev_err(dev, "  invalid register offset 0x%x\n",
                                offset);
                        continue;
@@ -348,7 +348,7 @@ static int single_configure_bits(struct udevice *dev,
        func->npins = 0;
        for (n = 0; n < count; n++, pins++) {
                offset = fdt32_to_cpu(pins->reg);
-               if (offset < 0 || offset > pdata->offset) {
+               if (offset > pdata->offset) {
                        dev_dbg(dev, "  invalid register offset 0x%x\n",
                                offset);
                        continue;