dm: gpio: Return error when pull up/down is requested but set_flags ops is not implme...

Currently in _dm_gpio_set_flags() when set_flags ops is not implemented
direction_output()/_input() is used, but pull up/down is not supported by
these ops.

Signed-off-by: Zixun LI <[email protected]>

diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c
index 0213271e3a69d7d6b39837f9dca902149368672a..da929c33447b918493127fe74791e4e064a299e1 100644 (file)
--- a/drivers/gpio/gpio-uclass.c
+++ b/drivers/gpio/gpio-uclass.c
@@ -705,6 +705,9 @@ static int _dm_gpio_set_flags(struct gpio_desc *desc, ulong flags)
        if (ops->set_flags) {
                ret = ops->set_flags(dev, desc->offset, flags);
        } else {
+               if (flags & GPIOD_MASK_PULL)
+                       return -EINVAL;
+
                if (flags & GPIOD_IS_OUT) {
                        bool value = flags & GPIOD_IS_OUT_ACTIVE;