exfat: fix the infinite loop in exfat_readdir()

If the file system is corrupted so that a cluster is linked to
itself in the cluster chain, and there is an unused directory
entry in the cluster, 'dentry' will not be incremented, causing
condition 'dentry < max_dentries' unable to prevent an infinite
loop.

This infinite loop causes s_lock not to be released, and other
tasks will hang, such as exfat_sync_fs().

This commit stops traversing the cluster chain when there is unused
directory entry in the cluster to avoid this infinite loop.

Reported-by: [email protected]
Closes: https://syzkaller.appspot.com/bug?extid=205c2644abdff9d3f9fc
Tested-by: [email protected]
Fixes: ca06197382bd ("exfat: add directory operations")
Signed-off-by: Yuezhang Mo <[email protected]>
Reviewed-by: Sungjong Seo <[email protected]>
Signed-off-by: Namjae Jeon <[email protected]>

diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c
index fe0a9b8a0cd079f5bf76eb9c5cc814ec43a17216..3103b932b674619adc168cf26f24d3e1f7a3b8ff 100644 (file)
--- a/fs/exfat/dir.c
+++ b/fs/exfat/dir.c
@@ -122,7 +122,7 @@ static int exfat_readdir(struct inode *inode, loff_t *cpos, struct exfat_dir_ent
                        type = exfat_get_entry_type(ep);
                        if (type == TYPE_UNUSED) {
                                brelse(bh);
-                               break;
+                               goto out;
                        }
 
                        if (type != TYPE_FILE && type != TYPE_DIR) {
@@ -170,6 +170,7 @@ static int exfat_readdir(struct inode *inode, loff_t *cpos, struct exfat_dir_ent
                }
        }
 
+out:
        dir_entry->namebuf.lfn[0] = '\0';
        *cpos = EXFAT_DEN_TO_B(dentry);
        return 0;