]> Git Repo - J-linux.git/commitdiff
landlock: Rename "ptrace" files to "task"
authorMickaël Salaün <[email protected]>
Thu, 7 Mar 2024 09:39:23 +0000 (10:39 +0100)
committerMickaël Salaün <[email protected]>
Fri, 8 Mar 2024 17:22:16 +0000 (18:22 +0100)
ptrace.[ch] are currently only used for the ptrace LSM hooks but their
scope will expand with IPCs and audit support.  Rename ptrace.[ch] to
task.[ch], which better reflect their content.  Similarly, rename
landlock_add_ptrace_hooks() to landlock_add_task_hooks().  Keep header
files for now.

Cc: Günther Noack <[email protected]>
Cc: Paul Moore <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mickaël Salaün <[email protected]>
security/landlock/Makefile
security/landlock/ptrace.c [deleted file]
security/landlock/ptrace.h [deleted file]
security/landlock/setup.c
security/landlock/task.c [new file with mode: 0644]
security/landlock/task.h [new file with mode: 0644]

index c2e116f2a299b9ed2ca9390529b1b47cd71bdf89..b4538b7cf7d2415106111464a94b50e1f28d1b11 100644 (file)
@@ -1,6 +1,6 @@
 obj-$(CONFIG_SECURITY_LANDLOCK) := landlock.o
 
 landlock-y := setup.o syscalls.o object.o ruleset.o \
-       cred.o ptrace.o fs.o
+       cred.o task.o fs.o
 
 landlock-$(CONFIG_INET) += net.o
diff --git a/security/landlock/ptrace.c b/security/landlock/ptrace.c
deleted file mode 100644 (file)
index 2bfc533..0000000
+++ /dev/null
@@ -1,120 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Landlock LSM - Ptrace hooks
- *
- * Copyright © 2017-2020 Mickaël Salaün <[email protected]>
- * Copyright © 2019-2020 ANSSI
- */
-
-#include <asm/current.h>
-#include <linux/cred.h>
-#include <linux/errno.h>
-#include <linux/kernel.h>
-#include <linux/lsm_hooks.h>
-#include <linux/rcupdate.h>
-#include <linux/sched.h>
-
-#include "common.h"
-#include "cred.h"
-#include "ptrace.h"
-#include "ruleset.h"
-#include "setup.h"
-
-/**
- * domain_scope_le - Checks domain ordering for scoped ptrace
- *
- * @parent: Parent domain.
- * @child: Potential child of @parent.
- *
- * Checks if the @parent domain is less or equal to (i.e. an ancestor, which
- * means a subset of) the @child domain.
- */
-static bool domain_scope_le(const struct landlock_ruleset *const parent,
-                           const struct landlock_ruleset *const child)
-{
-       const struct landlock_hierarchy *walker;
-
-       if (!parent)
-               return true;
-       if (!child)
-               return false;
-       for (walker = child->hierarchy; walker; walker = walker->parent) {
-               if (walker == parent->hierarchy)
-                       /* @parent is in the scoped hierarchy of @child. */
-                       return true;
-       }
-       /* There is no relationship between @parent and @child. */
-       return false;
-}
-
-static bool task_is_scoped(const struct task_struct *const parent,
-                          const struct task_struct *const child)
-{
-       bool is_scoped;
-       const struct landlock_ruleset *dom_parent, *dom_child;
-
-       rcu_read_lock();
-       dom_parent = landlock_get_task_domain(parent);
-       dom_child = landlock_get_task_domain(child);
-       is_scoped = domain_scope_le(dom_parent, dom_child);
-       rcu_read_unlock();
-       return is_scoped;
-}
-
-static int task_ptrace(const struct task_struct *const parent,
-                      const struct task_struct *const child)
-{
-       /* Quick return for non-landlocked tasks. */
-       if (!landlocked(parent))
-               return 0;
-       if (task_is_scoped(parent, child))
-               return 0;
-       return -EPERM;
-}
-
-/**
- * hook_ptrace_access_check - Determines whether the current process may access
- *                           another
- *
- * @child: Process to be accessed.
- * @mode: Mode of attachment.
- *
- * If the current task has Landlock rules, then the child must have at least
- * the same rules.  Else denied.
- *
- * Determines whether a process may access another, returning 0 if permission
- * granted, -errno if denied.
- */
-static int hook_ptrace_access_check(struct task_struct *const child,
-                                   const unsigned int mode)
-{
-       return task_ptrace(current, child);
-}
-
-/**
- * hook_ptrace_traceme - Determines whether another process may trace the
- *                      current one
- *
- * @parent: Task proposed to be the tracer.
- *
- * If the parent has Landlock rules, then the current task must have the same
- * or more rules.  Else denied.
- *
- * Determines whether the nominated task is permitted to trace the current
- * process, returning 0 if permission is granted, -errno if denied.
- */
-static int hook_ptrace_traceme(struct task_struct *const parent)
-{
-       return task_ptrace(parent, current);
-}
-
-static struct security_hook_list landlock_hooks[] __ro_after_init = {
-       LSM_HOOK_INIT(ptrace_access_check, hook_ptrace_access_check),
-       LSM_HOOK_INIT(ptrace_traceme, hook_ptrace_traceme),
-};
-
-__init void landlock_add_ptrace_hooks(void)
-{
-       security_add_hooks(landlock_hooks, ARRAY_SIZE(landlock_hooks),
-                          &landlock_lsmid);
-}
diff --git a/security/landlock/ptrace.h b/security/landlock/ptrace.h
deleted file mode 100644 (file)
index 265b220..0000000
+++ /dev/null
@@ -1,14 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Landlock LSM - Ptrace hooks
- *
- * Copyright © 2017-2019 Mickaël Salaün <[email protected]>
- * Copyright © 2019 ANSSI
- */
-
-#ifndef _SECURITY_LANDLOCK_PTRACE_H
-#define _SECURITY_LANDLOCK_PTRACE_H
-
-__init void landlock_add_ptrace_hooks(void);
-
-#endif /* _SECURITY_LANDLOCK_PTRACE_H */
index f6dd33143b7fc58769eab4534fc9a8e225bcba78..28519a45b11ffb9c0674bf7c212999847c74d0fa 100644 (file)
@@ -14,8 +14,8 @@
 #include "cred.h"
 #include "fs.h"
 #include "net.h"
-#include "ptrace.h"
 #include "setup.h"
+#include "task.h"
 
 bool landlock_initialized __ro_after_init = false;
 
@@ -34,7 +34,7 @@ const struct lsm_id landlock_lsmid = {
 static int __init landlock_init(void)
 {
        landlock_add_cred_hooks();
-       landlock_add_ptrace_hooks();
+       landlock_add_task_hooks();
        landlock_add_fs_hooks();
        landlock_add_net_hooks();
        landlock_initialized = true;
diff --git a/security/landlock/task.c b/security/landlock/task.c
new file mode 100644 (file)
index 0000000..849f512
--- /dev/null
@@ -0,0 +1,120 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Landlock LSM - Ptrace hooks
+ *
+ * Copyright © 2017-2020 Mickaël Salaün <[email protected]>
+ * Copyright © 2019-2020 ANSSI
+ */
+
+#include <asm/current.h>
+#include <linux/cred.h>
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#include <linux/lsm_hooks.h>
+#include <linux/rcupdate.h>
+#include <linux/sched.h>
+
+#include "common.h"
+#include "cred.h"
+#include "ruleset.h"
+#include "setup.h"
+#include "task.h"
+
+/**
+ * domain_scope_le - Checks domain ordering for scoped ptrace
+ *
+ * @parent: Parent domain.
+ * @child: Potential child of @parent.
+ *
+ * Checks if the @parent domain is less or equal to (i.e. an ancestor, which
+ * means a subset of) the @child domain.
+ */
+static bool domain_scope_le(const struct landlock_ruleset *const parent,
+                           const struct landlock_ruleset *const child)
+{
+       const struct landlock_hierarchy *walker;
+
+       if (!parent)
+               return true;
+       if (!child)
+               return false;
+       for (walker = child->hierarchy; walker; walker = walker->parent) {
+               if (walker == parent->hierarchy)
+                       /* @parent is in the scoped hierarchy of @child. */
+                       return true;
+       }
+       /* There is no relationship between @parent and @child. */
+       return false;
+}
+
+static bool task_is_scoped(const struct task_struct *const parent,
+                          const struct task_struct *const child)
+{
+       bool is_scoped;
+       const struct landlock_ruleset *dom_parent, *dom_child;
+
+       rcu_read_lock();
+       dom_parent = landlock_get_task_domain(parent);
+       dom_child = landlock_get_task_domain(child);
+       is_scoped = domain_scope_le(dom_parent, dom_child);
+       rcu_read_unlock();
+       return is_scoped;
+}
+
+static int task_ptrace(const struct task_struct *const parent,
+                      const struct task_struct *const child)
+{
+       /* Quick return for non-landlocked tasks. */
+       if (!landlocked(parent))
+               return 0;
+       if (task_is_scoped(parent, child))
+               return 0;
+       return -EPERM;
+}
+
+/**
+ * hook_ptrace_access_check - Determines whether the current process may access
+ *                           another
+ *
+ * @child: Process to be accessed.
+ * @mode: Mode of attachment.
+ *
+ * If the current task has Landlock rules, then the child must have at least
+ * the same rules.  Else denied.
+ *
+ * Determines whether a process may access another, returning 0 if permission
+ * granted, -errno if denied.
+ */
+static int hook_ptrace_access_check(struct task_struct *const child,
+                                   const unsigned int mode)
+{
+       return task_ptrace(current, child);
+}
+
+/**
+ * hook_ptrace_traceme - Determines whether another process may trace the
+ *                      current one
+ *
+ * @parent: Task proposed to be the tracer.
+ *
+ * If the parent has Landlock rules, then the current task must have the same
+ * or more rules.  Else denied.
+ *
+ * Determines whether the nominated task is permitted to trace the current
+ * process, returning 0 if permission is granted, -errno if denied.
+ */
+static int hook_ptrace_traceme(struct task_struct *const parent)
+{
+       return task_ptrace(parent, current);
+}
+
+static struct security_hook_list landlock_hooks[] __ro_after_init = {
+       LSM_HOOK_INIT(ptrace_access_check, hook_ptrace_access_check),
+       LSM_HOOK_INIT(ptrace_traceme, hook_ptrace_traceme),
+};
+
+__init void landlock_add_task_hooks(void)
+{
+       security_add_hooks(landlock_hooks, ARRAY_SIZE(landlock_hooks),
+                          &landlock_lsmid);
+}
diff --git a/security/landlock/task.h b/security/landlock/task.h
new file mode 100644 (file)
index 0000000..7c00360
--- /dev/null
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Landlock LSM - Ptrace hooks
+ *
+ * Copyright © 2017-2019 Mickaël Salaün <[email protected]>
+ * Copyright © 2019 ANSSI
+ */
+
+#ifndef _SECURITY_LANDLOCK_TASK_H
+#define _SECURITY_LANDLOCK_TASK_H
+
+__init void landlock_add_task_hooks(void);
+
+#endif /* _SECURITY_LANDLOCK_TASK_H */
This page took 0.068832 seconds and 4 git commands to generate.