s390/raw3270: improve raw3270_init() readability

Instead of checking if rc is 0, check whether it is non-zero and return
early if so. The call to class_create() can fail, so add a check to it and
move it out of the mutex region.

Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: "Ricardo B. Marliere" <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Heiko Carstens <[email protected]>

diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index 7a5bda26edbd6c7914f0052c679690d14860dbfb..899e86e5a68916cffa556a357ad78a7d0aaba071 100644 (file)
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -1316,17 +1316,19 @@ static int raw3270_init(void)
                return 0;
        raw3270_registered = 1;
        rc = ccw_driver_register(&raw3270_ccw_driver);
-       if (rc == 0) {
-               /* Create attributes for early (= console) device. */
-               mutex_lock(&raw3270_mutex);
-               class3270 = class_create("3270");
-               list_for_each_entry(rp, &raw3270_devices, list) {
-                       get_device(&rp->cdev->dev);
-                       raw3270_create_attributes(rp);
-               }
-               mutex_unlock(&raw3270_mutex);
+       if (rc)
+               return rc;
+       class3270 = class_create("3270");
+       if (IS_ERR(class3270))
+               return PTR_ERR(class3270);
+       /* Create attributes for early (= console) device. */
+       mutex_lock(&raw3270_mutex);
+       list_for_each_entry(rp, &raw3270_devices, list) {
+               get_device(&rp->cdev->dev);
+               raw3270_create_attributes(rp);
        }
-       return rc;
+       mutex_unlock(&raw3270_mutex);
+       return 0;
 }
 
 static void raw3270_exit(void)