sfc: use flow_rule_is_supp_control_flags()

Change the check for unsupported control flags, to use the new helper
flow_rule_is_supp_control_flags().

Since the helper was based on sfc, then nothing really changes.

Compile-tested, and compiled objects are identical.

Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]>
Reviewed-by: Edward Cree <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>

diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index 82e8891a619a201c310a36bf69b6e4a94b2323fc..9d140203e273ad6a6a4f62f2f508a0629ed72811 100644 (file)
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -273,11 +273,10 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
                        match->value.ip_firstfrag = fm.key->flags & FLOW_DIS_FIRST_FRAG;
                        match->mask.ip_firstfrag = true;
                }
-               if (fm.mask->flags & ~(FLOW_DIS_IS_FRAGMENT | FLOW_DIS_FIRST_FRAG)) {
-                       NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on control.flags %#x",
-                                              fm.mask->flags);
+               if (!flow_rule_is_supp_control_flags(FLOW_DIS_IS_FRAGMENT |
+                                                    FLOW_DIS_FIRST_FRAG,
+                                                    fm.mask->flags, extack))
                        return -EOPNOTSUPP;
-               }
        }
        if (dissector->used_keys &
            ~(BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL) |