]> Git Repo - J-linux.git/commitdiff
Input: synaptics-rmi4 - destroy F54 poller workqueue when removing
authorChuhong Yuan <[email protected]>
Fri, 15 Nov 2019 19:32:36 +0000 (11:32 -0800)
committerDmitry Torokhov <[email protected]>
Fri, 15 Nov 2019 19:46:33 +0000 (11:46 -0800)
The driver forgets to destroy workqueue in remove() similarly to what is
done when probe() fails. Add a call to destroy_workqueue() to fix it.

Since unregistration will wait for the work to finish, we do not need to
cancel/flush the work instance in remove().

Signed-off-by: Chuhong Yuan <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>
drivers/input/rmi4/rmi_f54.c

index 484ae1f973304001ea4320196852b61f6066a7ce..897105b9a98b22cdcd32e1b09918c0c4ebe5ea0d 100644 (file)
@@ -730,6 +730,7 @@ static void rmi_f54_remove(struct rmi_function *fn)
 
        video_unregister_device(&f54->vdev);
        v4l2_device_unregister(&f54->v4l2);
+       destroy_workqueue(f54->workqueue);
 }
 
 struct rmi_function_handler rmi_f54_handler = {
This page took 0.055923 seconds and 4 git commands to generate.