pwm: stm32: Fix error checking for a regmap_read() call

Without first assigning ret, it always evaluates to zero because
otherwise this code isn't reached. So assign the return code of
regmap_read() to ret to make the following error path do something.

This issue was spotted by Coverity.

Reported-by: Kees Bakker <[email protected]>
Link: https://lore.kernel.org/linux-pwm/[email protected]
Fixes: deaba9cff809 ("pwm: stm32: Implementation of the waveform callbacks")
Signed-off-by: Uwe Kleine-König <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Uwe Kleine-König <[email protected]>

diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
index d2c1085aee74e9d848f33860619c624c1c6e6df0..b889e64522c3d7b6a6ea5649f2b3ed18faf84500 100644 (file)
--- a/drivers/pwm/pwm-stm32.c
+++ b/drivers/pwm/pwm-stm32.c
@@ -334,7 +334,7 @@ static int stm32_pwm_write_waveform(struct pwm_chip *chip,
                                goto out;
                        }
 
-                       regmap_read(priv->regmap, TIM_ARR, &arr);
+                       ret = regmap_read(priv->regmap, TIM_ARR, &arr);
                        if (ret)
                                goto out;