iommu/sva: Fix memory leak in iommu_sva_bind_device()

Free the handle when the domain allocation fails before unlocking and
returning.

Fixes: 092edaddb660 ("iommu: Support mm PASID 1:n with sva domains")
Signed-off-by: Harshit Mogalapalli <[email protected]>
Reviewed-by: Lu Baolu <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Joerg Roedel <[email protected]>

diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
index 5175e8d85247b2ab69107e0efe115620e54580f8..c3fc9201d0be97e59395750cda0fc29940c0b844 100644 (file)
--- a/drivers/iommu/iommu-sva.c
+++ b/drivers/iommu/iommu-sva.c
@@ -101,7 +101,7 @@ struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct mm_struct *mm
        domain = iommu_sva_domain_alloc(dev, mm);
        if (!domain) {
                ret = -ENOMEM;
-               goto out_unlock;
+               goto out_free_handle;
        }
 
        ret = iommu_attach_device_pasid(domain, dev, iommu_mm->pasid);
@@ -118,6 +118,7 @@ out:
 
 out_free_domain:
        iommu_domain_free(domain);
+out_free_handle:
        kfree(handle);
 out_unlock:
        mutex_unlock(&iommu_sva_lock);