selftests/sgx: Remove incomplete ABI sanitization code in test enclave

As the selftest enclave is *not* intended for production, simplify the
code by not initializing CPU configuration registers as expected by the
ABI on enclave entry or cleansing caller-save registers on enclave exit.

Signed-off-by: Jo Van Bulck <[email protected]>
Signed-off-by: Dave Hansen <[email protected]>
Reviewed-by: Jarkko Sakkinen <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Link: https://lore.kernel.org/all/20231005153854.25566-14-jo.vanbulck%40cs.kuleuven.be

diff --git a/tools/testing/selftests/sgx/test_encl_bootstrap.S b/tools/testing/selftests/sgx/test_encl_bootstrap.S
index 28fe5d2ac0afd95fe66c1e51e407783e86e32e75..d8c4ac94e032c9bef82d827ac37f00323ac0ab6c 100644 (file)
--- a/tools/testing/selftests/sgx/test_encl_bootstrap.S
+++ b/tools/testing/selftests/sgx/test_encl_bootstrap.S
@@ -59,21 +59,11 @@ encl_entry_core:
 
        push    %rcx # push the address after EENTER
 
+       # NOTE: as the selftest enclave is *not* intended for production,
+       # simplify the code by not initializing ABI registers on entry or
+       # cleansing caller-save registers on exit.
        call    encl_body
 
-       /* Clear volatile GPRs, except RAX (EEXIT function). */
-       xor     %rcx, %rcx
-       xor     %rdx, %rdx
-       xor     %rdi, %rdi
-       xor     %rsi, %rsi
-       xor     %r8, %r8
-       xor     %r9, %r9
-       xor     %r10, %r10
-       xor     %r11, %r11
-
-       # Reset status flags.
-       add     %rdx, %rdx # OF = SF = AF = CF = 0; ZF = PF = 1
-
        # Prepare EEXIT target by popping the address of the instruction after
        # EENTER to RBX.
        pop     %rbx