]> Git Repo - J-linux.git/commitdiff
x86/vmware: Correct macro names
authorAlexey Makhalov <[email protected]>
Thu, 13 Jun 2024 19:16:48 +0000 (12:16 -0700)
committerBorislav Petkov (AMD) <[email protected]>
Tue, 25 Jun 2024 15:15:48 +0000 (17:15 +0200)
VCPU_RESERVED and LEGACY_X2APIC are not VMware hypercall commands.  These are
bits in the return value of the VMWARE_CMD_GETVCPU_INFO command.  Change
VMWARE_CMD_ prefix to GETVCPU_INFO_ one. And move the bit-shift
operation into the macro body.

Fixes: 4cca6ea04d31c ("x86/apic: Allow x2apic without IR on VMware platform")
Signed-off-by: Alexey Makhalov <[email protected]>
Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
arch/x86/kernel/cpu/vmware.c

index 24d6fd81cfbc6170426e7870a0ad91062eeb5d05..fc1b3f688d4f802d0c5e1a9e2d28fdca198e9c8d 100644 (file)
@@ -42,8 +42,8 @@
 #define CPUID_VMWARE_INFO_LEAF               0x40000000
 #define CPUID_VMWARE_FEATURES_LEAF           0x40000010
 
-#define VMWARE_CMD_LEGACY_X2APIC  3
-#define VMWARE_CMD_VCPU_RESERVED 31
+#define GETVCPU_INFO_LEGACY_X2APIC           BIT(3)
+#define GETVCPU_INFO_VCPU_RESERVED           BIT(31)
 
 #define STEALCLOCK_NOT_AVAILABLE (-1)
 #define STEALCLOCK_DISABLED        0
@@ -485,8 +485,8 @@ static bool __init vmware_legacy_x2apic_available(void)
        u32 eax;
 
        eax = vmware_hypercall1(VMWARE_CMD_GETVCPU_INFO, 0);
-       return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) &&
-               (eax & BIT(VMWARE_CMD_LEGACY_X2APIC));
+       return !(eax & GETVCPU_INFO_VCPU_RESERVED) &&
+               (eax & GETVCPU_INFO_LEGACY_X2APIC);
 }
 
 #ifdef CONFIG_AMD_MEM_ENCRYPT
This page took 0.050156 seconds and 4 git commands to generate.