ACPI: battery: Check for error code from devm_mutex_init() call

Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something. Add the missed
check.

Fixes: 0710c1ce5045 ("ACPI: battery: initialize mutexes through devm_ APIs")
Signed-off-by: Andy Shevchenko <[email protected]>
Reviewed-by: Thomas Weißschuh <[email protected]>
Link: https://patch.msgid.link/[email protected]
[ rjw: Added 2 empty code lines ]
Signed-off-by: Rafael J. Wysocki <[email protected]>

diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index d4dc4d19a2fd892bdfb1a809efa2b611b68e3717..aed4a37da03ea2221e9a0caae4eaae13da6364f2 100644 (file)
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -1225,8 +1225,14 @@ static int acpi_battery_add(struct acpi_device *device)
        strscpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
        strscpy(acpi_device_class(device), ACPI_BATTERY_CLASS);
        device->driver_data = battery;
-       devm_mutex_init(&device->dev, &battery->lock);
-       devm_mutex_init(&device->dev, &battery->sysfs_lock);
+       result = devm_mutex_init(&device->dev, &battery->lock);
+       if (result)
+               return result;
+
+       result = devm_mutex_init(&device->dev, &battery->sysfs_lock);
+       if (result)
+               return result;
+
        if (acpi_has_method(battery->device->handle, "_BIX"))
                set_bit(ACPI_BATTERY_XINFO_PRESENT, &battery->flags);