fs/affs: release old buffer head on error path

The reference count of the old buffer head should be decremented on path
that fails to get the new buffer head.

Fixes: 6b4657667ba0 ("fs/affs: add rename exchange")
CC: [email protected] # 4.14+
Signed-off-by: Pan Bian <[email protected]>
Signed-off-by: David Sterba <[email protected]>

diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index 41c5749f4db78078b2e1d5b65c31aa0b2c7724c1..5400a876d73fb52006ac97fed12b6d3d312c378e 100644 (file)
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -460,8 +460,10 @@ affs_xrename(struct inode *old_dir, struct dentry *old_dentry,
                return -EIO;
 
        bh_new = affs_bread(sb, d_inode(new_dentry)->i_ino);
-       if (!bh_new)
+       if (!bh_new) {
+               affs_brelse(bh_old);
                return -EIO;
+       }
 
        /* Remove old header from its parent directory. */
        affs_lock_dir(old_dir);