]> Git Repo - J-linux.git/commitdiff
watchdog: lenovo_se10_wdt: add HAS_IOPORT dependency
authorArnd Bergmann <[email protected]>
Tue, 28 May 2024 12:07:31 +0000 (14:07 +0200)
committerWim Van Sebroeck <[email protected]>
Sat, 15 Jun 2024 10:49:57 +0000 (12:49 +0200)
Once the inb()/outb() helpers become conditional, the newly added driver
fails to link on targets without CONFIG_HAS_IOPORT:

In file included from arch/arm64/include/asm/io.h:299,
                 from include/linux/io.h:14,
                 from drivers/watchdog/lenovo_se10_wdt.c:8:
drivers/watchdog/lenovo_se10_wdt.c: In function 'set_bram':
include/asm-generic/io.h:596:15: error: call to '_outb' declared with attribute error: outb() requires CONFIG_HAS_IOPORT
  596 | #define _outb _outb
include/asm-generic/io.h:655:14: note: in expansion of macro '_outb'
  655 | #define outb _outb
      |              ^~~~~
drivers/watchdog/lenovo_se10_wdt.c:67:9: note: in expansion of macro 'outb'
   67 |         outb(offset, bram_base);
      |         ^~~~

Add the same dependency we added to the other such drivers.

Fixes: 1f6602c8ed1e ("watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform")
Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by Mark Pearson <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Guenter Roeck <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>
drivers/watchdog/Kconfig

index 85eea38dbdf4bb7a3cfc74b3dc0f09f822bd41d7..2882944d23ccd5368c51fb0bf3680b70de45a304 100644 (file)
@@ -257,6 +257,7 @@ config GPIO_WATCHDOG_ARCH_INITCALL
 config LENOVO_SE10_WDT
        tristate "Lenovo SE10 Watchdog"
        depends on (X86 && DMI) || COMPILE_TEST
+       depends on HAS_IOPORT
        select WATCHDOG_CORE
        help
          If you say yes here you get support for the watchdog
This page took 0.050297 seconds and 4 git commands to generate.