]> Git Repo - J-linux.git/commitdiff
soundwire: qcom: Fix build failure when slimbus is module
authorVinod Koul <[email protected]>
Wed, 25 Nov 2020 05:51:55 +0000 (11:21 +0530)
committerVinod Koul <[email protected]>
Thu, 26 Nov 2020 04:25:07 +0000 (09:55 +0530)
Commit 5bd773242f75 ("soundwire: qcom: avoid dependency on
CONFIG_SLIMBUS") removed hard dependency on Slimbus for qcom driver but
it results in build failure when: CONFIG_SOUNDWIRE_QCOM=y
CONFIG_SLIMBUS=m

drivers/soundwire/qcom.o: In function `qcom_swrm_probe':
qcom.c:(.text+0xf44): undefined reference to `slimbus_bus'

Fix this by using IS_REACHABLE() in driver which is recommended to be
used with imply.

Fixes: 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS")
Reported-by: kernel test robot <[email protected]>
Tested-by: Srinivas Kandagatla <[email protected]>
Reviewed-by: Srinivas Kandagatla <[email protected]>
Acked-by: Randy Dunlap <[email protected]> # build-tested
Link: https://lore.kernel.org/r/20201125055155.GD8403@vkoul-mobl
Signed-off-by: Vinod Koul <[email protected]>
drivers/soundwire/qcom.c

index fbca4ebf63e9278d22f2ca84ec7c2d1086e01cfa..6d22df01f35471e8a8803c09d6ea074a756e9734 100644 (file)
@@ -799,7 +799,7 @@ static int qcom_swrm_probe(struct platform_device *pdev)
        data = of_device_get_match_data(dev);
        ctrl->rows_index = sdw_find_row_index(data->default_rows);
        ctrl->cols_index = sdw_find_col_index(data->default_cols);
-#if IS_ENABLED(CONFIG_SLIMBUS)
+#if IS_REACHABLE(CONFIG_SLIMBUS)
        if (dev->parent->bus == &slimbus_bus) {
 #else
        if (false) {
This page took 0.05479 seconds and 4 git commands to generate.