]> Git Repo - J-linux.git/commitdiff
ASoC: wm_adsp: Compressed stream DSP memory structs should be __packed
authorSimon Trimmer <[email protected]>
Wed, 9 Mar 2022 13:00:17 +0000 (13:00 +0000)
committerMark Brown <[email protected]>
Wed, 9 Mar 2022 17:50:26 +0000 (17:50 +0000)
The compressed stream code has a bunch of structs that are used to
represent DSP memory but have not been marked __packed. This isn't
safe, they could get padded on a 64-bit build.

Signed-off-by: Simon Trimmer <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Acked-by: Charles Keepax <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
sound/soc/codecs/wm_adsp.c

index 0582585236a28211811347f9e106e7d215b2f6f5..5a57bb04a0aeb3ea5204f0ce26ee91d3f169c93e 100644 (file)
@@ -97,13 +97,13 @@ struct wm_adsp_system_config_xm_hdr {
        __be32 wdma[8];
        __be32 build_job_name[3];
        __be32 build_job_number;
-};
+} __packed;
 
 struct wm_halo_system_config_xm_hdr {
        __be32 halo_heartbeat;
        __be32 build_job_name[3];
        __be32 build_job_number;
-};
+} __packed;
 
 struct wm_adsp_alg_xm_struct {
        __be32 magic;
@@ -114,13 +114,13 @@ struct wm_adsp_alg_xm_struct {
        __be32 high_water_mark;
        __be32 low_water_mark;
        __be64 smoothed_power;
-};
+} __packed;
 
 struct wm_adsp_host_buf_coeff_v1 {
        __be32 host_buf_ptr;            /* Host buffer pointer */
        __be32 versions;                /* Version numbers */
        __be32 name[4];                 /* The buffer name */
-};
+} __packed;
 
 struct wm_adsp_buffer {
        __be32 buf1_base;               /* Base addr of first buffer area */
@@ -141,7 +141,7 @@ struct wm_adsp_buffer {
        __be32 min_free;                /* min free space since stream start */
        __be32 blocks_written[2];       /* total blocks written (64 bit) */
        __be32 words_written[2];        /* total words written (64 bit) */
-};
+} __packed;
 
 struct wm_adsp_compr;
 
This page took 0.059257 seconds and 4 git commands to generate.