firmware: google: Unregister driver_info on failure

When platform_device_register_full() returns error, the gsmi_init() returns
without unregister gsmi_driver_info, fix by add missing
platform_driver_unregister() when platform_device_register_full() failed.

Fixes: 8942b2d5094b ("gsmi: Add GSMI commands to log S0ix info")
Signed-off-by: Yuan Can <[email protected]>
Acked-by: Brian Norris <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Tzung-Bi Shih <[email protected]>

diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index d304913314e494481173c28d3d4441c93c5ad9ed..24e666d5c3d1a231d611ad3c20816c1d223a0dc5 100644 (file)
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -918,7 +918,8 @@ static __init int gsmi_init(void)
        gsmi_dev.pdev = platform_device_register_full(&gsmi_dev_info);
        if (IS_ERR(gsmi_dev.pdev)) {
                printk(KERN_ERR "gsmi: unable to register platform device\n");
-               return PTR_ERR(gsmi_dev.pdev);
+               ret = PTR_ERR(gsmi_dev.pdev);
+               goto out_unregister;
        }
 
        /* SMI access needs to be serialized */
@@ -1056,10 +1057,11 @@ out_err:
        gsmi_buf_free(gsmi_dev.name_buf);
        kmem_cache_destroy(gsmi_dev.mem_pool);
        platform_device_unregister(gsmi_dev.pdev);
-       pr_info("gsmi: failed to load: %d\n", ret);
+out_unregister:
 #ifdef CONFIG_PM
        platform_driver_unregister(&gsmi_driver_info);
 #endif
+       pr_info("gsmi: failed to load: %d\n", ret);
        return ret;
 }