]> Git Repo - J-linux.git/commitdiff
fpga: altera-pr-ip: fix unsigned comparison with less than zero
authorMarco Pagani <[email protected]>
Thu, 9 Jun 2022 14:05:19 +0000 (16:05 +0200)
committerXu Yilun <[email protected]>
Fri, 10 Jun 2022 07:48:23 +0000 (15:48 +0800)
Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter count of the
alt_pr_fpga_write() function.

Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
Reviewed-by: Tom Rix <[email protected]>
Acked-by: Xu Yilun <[email protected]>
Signed-off-by: Marco Pagani <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Xu Yilun <[email protected]>
drivers/fpga/altera-pr-ip-core.c

index be0667968d33b61b5c925a2e16a1b05696630bd8..df8671af4a92a066d621f696c8192b4c4ff2fa9a 100644 (file)
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
        u32 *buffer_32 = (u32 *)buf;
        size_t i = 0;
 
-       if (count <= 0)
+       if (!count)
                return -EINVAL;
 
        /* Write out the complete 32-bit chunks */
This page took 0.040398 seconds and 4 git commands to generate.