]> Git Repo - J-linux.git/commitdiff
selftests/ring-buffer: Verify the entire meta-page padding
authorVincent Donnefort <[email protected]>
Tue, 10 Sep 2024 16:23:34 +0000 (17:23 +0100)
committerSteven Rostedt (Google) <[email protected]>
Wed, 11 Sep 2024 16:25:02 +0000 (12:25 -0400)
Improve the ring-buffer meta-page test coverage by checking for the
entire padding region to be 0 instead of just looking at the first 4
bytes.

Cc: [email protected]
Link: https://lore.kernel.org/[email protected]
Acked-by: Shuah Khan <[email protected]>
Signed-off-by: Vincent Donnefort <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>
tools/testing/selftests/ring-buffer/map_test.c

index 4bb0192e43f3800ff3906ad1b38c2cc536cf79d8..ba12fd31de87e81fa7ba1a7cac05348d12a45062 100644 (file)
@@ -231,15 +231,15 @@ TEST_F(map, data_mmap)
 
        /* Verify meta-page padding */
        if (desc->meta->meta_page_size > getpagesize()) {
-               void *addr;
-
                data_len = desc->meta->meta_page_size;
                data = mmap(NULL, data_len,
                            PROT_READ, MAP_SHARED, desc->cpu_fd, 0);
                ASSERT_NE(data, MAP_FAILED);
 
-               addr = (void *)((unsigned long)data + getpagesize());
-               ASSERT_EQ(*((int *)addr), 0);
+               for (int i = desc->meta->meta_struct_len;
+                    i < desc->meta->meta_page_size; i += sizeof(int))
+                       ASSERT_EQ(*(int *)(data + i), 0);
+
                munmap(data, data_len);
        }
 }
This page took 0.049685 seconds and 4 git commands to generate.