]> Git Repo - J-linux.git/commitdiff
clk: samsung: Don't register clkdev lookup for the fixed rate clocks
authorMarek Szyprowski <[email protected]>
Fri, 10 May 2024 06:59:01 +0000 (08:59 +0200)
committerStephen Boyd <[email protected]>
Tue, 14 May 2024 21:12:11 +0000 (14:12 -0700)
Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
clkdev entries") revealed that clock lookup is registered for all fixed
clocks. The mentioned commit added a check if the registered name is not
too long. This fails for some clocks registered for Exynos542x SoCs family.
This lookup is a left-over from early common clock framework days, not
really needed nowadays, so remove it to avoid further issues.

Signed-off-by: Marek Szyprowski <[email protected]>
Reviewed-by: Sam Protsenko <[email protected]>
Tested-by: Sam Protsenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Stephen Boyd <[email protected]>
drivers/clk/samsung/clk.c

index b6701905f25461934d60173e43756d96ab44ea47..afa5760ed3a11b17cd670c2ce47259dea90e8c32 100644 (file)
@@ -139,7 +139,7 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx,
                unsigned int nr_clk)
 {
        struct clk_hw *clk_hw;
-       unsigned int idx, ret;
+       unsigned int idx;
 
        for (idx = 0; idx < nr_clk; idx++, list++) {
                clk_hw = clk_hw_register_fixed_rate(ctx->dev, list->name,
@@ -151,15 +151,6 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx,
                }
 
                samsung_clk_add_lookup(ctx, clk_hw, list->id);
-
-               /*
-                * Unconditionally add a clock lookup for the fixed rate clocks.
-                * There are not many of these on any of Samsung platforms.
-                */
-               ret = clk_hw_register_clkdev(clk_hw, list->name, NULL);
-               if (ret)
-                       pr_err("%s: failed to register clock lookup for %s",
-                               __func__, list->name);
        }
 }
 
This page took 0.051452 seconds and 4 git commands to generate.