PCI: xgene: Remove unused assignment to variable msi_val

The value assigned to msi_val after the inner loop finishes its run is
never used for anything, and it is also immediately overridden in the
line that follows with the return value from the xgene_msi_int_read()
function.

Since the value of msi_val following the inner loop completion is never
used in any meaningful way the assignment can be removed.

Addresses-Coverity-ID: 1437183 ("Unused value")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Signed-off-by: Lorenzo Pieralisi <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Acked-by: Bjorn Helgaas <[email protected]>

diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index 02271c6d17a1126c358dccc169b65f6cfcb83828..2470782cb01afae6690d6101718672778f500d9a 100644 (file)
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -493,8 +493,8 @@ static int xgene_msi_probe(struct platform_device *pdev)
         */
        for (irq_index = 0; irq_index < NR_HW_IRQS; irq_index++) {
                for (msi_idx = 0; msi_idx < IDX_PER_GROUP; msi_idx++)
-                       msi_val = xgene_msi_ir_read(xgene_msi, irq_index,
-                                                   msi_idx);
+                       xgene_msi_ir_read(xgene_msi, irq_index, msi_idx);
+
                /* Read MSIINTn to confirm */
                msi_val = xgene_msi_int_read(xgene_msi, irq_index);
                if (msi_val) {