mtd: ubi: Fix worker handling

[u-boot.git] / drivers / mtd / ubi / wl.c

diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index 507b09172069f62ac621b0322c551ad3610f3081..0de2a4a5f8d8e6ade8fc2f286d52e3f7e601848e 100644 (file)
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -191,11 +191,7 @@ static void wl_entry_destroy(struct ubi_device *ubi, struct ubi_wl_entry *e)
  * This function returns zero in case of success and a negative error code in
  * case of failure.
  */
-#ifndef __UBOOT__
 static int do_work(struct ubi_device *ubi)
-#else
-int do_work(struct ubi_device *ubi)
-#endif
 {
        int err;
        struct ubi_work *wrk;
@@ -528,6 +524,33 @@ repeat:
        spin_unlock(&ubi->wl_lock);
 }
 
+#ifdef __UBOOT__
+void ubi_do_worker(struct ubi_device *ubi)
+{
+       int err;
+
+       if (list_empty(&ubi->works) || ubi->ro_mode ||
+           !ubi->thread_enabled || ubi_dbg_is_bgt_disabled(ubi))
+               return;
+
+       spin_lock(&ubi->wl_lock);
+       while (!list_empty(&ubi->works)) {
+               /*
+                * call do_work, which executes exactly one work form the queue,
+                * including removeing it from the work queue.
+                */
+               spin_unlock(&ubi->wl_lock);
+               err = do_work(ubi);
+               spin_lock(&ubi->wl_lock);
+               if (err) {
+                       ubi_err(ubi, "%s: work failed with error code %d",
+                               ubi->bgt_name, err);
+               }
+       }
+       spin_unlock(&ubi->wl_lock);
+}
+#endif
+
 /**
  * __schedule_ubi_work - schedule a work.
  * @ubi: UBI device description object
@@ -545,17 +568,6 @@ static void __schedule_ubi_work(struct ubi_device *ubi, struct ubi_work *wrk)
 #ifndef __UBOOT__
        if (ubi->thread_enabled && !ubi_dbg_is_bgt_disabled(ubi))
                wake_up_process(ubi->bgt_thread);
-#else
-       int err;
-       /*
-        * U-Boot special: We have no bgt_thread in U-Boot!
-        * So just call do_work() here directly.
-        */
-       err = do_work(ubi);
-       if (err) {
-               ubi_err(ubi, "%s: work failed with error code %d",
-                       ubi->bgt_name, err);
-       }
 #endif
        spin_unlock(&ubi->wl_lock);
 }
@@ -610,6 +622,10 @@ static int schedule_erase(struct ubi_device *ubi, struct ubi_wl_entry *e,
        wl_wrk->torture = torture;
 
        schedule_ubi_work(ubi, wl_wrk);
+
+#ifdef __UBOOT__
+       ubi_do_worker(ubi);
+#endif
        return 0;
 }
 
@@ -1011,8 +1027,15 @@ static int ensure_wear_leveling(struct ubi_device *ubi, int nested)
        wrk->func = &wear_leveling_worker;
        if (nested)
                __schedule_ubi_work(ubi, wrk);
+#ifndef __UBOOT__
        else
                schedule_ubi_work(ubi, wrk);
+#else
+       else {
+               schedule_ubi_work(ubi, wrk);
+               ubi_do_worker(ubi);
+       }
+#endif
        return err;
 
 out_cancel:
@@ -1528,6 +1551,7 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
                INIT_LIST_HEAD(&ubi->pq[i]);
        ubi->pq_head = 0;
 
+       ubi->free_count = 0;
        list_for_each_entry_safe(aeb, tmp, &ai->erase, u.list) {
                cond_resched();
 
@@ -1546,7 +1570,6 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
                found_pebs++;
        }
 
-       ubi->free_count = 0;
        list_for_each_entry(aeb, &ai->free, u.list) {
                cond_resched();