]> Git Repo - secp256k1.git/commit
Revert "ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign"
authorTim Ruffing <[email protected]>
Tue, 31 Mar 2020 12:28:48 +0000 (14:28 +0200)
committerTim Ruffing <[email protected]>
Tue, 31 Mar 2020 12:58:58 +0000 (14:58 +0200)
commit93d343bfc5323e56f6a60cb41d60b96368cc09c7
treef91dc4cf948b060a49cd51f9d8a7b6fa15520c8c
parent8f78e208ad28eb0d7e099ba58ed6476f87179a77
Revert "ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign"

This reverts commit 25e3cfbf9b52d2f5afa543f967a73aa8850d2038. The reverted
commit was probably based on the assumption that this is about the touched
checks cover the secret nonce k instead of r, which is the x-coord of the public
nonce. A signature with a zero r is invalid by the spec, so we should return 0
to make the caller retry with a different nonce. Overflow is not an issue.

Fixes #720.
src/ecdsa_impl.h
This page took 0.023124 seconds and 4 git commands to generate.