]> Git Repo - secp256k1.git/commit
Merge #754: Fix uninit values passed into cmov
authorTim Ruffing <[email protected]>
Tue, 2 Jun 2020 16:03:42 +0000 (18:03 +0200)
committerTim Ruffing <[email protected]>
Tue, 2 Jun 2020 16:06:44 +0000 (18:06 +0200)
commit5e1c885efb0f400d024efc259eddd6a5ee9cba7b
tree08f1ac7b824147476a1c725a94a30c661593836f
parent05d315affe0acd02591c8db783ce1badb0c37a31
parentf79a7adcf555ccc78b591850ea15c64fbfbca152
Merge #754: Fix uninit values passed into cmov

f79a7adcf555ccc78b591850ea15c64fbfbca152 Add valgrind uninit check to cmovs output (Elichai Turkel)
a39c2b09de304b8f24716b59219ae37c2538c242 Fixed UB(arithmetics on uninit values) in cmovs (Elichai Turkel)

Pull request description:

  This should fix #753.
  Used @peterdettman's solution here for the `ECMULT_CONST_TABLE_GET_GE` https://github.com/bitcoin-core/secp256k1/issues/753#issuecomment-631316091
  and in ecdsa_sign I initialize `s` and `r` to a zero scalar.

  The second commit adds a valgrind check to the cmovs that could've caught this (in ecdsa_sign, not in ecmult_const because there's a scalar clear there under `VERIFY_SETUP`)

ACKs for top commit:
  sipa:
    utACK f79a7adcf555ccc78b591850ea15c64fbfbca152
  jonasnick:
    ACK f79a7adcf555ccc78b591850ea15c64fbfbca152
  real-or-random:
    ACK f79a7adcf555ccc78b591850ea15c64fbfbca152

Tree-SHA512: 6fd7b7c84f392bda733a973f4dcfc12bf1478aac2591e2c87b69e637847d3b063c4243cc8feccaffc3a5824c18183a5e66bd4251c2322abaf63bb6439b38defe
This page took 0.024475 seconds and 4 git commands to generate.