]> Git Repo - secp256k1.git/commit
Merge #533: Make sure we're not using an uninitialized variable in secp256k1_wnaf_con...
authorGregory Maxwell <[email protected]>
Wed, 22 May 2019 04:43:53 +0000 (04:43 +0000)
committerGregory Maxwell <[email protected]>
Wed, 22 May 2019 04:44:29 +0000 (04:44 +0000)
commit5df77a0eda6e902a1aa9c6249cdeaec197b1e0cd
tree75abc353b3855b82eaf14f72b5ce34f1f15bc5db
parent975e51e0d9a540722116156b961e4528366525ab
parent248f0466112c96b9851c662fa829f20d28d16344
Merge #533: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)

248f046 Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...) (practicalswift)

Pull request description:

  Make sure we're not using an uninitialized variable in `secp256k1_wnaf_const(...)`:

  ```
  In file included from src/secp256k1.c:15:0,
                   from src/tests.c:17:
  src/ecmult_const_impl.h: In function ‘secp256k1_wnaf_const’:
  src/ecmult_const_impl.h:117:20: warning: ‘u’ may be used uninitialized in this function [-Wmaybe-uninitialized]
       wnaf[word] = u * global_sign;
                      ^
  ```

  **Note to reviewers:** Perhaps an `assert(…);` is a bit drastic. What would be a more graceful way to handle this? :-)

Tree-SHA512: 536cd7cc5b87a84fbaac578cecbba81b8d82e4672a30a2db9a674b82856132e79b0158a6a88609bc24942ebdbf1fcd2c4399a4c31ab0654b88ace9c0e6f1eaf3
src/ecmult_const_impl.h
This page took 0.025302 seconds and 4 git commands to generate.