From: balrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162>
Date: Sat, 20 Sep 2008 01:15:04 +0000 (+0000)
Subject: Add a comment about masking of CTI interrupt in 16550A UART.
X-Git-Url: https://repo.jachan.dev/qemu.git/commitdiff_plain/c9a33054bf589f1d78315100c645713b04bddc31

Add a comment about masking of CTI interrupt in 16550A UART.


git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5264 c046a42c-6fe2-441c-8c8c-71466251a162
---

diff --git a/hw/serial.c b/hw/serial.c
index 28d99f26cd..2167b79831 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -192,6 +192,9 @@ static void serial_update_irq(SerialState *s)
     if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
         tmp_iir = UART_IIR_RLSI;
     } else if ((s->ier & UART_IER_RDI) && s->timeout_ipending) {
+        /* Note that(s->ier & UART_IER_RDI) can mask this interrupt,
+         * this is not in the specification but is observed on existing
+         * hardware.  */
         tmp_iir = UART_IIR_CTI;
     } else if ((s->ier & UART_IER_RDI) && (s->lsr & UART_LSR_DR)) {
         if (!(s->fcr & UART_FCR_FE)) {