input: virtio: don't send mouse wheel event twice
authorMiika S <miika9764@gmail.com>
Fri, 22 Dec 2017 15:25:31 +0000 (17:25 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 29 Jan 2018 08:30:25 +0000 (09:30 +0100)
On Linux, a mouse event is generated for both down and up when mouse
wheel is used. This caused virtio_input_send() to be called twice each
time the wheel was used.

This commit adds a check for the button down state and only calls
virtio_input_send() when it is true.

Signed-off-by: Miika S <miika9764@gmail.com>
Message-Id: <20171222152531.1849-4-miika9764@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/input/virtio-input-hid.c

index a5917c27547a1f1cf037d6a8a53ccb5132ea138a..be054fd272126eae003efa75ab6b41f6b44f9bfc 100644 (file)
@@ -218,8 +218,10 @@ static void virtio_input_handle_event(DeviceState *dev, QemuConsole *src,
         break;
     case INPUT_EVENT_KIND_BTN:
         btn = evt->u.btn.data;
-        if (vhid->wheel_axis && (btn->button == INPUT_BUTTON_WHEEL_UP ||
-                                 btn->button == INPUT_BUTTON_WHEEL_DOWN)) {
+        if (vhid->wheel_axis &&
+            (btn->button == INPUT_BUTTON_WHEEL_UP ||
+             btn->button == INPUT_BUTTON_WHEEL_DOWN) &&
+            btn->down) {
             event.type  = cpu_to_le16(EV_REL);
             event.code  = cpu_to_le16(REL_WHEEL);
             event.value = cpu_to_le32(btn->button == INPUT_BUTTON_WHEEL_UP
This page took 0.025783 seconds and 4 git commands to generate.