block: use correct filename for error report
authorDunrong Huang <riegamaths@gmail.com>
Tue, 24 Sep 2013 10:14:01 +0000 (18:14 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 2 Oct 2013 09:41:50 +0000 (11:41 +0200)
The content filename point to will be erased by qemu_opts_absorb_qdict()
in raw_open_common() in drv->bdrv_file_open()

So it's better to use bs->filename.

Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c

diff --git a/block.c b/block.c
index 93e113ad7c0e63eed6430777da67fda694479438..e2d9936227d57186068c75f79d48d7e1b7c86a0c 100644 (file)
--- a/block.c
+++ b/block.c
@@ -808,8 +808,8 @@ static int bdrv_open_common(BlockDriverState *bs, BlockDriverState *file,
     if (ret < 0) {
         if (error_is_set(&local_err)) {
             error_propagate(errp, local_err);
-        } else if (filename) {
-            error_setg_errno(errp, -ret, "Could not open '%s'", filename);
+        } else if (bs->filename[0]) {
+            error_setg_errno(errp, -ret, "Could not open '%s'", bs->filename);
         } else {
             error_setg_errno(errp, -ret, "Could not open image");
         }
This page took 0.025717 seconds and 4 git commands to generate.