]> Git Repo - qemu.git/commit - include/hw/i386/pc.h
i386/pc: pc_basic_device_init(): delegate FDC creation request
authorLaszlo Ersek <[email protected]>
Thu, 28 May 2015 20:04:08 +0000 (22:04 +0200)
committerMichael S. Tsirkin <[email protected]>
Sun, 31 May 2015 18:24:06 +0000 (20:24 +0200)
commitfd53c87cf6651b0dfe9f5107cfe77d2f697bd4f6
tree01b03523539d7a5a0b5d98d36a35ef5a740032e7
parentb829c2a98f1f67308eb02fcddb52d8fa67775f18
i386/pc: pc_basic_device_init(): delegate FDC creation request

This patch introduces no observable change, but it allows the callers of
pc_basic_device_init(), ie. pc_init1() and pc_q35_init(), to request (or
not request) the creation of the FDC explicitly.

At the moment both callers pass constant create_fdctrl=true (hence no
observable change).

Assuming a board passes create_fdctrl=false, "floppy" will be NULL on
output, and (beyond the FDC not being created) that NULL will be passed on
to pc_cmos_init(). Luckily, pc_cmos_init() already handles that case.

Cc: Markus Armbruster <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: John Snow <[email protected]>
Cc: "Gabriel L. Somlo" <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Kevin Wolf <[email protected]>
Cc: [email protected]
Signed-off-by: Laszlo Ersek <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
hw/i386/pc.c
hw/i386/pc_piix.c
hw/i386/pc_q35.c
include/hw/i386/pc.h
This page took 0.023048 seconds and 4 git commands to generate.