]> Git Repo - qemu.git/commit - hw/net/vmxnet3.c
pci: Convert msix_init() to Error and fix callers
authorCao jin <[email protected]>
Tue, 17 Jan 2017 06:18:48 +0000 (14:18 +0800)
committerMichael S. Tsirkin <[email protected]>
Wed, 1 Feb 2017 01:37:18 +0000 (03:37 +0200)
commitee640c625e190a0c0e6b8966adc0e4720fb75200
tree1514d71db96b8db6da3029471a100fb16f2f4a00
parent20729dbd0109b9d9065447dba354f10bcf78d0d6
pci: Convert msix_init() to Error and fix callers

msix_init() reports errors with error_report(), which is wrong when
it's used in realize().  The same issue was fixed for msi_init() in
commit 1108b2f. In order to make the API change as small as possible,
leave the return value check to later patch.

For some devices(like e1000e, vmxnet3, nvme) who won't fail because of
msix_init's failure, suppress the error report by passing NULL error
object.

Bonus: add comment for msix_init.

CC: Jiri Pirko <[email protected]>
CC: Gerd Hoffmann <[email protected]>
CC: Dmitry Fleytman <[email protected]>
CC: Jason Wang <[email protected]>
CC: Michael S. Tsirkin <[email protected]>
CC: Hannes Reinecke <[email protected]>
CC: Paolo Bonzini <[email protected]>
CC: Alex Williamson <[email protected]>
CC: Markus Armbruster <[email protected]>
CC: Marcel Apfelbaum <[email protected]>
Signed-off-by: Cao jin <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
12 files changed:
hw/block/nvme.c
hw/misc/ivshmem.c
hw/net/e1000e.c
hw/net/rocker/rocker.c
hw/net/vmxnet3.c
hw/pci-bridge/gen_pcie_root_port.c
hw/pci/msix.c
hw/scsi/megasas.c
hw/usb/hcd-xhci.c
hw/vfio/pci.c
hw/virtio/virtio-pci.c
include/hw/pci/msix.h
This page took 0.03181 seconds and 4 git commands to generate.