]> Git Repo - qemu.git/commit - hw/pci-bridge/i82801b11.c
pci-bridge/i82801b11: clear bridge registers on platform reset
authorLaszlo Ersek <[email protected]>
Wed, 7 Feb 2018 12:10:27 +0000 (13:10 +0100)
committerMichael S. Tsirkin <[email protected]>
Thu, 8 Feb 2018 19:06:41 +0000 (21:06 +0200)
commited247f40db84c8bd4bb7d10948702cd47cc4d5ae
tree3e398ef67300674d241f722a14def4a08042072d
parentaa3c40f6bfae251a483b5c19f5ceb8e11bdbdb18
pci-bridge/i82801b11: clear bridge registers on platform reset

The "i82801b11-bridge" device model is a descendant of "base-pci-bridge"
(TYPE_PCI_BRIDGE). However, unlike other similar devices, such as

- pci-bridge,
- pcie-pci-bridge,
- PCIE Root Port,
- xio3130 switch upstream and downstream ports,
- dec-21154-p2p-bridge,
- pbm-bridge,
- xilinx-pcie-root,

"i82801b11-bridge" does not clear the bridge specific registers at
platform reset.

This is a problem because devices on "i82801b11-bridge" continue to
respond to config space cycles after platform reset, when addressed with
the bus number that was previously programmed into the secondary bus
number register of "i82801b11-bridge". This error breaks OVMF's search for
extra (PXB) root buses, for example.

The device class reset method for "i82801b11-bridge" is currently NULL;
set it directly to pci_bridge_reset(), like the last three bridge models
in the above listing do.

Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Marcel Apfelbaum <[email protected]>
Cc: [email protected]
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1541839
Signed-off-by: Laszlo Ersek <[email protected]>
Reviewed-by: Marcel Apfelbaum <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
hw/pci-bridge/i82801b11.c
This page took 0.027791 seconds and 4 git commands to generate.