]> Git Repo - qemu.git/commit
migration: Assert that migrate_multifd_compression() returns an in-range value
authorPeter Maydell <[email protected]>
Thu, 21 Jul 2022 11:52:06 +0000 (12:52 +0100)
committerDr. David Alan Gilbert <[email protected]>
Tue, 2 Aug 2022 15:46:52 +0000 (16:46 +0100)
commitead34f64f97d11626774a57863ca285a7ddc0d18
tree1436c6f5c9208fb4d2f2c2339bbf76ad71dd289c
parent777f53c75983dd10756f5dbfc8af50fe11da81c1
migration: Assert that migrate_multifd_compression() returns an in-range value

Coverity complains that when we use the return value from
migrate_multifd_compression() as an array index:
  multifd_recv_state->ops = multifd_ops[migrate_multifd_compression()];

that this might overrun the array (which is declared to have size
MULTIFD_COMPRESSION__MAX).  This is because the function return type
is MultiFDCompression, which is an autogenerated enum.  The code
generator includes the "one greater than the maximum possible value"
MULTIFD_COMPRESSION__MAX in the enum, even though this is not
actually a valid value for the enum, and this makes Coverity think
that migrate_multifd_compression() could return that __MAX value and
index off the end of the array.

Suppress the Coverity error by asserting that the value we're going
to return is within range.

Resolves: Coverity CID 14872391487254
Signed-off-by: Peter Maydell <[email protected]>
Message-Id: <20220721115207[email protected]>
Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
migration/migration.c
This page took 0.02741 seconds and 4 git commands to generate.