]> Git Repo - qemu.git/commit
vhost-user: remove VirtQ notifier restore
authorXueming Li <[email protected]>
Mon, 7 Feb 2022 07:19:28 +0000 (15:19 +0800)
committerMichael S. Tsirkin <[email protected]>
Fri, 4 Mar 2022 13:30:52 +0000 (08:30 -0500)
commite867144b73b3c5009266b6df07d5ff44acfb82c3
tree4d06deebce34cf1f22b0476c3fcbb62930fb934d
parent63670bd3fce3d0c033d939d1b2b7a5f6834d0cf3
vhost-user: remove VirtQ notifier restore

Notifier set when vhost-user backend asks qemu to mmap an FD and
offset. When vhost-user backend restart or getting killed, VQ notifier
FD and mmap addresses become invalid. After backend restart, MR contains
the invalid address will be restored and fail on notifier access.

On the other hand, qemu should munmap the notifier, release underlying
hardware resources to enable backend restart and allocate hardware
notifier resources correctly.

Qemu shouldn't reference and use resources of disconnected backend.

This patch removes VQ notifier restore, uses the default vhost-user
notifier to avoid invalid address access.

After backend restart, the backend should ask qemu to install a hardware
notifier if needed.

Fixes: 44866521bd6e ("vhost-user: support registering external host notifiers")
Cc: [email protected]
Signed-off-by: Xueming Li <[email protected]>
Message-Id: <20220207071929[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
hw/virtio/vhost-user.c
include/hw/virtio/vhost-user.h
This page took 0.028062 seconds and 4 git commands to generate.