]> Git Repo - qemu.git/commit - nbd/client.c
nbd: rename read_sync and friends
authorVladimir Sementsov-Ogievskiy <[email protected]>
Fri, 2 Jun 2017 15:01:39 +0000 (18:01 +0300)
committerPaolo Bonzini <[email protected]>
Thu, 15 Jun 2017 09:04:06 +0000 (11:04 +0200)
commitd1fdf257d52822695f5ace6c586e059aa17d4b79
treed5fb4687e70f916512592a286f6d1ebb64e10c1d
parent92229a57bba10d5bbf469221c32a18d4bed642f4
nbd: rename read_sync and friends

Rename
  nbd_wr_syncv -> nbd_rwv
  read_sync -> nbd_read
  read_sync_eof -> nbd_read_eof
  write_sync -> nbd_write
  drop_sync -> nbd_drop

1. nbd_ prefix
   read_sync and write_sync are already shared, so it is good to have a
   namespace prefix. drop_sync will be shared, and read_sync_eof is
   related to read_sync, so let's rename them all.

2. _sync suffix
   _sync is related to the fact that nbd_wr_syncv doesn't return if a
   write to socket returns EAGAIN. The first implementation of
   nbd_wr_syncv (was wr_sync in 7a5ca8648b) just loops while getting
   EAGAIN, the current implementation yields in this case.
   Why we want to get rid of it:
   - it is normal for r/w functions to be synchronous, so having an
     additional suffix for it looks redundant (contrariwise, we have
     _aio suffix for async functions)
   - _sync suffix in block layer is used when function does flush (so
     using it for other thing is confusing a bit)
   - keep function names short after adding nbd_ prefix

3. for nbd_wr_syncv let's use more common notation 'rw'

Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-Id: <20170602150150[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
block/nbd-client.c
include/block/nbd.h
nbd/client.c
nbd/common.c
nbd/nbd-internal.h
nbd/server.c
This page took 0.027276 seconds and 4 git commands to generate.