]> Git Repo - qemu.git/commit
block/file-posix: Fix laio_init() error handling crash bug
authorMarkus Armbruster <[email protected]>
Sat, 30 Nov 2019 19:42:22 +0000 (20:42 +0100)
committerMarkus Armbruster <[email protected]>
Mon, 2 Dec 2019 15:14:41 +0000 (16:14 +0100)
commitcb09104ea8418d9521d9a9d36ea0527b84ce51ac
tree09d8036107214761b51abffb302ce14b12cb8735
parent5a0948d36c4cbc1c5534afac6fee99de55245d12
block/file-posix: Fix laio_init() error handling crash bug

raw_aio_attach_aio_context() passes uninitialized Error *local_err by
reference to laio_init() via aio_setup_linux_aio().  When laio_init()
fails, it passes it on to error_setg_errno(), tripping error_setv()'s
assertion unless @local_err is null by dumb luck.

Fix by initializing @local_err properly.

Fixes: ed6e2161715c527330f936d44af4c547f25f687e
Cc: Nishanth Aravamudan <[email protected]>
Cc: Stefan Hajnoczi <[email protected]>
Cc: Kevin Wolf <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <20191130194240[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
block/file-posix.c
This page took 0.025133 seconds and 4 git commands to generate.