]> Git Repo - qemu.git/commit
thread-pool: add missing qemu_bh_cancel in completion function
authorPeter Lieven <[email protected]>
Thu, 16 Mar 2017 16:02:49 +0000 (17:02 +0100)
committerKevin Wolf <[email protected]>
Fri, 17 Mar 2017 11:54:21 +0000 (12:54 +0100)
commitb7a745dc33a18377bb4a8dfe54d1df01ea60bf66
tree9c74188a1a049f02e91512244913b85f7930df7f
parent8cd1a3e470212685bdd48ac03fdf9721dafc100b
thread-pool: add missing qemu_bh_cancel in completion function

commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations.

However, the rescheduling of the completion BH introcuded unnecessary spinning
in the main-loop. On very fast file backends this can even lead to the
"WARNING: I/O thread spun for 1000 iterations" message popping up.

Callgrind reports about 3-4% less instructions with this patch running
qemu-img bench on a ramdisk based VMDK file.

Fixes: 3c80ca158c96ff902a30883a8933e755988948b1
Cc: [email protected]
Signed-off-by: Peter Lieven <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
util/thread-pool.c
This page took 0.025568 seconds and 4 git commands to generate.