]> Git Repo - qemu.git/commit - hw/qdev-monitor.c
qdev: drop extra references at creation time
authorPaolo Bonzini <[email protected]>
Fri, 25 Jan 2013 13:12:37 +0000 (14:12 +0100)
committerAnthony Liguori <[email protected]>
Fri, 1 Feb 2013 21:53:11 +0000 (15:53 -0600)
commitb09995aef1d4a5879000a196a82e37b0511c8e03
tree5e9019b61486cb07a7707633f209fa630863dc7d
parentdc7389b79a15082fa4824bd3de966499f3b8cb2a
qdev: drop extra references at creation time

qdev_free and qbus_free have to do unparent+unref, because nobody else
drops the initial reference (the one included by object_initialize)
before them.

For device_init_func and do_device_add, this is trivially correct,
since the DeviceState goes out of scope.

For qdev_create, qdev_try_create and qbus_init, it is a bit more tricky.
What we are doing here is just assuming that the caller knows what it's
doing, and won't call qdev_free/qbus_free while the device is still there.
This is a pretty reasonable assumption and (behind the scenes) is also
what GObject/GTK does.  GTK actually has a "floating reference" that
goes away as soon as the caller does gtk_container_add or something
like that, but in the end qbus_init and qdev_try_create are already
adding the new object to its qdev parent!  So in the end the two solutions
are the same.

Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
hw/qdev-monitor.c
hw/qdev.c
vl.c
This page took 0.026519 seconds and 4 git commands to generate.